Re: [PATCH 10/12] s390: avoid __builtin_return_address(n) on clang

2019-04-10 Thread Martin Schwidefsky
On Mon, 8 Apr 2019 23:26:23 +0200 Arnd Bergmann wrote: > llvm on s390 has problems with __builtin_return_address(n), with n>0, > this results in a somewhat cryptic error message: > > fatal error: error in backend: Unsupported stack frame traversal count > > To work around it, use the direct re

Re: rseq/s390: choosing code signature

2019-04-10 Thread Martin Schwidefsky
On Wed, 10 Apr 2019 11:57:36 -0400 (EDT) Mathieu Desnoyers wrote: > - On Apr 10, 2019, at 11:52 AM, schwidefsky schwidef...@de.ibm.com wrote: > > > On Wed, 10 Apr 2019 11:50:39 -0400 (EDT) > > Mathieu Desnoyers wrote: > > > >> - On Apr 10, 2019, at 6:32 AM, schwidefsky schwidef...@de

Re: [PATCH 2/2] ftpm: firmware TPM running in TEE

2019-04-10 Thread Sasha Levin
On Wed, Apr 10, 2019 at 02:29:27PM +0300, Jarkko Sakkinen wrote: On Sat, Apr 06, 2019 at 11:30:47AM -0400, Sasha Levin wrote: On Wed, Apr 03, 2019 at 09:27:28PM +0300, Jarkko Sakkinen wrote: > On Wed, Apr 03, 2019 at 09:18:27PM +0300, Jarkko Sakkinen wrote: > > On Tue, Apr 02, 2019 at 03:33:16PM

Re: [PATCH v2] firmware: arm_scmi: Fix to replace of_match_device

2019-04-10 Thread Sudeep Holla
On Fri, Mar 22, 2019 at 04:55:03PM -0500, Aditya Pakki wrote: > of_match_device can return NULL if no matching device is found. > This patch replaces the function with of_device_get_match_data. > and returns -EINVAL in such a scenario. > > Signed-off-by: Aditya Pakki > > --- > v1: Replace of_match

Re: [PATCH v2] cpuset: restore sanity to cpuset_cpus_allowed_fallback()

2019-04-10 Thread Waiman Long
On 04/09/2019 04:40 PM, Joel Savitz wrote: > If a process is limited by taskset (i.e. cpuset) to only be allowed to > run on cpu N, and then cpu N is offlined via hotplug, the process will > be assigned the current value of its cpuset cgroup's effective_cpus field > in a call to do_set_cpus_allowed

Re: [PATCH 10/12] s390: avoid __builtin_return_address(n) on clang

2019-04-10 Thread Steven Rostedt
On Wed, 10 Apr 2019 18:03:57 +0200 Martin Schwidefsky wrote: > > --- a/arch/s390/include/asm/ftrace.h > > +++ b/arch/s390/include/asm/ftrace.h > > @@ -13,7 +13,12 @@ > > > > #ifndef __ASSEMBLY__ > > > > +#ifdef CONFIG_CC_IS_CLANG > > +/* https://bugs.llvm.org/show_bug.cgi?id=41424 */ > > +#def

[PATCH] regulator: hi6421: Convert to use simplified DT parsing

2019-04-10 Thread Axel Lin
Use regulator core's simplified DT parsing code to simply the driver implementation. Signed-off-by: Axel Lin --- drivers/regulator/hi6421-regulator.c | 208 ++- 1 file changed, 78 insertions(+), 130 deletions(-) diff --git a/drivers/regulator/hi6421-regulator.c b/driver

[PATCH 2/3] kbuild: Move stackleak config to Kconfig.hardening

2019-04-10 Thread Kees Cook
This moves the stackleak plugin options to Kconfig.hardening's memory initialization menu. Signed-off-by: Kees Cook --- scripts/gcc-plugins/Kconfig | 51 - security/Kconfig.hardening | 57 + 2 files changed, 57 insertions(+), 5

[PATCH 1/3] Kconfig: Create "kernel hardening" config area

2019-04-10 Thread Kees Cook
Right now kernel hardening options are scattered around various Kconfig files. This can be a central place to collect these kinds of options going forward. Signed-off-by: Kees Cook --- scripts/gcc-plugins/Kconfig | 70 ++- security/Kconfig| 2 + security/Kcon

[PATCH 3/3] kbuild: Implement Clang's stack initialization

2019-04-10 Thread Kees Cook
CONFIG_INIT_STACK_ALL turns on stack initialization based on -ftrivial-auto-var-init in Clang builds and on -fplugin-arg-structleak_plugin-byref-all in GCC builds. -ftrivial-auto-var-init is a Clang flag that provides trivial initializers for uninitialized local variables, variable fields and padd

[PATCH 0/3] Kconfig: Refactor memory initialization hardening

2019-04-10 Thread Kees Cook
This is a proposed alternative for the memory initialization series, which refactoring the existing gcc plugins into a separate Kconfig file and collects all the related options together with some more language to describe their differences. The last patch adds the Clang auto init option, as done b

Re: [PATCH] mtd: nand: Fix build error while CONFIG_MTD_NAND_ECC_SW_BCH is set to module

2019-04-10 Thread Miquel Raynal
Hi YueHaibing, YueHaibing wrote on Wed, 10 Apr 2019 23:03:24 +0800: > On 2019/4/10 22:29, Boris Brezillon wrote: > > On Wed, 10 Apr 2019 22:22:16 +0800 > > YueHaibing wrote: > > > >> On 2019/4/10 21:58, Boris Brezillon wrote: > >>> On Wed, 10 Apr 2019 15:39:28 +0200 > >>> Boris Brezillon

[PATCH] regulator: vexpress: Constify regulator_ops

2019-04-10 Thread Axel Lin
vexpress_regulator_ops_ro and vexpress_regulator_ops are never changed, make them const. Signed-off-by: Axel Lin --- drivers/regulator/vexpress-regulator.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/regulator/vexpress-regulator.c b/drivers/regulator/vexpress

Re: [PATCH 1/1] x86/entry/64: randomize kernel stack offset upon syscall

2019-04-10 Thread Kees Cook
On Wed, Apr 10, 2019 at 7:49 AM Andy Lutomirski wrote: > And build it like this, it fails: > > $ gcc -o ingo -g ingo.c -pie > /usr/bin/ld: /tmp/ccofYU9N.o: relocation R_X86_64_32 against `.rodata' > can not be used when making a PIE object; recompile with -fPIC > /usr/bin/ld: final link failed: no

Re: [PATCH] firmware: arm_scmi: check return value of idr_find

2019-04-10 Thread Sudeep Holla
On Fri, Mar 08, 2019 at 10:02:39PM -0600, Kangjie Lu wrote: > idr_find may return NULL, so check its return value and return an > error code. > I can't imagine a scenario leading to this. Steven has already explained why, so I won't repeat the same here. Did you hit this issue ? If so I would li

Re: [PATCH 1/2] module: Prepare for addition of new ro_after_init sections

2019-04-10 Thread Kees Cook
On Tue, Apr 9, 2019 at 6:14 PM Joel Fernandes (Google) wrote: > > For the purposes of hardening modules by adding sections to > ro_after_init sections, prepare for addition of new ro_after_init > entries which we do in future patches. Create a table to which new > entries could be added later. Thi

Re: [PATCH 02/12] s390: don't build vdso32 with clang

2019-04-10 Thread Nick Desaulniers
On Mon, Apr 8, 2019 at 2:27 PM Arnd Bergmann wrote: > > clang does not support 31 bit object files on s390, so skip > the 32-bit vdso here, and only build it when using gcc to compile > the kernel. What's the build failure? Would you mind filing a bug against LLVM's issue tracker for it, please?

[PATCH 00/22] watchdog: Expand use of device managed functions (series 3 of 3)

2019-04-10 Thread Guenter Roeck
Use device managed functions and other changes to simplify error handling, reduce source code size, improve readability, and reduce the likelyhood of bugs. The changes made in this series can be summarized to - Use devm_add_action_or_reset() for calls to clk_disable_unprepare - Use devm_watchdog_

[PATCH 03/22] watchdog: ts4800_wdt: Convert to use device managed functions and other improvements

2019-04-10 Thread Guenter Roeck
Use device managed functions to simplify error handling, reduce source code size, improve readability, and reduce the likelyhood of bugs. Other improvements as listed below. The conversion was done automatically with coccinelle using the following semantic patches. The semantic patches and the scr

[PATCH 13/22] watchdog: stm32_iwdg: Convert to use device managed functions and other improvements

2019-04-10 Thread Guenter Roeck
Use device managed functions to simplify error handling, reduce source code size, improve readability, and reduce the likelyhood of bugs. Other improvements as listed below. The conversion was done automatically with coccinelle using the following semantic patches. The semantic patches and the scr

[PATCH 20/22] watchdog: jz4740_wdt: Use 'dev' instead of dereferencing it repeatedly

2019-04-10 Thread Guenter Roeck
Introduce local variable 'struct device *dev' and use it instead of dereferencing it repeatedly. Also, there is no call to dev_get_drvdata() or platform_get_drvdata() in the driver, so drop the unnecessary call to platform_set_drvdata(). The conversion was done automatically with coccinelle using

[PATCH 21/22] watchdog: mpc8xxx_wdt: Convert to use device managed functions and other improvements

2019-04-10 Thread Guenter Roeck
Use device managed functions to simplify error handling, reduce source code size, improve readability, and reduce the likelyhood of bugs. Other improvements as listed below. The conversion was done automatically with coccinelle using the following semantic patches. The semantic patches and the scr

[PATCH 17/22] watchdog: loongson1_wdt: Convert to use device managed functions and other improvements

2019-04-10 Thread Guenter Roeck
Use device managed functions to simplify error handling, reduce source code size, improve readability, and reduce the likelyhood of bugs. Other improvements as listed below. The conversion was done automatically with coccinelle using the following semantic patches. The semantic patches and the scr

[PATCH 16/22] watchdog: pic32-wdt: Convert to use device managed functions and other improvements

2019-04-10 Thread Guenter Roeck
Use device managed functions to simplify error handling, reduce source code size, improve readability, and reduce the likelyhood of bugs. Other improvements as listed below. The conversion was done automatically with coccinelle using the following semantic patches. The semantic patches and the scr

[PATCH 22/22] watchdog: pnx4008_wdt: Convert to use device managed functions and other improvements

2019-04-10 Thread Guenter Roeck
Use device managed functions to simplify error handling, reduce source code size, improve readability, and reduce the likelyhood of bugs. Other improvements as listed below. The conversion was done automatically with coccinelle using the following semantic patches. The semantic patches and the scr

[PATCH 18/22] watchdog: mt7621_wdt: Use 'dev' instead of dereferencing it repeatedly

2019-04-10 Thread Guenter Roeck
Introduce local variable 'struct device *dev' and use it instead of dereferencing it repeatedly. The conversion was done automatically with coccinelle using the following semantic patches. The semantic patches and the scripts used to generate this commit log are available at https://github.com/gro

[PATCH 15/22] watchdog: pic32-dmt: Convert to use device managed functions and other improvements

2019-04-10 Thread Guenter Roeck
Use device managed functions to simplify error handling, reduce source code size, improve readability, and reduce the likelyhood of bugs. Other improvements as listed below. The conversion was done automatically with coccinelle using the following semantic patches. The semantic patches and the scr

[PATCH 19/22] watchdog: rt2880_wdt: Convert to use device managed functions and other improvements

2019-04-10 Thread Guenter Roeck
Use device managed functions to simplify error handling, reduce source code size, improve readability, and reduce the likelyhood of bugs. Other improvements as listed below. The conversion was done automatically with coccinelle using the following semantic patches. The semantic patches and the scr

[PATCH 10/22] watchdog: imx_sc_wdt: Use 'dev' instead of dereferencing it repeatedly

2019-04-10 Thread Guenter Roeck
Introduce local variable 'struct device *dev' and use it instead of dereferencing it repeatedly. The conversion was done automatically with coccinelle using the following semantic patches. The semantic patches and the scripts used to generate this commit log are available at https://github.com/gro

[PATCH 12/22] watchdog: zx2967_wdt: Convert to use device managed functions and other improvements

2019-04-10 Thread Guenter Roeck
Use device managed functions to simplify error handling, reduce source code size, improve readability, and reduce the likelyhood of bugs. Other improvements as listed below. The conversion was done automatically with coccinelle using the following semantic patches. The semantic patches and the scr

[PATCH 07/22] watchdog: wdat_wdt: Use 'dev' instead of dereferencing it repeatedly

2019-04-10 Thread Guenter Roeck
Introduce local variable 'struct device *dev' and use it instead of dereferencing it repeatedly. The conversion was done automatically with coccinelle using the following semantic patches. The semantic patches and the scripts used to generate this commit log are available at https://github.com/gro

[PATCH 01/22] watchdog: tegra_wdt: Use watchdog_stop_on_unregister and other improvements

2019-04-10 Thread Guenter Roeck
Use watchdog_stop_on_unregister() in probe instead of calling tegra_wdt_stop() in the remove function. Also introduce local variable 'struct device *dev' and use it instead of dereferencing it repeatedly. Finally, drop the now empty remove function. The conversion was done automatically with cocci

[PATCH 14/22] watchdog: ux500_wdt: Convert to use device managed functions and other improvements

2019-04-10 Thread Guenter Roeck
Use device managed functions to simplify error handling, reduce source code size, improve readability, and reduce the likelyhood of bugs. Other improvements as listed below. The conversion was done automatically with coccinelle using the following semantic patches. The semantic patches and the scr

[PATCH 04/22] watchdog: ts72xx_wdt: Use 'dev' instead of dereferencing it repeatedly

2019-04-10 Thread Guenter Roeck
Introduce local variable 'struct device *dev' and use it instead of dereferencing it repeatedly. The conversion was done automatically with coccinelle using the following semantic patches. The semantic patches and the scripts used to generate this commit log are available at https://github.com/gro

[PATCH 08/22] watchdog: wm831x_wdt: Use 'dev' instead of dereferencing it repeatedly

2019-04-10 Thread Guenter Roeck
Introduce local variable 'struct device *dev' and use it instead of dereferencing it repeatedly. The conversion was done automatically with coccinelle using the following semantic patches. The semantic patches and the scripts used to generate this commit log are available at https://github.com/gro

[PATCH 02/22] watchdog: tqmx86_wdt: Use 'dev' instead of dereferencing it repeatedly

2019-04-10 Thread Guenter Roeck
Introduce local variable 'struct device *dev' and use it instead of dereferencing it repeatedly. The conversion was done automatically with coccinelle using the following semantic patches. The semantic patches and the scripts used to generate this commit log are available at https://github.com/gro

[PATCH 06/22] watchdog: uniphier_wdt: drop platform_set_drvdata

2019-04-10 Thread Guenter Roeck
There is no call to dev_get_drvdata() or platform_get_drvdata() in the driver. Drop the unnecessary call to platform_set_drvdata(). The conversion was done automatically with coccinelle using the following semantic patches. The semantic patches and the scripts used to generate this commit log are

[PATCH 05/22] watchdog: twl4030_wdt: Convert to use device managed functions and other improvements

2019-04-10 Thread Guenter Roeck
Use device managed functions to simplify error handling, reduce source code size, improve readability, and reduce the likelyhood of bugs. Other improvements as listed below. The conversion was done automatically with coccinelle using the following semantic patches. The semantic patches and the scr

[PATCH 09/22] watchdog: xen_wdt: Use 'dev' instead of dereferencing it repeatedly

2019-04-10 Thread Guenter Roeck
Introduce local variable 'struct device *dev' and use it instead of dereferencing it repeatedly. The conversion was done automatically with coccinelle using the following semantic patches. The semantic patches and the scripts used to generate this commit log are available at https://github.com/gro

[PATCH 11/22] watchdog: sbsa_gwdt: Convert to use device managed functions and other improvements

2019-04-10 Thread Guenter Roeck
Use device managed functions to simplify error handling, reduce source code size, improve readability, and reduce the likelyhood of bugs. Other improvements as listed below. The conversion was done automatically with coccinelle using the following semantic patches. The semantic patches and the scr

Re: [PATCH] firmware: arm_scmi: check return value of idr_find

2019-04-10 Thread Sudeep Holla
On Mon, Mar 25, 2019 at 03:48:22PM -0500, Kangjie Lu wrote: You should mark this v2 id you changed any code or commit message or added any tags. Just FYI for future. > Thanks for Steven Price's review of this patch. In the current code, > idr_find won't return NULL because the SCMI_PROTOCOL_BASE

Re: [PATCH] regulator: vexpress: Constify regulator_ops

2019-04-10 Thread Sudeep Holla
On Thu, Apr 11, 2019 at 12:19:37AM +0800, Axel Lin wrote: > vexpress_regulator_ops_ro and vexpress_regulator_ops are never changed, > make them const. > Assuming Mark will pick up this as usual, Acked-by: Sudeep Holla -- Regards, Sudeep

Re: [PATCH 12/12] [PROBABLY WRONG] s390: void '0' constraint in inline assembly

2019-04-10 Thread Nick Desaulniers
On Wed, Apr 10, 2019 at 6:55 AM Martin Schwidefsky wrote: > > On Mon, 8 Apr 2019 23:26:25 +0200 > Arnd Bergmann wrote: > > > clang does not understand the contraint "0" in the CALL_ON_STACK() > > macro: > > > > ../arch/s390/mm/maccess.c:117:10: error: invalid input constraint '0' in asm > >

Re: [PATCH v5 1/3] Provide in-kernel headers to make extending kernel easier

2019-04-10 Thread Olof Johansson
On Wed, Apr 10, 2019 at 8:51 AM Joel Fernandes wrote: > > On Wed, Apr 10, 2019 at 11:07 AM Olof Johansson wrote: > [snip] > > > > Wouldn't it be more convenient to provide it in a standardized format > > > > such that you won't have to take an additional step, and always have > > > > This is that

Re: [PATCH -next] PCI: mvebu: Make mvebu_pci_bridge_emul_ops static

2019-04-10 Thread Thomas Petazzoni
On Wed, 10 Apr 2019 22:09:49 +0800 Yue Haibing wrote: > From: YueHaibing > > Fix sparse warning: > > drivers/pci/controller/pci-mvebu.c:557:28: warning: > symbol 'mvebu_pci_bridge_emul_ops' was not declared. Should it be static? > > Reported-by: Hulk Robot > Signed-off-by: YueHaibing Revi

Re: [PATCH 12/27] x86/pkru: Provide .*_pkru_ins() functions

2019-04-10 Thread Borislav Petkov
On Wed, Apr 03, 2019 at 06:41:41PM +0200, Sebastian Andrzej Siewior wrote: > Dave Hansen has asked for __read_pkru() and __write_pkru() to be symmetrical. > As part of the series __write_pkru() will read back the value and only write > it > if it is different. > In order to make both functions sym

RE: [PATCH RESEND 2/5] x86/MCE: Handle MCA controls in a per_cpu way

2019-04-10 Thread Ghannam, Yazen
> -Original Message- > From: Borislav Petkov > Sent: Tuesday, April 9, 2019 3:34 PM > To: Ghannam, Yazen > Cc: linux-e...@vger.kernel.org; linux-kernel@vger.kernel.org; > tony.l...@intel.com; x...@kernel.org > Subject: Re: [PATCH RESEND 2/5] x86/MCE: Handle MCA controls in a per_cpu way

Re: [PATCH RESEND 2/5] x86/MCE: Handle MCA controls in a per_cpu way

2019-04-10 Thread Borislav Petkov
On Wed, Apr 10, 2019 at 04:36:30PM +, Ghannam, Yazen wrote: > We have this case on AMD Family 17h with Bank 4. The hardware enforces > this bank to be Read-as-Zero/Writes-Ignored. > > This behavior is enforced whether the bank is in the middle or at the > end. Does num_banks contain the disabl

Re: [PATCH v3 1/7] clkdev: Hold clocks_mutex while iterating clocks list

2019-04-10 Thread Stephen Boyd
Quoting Russell King - ARM Linux admin (2019-04-09 01:57:17) > On Tue, Apr 09, 2019 at 05:31:48AM +, Vaittinen, Matti wrote: > > On Mon, 2019-04-08 at 23:21 +0100, Russell King - ARM Linux admin > > wrote: > > > On Mon, Apr 08, 2019 at 10:00:02AM -0700, Stephen Boyd wrote: > > > > > > > > > >

Re: [PATCH v3 3/7] clk: Add of_clk_hw_register() API for early clk drivers

2019-04-10 Thread Stephen Boyd
Quoting Jeffrey Hugo (2019-04-08 14:46:11) > On 4/4/2019 3:53 PM, Stephen Boyd wrote: > > In some circumstances drivers register clks early and don't have access > > to a struct device because the device model isn't initialized yet. Add > > an API to let drivers register clks associated with a stru

Re: [GIT PULL] apparmor regression fix for v5.1-rc5

2019-04-10 Thread pr-tracker-bot
The pull request you sent on Wed, 10 Apr 2019 04:32:14 -0700: > git://git.kernel.org/pub/scm/linux/kernel/git/jj/linux-apparmor > 5.1-regression-fix has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/ed79cc87302bf7fbc87f05d655b998f866b4fed8 Thank you! -- Deet-doot-dot,

Re: [PATCH-tip v2 06/12] locking/rwsem: Wake up almost all readers in wait queue

2019-04-10 Thread Davidlohr Bueso
On Fri, 05 Apr 2019, Waiman Long wrote: When the front of the wait queue is a reader, other readers immediately following the first reader will also be woken up at the same time. However, if there is a writer in between. Those readers behind the writer will not be woken up. Because of optimisti

Re: [PATCH v5 0/8] PCI: DWC/Keystone: MSI configuration cleanup

2019-04-10 Thread Lorenzo Pieralisi
On Thu, Mar 21, 2019 at 03:29:19PM +0530, Kishon Vijay Abraham I wrote: > This series tries to address the comments discussed in [1] w.r.t > removing Keystone specific callbacks defined in dw_pcie_host_ops. > > This series also tries to cleanup the Keystone interrupt handling > part. > > Changes

Re: [PATCH 20/22] watchdog: jz4740_wdt: Use 'dev' instead of dereferencing it repeatedly

2019-04-10 Thread Joe Perches
On Wed, 2019-04-10 at 09:28 -0700, Guenter Roeck wrote: > Introduce local variable 'struct device *dev' and use it instead of > dereferencing it repeatedly. Also, there is no call to dev_get_drvdata() > or platform_get_drvdata() in the driver, so drop the unnecessary > call to platform_set_drvdata(

Re: [PATCH 12/27] x86/pkru: Provide .*_pkru_ins() functions

2019-04-10 Thread Borislav Petkov
On Wed, Apr 10, 2019 at 06:36:15PM +0200, Borislav Petkov wrote: > Well, this is going in the wrong direction. The proper thing to do would > be to have: > > rdpkru() > wrpkru() > > which only do the inline asm with the respective opcodes. Just like > rdtsc(), clflush(), etc. IOW, like this: --

Re: [PATCH v3 3/7] clk: Add of_clk_hw_register() API for early clk drivers

2019-04-10 Thread Stephen Boyd
Quoting Jeffrey Hugo (2019-04-08 14:46:11) > On 4/4/2019 3:53 PM, Stephen Boyd wrote: > > In some circumstances drivers register clks early and don't have access > > to a struct device because the device model isn't initialized yet. Add > > an API to let drivers register clks associated with a stru

Re: [Qemu-devel] [PATCH v5 2/5] virtio-pmem: Add virtio pmem driver

2019-04-10 Thread Cornelia Huck
On Wed, 10 Apr 2019 12:46:12 -0400 "Michael S. Tsirkin" wrote: > On Wed, Apr 10, 2019 at 04:31:39PM +0200, Cornelia Huck wrote: > > On Wed, 10 Apr 2019 10:03:01 -0400 (EDT) > > Pankaj Gupta wrote: > > > > > > > > > > On Wed, Apr 10, 2019 at 09:38:22AM +0530, Pankaj Gupta wrote: > > > > >

RE: [PATCH RESEND 2/5] x86/MCE: Handle MCA controls in a per_cpu way

2019-04-10 Thread Ghannam, Yazen
> -Original Message- > From: Borislav Petkov > Sent: Wednesday, April 10, 2019 11:41 AM > To: Ghannam, Yazen > Cc: linux-e...@vger.kernel.org; linux-kernel@vger.kernel.org; > tony.l...@intel.com; x...@kernel.org > Subject: Re: [PATCH RESEND 2/5] x86/MCE: Handle MCA controls in a per_cpu

Re: [PATCH] clocksource/drivers/timer-ti-dm: Remove omap_dm_timer_set_load_start

2019-04-10 Thread Daniel Lezcano
Hi Tony, can you ask for an acked-by before pulling a patch in your tree? On 04/04/2019 16:17, Tony Lindgren wrote: > * Ladislav Michl [190327 08:12]: >> Hello Nathan, >> >> On Tue, Mar 26, 2019 at 10:01:27PM -0700, Nathan Chancellor wrote: >>> Commit 008258d995a6 ("clocksource/drivers/timer

Re: [PATCH v2 1/3] ftpm: dt-binding: add dts documentation for fTPM driver

2019-04-10 Thread Rob Herring
On Wed, Apr 10, 2019 at 11:19 AM Sasha Levin wrote: > > On Tue, Apr 09, 2019 at 04:18:29PM -0500, Rob Herring wrote: > >On Tue, Apr 9, 2019 at 1:50 PM Sasha Levin wrote: > >> > >> The parameters are similar to the ones used by IBM's vTPM and the > >> various I2C tpm drivers. > > > >Bindings descr

Re: [Freedreno] [PATCH] drm/msm/a6xx: Fix build with !CONFIG_DEBUG_FS

2019-04-10 Thread Jordan Crouse
On Thu, Apr 04, 2019 at 10:02:07AM +0800, YueHaibing wrote: > On 2019/4/3 23:36, Jordan Crouse wrote: > > On Wed, Apr 03, 2019 at 02:48:11PM +0800, Yue Haibing wrote: > >> From: YueHaibing > >> > >> When building CONFIG_DEBUG_FS is not set > >> gcc warn this: > >> > >> drivers/gpu/drm/msm/adreno/a

Re: [PATCH] mtd: nand: Fix build error while CONFIG_MTD_NAND_ECC_SW_BCH is set to module

2019-04-10 Thread Boris Brezillon
On Wed, 10 Apr 2019 18:18:43 +0200 Miquel Raynal wrote: > Hi YueHaibing, > > YueHaibing wrote on Wed, 10 Apr 2019 23:03:24 > +0800: > > > On 2019/4/10 22:29, Boris Brezillon wrote: > > > On Wed, 10 Apr 2019 22:22:16 +0800 > > > YueHaibing wrote: > > > > > >> On 2019/4/10 21:58, Boris B

Re: [PATCH-tip v2 06/12] locking/rwsem: Wake up almost all readers in wait queue

2019-04-10 Thread Waiman Long
On 04/10/2019 12:50 PM, Davidlohr Bueso wrote: > On Fri, 05 Apr 2019, Waiman Long wrote: > >> When the front of the wait queue is a reader, other readers >> immediately following the first reader will also be woken up at the >> same time. However, if there is a writer in between. Those readers >> b

[PATCH] genirq/devres: Use struct_size() in devm_kzalloc()

2019-04-10 Thread Gustavo A. R. Silva
One of the more common cases of allocation size calculations is finding the size of a structure that has a zero-sized array at the end, along with memory for some number of elements for that array. For example: struct foo { int stuff; struct boo entry[]; }; size = sizeof(struct foo) + cou

Re: [PATCH] KVM: x86: optimize check for valid PAT value

2019-04-10 Thread Paolo Bonzini
On 10/04/19 16:57, Sean Christopherson wrote: > On Wed, Apr 10, 2019 at 12:55:53PM +, David Laight wrote: >> From: Paolo Bonzini >>> Sent: 10 April 2019 10:55 >>> >>> This check will soon be done on every nested vmentry and vmexit, >>> "parallelize" it using bitwise operations. >>> >>> Signed-o

Re: [PATCH 1/3] RISC-V: Add separate defconfig for 32bit systems

2019-04-10 Thread Palmer Dabbelt
On Tue, 09 Apr 2019 23:09:03 PDT (-0700), a...@brainfault.org wrote: On Tue, Apr 9, 2019 at 10:14 PM Palmer Dabbelt wrote: On Tue, 12 Mar 2019 15:08:12 PDT (-0700), Anup Patel wrote: > This patch adds rv32_defconfig for 32bit systems. The only > difference between rv32_defconfig and defconfig

Re: [PATCH-tip v2 06/12] locking/rwsem: Wake up almost all readers in wait queue

2019-04-10 Thread Davidlohr Bueso
On Wed, 10 Apr 2019, Waiman Long wrote: There are 2 major reasons why there is a limit. 1) It will be unfair to the task that needs to spend so much of its own CPU time to wake up too many readers. This has never been a problem before. 2) I want to avoid the extreme case that there are more

Re: [PATCH RESEND 2/5] x86/MCE: Handle MCA controls in a per_cpu way

2019-04-10 Thread Borislav Petkov
On Wed, Apr 10, 2019 at 04:58:12PM +, Ghannam, Yazen wrote: > Yes, unused banks in the middle are counted in the MCG_CAP[Count] value. Good. > Okay, so you're saying the sysfs access should fail if a bank is > disabled. Is that correct? Well, think about it. If a bank is not operational for

Re: [PATCH] Yama: mark local symbols as static

2019-04-10 Thread James Morris
On Wed, 27 Mar 2019, Jann Horn wrote: > sparse complains that Yama defines functions and a variable as non-static > even though they don't exist in any header. Fix it by making them static. > > Signed-off-by: Jann Horn Applied to git://git.kernel.org/pub/scm/linux/kernel/git/jmorris/linux-secur

Re: [PATCH] security: don't use RCU accessors for cred->session_keyring

2019-04-10 Thread James Morris
On Wed, 27 Mar 2019, Jann Horn wrote: > sparse complains that a bunch of places in kernel/cred.c access > cred->session_keyring without the RCU helpers required by the __rcu > annotation. > > cred->session_keyring is written in the following places: > > - prepare_kernel_cred() [in a new cred st

Re: [PATCH] keys: safe concurrent user->{session,uid}_keyring access

2019-04-10 Thread James Morris
On Wed, 27 Mar 2019, Jann Horn wrote: > The current code can perform concurrent updates and reads on > user->session_keyring and user->uid_keyring. Add a comment to > struct user_struct to document the nontrivial locking semantics, and use > READ_ONCE() for unlocked readers and smp_store_release()

Re: [PATCH] lib/Kconfig.debug: Fix build error without CONFIG_BLOCK

2019-04-10 Thread Kees Cook
On Wed, Apr 10, 2019 at 12:55 AM Yue Haibing wrote: > > From: YueHaibing > > If CONFIG_TEST_KMOD is set to M, while CONFIG_BLOCK is not set, > XFS and BTRFS can not be compiled successly. > > Reported-by: Hulk Robot > Fixes: d9c6a72d6fa2 ("kmod: add test driver to stress test the module loader")

Re: [PATCH-tip v2 06/12] locking/rwsem: Wake up almost all readers in wait queue

2019-04-10 Thread Davidlohr Bueso
On Wed, 10 Apr 2019, Bueso wrote: On Wed, 10 Apr 2019, Waiman Long wrote: 2) I want to avoid the extreme case that there are more than 32k readers in the wait queue and make the count overflow. But in this case the readers are already on the queue. Never mind this. But the limit could stil

Re: [PATCH] security: inode: fix a missing check for securityfs_create_file

2019-04-10 Thread James Morris
On Fri, 15 Mar 2019, Kangjie Lu wrote: > securityfs_create_file may fail. The fix checks its status and > returns the error code upstream if it fails. > > Signed-off-by: Kangjie Lu > Applied to git://git.kernel.org/pub/scm/linux/kernel/git/jmorris/linux-security.git next-general > --- > Ret

Re: [PATCH] Yama: mark function as static

2019-04-10 Thread James Morris
On Wed, 27 Mar 2019, Mukesh Ojha wrote: > Sparse complains yama_task_prctl can be static. Fix it by making > it static. > > Signed-off-by: Mukesh Ojha Applied to git://git.kernel.org/pub/scm/linux/kernel/git/jmorris/linux-security.git next-general -- James Morris

Re: [PATCH 2/2] ftpm: firmware TPM running in TEE

2019-04-10 Thread Jarkko Sakkinen
On Wed, Apr 10, 2019 at 12:04:32PM -0400, Sasha Levin wrote: > On Wed, Apr 10, 2019 at 02:29:27PM +0300, Jarkko Sakkinen wrote: > > On Sat, Apr 06, 2019 at 11:30:47AM -0400, Sasha Levin wrote: > > > On Wed, Apr 03, 2019 at 09:27:28PM +0300, Jarkko Sakkinen wrote: > > > > On Wed, Apr 03, 2019 at 09:

[PATCH v3 0/2] cpufreq: Add sunxi nvmem based CPU scaling driver

2019-04-10 Thread Yangtao Li
Add sunxi nvmem based CPU scaling driver, refers to qcom-cpufreq-kryo. Yangtao Li (2): cpufreq: Add sunxi nvmem based CPU scaling driver dt-bindings: cpufreq: Document allwinner,cpu-operating-points-v2 .../bindings/opp/sunxi-nvmem-cpufreq.txt | 168 + MAINTAINERS

[PATCH v3 1/2] cpufreq: Add sunxi nvmem based CPU scaling driver

2019-04-10 Thread Yangtao Li
For some SoCs, the CPU frequency subset and voltage value of each OPP varies based on the silicon variant in use. The sunxi-cpufreq-nvmem driver reads the efuse value from the SoC to provide the OPP framework with required information. Signed-off-by: Yangtao Li --- MAINTAINERS

[PATCH v3 2/2] dt-bindings: cpufreq: Document allwinner,cpu-operating-points-v2

2019-04-10 Thread Yangtao Li
Allwinner Process Voltage Scaling Tables defines the voltage and frequency value based on the speedbin blown in the efuse combination. The sunxi-cpufreq-nvmem driver reads the efuse value from the SoC to provide the OPP framework with required information. This is used to determine the voltage and

[PATCH] platform/chrome: wilco_ec: Add h1_gpio status to debugfs

2019-04-10 Thread Nick Crews
As part of Chrome OS's FAFT (Fully Automated Firmware Testing) tests, we need to ensure that the H1 chip is properly setting some GPIO lines. The h1_gpio attribute exposes the state of the lines: - ENTRY_TO_FACT_MODE in BIT(0) - SPI_CHROME_SEL in BIT(1) There are two reasons that I am exposing thi

Re: [PATCH v2] cpuset: restore sanity to cpuset_cpus_allowed_fallback()

2019-04-10 Thread Phil Auld
On Tue, Apr 09, 2019 at 04:40:03PM -0400 Joel Savitz wrote: > If a process is limited by taskset (i.e. cpuset) to only be allowed to > run on cpu N, and then cpu N is offlined via hotplug, the process will > be assigned the current value of its cpuset cgroup's effective_cpus field > in a call to do

Re: [PATCH v2 1/2] cpufreq: Add sunxi nvmem based CPU scaling driver

2019-04-10 Thread Frank Lee
On Wed, Apr 10, 2019 at 11:24 AM Viresh Kumar wrote: > > On 09-04-19, 13:25, Yangtao Li wrote: > > +static const struct sunxi_cpufreq_soc_data sun50i_h6_data = { > > + .efuse_xlate = sun50i_efuse_xlate, > > + .nvmem_mask = 0x7, > > + .nvmem_shift = 5, > > +}; > > + > > +static const st

Re: [PULL -- 5.1 REGRESSION] Bluetooth: btusb: request wake pin with NOAUTOEN

2019-04-10 Thread Brian Norris
On Tue, Apr 9, 2019 at 8:43 PM Linus Torvalds wrote: > Either it's edge-triggered and you'll get one possibly spurious > interrupt for an old issue, or it's level-triggered and setting up the > hw should bring the irq line inactive and you'll be ok. I think our key difference here is in how much

Re: [PATCH 20/22] watchdog: jz4740_wdt: Use 'dev' instead of dereferencing it repeatedly

2019-04-10 Thread Guenter Roeck
Hi Joe, On Wed, Apr 10, 2019 at 09:52:09AM -0700, Joe Perches wrote: > On Wed, 2019-04-10 at 09:28 -0700, Guenter Roeck wrote: > > Introduce local variable 'struct device *dev' and use it instead of > > dereferencing it repeatedly. Also, there is no call to dev_get_drvdata() > > or platform_get_dr

Re: [PATCH 1/2] module: Prepare for addition of new ro_after_init sections

2019-04-10 Thread Joel Fernandes
On Wed, Apr 10, 2019 at 09:26:44AM -0700, Kees Cook wrote: > On Tue, Apr 9, 2019 at 6:14 PM Joel Fernandes (Google) > wrote: > > > > For the purposes of hardening modules by adding sections to > > ro_after_init sections, prepare for addition of new ro_after_init > > entries which we do in future p

Re: [PATCH v2 2/2] dt-bindings: cpufreq: Document operating-points-v2-sunxi-cpu

2019-04-10 Thread Frank Lee
On Wed, Apr 10, 2019 at 10:57 PM Maxime Ripard wrote: > > On Tue, Apr 09, 2019 at 01:25:58PM -0400, Yangtao Li wrote: > > Allwinner Process Voltage Scaling Tables defines the voltage and > > frequency value based on the speedbin blown in the efuse combination. > > The sunxi-cpufreq-nvmem driver r

Re: [PATCH-tip v2 06/12] locking/rwsem: Wake up almost all readers in wait queue

2019-04-10 Thread Waiman Long
On 04/10/2019 01:22 PM, Davidlohr Bueso wrote: > On Wed, 10 Apr 2019, Waiman Long wrote: >> There are 2 major reasons why there is a limit. >> >> 1) It will be unfair to the task that needs to spend so much of its own >> CPU time to wake up too many readers. > > This has never been a problem before

Re: [PATCH-tip v2 06/12] locking/rwsem: Wake up almost all readers in wait queue

2019-04-10 Thread Waiman Long
On 04/10/2019 01:31 PM, Davidlohr Bueso wrote: > On Wed, 10 Apr 2019, Bueso wrote: > >> On Wed, 10 Apr 2019, Waiman Long wrote: >>> 2) I want to avoid the extreme case that there are more than 32k >>> readers >>> in the wait queue and make the count overflow. >> >> But in this case the readers are

Re: 32-bit Amlogic (ARM) SoC: kernel BUG in kfree()

2019-04-10 Thread Martin Blumenstingl
Hi Liang, On Wed, Apr 10, 2019 at 1:08 PM Liang Yang wrote: > > Hi Martin, > > On 2019/4/5 12:30, Martin Blumenstingl wrote: > > Hi Liang, > > > > On Fri, Mar 29, 2019 at 8:44 AM Liang Yang wrote: > >> > >> Hi Martin, > >> > >> On 2019/3/29 2:03, Martin Blumenstingl wrote: > >>> Hi Liang, > >> [

Re: [PATCH v1 1/4] platform/x86: intel_pmc_ipc: Use BIT() macro

2019-04-10 Thread sathyanarayanan kuppuswamy
On 4/10/19 6:59 AM, Andy Shevchenko wrote: On Tue, Apr 09, 2019 at 08:39:39PM +0300, Andy Shevchenko wrote: On Tue, Apr 09, 2019 at 10:07:35AM -0700, sathyanarayanan kuppuswamy wrote: On 4/9/19 4:25 AM, Andy Shevchenko wrote: Use BIT() and BIT_MASK() macros for definitions. Looks good to me

Re: rseq/x86: choosing rseq code signature

2019-04-10 Thread Peter Zijlstra
On Wed, Apr 10, 2019 at 11:47:40AM -0400, Mathieu Desnoyers wrote: > - On Apr 10, 2019, at 2:54 AM, Peter Zijlstra pet...@infradead.org wrote: > > > On Tue, Apr 09, 2019 at 04:43:42PM -0400, Mathieu Desnoyers wrote: > >> +/* > >> + * RSEQ_SIG is used with the following privileged instructions,

Re: [v2 PATCH 4/4] phy: phy-meson-gxl-usb2: get optional clock by devm_clk_get_optional()

2019-04-10 Thread Martin Blumenstingl
On Wed, Apr 10, 2019 at 8:13 AM Chunfeng Yun wrote: > > Use devm_clk_get_optional() to get optional clock > > Cc: Martin Blumenstingl > Signed-off-by: Chunfeng Yun > Acked-by: Martin Blumenstingl now also: Tested-by: Martin Blumenstingl (on my Khadas VIM by manually adjusting meson-gxl.dtsi an

Re: [PATCH] security: inode: fix a missing check for securityfs_create_file

2019-04-10 Thread Al Viro
On Thu, Apr 11, 2019 at 03:34:43AM +1000, James Morris wrote: > On Fri, 15 Mar 2019, Kangjie Lu wrote: > > > securityfs_create_file may fail. The fix checks its status and > > returns the error code upstream if it fails. > > > > Signed-off-by: Kangjie Lu > > > > Applied to > git://git.kernel.

Re: [PATCH 1/2] mm/gup.c: fix the wrong comments

2019-04-10 Thread Ira Weiny
On Wed, Apr 10, 2019 at 09:20:36AM +0800, Huang Shijie wrote: > On Tue, Apr 09, 2019 at 02:55:31PM +, Weiny, Ira wrote: > > > On Tue, Apr 09, 2019 at 11:04:18AM +0800, Huang Shijie wrote: > > > > On Mon, Apr 08, 2019 at 07:49:29PM -0700, Matthew Wilcox wrote: > > > > > On Tue, Apr 09, 2019 at 0

Re: rseq/x86: choosing rseq code signature

2019-04-10 Thread Mathieu Desnoyers
- On Apr 10, 2019, at 1:57 PM, Peter Zijlstra pet...@infradead.org wrote: > On Wed, Apr 10, 2019 at 11:47:40AM -0400, Mathieu Desnoyers wrote: >> - On Apr 10, 2019, at 2:54 AM, Peter Zijlstra pet...@infradead.org wrote: >> >> > On Tue, Apr 09, 2019 at 04:43:42PM -0400, Mathieu Desnoyers w

Re: [PATCH v1 3/4] platform/x86: intel_pmc_ipc: Don't map non-used optional resources

2019-04-10 Thread sathyanarayanan kuppuswamy
Hi, On 4/9/19 4:25 AM, Andy Shevchenko wrote: The intel_pmc_ipc driver has a placeholder for all possible resources that may have been provided by ACPI. Since there are few optional ones, the driver still uses them and binds to wrong ranges in resource tree: # grep intel_punit_ipc /proc/iome

Re: [PATCH v1 4/4] platform/x86: intel_punit_ipc: Revert "Fix resource ioremap warning"

2019-04-10 Thread sathyanarayanan kuppuswamy
Hi, On 4/9/19 4:25 AM, Andy Shevchenko wrote: Since we have a proper fix for intel_pmc_ipc driver for resource management, get rid of unneeded commit in the intel_punit_ipc driver. This reverts commit 6cc8cbbc8868033f279b63e98b26b75eaa0006ab. Reviewed-by: Kuppuswamy Sathyanarayanan Signed-o

Re: [PATCH 1/2] mm/gup.c: fix the wrong comments

2019-04-10 Thread Ira Weiny
On Wed, Apr 10, 2019 at 09:18:50AM +0800, Huang Shijie wrote: > On Tue, Apr 09, 2019 at 01:23:16PM -0700, Ira Weiny wrote: > > On Tue, Apr 09, 2019 at 09:08:33AM +0800, Huang Shijie wrote: > > > On Mon, Apr 08, 2019 at 07:13:13AM -0700, Matthew Wilcox wrote: > > > > On Mon, Apr 08, 2019 at 10:37:45

[PATCH] uml: fix a boot splat wrt use of cpu_all_mask

2019-04-10 Thread Maciej Żenczykowski
From: Maciej Żenczykowski Memory: 509108K/542612K available (3835K kernel code, 919K rwdata, 1028K rodata, 129K init, 211K bss, 33504K reserved, 0K cma-reserved) NR_IRQS: 15 clocksource: timer: mask: 0x max_cycles: 0x1cd42e205, max_idle_ns: 881590404426 ns [ cut here

Re: KASAN: use-after-free Read in path_lookupat

2019-04-10 Thread Al Viro
On Tue, Mar 26, 2019 at 01:45:52AM +, Al Viro wrote: > On Mon, Mar 25, 2019 at 11:37:32PM +, Al Viro wrote: > > > For debugfs it's clearly "use default ->evict_inode(), have explicit > > ->destroy_inode() using free_inode_nonrcu()" - there we have nothing > > else done in ->evict_inode() a

<    1   2   3   4   5   6   7   8   9   >