Re: [PATCH V2 1/4] dt-bindings: memory: Renesas RPC-IF: Add support for RZ/G2 Series

2021-01-05 Thread Krzysztof Kozlowski
On Sat, Jan 02, 2021 at 05:54:09AM -0600, Adam Ford wrote: > The RZ/G2 Series has the RPC-IF interface. > Update bindings to support: r8a774a1, r8a774b1, r8a774c0, and r8a774e1 > > Signed-off-by: Adam Ford > --- > .../bindings/memory-controllers/renesas,rpc-if.yaml | 6 +- > 1 file

Re: [PATCH v12 3/5] memory: tegra124: Support interconnect framework

2021-01-05 Thread Krzysztof Kozlowski
On Mon, Dec 28, 2020 at 06:49:18PM +0300, Dmitry Osipenko wrote: > Now Internal and External memory controllers are memory interconnection > providers. This allows us to use interconnect API for tuning of memory > configuration. EMC driver now supports OPPs and DVFS. > > Tested-by: Nicolas

Re: [PATCH v12 2/5] memory: tegra124-emc: Continue probing if timings are missing in device-tree

2021-01-05 Thread Krzysztof Kozlowski
On Mon, Dec 28, 2020 at 06:49:17PM +0300, Dmitry Osipenko wrote: > EMC driver will become mandatory after turning it into interconnect > provider because interconnect users, like display controller driver, will > fail to probe using newer device-trees that have interconnect properties. > Thus make

Re: [PATCH v12 1/5] memory: tegra124-emc: Make driver modular

2021-01-05 Thread Krzysztof Kozlowski
On Mon, Dec 28, 2020 at 06:49:16PM +0300, Dmitry Osipenko wrote: > Add modularization support to the Tegra124 EMC driver, which now can be > compiled as a loadable kernel module. > > Note that EMC clock must be registered at clk-init time, otherwise PLLM > will be disabled as unused clock at boot

Re: [PATCH v6 2/8] regulator: dt-bindings: Document max8997-pmic nodes

2021-01-05 Thread Krzysztof Kozlowski
On Mon, Jan 04, 2021 at 09:24:49PM +, Mark Brown wrote: > On Mon, Jan 04, 2021 at 07:38:21PM +0100, Krzysztof Kozlowski wrote: > > On Mon, Jan 04, 2021 at 06:27:34PM +, Mark Brown wrote: > > > > We can indicate the presence of features without adding new compatible

Re: [PATCH] rtc: s5m: use devm_i2c_new_dummy_device()

2021-01-05 Thread Krzysztof Kozlowski
On Tue, Jan 05, 2021 at 02:44:24PM +0100, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > Use the managed variant of i2c_new_dummy_device() to shrink code and > remove the goto label. > > Signed-off-by: Bartosz Golaszewski > --- > drivers/rtc/rtc-s5m.c | 24

Re: [PATCH v6 2/8] regulator: dt-bindings: Document max8997-pmic nodes

2021-01-04 Thread Krzysztof Kozlowski
On Mon, Jan 04, 2021 at 06:27:34PM +, Mark Brown wrote: > On Mon, Jan 04, 2021 at 07:18:25PM +0100, Krzysztof Kozlowski wrote: > > On Mon, Jan 04, 2021 at 01:51:56PM +, Mark Brown wrote: > > > > > +- charger: Node for configuring the charger driver. > &

Re: [PATCH v6 2/8] regulator: dt-bindings: Document max8997-pmic nodes

2021-01-04 Thread Krzysztof Kozlowski
On Mon, Jan 04, 2021 at 01:51:56PM +, Mark Brown wrote: > On Wed, Dec 30, 2020 at 08:52:07PM +, Timon Baetz wrote: > > > +- charger: Node for configuring the charger driver. > > + Required properties: > > + - compatible: "maxim,max8997-battery" > > + Optional properties: > > + -

Re: [PATCH 25/31] memory: tegra30: convert to use devm_pm_opp_* API

2021-01-04 Thread Krzysztof Kozlowski
On Sun, Jan 03, 2021 at 03:54:15AM +, Yangtao Li wrote: > Use devm_pm_opp_* API to simplify code. > > Signed-off-by: Yangtao Li > --- > drivers/memory/tegra/tegra30-emc.c | 29 + > 1 file changed, 9 insertions(+), 20 deletions(-) Reviewed-by: K

Re: [PATCH 24/31] memory: tegra20: convert to use devm_pm_opp_* API

2021-01-04 Thread Krzysztof Kozlowski
On Fri, Jan 01, 2021 at 04:55:00PM +, Yangtao Li wrote: > Use devm_pm_opp_* API to simplify code. > > Signed-off-by: Yangtao Li > --- > drivers/memory/tegra/tegra20-emc.c | 29 + > 1 file changed, 9 insertions(+), 20 deletions(-) > R

Re: [PATCH 22/31] memory: samsung: exynos5422-dmc: fix return error in exynos5_init_freq_table

2021-01-04 Thread Krzysztof Kozlowski
On Fri, Jan 01, 2021 at 04:54:58PM +, Yangtao Li wrote: > We can't always return -EINVAL, let's fix it. > > Signed-off-by: Yangtao Li > --- > drivers/memory/samsung/exynos5422-dmc.c | 10 +++--- > 1 file changed, 7 insertions(+), 3 deletions(-) Reviewed-by: Krzysztof

Re: [PATCH 23/31] memory: samsung: exynos5422-dmc: convert to use devm_pm_opp_* API

2021-01-04 Thread Krzysztof Kozlowski
On Fri, Jan 01, 2021 at 04:54:59PM +, Yangtao Li wrote: > Use devm_pm_opp_* API to simplify code. > > Signed-off-by: Yangtao Li > --- > drivers/memory/samsung/exynos5422-dmc.c | 21 + > 1 file changed, 5 insertions(+), 16 deletions(-) Reviewed-by: K

Re: [PATCH v5 2/2] arm64: dts: imx8mm: Add Gateworks i.MX 8M Mini Development Kits

2021-01-04 Thread Krzysztof Kozlowski
mar in commit log (s/controll/control > s/comprised/consisting/) > - removed underscore from remaining node names > - removed blank line in hoggrp > - removed unused assigned-clocks and assigned-clock-rates node from usdhc > nodes > Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH v4 2/2] arm64: dts: imx8mm: Add Gateworks i.MX 8M Mini Development Kits

2021-01-04 Thread Krzysztof Kozlowski
On Wed, Dec 30, 2020 at 09:58:43AM -0800, Tim Harvey wrote: > The Gateworks Venice GW71xx-0x/GW72xx-0x/GW73xx-0x are development > kits comprised of a GW700x SoM and a Baseboard. Future SoM's such > as the GW701x will create additional combinations. > > The GW700x SoM contains: > - i.MX 8M Mini

Re: (subset) [PATCH -next] drivers: memory: Use DEFINE_SPINLOCK() for spinlock

2021-01-03 Thread Krzysztof Kozlowski
commit: bd96a89ca3fe874c98fe057cccb087603d76e5d4 Best regards, -- Krzysztof Kozlowski

Re: (subset) [PATCH v6 1/8] extcon: max8997: Add CHGINS and CHGRM interrupt handling

2021-01-03 Thread Krzysztof Kozlowski
commit: 3803f461bd28c1c817281348509399778633e82f Best regards, -- Krzysztof Kozlowski

Re: (subset) [PATCH v6 1/8] extcon: max8997: Add CHGINS and CHGRM interrupt handling

2021-01-03 Thread Krzysztof Kozlowski
commit: 4a928b3b7c0f8a2ae382c3db3a78898877567786 Best regards, -- Krzysztof Kozlowski

Re: [PATCH v2 2/4] soc: samsung: exynos-asv: handle reading revision register error

2021-01-03 Thread Krzysztof Kozlowski
On Mon, Dec 07, 2020 at 08:05:15PM +0100, Krzysztof Kozlowski wrote: > If regmap_read() fails, the product_id local variable will contain > random value from the stack. Do not try to parse such value and fail > the ASV driver probe. > > Fixes: 5ea428595cc5 ("soc: samsung:

Re: (subset) [PATCH v2 0/4] soc: samsung: exynos-chipid and asv improvements

2021-01-03 Thread Krzysztof Kozlowski
On Mon, 7 Dec 2020 20:05:13 +0100, Krzysztof Kozlowski wrote: > Changes since v1: > 1. Drop patch "soc: samsung: exynos-chipid: initialize later - with >arch_initcall" which is now superseded by convertin to a driver. > 2. Include Marek's patch, just for the referenc

Re: [PATCH v2 1/4] soc: samsung: exynos-asv: don't defer early on not-supported SoCs

2021-01-03 Thread Krzysztof Kozlowski
On Mon, Dec 07, 2020 at 08:05:14PM +0100, Krzysztof Kozlowski wrote: > From: Marek Szyprowski > > Check if the SoC is really supported before gathering the needed > resources. This fixes endless deferred probe on some SoCs other than > Exynos5422 (like Exynos5410). > > Fixe

Re: [PATCH v6 3/8] power: supply: max8997_charger: Set CHARGER current limit

2020-12-31 Thread Krzysztof Kozlowski
. > Add missing include. > Rename charger_data members. > Disable regulator on regulator_set_current_limit() failure. > Fix ret declaration. > Remove unneeded variables. > Don't dev_err() on deferral. > Get regulator and extcon from DTS. > Use dev

[PATCH] extcon: Add stubs for extcon_register_notifier_all() functions

2020-12-31 Thread Krzysztof Kozlowski
nitor all external connectors") Reported-by: kernel test robot Signed-off-by: Krzysztof Kozlowski --- include/linux/extcon.h | 23 +++ 1 file changed, 23 insertions(+) diff --git a/include/linux/extcon.h b/include/linux/extcon.h index fd183fb9c20f..0c19010da77f 100644 ---

Re: [PATCH v6 3/8] power: supply: max8997_charger: Set CHARGER current limit

2020-12-31 Thread Krzysztof Kozlowski
On Thu, Dec 31, 2020 at 07:19:07AM +, Timon Baetz wrote: > On Thu, 31 Dec 2020 07:22:22 +0800, kernel test robot wrote: > > Hi Timon, > > > > Thank you for the patch! Yet something to improve: > > > > [auto build test ERROR on regulator/for-next] > > [also build test ERROR on

Re: [PATCH v5 1/8] extcon: max8997: Add CHGINS and CHGRM interrupt handling

2020-12-30 Thread Krzysztof Kozlowski
On Mon, Dec 28, 2020 at 11:35:38AM +, Timon Baetz wrote: > This allows the MAX8997 charger to set the current limit depending on > the detected extcon charger type. > > Signed-off-by: Timon Baetz > --- > drivers/extcon/extcon-max8997.c | 4 > 1 file changed, 4 insertions(+) It's

Re: [PATCH v5 3/8] power: supply: max8997_charger: Set CHARGER current limit

2020-12-30 Thread Krzysztof Kozlowski
On Mon, Dec 28, 2020 at 11:36:02AM +, Timon Baetz wrote: > Register for extcon notification and set charging current depending on > the detected cable type. Current values are taken from vendor kernel, > where most charger types end up setting 650mA [0]. > > Also enable and disable the

Re: [PATCH v3 2/2] arm64: dts: imx8mm: Add Gateworks i.MX 8M Mini Development Kits

2020-12-30 Thread Krzysztof Kozlowski
On Mon, Dec 28, 2020 at 04:21:17PM -0800, Tim Harvey wrote: > The Gateworks Venice GW71xx-0x/GW72xx-0x/GW73xx-0x are development > kits comprised of a GW700x SoM and a Baseboard. Future SoM's such > as the GW701x will create additional combinations. > > The GW700x SoM contains: > - i.MX 8M Mini

Re: [PATCH 3/4] arm64: dts: imx8mn: add spba bus node

2020-12-29 Thread Krzysztof Kozlowski
On Tue, Dec 29, 2020 at 08:00:44PM +0800, peng@nxp.com wrote: > From: Peng Fan > > According to RM, there is a spba bus inside aips3 and aips1, add it. This does not look like matching contents of commit. Best regards, Krzysztof > > Signed-off-by: Peng Fan > --- >

Re: [PATCH 2/4] arm64: dts: imx8mn: add spba bus node

2020-12-29 Thread Krzysztof Kozlowski
On Tue, Dec 29, 2020 at 06:26:41AM -0600, Adam Ford wrote: > On Tue, Dec 29, 2020 at 6:15 AM wrote: > > > > From: Peng Fan > > > > According to RM, there is a spba bus inside aips3 and aips1, add it. > > > > Signed-off-by: Peng Fan > > --- > > arch/arm64/boot/dts/freescale/imx8mm.dtsi | 362

Re: [PATCH 1/9] ARM: dts: exynos: correct PMIC interrupt trigger level on Artik 5

2020-12-29 Thread Krzysztof Kozlowski
On Thu, 10 Dec 2020 22:28:55 +0100, Krzysztof Kozlowski wrote: > The Samsung PMIC datasheets describe the interrupt line as active low > with a requirement of acknowledge from the CPU. Without specifying the > interrupt type in Devicetree, kernel might apply some fixed > c

Re: (subset) [PATCH] arm64: dts: exynos: correct S3FWRN5 NFC interrupt trigger level on TM2

2020-12-29 Thread Krzysztof Kozlowski
On Thu, 10 Dec 2020 22:18:58 +0100, Krzysztof Kozlowski wrote: > The S3FWRN5 datasheet describe the interrupt line as rising edge. The > current configuration as level high, could cause spurious interrupts. Applied, thanks! [1/1] arm64: dts: exynos: correct S3FWRN5 NFC interrupt trigger

Re: (subset) [PATCH 0/2] Fix USB2 PHY operation on Exynos542x

2020-12-29 Thread Krzysztof Kozlowski
Y operation, what caused the suspend failure. Fix this by learning > the Exynos USB2 PHY driver about the Exynos5420 variant. > > [...] Applied, thanks! [2/2] ARM: dts: exynos: use Exynos5420 dedicated USB2 PHY compatible commit: 75681980c4e3d89c55b5b8f20b8f4c1aace601be Best regards, -- Krzysztof Kozlowski

Re: [PATCH 03/18] ARM: dts: exynos: correct fuel gauge interrupt trigger level on Midas family

2020-12-29 Thread Krzysztof Kozlowski
On Thu, Dec 10, 2020 at 10:25:19PM +0100, Krzysztof Kozlowski wrote: > The Maxim fuel gauge datasheets describe the interrupt line as active > low with a requirement of acknowledge from the CPU. The falling edge > interrupt will mostly work but it's not correct. > > Fixes: e86

Re: [PATCH 2/2] ARM: dts: exynos: use Exynos5420 dedicated USB2 PHY compatible

2020-12-29 Thread Krzysztof Kozlowski
On Fri, Nov 20, 2020 at 12:07:44PM +0100, Marek Szyprowski wrote: > Hi Krzysztof, > > On 20.11.2020 12:05, Krzysztof Kozlowski wrote: > > On Fri, Nov 20, 2020 at 09:56:37AM +0100, Marek Szyprowski wrote: > >> USB2.0 PHY in Exynos5420 differs from Exynos5250 variant a bit,

Re: [PATCH 2/2] arm64: dts: imx8mm: Add Gateworks IMX8MM Development Kits

2020-12-28 Thread Krzysztof Kozlowski
On Mon, Dec 28, 2020 at 11:02:40AM -0800, Tim Harvey wrote: > > + > > > + { > > > + clock-frequency = <10>; > > > + pinctrl-names = "default"; > > > + pinctrl-0 = <_i2c1>; > > > + status = "okay"; > > > + > > > + gsc: gsc@20 { > > > > Node name should describe class of a

Re: [PATCH v4 4/7] power: supply: max8997_charger: Set CHARGER current limit

2020-12-28 Thread Krzysztof Kozlowski
On Fri, Dec 25, 2020 at 11:33:21AM +, Timon Baetz wrote: > On Thu, 24 Dec 2020 15:00:38 +0100, Krzysztof Kozlowski wrote: > > On Thu, Dec 24, 2020 at 02:37:06PM +0100, Krzysztof Kozlowski wrote: > > > On Thu, Dec 24, 2020 at 01:13:02PM +, Timon Baetz wrote: > > &g

Re: [PATCH v3 4/6] arm64: dts: imx8mm: Add Engicam i.Core MX8M Mini C.TOUCH 2.0

2020-12-28 Thread Krzysztof Kozlowski
On Mon, 28 Dec 2020 at 09:21, Jagan Teki wrote: > > > #include "imx8mm.dtsi" > > > #include "imx8mm-beacon-som.dtsi" > > > #include "imx8mm-beacon-baseboard.dtsi" > > > > > > (SoC dtsi, SoM dtsi, Carrier board dtsi) > > > > > > > design which makes any sense. We do not create empty DTS files

[PATCH] ath9k: Add separate entry for LED triggers to fix module builds

2020-12-27 Thread Krzysztof Kozlowski
_CLASS can only be a module if ath9k driver is a module as well. Reported-by: kernel test robot Fixes: 72cdab808714 ("ath9k: Do not select MAC80211_LEDS by default") Signed-off-by: Krzysztof Kozlowski --- drivers/net/wireless/ath/ath9k/Kconfig| 18 -- drivers/ne

Re: [PATCH v4 4/7] power: supply: max8997_charger: Set CHARGER current limit

2020-12-24 Thread Krzysztof Kozlowski
On Thu, Dec 24, 2020 at 02:37:06PM +0100, Krzysztof Kozlowski wrote: > On Thu, Dec 24, 2020 at 01:13:02PM +, Timon Baetz wrote: > > On Thu, 24 Dec 2020 10:55:59 +0100, Krzysztof Kozlowski wrote: > > > > @@ -170,6 +237,28 @@ static int max8997_battery_probe(struct > >

Re: [PATCH v4 4/7] power: supply: max8997_charger: Set CHARGER current limit

2020-12-24 Thread Krzysztof Kozlowski
On Thu, Dec 24, 2020 at 01:13:02PM +, Timon Baetz wrote: > On Thu, 24 Dec 2020 10:55:59 +0100, Krzysztof Kozlowski wrote: > > On Wed, Dec 23, 2020 at 01:43:05PM +, Timon Baetz wrote: > > > Register for extcon notification and set charging current depending on > > &

Re: [PATCH 2/2] arm64: dts: imx8mm: Add Gateworks IMX8MM Development Kits

2020-12-24 Thread Krzysztof Kozlowski
On Wed, Dec 23, 2020 at 02:23:16PM -0800, Tim Harvey wrote: > The Gateworks Venice GW71xx-0x/GW72xx-0x/GW73xx-0x are development > kits comprised of a GW700x SoM and a Baseboard. > > The GW700x SoM contains: > - IMX8MM SoC > - LPDDR4 DRAM > - eMMC FLASH > - Gateworks System Controller

Re: [PATCH 2/2] arm64: dts: imx8mm: Add Gateworks IMX8MM Development Kits

2020-12-24 Thread Krzysztof Kozlowski
On Wed, Dec 23, 2020 at 02:23:16PM -0800, Tim Harvey wrote: > The Gateworks Venice GW71xx-0x/GW72xx-0x/GW73xx-0x are development > kits comprised of a GW700x SoM and a Baseboard. > > The GW700x SoM contains: > - IMX8MM SoC It's i.MX 8M Mini.

Re: [PATCH 1/2] dt-bindings: arm: fsl: Add binding for Gateworks boards with IMX8MM

2020-12-24 Thread Krzysztof Kozlowski
On Wed, Dec 23, 2020 at 02:23:15PM -0800, Tim Harvey wrote: > Add bindings for the Gateworks Venice Development kit boards with > IMX8MM System on Module. > > Signed-off-by: Tim Harvey > --- > Documentation/devicetree/bindings/arm/fsl.yaml | 3 +++ > 1 file changed, 3 insertions(+) > > diff

Re: [PATCH v3 4/6] arm64: dts: imx8mm: Add Engicam i.Core MX8M Mini C.TOUCH 2.0

2020-12-24 Thread Krzysztof Kozlowski
On Thu, 24 Dec 2020 at 11:08, Jagan Teki wrote: > > On Thu, Dec 24, 2020 at 2:48 PM Krzysztof Kozlowski wrote: > > > > On Wed, 23 Dec 2020 at 13:07, Jagan Teki wrote: > > > > > > On Wed, Dec 23, 2020 at 5:29 PM Krzysztof Kozlowski > > > wrote:

Re: [PATCH v4 4/7] power: supply: max8997_charger: Set CHARGER current limit

2020-12-24 Thread Krzysztof Kozlowski
On Wed, Dec 23, 2020 at 01:43:05PM +, Timon Baetz wrote: > Register for extcon notification and set charging current depending on > the detected cable type. Current values are taken from vendor kernel, > where most charger types end up setting 650mA [0]. > > Also enable and disable the

Re: [PATCH v4 2/7] regulator: dt-bindings: Document max8997-pmic nodes

2020-12-24 Thread Krzysztof Kozlowski
On Wed, Dec 23, 2020 at 01:42:43PM +, Timon Baetz wrote: > Add maxim,max8997-battery and maxim,max8997-muic optional nodes. > > Signed-off-by: Timon Baetz I already acked this, why did you skip my tag? Best regards, Krzysztof > --- > .../bindings/regulator/max8997-regulator.txt

Re: [PATCH v3 4/6] arm64: dts: imx8mm: Add Engicam i.Core MX8M Mini C.TOUCH 2.0

2020-12-24 Thread Krzysztof Kozlowski
On Wed, 23 Dec 2020 at 13:07, Jagan Teki wrote: > > On Wed, Dec 23, 2020 at 5:29 PM Krzysztof Kozlowski wrote: > > > > On Wed, Dec 23, 2020 at 04:33:41PM +0530, Jagan Teki wrote: > > > Engicam C.TOUCH 2.0 is an EDIMM compliant general purpose Carrier > > >

Re: [PATCH v3 4/6] arm64: dts: imx8mm: Add Engicam i.Core MX8M Mini C.TOUCH 2.0

2020-12-23 Thread Krzysztof Kozlowski
On Wed, Dec 23, 2020 at 04:33:41PM +0530, Jagan Teki wrote: > Engicam C.TOUCH 2.0 is an EDIMM compliant general purpose Carrier > board. > > Genaral features: > - Ethernet 10/100 > - Wifi/BT > - USB Type A/OTG > - Audio Out > - CAN > - LVDS panel connector > > i.Core MX8M Mini is an EDIMM SoM

Re: [PATCH v3 3/6] arm64: dts: imx8mm: Add Engicam i.Core MX8M Mini SoM

2020-12-23 Thread Krzysztof Kozlowski
tions. > > .../dts/freescale/imx8mm-icore-mx8mm.dtsi | 232 ++ > 1 file changed, 232 insertions(+) > create mode 100644 arch/arm64/boot/dts/freescale/imx8mm-icore-mx8mm.dtsi Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH v3 2/6] dt-bindings: arm: fsl: Add Engicam i.Core MX8M Mini C.TOUCH 2.0

2020-12-23 Thread Krzysztof Kozlowski
this Carrier board for > creating complete i.Core MX8M Mini C.TOUCH 2.0 board. > > Add bindings for it. > > Signed-off-by: Jagan Teki > --- > Changes for v3: > - add proper bindings > Changes for v2: > - updated commit message > Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH v2 3/4] arm64: dts: imx8mq-librem5: Move usdhc clocks assignment to board DT

2020-12-23 Thread Krzysztof Kozlowski
dts: imx8mq: Move usdhc clocks assignment to > board DT") > Signed-off-by: Martin Kepplinger > --- > arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi | 4 > 1 file changed, 4 insertions(+) Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH v2 2/4] arm64: dts: imx8mq-librem5: add pinctrl for the touchscreen description

2020-12-23 Thread Krzysztof Kozlowski
he Librem 5 phone") > Signed-off-by: Martin Kepplinger > --- > arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi | 9 + > 1 file changed, 9 insertions(+) > Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH v3 4/7] power: supply: max8997_charger: Set CHARGER current limit

2020-12-23 Thread Krzysztof Kozlowski
On Wed, Dec 23, 2020 at 08:09:55AM +, Timon Baetz wrote: > On Tue, 22 Dec 2020 09:40:04 +0100, Krzysztof Kozlowski wrote: (...) > > > .name = "max8997_pmic", > > > .type = POWER_SUPPLY_TYPE_BATTERY, > > > @@ -170,6 +237,33 @@

Re: [PATCH v2 2/6] dt-bindings: arm: fsl: Add Engicam i.Core MX8M Mini C.TOUCH 2.0

2020-12-22 Thread Krzysztof Kozlowski
On Tue, Dec 22, 2020 at 09:25:40PM +0100, Krzysztof Kozlowski wrote: > On Tue, 22 Dec 2020 at 19:28, Jagan Teki wrote: > > > > On Mon, Dec 21, 2020 at 8:17 PM Jagan Teki > > wrote: > > > > > > On Mon, Dec 21, 2020 at 8:12 PM Krzysztof Kozlowski >

Re: [PATCH v2 2/6] dt-bindings: arm: fsl: Add Engicam i.Core MX8M Mini C.TOUCH 2.0

2020-12-22 Thread Krzysztof Kozlowski
On Tue, 22 Dec 2020 at 19:28, Jagan Teki wrote: > > On Mon, Dec 21, 2020 at 8:17 PM Jagan Teki wrote: > > > > On Mon, Dec 21, 2020 at 8:12 PM Krzysztof Kozlowski wrote: > > > > > > On Mon, Dec 21, 2020 at 08:09:47PM +0530, Jagan Teki wrote: > > >

Re: [PATCH v2 6/6] arm64: dts: imx8mm: Add Engicam i.Core MX8M Mini EDIMM2.2 Starter Kit

2020-12-22 Thread Krzysztof Kozlowski
On Tue, Dec 22, 2020 at 02:20:55PM +0530, Jagan Teki wrote: > On Tue, Dec 22, 2020 at 2:36 AM Krzysztof Kozlowski wrote: > > > > On Tue, Dec 22, 2020 at 01:03:07AM +0530, Jagan Teki wrote: > > > On Mon, Dec 21, 2020 at 7:36 PM Krzysztof Kozlowski > > > wrot

Re: [PATCH v3 4/7] power: supply: max8997_charger: Set CHARGER current limit

2020-12-22 Thread Krzysztof Kozlowski
On Tue, Dec 22, 2020 at 07:31:40AM +, Timon Baetz wrote: > Register for extcon notification and set charging current depending on > the detected cable type. Current values are taken from vendor kernel, > where most charger types end up setting 650mA [0]. > > Also enable and disable the

Re: [PATCH v3 3/7] mfd: max8997: Add of_compatible to extcon and charger mfd_cell

2020-12-22 Thread Krzysztof Kozlowski
er. > > Signed-off-by: Timon Baetz > --- > drivers/mfd/max8997.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH v3 2/7] regulator: dt-bindings: Document max8997-pmic nodes

2020-12-22 Thread Krzysztof Kozlowski
tions(+) > Acked-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH v9 1/4] dt-bindings: soc: imx8m: add DT Binding doc for soc unique ID

2020-12-22 Thread Krzysztof Kozlowski
sure it is right > Changes for v2: > - remove the subject prefix "LF-2571-1" > > .../bindings/soc/imx/imx8m-soc.yaml | 86 +++ > 1 file changed, 86 insertions(+) > create mode 100644 Documentation/devicetree/bindings/soc/imx/imx8m-soc.yaml > Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH v2 6/6] arm64: dts: imx8mm: Add Engicam i.Core MX8M Mini EDIMM2.2 Starter Kit

2020-12-21 Thread Krzysztof Kozlowski
On Tue, Dec 22, 2020 at 01:03:07AM +0530, Jagan Teki wrote: > On Mon, Dec 21, 2020 at 7:36 PM Krzysztof Kozlowski wrote: > > > > On Mon, Dec 21, 2020 at 05:01:51PM +0530, Jagan Teki wrote: > > > Engicam EDIMM2.2 Starter Kit is an EDIMM 2.2 Form Factor Capacitiv

Re: [PATCH v2 16/18] arm64: dts: hi3660: Harmonize DWC USB3 DT nodes name

2020-12-21 Thread Krzysztof Kozlowski
On Mon, Dec 21, 2020 at 12:24:11PM -0800, John Stultz wrote: > On Sat, Dec 19, 2020 at 3:06 AM Krzysztof Kozlowski wrote: > > On Fri, Dec 18, 2020 at 09:11:42PM -0800, John Stultz wrote: > > > On Wed, Nov 11, 2020 at 1:22 AM Serge Semin > > > wrote: > > >

Re: [PATCH v2 2/6] power: supply: max8997_charger: Set CHARGER current limit

2020-12-21 Thread Krzysztof Kozlowski
On Mon, Dec 21, 2020 at 03:35:07PM +, Timon Baetz wrote: > On Mon, 21 Dec 2020 15:16:27 +0100, Krzysztof Kozlowski wrote: > > On Mon, Dec 21, 2020 at 09:53:15AM +, Timon Baetz wrote: > > > Register for extcon notification and set charging current depending on > > &

Re: [PATCH v2 2/6] dt-bindings: arm: fsl: Add Engicam i.Core MX8M Mini C.TOUCH 2.0

2020-12-21 Thread Krzysztof Kozlowski
On Mon, Dec 21, 2020 at 08:09:47PM +0530, Jagan Teki wrote: > On Mon, Dec 21, 2020 at 7:35 PM Krzysztof Kozlowski wrote: > > > > On Mon, Dec 21, 2020 at 07:29:22PM +0530, Jagan Teki wrote: > > > On Mon, Dec 21, 2020 at 7:16 PM Krzysztof Kozlowski > > > wrot

Re: [PATCH v2 6/6] regulator: dt-bindings: Document max8997-pmic nodes

2020-12-21 Thread Krzysztof Kozlowski
On Mon, Dec 21, 2020 at 09:53:41AM +, Timon Baetz wrote: > Add maxim,max8997-battery and maxim,max8997-muic optional nodes. > > Signed-off-by: Timon Baetz > --- > .../bindings/regulator/max8997-regulator.txt | 11 +++ > 1 file changed, 11 insertions(+) I see you updated

Re: [PATCH v2 5/6] ARM: dts: exynos: Added top-off charging regulator node for i9100

2020-12-21 Thread Krzysztof Kozlowski
On Mon, Dec 21, 2020 at 09:53:35AM +, Timon Baetz wrote: > Value taken from Galaxy S2 vendor kernel [0] which always sets 200mA. Subject: "Add", not "Added", as in Linux coding style. > > Also rearrange regulators based on definition in max8997.h. > > [0] >

Re: [PATCH v2 4/6] ARM: dts: exynos: Added muic and charger nodes for i9100

2020-12-21 Thread Krzysztof Kozlowski
On Mon, Dec 21, 2020 at 09:53:28AM +, Timon Baetz wrote: > muic node is only used for extcon consumers. > charger node is used to specify muic and regulator. > > Signed-off-by: Timon Baetz > --- > arch/arm/boot/dts/exynos4210-i9100.dts | 10 ++ > 1 file changed, 10 insertions(+)

Re: [PATCH v2 3/6] ARM: dts: exynos: Fix charging regulator voltage and current for i9100

2020-12-21 Thread Krzysztof Kozlowski
On Mon, Dec 21, 2020 at 09:53:22AM +, Timon Baetz wrote: > Set CHARGER current and CHARGER_CV voltage according to Galaxy S2 vendor > sources [0,1]. Mention that the vendor sources are for Galaxy S2 Epic 4G Touch SPH-D710 Android. This seems to depend on driver changes, so it will have to

Re: [PATCH v2 2/6] power: supply: max8997_charger: Set CHARGER current limit

2020-12-21 Thread Krzysztof Kozlowski
On Mon, Dec 21, 2020 at 09:53:15AM +, Timon Baetz wrote: > Register for extcon notification and set charging current depending on > the detected cable type. Current values are taken from vendor kernel, > where most charger types end up setting 650mA [0]. > > Also enable and disable the

Re: [PATCH v2 1/6] extcon: max8997: Add CHGINS and CHGRM interrupt handling

2020-12-21 Thread Krzysztof Kozlowski
On Mon, Dec 21, 2020 at 09:53:08AM +, Timon Baetz wrote: > This allows the MAX8997 charger to set the current limit depending on > the detected extcon charger type. > > Signed-off-by: Timon Baetz Don't do this: In-Reply-To: <20201202203516.43053-1-timon.ba...@protonmail.com> It's a

Re: [PATCH v2 6/6] arm64: dts: imx8mm: Add Engicam i.Core MX8M Mini EDIMM2.2 Starter Kit

2020-12-21 Thread Krzysztof Kozlowski
On Mon, Dec 21, 2020 at 05:01:51PM +0530, Jagan Teki wrote: > Engicam EDIMM2.2 Starter Kit is an EDIMM 2.2 Form Factor Capacitive > Evaluation Board. > > Genaral features: > - LCD 7" C.Touch > - microSD slot > - Ethernet 1Gb > - Wifi/BT > - 2x LVDS Full HD interfaces > - 3x USB 2.0 > - 1x USB 3.0

Re: [PATCH v2 2/6] dt-bindings: arm: fsl: Add Engicam i.Core MX8M Mini C.TOUCH 2.0

2020-12-21 Thread Krzysztof Kozlowski
On Mon, Dec 21, 2020 at 07:29:22PM +0530, Jagan Teki wrote: > On Mon, Dec 21, 2020 at 7:16 PM Krzysztof Kozlowski wrote: > > > > On Mon, Dec 21, 2020 at 05:01:47PM +0530, Jagan Teki wrote: > > > i.Core MX8M Mini is an EDIMM SoM based on NXP i.MX8M Mini from Engicam.

Re: [PATCH v2 4/6] arm64: dts: imx8mm: Add Engicam i.Core MX8M Mini C.TOUCH 2.0

2020-12-21 Thread Krzysztof Kozlowski
On Mon, Dec 21, 2020 at 05:01:49PM +0530, Jagan Teki wrote: > Engicam C.TOUCH 2.0 is an EDIMM compliant general purpose Carrier > board. > > Genaral features: > - Ethernet 10/100 > - Wifi/BT > - USB Type A/OTG > - Audio Out > - CAN > - LVDS panel connector > > i.Core MX8M Mini is an EDIMM SoM

Re: [PATCH v2 3/6] arm64: dts: imx8mm: Add Engicam i.Core MX8M Mini SoM

2020-12-21 Thread Krzysztof Kozlowski
On Mon, Dec 21, 2020 at 05:01:48PM +0530, Jagan Teki wrote: > i.Core MX8M Mini is an EDIMM SoM based on NXP i.MX8M Mini > from Engicam. > > General features: > - NXP i.MX8M Mini > - Up to 2GB LDDR4 > - 8/16GB eMMC > - Gigabit Ethernet > - USB 2.0 Host/OTG > - PCIe Gen2 interface > - I2S > - MIPI

Re: [PATCH v2 2/6] dt-bindings: arm: fsl: Add Engicam i.Core MX8M Mini C.TOUCH 2.0

2020-12-21 Thread Krzysztof Kozlowski
On Mon, Dec 21, 2020 at 05:01:47PM +0530, Jagan Teki wrote: > i.Core MX8M Mini is an EDIMM SoM based on NXP i.MX8M Mini from Engicam. > > C.TOUCH 2.0 is a general purpose carrier board with capacitive > touch interface support. > > i.Core MX8M Mini needs to mount on top of this Carrier board for

Re: [PATCH v2 1/6] arm64: defconfig: Enable REGULATOR_PF8X00

2020-12-21 Thread Krzysztof Kozlowski
igned-off-by: Jagan Teki > --- > Changes for v2: > - updated commit message > > arch/arm64/configs/defconfig | 1 + > 1 file changed, 1 insertion(+) Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH v8 3/4] arm64: dts: imx8m: add NVMEM provider and consumer to read soc unique ID

2020-12-20 Thread Krzysztof Kozlowski
On Mon, Dec 21, 2020 at 03:10:52AM +, Alice Guo (OSS) wrote: > > > > -Original Message- > > From: Krzysztof Kozlowski > > Sent: 2020年12月19日 20:17 > > To: Alice Guo (OSS) > > Cc: robh...@kernel.org; shawn...@kernel.org; s.ha...@pengutronix.

Re: [PATCH 9/9] mfd: sec-irq: Do not enforce (incorrect) interrupt trigger type

2020-12-20 Thread Krzysztof Kozlowski
On Mon, Dec 21, 2020 at 08:36:02AM +0100, Marek Szyprowski wrote: > Hi Krzysztof, > > On 18.12.2020 15:22, Krzysztof Kozlowski wrote: > > On Fri, Dec 18, 2020 at 02:25:39PM +0100, Marek Szyprowski wrote: > >> On 10.12.2020 22:29, Krzysztof Kozlowski wrote: > >>&

Re: [PATCH v2 3/4] arm64: dts: imx8mq-librem5-devkit: Disable snvs_rtc

2020-12-19 Thread Krzysztof Kozlowski
ale/imx8mq-librem5-devkit.dts | 4 > 1 file changed, 4 insertions(+) > Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH v2 2/4] arm64: dts: imx8mq-librem5-devkit: Tweak pmic regulators

2020-12-19 Thread Krzysztof Kozlowski
runtime suspend so > let's revisit this at a later point. > > Signed-off-by: Guido Günther > --- > .../boot/dts/freescale/imx8mq-librem5-devkit.dts | 11 +++ > 1 file changed, 11 insertions(+) > Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH v2 4/4] arm64: dts: imx8mq-librem5-devkit: Drop custom clock settings

2020-12-19 Thread Krzysztof Kozlowski
0 5 > > Signed-off-by: Guido Günther > --- > arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts | 5 - > 1 file changed, 5 deletions(-) > Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH v2 1/4] arm64: defconfig: Enable Librem 5 devkit components

2020-12-19 Thread Krzysztof Kozlowski
er > --- > arch/arm64/configs/defconfig | 8 ++++ > 1 file changed, 8 insertions(+) Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH 3/4] arm64: dts: imx8mq-librem5: Move usdhc clocks assignment to board DT

2020-12-19 Thread Krzysztof Kozlowski
On Fri, Dec 18, 2020 at 11:31:30AM +0100, Martin Kepplinger wrote: > According to commit e045f044e84e ("arm64: dts: imx8mq: Move usdhc clocks > assignment to board DT") add the clocks assignment to imx8mq-librem5.dtsi > too. > > Signed-off-by: Martin Kepplinger This should go with Fixes tag as

Re: [PATCH 2/4] arm64: dts: imx8mq-librem5: add pinctrl for the touchscreen description

2020-12-19 Thread Krzysztof Kozlowski
On Fri, Dec 18, 2020 at 11:31:29AM +0100, Martin Kepplinger wrote: > Add the pinctrl description for the interrupt. Please describe why do you need to add it. From the patch contents I easily see what you are doing. But neither the commit title nor the message describe what you want to achieve

Re: [PATCH v8 3/4] arm64: dts: imx8m: add NVMEM provider and consumer to read soc unique ID

2020-12-19 Thread Krzysztof Kozlowski
On Fri, Dec 18, 2020 at 04:37:25PM +0800, Alice Guo (OSS) wrote: > From: Alice Guo > > In order to be able to use NVMEM APIs to read soc unique ID, add the > nvmem data cell and name for nvmem-cells to the "soc" node, and add a > nvmem node which provides soc unique ID to efuse@3035. > >

Re: [PATCH v8 4/4] soc: imx8m: change to use platform driver

2020-12-19 Thread Krzysztof Kozlowski
On Fri, Dec 18, 2020 at 04:37:26PM +0800, Alice Guo (OSS) wrote: > From: Alice Guo > > Directly reading ocotp register depends on that bootloader enables ocotp > clk, which is not always effective, so change to use nvmem API. Using > nvmem API requires to support driver defer probe and thus

Re: [PATCH v2 16/18] arm64: dts: hi3660: Harmonize DWC USB3 DT nodes name

2020-12-19 Thread Krzysztof Kozlowski
requires the USB nodes to have the name acceptable by the regexp: > > "^usb(@.*)?" . Make sure the "snps,dwc3"-compatible nodes are correctly > > named. > > > > Signed-off-by: Serge Semin > > Acked-by: Krzysztof Kozlowski > > --- > > arch

Re: [PATCH v2 41/48] memory: tegra20-emc: Use devm_tegra_core_dev_init_opp_table()

2020-12-19 Thread Krzysztof Kozlowski
On Thu, Dec 17, 2020 at 09:06:31PM +0300, Dmitry Osipenko wrote: > Use common devm_tegra_core_dev_init_opp_table() helper for the OPP table > initialization. > > Signed-off-by: Dmitry Osipenko > --- > drivers/memory/tegra/tegra20-emc.c | 57 +++--- > 1 file changed, 4

Re: [PATCH v2 07/48] dt-bindings: arm: tegra: Add binding for core power domain

2020-12-19 Thread Krzysztof Kozlowski
On Thu, Dec 17, 2020 at 09:05:57PM +0300, Dmitry Osipenko wrote: > All NVIDIA Tegra SoCs have a core power domain where majority of hardware > blocks reside. Add binding for the core power domain. > > Signed-off-by: Dmitry Osipenko > --- > .../arm/tegra/nvidia,tegra20-core-domain.yaml | 48

Re: [PATCH 9/9] mfd: sec-irq: Do not enforce (incorrect) interrupt trigger type

2020-12-18 Thread Krzysztof Kozlowski
On Fri, Dec 18, 2020 at 02:25:39PM +0100, Marek Szyprowski wrote: > On 10.12.2020 22:29, Krzysztof Kozlowski wrote: > > Interrupt line can be configured on different hardware in different way, > > even inverted. Therefore driver should not enforce specific trigger > >

Re: [PATCH v8 1/4] dt-bindings: soc: imx8m: add DT Binding doc for soc unique ID

2020-12-18 Thread Krzysztof Kozlowski
On Fri, Dec 18, 2020 at 09:05:00AM +, Alice Guo (OSS) wrote: > > +required: > > > + - compatible > > > + - nvmem-cells > > > + - nvmem-cell-names > > > + > > > +additionalProperties: true > > > > Don't leave comments unresolved (or resolve them against review without > >

Re: [PATCH v8 1/4] dt-bindings: soc: imx8m: add DT Binding doc for soc unique ID

2020-12-18 Thread Krzysztof Kozlowski
On Fri, Dec 18, 2020 at 04:37:23PM +0800, Alice Guo (OSS) wrote: > From: Alice Guo > > Add DT Binding doc for the Unique ID of i.MX 8M series. > > Signed-off-by: Alice Guo > --- > > Changes for v8: > - match soc node with regular expression > Changes for v7: > - change to a separate schema

Re: [PATCH v7 1/4] dt-bindings: soc: imx8m: add DT Binding doc for soc unique ID

2020-12-16 Thread Krzysztof Kozlowski
On Wed, Dec 16, 2020 at 09:55:34AM +, Alice Guo (OSS) wrote: > > > > -Original Message- > > From: Krzysztof Kozlowski > > Sent: 2020年12月15日 17:11 > > To: Alice Guo (OSS) > > Cc: robh...@kernel.org; shawn...@kernel.org; s.ha...@pengutronix.

Re: [PATCH] clk: s2mps11: Fix a resource leak in error handling paths in the probe function

2020-12-15 Thread Krzysztof Kozlowski
missing of_node_put and of_clk_del_provider") > > Fixes: 7cc560dea415 ("clk: s2mps11: Add support for s2mps11") > Signed-off-by: Christophe JAILLET > --- > drivers/clk/clk-s2mps11.c | 1 + > 1 file changed, 1 insertion(+) > Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH 3/4] arm64: dts: imx8mq-librem5-devkit: Mark more regulators as always-on

2020-12-15 Thread Krzysztof Kozlowski
On Sun, Dec 13, 2020 at 06:17:13PM +0100, Guido Günther wrote: > They power vital parts of the board and low power consumption is not > really an issue here. It also brings things more in line with what > Purism is using downstream. I don't find it a proper explanation. Not all regulators power

Re: [PATCH 4/4] arm64: dts: imx8mq-librem5-devkit: Drop custom clock settings

2020-12-15 Thread Krzysztof Kozlowski
On Sun, Dec 13, 2020 at 06:17:14PM +0100, Guido Günther wrote: > Otherwise the boot hangs early on. And previously it was booting or maybe never tested? Maybe the issue is actually different, e.g. you miss some power domains? Best regards, Krzysztof

Re: [PATCH 2/4] arm64: dts: imx8mq-librem5-devkit: Disable snvs_rtc

2020-12-15 Thread Krzysztof Kozlowski
On Sun, Dec 13, 2020 at 06:17:12PM +0100, Guido Günther wrote: > The board has it's own rtc chip. s/rtc/RTC/ Even if you have on-board RTC, why disabling the SNVS? Best regards, Krzysztof > > Signed-off-by: Guido Günther > --- > arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts | 4

Re: [PATCH 1/4] arm64: defconfig: Enable Librem5 Devkit components

2020-12-15 Thread Krzysztof Kozlowski
On Sun, Dec 13, 2020 at 06:17:11PM +0100, Guido Günther wrote: > This enables > > - touchscreen: CONFIG_TOUCHSCREEN_GOODIX > - charge controller: CONFIG_CHARGER_BQ25890 > - audio codec: CONFIG_SND_SOC_IMX_SGTL5000 > - rtc: CONFIG_RTC_DRV_M41T80 > - magnetometer: CONFIG_IIO_ST_MAGN_3AXIS > - pwm:

Re: [PATCH v2 net-next 2/2] nfc: s3fwrn5: Remove unused NCI prop commands

2020-12-15 Thread Krzysztof Kozlowski
s/nfc/s3fwrn5/nci.h | 22 -- > 2 files changed, 47 deletions(-) > Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH v2 net-next 1/2] nfc: s3fwrn5: Remove the delay for NFC sleep

2020-12-15 Thread Krzysztof Kozlowski
++- > 1 file changed, 2 insertions(+), 1 deletion(-) > Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH v7 1/4] dt-bindings: soc: imx8m: add DT Binding doc for soc unique ID

2020-12-15 Thread Krzysztof Kozlowski
On Tue, Dec 15, 2020 at 04:35:48PM +0800, Alice Guo (OSS) wrote: > From: Alice Guo > > Add DT Binding doc for the Unique ID of i.MX 8M series. > > Signed-off-by: Alice Guo > --- > > Changes for v7: > - change to a separate schema file > Changes for v6: > - none > Changes for v5: > -

<    2   3   4   5   6   7   8   9   10   11   >