[GIT PULL] Thermal-SoC management changes for v5.4-rc1

2019-09-28 Thread Eduardo Valentin
Hello Linus, Please consider the following thermal soc changes for v5.4-rc1. This is a really small pull in the midst of a lot of pending patches. We are in the middle of restructuring how we are maintaining the thermal subsystem, as per discussion in our last LPC. For now, I am sending just some

Re: [PATCHv2 2/2] hwmon: core: fix potential memory leak in *hwmon_device_register*

2019-06-06 Thread Eduardo Valentin
On Wed, Jun 05, 2019 at 01:38:38PM -0700, Guenter Roeck wrote: > On Wed, May 29, 2019 at 07:56:05PM -0700, Eduardo Valentin wrote: > > When registering a hwmon device with HWMON_C_REGISTER_TZ flag > > in place, the hwmon subsystem will attempt to register the device > >

Re: [PATCH][next] drivers: thermal: tsens: remove redundant u32 comparison with less than zero

2019-06-06 Thread Eduardo Valentin
hey Colin, On Fri, May 31, 2019 at 11:57:08AM +0100, Colin King wrote: > From: Colin Ian King > > The u32 variable hw_id is unsigned and cannot be less than zero so > the comparison with less than zero is always false and hence is redundant > and can be removed. > > Addresses-Coverity:

Re: [PATCHv7 2/3] i2c: slave-mqueue: add a slave backend to receive and queue messages

2019-06-05 Thread Eduardo Valentin
On Wed, Jun 05, 2019 at 08:02:11PM +0300, Andy Shevchenko wrote: > On Wed, Jun 5, 2019 at 7:48 PM Eduardo Valentin wrote: > > > > From: Haiyue Wang > > > > Some protocols over I2C are designed for bi-directional transferring > > messages by using I2C Mas

[PATCHv7 3/3] Documentation: ABI: Add i2c-slave-mqueue sysfs documentation

2019-06-05 Thread Eduardo Valentin
Document the slave-mqueue sysfs attribute used by the i2c-slave-mqueue driver. Cc: Rob Herring Cc: Mark Rutland Cc: Wolfram Sang Cc: linux-...@vger.kernel.org Cc: devicet...@vger.kernel.org Cc: linux-kernel@vger.kernel.org Signed-off-by: Eduardo Valentin --- changes from V6 to V7: - none

[PATCHv7 2/3] i2c: slave-mqueue: add a slave backend to receive and queue messages

2019-06-05 Thread Eduardo Valentin
Cc: Mark Rutland Cc: Wolfram Sang Cc: Andy Shevchenko Cc: linux-...@vger.kernel.org Cc: devicet...@vger.kernel.org Cc: linux-kernel@vger.kernel.org Signed-off-by: Haiyue Wang Signed-off-by: Eduardo Valentin --- >From V6 -> V7: - fixed compile warm when CONFIG_OF=n by wrapping of

[PATCHv7 1/3] dt-bindings: i2c: document bindings for i2c-slave-mqueue

2019-06-05 Thread Eduardo Valentin
Document the i2c-slave-mqueue binding by adding descriptor, required properties, and example. Cc: Rob Herring Cc: Mark Rutland Cc: Wolfram Sang Cc: linux-...@vger.kernel.org Cc: devicet...@vger.kernel.org Cc: linux-kernel@vger.kernel.org Signed-off-by: Eduardo Valentin --- Changes from V6

Re: [PATCH v2 1/2] dt-bindings: interrupt-controller: Amazon's Annapurna Labs FIC

2019-06-05 Thread Eduardo Valentin
interrupt-controller; > + #interrupt-cells = <1>; > + reg = <0x0 0xfd8a8500 0x0 0x1000>; > + interrupt-parent = <>; > + interrupts = ; > +}; > -- > 2.7.4 > -- All the best, Eduardo Valentin

Re: [PATCH 2/3] i2c: slave-mqueue: add a slave backend to receive and queue messages

2019-06-05 Thread Eduardo Valentin
On Wed, Jun 05, 2019 at 06:20:37PM +0300, Andy Shevchenko wrote: > On Wed, Jun 5, 2019 at 5:32 PM Eduardo Valentin wrote: > > On Wed, Jun 05, 2019 at 11:25:39AM +0300, Andy Shevchenko wrote: > > > On Wed, Jun 5, 2019 at 6:30 AM Eduardo Valentin wrote: > > > Well, yes,

Re: [PATCH 2/3] i2c: slave-mqueue: add a slave backend to receive and queue messages

2019-06-05 Thread Eduardo Valentin
On Wed, Jun 05, 2019 at 11:25:39AM +0300, Andy Shevchenko wrote: > On Wed, Jun 5, 2019 at 6:30 AM Eduardo Valentin wrote: > > > > Hey Andry, > > > > Long time no seeing :-) > > True! > > > > > > +#define MQ_MSGBUF_SIZE CO

Re: [PATCH 2/3] i2c: slave-mqueue: add a slave backend to receive and queue messages

2019-06-04 Thread Eduardo Valentin
Hey Andry, Long time no seeing :-) On Tue, Jun 04, 2019 at 08:16:11PM +0300, Andy Shevchenko wrote: > On Thu, May 30, 2019 at 09:33:46PM -0700, Eduardo Valentin wrote: > > From: Haiyue Wang > > > > Some protocols over I2C are designed for bi-directional transferring >

[GIT PULL] Thermal-SoC management fixes for v5.2-rc3

2019-06-01 Thread Eduardo Valentin
: - Revert tsens change that is reported to cause issues. BR, -------- Eduardo Valentin (1): Revert "drivers: thermal: tsens: Add new operation to check if a sensor is enabled" drivers/thermal/qcom/tsens-common.c | 14 ---

[PATCH 1/3] dt-bindings: i2c: document bindings for i2c-slave-mqueue

2019-05-30 Thread Eduardo Valentin
Document the i2c-slave-mqueue binding by adding descriptor, required properties, and example. Cc: Rob Herring Cc: Mark Rutland Cc: Wolfram Sang Cc: linux-...@vger.kernel.org Cc: devicet...@vger.kernel.org Cc: linux-kernel@vger.kernel.org Signed-off-by: Eduardo Valentin --- .../bindings/i2c

[PATCH 2/3] i2c: slave-mqueue: add a slave backend to receive and queue messages

2019-05-30 Thread Eduardo Valentin
Cc: Mark Rutland Cc: Wolfram Sang Cc: linux-...@vger.kernel.org Cc: devicet...@vger.kernel.org Cc: linux-kernel@vger.kernel.org Signed-off-by: Haiyue Wang Signed-off-by: Eduardo Valentin --- Documentation/i2c/slave-mqueue-backend.rst | 124 MAINTAINERS

[PATCH 3/3] Documentation: ABI: Add i2c-slave-mqueue sysfs documentation

2019-05-30 Thread Eduardo Valentin
Document the slave-mqueue sysfs attribute used by the i2c-slave-mqueue driver. Cc: Rob Herring Cc: Mark Rutland Cc: Wolfram Sang Cc: linux-...@vger.kernel.org Cc: devicet...@vger.kernel.org Cc: linux-kernel@vger.kernel.org Signed-off-by: Eduardo Valentin --- .../ABI/testing/sysfs-bus-i2c

[PATCH 0/3] introduce i2c-slave-mqueue

2019-05-30 Thread Eduardo Valentin
: - Added DT support for probing via Device Tree - Docummented DT bindings - Documented sysfs ABI - Small fixes on wording and Kconfig entries. Haiyue's V5: https://lkml.org/lkml/2018/4/23/835 BR, Eduardo Valentin (2): dt-bindings: i2c: document bindings for i2c-slave-mqueue Documentation: ABI

Re: [PATCH v3 3/8] drivers/soc: xdma: Add user interface

2019-05-30 Thread Eduardo Valentin
= _xdma_fops; > + ctx->misc.name = "xdma"; tiny bit here, should this be named more specific ? something like "aspeed_xdma" ? > + ctx->misc.parent = dev; > + rc = misc_register(>misc); > + if (rc) { > + dev_err(dev, "Unable to register xdma miscdevice.\n"); > + > + gen_pool_free(ctx->vga_pool, (unsigned long)ctx->cmdq_vga_virt, > + XDMA_CMDQ_SIZE); > + dma_free_coherent(dev, ctx->vga_size, ctx->vga_virt, > + ctx->vga_dma); > + dma_release_declared_memory(dev); > + reset_control_assert(ctx->reset); > + return rc; > + } > + > return 0; > } > > @@ -489,6 +689,7 @@ static int aspeed_xdma_remove(struct platform_device > *pdev) > { > struct aspeed_xdma *ctx = platform_get_drvdata(pdev); > > + misc_deregister(>misc); > gen_pool_free(ctx->vga_pool, (unsigned long)ctx->cmdq_vga_virt, > XDMA_CMDQ_SIZE); > dma_free_coherent(ctx->dev, ctx->vga_size, ctx->vga_virt, > -- > 1.8.3.1 > -- All the best, Eduardo Valentin

Re: [PATCH v3 5/8] drivers/soc: xdma: Add PCI device configuration sysfs

2019-05-30 Thread Eduardo Valentin
ssert(ctx->reset); > return rc; > @@ -682,6 +775,8 @@ static int aspeed_xdma_probe(struct platform_device *pdev) > return rc; > } > > + device_create_file(dev, _attr_pcidev); Should we consider using one of the default attributes here

Re: [PATCH v3 2/8] drivers/soc: Add Aspeed XDMA Engine Driver

2019-05-30 Thread Eduardo Valentin
setup genalloc pool.\n"); > + return -ENOMEM; > + } > + > + reset_control_deassert(ctx->reset); > + > + msleep(10); Why 10ms again? :-) > + > + rc = aspeed_xdma_init_mem(ctx); > + if (rc) { > + reset_control_assert(ctx->reset); > + return rc; > + } > + > + aspeed_xdma_init_eng(ctx); > + > + return 0; > +} > + > +static int aspeed_xdma_remove(struct platform_device *pdev) > +{ > + struct aspeed_xdma *ctx = platform_get_drvdata(pdev); > + > + gen_pool_free(ctx->vga_pool, (unsigned long)ctx->cmdq_vga_virt, > + XDMA_CMDQ_SIZE); > + dma_free_coherent(ctx->dev, ctx->vga_size, ctx->vga_virt, > + ctx->vga_dma); > + dma_release_declared_memory(ctx->dev); > + reset_control_assert(ctx->reset); > + > + return 0; > +} > + > +static const struct of_device_id aspeed_xdma_match[] = { > + { .compatible = "aspeed,ast2500-xdma" }, > + { }, > +}; > + > +static struct platform_driver aspeed_xdma_driver = { > + .probe = aspeed_xdma_probe, > + .remove = aspeed_xdma_remove, > + .driver = { > + .name = DEVICE_NAME, > + .of_match_table = aspeed_xdma_match, > + }, > +}; > + > +module_platform_driver(aspeed_xdma_driver); > + > +MODULE_AUTHOR("Eddie James"); > +MODULE_DESCRIPTION("Aspeed XDMA Engine Driver"); > +MODULE_LICENSE("GPL v2"); > diff --git a/include/uapi/linux/aspeed-xdma.h > b/include/uapi/linux/aspeed-xdma.h > new file mode 100644 > index 000..998459e > --- /dev/null > +++ b/include/uapi/linux/aspeed-xdma.h > @@ -0,0 +1,26 @@ > +/* SPDX-License-Identifier: GPL-2.0+ */ > +/* Copyright IBM Corp 2019 */ > + > +#ifndef _UAPI_LINUX_ASPEED_XDMA_H_ > +#define _UAPI_LINUX_ASPEED_XDMA_H_ > + > +#include > + > +/* > + * aspeed_xdma_op > + * > + * host_addr: the DMA address on the host side, typically configured by PCI > + *subsystem > + * > + * len: the size of the transfer in bytes; it should be a multiple of 16 > bytes > + * > + * upstream: boolean indicating the direction of the DMA operation; upstream > + * means a transfer from the BMC to the host > + */ > +struct aspeed_xdma_op { > + __u64 host_addr; > + __u32 len; > + __u32 upstream; > +}; > + > +#endif /* _UAPI_LINUX_ASPEED_XDMA_H_ */ > -- > 1.8.3.1 > -- All the best, Eduardo Valentin

Re: [PATCH i2c/slave-mqueue v5] i2c: slave-mqueue: add a slave backend to receive and queue messages

2019-05-30 Thread Eduardo Valentin
On Wed, May 29, 2019 at 08:46:48PM -0700, Eduardo Valentin wrote: > On Tue, Apr 24, 2018 at 01:06:32AM +0800, Haiyue Wang wrote: > > Some protocols over I2C are designed for bi-directional transferring > > messages by using I2C Master Write protocol. Like the MCTP (Managemen

Re: [PATCH i2c/slave-mqueue v5] i2c: slave-mqueue: add a slave backend to receive and queue messages

2019-05-29 Thread Eduardo Valentin
quot;slave-mqueue"; > + mq->bin.attr.mode = 0400; > + mq->bin.read = i2c_slave_mqueue_bin_read; > + mq->bin.size = MQ_MSGBUF_SIZE * MQ_QUEUE_SIZE; > + > + ret = sysfs_create_bin_file(>kobj, >bin); > + if (ret) > + return ret; > + > + mq-&g

Re: [PATCH i2c/slave-mqueue v5] i2c: slave-mqueue: add a slave backend to receive and queue messages

2019-05-29 Thread Eduardo Valentin
On Thu, May 30, 2019 at 09:33:34AM +0800, Wang, Haiyue wrote: > > 在 2019-05-30 07:11, Eduardo Valentin 写道: > >>>>>>+ > >>>>>>+ case I2C_SLAVE_WRITE_RECEIVED: > >>>>>>+ if (msg->len < MQ_MSGBUF_SIZE)

Re: [PATCH i2c/slave-mqueue v5] i2c: slave-mqueue: add a slave backend to receive and queue messages

2019-05-29 Thread Eduardo Valentin
t; + ret = sysfs_create_bin_file(>kobj, >bin); > + if (ret) > + return ret; > + > + mq->kn = kernfs_find_and_get(dev->kobj.sd, mq->bin.attr.name); > + if (!mq->kn) { > + sysfs_remove_bin_file(>kobj, >bin); > + return -EFAULT; > + } > + > + ret = i2c_slave_register(client, i2c_slave_mqueue_callback); > + if (ret) { > + kernfs_put(mq->kn); > + sysfs_remove_bin_file(>kobj, >bin); > + return ret; > + } > + > + return 0; > +} > + > +static int i2c_slave_mqueue_remove(struct i2c_client *client) > +{ > + struct mq_queue *mq = i2c_get_clientdata(client); > + > + i2c_slave_unregister(client); > + > + kernfs_put(mq->kn); > + sysfs_remove_bin_file(>dev.kobj, >bin); > + > + return 0; > +} > + > +static const struct i2c_device_id i2c_slave_mqueue_id[] = { > + { "slave-mqueue", 0 }, > + { } > +}; > +MODULE_DEVICE_TABLE(i2c, i2c_slave_mqueue_id); Also, can we have device tree support for this driver? > + > +static struct i2c_driver i2c_slave_mqueue_driver = { > + .driver = { > + .name = "i2c-slave-mqueue", > + }, > + .probe = i2c_slave_mqueue_probe, > + .remove = i2c_slave_mqueue_remove, > + .id_table = i2c_slave_mqueue_id, > +}; > +module_i2c_driver(i2c_slave_mqueue_driver); > + > +MODULE_LICENSE("GPL v2"); > +MODULE_AUTHOR("Haiyue Wang "); > +MODULE_DESCRIPTION("I2C slave mode for receiving and queuing messages"); > -- > 2.7.4 > -- All the best, Eduardo Valentin

Re: [PATCH i2c/slave-mqueue v5] i2c: slave-mqueue: add a slave backend to receive and queue messages

2019-05-29 Thread Eduardo Valentin
Hello, On Sat, May 25, 2019 at 01:10:46PM +0800, Wang, Haiyue wrote: > > 在 2019-05-25 01:33, Eduardo Valentin 写道: > >Hey, > > > >On Fri, May 24, 2019 at 10:43:16AM +0800, Wang, Haiyue wrote: > >>Thanks for interest, the design idea is from: > >> >

Re: [PATCH] thermal/drivers/of: Add a get_temp_id callback function

2019-05-28 Thread Eduardo Valentin
On Thu, May 23, 2019 at 07:48:56PM -0700, Andrey Smirnov wrote: > On Mon, Apr 29, 2019 at 9:51 AM Daniel Lezcano > wrote: > > > > On 24/04/2019 01:08, Daniel Lezcano wrote: > > > On 23/04/2019 17:44, Eduardo Valentin wrote: > > >> Hello, > > >&

Re: [PATCH RESEND V13 2/5] thermal: of-thermal: add API for getting sensor ID from DT

2019-05-28 Thread Eduardo Valentin
On Tue, May 28, 2019 at 02:06:18PM +0800, anson.hu...@nxp.com wrote: > From: Anson Huang > > On some platforms like i.MX8QXP, the thermal driver needs a > real HW sensor ID from DT thermal zone, the HW sensor ID is > used to get temperature from SCU firmware, and the virtual > sensor ID starting

Re: [PATCH] arm64: dts: ls1028a: Add Thermal Monitor Unit node

2019-05-28 Thread Eduardo Valentin
Tang I dont see anything wrong from a thermal standpoint. Acked-by: Eduardo Valentin Please get this via your arch tree maintainer to avoid merge conflicts. > --- > arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi | 114 > > 1 files changed, 114 insertion

Re: [PATCH -next] drivers: thermal: tsens: Change hw_id type to int in is_sensor_enabled

2019-05-28 Thread Eduardo Valentin
YueHaibing, On Mon, May 27, 2019 at 09:41:24PM +0800, YueHaibing wrote: > Sensor hw_id is int type other u32, is_sensor_enabled > should use int to compare, this fix smatch warning: > > drivers/thermal/qcom/tsens-common.c:72 > is_sensor_enabled() warn: unsigned 'hw_id' is never less than zero.

Re: [PATCH] thermal: tsens: Remove unnecessary comparison of unsigned integer with < 0

2019-05-28 Thread Eduardo Valentin
Gustavo, On Mon, May 27, 2019 at 11:08:25AM -0500, Gustavo A. R. Silva wrote: > There is no need to compare hw_id with < 0 because such comparison > of an unsigned value is always false. > > Fix this by removing such comparison. Thanks for fixing this. But we had to revert the commit that

[PATCH 1/1] Revert "drivers: thermal: tsens: Add new operation to check if a sensor is enabled"

2019-05-28 Thread Eduardo Valentin
This reverts commit 3e6a8fb3308419129c7a52de6eb42feef5a919a0. Cc: Andy Gross Cc: David Brown Cc: Amit Kucheria Cc: Zhang Rui Cc: Daniel Lezcano Suggested-by: Amit Kucheria Reported-by: Andy Gross Signed-off-by: Eduardo Valentin --- Added this for next -rc, as per request. drivers

Re: [PATCH i2c/slave-mqueue v5] i2c: slave-mqueue: add a slave backend to receive and queue messages

2019-05-24 Thread Eduardo Valentin
/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/i2c/slave-interface > > Then you will get the answer. ;-) Well, maybe :-) see further comments inline.. > > BR, > > Haiyue > > > 在 2019-05-24 06:03, Eduardo Valentin 写道: > >Hey Wang, > > &g

[GIT PULL] Thermal-SoC management fixes for v5.2-rc2

2019-05-24 Thread Eduardo Valentin
Hello Linus, Please consider the following thermal soc fixes for v5.2-rc2. The following changes since commit 4dde821e4296e156d133b98ddc4c45861935a4fb: Merge tag 'xfs-5.2-fixes-1' of git://git.kernel.org/pub/scm/fs/xfs/xfs-linux (2019-05-23 11:18:18 -0700) are available in the git

Re: [GIT PULL] Thermal-SoC management changes for v5.2-rc1

2019-05-24 Thread Eduardo Valentin
Hello, On Fri, May 24, 2019 at 10:23:09AM +0200, Tomeu Vizoso wrote: > On Fri, 24 May 2019 at 04:40, Eduardo Valentin wrote: > > > > On Thu, May 23, 2019 at 11:46:47AM +0200, Tomeu Vizoso wrote: > > > Hi Eduardo, > > > > > > I saw that for 5.1 [0] yo

Re: [PATCH] dt-bindings: thermal: Make cooling-maps property optional

2019-05-23 Thread Eduardo Valentin
On Wed, May 15, 2019 at 05:36:47PM +0800, Yuantian Tang wrote: > There may be no cooling device on system, or there are no enough > cooling devices for each thermal zone in multiple thermal zone > cases since cooling devices can't be shared. > So make this property optional to remove such

Re: [GIT PULL] Thermal-SoC management changes for v5.2-rc1

2019-05-23 Thread Eduardo Valentin
? > Thanks, > > Tomeu > > On Thu, 16 May 2019 at 06:43, Eduardo Valentin wrote: > > > > Hello Linus, > > > > Please consider the following thermal soc changes for v5.2-rc1. > > > > The following changes since commit 37624b58542fb9f2d9a70e6ea006ef8a

Re: [GIT PULL] Thermal-SoC management changes for v5.2-rc1

2019-05-23 Thread Eduardo Valentin
On Thu, May 16, 2019 at 09:55:33AM -0700, Guenter Roeck wrote: > On 5/16/19 8:07 AM, Linus Torvalds wrote: > >On Wed, May 15, 2019 at 9:43 PM Eduardo Valentin wrote: > >> > >>- thermal core has a new devm_* API for registering cooling devices, thanks > >>to

Re: [PATCH v3 1/3] thermal: rockchip: fix up the tsadc pinctrl setting error

2019-05-23 Thread Eduardo Valentin
On Thu, May 23, 2019 at 09:34:37AM +0800, elaine.zhang wrote: > hi, Heiko & Enric: > > 在 2019/5/22 下午8:27, Heiko Stuebner 写道: > >Hi Enric, > > > >Am Montag, 20. Mai 2019, 15:38:32 CEST schrieb Enric Balletbo Serra: > >>Hi all, > >> > >>As pointed by [1] and [2] this commit, that now is upstream,

Re: [PATCH] Revert "thermal: rockchip: fix up the tsadc pinctrl setting error"

2019-05-23 Thread Eduardo Valentin
On Wed, May 22, 2019 at 08:34:34AM -0700, Doug Anderson wrote: > Hi, > > On Wed, May 22, 2019 at 7:12 AM Heiko Stuebner wrote: > > > > This reverts commit 28694e009e512451ead5519dd801f9869acb1f60. > > > > The commit causes multiple issues in that: > > - the added call to ->control does

Re: [PATCH i2c/slave-mqueue v5] i2c: slave-mqueue: add a slave backend to receive and queue messages

2019-05-23 Thread Eduardo Valentin
; > + mq->bin.read = i2c_slave_mqueue_bin_read; > + mq->bin.size = MQ_MSGBUF_SIZE * MQ_QUEUE_SIZE; > + > + ret = sysfs_create_bin_file(>kobj, >bin); > + if (ret) > + return ret; > + > + mq->kn = kernfs_find_and_get(dev->kobj.sd, mq->bin.attr.name); > + if (!mq->kn) { > + sysfs_remove_bin_file(>kobj, >bin); > + return -EFAULT; > + } > + > + ret = i2c_slave_register(client, i2c_slave_mqueue_callback); > + if (ret) { > + kernfs_put(mq->kn); > + sysfs_remove_bin_file(>kobj, >bin); > + return ret; > + } > + > + return 0; > +} > + > +static int i2c_slave_mqueue_remove(struct i2c_client *client) > +{ > + struct mq_queue *mq = i2c_get_clientdata(client); > + > + i2c_slave_unregister(client); > + > + kernfs_put(mq->kn); > + sysfs_remove_bin_file(>dev.kobj, >bin); > + > + return 0; > +} > + > +static const struct i2c_device_id i2c_slave_mqueue_id[] = { > + { "slave-mqueue", 0 }, > + { } > +}; > +MODULE_DEVICE_TABLE(i2c, i2c_slave_mqueue_id); > + > +static struct i2c_driver i2c_slave_mqueue_driver = { > + .driver = { > + .name = "i2c-slave-mqueue", > + }, > + .probe = i2c_slave_mqueue_probe, > + .remove = i2c_slave_mqueue_remove, > + .id_table = i2c_slave_mqueue_id, > +}; > +module_i2c_driver(i2c_slave_mqueue_driver); > + > +MODULE_LICENSE("GPL v2"); > +MODULE_AUTHOR("Haiyue Wang "); > +MODULE_DESCRIPTION("I2C slave mode for receiving and queuing messages"); > -- > 2.7.4 > -- All the best, Eduardo Valentin

[GIT PULL] Thermal-SoC management changes for v5.2-rc1

2019-05-15 Thread Eduardo Valentin
thermal driver, thanks to Amit K. - Cleanups on cpu cooling driver, thanks to Daniel L. - broadcom thermal driver dropped support to ACPI, thanks to Srinath M. - tegra thermal driver gains support to OC hw throttle and GPU throtle, thanks to Wei Ni. - Fixes in several thermal drivers. BR, Eduardo

Re: [PATCH v3 3/3] thermal: cpu_cooling: Migrate to using the EM framework

2019-05-14 Thread Eduardo Valentin
Hey Quentin, On Tue, May 14, 2019 at 08:15:08AM +0100, Quentin Perret wrote: > Hi Eduardo, > > On Monday 13 May 2019 at 20:40:59 (-0700), Eduardo Valentin wrote: > > On Fri, May 03, 2019 at 10:44:09AM +0100, Quentin Perret wrote: > > > The newly introduced Energy Model

Re: linux-next: manual merge of the thermal-soc tree with Linus' tree

2019-05-14 Thread Eduardo Valentin
Hey Stephen, On Tue, May 14, 2019 at 02:40:06PM +1000, Stephen Rothwell wrote: > Hi Eduardo, > > On Mon, 13 May 2019 20:44:11 -0700 Eduardo Valentin > wrote: > > > > Thanks for spotting this. I am re-doing the branch based off v5.1-rc7, > > where the last conflict

Re: linux-next: manual merge of the thermal-soc tree with Linus' tree

2019-05-13 Thread Eduardo Valentin
Stephen, On Mon, May 13, 2019 at 10:49:28AM +1000, Stephen Rothwell wrote: > Hi all, > > Today's linux-next merge of the thermal-soc tree got a conflict in: > > MAINTAINERS > > between commit: > > f23afd75fc99 ("RDMA/efa: Add driver to Kconfig/Makefile") > > from Linus' tree and commit:

Re: [PATCH v3 3/3] thermal: cpu_cooling: Migrate to using the EM framework

2019-05-13 Thread Eduardo Valentin
On Fri, May 03, 2019 at 10:44:09AM +0100, Quentin Perret wrote: > The newly introduced Energy Model framework manages power cost tables in > a generic way. Moreover, it supports a several types of models since the > tables can come from DT or firmware (through SCMI) for example. On the > other

Re: [PATCH - resend 1/3] thermal/drivers/cpu_cooling: Fixup the header and copyright

2019-05-11 Thread Eduardo Valentin
On Sun, Apr 28, 2019 at 11:51:03AM +0200, Daniel Lezcano wrote: > The copyright format does not conform to the format requested by > Linaro: https://wiki.linaro.org/Copyright > > Fix it. > > Signed-off-by: Daniel Lezcano > Viresh Kumar Based on the series and other patches of it, I am

Re: [PATCH 1/7] thermal/drivers/core: Remove the module Kconfig's option

2019-04-23 Thread Eduardo Valentin
Hello, On Tue, Apr 02, 2019 at 06:12:44PM +0200, Daniel Lezcano wrote: > The module support for the thermal subsystem makes little sense: > - some subsystems relying on it are not modules, thus forcing the >framework to be compiled in > - it is compiled in for almost every configs, the

Re: [PATCH v2 12/12] thermal: tegra: enable OC hw throttle

2019-04-23 Thread Eduardo Valentin
On Thu, Feb 21, 2019 at 06:18:47PM +0800, Wei Ni wrote: > Parse Over Current settings from DT and program them to > generate interrupts. Also enable hw throttling whenever > there are OC events. Log the OC events as debug messages. > > Signed-off-by: Wei Ni I applied this series except for this

Re: [PATCH] thermal/drivers/of: Add a get_temp_id callback function

2019-04-23 Thread Eduardo Valentin
Hello, On Tue, Apr 16, 2019 at 07:22:03PM +0200, Daniel Lezcano wrote: > Currently when we register a sensor, we specify the sensor id and a data > pointer to be passed when the get_temp function is called. However the > sensor_id is not passed to the get_temp callback forcing the driver to > do

[GIT PULL] Thermal-SoC management changes for v5.1-rc1

2019-03-06 Thread Eduardo Valentin
Hello Linus, Please consider the following thermal soc changes for v5.1-rc1. The following changes since commit 8834f5600cf3c8db365e18a3d5cac2c2780c81e5: Linux 5.0-rc5 (2019-02-03 13:48:04 -0800) are available in the git repository at:

Re: [PATCH V8 1/4] dt-bindings: fsl: scu: add thermal binding

2019-02-23 Thread Eduardo Valentin
On Sat, Feb 23, 2019 at 01:38:00PM -0800, Eduardo Valentin wrote: > On Thu, Feb 21, 2019 at 06:38:30AM +, Anson Huang wrote: > > NXP i.MX8QXP is an ARMv8 SoC with a Cortex-M4 core inside as > > system controller, the system controller is in charge of system > > power, cloc

Re: [PATCH V8 2/4] thermal: imx_sc: add i.MX system controller thermal support

2019-02-23 Thread Eduardo Valentin
Hey Anson, On Thu, Feb 21, 2019 at 06:38:39AM +, Anson Huang wrote: > i.MX8QXP is an ARMv8 SoC which has a Cortex-M4 system controller > inside, the system controller is in charge of controlling power, > clock and thermal sensors etc.. > > This patch adds i.MX system controller thermal

Re: [PATCH V8 1/4] dt-bindings: fsl: scu: add thermal binding

2019-02-23 Thread Eduardo Valentin
On Thu, Feb 21, 2019 at 06:38:30AM +, Anson Huang wrote: > NXP i.MX8QXP is an ARMv8 SoC with a Cortex-M4 core inside as > system controller, the system controller is in charge of system > power, clock and thermal sensors etc. management, Linux kernel > has to communicate with system controller

Re: [PATCH V7 2/4] thermal: imx_sc: add i.MX system controller thermal support

2019-02-20 Thread Eduardo Valentin
On Wed, Feb 20, 2019 at 06:53:40AM +, Anson Huang wrote: > i.MX8QXP is an ARMv8 SoC which has a Cortex-M4 system controller > inside, the system controller is in charge of controlling power, > clock and thermal sensors etc.. > > This patch adds i.MX system controller thermal driver support, >

Re: [PATCH V7 4/4] arm64: dts: imx: add i.MX8QXP thermal support

2019-02-20 Thread Eduardo Valentin
On Wed, Feb 20, 2019 at 06:53:58AM +, Anson Huang wrote: > Add i.MX8QXP CPU thermal zone support. > > Signed-off-by: Anson Huang > --- > Changes since V6: > - add fallback compatible string "fsl,imx-sc-thermal" according to i.MX > SC thermal driver > update. > --- >

Re: [PATCH 12/12] thermal: qoriq: Add support for multiple thremal sites

2019-02-20 Thread Eduardo Valentin
s indivudial sensors and get their temperature readings. small typo: indivudial/individual. > > Signed-off-by: Andrey Smirnov > Cc: Chris Healy > Cc: Lucas Stach > Cc: Zhang Rui > Cc: Eduardo Valentin > Cc: Daniel Lezcano > Cc: linux-...@nxp.com > Cc: linu

Re: [PATCH 00/12] QorIQ TMU multi-sensor and HWMON support

2019-02-20 Thread Eduardo Valentin
Hey Andrey On Mon, Feb 18, 2019 at 11:11:29AM -0800, Andrey Smirnov wrote: > Everyone: > > This series contains patches adding support for HWMON integration, > multi-sensor support as well as a small fix and general improvements > (hopefully) for TMU driver I made while working on it on i.MX8MQ.

Re: [PATCH v1 00/12] qcom: dts: thermal cleanups

2019-02-20 Thread Eduardo Valentin
On Wed, Feb 20, 2019 at 03:09:36PM +0530, Amit Kucheria wrote: > On Wed, Feb 20, 2019 at 6:56 AM Eduardo Valentin wrote: > > > > Hey > > On Mon, Feb 18, 2019 at 06:05:14PM +0530, Amit Kucheria wrote: > > > - Expose all temperature sensors on msm8916, msm996, ms

Re: [PATCH v1 00/12] qcom: dts: thermal cleanups

2019-02-19 Thread Eduardo Valentin
Hey On Mon, Feb 18, 2019 at 06:05:14PM +0530, Amit Kucheria wrote: > - Expose all temperature sensors on msm8916, msm996, msm8998, sdm845 > - split up the register address map for msm8998 > - standardize names of the various thermal-zones across boards to make it > easy for test scripts to parse

Re: [PATCH v1 04/12] arm64: dts: msm8996: thermal: Add temperature sensors near major peripherals

2019-02-19 Thread Eduardo Valentin
On Mon, Feb 18, 2019 at 06:05:18PM +0530, Amit Kucheria wrote: > msm8996 has a total of 21 temperature sensors. Populate DT with > information about them. > > There are 2 sensors on each of the cpus - one on the top, the other > below (we only expose one on the top in DT for now). For the GPU, we

Re: [PATCH v1 03/12] arm64: dts: msm8916: thermal: Add sensor for modem

2019-02-19 Thread Eduardo Valentin
On Mon, Feb 18, 2019 at 06:05:17PM +0530, Amit Kucheria wrote: > On platforms that have a modem, sensor 0 monitors the modem. > > Signed-off-by: Amit Kucheria > --- > arch/arm64/boot/dts/qcom/msm8916.dtsi | 6 ++ > 1 file changed, 6 insertions(+) > > diff --git

Re: [PATCH v1 01/12] of: Add bindings of thermtrip for Tegra soctherm

2019-02-19 Thread Eduardo Valentin
On Fri, Dec 28, 2018 at 11:28:42AM +0800, Wei Ni wrote: > > > On 28/12/2018 7:06 AM, Rob Herring wrote: > > On Tue, Dec 18, 2018 at 03:34:33PM +0800, Wei Ni wrote: > >> Add optional property "nvidia,thermtrips". > >> If present, these trips will be used as HW shutdown trips, > >> and critical

Re: [PATCH v1 13/24] drivers: thermal: tsens: Print IP version

2019-02-19 Thread Eduardo Valentin
On Thu, Feb 07, 2019 at 04:19:31PM +0530, Amit Kucheria wrote: > On some TSENS IP, version is stored. Print that version at init. > > Signed-off-by: Amit Kucheria > --- > drivers/thermal/qcom/tsens-common.c | 23 ++- > 1 file changed, 22 insertions(+), 1 deletion(-) > >

Re: [PATCH v1 21/24] drivers: thermal: tsens: Add generic support for TSENS v1 IP

2019-02-19 Thread Eduardo Valentin
On Thu, Feb 07, 2019 at 04:19:39PM +0530, Amit Kucheria wrote: > qcs404 has a single TSENS IP block with 10 sensors. It uses version 1.4 > of the TSENS IP, functionality for which is encapsulated inside the > qcom,tsens-v1 compatible. > > Signed-off-by: Amit Kucheria > --- >

Re: [PATCH v1 23/24] arm64: dts: qcom: qcs404: Add thermal zones for each sensor

2019-02-19 Thread Eduardo Valentin
On Thu, Feb 07, 2019 at 04:19:41PM +0530, Amit Kucheria wrote: > qcs404 has 10 sensors connected to the single TSENS IP. Define a thermal > zone for each of those sensors to expose the temperature of each zone. > > Signed-off-by: Amit Kucheria > --- > arch/arm64/boot/dts/qcom/qcs404.dtsi | 243

Re: [PATCH V6 1/4] dt-bindings: fsl: scu: add thermal binding

2019-02-19 Thread Eduardo Valentin
On Tue, Feb 19, 2019 at 07:20:58AM +, Anson Huang wrote: > Ping... I will take a look on this. > > Best Regards! > Anson Huang > > > -Original Message- > > From: Anson Huang > > Sent: 2019年2月13日 13:36 > > To: robh...@kernel.org; mark.rutl...@arm.com; shawn...@kernel.org; > >

Re: [GIT PULL] Thermal-SoC management fixes for v5.0-rc6

2019-02-10 Thread Eduardo Valentin
Hey, Thanks for the note, but.. On Sun, Feb 10, 2019 at 04:25:16AM +, pr-tracker-...@kernel.org wrote: > The pull request you sent on Sat, 9 Feb 2019 20:17:23 -0800: > > > git://git.kernel.org/pub/scm/linux/kernel/git/evalenti/linux-soc-thermal > > fixes > > has been merged into

[GIT PULL] Thermal-SoC management fixes for v5.0-rc6

2019-02-09 Thread Eduardo Valentin
Hello Linus, Please consider pulling from git://git.kernel.org/pub/scm/linux/kernel/git/evalenti/linux-soc-thermal fixes to receive Thermal-SoC Management fixes for v5.0-rc6 with top-most bf78f133cd39e0ed41551150909e41513958a738: thermal: cpu_cooling: Clarify error message (2019-02-05

Re: [PATCH 4/7] thermal: mediatek: add thermal controller offset

2019-02-05 Thread Eduardo Valentin
On Fri, Feb 01, 2019 at 03:38:10PM +0800, michael@mediatek.com wrote: > From: Michael Kao > > One thermal controller can read four sensors at most, > so we need to add controller_offset for the project with > more than four sensors to reuse the same register settings. > > Signed-off-by:

Re: [PATCH 3/7] thermal: mediatek: add calibration item

2019-02-05 Thread Eduardo Valentin
On Mon, Feb 04, 2019 at 06:31:41PM +0100, Matthias Brugger wrote: > > > On 01/02/2019 08:38, michael@mediatek.com wrote: > > From: Michael Kao > > > > Add calibration item in thermal_data to support > > the project with different calibration coefficient. > > > > Signed-off-by: Michael Kao

Re: [PATCH v3 1/1] arm64: dts: sdm845: wireup the thermal trip points to cpufreq

2019-02-05 Thread Eduardo Valentin
tle clusters. > > We throttle lightly at the first trip point, just removing the boost > frequency. At the next trip point we allow ourselves to be throttled to > any extent. > >From OF thermal descriptor, this patch looks fine to me: Acked-by: Eduardo Valentin > Signed-off

Re: [PATCH v6 0/3] Stingray thermal driver support

2019-02-05 Thread Eduardo Valentin
; These patches adds the stingray thermal driver and its > > corresponding DT nodes with documentation. > > > > Changes from v5 > > - Addressed Eduardo Valentin comments. > > > > Changes from v4 > > - Addressed Rob Herring comments on DT parameter

Re: [PATCH v1 0/2] thermal: trivial fixes to error messages

2019-02-05 Thread Eduardo Valentin
On Mon, Jan 21, 2019 at 03:12:21PM +0530, Amit Kucheria wrote: > Fix up a couple of error messages > > Amit Kucheria (2): > thermal: of-thermal: Print name of device node with error > thermal: cpu_cooling: Clarify error message > > drivers/thermal/cpu_cooling.c | 2 +- >

Re: [PATCH V5 2/4] thermal: imx_sc: add i.MX system controller thermal support

2019-02-05 Thread Eduardo Valentin
On Tue, Jan 22, 2019 at 06:54:30AM +, Anson Huang wrote: > Hi, Eduardo > > Best Regards! > Anson Huang > > > -Original Message- > > From: Anson Huang > > Sent: 2019年1月10日 17:28 > > To: 'Eduardo Valentin' > > Cc: 'robh...@kernel.org'

Re: [PATCH V5 2/4] thermal: imx_sc: add i.MX system controller thermal support

2019-02-05 Thread Eduardo Valentin
On Tue, Jan 22, 2019 at 06:54:30AM +, Anson Huang wrote: > Hi, Eduardo > > Best Regards! > Anson Huang Taking a look > > > -Original Message- > > From: Anson Huang > > Sent: 2019年1月10日 17:28 > > To: 'Eduardo Valentin' > > Cc:

[GIT PULL v2] Thermal-SoC management updates for v4.21-rc1

2019-01-02 Thread Eduardo Valentin
interpolation Eduardo Valentin (1): thermal: hwmon: inline helpers when CONFIG_THERMAL_HWMON is not set Fabrizio Castro (2): dt-bindings: thermal: rcar-thermal: add R8A774C0 support thermal: rcar_thermal: add R8A774C0 support Geert Uytterhoeven (1): dt-bindings: thermal: rcar-gen3

Re: [PATCH v5 2/3] thermal: broadcom: Add Stingray thermal driver

2019-01-02 Thread Eduardo Valentin
On Tue, Oct 16, 2018 at 08:41:19PM +0530, Srinath Mannam wrote: > From: Pramod Kumar > > Stingray SoC has six temperature sensor and those are > configured, controlled and accessed to read temperature > and update in DDR memory using m0 firmware. > All six sensors has been given 4 bytes of

Re: [PATCH v2 2/2] mmc: sdhci-omap: Workaround errata regarding SDR104/HS200 tuning failures (i929)

2019-01-02 Thread Eduardo Valentin
On Wed, Jan 02, 2019 at 10:29:31AM -0800, Olof Johansson wrote: > Hi, > > > On Wed, Dec 12, 2018 at 1:20 AM Ulf Hansson wrote: > > > > + Thermal maintainers > > > > On Tue, 11 Dec 2018 at 15:20, Faiz Abbas wrote: > > > > > > Errata i929 in certain OMAP5/DRA7XX/AM57XX silicon revisions > > >

Re: [GIT PULL] Thermal-SoC management updates for v4.21-rc1

2019-01-01 Thread Eduardo Valentin
On Tue, Jan 01, 2019 at 03:32:50PM -0800, Linus Torvalds wrote: > On Tue, Jan 1, 2019 at 3:16 PM Eduardo Valentin wrote: > > > > > It doesn't even build cleanly. > > > > > > > Do you still have have a copy of the build error? > > A plain "make al

Re: [GIT PULL] Thermal-SoC management updates for v4.21-rc1

2019-01-01 Thread Eduardo Valentin
On Tue, Jan 01, 2019 at 01:35:36PM -0800, Linus Torvalds wrote: > On Tue, Jan 1, 2019 at 8:05 AM Eduardo Valentin wrote: > > > > Please consider pulling from > > > > git://git.kernel.org/pub/scm/linux/kernel/git/evalenti/linux-soc-thermal > > linus >

Re: [PATCH v5 0/3] Stingray thermal driver support

2019-01-01 Thread Eduardo Valentin
On Tue, Jan 01, 2019 at 10:04:39PM +0800, Zhang Rui wrote: > On 一, 2018-12-31 at 14:15 -0800, Florian Fainelli wrote: > > > > On 04/12/2018 19:17, Srinath Mannam wrote: > > > > > > Hi, > > > > > > Could you please provide your feedback to this patch series? > > Rui or Eduardo can we get either

[GIT PULL] Thermal-SoC management updates for v4.21-rc1

2019-01-01 Thread Eduardo Valentin
Hello Linus, Please consider pulling from git://git.kernel.org/pub/scm/linux/kernel/git/evalenti/linux-soc-thermal linus to receive Thermal-SoC Management updates for v4.21-rc1 with top-most 055ddb633a35845f106fb732a07c90862e0a43e5: thermal: generic-adc: Fix adc to temp interpolation

Re: [PATCH V5 2/4] thermal: imx_sc: add i.MX system controller thermal support

2018-12-25 Thread Eduardo Valentin
On Thu, Dec 20, 2018 at 09:08:32AM +, Anson Huang wrote: > i.MX8QXP is an ARMv8 SoC which has a Cortex-M4 system controller > inside, the system controller is in charge of controlling power, > clock and thermal sensors etc.. > > This patch adds i.MX system controller thermal driver support, >

Re: [PATCH v6 3/4] thermal: tegra: parse sensor id before sensor register

2018-12-19 Thread Eduardo Valentin
On Wed, Dec 19, 2018 at 11:00:10AM +0800, Wei Ni wrote: > > > On 19/12/2018 9:24 AM, Eduardo Valentin wrote: > > On Fri, Dec 14, 2018 at 05:49:52PM +0800, Wei Ni wrote: > >> Since different platforms may not support all 4 > >> sensors, so the sensor registrat

Re: [PATCH v6 3/4] thermal: tegra: parse sensor id before sensor register

2018-12-18 Thread Eduardo Valentin
On Fri, Dec 14, 2018 at 05:49:52PM +0800, Wei Ni wrote: > Since different platforms may not support all 4 > sensors, so the sensor registration may be failed. > Add codes to parse dt to find sensor id which > need to be registered. So that the registration > can be successful on all platform. > >

Re: [PATCH v6 0/4] Fixes for Tegra soctherm

2018-12-18 Thread Eduardo Valentin
On Tue, Dec 18, 2018 at 11:35:54AM +0800, Zhang Rui wrote: > On 五, 2018-12-14 at 17:54 +0800, Wei Ni wrote: > > Hi Rui, > > I moved get_trend() patch https://lkml.org/lkml/2018/11/20/643 in > > this > > serial. > > Since no more comments on these patches, will you take them? > > > I think Eduardo

Re: [PATCH 3/3] arm64: tegra: p2972: Enable the CPU, GPU and AUX thermal zones

2018-12-15 Thread Eduardo Valentin
On Fri, Nov 23, 2018 at 01:18:39PM +0100, Thierry Reding wrote: > From: Thierry Reding > > Enable these thermal zones to be able to monitor their temperatures and > control the fan to cool down the system if necessary. > > Signed-off-by: Thierry Reding Acked-by

Re: [PATCH 2/3] arm64: tegra: Add thermal zones on Tegra194

2018-12-15 Thread Eduardo Valentin
On Fri, Nov 23, 2018 at 01:18:38PM +0100, Thierry Reding wrote: > From: Thierry Reding > > The NVIDIA Tegra194 SoC defines six thermal zones. Define all of them in > device tree. > > Signed-off-by: Thierry Reding Acked-by: Eduardo Valentin The patch 1 I added i

Re: [PATCH] thermal: stm32: read factory settings inside stm_thermal_prepare

2018-12-14 Thread Eduardo Valentin
On Thu, Dec 06, 2018 at 01:23:32PM +, David HERNANDEZ SANCHEZ wrote: > Calling stm_thermal_read_factory_settings before clocking > internal peripheral causes bad register values and makes > temperature computation wrong. > > Calling stm_thermal_read_factory_settings inside >

[GIT PULL] Thermal-SoC management fixes for v4.20-rc7

2018-12-13 Thread Eduardo Valentin
Hello Linus, Consider pulling the following changes since commit 40e020c129cfc991e8ab4736d2665351ffd1468d: Linux 4.20-rc6 (2018-12-09 15:31:00 -0800) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/evalenti/linux-soc-thermal fixes for you to fetch

[GIT PULL] Thermal-SoC management fixes for v4.20-rc6

2018-12-08 Thread Eduardo Valentin
Hello Linus, Consider pulling the following patches containing fixes on thermal soc. The following changes since commit 0072a0c14d5b7cb72c611d396f143f5dcd73ebe2: Merge tag 'media/v4.20-4' of git://git.kernel.org/pub/scm/linux/kernel/git/mchehab/linux-media (2018-12-03 11:29:20 -0800) are

[GIT PULL] Thermal-SoC management fixes for v4.20-rc6

2018-12-08 Thread Eduardo Valentin
Hello Linus, Consider pulling the following patches containing fixes on thermal soc. The following changes since commit 0072a0c14d5b7cb72c611d396f143f5dcd73ebe2: Merge tag 'media/v4.20-4' of git://git.kernel.org/pub/scm/linux/kernel/git/mchehab/linux-media (2018-12-03 11:29:20 -0800) are

Re: [PATCH v3 2/4] drivers: thermal: tsens: Add generic support for TSENS v1 IP

2018-12-04 Thread Eduardo Valentin
On Tue, Dec 04, 2018 at 04:54:21PM +0530, Amit Kucheria wrote: > On Thu, Nov 29, 2018 at 10:26 PM Eduardo Valentin wrote: > > > > On Tue, Nov 27, 2018 at 09:59:05PM +0530, Amit Kucheria wrote: > > > > > > + qfprom_cdata = (u32 *)qfprom_read(tmdev->d

Re: [PATCH v3 2/4] drivers: thermal: tsens: Add generic support for TSENS v1 IP

2018-12-04 Thread Eduardo Valentin
On Tue, Dec 04, 2018 at 04:54:21PM +0530, Amit Kucheria wrote: > On Thu, Nov 29, 2018 at 10:26 PM Eduardo Valentin wrote: > > > > On Tue, Nov 27, 2018 at 09:59:05PM +0530, Amit Kucheria wrote: > > > > > > + qfprom_cdata = (u32 *)qfprom_read(tmdev->d

Re: [PATCH v3 4/4] arm64: dts: qcom: qcs404: Add thermal zones for each sensor

2018-12-04 Thread Eduardo Valentin
On Tue, Dec 04, 2018 at 04:56:15PM +0530, Amit Kucheria wrote: > On Thu, Nov 29, 2018 at 10:27 PM Eduardo Valentin wrote: > > > > On Tue, Nov 27, 2018 at 09:59:07PM +0530, Amit Kucheria wrote: > > > qcs404 has 10 sensors connected to the single TSENS IP. Define a the

Re: [PATCH v3 4/4] arm64: dts: qcom: qcs404: Add thermal zones for each sensor

2018-12-04 Thread Eduardo Valentin
On Tue, Dec 04, 2018 at 04:56:15PM +0530, Amit Kucheria wrote: > On Thu, Nov 29, 2018 at 10:27 PM Eduardo Valentin wrote: > > > > On Tue, Nov 27, 2018 at 09:59:07PM +0530, Amit Kucheria wrote: > > > qcs404 has 10 sensors connected to the single TSENS IP. Define a the

Re: [PATCH] thermal/drivers/hisi: Fix bad initialization

2018-11-29 Thread Eduardo Valentin
On Thu, Nov 29, 2018 at 07:26:56PM +0100, Daniel Lezcano wrote: > Without this patch, the thermal driver on hi6220 and hi3660 is broken. > > That is due because part of the posted patchset was merged but a small > change in the DT was dropped. > > The hi6220 and hi3660 do not have an interrupt

Re: [PATCH] thermal/drivers/hisi: Fix bad initialization

2018-11-29 Thread Eduardo Valentin
On Thu, Nov 29, 2018 at 07:26:56PM +0100, Daniel Lezcano wrote: > Without this patch, the thermal driver on hi6220 and hi3660 is broken. > > That is due because part of the posted patchset was merged but a small > change in the DT was dropped. > > The hi6220 and hi3660 do not have an interrupt

Re: [PATCH v3] thermal: qoriq: add multiple sensors support

2018-11-29 Thread Eduardo Valentin
On Wed, Nov 21, 2018 at 10:41:36AM +0100, Daniel Lezcano wrote: > On 21/11/2018 10:16, Andy Tang wrote: > > Hi Daniel, > > > > Thanks for your explanation. The problem is these two trees are not synced > > well. > > Let's take our driver(qoriq_thermal.c) for example. > > > > Git log on Rui's

Re: [PATCH v3] thermal: qoriq: add multiple sensors support

2018-11-29 Thread Eduardo Valentin
On Wed, Nov 21, 2018 at 10:41:36AM +0100, Daniel Lezcano wrote: > On 21/11/2018 10:16, Andy Tang wrote: > > Hi Daniel, > > > > Thanks for your explanation. The problem is these two trees are not synced > > well. > > Let's take our driver(qoriq_thermal.c) for example. > > > > Git log on Rui's

Re: [PATCH v3] thermal: qoriq: add multiple sensors support

2018-11-29 Thread Eduardo Valentin
On Wed, Nov 21, 2018 at 09:16:08AM +, Andy Tang wrote: > Hi Daniel, > > Thanks for your explanation. The problem is these two trees are not synced > well. > Let's take our driver(qoriq_thermal.c) for example. > > Git log on Rui's tree next branch: > 2dfef65 thermal: qoriq: Switch to SPDX

  1   2   3   4   5   6   7   8   9   10   >