ldewan...@nvidia.com
Acked-by: Jean Delvare kh...@linux-fr.org
Applied to for-current, thanks.
--
Pengutronix e.K. | Wolfram Sang|
Industrial Linux Solutions | http://www.pengutronix.de/ |
signature.asc
Description: Digital signature
Are you taking these soon? I've rebased on -next, but they're
still in my local delta.
Applied to -next now, will push out later today.
--
Pengutronix e.K. | Wolfram Sang|
Industrial Linux Solutions | http://www.pengutronix.de
)
Laxman Dewangan (1):
i2c: tegra: set irq name as device name
Philippe Begnic (1):
i2c-nomadik: Fixup clock handling
Wolfram Sang (1):
i2c: mxs: remove broken PIOQUEUE support
drivers/i2c/busses/i2c-mxs.c | 186
Jean,
* Wolfram Sang, for joining the crew when it became clear that there
was more review work than Ben and myself could deal with.
Thank you for guiding me when I entered the kernel space and again when
you entrusted me to do maintainer work in i2c.
I hope I did not forget anyone, please
and clk_disable_unprepare
Thomas Kavanagh (1):
i2c: algo: pca: Fix chip reset function for PCA9665
Wolfram Sang (1):
Merge tag 'v3.6-rc7' into i2c-embedded/for-next
.../devicetree/bindings/i2c/atmel-i2c.txt | 30 +
Documentation/devicetree/bindings/i2c/davinci.txt | 28
waiting for event\n, timeout);
- status = timeout;
- }
-
if (timeout == 0) {
/* Controller timed out */
dev_err(dev-adev-dev, write to slave 0x%x timed out\n,
--
1.7.0.4
--
Pengutronix e.K. | Wolfram Sang
Thanks your pointing out. I just manually reviewed the code when found
this point. Would like to try some auto-script but failed:)
I can suggest 'coccinelle' for that kind of job.
--
Pengutronix e.K. | Wolfram Sang|
Industrial Linux Solutions
, 0,
+ ret = devm_request_irq(pdev-dev, irq, ocores_isr, 0,
pdev-name, i2c);
if (ret) {
dev_err(pdev-dev, Cannot claim IRQ\n);
Rest looks good.
--
Pengutronix e.K. | Wolfram Sang|
Industrial Linux
;
+ }
+
I'd think we should handle this via a seperate compatible-entry and
match-data?
Regards,
Wolfram
--
Pengutronix e.K. | Wolfram Sang|
Industrial Linux Solutions | http://www.pengutronix.de/ |
signature.asc
Description
, thanks.
--
Pengutronix e.K. | Wolfram Sang|
Industrial Linux Solutions | http://www.pengutronix.de/ |
signature.asc
Description: Digital signature
e.K. | Wolfram Sang|
Industrial Linux Solutions | http://www.pengutronix.de/ |
signature.asc
Description: Digital signature
return dev-archdata.irqs[num];
91 #else
92 struct resource *r = platform_get_resource(dev, IORESOURCE_IRQ,
num);
93
94 return r ? r-start : -ENXIO;
95 #endif
96 }
97 EXPORT_SYMBOL_GPL(platform_get_irq);
--
Pengutronix e.K. | Wolfram Sang
Probably due to copypaste, some stuff was simply forgotten.
Signed-off-by: Wolfram Sang wolf...@the-dreams.de
---
drivers/base/platform.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/base/platform.c b/drivers/base/platform.c
index 72c776f..d7ea92e 100644
it understands.
Also, remove a reference in one source to the binding documentation, since path
information easily gets stale.
Signed-off-by: Wolfram Sang wolf...@the-dreams.de
Cc: Rob Herring robherri...@gmail.com
Cc: Grant Likely grant.lik...@secretlab.ca
---
I think it would be helpful if other subsystems
: registered GPIOs 477 to 500 on device: tca6424a
Signed-off-by: Sebastien Guiriec s-guir...@ti.com
looks good to me also, should go in v3.8 merge window:
Reviewed-by: Felipe Balbi ba...@ti.com
Applied to for-next, thanks!
--
Pengutronix e.K. | Wolfram Sang
,
read_MASTER_CTL(iface) | STOP);
} else if (iface-cur_mode == TWI_I2C_MODE_REPEAT
--
1.7.0.4
--
Pengutronix e.K. | Wolfram Sang|
Industrial Linux Solutions | http://www.pengutronix.de/ |
signature.asc
Description
.
+ (read_MASTER_CTL(iface) MEN) == 0
(iface-cur_mode == TWI_I2C_MODE_REPEAT ||
iface-cur_mode == TWI_I2C_MODE_COMBINED)) {
iface-result = -1;
--
1.7.0.4
--
Pengutronix e.K. | Wolfram Sang
, read_MASTER_CTL(iface) | MEN |
+ write_MASTER_CTL(iface, read_MASTER_CTL(iface) | MEN | RSTART |
((CONFIG_I2C_BLACKFIN_TWI_CLK_KHZ100) ? FAST : 0));
break;
default:
--
1.7.0.4
--
Pengutronix e.K. | Wolfram Sang
...@samsung.com
Sorry, this dropped of the pile. Applied to next now.
--
Pengutronix e.K. | Wolfram Sang|
Industrial Linux Solutions | http://www.pengutronix.de/ |
signature.asc
Description: Digital signature
,
Wolfram
--
Pengutronix e.K. | Wolfram Sang|
Industrial Linux Solutions | http://www.pengutronix.de/ |
signature.asc
Description: Digital signature
On Mon, Jul 16, 2012 at 01:37:13PM +0200, Linus Walleij wrote:
On Mon, Jul 16, 2012 at 12:17 PM, Wolfram Sang w.s...@pengutronix.de wrote:
And about the perpetual nature of device tree bindings it
appears to me that the modus operandi right now is to not
regard any of these as written
and definitions are still fluid.
See my response to Linus. I do understand your view and where it comes
from. As a maintainer, I have other priorities. No offence involved,
it needs some settlement.
--
Pengutronix e.K. | Wolfram Sang|
Industrial Linux Solutions
On Wed, Apr 10, 2013 at 01:36:36PM +0300, Mika Westerberg wrote:
From: Andy Shevchenko andriy.shevche...@linux.intel.com
This makes the error handling much more simpler than open-coding everything
and in addition makes the probe function smaller and tidier.
Signed-off-by: Andy Shevchenko
Doug,
On Tue, Apr 09, 2013 at 02:34:28PM -0700, Doug Anderson wrote:
The i2c-arb-gpio-challenge driver implements an I2C arbitration scheme
where masters need to claim the bus with a GPIO before they can start
a transcation. This should generally only be used when standard I2C
multimaster
On Wed, Apr 10, 2013 at 10:02:12AM -0700, Guenter Roeck wrote:
On Mon, Apr 08, 2013 at 10:15:19AM -0700, Kevin Strasser wrote:
From: Michael Brunner michael.brun...@kontron.com
Add i2c support for the on-board PLD found on some Kontron embedded
modules.
Signed-off-by: Michael
Hi,
thanks for the submission.
On Thu, Apr 04, 2013 at 09:52:01PM -0700, Naveen Krishna Chatradhi wrote:
From: Naveen Krishna Chatradhi ch.nav...@samsung.com
Adds support for High Speed I2C driver found in Exynos5 and
later SoCs from Samsung.
This driver currently supports Auto mode.
On Tue, Apr 16, 2013 at 09:29:00AM -0700, Doug Anderson wrote:
The i2c-arb-gpio-challenge driver implements an I2C arbitration scheme
where masters need to claim the bus with a GPIO before they can start
a transcation. This should generally only be used when standard I2C
multimaster isn't
On Tue, Apr 16, 2013 at 09:34:58AM -0700, Olof Johansson wrote:
Overdue, should have added a few iterations ago: :)
Why is that? Is the current iteration too generic for your taste?
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to
Ben has done valuable work for the I2C subsystem, yet he has been
inactive for ~15 months. Let MAINTAINERS reflect that. He will be
most welcome if he wants to participate again.
Signed-off-by: Wolfram Sang w...@the-dreams.de
Cc: Ben Dooks ben-li...@fluff.org
---
Ben, please speak up if you want
On Fri, Apr 19, 2013 at 12:01:04AM +, EUNBONG SONG wrote:
I think HZ/50 is better than 2 for adapter timeout.
Basically OK. But why HZ/50? Most drivers use HZ.
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
On Thu, Apr 18, 2013 at 07:40:16AM +, 송은봉 wrote:
I rewrite my patch because the patch before i sent have many white space.
Thanks!
This should have been below the --- after the sigend-off.
---
I've been debugging the abnormal operation of i2c on octeon.
If a process is terminated by
On Fri, Apr 19, 2013 at 09:13:54AM +, EUNBONG SONG wrote:
On Fri, Apr 19, 2013 at 12:01:04AM +, EUNBONG SONG wrote:
I think HZ/50 is better than 2 for adapter timeout.
Basically OK. But why HZ/50? Most drivers use HZ.
Actually, I just translated 2 jiffies because HZ is
Hi,
Very interesting discussion, especially the argument that we already shipped
would not be a convincing argument.
I had senior kernel maintainers tell me and the company I work for that we
should
submit _all_ our platform specific kernel code and drivers for inclusion into
the
Guenter,
I think there is a difference between a bad driver or underlying hardware. To
me, shipped applies to hardware or firmware which can not be upgraded, not
to
the software running on it.
OK. Valuable distinction.
board support hosted in the I2C directory. But that is exactly what I
On Wed, Mar 13, 2013 at 09:36:21AM -0700, Doug Anderson wrote:
The i2c-arbitrator-cros-ec driver implements the arbitration scheme
that the Embedded Controller (EC) on the ARM Chromebook expects to use
for bus multimastering. This i2c-arbitrator-cros-ec driver could also
be used in other
@@ -108,32 +108,27 @@ static int dw_i2c_probe(struct platform_device *pdev)
return irq; /* -ENXIO */
}
- ioarea = request_mem_region(mem-start, resource_size(mem),
- pdev-name);
- if (!ioarea) {
- dev_err(pdev-dev, I2C region
@@ -296,10 +273,11 @@ static int i2c_dw_pci_probe(struct pci_dev *pdev,
snprintf(adap-name, sizeof(adap-name), i2c-designware-pci-%d,
adap-nr);
- r = request_irq(pdev-irq, i2c_dw_isr, IRQF_SHARED, adap-name, dev);
+ r = devm_request_irq(pdev-dev, pdev-irq,
On Thu, Mar 21, 2013 at 02:09:57AM -, Mika Westerberg wrote:
It is not good idea to mix static and dynamic I2C adapter numbering. In
this particular case on Lynxpoint we had graphics I2C adapter which took
the first numbers preventing the designware I2C driver from using the
adapter
+static void __i2c_dw_enable(struct dw_i2c_dev *dev, bool enable)
+{
+ int timeout = 100;
+
+ do {
+ dw_writel(dev, enable, DW_IC_ENABLE);
+ if ((dw_readl(dev, DW_IC_ENABLE_STATUS) 1) == enable)
+ return;
+
+
i2c_dw_disable_int(dev);
- r = request_irq(dev-irq, i2c_dw_isr, IRQF_SHARED, pdev-name, dev);
+ r = devm_request_irq(pdev-dev, dev-irq, i2c_dw_isr, IRQF_SHARED,
+ pdev-name, dev);
Is it ensured that no interrupts will happen during remove? Because the
adapter
On Tue, Apr 09, 2013 at 12:28:36PM +0300, Mika Westerberg wrote:
On Tue, Apr 09, 2013 at 11:09:14AM +0200, Wolfram Sang wrote:
+static void __i2c_dw_enable(struct dw_i2c_dev *dev, bool enable)
+{
+ int timeout = 100;
+
+ do {
+ dw_writel(dev, enable, DW_IC_ENABLE
On Tue, Apr 09, 2013 at 12:23:19PM +0300, Mika Westerberg wrote:
On Tue, Apr 09, 2013 at 11:06:05AM +0200, Wolfram Sang wrote:
On Thu, Mar 21, 2013 at 02:09:57AM -, Mika Westerberg wrote:
It is not good idea to mix static and dynamic I2C adapter numbering. In
this particular case
On Mon, Mar 18, 2013 at 05:52:13PM +0400, Sergey Gerasimov wrote:
Signed-off-by: Sergey Gerasimov sergey.gerasi...@astrosoft-development.com
NAK. Page size may differ across vendors, so we can't hardcode values in
that table. There is a pagesize property for devicetree.
And please make sure you
On Tue, Apr 09, 2013 at 09:46:39AM +0800, Yijing Wang wrote:
CONFIG_HOTPLUG is going away as an option, cleanup CONFIG_HOTPLUG
ifdefs in i2c files.
Signed-off-by: Yijing Wang wangyij...@huawei.com
Applied to for-next, thanks!
--
To unsubscribe from this list: send the line unsubscribe
On Wed, Apr 10, 2013 at 07:59:17PM +0900, Kukjin Kim wrote:
Doug Anderson wrote:
We need to use the i2c-arbitrator to talk to any of the devices on i2c
bus 4 on exynos5250-snow so that we don't confuse the embedded
controller (EC). Add the i2c-arbitrator to the device tree. As we
add
any update on your patch series to support CGEB? I have some time to
work on these patches but I don't want to duplicate the work. I really
want this watches to hit mainline soon.
I acked the I2C patch and this is all I can do for this series.
--
To unsubscribe from this list: send the line
On Thu, Apr 11, 2013 at 02:04:50AM +0200, Arnd Bergmann wrote:
No other file in the kernel besides i2c-s3c2410.c uses the current
plat/regs-iic.h, so we can simply move the header file to live in the
same directory as the driver, as a preparation to multiplatform builds.
What about putting
On Tue, Mar 05, 2013 at 05:14:45PM +0530, Vishwanathrao Badarkhe, Manish wrote:
Update the code to use devm_* API so that driver
core will manage resources.
Signed-off-by: Vishwanathrao Badarkhe, Manish manish...@ti.com
Applied the following fix:
+ dev-base =
On Sat, Mar 09, 2013 at 07:16:43PM +0100, Lars-Peter Clausen wrote:
Currently i2c_del_adapter() returns 0 on success and potentially an error code
on failure. Unfortunately this doesn't mix too well with the Linux device
driver
model. An i2c_adapter is usually registered in a drivers probe
On Sat, Mar 09, 2013 at 07:16:46PM +0100, Lars-Peter Clausen wrote:
i2c_del_adapter() always returns 0. So all checks testing whether it will be
non zero will always evaluate to false and the conditional code is dead code.
This patch updates all callers of i2c_del_mux_adapter() to ignore the
...@intel.com
Shall this go via the I2C tree? If not, for the I2C part:
Acked-by: Wolfram Sang w...@the-dreams.de
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Sat, Mar 09, 2013 at 07:16:43PM +0100, Lars-Peter Clausen wrote:
Currently i2c_del_adapter() returns 0 on success and potentially an error code
on failure. Unfortunately this doesn't mix too well with the Linux device
driver
model. An i2c_adapter is usually registered in a drivers probe
Hi,
working on the transparency thing here regarding the current I2C
workflow. I am currently on, well, let's call it something between
holiday and retreat. I will work on (hopefully all) pending I2C patches
half-time until Friday and then probably disappear for about 3 weeks
again. Disappearing
On Thu, Feb 14, 2013 at 12:28:18PM +0100, Cong Ding wrote:
If it goes to eclk through line 1107, the variable res would be NULL. It will
cause a null pointer dereference error if we call release_mem_region. The
correct way should be using devm_kzalloc rather than kzalloc to allocate
memory.
On Fri, Mar 01, 2013 at 08:57:32AM -0800, Doug Anderson wrote:
The commit: i2c-core: dt: Pick i2c bus number from i2c alias if
present adds support for automatically picking the bus number based
on the alias ID. Remove the now unnecessary code from i2c-pxa that
did the same thing.
On Fri, Mar 15, 2013 at 09:04:08PM +0530, Laxman Dewangan wrote:
NVIDIA's Tegra SoC allows read/write of controller register only
if controller clock is enabled. System hangs if read/write happens
to registers without enabling clock.
clk_prepare_enable() can be fail due to unknown reason and
On Thu, Feb 21, 2013 at 02:30:43PM -0800, Seth Heasley wrote:
This patch adds the iSMT SMBus Controller DeviceIDs for the Intel Avoton SOC.
Signed-off-by: Seth Heasley seth.heas...@intel.com
Applied to for-current, thanks!
--
To unsubscribe from this list: send the line unsubscribe
On Fri, Mar 15, 2013 at 04:32:57PM +0100, ludovic.desroc...@atmel.com wrote:
From: Ludovic Desroches ludovic.desroc...@atmel.com
Create an entry for atmel i2c driver: i2c-at91.c
Signed-off-by: Ludovic Desroches ludovic.desroc...@atmel.com
Applied to for-current, thanks!
--
To unsubscribe
On Tue, Feb 26, 2013 at 09:08:43PM +, 송은봉 wrote:
I've been debugging the abnormal operation of i2c on octeon.
If a process is terminated by signal in the middle of i2c operation,
next i2c read operation which is done by another process was failed.
So i changed to ignore signal in the
Linus,
please pull the updates for the 3.9 kernel. There is one bugfix for the
tegra driver. There are two updates regarding email addresses and
MAINTAINERS which I like to have up-to-date so people can be reached
immediately. While we are here, there is on PCI_ID addition.
Thanks,
Wolfram
+ /* CLK_DIV max is 256 */
+ for (i = 0; i 256; i++) {
+ utemp1 = utemp0 / (i + 1);
+ /* SCLK_L/H max is 256 / 2 */
+ if (utemp1 128) {
I think TSCLK_L and TSCLK_H both can be configured upto 255.Why
limiting it to 128 ?
By
Hi Sascha,
Any other comments to this series? Is the base cgeb support ok to
include?
I had a few comments to the I2C driver.
All the best,
Wolfram
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo
0x08/* chip is fram not eeprom */
void(*setup)(struct memory_accessor *, void *context);
void*context;
Thanks for your interest nonetheless,
Wolfram
--
Pengutronix e.K. | Wolfram Sang|
Industrial
Change to my private email, change to my shiny new kernel.org repos,
and drop outdated entry from the former maintainer. Drop my PCA entry,
too, since it belongs to the I2C realm anyhow.
Signed-off-by: Wolfram Sang wolf...@the-dreams.de
---
MAINTAINERS | 16 +++-
1 file changed, 3
Hi,
thanks for doing this cleanup series. Looks very worthwhile!
--- a/drivers/i2c/i2c-core.c
+++ b/drivers/i2c/i2c-core.c
@@ -935,25 +935,16 @@ out_list:
*/
int i2c_add_adapter(struct i2c_adapter *adapter)
{
- int id, res = 0;
-
-retry:
- if
as described above.
This leaves MAX_IDR_MASK without any user, remove it and relocate
other MAX_IDR_* constants to lib/idr.c.
Signed-off-by: Tejun Heo t...@kernel.org
For the i2c-part:
Acked-by: Wolfram Sang wolf...@the-dreams.de
--
To unsubscribe from this list: send the line unsubscribe
Hi Doug,
On Mon, Jan 14, 2013 at 10:53:21AM -0800, Doug Anderson wrote:
This allows you to get the equivalent functionality of
i2c_add_numbered_adapter() with all data in the device tree and no
special case code in your driver. This is a common device tree
technique.
For quick reference,
what happend to this one ? It was a patch updating Kconfig help for at24.
Do you know linux-next? Have a look there...
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at
Seth recently sent a patch adding IDs for the Avoton:
http://marc.info/?l=linux-kernelm=135959209218860w=2
Your patch conflicts with his. Please rebase on top of Seth's patch, so
that both patches can be applied in sequence.
Yes, please.
--- a/drivers/i2c/busses/i2c-i801.c
+++
eeprom do you have? Check its datasheet, some in deed use 8 addresses.
Regards,
Wolfram
--
Pengutronix e.K. | Wolfram Sang|
Industrial Linux Solutions | http://www.pengutronix.de/ |
signature.asc
Description: Digital signature
On Tue, Feb 26, 2013 at 11:02:17AM +0100, Jiri Kosina wrote:
On Fri, 22 Feb 2013, 송은봉 wrote:
I've been debugging the abnormal operation of i2c on octeon.
If a process is terminated by signal in the middle of i2c operation,
next i2c read operation which is done by another process
commit 6b4d0b27 (clean shmem_file_setup() a bit) broke allnoconfig since
this needs the NOMMU path where 'error' is still needed:
mm/shmem.c:2935:2: error: 'error' undeclared (first use in this function)
Signed-off-by: Wolfram Sang w...@the-dreams.de
Cc: Al Viro v...@zeniv.linux.org.uk
---
mm
Doug Anderson (2):
i2c-core: dt: Pick i2c bus number from i2c alias if present
i2c: pxa: Use i2c-core to get bus number now
drivers/i2c/busses/i2c-pxa.c | 20
drivers/i2c/i2c-core.c | 54
2 files changed, 49
On Fri, Mar 01, 2013 at 08:57:31AM -0800, Doug Anderson wrote:
This allows you to get the equivalent functionality of
i2c_add_numbered_adapter() with all data in the device tree and no
special case code in your driver. This is a common device tree
technique.
For quick reference, the FDT
. | Wolfram Sang|
Industrial Linux Solutions | http://www.pengutronix.de/ |
signature.asc
Description: Digital signature
On Thu, Jan 24, 2013 at 07:18:47PM +0800, Mark Brown wrote:
On Thu, Jan 24, 2013 at 12:13:29PM +0100, Wolfram Sang wrote:
On Sat, Dec 15, 2012 at 11:21:36PM +0900, Mark Brown wrote:
also get things like read operations which appear as multiple
transactions on the I2C bus so require
,
Wolfram
--
Pengutronix e.K. | Wolfram Sang|
Industrial Linux Solutions | http://www.pengutronix.de/ |
signature.asc
Description: Digital signature
will
free the interrupt only after remove has finished. Interrupts need to be
properly masked out before.
Regards,
Wolfram
--
Pengutronix e.K. | Wolfram Sang|
Industrial Linux Solutions | http://www.pengutronix.de/ |
signature.asc
;
+ int use_smbuse_write;
Can't you use the same 'use_smbus' variable and do a similar switch-case
as in the read function?
Regards,
Wolfram
--
Pengutronix e.K. | Wolfram Sang|
Industrial Linux Solutions | http://www.pengutronix.de
to that.
--
Pengutronix e.K. | Wolfram Sang|
Industrial Linux Solutions | http://www.pengutronix.de/ |
signature.asc
Description: Digital signature
can be removed from the failure code paths.
Signed-off-by: Thierry Reding thierry.red...@avionic-design.de
Cc: Wolfram Sang w.s...@pengutronix.de
Cc: Ben Dooks ben-li...@fluff.org
Cc: linux-...@vger.kernel.org
I still have the concerns I mentioned in the previous discussion but the
series
On Tue, Jan 08, 2013 at 02:40:09PM +0100, Laurent Navet wrote:
sizeof when applied to a pointer typed expression gives the size of
the pointer
The semantic patch that makes this output is available
in scripts/coccinelle/misc/noderef.cocci.
More information about semantic patching is
|6 +++---
drivers/i2c/busses/i2c-sirf.c|4
drivers/i2c/muxes/i2c-mux-pinctrl.c |2 +-
5 files changed, 16 insertions(+), 6 deletions(-)
--
Pengutronix e.K. | Wolfram Sang|
Industrial Linux Solutions | http
On Fri, Nov 23, 2012 at 02:11:51PM +0530, Tushar Behera wrote:
This patchset cleans up the probe function of i2c-s3c2410 driver.
These have been tested on Exynos4210 based Origen board.
Changes since V1:
* devm_request_mem_region and devm_ioremap calls were replaced by
On Fri, Dec 07, 2012 at 11:14:28AM +0100, Lars Poeschel wrote:
I wanted to use a fm24c04 i2c fram chip with linux. I grepped the
source and found nothing. I later found that my chip can be handled
by at24 eeprom driver. It creates a sysfs file called eeprom to
read from and
On Thu, Jan 10, 2013 at 03:07:42PM +0100, Laurent Navet wrote:
avoid these checkpatch.pl issues :
- ERROR: foo * bar should be foo *bar
- ERROR: switch and case should be at the same indent
- ERROR: (foo*) should be (foo *)
- ERROR: do not use assignment in if condition
- ERROR: space
On Sat, Jan 05, 2013 at 05:34:46PM +0530, Laxman Dewangan wrote:
NVIDIA's Tegra114 has following enhanced feature in i2c controller:
- Enable/disable control for per packet transfer complete interrupt.
Earlier SoCs could not disable this.
- Single clock source for standard/fast and HS mode
On Thu, Jan 17, 2013 at 12:31:03PM +0200, Mika Westerberg wrote:
Hi all,
This series adds support for the Intel Lynxpoint Low Power Subsystem I2C
controllers. They are compatible with the DesignWare I2C controller.
Patches [1/4] and [2/4] are fixes that are necessary to get the driver
understanding. Please put me on CC, if you post the patches.
Regards,
Wolfram
--
Pengutronix e.K. | Wolfram Sang|
Industrial Linux Solutions | http://www.pengutronix.de/ |
signature.asc
Description: Digital signature
-by: Tejun Heo t...@kernel.org
Acked-by: Wolfram Sang wolf...@the-dreams.de
Would be nice to fold this patch into the previous one, if possible.
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info
-by: Wolfram Sang w...@the-dreams.de
Otherwise, let me know if and when I should pick it up.
Thanks,
Wolfram
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo
/platform_data/i2c-s3c2410.h:37:26: warning: 'struct
platform_device' declared inside parameter list [enabled by default]
Signed-off-by: Arnd Bergmann a...@arndb.de
Fine with me:
Acked-by: Wolfram Sang w...@the-dreams.de
--
To unsubscribe from this list: send the line unsubscribe linux-kernel
On Fri, Feb 15, 2013 at 06:31:07PM +0530, Shubhrajyoti Datta wrote:
On Thu, Feb 14, 2013 at 6:13 PM, Laxman Dewangan ldewan...@nvidia.com wrote:
If timeout error occurs in the i2c transfer then it was dumping warning
of call stack.
Remove the warning dump as there is may be possibility
On Sat, Feb 02, 2013 at 02:14:57PM -,
=?utf-8?q?Peter_H=C3=BCwe_=3CPeterHuewe=40gmx=2Ede=3E?= wrote:
Replace a call to devm_request_mem_region followed by a call to
dev_ioremap_nocache with devm_request_and_ioremap which does the same.
And since res_size isn't needed anymore we can remove
On Thu, Feb 07, 2013 at 06:22:00PM +0530, Vishwanathrao Badarkhe, Manish wrote:
Update the code to use devm_* API so that driver
core will manage resources.
Also, if devm_request_and_ioremap fails return -EADDRNOTAVAIL
instead of -EBUSY.
Signed-off-by: Vishwanathrao Badarkhe, Manish
On Thu, Feb 14, 2013 at 06:13:33PM +0530, Laxman Dewangan wrote:
If timeout error occurs in the i2c transfer then it was dumping warning
of call stack.
Remove the warning dump as there is may be possibility that some slave
devices are busy and not responding the i2c communication.
On Fri, Feb 15, 2013 at 10:41:22AM -0800, Doug Anderson wrote:
Stephen Warren pointed out as part of a code review of another mux
driver that there should be no need to have
platform_set_drvdata(pdev, NULL) in the remove function. Get rid of
it in the i2c-mux-gpio driver.
See Stephen's
On Fri, Feb 15, 2013 at 10:51:40AM -0800, Randy Dunlap wrote:
From: Randy Dunlap rdun...@infradead.org
Fix printk format warning. dma_addr_t can be 32-bit or 64-bit,
so cast it to long long for printing. This also matches the
printk format specifier that is already used.
I'll re-send with I2C subsystem wide. I probably won't attempt the
whole kernel wide at this point, but would be very happy if someone
else wanted to! :)
Thanks. Please double check that setting NULL is really unneeded for the
non-platform-bus variants, too, or skip those if you are unsure.
On Fri, Feb 15, 2013 at 12:40:47PM -0700, Stephen Warren wrote:
On 02/15/2013 12:18 PM, Wolfram Sang wrote:
On Thu, Feb 14, 2013 at 06:13:33PM +0530, Laxman Dewangan wrote:
If timeout error occurs in the i2c transfer then it was dumping warning
of call stack.
Remove the warning dump
1 - 100 of 7563 matches
Mail list logo
