Re: [RFC PATCH 1/8] stk-webcam: various fixes.

2013-02-10 Thread Hans Verkuil
On Sat February 9 2013 12:22:12 Arvydas Sidorenko wrote: On Fri, Feb 8, 2013 at 10:20 AM, Hans Verkuil hverk...@xs4all.nl wrote: Thanks for the testing! I've pushed some more improvements to my git branch. Hopefully the compliance tests are now running OK. Please check the dmesg output as

Re: [RFC PATCH 1/8] stk-webcam: various fixes.

2013-02-10 Thread Arvydas Sidorenko
On Sun, Feb 10, 2013 at 8:28 AM, Hans Verkuil hverk...@xs4all.nl wrote: I've improved this message, so please run again with the latest code and let me know what it says. I don't understand all the upside-down problems... $ dmesg | grep upside upside down: 0 -1 -1 -- To unsubscribe from

Re: [RFC PATCH 1/8] stk-webcam: various fixes.

2013-02-10 Thread Hans Verkuil
On Sun February 10 2013 15:46:05 Arvydas Sidorenko wrote: On Sun, Feb 10, 2013 at 8:28 AM, Hans Verkuil hverk...@xs4all.nl wrote: I've improved this message, so please run again with the latest code and let me know what it says. I don't understand all the upside-down problems... $

Re: [RFC PATCH 1/8] stk-webcam: various fixes.

2013-02-10 Thread Arvydas Sidorenko
On Sun, Feb 10, 2013 at 3:02 PM, Hans Verkuil hverk...@xs4all.nl wrote: Thanks, I found the bug. It's my fault: I made a logic error w.r.t. setting up the initial hflip/vflip values. I've read over it dozens of times without actually catching the - rather obvious - bug :-) Get the latest

Re: [RFC PATCH 1/8] stk-webcam: various fixes.

2013-02-10 Thread Hans Verkuil
On Sun February 10 2013 17:16:30 Arvydas Sidorenko wrote: On Sun, Feb 10, 2013 at 3:02 PM, Hans Verkuil hverk...@xs4all.nl wrote: Thanks, I found the bug. It's my fault: I made a logic error w.r.t. setting up the initial hflip/vflip values. I've read over it dozens of times without

Re: [RFC PATCH 1/8] stk-webcam: various fixes.

2013-02-09 Thread Arvydas Sidorenko
On Fri, Feb 8, 2013 at 10:20 AM, Hans Verkuil hverk...@xs4all.nl wrote: Thanks for the testing! I've pushed some more improvements to my git branch. Hopefully the compliance tests are now running OK. Please check the dmesg output as well. In addition I've added an 'upside down' message to

Re: [RFC PATCH 1/8] stk-webcam: various fixes.

2013-02-08 Thread Hans Verkuil
On Thu February 7 2013 23:39:58 Arvydas Sidorenko wrote: On Wed, Feb 6, 2013 at 8:32 AM, Hans Verkuil hverk...@xs4all.nl wrote: I've improved v4l2-compliance a bit, but I've also pushed a fix (I hope) to my git branch. It's great if you can test this! Thanks for the testing! I've

Re: [RFC PATCH 1/8] stk-webcam: various fixes.

2013-02-07 Thread Arvydas Sidorenko
On Wed, Feb 6, 2013 at 8:32 AM, Hans Verkuil hverk...@xs4all.nl wrote: I've improved v4l2-compliance a bit, but I've also pushed a fix (I hope) to my git branch. It's great if you can test this! $ v4l2-compliance -d /dev/video0 Driver Info: Driver name : stk Card type

Re: [RFC PATCH 1/8] stk-webcam: various fixes.

2013-02-05 Thread Arvydas Sidorenko
On Mon, Feb 4, 2013 at 2:35 PM, Hans Verkuil hverk...@xs4all.nl wrote: Hi Arvydas, Yes indeed, it would be great if you could test this! Note that the patch series is also available in my git tree: http://git.linuxtv.org/hverkuil/media_tree.git/shortlog/refs/heads/stkwebcam Besides the

Re: [RFC PATCH 1/8] stk-webcam: various fixes.

2013-02-05 Thread Hans Verkuil
On Tue February 5 2013 16:28:17 Arvydas Sidorenko wrote: On Mon, Feb 4, 2013 at 2:35 PM, Hans Verkuil hverk...@xs4all.nl wrote: Hi Arvydas, Yes indeed, it would be great if you could test this! Note that the patch series is also available in my git tree:

Re: [RFC PATCH 1/8] stk-webcam: various fixes.

2013-02-05 Thread Ezequiel Garcia
On Tue, Feb 5, 2013 at 12:35 PM, Hans Verkuil hverk...@xs4all.nl wrote: On Tue February 5 2013 16:28:17 Arvydas Sidorenko wrote: On Mon, Feb 4, 2013 at 2:35 PM, Hans Verkuil hverk...@xs4all.nl wrote: Hi Arvydas, Yes indeed, it would be great if you could test this! Note that the

Re: [RFC PATCH 1/8] stk-webcam: various fixes.

2013-02-05 Thread Arvydas Sidorenko
On Tue, Feb 5, 2013 at 5:56 PM, Ezequiel Garcia elezegar...@gmail.com wrote: On Tue, Feb 5, 2013 at 12:35 PM, Hans Verkuil hverk...@xs4all.nl wrote: On Tue February 5 2013 16:28:17 Arvydas Sidorenko wrote: I have tested the patches using STK-1135 webcam. Everything works well. $

Re: [RFC PATCH 1/8] stk-webcam: various fixes.

2013-02-05 Thread Hans Verkuil
On Tue February 5 2013 18:08:31 Arvydas Sidorenko wrote: On Tue, Feb 5, 2013 at 5:56 PM, Ezequiel Garcia elezegar...@gmail.com wrote: On Tue, Feb 5, 2013 at 12:35 PM, Hans Verkuil hverk...@xs4all.nl wrote: On Tue February 5 2013 16:28:17 Arvydas Sidorenko wrote: I have tested the patches

Re: [RFC PATCH 1/8] stk-webcam: various fixes.

2013-02-05 Thread Hans Verkuil
On Tue February 5 2013 19:41:31 Hans Verkuil wrote: Buffer ioctls: fail: v4l2-test-buffers.cpp(132): ret != -1 I need to look into this a bit more. I probably need to improve v4l2-compliance itself so I get better feedback as to which error is actually returned here. I've

[RFC PATCH 1/8] stk-webcam: various fixes.

2013-02-04 Thread Hans Verkuil
This patch series updates this driver to the control framework, switches it to unlocked_ioctl, fixes a variety of V4L2 compliance issues. It compiles, but to my knowledge nobody has hardware to test this :-( If anyone has hardware to test this, please let me know! Regards, Hans -- To

Re: [RFC PATCH 1/8] stk-webcam: various fixes.

2013-02-04 Thread Hans de Goede
Hi, On 02/04/2013 01:36 PM, Hans Verkuil wrote: This patch series updates this driver to the control framework, switches it to unlocked_ioctl, fixes a variety of V4L2 compliance issues. Good stuff! It compiles, but to my knowledge nobody has hardware to test this :-( If anyone has hardware

Re: [RFC PATCH 1/8] stk-webcam: various fixes.

2013-02-04 Thread Ezequiel Garcia
Hello Hans, On Mon, Feb 4, 2013 at 9:36 AM, Hans Verkuil hverk...@xs4all.nl wrote: This patch series updates this driver to the control framework, switches it to unlocked_ioctl, fixes a variety of V4L2 compliance issues. It compiles, but to my knowledge nobody has hardware to test this :-(

Re: [RFC PATCH 1/8] stk-webcam: various fixes.

2013-02-04 Thread Hans Verkuil
On Mon February 4 2013 14:23:55 Ezequiel Garcia wrote: Hello Hans, On Mon, Feb 4, 2013 at 9:36 AM, Hans Verkuil hverk...@xs4all.nl wrote: This patch series updates this driver to the control framework, switches it to unlocked_ioctl, fixes a variety of V4L2 compliance issues. It