[PATCH] mmc: read alias from device-tree if probing via of.

2015-10-02 Thread Ben Dooks
: aliases { mmc0 = mmc2 = } Signed-off-by: Ben Dooks <ben.do...@codethink.co.uk> Tested-by: Kejia Hu <kejia...@codethink.co.uk> --- drivers/mmc/core/host.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/mmc/core/host.c b/drivers/mmc

3.18 SDIO driver re-attach issue

2015-06-10 Thread Ben Dooks
happens? Currently we ignore the error and the wifi driver seems to be working with the device. If there is a better fix then we would like to know so it can be fixed properly up-stream. -- Ben Dooks http://www.codethink.co.uk/ Senior Engineer

[RFC 6/6] mmc: atmel-mci: use atmel_io.h to provide on-chip IO

2015-03-26 Thread Ben Dooks
Use linux/atmel_io.h to provide IO accessors which work on both AVR32 and ARM for on-chip peripherals. Signed-off-by: Ben Dooks ben.do...@codethink.co.uk -- CC: Ludovic Desroches ludovic.desroc...@atmel.com CC: Chris Ball ch...@printf.net CC: Ulf Hansson ulf.hans...@linaro.org CC: linux-mmc

[PATCH RESEND 6/7] mmc: host: dw_mmc: change idmac descriptor files to __le32

2015-03-25 Thread Ben Dooks
. Signed-off-by: Ben Dooks ben.do...@codethink.co.uk -- CC: Linux MCC linux-mmc@vger.kernel.org CC: Linux ARM Kernel linux-arm-ker...@lists.infradead.org CC: Dinh Nguyen dingu...@opensource.altera.com CC: Chris Ball ch...@printf.net CC: Ulf Hansson ulf.hans...@linaro.org CC: Jaehoon Chung jh80.ch

[PATCH 6/7] mmc: host: dw_mmc: change idmac descriptor files to __le32

2015-03-25 Thread Ben Dooks
. Signed-off-by: Ben Dooks ben.do...@codethink.co.uk -- CC: Linux MCC linux-mmc@vger.kernel.org CC: Linux ARM Kernel linux-arm-ker...@lists.infradead.org CC: Dinh Nguyen dingu...@opensource.altera.com CC: Chris Ball ch...@printf.net CC: Ulf Hansson ulf.hans...@linaro.org CC: Jaehoon Chung jh80.ch

[PATCH 7/7] mmc: host: dw_mmc: fix fifo ordering in big endian

2015-03-25 Thread Ben Dooks
, it would be easier just to store the pointer to the fifo registers in the host block instead of the offset to them. So change the host-data_offset to host-fifo_reg (which also means we catch all the places this is read or written). Signed-off-by: Ben Dooks ben.do...@codethink.co.uk -- CC: Linux MMC linux

[PATCH 5/7] mmc: host: dw_mmc make IO accessors endian agnostic

2015-03-25 Thread Ben Dooks
The dw_mmc driver does not use endian agnostic IO accessors, so fix the use of __raw reads and writes to be the relaxed versions. This fixes the dw_mmc driver initialisation on Altera socfpga in big endian. Signed-off-by: Ben Dooks ben.do...@codethink.co.uk -- CC: Linux MMC linux-mmc

[PATCH RESEND 7/7] mmc: host: dw_mmc: fix fifo ordering in big endian

2015-03-25 Thread Ben Dooks
, it would be easier just to store the pointer to the fifo registers in the host block instead of the offset to them. So change the host-data_offset to host-fifo_reg (which also means we catch all the places this is read or written). Signed-off-by: Ben Dooks ben.do...@codethink.co.uk -- CC: Linux MMC linux

[PATCH RESEND 5/7] mmc: host: dw_mmc make IO accessors endian agnostic

2015-03-25 Thread Ben Dooks
The dw_mmc driver does not use endian agnostic IO accessors, so fix the use of __raw reads and writes to be the relaxed versions. This fixes the dw_mmc driver initialisation on Altera socfpga in big endian. Signed-off-by: Ben Dooks ben.do...@codethink.co.uk -- CC: Linux MMC linux-mmc

Re: [Linux-kernel] [PATCH 12/13] mmc: atmel-mci: use endian agnostic IO

2015-03-24 Thread Ben Dooks
On 19/03/15 14:22, Ben Hutchings wrote: On Wed, 2015-03-18 at 15:53 +, Ben Dooks wrote: Change the __raw IO functions to endian agnostic relaxed ones to allow the driver to function on big endian ARM systems. Signed-off-by: Ben Dooks ben.do...@codethink.co.uk -- CC: Ludovic Desroches

[PATCH 12/13] mmc: atmel-mci: use endian agnostic IO

2015-03-18 Thread Ben Dooks
Change the __raw IO functions to endian agnostic relaxed ones to allow the driver to function on big endian ARM systems. Signed-off-by: Ben Dooks ben.do...@codethink.co.uk -- CC: Ludovic Desroches ludovic.desroc...@atmel.com CC: Chris Ball ch...@printf.net CC: Ulf Hansson ulf.hans...@linaro.org

resend - sh mmcif driver cleanup patch series

2014-06-04 Thread Ben Dooks
This is a re-send of the mmcif driver cleanups that seem to have been missed. If possible, could this be merged for the current merge window? These should be available at: http://git.codethink.co.uk/linux.git bjdooks/315-rc8/mmcif -- To unsubscribe from this list: send the line

[PATCH 2/6] mmc: sh-mmcif: use devm_ for ioremap

2014-06-04 Thread Ben Dooks
Start tidying the probe/release code by using devm_ioremap_resource() to map the IO registers. Signed-off-by: Ben Dooks ben.do...@codethink.co.uk --- Fixes from v1: - return the PTR_ERR() from devm_ioremap - remove error print as it already shows an error --- drivers/mmc/host

[PATCH 6/6] mmc: sh-mmcif: final error path cleanup

2014-06-04 Thread Ben Dooks
Remove the error path items that are no longer needed. The mmc card-detect code cleans up after itself (and registers with devm) and the host error is the same as the clock disable. Signed-off-by: Ben Dooks ben.do...@codethink.co.uk --- drivers/mmc/host/sh_mmcif.c | 6 ++ 1 file changed, 2

[PATCH 3/6] mmc: sh-mmcif: use devm_ for clock management

2014-06-04 Thread Ben Dooks
Use the devm_clk_get() code to get the clock and allow it to be freed automatically on release. Signed-off-by: Ben Dooks ben.do...@codethink.co.uk --- drivers/mmc/host/sh_mmcif.c | 18 -- 1 file changed, 8 insertions(+), 10 deletions(-) diff --git a/drivers/mmc/host/sh_mmcif.c b

[PATCH 4/6] mmc: sh-mmcif: use devm_ for irq management

2014-06-04 Thread Ben Dooks
Use devm_request_threaded_irq() for the host interrupt handlers so we do not have to worry about freeing them on exit or error. Tidies up the exit path code for the driver. Signed-off-by: Ben Dooks ben.do...@codethink.co.uk --- drivers/mmc/host/sh_mmcif.c | 26 -- 1 file

[PATCH 1/6] mmc: sh-mmcif: update to print version and bus clock rate on probe

2014-06-04 Thread Ben Dooks
Change the initial print to show chip version and the bus rate it is working at instead of the driver version. This is more useful information as we already know which driver version from the kernel it is in. Signed-off-by: Ben Dooks ben.do...@codethink.co.uk --- drivers/mmc/host/sh_mmcif.c | 9

Re: [GIT PULL] MMC for v.3.16

2014-06-02 Thread Ben Dooks
in? I posted them some time ago but they do not seem to have been applied. -- Ben Dooks, b...@fluff.org, http://www.fluff.org/ben/ Large Hadron Colada: A large Pina Colada that makes the universe disappear. -- To unsubscribe from this list: send the line unsubscribe linux-mmc in the body

Re: [PATCH 3/3] mmc: tmio: care about DMA tx/rx addr offset

2014-05-30 Thread Ben Dooks
-by: Ben Dooks ben-li...@fluff.org -- Ben Dooks, b...@fluff.org, http://www.fluff.org/ben/ Large Hadron Colada: A large Pina Colada that makes the universe disappear. -- To unsubscribe from this list: send the line unsubscribe linux-mmc in the body of a message to majord...@vger.kernel.org More

Re: [PATCH 1/3] mmc: block: add block number limitation flag for lultiple block read

2014-05-30 Thread Ben Dooks
. If you do that, then there is around a 8-10x performance penalty. -- Ben Dooks, b...@fluff.org, http://www.fluff.org/ben/ Large Hadron Colada: A large Pina Colada that makes the universe disappear. -- To unsubscribe from this list: send the line unsubscribe linux-mmc in the body of a message

Re: [PATCH 1/4] mmc: sdhci: add a driver for Berlin SoCs

2014-05-09 Thread Ben Dooks
, + }, + {} I think the hardware names should be used instead of the quirks the hardware has (broken wp / broken adma) -- Ben Dooks http://www.codethink.co.uk/ Senior Engineer Codethink - Providing Genius -- To unsubscribe from this list

Re: [PATCH] MAINTAINERS: mmc: Update email for host driver maintainer

2014-05-08 Thread Ben Dooks
...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html -- Ben Dooks, b...@fluff.org, http://www.fluff.org/ben/ Large Hadron Colada: A large Pina Colada that makes the universe disappear. -- To unsubscribe from this list: send the line unsubscribe linux-mmc in the body

Re: [PATCH 5/6] shmobile: TMIO: break register specs out from TMIO kernel driver

2014-04-30 Thread Ben Dooks
unsubscribe linux-mmc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html -- Ben Dooks, b...@fluff.org, http://www.fluff.org/ben/ Large Hadron Colada: A large Pina Colada that makes the universe disappear. -- To unsubscribe from

Re: [PATCH] mmc: card.h: Use NULL instead of 0 for END_FIXUP

2014-04-09 Thread Ben Dooks
to use { } here. -- Ben Dooks http://www.codethink.co.uk/ Senior Engineer Codethink - Providing Genius -- To unsubscribe from this list: send the line unsubscribe linux-mmc in the body of a message to majord...@vger.kernel.org More majordomo info

Re: [PATCH] sdhci: Forward EPROBE_DEFER on vmmc and vqmmc regulators

2014-04-07 Thread Ben Dooks
regulator_get_optional() should not be considered a bug, while getting an error return should always cause the probe function to fail. Surely it needs to be changed to IS_ERR(), nor IS_ERR_OR_NULL()? -- Ben Dooks http://www.codethink.co.uk/ Senior Engineer

Re: [PATCH] sdhci: Forward EPROBE_DEFER on vmmc and vqmmc regulators

2014-04-07 Thread Ben Dooks
On 07/04/14 13:16, Ben Dooks wrote: On 07/04/14 13:09, Mike Looijmans wrote: On 04/07/2014 10:11 AM, Arnd Bergmann wrote: On Monday 07 April 2014 08:38:28 Mike Looijmans wrote: index 34aef81..43b90c1 100644 --- a/drivers/mmc/host/sdhci.c +++ b/drivers/mmc/host/sdhci.c @@ -2972,6 +2972,8

Re: [PATCH 4/4] mmc: SDHI: update sh_mobile_sdhi_of_data for r8a7790

2014-04-03 Thread Ben Dooks
or UHS-1 card. Is there any reason to stop using the MULTI_READ as the system seems to work without MMC_CAP2_NO_MULTI_READ. Also, this series does not seem to be in any of the git trees I would expect. Does it need re-sending? -- Ben Dooks http://www.codethink.co.uk

[PATCH 3/6] mmc: sh-mmcif: use devm_ for clock management

2014-04-01 Thread Ben Dooks
--- drivers/mmc/host/sh_mmcif.c | 18 -- 1 file changed, 8 insertions(+), 10 deletions(-) diff --git a/drivers/mmc/host/sh_mmcif.c b/drivers/mmc/host/sh_mmcif.c index be6be2b..c006310 100644 --- a/drivers/mmc/host/sh_mmcif.c +++ b/drivers/mmc/host/sh_mmcif.c @@ -1393,7 +1393,7 @@

cleanups for sh-mmcif driver

2014-04-01 Thread Ben Dooks
Some cleanups and updates for the sh mmcif driver. -- To unsubscribe from this list: send the line unsubscribe linux-mmc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH 1/6] mmc: sh-mmcif: print bus clock rate on probe

2014-04-01 Thread Ben Dooks
Add a print to show the host-bus clock rate for mmcif on probe to allow easy check on what clock rate the bus clock is at. Signed-off-by: Ben Dooks ben.do...@codethink.co.uk --- drivers/mmc/host/sh_mmcif.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/mmc/host

[PATCH 2/6] mmc: sh-mmcif: use devm_ for ioremap

2014-04-01 Thread Ben Dooks
Start tidying the probe/release code by using devm_ioremap_resource() to map the IO registers. Signed-off-by: Ben Dooks ben.do...@codethink.co.uk --- drivers/mmc/host/sh_mmcif.c | 20 +--- 1 file changed, 5 insertions(+), 15 deletions(-) diff --git a/drivers/mmc/host/sh_mmcif.c

[PATCH 6/6] mmc: sh-mmcif: final error path cleanup

2014-04-01 Thread Ben Dooks
-by: Ben Dooks ben.do...@codethink.co.uk --- drivers/mmc/host/sh_mmcif.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/mmc/host/sh_mmcif.c b/drivers/mmc/host/sh_mmcif.c index c951760..d63cfa7 100644 --- a/drivers/mmc/host/sh_mmcif.c +++ b/drivers/mmc/host/sh_mmcif.c

[PATCH 5/6] mmc: sh-mmcif: no need to call pm_runtime_suspend on error

2014-04-01 Thread Ben Dooks
The pm_runtime call should implicitly disable the device once the probe is over if there is no explicit reference gained. There is no need to call pm_runtime_suspend() before the pm_runtime_disable() call. Signed-off-by: Ben Dooks ben.do...@codethink.co.uk --- drivers/mmc/host/sh_mmcif.c | 6

[PATCH 4/6] mmc: sh-mmcif: use devm_ for irq management

2014-04-01 Thread Ben Dooks
Use devm_request_threaded_irq() for the host interrupt handlers so we do not have to worry about freeing them on exit or error. Tidies up the exit path code for the driver. Signed-off-by: Ben Dooks ben.do...@codethink.co.uk --- drivers/mmc/host/sh_mmcif.c | 26 -- 1 file

Re: [PATCH 2/6] mmc: sh-mmcif: use devm_ for ioremap

2014-04-01 Thread Ben Dooks
On 01/04/14 11:55, Geert Uytterhoeven wrote: On Tue, Apr 1, 2014 at 12:25 PM, Ben Dooks ben.do...@codethink.co.uk wrote: + reg = devm_ioremap_resource(pdev-dev, res); + if (IS_ERR(reg)) { dev_err(pdev-dev, ioremap error.\n); devm_ioremap_resource() already calls

Re: [PATCH 3/6] mmc: sh-mmcif: use devm_ for clock management

2014-04-01 Thread Ben Dooks
On 01/04/14 11:59, Geert Uytterhoeven wrote: On Tue, Apr 1, 2014 at 12:25 PM, Ben Dooks ben.do...@codethink.co.uk wrote: - host-hclk = clk_get(pdev-dev, NULL); + host-hclk = devm_clk_get(pdev-dev, NULL); if (IS_ERR(host-hclk)) { ret = PTR_ERR(host-hclk

Re: [PATCH 1/6] mmc: sh-mmcif: print bus clock rate on probe

2014-04-01 Thread Ben Dooks
On 01/04/14 12:08, Laurent Pinchart wrote: Hi Ben, Thank you for the patch. On Tuesday 01 April 2014 11:25:49 Ben Dooks wrote: Add a print to show the host-bus clock rate for mmcif on probe to allow easy check on what clock rate the bus clock is at. Signed-off-by: Ben Dooks ben.do

sh mmcif cleanups

2014-04-01 Thread Ben Dooks
This is a second round of the mmcif cleanups Changes since v1: - fix issues with devm_ioremap return, and error printing - change the initial print - fix issue with disabling clock -- To unsubscribe from this list: send the line unsubscribe linux-mmc in the body of a

[PATCH v2 6/6] mmc: sh-mmcif: final error path cleanup

2014-04-01 Thread Ben Dooks
Remove the error path items that are no longer needed. The mmc card-detect code cleans up after itself (and registers with devm) and the host error is the same as the clock disable. Signed-off-by: Ben Dooks ben.do...@codethink.co.uk --- drivers/mmc/host/sh_mmcif.c | 6 ++ 1 file changed, 2

[PATCH v2 4/6] mmc: sh-mmcif: use devm_ for irq management

2014-04-01 Thread Ben Dooks
Use devm_request_threaded_irq() for the host interrupt handlers so we do not have to worry about freeing them on exit or error. Tidies up the exit path code for the driver. Signed-off-by: Ben Dooks ben.do...@codethink.co.uk --- drivers/mmc/host/sh_mmcif.c | 26 -- 1 file

[PATCH v2 5/6] mmc: sh-mmcif: no need to call pm_runtime_suspend on error

2014-04-01 Thread Ben Dooks
The pm_runtime call should implicitly disable the device once the probe is over if there is no explicit reference gained. There is no need to call pm_runtime_suspend() before the pm_runtime_disable() call. Signed-off-by: Ben Dooks ben.do...@codethink.co.uk --- drivers/mmc/host/sh_mmcif.c | 6

[PATCH v2 1/6] mmc: sh-mmcif: update to print version and bus clock rate on probe

2014-04-01 Thread Ben Dooks
Change the initial print to show chip version and the bus rate it is working at instead of the driver version. This is more useful information as we already know which driver version from the kernel it is in. Signed-off-by: Ben Dooks ben.do...@codethink.co.uk --- drivers/mmc/host/sh_mmcif.c | 9

[PATCH v2 2/6] mmc: sh-mmcif: use devm_ for ioremap

2014-04-01 Thread Ben Dooks
Start tidying the probe/release code by using devm_ioremap_resource() to map the IO registers. Signed-off-by: Ben Dooks ben.do...@codethink.co.uk --- Fixes from v1: - return the PTR_ERR() from devm_ioremap - remove error print as it already shows an error --- drivers/mmc/host

[PATCH v2 3/6] mmc: sh-mmcif: use devm_ for clock management

2014-04-01 Thread Ben Dooks
Use the devm_clk_get() code to get the clock and allow it to be freed automatically on release. Signed-off-by: Ben Dooks ben.do...@codethink.co.uk --- drivers/mmc/host/sh_mmcif.c | 18 -- 1 file changed, 8 insertions(+), 10 deletions(-) diff --git a/drivers/mmc/host/sh_mmcif.c b

Re: sh mmcif cleanups

2014-04-01 Thread Ben Dooks
On 01/04/14 13:45, Laurent Pinchart wrote: On Tuesday 01 April 2014 13:01:40 Ben Dooks wrote: This is a second round of the mmcif cleanups Changes since v1: - fix issues with devm_ioremap return, and error printing - change the initial print - fix issue with disabling

Re: [PATCH 1/3] mmc: tmio-mmc: add DMA SG synchronisation

2014-02-06 Thread Ben Dooks
? -- Ben Dooks http://www.codethink.co.uk/ Senior Engineer Codethink - Providing Genius -- To unsubscribe from this list: send the line unsubscribe linux-mmc in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: [PATCH 4/4] ARM: shmobile: ag5evm, ap4: Make use of irq index enum

2011-08-16 Thread Ben Dooks
), .flags = IORESOURCE_IRQ, }, - [3] = { + [1 + SH_MOBILE_SDHI_IRQ_SDIO] = { .start = gic_spi(85), .flags = IORESOURCE_IRQ, }, how about naming the irqs? -- Ben Dooks, b...@fluff.org, http://www.fluff.org/ben/ Large Hadron Colada: A large Pina

Re: [RFC PATCH 0/3] If an IRQ is a GPIO, request and configure it

2011-08-05 Thread Ben Dooks
+ 3 files changed, 24 insertions(+), 22 deletions(-) ___ linux-arm-kernel mailing list linux-arm-ker...@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel -- Ben Dooks, b...@fluff.org, http://www.fluff.org

Re: [PATCH 1/3] irq: If an IRQ is a GPIO, request and configure it

2011-08-05 Thread Ben Dooks
/* make sure affinity_hint is cleaned up */ -- 1.7.0.4 ___ linux-arm-kernel mailing list linux-arm-ker...@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel -- Ben Dooks, b...@fluff.org, http://www.fluff.org/ben

Re: [PATCH 1/3] irq: If an IRQ is a GPIO, request and configure it

2011-08-05 Thread Ben Dooks
(the IIO system is the only system currently doing this, for some fairly nasty reasons) -- Ben Dooks, b...@fluff.org, http://www.fluff.org/ben/ Large Hadron Colada: A large Pina Colada that makes the universe disappear. -- To unsubscribe from this list: send the line unsubscribe linux-mmc in the body

Re: [PATCH resend] mmc: Added ioctl to let userspace apps send ACMDs

2011-03-17 Thread Ben Dooks
and delete the message. -- To unsubscribe from this list: send the line unsubscribe linux-mmc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html -- Ben Dooks, b...@fluff.org, http://www.fluff.org/ben/ Large Hadron Colada

Re: [PATCH] mmc: mshci: Add support Mobile Storage Host Controller Interface

2011-01-07 Thread Ben Dooks
On Fri, Jan 07, 2011 at 12:51:23PM +0100, Wolfram Sang wrote: The 'mshci.c' is based on 'linux/drivers/mmc/host/sdhci.c' and the role is exactly same with that. Can you sum up the differences why you cannot sdhci.c directly, please? I second that. -- Ben Dooks, b...@fluff.org, http

Re: [PATCH 0/23] Alternative mmc structure to support pxa168, pxa910, mmp2 family SD

2010-12-21 Thread Ben Dooks
post? -- Ben Dooks, b...@fluff.org, http://www.fluff.org/ben/ Large Hadron Colada: A large Pina Colada that makes the universe disappear. -- To unsubscribe from this list: send the line unsubscribe linux-mmc in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: [PATCH 6/6] mmc: sdhci-pltfm: add pltfm-driver for imx35/51

2010-09-28 Thread Ben Dooks
On Tue, Sep 28, 2010 at 10:04:14AM -0400, zhangfei gao wrote: On Tue, Sep 28, 2010 at 8:36 AM, Wolfram Sang w.s...@pengutronix.de wrote: This driver adds basic support for the esdhc-core found on e.g. imx35/51. It adds up to the pltfm-core. Signed-off-by: Wolfram Sang

Re: [PATCH v2 2/2] sdhci-s3c: Add support no internal clock divider in host controller

2010-09-20 Thread Ben Dooks
On 17/09/10 10:45, Kukjin Kim wrote: From: Hyuk Lee hyuk1@samsung.com This patch adds to support no internal clock divider in SDHCI. The external clock divider can be used to make a proper clock because SDHCI doesn't support internal clock divider by itself. Signed-off-by: Hyuk Lee

Re: [PATCHv5 3/4] sdhci-s3c: add support for new card detection methods (driver part)

2010-07-28 Thread Ben Dooks
On 28/07/10 15:19, Marek Szyprowski wrote: On some Samsung SoCs not all SDHCI controllers have card detect (CD) line. For some embedded designs it is not even needed, because ususally the device (like SDIO flash memory or wifi controller) is permanently wired to the controller. There are also

Re: [PATCHv2 1/4] sdhci-s3c: add support for the non standard minimal clock value

2010-07-28 Thread Ben Dooks
On 28/07/10 15:19, Marek Szyprowski wrote: S3C SDHCI host controller can change the source for generating mmc clock. By default host bus clock is used, what causes some problems on machines with 133MHz bus, because the SDHCI divider cannot be as high get proper clock value for identification

Re: [PATCH v5 3/3] sdhci-s3c: Add SDHCI_QUIRK_NO_WP_BIT quirk for Samsung SoC

2010-07-28 Thread Ben Dooks
. Signed-off-by: Hyuk Lee hyuk1@samsung.com Signed-off-by: Kukjin Kim kgene@samsung.com Cc: Ben Dooks ben-li...@fluff.org --- Changes since v4: - Address comments from Marek. Hi Andrew, If there are no problems, could you please apply this patch? rn gpio_get_value(ourhost-pdata

Re: [PATCH 2/3] ARM: S5PV210: Add support SDMMC WP through EXT_INT on SMDKV210

2010-06-15 Thread Ben Dooks
On Tue, Jun 15, 2010 at 08:27:47PM +0900, Kukjin Kim wrote: From: Lee Hyuk hyuk1@samsung.com S5PV210 HSMMC host controller doesn't have the Write Protection pin which should be connnected with SDMMC card WP pin. So allocated a GPIO in order to get the data from SDMMC card WP pin with

Re: [PATCH 1/3] ARM: SAMSUNG: Add the member of platdata to implement SDMMC Write Protection

2010-06-15 Thread Ben Dooks
On Tue, Jun 15, 2010 at 08:27:46PM +0900, Kukjin Kim wrote: From: Lee Hyuk hyuk1@samsung.com This patch adds the members of platdata which are cfg_wp and get_ro. The cfg_wp is the function for setting the specific GPIO for WP pin and get_ro is the function for getting data from the

Re: [PATCH 3/3] sdhci-s3c: Add SDHCI_QUIRK_NO_WP_BIT for Samsung SoC

2010-06-15 Thread Ben Dooks
On Tue, Jun 15, 2010 at 08:27:48PM +0900, Kukjin Kim wrote: From: Lee Hyuk hyuk1@samsung.com S5PV210 HSMMC host controller doesn't have the WP pin which should be connnected with SDMMC card WP pin. So if there are the cfg_wp and get_ro in pdata, configure the WP pin and replace get_ro

Re: + s5pc110-sdhci-s3c-can-override-host-capabilities.patch added to -mm tree

2010-06-10 Thread Ben Dooks
On Thu, Jun 10, 2010 at 01:43:14PM -0700, a...@linux-foundation.org wrote: The patch titled s5pc110: SDHCI-s3c can override host capabilities has been added to the -mm tree. Its filename is s5pc110-sdhci-s3c-can-override-host-capabilities.patch Before you just go and hit reply,

Re: + s5pc110-sdhci-s3c-support-on-s5pc110.patch added to -mm tree

2010-06-10 Thread Ben Dooks
On Thu, Jun 10, 2010 at 01:43:17PM -0700, a...@linux-foundation.org wrote: The patch titled s5pc110: SDHCI-s3c support on s5pc110 has been added to the -mm tree. Its filename is s5pc110-sdhci-s3c-support-on-s5pc110.patch Before you just go and hit reply, please: a)

Re: + sdhci-add-no-hi-speed-bit-quirk-support.patch added to -mm tree

2010-06-10 Thread Ben Dooks
On Thu, Jun 10, 2010 at 01:43:19PM -0700, a...@linux-foundation.org wrote: The patch titled SDHCI: add no hi-speed bit quirk support has been added to the -mm tree. Its filename is sdhci-add-no-hi-speed-bit-quirk-support.patch Before you just go and hit reply, please: a)

Re: [PATCH 3/3] s5pv210: Aquila: add definitions for sdhci devices

2010-06-10 Thread Ben Dooks
On Wed, Jun 09, 2010 at 11:39:05AM +0200, Marek Szyprowski wrote: This patch add support for SDHCI blocks on Samsung Aquila board. The following host controllers are defined: 1. Internal MoviNAND device (permanently wired to the controller) 2. Internal WiFI SDIO device (card is activated by

Re: [PATCH 1/5] sdhci-s3c: depend on plat-samsung

2010-06-10 Thread Ben Dooks
On Fri, Jun 11, 2010 at 09:29:38AM +0900, Kukjin Kim wrote: Marek Szyprowski wrote: Most Samsung SoC have support for SDHCI block, so make the driver dependent on the Samsung platform instead on listing all SoCs in the Kconfig (and updating it again when support for the new SoC variant

Re: [PATCH] Recognize CSD structure version 3

2010-05-31 Thread Ben Dooks
On Mon, May 31, 2010 at 03:40:35PM +0900, Kyungmin Park wrote: The eMMC spec 4.4 and 4.3 + additional feature chips has CSD structure version 3 To probe these chip properly and make it simple. it doesn't check CSD structure. Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- diff

Re: PATCH: sdhci.h fix typo

2010-04-30 Thread Ben Dooks
On Thu, Apr 29, 2010 at 04:05:06PM +0800, zhangfei gao wrote: Hi, Here is one typo erro in sdhci.h, though it does not impact the stability. Thanks From 1fbcb05dbab2e5e5de72060f0481a279fa3eda18 Mon Sep 17 00:00:00 2001 From: Zhangfei Gao zg...@marvell.com Date: Thu, 22 Apr 2010

Re: [PATCH] sdhci: Rename SDHCI I/O accessor functions

2010-04-27 Thread Ben Dooks
} functions with macros. Acked-by: Anton Vorontsov cbouatmai...@gmail.com Signed-off-by: Matt Fleming m...@console-pimps.org Acked-by: Ben Dooks ben-li...@fluff.org -- Ben Q: What's a light-year? A: One-third less calories than a regular year. -- To unsubscribe from this list: send

Re: [PATCH] mmc-omap: Add support for 16-bit and 32-bit registers

2010-03-08 Thread Ben Dooks
On Sun, Mar 07, 2010 at 10:59:01PM +, Ben Dooks wrote: On Sun, Mar 07, 2010 at 09:47:58AM -0800, Cory Maccarrone wrote: From: Marek Belisko marek.beli...@open-nandra.com The omap850 and omap730 use 16-bit registers instead of 32-bit, requiring a modification of the register addresses

Re: [PATCH-Resend] sdhci: Add new quirk in sdhci driver and update ADMA descriptor build.

2010-01-27 Thread Ben Dooks
to this, for controllers using the new quirk, the last entry in the ADMA descritor table is marked with the 'End' attribute (instead of using a NOP descriptor with 'End' attribute). Signed-off-by: Thomas Abraham thomas...@samsung.com Acked-by: Ben Dooks ben-li...@fluff.org --- drivers/mmc/host/sdhci.c

Re: [PATCH-Resend] S3C: sdhci: Enable ADMA feature in S3C sdhci controller.

2010-01-27 Thread Ben Dooks
...@samsung.com Acked-by: Ben Dooks ben-li...@fluff.org --- drivers/mmc/host/sdhci-s3c.c |7 +-- 1 files changed, 1 insertions(+), 6 deletions(-) diff --git a/drivers/mmc/host/sdhci-s3c.c b/drivers/mmc/host/sdhci-s3c.c index 7400ba0..03f7e3b 100644 --- a/drivers/mmc/host/sdhci-s3c.c

[PATCH] sdhci: improve sdhci sdhci_set_adma_desc() code

2010-01-27 Thread Ben Dooks
: e1c030b0strhr3, [r0] + dc: e1c020b2strhr2, [r0, #2] Signed-off-by: Ben Dooks ben-li...@fluff.org --- drivers/mmc/host/sdhci.c | 16 1 files changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host

[PATCH] sdhci: add adma descriptor set call

2010-01-27 Thread Ben Dooks
The code to write the ADMA descriptor into memory is repeated several times throughout sdhci_adma_table_pre, and thus should be moved into a common function. This will also be useful if the patch to make the write more efficient is accepted. Signed-off-by: Ben Dooks ben-li...@fluff.org

Re: [patch 00/11] s3cmci fixes and updates for current merge window

2009-10-02 Thread Ben Dooks
Andrew Morton wrote: On Mon, 21 Sep 2009 14:35:55 +0100 Ben Dooks b...@simtec.co.uk wrote: This is a set of the s3cmci updates and fixes for the current merge window. It is a resend of an updated version of a series posted a few weeks ago, which I could not find queued anywhere. Sending

[patch 09/11] s3cmci: DMA fixes

2009-09-21 Thread Ben Dooks
the host and memory. Signed-off-by: Ben Dooks b...@simtec.co.uk --- drivers/mmc/host/s3cmci.c | 62 ++ drivers/mmc/host/s3cmci.h |3 -- 2 files changed, 47 insertions(+), 18 deletions(-) Index: b/drivers/mmc/host/s3cmci.c

[patch 03/11] s3cmci: Change GPIO to gpiolib from S3C24XX specific calls

2009-09-21 Thread Ben Dooks
Move to using gpiolib to access the card detect and write protect GPIO lines instead of using the platform speicifc s3c2410_gpio calls. Also ensure that the card lines are claimed the same way to avoid overlap with any other drivers. Signed-off-by: Ben Dooks b...@simtec.co.uk --- drivers/mmc

[patch 07/11] s3cmci: Add SDIO IRQ support

2009-09-21 Thread Ben Dooks
an IRQ than is held asserted, so there are some manual checks to see if the SDIO interrupt is active after a transfer. Major testing on the S3C2440. Signed-off-by: Ben Dooks b...@simtec.co.uk --- drivers/mmc/host/s3cmci.c | 161 +++--- drivers/mmc/host

[patch 06/11] s3cmci: Add debugfs support for examining driver and hardware state.

2009-09-21 Thread Ben Dooks
Export driver state and hardware register state via debugfs entries created under a directory formed from dev_name() on the probed device when CONFIG_DEBUG_FS is set. Signed-off-by: Ben Dooks b...@simtec.co.uk --- drivers/mmc/host/s3cmci.c | 126

[patch 10/11] s3cmci: Make SDIO IRQ hardware IRQ support build-time configurable.

2009-09-21 Thread Ben Dooks
We have found a couple of boards where the SDIO IRQ hardware support has failed to work properly, and thus we should make it configurable whether or not to be included in the driver. Signed-off-by: Ben Dooks b...@simtec.co.uk --- drivers/mmc/host/Kconfig |7 +++ drivers/mmc/host