Dong Aisheng freescale.com> writes:
>
> Commit 8d86e4f mmc: sdhci-esdhc-imx: Call mmc_of_parse()
> seriously break the sd card detect/write protect function
> of most IMX platforms since a lot of GPIO flags of cd-gpios/wp-gpios
> are wrongly set in devicetree.
...
Hi,
rial/mos7720.c
> @@ -135,7 +135,7 @@ enum mos_regs {
> DLM,
> DPR, /* parallel port regs */
> DSR,
> - DCR,
> + parport_DCR,
> ECR,
> SP1_REG, /* device control regs */
> SP2_REG, /* serial port 2 (7720 only)
assumed the original author wants to see the message whenever reset is
> attempted, which is OK by me because it is on the recovery path i.e.
> hopefully rare. The EOPNOTSUPP case is consistent with the code further up
> which returns EOPNOTSUPP when there is no ->reset() callback.
S
2015-01-13 9:19 GMT+01:00 Ulf Hansson :
> On 12 January 2015 at 16:11, Ulf Hansson wrote:
>> On 12 January 2015 at 15:38, Johan Rudholm wrote:
>>> Make the mmc_hw_reset routine more generic, by putting the (e)MMC-
>>> specific stuff in the new bus_ops->reset in m
Move the (e)MMC specific hw_reset code from core.c into mmc.c. Call the
code from the new bus_ops member "reset". This also allows for adding
a SD card specific reset procedure.
Signed-off-by: Johan Rudholm
---
drivers/mmc/core/cor
s member hw_reset instead of power_reset
- Create mmc_set_initial_state and call it from mmc_mmc_hw_reset
instead of mmc_power_up
- Keep "mmc_hw_reset" naming
Johan Rudholm (3):
mmc: core: always check status after reset
mmc: core: refactor the hw_reset routines
mmc: sd: add res
Enable power cycle and re-initialization of SD cards via the reset
bus_ops. Power cycling a buggy SD card sometimes helps it get back on
track.
Signed-off-by: Johan Rudholm
---
drivers/mmc/core/sd.c |7 +++
1 files changed, 7 insertions(+), 0 deletions(-)
diff --git a/drivers/mmc/core
2015-01-12 13:55 GMT+01:00 Ulf Hansson :
> On 9 January 2015 at 12:08, Johan Rudholm wrote:
>> Move the (e)MMC specific hw_reset code from core.c into mmc.c Call the
>> code from the new bus_ops member hw_reset. This also allows for adding
>> a SD card specific reset procedur
Always check if the card is alive after a successful reset. This allows
us to remove mmc_hw_reset_check(), leaving mmc_hw_reset() as the only
card reset interface.
Signed-off-by: Johan Rudholm
---
drivers/mmc/card/mmc_test.c | 18 +++---
drivers/mmc/core/core.c | 24
mmc_hw_reset() as the only
card reset interface. This also informs any callers, for instance the
block layer, if a reset was sucessful or not.
Signed-off-by: Johan Rudholm
---
drivers/mmc/card/mmc_test.c | 18 ---
drivers/mmc/core/core.c | 70
Enable power cycle and re-initialization of SD cards via the hw_reset
bus_ops. Power cycling a buggy SD card sometimes helps it get back on
track.
Signed-off-by: Johan Rudholm
---
drivers/mmc/core/sd.c |7 +++
1 files changed, 7 insertions(+), 0 deletions(-)
diff --git a/drivers/mmc
c_can_reset
- Always set bus_mode = MMC_BUSMODE_PUSHPULL in mmc_set_initial_state()
v2:
- Call the new bus_ops member hw_reset instead of power_reset
- Create mmc_set_initial_state and call it from mmc_mmc_hw_reset
instead of mmc_power_up
- Keep "mmc_hw_reset" naming
Johan Rud
Hi Ulf,
2014-12-01 11:50 GMT+01:00 Ulf Hansson :
> On 28 November 2014 at 16:54, Johan Rudholm wrote:
>> 2014-11-27 10:50 GMT+01:00 Ulf Hansson :
>>> On 27 November 2014 at 10:05, Johan Rudholm wrote:
>>>> Hi Ulf,
>>>>
>>>> 2014-11-25 14:4
Split the (e)MMC specific hw_reset code from core.c into mmc.c and
mmc_test.c. Call the code from the new bus_ops member hw_reset.
Export mmc_set_initial_state and mmc_send_status so that they may be
called from mmc_test.
Signed-off-by: Johan Rudholm
---
drivers/mmc/card/mmc_test.c | 24
If bus_ops->hw_reset is missing, try to power cycle the card instead.
This will allow SD cards to be power cycled and re-initialized as well.
Power cycling a buggy SD card sometimes helps it get back on track.
Signed-off-by: Johan Rudholm
---
drivers/mmc/core/core.c |
Always set bus_mode = MMC_BUSMODE_PUSHPULL in mmc_set_initial_state()
v2:
- Call the new bus_ops member hw_reset instead of power_reset
- Create mmc_set_initial_state and call it from mmc_mmc_hw_reset
instead of mmc_power_up
- Keep "mmc_hw_reset" naming
Johan Rudholm (2):
mmc
2014-11-27 10:50 GMT+01:00 Ulf Hansson :
> On 27 November 2014 at 10:05, Johan Rudholm wrote:
>> Hi Ulf,
>>
>> 2014-11-25 14:48 GMT+01:00 Ulf Hansson :
>>> On 24 November 2014 at 12:06, Johan Rudholm wrote:
>>>> Move the (e)MMC specific hw_reset code fr
Hi Ulf,
2014-11-25 14:48 GMT+01:00 Ulf Hansson :
> On 24 November 2014 at 12:06, Johan Rudholm wrote:
>> Move the (e)MMC specific hw_reset code from core.c into mmc.c and call
>> it from the new bus_ops member hw_reset. This also lets us add code
>> for resetting SD cards
Enable power cycle and re-initialization of SD cards via the hw_reset
bus_ops. Power cycling a buggy SD card sometimes helps it get back on
track.
Signed-off-by: Johan Rudholm
---
drivers/mmc/core/sd.c | 13 +
1 files changed, 13 insertions(+), 0 deletions(-)
diff --git a/drivers
Move the (e)MMC specific hw_reset code from core.c into mmc.c and call
it from the new bus_ops member hw_reset. This also lets us add code
for resetting SD cards as well.
Signed-off-by: Johan Rudholm
---
drivers/mmc/core/core.c | 56 +++---
drivers/mmc
up
- Keep "mmc_hw_reset" naming
Johan Rudholm (2):
mmc: core: turn hw_reset into a bus_ops
mmc: sd: add hw_reset callback
drivers/mmc/core/core.c | 56 +++---
drivers/mmc/core/core.h |5
drivers/mm
MD11, the additional gating/un-gating
> SD clock between (2) and (3) can be prevented and thus no failure at (11).
> It has been verified with many UHS-1 SD cards on mb86s7x platforms and
> works correctly.
>
> Signed-off-by: Vincent Yang
Reviewed-by: Johan Rudholm
BR, Johan
--
To uns
Enable power cycle and re-initialization of SD cards via the hw_reset
bus_ops. Power cycling a buggy SD card sometimes helps it get back on
track.
Signed-off-by: Johan Rudholm
---
drivers/mmc/core/sd.c | 13 +
1 files changed, 13 insertions(+), 0 deletions(-)
diff --git a/drivers
Move the (e)MMC specific hw_reset code from core.c into mmc.c and call
it from the new bus_ops member hw_reset. This also lets us add code
for resetting SD cards as well.
Signed-off-by: Johan Rudholm
---
drivers/mmc/core/core.c | 56 +++---
drivers/mmc
ODE_PUSHPULL in mmc_set_initial_state()
v2:
- Call the new bus_ops member hw_reset instead of power_reset
- Create mmc_set_initial_state and call it from mmc_mmc_hw_reset
instead of mmc_power_up
- Keep "mmc_hw_reset" naming
Johan Rudholm (3):
mmc: core: consistent handling of initial
be a problem since the device will be
powered off anyway.
mmc_do_hw_reset():
Always set bus_mode = MMC_BUSMODE_PUSHPULL, as required by SD/SDIO
cards. MMC cards require MMC_BUSMODE_OPENDRAIN, but this is taken
care of by mmc_init_card() and mmc_attach_mmc().
Signed-off-by: Johan Ru
he SD spec doesn't have open drain mode but do support SPI mode. That
> tells me that we should keep using MMC_BUSMODE_PUSHPULL for SPI mode.
Thank you for explaining this. So I think we should be OK by always
choosing MMC_BUSMODE_PUSHPULL, because for MMC cards mmc_init_card is
called from
Hi Adrian,
2014-11-05 13:10 GMT+01:00 Adrian Hunter :
> On 04/11/14 17:07, Johan Rudholm wrote:
>> Move the (e)MMC specific hw_reset code from core.c into mmc.c and call
>> it from the new bus_ops member hw_reset. This also lets us add code
>> for reseting SD cards as well
Hi Ulf,
2014-11-05 11:13 GMT+01:00 Ulf Hansson :
> On 4 November 2014 16:07, Johan Rudholm wrote:
>> mmc_do_hw_reset, mmc_power_up and mmc_power_off all set the same
>> group of initial values, simplify by sticking them together.
>
> That's not entirely true. This patc
mmc_do_hw_reset, mmc_power_up and mmc_power_off all set the same
group of initial values, simplify by sticking them together.
Signed-off-by: Johan Rudholm
---
drivers/mmc/core/core.c | 49 +++
drivers/mmc/core/core.h |1 +
2 files changed, 25
Move the (e)MMC specific hw_reset code from core.c into mmc.c and call
it from the new bus_ops member hw_reset. This also lets us add code
for reseting SD cards as well.
Signed-off-by: Johan Rudholm
---
drivers/mmc/card/mmc_test.c |3 --
drivers/mmc/core/core.c | 48
Signed-off-by: Johan Rudholm
---
drivers/mmc/core/core.c | 10 ++
1 files changed, 2 insertions(+), 8 deletions(-)
diff --git a/drivers/mmc/core/core.c b/drivers/mmc/core/core.c
index 7dc0c85..5d215ee 100644
--- a/drivers/mmc/core/core.c
+++ b/drivers/mmc/core/core.c
@@ -2265,15
de with an eMMC?
v2:
- Call the new bus_ops member hw_reset instead of power_reset
- Create mmc_set_initial_state and call it from mmc_mmc_hw_reset
instead of mmc_power_up
- Keep "mmc_hw_reset" naming
Johan Rudholm (4):
mmc: core: use mmc_send_status to check hw_reset
mmc:
Enable power cycle and re-initialization of SD cards via the hw_reset
bus_ops. Power cycling a buggy SD card sometimes helps it get back on
track.
Signed-off-by: Johan Rudholm
---
drivers/mmc/core/sd.c | 13 +
1 files changed, 13 insertions(+), 0 deletions(-)
diff --git a/drivers
2014-11-03 10:20 GMT+01:00 Adrian Hunter :
> On 24/10/14 15:46, Johan Rudholm wrote:
>> Move the (e)MMC specific hw_reset code from core.c into mmc.c and call
>> it from the new bus_ops member power_reset. This also lets us add code
>
> power_reset is not a good nam
2014-11-03 10:21 GMT+01:00 Adrian Hunter :
> On 24/10/14 15:46, Johan Rudholm wrote:
>> The steps performed in mmc_do_hw_reset for eMMC:s after the hardware
>> reset are very similar to those performed by mmc_power_up, so do a call
>
> They perform different functions. mmc_po
Hi all,
any comments on this patch set?
//Johan
2014-10-24 14:46 GMT+02:00 Johan Rudholm :
> Make the mmc_hw_reset routines more generic, so we can easily add a
> power cycle of SD cards as well. Also simplify the (e)MMC specific
> parts of the reset code.
>
> As I don't
Enable power cycle and re-initialization of SD cards via the mmc_reset
function. Power cycling a buggy SD card sometimes helps it get back on
track.
Signed-off-by: Johan Rudholm
---
drivers/mmc/core/sd.c | 16
1 files changed, 16 insertions(+), 0 deletions(-)
diff --git a
de with an eMMC?
Johan Rudholm (4):
mmc: core: use mmc_send_status to check hw_reset
mmc: core: use mmc_power_up in hw_reset
mmc: core: make hw_reset generic
mmc: sd: add power_reset callback
drivers/mmc/card/block.c|2 +-
drivers/mmc/card/mmc_test.c |5 +--
drivers/mmc/c
The steps performed in mmc_do_hw_reset for eMMC:s after the hardware
reset are very similar to those performed by mmc_power_up, so do a call
to this function instead.
Signed-off-by: Johan Rudholm
---
drivers/mmc/core/core.c | 11 +--
1 files changed, 1 insertions(+), 10 deletions
be something else
than doing a hw_reset).
Signed-off-by: Johan Rudholm
---
drivers/mmc/card/block.c|2 +-
drivers/mmc/card/mmc_test.c |5 +---
drivers/mmc/core/core.c | 58 +-
drivers/mmc/core/core.h |4 +++
drivers/mmc/core/mmc.c
Signed-off-by: Johan Rudholm
---
drivers/mmc/core/core.c | 10 ++
1 files changed, 2 insertions(+), 8 deletions(-)
diff --git a/drivers/mmc/core/core.c b/drivers/mmc/core/core.c
index 7dc0c85..5d215ee 100644
--- a/drivers/mmc/core/core.c
+++ b/drivers/mmc/core/core.c
@@ -2265,15
Stop command errors are not fatal to the transfer since we make sure
that the card returns to the transfer state and check the card status.
Change an unnecessary error to an info.
Signed-off-by: Johan Rudholm
---
drivers/mmc/card/block.c |2 +-
1 files changed, 1 insertions(+), 1 deletions
Hi Ulf,
2014-09-11 13:03 GMT+02:00 Ulf Hansson :
> On 9 September 2014 16:21, Johan Rudholm wrote:
>> SD-cards cannot be reset, but they can be power cycled. Power cycling
>> a buggy SD-card sometimes helps it get back on track.
>
> Hi Johan,
>
> This feature ha
2014-09-09 11:11 GMT+02:00 Arnd Bergmann :
> On Tuesday 09 September 2014 10:54:51 Johan Rudholm wrote:
>> 2014-09-03 16:24 GMT+02:00 Johan Rudholm :
>> > Hi all,
>> >
>> > as you know, NAND flash can be programmed a limited number of times
>> > befor
SD-cards cannot be reset, but they can be power cycled. Power cycling
a buggy SD-card sometimes helps it get back on track.
Signed-off-by: Johan Rudholm
---
drivers/mmc/core/core.c | 16 +++-
1 files changed, 11 insertions(+), 5 deletions(-)
diff --git a/drivers/mmc/core/core.c b
Hi Ulf, Arnd,
do you guys have any thoughts on this?
Kind regards, Johan
2014-09-03 16:24 GMT+02:00 Johan Rudholm :
> Hi all,
>
> as you know, NAND flash can be programmed a limited number of times
> before it reaches end of life, the number of times varies with the
> NAND
t kinds of errors in the card status
* Anything else?
Perhaps it's not possible to detect worn out cards this way, but at
least it could point out and warn about crappy cards?
Any thoughts about this?
Kind regards, Johan
--
To unsubscribe from this list: send the line "unsubscribe linux
The initialization of some SD-cards fails because the card never
leaves the busy state. Aid trouble shooting by indicating this in the
kernel log.
Signed-off-by: Johan Rudholm
---
drivers/mmc/core/sd_ops.c |3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/drivers/mmc
d by other commands sent via the
block driver or other ioctl calls.
Kind regards, Johan
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Mon, Sep 23, 2013 at 04:50:29PM +0200, Sascha Hauer wrote:
> On Mon, Sep 23, 2013 at 04:27:25PM +0200, Johan Hovold wrote:
> > Deferred probing cannot be used with platform_driver_probe as by the
> > time probing is retried either the driver has been unregistered or its
> &g
t91_cf and pxa25x_udc patches are completely
untested.
Johan
Johan Hovold (7):
driver core: prevent deferred probe with platform_driver_probe
mmc: mvsdio: fix deferred probe from __init
mtd: atmel_nand: fix deferred probe from __init
pcmcia: at91_cf: fix deferred probe from __init
usb: gadget:
ng
Cc: Haojian Zhuang
Cc: Felipe Balbi
Signed-off-by: Johan Hovold
---
drivers/usb/gadget/pxa25x_udc.c | 9 +
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/drivers/usb/gadget/pxa25x_udc.c b/drivers/usb/gadget/pxa25x_udc.c
index cc92074..0ac6064 100644
--- a/dri
return -EPROBE_DEFER if a gpio_request or regulator_get fails.
Cc: Felipe Balbi
Signed-off-by: Johan Hovold
---
drivers/usb/phy/phy-gpio-vbus-usb.c | 11 +--
1 file changed, 5 insertions(+), 6 deletions(-)
diff --git a/drivers/usb/phy/phy-gpio-vbus-usb.c
b/drivers/usb/phy/phy-gpio-vbus-usb
currently return subsystem errors
from probe and that these can include -EPROBE_DEFER (e.g. if a gpio
request fails).
Add a warning to platform_drv_probe that can be used to catch drivers
that inadvertently request probe deferral while using
platform_driver_probe.
Signed-off-by: Johan Hovold
Wu
Signed-off-by: Johan Hovold
---
drivers/mtd/nand/atmel_nand.c | 13 +++--
1 file changed, 7 insertions(+), 6 deletions(-)
diff --git a/drivers/mtd/nand/atmel_nand.c b/drivers/mtd/nand/atmel_nand.c
index 060feea..bd1ce7d 100644
--- a/drivers/mtd/nand/atmel_nand.c
+++ b/drivers/mtd/na
IOL-VILLARD
Cc: Nicolas Ferre
Signed-off-by: Johan Hovold
---
drivers/pcmcia/at91_cf.c | 11 +--
1 file changed, 5 insertions(+), 6 deletions(-)
diff --git a/drivers/pcmcia/at91_cf.c b/drivers/pcmcia/at91_cf.c
index b8f5acf..de24232 100644
--- a/drivers/pcmcia/at91_cf.c
+++ b/drivers/p
Cc: Chris Ball
Signed-off-by: Johan Hovold
---
drivers/mmc/host/mvsdio.c | 11 ++-
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/drivers/mmc/host/mvsdio.c b/drivers/mmc/host/mvsdio.c
index 06c5b0b..deecee0 100644
--- a/drivers/mmc/host/mvsdio.c
+++ b/drivers/mmc/host/mvs
o Han
Cc: Jean-Christophe Plagniol-Villard
Signed-off-by: Johan Hovold
---
drivers/video/backlight/atmel-pwm-bl.c | 9 +
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/drivers/video/backlight/atmel-pwm-bl.c
b/drivers/video/backlight/atmel-pwm-bl.c
index 0393d82..f7447
to improve UHS card support
>
> drivers/mmc/host/mmci.c | 94
> +++
> drivers/mmc/host/mmci.h |4 ++
> 2 files changed, 90 insertions(+), 8 deletions(-)
Looks good! Please add my
Reviewed-by: Johan Rudholm
to this patch set.
Kind regards, Johan
--
To unsubscribe fr
oks good to me! Please add my
Reviewed-by: Johan Rudholm
Kind regards, Johan
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
EXT_CSD_PWR_CL_DDR_52_360;
> + pwrclass_val = (bus_width <= EXT_CSD_BUS_WIDTH_8) ?
> + card->ext_csd.raw_pwr_cl_52_360 :
> + card->ext_csd.raw_pwr_cl_52_360;
I believe you should have "
Hi,
2013/4/17 Fredrik Soderstedt :
> Only execute tuning for sd and sdio devices that are using
> SDR50 or SDR104.
>
> Make sure clock is hold during tuning for sdio devices.
>
> Signed-off-by: Fredrik Soderstedt
Acked-by: Johan Rudholm
//Johan
--
To unsubscribe from this l
t+0xac/0x1b4)
> [] (__mmc_claim_host+0x0/0x1b4) from []
> (mmc_suspend+0x28/0x9c)
> [] (mmc_suspend+0x0/0x9c) from []
> (mmc_suspend_host+0xb4/0x194)
> ...
>
> Reported-by: Johan Rudholm
> Signed-off-by: Seungwon Jeon
Thank you for the quick response and fix! This fixes th
d the
amba-stuff, this is our power domain.
Kind regards, Johan
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
is always enabled (if supported), but the DMA-channel is not
released on module unload unless the DMA-config option is selected.
Remove the no longer used CONFIG_MMC_ATMELMCI_DMA option completely.
Cc: stable
Signed-off-by: Johan Hovold
---
arch/arm/configs/at91sam9g45_defconfig | 1 -
arch/avr
ase.
>> +*/
>> + if (!ret && host->ops->get_cd && !host->ops->get_cd(host)) {
>> + mmc_detect_change(host, msecs_to_jiffies(200));
>> + pr_debug("%s: card remove too slowly\n",
>> +
by default]
>
> Use the previous type so that it matches the start_signal_voltage_switch()
> definition from host.h.
>
> Signed-off-by: Fabio Estevam
Reviewed-by: Johan Rudholm
Kind regards, Johan
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of
Hi Chris,
2013/2/11 Chris Ball :
> Hi Johan,
>
> On Mon, Jan 28 2013, Johan Rudholm wrote:
>> This patch series attempts to make the 1.8V signal voltage switch
>> required for UHS mode work according to the SD specification.
>
> Thanks, pushed to mmc-next for 3.9.
Co
: Johan Rudholm
Acked-by: Ulf Hansson
Tested-by: Wei WANG
---
drivers/mmc/core/core.c | 35 +++
drivers/mmc/core/core.h |4 ++--
drivers/mmc/core/mmc.c |8
drivers/mmc/core/sd.c |2 +-
drivers/mmc/core/sdio.c |3 +--
5 files changed, 31
Signed-off-by: Johan Rudholm
---
drivers/mmc/core/sd.c |6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/mmc/core/sd.c b/drivers/mmc/core/sd.c
index 74972c2..9373639 100644
--- a/drivers/mmc/core/sd.c
+++ b/drivers/mmc/core/sd.c
@@ -444,8 +444,7 @@ static void
This host_ops member is used to test if the card is signaling busy by
pulling dat[0:3] low.
Signed-off-by: Johan Rudholm
Acked-by: Ulf Hansson
Tested-by: Wei WANG
---
include/linux/mmc/host.h |3 +++
1 file changed, 3 insertions(+)
diff --git a/include/linux/mmc/host.h b/include/linux
: Johan Rudholm
Signed-off-by: Kevin Liu
Signed-off-by: Ulf Hansson
Tested-by: Wei WANG
---
drivers/mmc/core/core.c | 83 +--
drivers/mmc/core/sd.c | 21 +---
drivers/mmc/core/sdio.c | 20 ++--
3 files changed, 107 insertions
dd retry-loop / power cycle in sdio.c
- Fall back to 3.3 V if the switch repeatedly fails
- Add an extra argument to the card_busy host_ops function,
which can be used to signal polling use of the function
Johan Rudholm (5):
mmc: sd: Simplify by using mmc_host_uhs
mmc: c
Add mmc_power_cycle which can be used to power cycle for instance
SD-cards.
Signed-off-by: Johan Rudholm
Acked-by: Ulf Hansson
Tested-by: Wei WANG
---
drivers/mmc/core/core.c |8
drivers/mmc/core/core.h |1 +
2 files changed, 9 insertions(+)
diff --git a/drivers/mmc/core
Hi,
2013/1/8 Ulf Hansson :
> On 8 January 2013 15:05, Johan Rudholm wrote:
>> This patch series attempts to make the 1.8V signal voltage switch
>> required for UHS mode work according to the SD specification.
>>
>> These patches have been tested with a couple of UH
which can be used to signal polling use of the function
Johan Rudholm (4):
mmc: core: Add mmc_power_cycle
mmc: core: Add card_busy to host_ops
mmc: core: Break out start_signal_voltage_switch
mmc: core: Fixup signal voltage switch
drivers/mmc/core/core.c | 114 +++
: Johan Rudholm
Signed-off-by: Kevin Liu
Signed-off-by: Ulf Hansson
---
drivers/mmc/core/core.c | 83 +--
drivers/mmc/core/sd.c | 21 +---
drivers/mmc/core/sdio.c | 20 ++--
3 files changed, 107 insertions(+), 17 deletions
Add mmc_power_cycle which can be used to power cycle for instance
SD-cards.
Signed-off-by: Johan Rudholm
---
drivers/mmc/core/core.c |8
drivers/mmc/core/core.h |1 +
2 files changed, 9 insertions(+)
diff --git a/drivers/mmc/core/core.c b/drivers/mmc/core/core.c
index aaed768
: Johan Rudholm
---
drivers/mmc/core/core.c | 35 +++
drivers/mmc/core/core.h |4 ++--
drivers/mmc/core/mmc.c |8
drivers/mmc/core/sd.c |2 +-
drivers/mmc/core/sdio.c |3 +--
5 files changed, 31 insertions(+), 21 deletions(-)
diff --git a
This host_ops member is used to test if the card is signaling busy by
pulling dat[0:3] low.
Signed-off-by: Johan Rudholm
---
include/linux/mmc/host.h |3 +++
1 file changed, 3 insertions(+)
diff --git a/include/linux/mmc/host.h b/include/linux/mmc/host.h
index 61a10c1..3b56ef2 100644
--- a
Hi Kevin and Ulf,
2013/1/8 Ulf Hansson :
> On 8 January 2013 01:56, Kevin Liu wrote:
>> 2013/1/8 Ulf Hansson :
>>> On 7 January 2013 16:10, Johan Rudholm wrote:
>>>> Allow callers to access the start_signal_voltage_switch host_ops
>>>> member with
Allow callers to access the start_signal_voltage_switch host_ops
member without going through any cmd11 logic. This is mostly a
preparation for the following signal voltage switch patch.
Signed-off-by: Johan Rudholm
---
drivers/mmc/core/core.c | 31 +++
drivers/mmc
: Johan Rudholm
Signed-off-by: Kevin Liu
Signed-off-by: Ulf Hansson
---
drivers/mmc/core/core.c | 83 +--
drivers/mmc/core/sd.c | 21 +---
drivers/mmc/core/sdio.c | 20 ++--
3 files changed, 107 insertions(+), 17 deletions
mc_host_clk_hold / mmc_host_clk_release
- Add retry-loop / power cycle in sdio.c
- Fall back to 3.3 V if the switch repeatedly fails
- Add an extra argument to the card_busy host_ops function,
which can be used to signal polling use of the function
Johan Rudholm (
Add mmc_power_cycle which can be used to power cycle for instance
SD-cards.
Signed-off-by: Johan Rudholm
---
drivers/mmc/core/core.c |8
drivers/mmc/core/core.h |1 +
2 files changed, 9 insertions(+)
diff --git a/drivers/mmc/core/core.c b/drivers/mmc/core/core.c
index aaed768
This host_ops member is used to test if the card is signaling busy by
pulling dat[0:3] low.
Signed-off-by: Johan Rudholm
---
include/linux/mmc/host.h |3 +++
1 file changed, 3 insertions(+)
diff --git a/include/linux/mmc/host.h b/include/linux/mmc/host.h
index 61a10c1..3b56ef2 100644
--- a
Hi,
2013/1/3 Johan Rudholm :
> + err = host->ops->start_signal_voltage_switch(host,
> &host->ios);
> + if (err) {
> + /*
> +* Voltages may not been switched, but we've already
> +
This host_ops member is used to test if the card is signaling busy by
pulling dat[0:3] low.
Signed-off-by: Johan Rudholm
---
include/linux/mmc/host.h |3 +++
1 file changed, 3 insertions(+)
diff --git a/include/linux/mmc/host.h b/include/linux/mmc/host.h
index 61a10c1..3b56ef2 100644
--- a
Add mmc_power_cycle which can be used to power cycle for instance
SD-cards.
Signed-off-by: Johan Rudholm
---
drivers/mmc/core/core.c |8
drivers/mmc/core/core.h |1 +
2 files changed, 9 insertions(+)
diff --git a/drivers/mmc/core/core.c b/drivers/mmc/core/core.c
index aaed768
: Johan Rudholm
Signed-off-by: Kevin Liu
Signed-off-by: Ulf Hansson
---
drivers/mmc/core/core.c | 72 ---
drivers/mmc/core/sd.c | 21 ++
drivers/mmc/core/sdio.c | 20 +++--
3 files changed, 102 insertions(+), 11 deletions
- Keep calls to mmc_host_clk_hold / mmc_host_clk_release
- Add retry-loop / power cycle in sdio.c
- Fall back to 3.3 V if the switch repeatedly fails
- Add an extra argument to the card_busy host_ops function,
which can be used to signal polling use of the function
Johan Rudho
Hi Kevin,
2012/12/18 Kevin Liu :
> 2012/12/18 Johan Rudholm :
<...>
>> + host->ios.signal_voltage = signal_voltage;
>> err = host->ops->start_signal_voltage_switch(host,
>> &host->ios);
>> - mmc_h
- Add retry-loop / power cycle in sdio.c
- Fall back to 3.3 V if the switch repeatedly fails
- Add an extra argument to the card_busy host_ops function,
which can be used to signal polling use of the function
Johan Rudholm (3):
mmc: core: Add mmc_power_cycle
mmc:
Add mmc_power_cycle which can be used to power cycle for instance
SD-cards.
Signed-off-by: Johan Rudholm
---
drivers/mmc/core/core.c |8
drivers/mmc/core/core.h |1 +
2 files changed, 9 insertions(+)
diff --git a/drivers/mmc/core/core.c b/drivers/mmc/core/core.c
index aaed768
This host_ops member is used to test if the card is signaling busy by
pulling dat[0:3] low.
Signed-off-by: Johan Rudholm
---
include/linux/mmc/host.h |3 +++
1 file changed, 3 insertions(+)
diff --git a/include/linux/mmc/host.h b/include/linux/mmc/host.h
index 23df21e..e2ed8c5 100644
--- a
: Johan Rudholm
Signed-off-by: Kevin Liu
Signed-off-by: Ulf Hansson
---
drivers/mmc/core/core.c | 75 +++
drivers/mmc/core/sd.c | 21 +
drivers/mmc/core/sdio.c | 20 +++--
3 files changed, 104 insertions(+), 12 deletions
code for signal voltage setting
>>> mmc: core: cycle power the card in voltage switch rather than
>>> mmc_sd_get_cid
>>
>> Regarding you patches on the core layer. I think it would make sense
>> to instead of patching on top of Johan patchset, if needed, it i
familiar with SDHCI, but don't you need some calls to
sdhci_runtime_pm_get / put here?
Kind regards, Johan
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Kevin,
2012/12/14 Kevin Liu :
>
> Just sent a patchset for sdhci based on your patch. Please help to review.
> Tested with both UHS and non-UHS sd card on sdhci-pxav3 platform.
Great! I'll get on it right away.
Kind regards, Johan
--
To unsubscribe from this list: send the lin
1 - 100 of 157 matches
Mail list logo
