Re: [PATCH 004/182] gpio: generic: factor into gpio_chip struct

2015-12-09 Thread Michael Welling
On Wed, Dec 09, 2015 at 02:12:40PM +0100, Linus Walleij wrote: ... > @@ -55,16 +54,16 @@ static int moxart_gpio_probe(struct platform_device *pdev) > return ret; > } > > - bgc->gc.label = "moxart-gpio"; > - bgc->gc.request = gpiochip_generic_request; > - bgc->gc.fr

Re: [PATCH] spi: omap2-mcspi: add runtime PM to set_cs()

2015-08-31 Thread Michael Welling
On Mon, Aug 31, 2015 at 09:53:55AM +0100, Mark Brown wrote: > On Sun, Aug 30, 2015 at 11:44:45AM -0500, Michael Welling wrote: > > > The patch is currently sitting in linux-next. > > > Not sure why it wasn't merged with 4.2.0-rc8. > > You didn't indicate t

Re: [PATCH] spi: omap2-mcspi: add runtime PM to set_cs()

2015-08-30 Thread Michael Welling
On Sun, Aug 30, 2015 at 05:45:21PM +0300, Jarkko Nikula wrote: > Hi > > On 07/24/2015 07:39 PM, Mark Brown wrote: > > On Wed, Jul 22, 2015 at 08:46:09PM +0200, Sebastian Reichel wrote: > >> Since commit ddcad7e9068eb omap2_mcspi_set_cs() is called without > >> runtime power management requested. T

Re: [PATCH] spi: omap2-mcspi: add runtime PM to set_cs()

2015-07-22 Thread Michael Welling
l; > > /* The controller handles the inverted chip selects > @@ -255,6 +256,12 @@ static void omap2_mcspi_set_cs(struct spi_device *spi, > bool enable) > enable = !enable; > > if (spi->controller_state) { > + i

Re: linux 4.2-rc1 broken Nokia N900

2015-07-21 Thread Michael Welling
On Wed, Jul 22, 2015 at 04:03:07AM +0200, Sebastian Reichel wrote: > Hi, > > On Tue, Jul 21, 2015 at 07:17:41PM -0500, Michael Welling wrote: > > On Tue, Jul 21, 2015 at 11:34:41AM +0200, Pavel Machek wrote: > > > > This code has my head spinning. > > > &g

Re: linux 4.2-rc1 broken Nokia N900

2015-07-21 Thread Michael Welling
On Tue, Jul 21, 2015 at 11:34:41AM +0200, Pavel Machek wrote: This code has my head spinning. I found that the errors do not occur when the driver is built into the kernel. I also found that with the patch below the errors go away. Not sure if it is acceptible but see if it fixes things on your

Re: linux 4.2-rc1 broken Nokia N900

2015-07-21 Thread Michael Welling
On Tue, Jul 21, 2015 at 11:34:41AM +0200, Pavel Machek wrote: > Actually.. for the record I'm _not_ using modules. So either I hit > something different, or problem happens regardless of modules. > Pavel I was able to reproduce

Re: linux 4.2-rc1 broken Nokia N900

2015-07-20 Thread Michael Welling
On Wed, Jul 15, 2015 at 09:49:33PM +0200, Pavel Machek wrote: > Hi! > > > > Ok, so: > > > > > > 4.2-rc1 worked for me, IIRC. > > > > This does not make sense. > > > > Nothing has changed in drivers/spi between these versions. > > Are you sure that 4.2-rc1 worked for you? > > Tested again: yes,

Re: linux 4.2-rc1 broken Nokia N900

2015-07-20 Thread Michael Welling
On Tue, Jul 14, 2015 at 09:14:12AM +0200, Pali Rohár wrote: > On Monday 13 July 2015 17:36:07 Michael Welling wrote: > > On Tue, Jul 14, 2015 at 12:02:44AM +0200, Pali Rohár wrote: > > > I think nothing special. I just call: > > > > > > export ARCH=arm > >

Re: linux 4.2-rc1 broken Nokia N900

2015-07-15 Thread Michael Welling
On Wed, Jul 15, 2015 at 09:49:33PM +0200, Pavel Machek wrote: > Hi! > > > > Ok, so: > > > > > > 4.2-rc1 worked for me, IIRC. > > > > This does not make sense. > > > > Nothing has changed in drivers/spi between these versions. > > Are you sure that 4.2-rc1 worked for you? > > Tested again: yes,

Re: linux 4.2-rc1 broken Nokia N900

2015-07-14 Thread Michael Welling
On Tue, Jul 14, 2015 at 10:01:26PM +0200, Pavel Machek wrote: > On Tue 2015-07-14 11:33:42, Michael Welling wrote: > > On Tue, Jul 14, 2015 at 09:14:12AM +0200, Pali Rohár wrote: > > > On Monday 13 July 2015 17:36:07 Michael Welling wrote: > > > > On Tue, Jul 14,

Re: linux 4.2-rc1 broken Nokia N900

2015-07-14 Thread Michael Welling
On Tue, Jul 14, 2015 at 09:14:12AM +0200, Pali Rohár wrote: > On Monday 13 July 2015 17:36:07 Michael Welling wrote: > > On Tue, Jul 14, 2015 at 12:02:44AM +0200, Pali Rohár wrote: > > > I think nothing special. I just call: > > > > > > export ARCH=arm > >

Re: linux 4.2-rc1 broken Nokia N900

2015-07-13 Thread Michael Welling
On Tue, Jul 14, 2015 at 12:02:44AM +0200, Pali Rohár wrote: > I think nothing special. I just call: > > export ARCH=arm > export CROSS_COMPILE=arm-linux-gnueabi- > make rx51_defconfig > rm -f arch/arm/boot/zImage > make -j12 zImage modules omap3-n900.dtb CONFIG_DEBUG_SECTION_MISMATCH=y > cat arch/

Re: linux 4.2-rc1 broken Nokia N900

2015-07-13 Thread Michael Welling
On Mon, Jul 13, 2015 at 10:34:21PM +0200, Pali Rohár wrote: > On Monday 13 July 2015 22:28:35 Michael Welling wrote: > > On Mon, Jul 13, 2015 at 07:09:06PM +0200, Pali Rohár wrote: > > > Hello, here is my objdump of 4.2-rc2 version: > > > > > > 0

Re: linux 4.2-rc1 broken Nokia N900

2015-07-13 Thread Michael Welling
On Mon, Jul 13, 2015 at 07:09:06PM +0200, Pali Rohár wrote: > Hello, here is my objdump of 4.2-rc2 version: > > 0064 : > 64: e3003182movwr3, #386; 0x182 > 68: e19030b3ldrhr3, [r0, r3] > 6c: e3130004tst r3, #4 >

Re: linux 4.2-rc1 broken Nokia N900

2015-07-13 Thread Michael Welling
On Mon, Jul 13, 2015 at 07:09:06PM +0200, Pali Rohár wrote: > On Monday 13 July 2015 19:03:44 Michael Welling wrote: > > On Mon, Jul 13, 2015 at 10:09:21AM +0200, Sebastian Reichel wrote: > > > [+cc Michael Welling , author of all omap-spi > > > patches between 4.1 a

Re: linux 4.2-rc1 broken Nokia N900

2015-07-13 Thread Michael Welling
On Mon, Jul 13, 2015 at 10:09:21AM +0200, Sebastian Reichel wrote: > [+cc Michael Welling , author of all omap-spi patches > between 4.1 and 4.2-rc1] > > Hi, > > On Sun, Jul 12, 2015 at 11:44:25PM -0700, Tony Lindgren wrote: > > * Pali Rohár [150711 05:07]: > &g

Re: [PATCH 4/4] spi: omap2-mcspi: Handle error on gpio_request

2015-05-24 Thread Michael Welling
On Sun, May 24, 2015 at 10:13:07AM +0200, Nicholas Mc Guire wrote: > On Sat, 23 May 2015, Michael Welling wrote: > > > If a valid GPIO is specified but cannot be requested by the driver, print a > > message and error out of omap2_mcspi_setup. > > > >

[PATCH 4/4] spi: omap2-mcspi: Handle error on gpio_request

2015-05-23 Thread Michael Welling
If a valid GPIO is specified but cannot be requested by the driver, print a message and error out of omap2_mcspi_setup. Signed-off-by: Michael Welling --- drivers/spi/spi-omap2-mcspi.c |9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/spi/spi-omap2-mcspi.c

[PATCH 3/4] spi: omap2-mcspi: Fix GPIO chip select support

2015-05-23 Thread Michael Welling
The OMAP2_MCSPI_CHCONF_FORCE must be toggled even when using GPIO chip selects. This patch conditionally calls the omap2_mcspi_set_cs function to do so when using GPIO chip selects. Signed-off-by: Michael Welling --- drivers/spi/spi-omap2-mcspi.c |6 ++ 1 file changed, 6 insertions

[PATCH 1/4] spi: omap2-mcspi: Remove unnecessary delay

2015-05-23 Thread Michael Welling
The core spi driver handles the delay between transactions. This is a remanant from the transfer_one conversion. Signed-off-by: Michael Welling --- drivers/spi/spi-omap2-mcspi.c |3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/spi/spi-omap2-mcspi.c b/drivers/spi/spi-omap2

[PATCH 0/4] spi: omap2-mcspi: Fixes for recent updates

2015-05-23 Thread Michael Welling
The recent update of the OMAP2 McSPI driver left some unresolved issues. These patches should take care them and again allow for GPIO chip selects and native chip selects. Michael Welling (4): spi: omap2-mcspi: Remove unnecessary delay spi: omap2-mcspi: Fix set_cs function for active high

[PATCH 2/4] spi: omap2-mcspi: Fix set_cs function for active high

2015-05-23 Thread Michael Welling
OMAP2_MCSPI_CHCONF_FORCE bit in omap2_mcspi_set_cs. Signed-off-by: Michael Welling --- drivers/spi/spi-omap2-mcspi.c |7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/spi/spi-omap2-mcspi.c b/drivers/spi/spi-omap2-mcspi.c index 304b427..502db29 100644 --- a/drivers/spi/spi-omap2

Re: [PATCH] spi: omap2-mcspi: Fix native cs with new set_cs

2015-05-22 Thread Michael Welling
On Fri, May 22, 2015 at 01:25:44PM +0100, Mark Brown wrote: > On Thu, May 21, 2015 at 06:48:33PM -0500, Michael Welling wrote: > > > So after reverting this patch I found there is a issue in that it is > > difficult > > to determine when a transfer is complete to prope

Re: [PATCH] spi: omap2-mcspi: Fix native cs with new set_cs

2015-05-21 Thread Michael Welling
On Thu, May 21, 2015 at 10:16:38PM +0100, Mark Brown wrote: > On Thu, May 21, 2015 at 04:04:11PM -0500, Michael Welling wrote: > > > Do you want to revert the patch and apply a new one or should I provide a > > patch that reverts the changes and fixes it all in one? > >

Re: [PATCH] spi: omap2-mcspi: Fix native cs with new set_cs

2015-05-21 Thread Michael Welling
On Thu, May 21, 2015 at 11:18:57AM +0100, Mark Brown wrote: > On Wed, May 20, 2015 at 09:07:09PM -0500, Michael Welling wrote: > > > My guess is that the set_cs needs to be called even when toggling as GPIO. > > > How should I handle this? > > It shouldn't be

Re: [PATCH] spi: omap2-mcspi: Fix native cs with new set_cs

2015-05-20 Thread Michael Welling
On Tue, May 12, 2015 at 08:17:58PM +0100, Mark Brown wrote: > On Tue, May 12, 2015 at 12:38:57PM -0500, Michael Welling wrote: > > GPIO chip select patch series appears to have broken the native chip select > > support. This patch pulls the manual native chip select toggling

Re: AM335x OMAP2 common clock external fixed-clock registration

2015-04-17 Thread Michael Welling
On Fri, Apr 17, 2015 at 11:18:33AM +0100, Russell King - ARM Linux wrote: > On Fri, Apr 17, 2015 at 11:12:03AM +0200, Sebastian Hesselbarth wrote: > > On 17.04.2015 04:00, Michael Welling wrote: > > >On Fri, Apr 17, 2015 at 01:23:50AM +0200, Sebastian Hesselbarth wrote: > &g

Re: AM335x OMAP2 common clock external fixed-clock registration

2015-04-17 Thread Michael Welling
On Fri, Apr 17, 2015 at 11:12:03AM +0200, Sebastian Hesselbarth wrote: > On 17.04.2015 04:00, Michael Welling wrote: > >On Fri, Apr 17, 2015 at 01:23:50AM +0200, Sebastian Hesselbarth wrote: > >>On 17.04.2015 00:09, Michael Welling wrote: > >>>On Thu, Apr 16, 2015

Re: AM335x OMAP2 common clock external fixed-clock registration

2015-04-16 Thread Michael Welling
On Fri, Apr 17, 2015 at 01:23:50AM +0200, Sebastian Hesselbarth wrote: > On 17.04.2015 00:09, Michael Welling wrote: > >On Thu, Apr 16, 2015 at 10:37:19PM +0200, Sebastian Hesselbarth wrote: > >>On 16.04.2015 18:17, Michael Welling wrote: > >>>On Thu, Apr 16, 2015 at

Re: AM335x OMAP2 common clock external fixed-clock registration

2015-04-16 Thread Michael Welling
On Thu, Apr 16, 2015 at 10:37:19PM +0200, Sebastian Hesselbarth wrote: > On 16.04.2015 18:17, Michael Welling wrote: > >On Thu, Apr 16, 2015 at 07:32:32AM +0300, Tero Kristo wrote: > >>On 04/15/2015 11:51 PM, Michael Welling wrote: > >>>On Wed, Apr 15, 2015 at 01

Re: AM335x OMAP2 common clock external fixed-clock registration

2015-04-16 Thread Michael Welling
On Thu, Apr 16, 2015 at 07:32:32AM +0300, Tero Kristo wrote: > On 04/15/2015 11:51 PM, Michael Welling wrote: > >On Wed, Apr 15, 2015 at 01:45:53PM -0700, Mike Turquette wrote: > >>On Wed, Apr 15, 2015 at 12:47 PM, Michael Welling wrote: > >>>On Wed, Apr 15, 2015 at

Re: AM335x OMAP2 common clock external fixed-clock registration

2015-04-15 Thread Michael Welling
On Wed, Apr 15, 2015 at 01:45:53PM -0700, Mike Turquette wrote: > On Wed, Apr 15, 2015 at 12:47 PM, Michael Welling wrote: > > On Wed, Apr 15, 2015 at 09:43:30PM +0300, Tero Kristo wrote: > >> On 04/15/2015 05:09 PM, Michael Welling wrote: > >> >On Wed, Apr 15,

Re: AM335x OMAP2 common clock external fixed-clock registration

2015-04-15 Thread Michael Welling
On Wed, Apr 15, 2015 at 09:43:30PM +0300, Tero Kristo wrote: > On 04/15/2015 05:09 PM, Michael Welling wrote: > >On Wed, Apr 15, 2015 at 09:34:48AM +0300, Tero Kristo wrote: > >>On 04/15/2015 12:17 AM, Michael Welling wrote: > >>>Greetings, > >>> > &

Re: AM335x OMAP2 common clock external fixed-clock registration

2015-04-15 Thread Michael Welling
On Wed, Apr 15, 2015 at 09:34:48AM +0300, Tero Kristo wrote: > On 04/15/2015 12:17 AM, Michael Welling wrote: > >Greetings, > > > >I have developed an AM3354 based SoM and it uses an external SI5351 clock > >generator to drive the clock inputs for an external duart an

AM335x OMAP2 common clock external fixed-clock registration

2015-04-14 Thread Michael Welling
Greetings, I have developed an AM3354 based SoM and it uses an external SI5351 clock generator to drive the clock inputs for an external duart and I2S audio master clock. With the registration according to the documentation the reference clock is not being detected and hence the clock generator is

Re: TSC2004 driver

2014-08-06 Thread Michael Welling
On Wed, Aug 6, 2014 at 5:28 PM, Sebastian Reichel wrote: > Hi, > > On Wed, Aug 06, 2014 at 05:13:19PM -0500, Michael Welling wrote: >> The tsc2005 still needs devicetree conversion, so it is at least 2 >> patches away from where I can use it. > > TSC2005 DT sup

Re: TSC2004 driver

2014-08-06 Thread Michael Welling
On Wed, Aug 6, 2014 at 4:16 PM, Dmitry Torokhov wrote: > On Wed, Aug 06, 2014 at 10:33:18PM +0200, Joachim Eastwood wrote: >> On 6 August 2014 21:37, Dmitry Torokhov wrote: >> > Hi Michael, >> > >> > On Tue, Aug 05, 2014 at 12:06:40PM -0500, Michael Welling

TSC2004 driver

2014-08-05 Thread Michael Welling
The TSC2004 driver has yet to appear in the mainline kernel. We have been using the driver referenced here as provided by TI: https://www.mail-archive.com/linux-omap@vger.kernel.org/msg22018.html Are there any plans of supporting this device in the mainline kernel? Mysteriously a device tree ent

Re: OMAP3/AM3517 EHCI USB Issue

2014-08-04 Thread Michael Welling
On Mon, Aug 04, 2014 at 12:34:16PM +0300, Roger Quadros wrote: > On 08/02/2014 02:51 AM, Michael Welling wrote: > > On Fri, Aug 1, 2014 at 6:04 PM, Michael Welling > > wrote: > >> On Wed, Jul 30, 2014 at 12:03:22PM +0300, Roger Quadros wrote: > >>> On 07/29/

Re: OMAP3/AM3517 EHCI USB Issue

2014-08-01 Thread Michael Welling
On Fri, Aug 1, 2014 at 6:04 PM, Michael Welling wrote: > On Wed, Jul 30, 2014 at 12:03:22PM +0300, Roger Quadros wrote: >> On 07/29/2014 06:20 PM, Michael Welling wrote: >> > On Tue, Jul 29, 2014 at 11:59:07AM +0300, Roger Quadros wrote: >> >> Hi Michael, >

Re: OMAP3/AM3517 EHCI USB Issue

2014-08-01 Thread Michael Welling
On Wed, Jul 30, 2014 at 12:03:22PM +0300, Roger Quadros wrote: > On 07/29/2014 06:20 PM, Michael Welling wrote: > > On Tue, Jul 29, 2014 at 11:59:07AM +0300, Roger Quadros wrote: > >> Hi Michael, > >> > >> On 07/28/2014 09:10 PM, Felipe Balbi wrote: > >&

Re: OMAP3/AM3517 EHCI USB Issue

2014-07-30 Thread Michael Welling
On Wed, Jul 30, 2014 at 1:59 PM, Michael Welling wrote: > On Wed, Jul 30, 2014 at 12:03:22PM +0300, Roger Quadros wrote: >> On 07/29/2014 06:20 PM, Michael Welling wrote: >> > On Tue, Jul 29, 2014 at 11:59:07AM +0300, Roger Quadros wrote: >> >> Hi Michael, >

Re: OMAP3/AM3517 EHCI USB Issue

2014-07-30 Thread Michael Welling
On Wed, Jul 30, 2014 at 12:03:22PM +0300, Roger Quadros wrote: > On 07/29/2014 06:20 PM, Michael Welling wrote: > > On Tue, Jul 29, 2014 at 11:59:07AM +0300, Roger Quadros wrote: > >> Hi Michael, > >> > >> On 07/28/2014 09:10 PM, Felipe Balbi wrote: > >&

Re: OMAP3/AM3517 EHCI USB Issue

2014-07-29 Thread Michael Welling
On Tue, Jul 29, 2014 at 12:51:45AM -0700, Tony Lindgren wrote: > * Felipe Balbi [140728 11:13]: > > On Mon, Jul 28, 2014 at 12:57:39PM -0500, Michael Welling wrote: > > > On Mon, Jul 28, 2014 at 10:57:18AM -0500, Felipe Balbi wrote: > > > > > > > > >

Re: OMAP3/AM3517 EHCI USB Issue

2014-07-29 Thread Michael Welling
On Tue, Jul 29, 2014 at 11:59:07AM +0300, Roger Quadros wrote: > Hi Michael, > > On 07/28/2014 09:10 PM, Felipe Balbi wrote: > > On Mon, Jul 28, 2014 at 12:57:39PM -0500, Michael Welling wrote: > >> On Mon, Jul 28, 2014 at 10:57:18AM -0500, Felipe Balbi wrote: > >>

Re: AM3517 fails to boot 3.16-rc5 device tree kernel

2014-07-21 Thread Michael Welling
On Mon, Jul 21, 2014 at 11:38 AM, Michael Welling wrote: > On Mon, Jul 21, 2014 at 12:09:13AM -0700, Tony Lindgren wrote: >> * Michael Welling [140718 07:42]: >> > On Fri, Jul 18, 2014 at 1:38 AM, Tony Lindgren wrote: >> > > >> > > Hmm maybe double chec

Re: AM3517 fails to boot 3.16-rc5 device tree kernel

2014-07-21 Thread Michael Welling
On Mon, Jul 21, 2014 at 12:09:13AM -0700, Tony Lindgren wrote: > * Michael Welling [140718 07:42]: > > On Fri, Jul 18, 2014 at 1:38 AM, Tony Lindgren wrote: > > > > > > Hmm maybe double check your're booting device tree based kernel > > > instead of l

Re: AM3517 fails to boot 3.16-rc5 device tree kernel

2014-07-18 Thread Michael Welling
On Fri, Jul 18, 2014 at 09:40:48AM -0500, Michael Welling wrote: > On Fri, Jul 18, 2014 at 1:38 AM, Tony Lindgren wrote: > > * mwelling [140717 16:42]: > >> I am in the process of porting a device tree compatible version of the > >> linux kernel to a AM3517 based devi

Re: AM3517 fails to boot 3.16-rc5 device tree kernel

2014-07-18 Thread Michael Welling
On Fri, Jul 18, 2014 at 09:40:48AM -0500, Michael Welling wrote: > On Fri, Jul 18, 2014 at 1:38 AM, Tony Lindgren wrote: > > * mwelling [140717 16:42]: > >> I am in the process of porting a device tree compatible version of the > >> linux kernel to a AM3517 based devi

Re: AM3517 fails to boot 3.16-rc5 device tree kernel

2014-07-18 Thread Michael Welling
On Fri, Jul 18, 2014 at 1:38 AM, Tony Lindgren wrote: > * mwelling [140717 16:42]: >> I am in the process of porting a device tree compatible version of the >> linux kernel to a AM3517 based device. >> >> First I tried 3.10.x and the device tree port appeared to be incomplete. >> Neither the LCD