Re: [PATCH for-next 3/6] IB/ipoib: Handle QP in SQE state

2015-04-16 Thread Erez Shitrit
On 4/15/2015 8:20 PM, Devesh Sharma wrote: -Original Message- From: linux-rdma-ow...@vger.kernel.org [mailto:linux-rdma- ow...@vger.kernel.org] On Behalf Of Or Gerlitz Sent: Thursday, April 02, 2015 4:09 PM To: Roland Dreier; Doug Ledford Cc: linux-rdma@vger.kernel.org; Erez Shitrit; Tal

[PATCH v4 03/27] IB/Verbs: Reform IB-core mad/agent/user_mad

2015-04-16 Thread Michael Wang
Use raw management helpers to reform IB-core mad/agent/user_mad. Cc: Steve Wise sw...@opengridcomputing.com Cc: Tom Talpey t...@talpey.com Cc: Jason Gunthorpe jguntho...@obsidianresearch.com Cc: Doug Ledford dledf...@redhat.com Cc: Ira Weiny ira.we...@intel.com Cc: Sean Hefty

[PATCH v4 17/27] IB/Verbs: Use management helper cap_ib_smi()

2015-04-16 Thread Michael Wang
Introduce helper cap_ib_smi() to help us check if the port of an IB device support Infiniband Subnet Management Interface. Cc: Steve Wise sw...@opengridcomputing.com Cc: Tom Talpey t...@talpey.com Cc: Jason Gunthorpe jguntho...@obsidianresearch.com Cc: Doug Ledford dledf...@redhat.com Cc: Ira

[PATCH v4 15/27] IB/Verbs: Reform rest part in IB-core cma

2015-04-16 Thread Michael Wang
Use raw management helpers to reform rest part in IB-core cma. Cc: Steve Wise sw...@opengridcomputing.com Cc: Tom Talpey t...@talpey.com Cc: Jason Gunthorpe jguntho...@obsidianresearch.com Cc: Doug Ledford dledf...@redhat.com Cc: Ira Weiny ira.we...@intel.com Cc: Sean Hefty sean.he...@intel.com

Re: [PATCH v3 01/28] IB/Verbs: Implement new callback query_transport()

2015-04-16 Thread Michael Wang
Hi, Hal On 04/15/2015 08:36 PM, Hal Rosenstock wrote: On 4/13/2015 8:22 AM, Michael Wang wrote: [snip] __attribute_const__ enum rdma_transport_type @@ -1501,6 +1504,8 @@ struct ib_device { int(*query_port)(struct ib_device *device,

[PATCH v4 00/27] IB/Verbs: IB Management Helpers

2015-04-16 Thread Michael Wang
Since v3: * Apply suggestions from Sean, Ira, Jason, thanks for the comments :-) and please remind me if I missed anything :-P * No more cap_XX_dev(), all the check are per-port now, use port 1 for cases only care about the cm type, can't support mixing cm type device in future.

[PATCH v4 12/27] IB/Verbs: Reform mcast related part in IB-core cma

2015-04-16 Thread Michael Wang
Use raw management helpers to reform mcast related part in IB-core cma. Cc: Steve Wise sw...@opengridcomputing.com Cc: Tom Talpey t...@talpey.com Cc: Jason Gunthorpe jguntho...@obsidianresearch.com Cc: Doug Ledford dledf...@redhat.com Cc: Ira Weiny ira.we...@intel.com Cc: Sean Hefty

[PATCH v4 09/27] IB/Verbs: Reform IB-core verbs/uverbs_cmd/sysfs

2015-04-16 Thread Michael Wang
Use raw management helpers to reform IB-core verbs/uverbs_cmd/sysfs. Cc: Steve Wise sw...@opengridcomputing.com Cc: Tom Talpey t...@talpey.com Cc: Jason Gunthorpe jguntho...@obsidianresearch.com Cc: Doug Ledford dledf...@redhat.com Cc: Ira Weiny ira.we...@intel.com Cc: Sean Hefty

[PATCH v4 10/27] IB/Verbs: Reform cm related part in IB-core cma/ucm

2015-04-16 Thread Michael Wang
Use raw management helpers to reform cm related part in IB-core cma/ucm. These checks focus on the device cm type rather than the port capability, directly pass port 1 works currently, but can't support mixing cm type device in future. Cc: Steve Wise sw...@opengridcomputing.com Cc: Tom Talpey

[PATCH v4 05/27] IB/Verbs: Reform IB-core sa_query

2015-04-16 Thread Michael Wang
Use raw management helpers to reform IB-core sa_query. Cc: Steve Wise sw...@opengridcomputing.com Cc: Tom Talpey t...@talpey.com Cc: Jason Gunthorpe jguntho...@obsidianresearch.com Cc: Doug Ledford dledf...@redhat.com Cc: Ira Weiny ira.we...@intel.com Cc: Sean Hefty sean.he...@intel.com

[PATCH v4 07/27] IB/Verbs: Reform IB-ulp ipoib

2015-04-16 Thread Michael Wang
Use raw management helpers to reform IB-ulp ipoib. Cc: Steve Wise sw...@opengridcomputing.com Cc: Tom Talpey t...@talpey.com Cc: Jason Gunthorpe jguntho...@obsidianresearch.com Cc: Doug Ledford dledf...@redhat.com Cc: Ira Weiny ira.we...@intel.com Cc: Sean Hefty sean.he...@intel.com

[PATCH v4 04/27] IB/Verbs: Reform IB-core cm

2015-04-16 Thread Michael Wang
Use raw management helpers to reform IB-core cm. Cc: Steve Wise sw...@opengridcomputing.com Cc: Tom Talpey t...@talpey.com Cc: Jason Gunthorpe jguntho...@obsidianresearch.com Cc: Doug Ledford dledf...@redhat.com Cc: Ira Weiny ira.we...@intel.com Cc: Sean Hefty sean.he...@intel.com Signed-off-by:

[PATCH v4 06/27] IB/Verbs: Reform IB-core multicast

2015-04-16 Thread Michael Wang
Use raw management helpers to reform IB-core multicast. Cc: Steve Wise sw...@opengridcomputing.com Cc: Tom Talpey t...@talpey.com Cc: Jason Gunthorpe jguntho...@obsidianresearch.com Cc: Doug Ledford dledf...@redhat.com Cc: Ira Weiny ira.we...@intel.com Cc: Sean Hefty sean.he...@intel.com

RE: [PATCH for-next 3/6] IB/ipoib: Handle QP in SQE state

2015-04-16 Thread Devesh Sharma
-Original Message- From: Erez Shitrit [mailto:ere...@dev.mellanox.co.il] Sent: Thursday, April 16, 2015 12:14 PM To: Devesh Sharma; Or Gerlitz; Roland Dreier; Doug Ledford Cc: linux-rdma@vger.kernel.org; Erez Shitrit; Tal Alon; Amir Vadai Subject: Re: [PATCH for-next 3/6] IB/ipoib:

[PATCH v4 14/27] IB/Verbs: Reform cma_acquire_dev()

2015-04-16 Thread Michael Wang
Reform cma_acquire_dev() with management helpers, introduce cma_validate_port() to make the code more clean. Cc: Steve Wise sw...@opengridcomputing.com Cc: Tom Talpey t...@talpey.com Cc: Jason Gunthorpe jguntho...@obsidianresearch.com Cc: Doug Ledford dledf...@redhat.com Cc: Ira Weiny

[PATCH v4 13/27] IB/Verbs: Reserve legacy transport type in 'dev_addr'

2015-04-16 Thread Michael Wang
Reserve the legacy transport type for the 'transport' member of 'struct rdma_dev_addr' until we make sure this is no longer needed. Cc: Steve Wise sw...@opengridcomputing.com Cc: Tom Talpey t...@talpey.com Cc: Jason Gunthorpe jguntho...@obsidianresearch.com Cc: Doug Ledford dledf...@redhat.com

[PATCH v4 19/27] IB/Verbs: Use management helper cap_iw_cm()

2015-04-16 Thread Michael Wang
Introduce helper cap_iw_cm() to help us check if the port of an IB device support IWARP Communication Manager. Cc: Steve Wise sw...@opengridcomputing.com Cc: Tom Talpey t...@talpey.com Cc: Jason Gunthorpe jguntho...@obsidianresearch.com Cc: Doug Ledford dledf...@redhat.com Cc: Ira Weiny

[PATCH v4 22/27] IB/Verbs: Use management helper cap_ipoib()

2015-04-16 Thread Michael Wang
Introduce helper cap_ipoib() to help us check if the port of an IB device support IP over Infiniband. Cc: Steve Wise sw...@opengridcomputing.com Cc: Tom Talpey t...@talpey.com Cc: Jason Gunthorpe jguntho...@obsidianresearch.com Cc: Doug Ledford dledf...@redhat.com Cc: Ira Weiny

[PATCH v4 20/27] IB/Verbs: Use management helper cap_ib_sa()

2015-04-16 Thread Michael Wang
Introduce helper cap_ib_sa() to help us check if the port of an IB device support Infiniband Subnet Administrator. Cc: Steve Wise sw...@opengridcomputing.com Cc: Tom Talpey t...@talpey.com Cc: Jason Gunthorpe jguntho...@obsidianresearch.com Cc: Doug Ledford dledf...@redhat.com Cc: Ira Weiny

[PATCH v4 24/27] IB/Verbs: Use management helper cap_af_ib()

2015-04-16 Thread Michael Wang
Introduce helper cap_af_ib() to help us check if the port of an IB device support Native Infiniband Address. Cc: Steve Wise sw...@opengridcomputing.com Cc: Tom Talpey t...@talpey.com Cc: Jason Gunthorpe jguntho...@obsidianresearch.com Cc: Doug Ledford dledf...@redhat.com Cc: Ira Weiny

[PATCH v4 23/27] IB/Verbs: Use management helper cap_read_multi_sge()

2015-04-16 Thread Michael Wang
Introduce helper cap_read_multi_sge() to help us check if the port of an IB device support RDMA Read Multiple Scatter-Gather Entries. Cc: Steve Wise sw...@opengridcomputing.com Cc: Tom Talpey t...@talpey.com Cc: Jason Gunthorpe jguntho...@obsidianresearch.com Cc: Doug Ledford dledf...@redhat.com

[PATCH v4 25/27] IB/Verbs: Use management helper cap_eth_ah()

2015-04-16 Thread Michael Wang
Introduce helper cap_eth_ah() to help us check if the port of an IB device support Ethernet Address Handler. Cc: Steve Wise sw...@opengridcomputing.com Cc: Tom Talpey t...@talpey.com Cc: Jason Gunthorpe jguntho...@obsidianresearch.com Cc: Doug Ledford dledf...@redhat.com Cc: Ira Weiny

[PATCH v4 11/27] IB/Verbs: Reform route related part in IB-core cma

2015-04-16 Thread Michael Wang
Use raw management helpers to reform route related part in IB-core cma. Cc: Steve Wise sw...@opengridcomputing.com Cc: Tom Talpey t...@talpey.com Cc: Jason Gunthorpe jguntho...@obsidianresearch.com Cc: Doug Ledford dledf...@redhat.com Cc: Ira Weiny ira.we...@intel.com Cc: Sean Hefty

[PATCH v4 01/27] IB/Verbs: Implement new callback query_transport()

2015-04-16 Thread Michael Wang
Add new callback query_transport() and implement for each HW. Mapping List: node-type link-layer old-transport new-transport nes RNICETH IWARP IWARP amso1100RNICETH IWARP IWARP

[PATCH v4 26/27] IB/Verbs: Clean up rdma_ib_or_iboe()

2015-04-16 Thread Michael Wang
We have finished introducing the cap_XX(), and raw helper rdma_ib_or_iboe() is no longer necessary, thus clean it up. Cc: Steve Wise sw...@opengridcomputing.com Cc: Tom Talpey t...@talpey.com Cc: Jason Gunthorpe jguntho...@obsidianresearch.com Cc: Doug Ledford dledf...@redhat.com Cc: Ira Weiny

[PATCH v4 27/27] IB/Verbs: Cleanup rdma_node_get_transport()

2015-04-16 Thread Michael Wang
We have get rid of all the scene using legacy rdma_node_get_transport(), now clean it up. Cc: Steve Wise sw...@opengridcomputing.com Cc: Tom Talpey t...@talpey.com Cc: Jason Gunthorpe jguntho...@obsidianresearch.com Cc: Doug Ledford dledf...@redhat.com Cc: Ira Weiny ira.we...@intel.com Cc: Sean

[PATCH v4 02/27] IB/Verbs: Implement raw management helpers

2015-04-16 Thread Michael Wang
Add raw helpers: rdma_tech_ib rdma_tech_iboe rdma_tech_iwarp rdma_ib_or_iboe (transition, clean up later) To help us detect which technology the port supported. Cc: Steve Wise sw...@opengridcomputing.com Cc: Tom Talpey t...@talpey.com Cc: Jason Gunthorpe

Re: [PATCH v3 for-next 01/33] IB/core: Add RoCE GID cache

2015-04-16 Thread Matan Barak
AFAIK, RoCE v2 is the known and official name. Why would we like to come up with a customized name? These are indeed two different protocols, thus the comparison to DHCP assigned addresses and static addresses is (to say the least) a bit off. Even when comparing IPv4 and IPv6, the most

[PATCH RFC] IB/core: Get rid of redundant verb ib_destroy_mr

2015-04-16 Thread Sagi Grimberg
This was added (by me) in a thought of starting a unification of all mr allocation and destruction routines but the fact is we have a single destruction routine already, ib_dereg_mr. So another verb that essentially does the same thing is really redundant. And, move mlx5_ib_destroy_mr specific

Re: [PATCH v3 for-next 01/33] IB/core: Add RoCE GID cache

2015-04-16 Thread Moni Shoua
On Wed, Apr 15, 2015 at 7:08 PM, Hefty, Sean sean.he...@intel.com wrote: It does not break every app, the choice of which GID type to use is made by the RDMA-CM based on network topology hint obtained from the IP stack. Please refer to patch 15/33: IB/Core: Changes to the IB Core

Re: [PATCH v3 01/28] IB/Verbs: Implement new callback query_transport()

2015-04-16 Thread Hal Rosenstock
On 4/15/2015 4:33 PM, ira.weiny wrote: On Wed, Apr 15, 2015 at 02:36:13PM -0400, Hal Rosenstock wrote: On 4/13/2015 8:22 AM, Michael Wang wrote: diff --git a/include/rdma/ib_verbs.h b/include/rdma/ib_verbs.h index 65994a1..d54f91e 100644 --- a/include/rdma/ib_verbs.h +++

Re: [PATCH v4 04/27] IB/Verbs: Reform IB-core cm

2015-04-16 Thread Michael Wang
On 04/16/2015 02:43 PM, Hal Rosenstock wrote: [snip] + +count++; } + +if (!count) { +device_unregister(cm_dev-device); +kfree(cm_dev); +return; Nit: alternatively, this could be goto at end of this routine where there is same 2

Re: [PATCH linux-next 1/4] infiniband/ipoib: fix possible NULL pointer dereference in ipoib_get_iflink

2015-04-16 Thread Erez Shitrit
On Wed, Apr 15, 2015 at 7:06 PM, Jason Gunthorpe jguntho...@obsidianresearch.com wrote: On Wed, Apr 15, 2015 at 09:17:14AM +0300, Erez Shitrit wrote: + /* parent interface */ + if (!test_bit(IPOIB_FLAG_SUBINTERFACE, priv-flags)) + return dev-ifindex; + + /*

Re: RDMA patches for 4.1

2015-04-16 Thread Or Gerlitz
On 4/15/2015 11:45 PM, Doug Ledford wrote: On Wed, 2015-04-15 at 12:38 -0700, Roland Dreier wrote: On Wed, Apr 15, 2015 at 11:16 AM, Doug Ledford dledf...@redhat.com wrote: He has patches that don't conflict available. I can rebase my tree to that if you want. I just can't do it for a couple

Re: [PATCH v4 03/27] IB/Verbs: Reform IB-core mad/agent/user_mad

2015-04-16 Thread Hal Rosenstock
On 4/16/2015 4:05 AM, Michael Wang wrote: Use raw management helpers to reform IB-core mad/agent/user_mad. Cc: Steve Wise sw...@opengridcomputing.com Cc: Tom Talpey t...@talpey.com Cc: Jason Gunthorpe jguntho...@obsidianresearch.com Cc: Doug Ledford dledf...@redhat.com Cc: Ira Weiny

Re: [PATCH for-next 3/6] IB/ipoib: Handle QP in SQE state

2015-04-16 Thread Doug Ledford
On Apr 15, 2015, at 9:29 AM, Erez Shitrit ere...@dev.mellanox.co.il wrote: Hi Doug (now with reply to all :) ) On Wed, Apr 15, 2015 at 3:08 PM, Doug Ledford dledf...@redhat.com wrote: On Apr 2, 2015, at 6:39 AM, Or Gerlitz ogerl...@mellanox.com wrote: From: Erez Shitrit

Re: [PATCH v4 14/27] IB/Verbs: Reform cma_acquire_dev()

2015-04-16 Thread Hal Rosenstock
On 4/16/2015 9:35 AM, Michael Wang wrote: On 04/16/2015 03:19 PM, Hal Rosenstock wrote: [snip] +static inline int cma_validate_port(struct ib_device *device, u8 port, + union ib_gid *gid, int dev_type) +{ + u8 found_port; + int ret = -ENODEV; + +

Re: [PATCH v4 27/27] IB/Verbs: Cleanup rdma_node_get_transport()

2015-04-16 Thread Hal Rosenstock
On 4/16/2015 9:41 AM, Michael Wang wrote: On 04/16/2015 03:36 PM, Hal Rosenstock wrote: [snip] -EXPORT_SYMBOL(rdma_node_get_transport); - enum rdma_link_layer rdma_port_get_link_layer(struct ib_device *device, u8 port_num) { if (device-get_link_layer) diff --git

RE: [PATCH v4 10/27] IB/Verbs: Reform cm related part in IB-core cma/ucm

2015-04-16 Thread Hefty, Sean
This is equivalent to today where the checks are per node rather than per port. Should all checks here be port 1 based or only certain ones like listen ? For example, in connect/reject/disconnect, don't we already have port ? Guess this can be dealt with later as this is not a

Re: [PATCH v4 10/27] IB/Verbs: Reform cm related part in IB-core cma/ucm

2015-04-16 Thread Hal Rosenstock
On 4/16/2015 4:08 AM, Michael Wang wrote: Use raw management helpers to reform cm related part in IB-core cma/ucm. These checks focus on the device cm type rather than the port capability, directly pass port 1 works currently, but can't support mixing cm type device in future. This is

[PATCH infiniband-diags] Close additional file descriptor in iblinkinfo in advance

2015-04-16 Thread Hal Rosenstock
From: Vladimir Koushnir vladim...@mellanox.com Date: Tue, 14 Apr 2015 18:14:48 +0300 Additional file descriptor for SMP MADs should be closed before running ibnd_discover_fabric() to avoid parallel usage of two SMP file descriptors Signed-off-by: Vladimir Koushnir vladim...@mellanox.com

Re: [PATCH v3 25/28] IB/Verbs: Use management helper cap_af_ib()

2015-04-16 Thread Or Gerlitz
On Mon, Apr 13, 2015 at 3:35 PM, Michael Wang yun.w...@profitbricks.com wrote: Introduce helper cap_af_ib() to help us check if the port of an IB device support Native Infiniband Address. Cc: Steve Wise sw...@opengridcomputing.com Cc: Tom Talpey t...@talpey.com Cc: Jason Gunthorpe

[PATCH infiniband-diags] query_smp.c: Avoid busy looping in process_one_recv

2015-04-16 Thread Hal Rosenstock
From: Vladimir Koushnir vladim...@mellanox.com Date: Thu, 16 Apr 2015 14:11:16 +0300 Today, process_one_recv calls umad_recv with zero timeout. That means umad_recv will use non-blocking read() without polling, In many cases, this causes busy loop. In the fix, umad_recv is invoked with -1

Re: [PATCH for-next 3/6] IB/ipoib: Handle QP in SQE state

2015-04-16 Thread Doug Ledford
On Apr 16, 2015, at 10:32 AM, Erez Shitrit ere...@dev.mellanox.co.il wrote: On Thu, Apr 16, 2015 at 4:29 PM, Doug Ledford dledf...@redhat.com wrote: On Apr 15, 2015, at 9:29 AM, Erez Shitrit ere...@dev.mellanox.co.il wrote: Hi Doug (now with reply to all :) ) On Wed, Apr 15, 2015

RE: [PATCH v3 for-next 01/33] IB/core: Add RoCE GID cache

2015-04-16 Thread Hefty, Sean
RoCE v2 is really Infiniband over UDP over IP. Why don't we just call it IBoUDP like it is? RoCEv2 is the name in the IBTA spec (Annex 17) We call RoCE IBoE in the kernel, because that's what it is. RoCE is an IBTA marketing name. Looking through the Annex, I don't see where Ethernet is

RE: [PATCH v3 25/28] IB/Verbs: Use management helper cap_af_ib()

2015-04-16 Thread Hefty, Sean
diff --git a/drivers/infiniband/core/cma.c b/drivers/infiniband/core/cma.c index 65e41f4..7f5815d 100644 --- a/drivers/infiniband/core/cma.c +++ b/drivers/infiniband/core/cma.c @@ -470,7 +470,7 @@ static int cma_resolve_ib_dev(struct rdma_id_private *id_priv)

Re: [PATCH v4 10/27] IB/Verbs: Reform cm related part in IB-core cma/ucm

2015-04-16 Thread Jason Gunthorpe
On Thu, Apr 16, 2015 at 10:08:10AM +0200, Michael Wang wrote: Use raw management helpers to reform cm related part in IB-core cma/ucm. These checks focus on the device cm type rather than the port capability, directly pass port 1 works currently, but can't support mixing cm type device in

Re: [PATCH V1 net-next] IB/ipoib: Fix ndo_get_iflink

2015-04-16 Thread Jason Gunthorpe
On Thu, Apr 16, 2015 at 04:34:34PM +0300, Erez Shitrit wrote: Currently, iflink of the parent interface was always accessed, even when interface didn't have a parent and hence we crashed there. Handle the interface types properly: for a child interface, return the ifindex of the parent, for

Re: [PATCH v4 10/27] IB/Verbs: Reform cm related part in IB-core cma/ucm

2015-04-16 Thread Michael Wang
On 04/16/2015 04:31 PM, Hefty, Sean wrote: This is equivalent to today where the checks are per node rather than per port. Should all checks here be port 1 based or only certain ones like listen ? For example, in connect/reject/disconnect, don't we already have port ? Guess this can be

Re: [PATCH v3 25/28] IB/Verbs: Use management helper cap_af_ib()

2015-04-16 Thread Michael Wang
On 04/16/2015 05:09 PM, Hefty, Sean wrote: [snip] Sean, can you please put a precise writeup what does it take to support AF_IB... I am a bit confused here and wasn't sure if this can be supported with RoCE. I think this means IB GID addressing is checked (Native Infiniband Address) and

Re: [PATCH v3 27/28] IB/Verbs: Clean up rdma_ib_or_iboe()

2015-04-16 Thread Jason Gunthorpe
On Tue, Apr 14, 2015 at 11:13:03AM +0200, Michael Wang wrote: I would be very happy to see a patch that adds cap_ib_smi to the current tree and states 'This patch is tested to have no change on the binary compilation results' There are too much reform there (per-dev to per-port), I guess

Re: [PATCH v3 07/28] IB/Verbs: Reform IB-ulp ipoib

2015-04-16 Thread Roland Dreier
On Thu, Apr 16, 2015 at 9:44 AM, Jason Gunthorpe jguntho...@obsidianresearch.com wrote: We can give client-add() callback a return value and make ib_register_device() return -ENOMEM when it failed, just wondering why we don't do this at first, any special reason? No idea, but having

RE: [PATCH v3 07/28] IB/Verbs: Reform IB-ulp ipoib

2015-04-16 Thread Weiny, Ira
On Wed, Apr 15, 2015 at 09:58:18AM +0200, Michael Wang wrote: We can give client-add() callback a return value and make ib_register_device() return -ENOMEM when it failed, just wondering why we don't do this at first, any special reason? No idea, but having ib_register_device fail

Re: [PATCH v3 07/28] IB/Verbs: Reform IB-ulp ipoib

2015-04-16 Thread Jason Gunthorpe
On Wed, Apr 15, 2015 at 09:58:18AM +0200, Michael Wang wrote: We can give client-add() callback a return value and make ib_register_device() return -ENOMEM when it failed, just wondering why we don't do this at first, any special reason? No idea, but having ib_register_device fail and unwind

RE: [PATCH v4 10/27] IB/Verbs: Reform cm related part in IB-core cma/ucm

2015-04-16 Thread Hefty, Sean
After the discussion settled, I ended up thinking that implementing explicit device checks, for use by CM, and the BUG_ON at register to require all ports have the same value was the best option. Sure, but why not update the other areas anyway? This way when listens become per port, rather

Re: [PATCH v4 10/27] IB/Verbs: Reform cm related part in IB-core cma/ucm

2015-04-16 Thread Jason Gunthorpe
On Thu, Apr 16, 2015 at 04:55:10PM +, Hefty, Sean wrote: After the discussion settled, I ended up thinking that implementing explicit device checks, for use by CM, and the BUG_ON at register to require all ports have the same value was the best option. Sure, but why not update the

Re: [PATCH V1 net-next] IB/ipoib: Fix ndo_get_iflink

2015-04-16 Thread Yann Droneaud
Hi, Le jeudi 16 avril 2015 à 16:34 +0300, Erez Shitrit a écrit : Currently, iflink of the parent interface was always accessed, even when interface didn't have a parent and hence we crashed there. + since commit 5aa7add8f14b ('infiniband/ipoib: implement ndo_get_iflink'). as there was no

Re: [PATCH v4 10/27] IB/Verbs: Reform cm related part in IB-core cma/ucm

2015-04-16 Thread Tom Talpey
On 4/16/2015 11:22 AM, Michael Wang wrote: On 04/16/2015 04:31 PM, Hefty, Sean wrote: This is equivalent to today where the checks are per node rather than per port. Should all checks here be port 1 based or only certain ones like listen ? For example, in connect/reject/disconnect, don't we

RE: [PATCH v3 07/28] IB/Verbs: Reform IB-ulp ipoib

2015-04-16 Thread Hefty, Sean
No idea, but having ib_register_device fail and unwind if a client fails to attach makes sense to me. It seems a bit unfriendly to fail an entire device if one ULP has a problem. Let's say you have a system whose main network connection is IPoIB. Would you want that connection to come

[PATCH net-next] IB/ipoib: Fix ndo_get_iflink

2015-04-16 Thread Erez Shitrit
Currently, iflink of the parent interface was always accessed, event when interface didn't have a parent and hence we rashed there. Handle the interface types properly: for a child interface, return the ifindex of the parent, for parent interface, return its ifindex. For child devices, make

Re: [PATCH v4 14/27] IB/Verbs: Reform cma_acquire_dev()

2015-04-16 Thread Michael Wang
On 04/16/2015 03:19 PM, Hal Rosenstock wrote: [snip] +static inline int cma_validate_port(struct ib_device *device, u8 port, + union ib_gid *gid, int dev_type) +{ +u8 found_port; +int ret = -ENODEV; + +if ((dev_type == ARPHRD_INFINIBAND)

[PATCH V1 net-next] IB/ipoib: Fix ndo_get_iflink

2015-04-16 Thread Erez Shitrit
Currently, iflink of the parent interface was always accessed, even when interface didn't have a parent and hence we crashed there. Handle the interface types properly: for a child interface, return the ifindex of the parent, for parent interface, return its ifindex. For child devices, make

Re: [PATCH v4 27/27] IB/Verbs: Cleanup rdma_node_get_transport()

2015-04-16 Thread Tom Tucker
On 4/16/15 8:45 AM, Michael Wang wrote: On 04/16/2015 03:42 PM, Hal Rosenstock wrote: On 4/16/2015 9:41 AM, Michael Wang wrote: On 04/16/2015 03:36 PM, Hal Rosenstock wrote: [snip] -EXPORT_SYMBOL(rdma_node_get_transport); - enum rdma_link_layer rdma_port_get_link_layer(struct ib_device

[PATCH v1 1/2] IB/core: dma map/unmap locking optimizations

2015-04-16 Thread Guy Shapiro
Currently, while mapping or unmapping pages for ODP, the umem mutex is locked and unlocked once for each page. Such lock/unlock operation take few tens to hundreds of nsecs. This makes a significant impact when mapping or unmapping few MBs of memory. To avoid this, the mutex should be locked only

[PATCH v1 0/2] ODP performance improvements

2015-04-16 Thread Guy Shapiro
This patchset contains small changes that improve the performance of memory map updates. The patches reduce the execution time of ib_umem_odp_unmap_dma_pages when invalidating 4MB of memory from 46us to 13us. This amounts to a reduction of about 30% in the total execution time of the invalidation

[PATCH v1 2/2] IB/core: dma unmap optimizations

2015-04-16 Thread Guy Shapiro
While unmapping an ODP writable page, the dirty bit of the page is set. In order to do so, the head of the compound page is found. Currently, the compound head is found even on non-writable pages, where it is never used, leading to unnecessary cpu barrier that impacts performance. This patch

Re: [PATCH v4 14/27] IB/Verbs: Reform cma_acquire_dev()

2015-04-16 Thread Hal Rosenstock
On 4/16/2015 4:09 AM, Michael Wang wrote: Reform cma_acquire_dev() with management helpers, introduce cma_validate_port() to make the code more clean. Cc: Steve Wise sw...@opengridcomputing.com Cc: Tom Talpey t...@talpey.com Cc: Jason Gunthorpe jguntho...@obsidianresearch.com Cc: Doug

Re: [PATCH v4 20/27] IB/Verbs: Use management helper cap_ib_sa()

2015-04-16 Thread Michael Wang
On 04/16/2015 03:36 PM, Hal Rosenstock wrote: On 4/16/2015 4:12 AM, Michael Wang wrote: Introduce helper cap_ib_sa() to help us check if the port of an IB device support Infiniband Subnet Administrator. Nit: Administrator - Administration Will be in next version :-) Regards, Michael

Re: [PATCH v4 27/27] IB/Verbs: Cleanup rdma_node_get_transport()

2015-04-16 Thread Michael Wang
On 04/16/2015 03:36 PM, Hal Rosenstock wrote: [snip] -EXPORT_SYMBOL(rdma_node_get_transport); - enum rdma_link_layer rdma_port_get_link_layer(struct ib_device *device, u8 port_num) { if (device-get_link_layer) diff --git a/include/rdma/ib_verbs.h b/include/rdma/ib_verbs.h index

Re: [PATCH v4 27/27] IB/Verbs: Cleanup rdma_node_get_transport()

2015-04-16 Thread Michael Wang
On 04/16/2015 03:42 PM, Hal Rosenstock wrote: On 4/16/2015 9:41 AM, Michael Wang wrote: On 04/16/2015 03:36 PM, Hal Rosenstock wrote: [snip] -EXPORT_SYMBOL(rdma_node_get_transport); - enum rdma_link_layer rdma_port_get_link_layer(struct ib_device *device, u8 port_num) { if

Re: [PATCH v3 25/28] IB/Verbs: Use management helper cap_af_ib()

2015-04-16 Thread Hal Rosenstock
On 4/16/2015 9:57 AM, Or Gerlitz wrote: On Mon, Apr 13, 2015 at 3:35 PM, Michael Wang yun.w...@profitbricks.com wrote: Introduce helper cap_af_ib() to help us check if the port of an IB device support Native Infiniband Address. Cc: Steve Wise sw...@opengridcomputing.com Cc: Tom Talpey

Re: [PATCH v4 20/27] IB/Verbs: Use management helper cap_ib_sa()

2015-04-16 Thread Hal Rosenstock
On 4/16/2015 4:12 AM, Michael Wang wrote: Introduce helper cap_ib_sa() to help us check if the port of an IB device support Infiniband Subnet Administrator. Nit: Administrator - Administration Cc: Steve Wise sw...@opengridcomputing.com Cc: Tom Talpey t...@talpey.com Cc: Jason Gunthorpe

Re: [PATCH v4 27/27] IB/Verbs: Cleanup rdma_node_get_transport()

2015-04-16 Thread Hal Rosenstock
On 4/16/2015 4:15 AM, Michael Wang wrote: We have get rid of all the scene using legacy rdma_node_get_transport(), now clean it up. Cc: Steve Wise sw...@opengridcomputing.com Cc: Tom Talpey t...@talpey.com Cc: Jason Gunthorpe jguntho...@obsidianresearch.com Cc: Doug Ledford

Re: [PATCH for-next 3/6] IB/ipoib: Handle QP in SQE state

2015-04-16 Thread Erez Shitrit
On Thu, Apr 16, 2015 at 4:29 PM, Doug Ledford dledf...@redhat.com wrote: On Apr 15, 2015, at 9:29 AM, Erez Shitrit ere...@dev.mellanox.co.il wrote: Hi Doug (now with reply to all :) ) On Wed, Apr 15, 2015 at 3:08 PM, Doug Ledford dledf...@redhat.com wrote: On Apr 2, 2015, at 6:39 AM, Or

RE: [PATCH v4 10/27] IB/Verbs: Reform cm related part in IB-core cma/ucm

2015-04-16 Thread Hefty, Sean
To be confirmed: PORT ASSIGNED rdma_init_qp_attr Y rdma_destroy_id unknown cma_listen_on_dev N cma_bind_loopback N Bind loopback will attach to a port, but the id does not have on entry. rdma_listen

Re: [PATCH v4 10/27] IB/Verbs: Reform cm related part in IB-core cma/ucm

2015-04-16 Thread Hal Rosenstock
On 4/16/2015 11:58 AM, Jason Gunthorpe wrote: It also looks like hardwired 1 won't work on switch ports, so it is no-go. AFAIK enhanced switch port 0 is not supported by CM/RDMA CM in the current code. There is no need for CM/RDMA CM on base switch port 0. -- To unsubscribe from this list: send

RE: [PATCH v4 10/27] IB/Verbs: Reform cm related part in IB-core cma/ucm

2015-04-16 Thread Weiny, Ira
On 4/16/2015 11:58 AM, Jason Gunthorpe wrote: It also looks like hardwired 1 won't work on switch ports, so it is no-go. AFAIK enhanced switch port 0 is not supported by CM/RDMA CM in the current code. There is no need for CM/RDMA CM on base switch port 0. I concur and I thought I

Re: [PATCH v3 07/28] IB/Verbs: Reform IB-ulp ipoib

2015-04-16 Thread Jason Gunthorpe
On Thu, Apr 16, 2015 at 10:02:46AM -0700, Roland Dreier wrote: On Thu, Apr 16, 2015 at 9:44 AM, Jason Gunthorpe jguntho...@obsidianresearch.com wrote: We can give client-add() callback a return value and make ib_register_device() return -ENOMEM when it failed, just wondering why we don't

Re: [PATCH v4 10/27] IB/Verbs: Reform cm related part in IB-core cma/ucm

2015-04-16 Thread Jason Gunthorpe
On Thu, Apr 16, 2015 at 01:38:07PM -0400, Hal Rosenstock wrote: On 4/16/2015 11:58 AM, Jason Gunthorpe wrote: It also looks like hardwired 1 won't work on switch ports, so it is no-go. AFAIK enhanced switch port 0 is not supported by CM/RDMA CM in the current code. There is no need for

Re: Stepping down as maintainer (was Re: [PATCH for-next 0/9] mlx4 changes in virtual GID management)

2015-04-16 Thread Doug Ledford
On Thu, 2015-04-16 at 15:37 -0600, Jason Gunthorpe wrote: On Fri, Apr 17, 2015 at 12:26:47AM +0300, Or Gerlitz wrote: On Thu, Apr 16, 2015 at 11:13 PM, Jason Gunthorpe jguntho...@obsidianresearch.com wrote: On Wed, Apr 15, 2015 at 08:39:13AM -0400, Doug Ledford wrote: Let’s take this

Re: Stepping down as maintainer (was Re: [PATCH for-next 0/9] mlx4 changes in virtual GID management)

2015-04-16 Thread Jason Gunthorpe
On Fri, Apr 17, 2015 at 12:26:47AM +0300, Or Gerlitz wrote: On Thu, Apr 16, 2015 at 11:13 PM, Jason Gunthorpe jguntho...@obsidianresearch.com wrote: On Wed, Apr 15, 2015 at 08:39:13AM -0400, Doug Ledford wrote: Let’s take this as a starting point. If there are other patches people think

Re: Stepping down as maintainer (was Re: [PATCH for-next 0/9] mlx4 changes in virtual GID management)

2015-04-16 Thread Jason Gunthorpe
On Wed, Apr 15, 2015 at 08:39:13AM -0400, Doug Ledford wrote: Let’s take this as a starting point. If there are other patches people think should make 4.1, please bring them to my attention and I’ll add them for review and possible addition to the list. git://github.com/dledford/linux.git

Re: Stepping down as maintainer (was Re: [PATCH for-next 0/9] mlx4 changes in virtual GID management)

2015-04-16 Thread Or Gerlitz
On Thu, Apr 16, 2015 at 11:13 PM, Jason Gunthorpe jguntho...@obsidianresearch.com wrote: On Wed, Apr 15, 2015 at 08:39:13AM -0400, Doug Ledford wrote: Let’s take this as a starting point. If there are other patches people think should make 4.1, please bring them to my attention and I’ll add

NFSoRDMA bi-weekly developers meeting minutes (4/16/15)

2015-04-16 Thread Shirley Ma
Attendees: Jeff Becker (NASA) Wendy Cheng (Intel) Chuck Lever (Oracle) Doug Ledford (RedHat) Shirley Ma (Oracle) Anna Schumaker (Net App) Steve Wise (OpenGridComputing, Chelsio) Today's meeting notes: NFSoRDMA server support: --- NFSoRDMA Server is still technology preview

RE: RE: [PATCH v3 for-next 01/33] IB/core: Add RoCE GID cache

2015-04-16 Thread Hefty, Sean
The RoCE Verbs interface references the HCA GID table in QPs and AHs, for all RoCE versions. The IBTA specifically does not define software interfaces. The concern here is the architecture and definition of the linux rdma software stack, not verbs, despite the fact that the layer is named

Re: [PATCH V1 net-next] IB/ipoib: Fix ndo_get_iflink

2015-04-16 Thread Or Gerlitz
On Thu, Apr 16, 2015, Yann Droneaud ydrone...@opteya.com wrote: Hi, Le jeudi 16 avril 2015 à 16:34 +0300, Erez Shitrit a écrit : Currently, iflink of the parent interface was always accessed, even when interface didn't have a parent and hence we crashed there. + since commit 5aa7add8f14b

RE: RE: [PATCH v3 for-next 01/33] IB/core: Add RoCE GID cache

2015-04-16 Thread Liran Liss
RoCE v2 is really Infiniband over UDP over IP. Why don't we just call it IBoUDP like it is? RoCEv2 is the name in the IBTA spec (Annex 17) We call RoCE IBoE in the kernel, because that's what it is. RoCE is an IBTA marketing name. Looking through the Annex, I don't see where

RE: RE: [PATCH v3 for-next 01/33] IB/core: Add RoCE GID cache

2015-04-16 Thread Liran Liss
The RoCE Verbs interface references the HCA GID table in QPs and AHs, for all RoCE versions. The IBTA specifically does not define software interfaces. The concern here is the architecture and definition of the linux rdma software stack, not verbs, despite the fact that the layer is

RE: [PATCH v3 27/28] IB/Verbs: Clean up rdma_ib_or_iboe()

2015-04-16 Thread Steve Wise
-Original Message- From: Jason Gunthorpe [mailto:jguntho...@obsidianresearch.com] Sent: Thursday, April 16, 2015 11:43 AM To: Michael Wang Cc: Roland Dreier; Sean Hefty; Hal Rosenstock; linux-rdma@vger.kernel.org; linux-ker...@vger.kernel.org; Tom Tucker; Steve Wise; Hoang-Nam