On Mon, Apr 2, 2012 at 8:42 PM, Roland Dreier rol...@kernel.org wrote:
On Mon, Apr 2, 2012 at 7:45 AM, Or Gerlitz ogerl...@mellanox.com wrote:
switch (attr.active_speed) {
case IB_SPEED_SDR:
+ speed = SDR;
rate = 25;
break
On Mon, Apr 2, 2012 at 8:42 PM, Roland Dreier rol...@kernel.org wrote:
On Mon, Apr 2, 2012 at 7:45 AM, Or Gerlitz ogerl...@mellanox.com wrote:
switch (attr.active_speed) {
case IB_SPEED_SDR:
+ speed = SDR;
rate = 25;
break
On Mon, Apr 2, 2012 at 10:35 PM, Roland Dreier rol...@kernel.org wrote:
I think I'd rather just add this, to get back closer to the original
behavior even for non-fixed drivers (but I'll still merge the mlx4
patch, since that makes sense too).
okay, makes sense
--
To unsubscribe from this
On 4/2/2012 10:27 PM, Roland Dreier wrote:
This looks reasonable, applied
Thanks, so we're in a situation where there are / will be fixes for 3.4
and new code for 3.5 is coming, how about that suggestion I made lately
- for-next to contain code for the next kernel (e.g 3.5 at this point)
previously allocated.
Acked-by: Or Gerlitz ogerl...@mellanox.com
Roland, could you push that?
Or.
--
To unsubscribe from this list: send the line unsubscribe linux-rdma in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On 4/16/2012 8:05 AM, Roland Dreier wrote:
thanks, applied (looks like a 3.4 regression so I'll send the fix to Linus with
my next batch)
not sure to follow on the next branch part, it is a regression
introduced in 3.4-rc1 so it should be in your fixes branch
and submitted within a batch
On 2/2/2012 3:21 AM, David Miller wrote:
From: Roland Dreierrol...@kernel.org
I'm happy to do it but I'm still not quite sure I understand what the
end state is. Is it just a matter of peeking into the skb contents
to get at the daddr, looking up the neigh based on that and then
continuing to
From: Jack Morgenstein ja...@dev.mellanox.co.il
Commit 0b307043049f34211affdde46f82e7abbe8c4590 IB/mad: Return
error response for unsupported MADs introduced two problems:
1. If the unsupported MAD is a Directed-route get/set, it fails
to set the D bit in the response MAD status field. This
On 4/25/2012 2:13 AM, Roland Dreier wrote:
Thanks, applied as two patches, since AFAICT the two fixes are not
tied to each other.
yep, makes sense, so what's in CT - is it consider that?
Or.
--
To unsubscribe from this list: send the line unsubscribe linux-rdma in
the body of a message to
I got this today with the IB git for-next, with some other patches applied
(the ones I will send next, but they they don't seem to be related?), and
libibverbs/mlx4 from their git heads.
Or.
==
[ INFO: possible circular locking dependency
ib_open_qp() to share XRC TGT QPs.
Signed-off-by: Or Gerlitz ogerl...@mellanox.com
---
drivers/infiniband/core/verbs.c | 14 --
include/rdma/ib_verbs.h |2 +-
2 files changed, 13 insertions(+), 3 deletions(-)
diff --git a/drivers/infiniband/core/verbs.c b/drivers/infiniband
) available
for ULPs
Jack Morgenstein (1):
net/mlx4_core: change bitmap allocator to work in round-robin fashion
Or Gerlitz (2):
IB/iser: Fix buggy error flow in iser ep connection establishment
IB/core: enhance the qp use counter to track multicast attach/detach
Oren Duer (1):
IB/mlx4
endpoint object that caused kernel NULL pointer dereference.
Fix that by plugging correctly to the IB conn reference counting.
Signed-off-by: Or Gerlitz ogerl...@mellanox.com
---
drivers/infiniband/ulp/iser/iscsi_iser.c |5 ++---
drivers/infiniband/ulp/iser/iser_verbs.c |3 ++-
2 files changed
From: Jack Morgenstein ja...@dev.mellanox.co.il
Under most circumstances, the bitmap allocator does not allocate the
same full 24-bit qp-number immediately after a qp is destroyed.
This operates by using the upper bits of a 24-bit qp number, beyond the
number of QPs that are actually available
From: Shlomo Pongratz shlo...@mellanox.com
This patch adds a 64 bits flags2 features variable to export further features
of the hardware. The original flags field, tracks feature whose support bits
are
advertized by the firmware in offsets 0x40 and 0x44 of the query device
capabilities command,
From: Shlomo Pongratz shlo...@mellanox.com
Signed-off-by: Shlomo Pongratz shlo...@mellanox.com
---
drivers/infiniband/hw/mlx4/cq.c | 10 +-
drivers/infiniband/hw/mlx4/main.c | 12 ++--
drivers/infiniband/hw/mlx4/mr.c |2 +-
drivers/infiniband/hw/mlx4/qp.c | 12
From: Shlomo Pongratz shlo...@mellanox.com
Enable IB ULPs to use a larger portion of the device EQs (which map
to IRQs). The mlx4_ib driver follows the mlx4_core framework of the
EQs to be divided among the device ports. In this scheme, for each IB
port, the number of allocated EQs follows the
used for the connection.
Signed-off-by: Oren Duer o...@mellanox.co.il
Signed-off-by: Or Gerlitz ogerl...@mellanox.com
---
drivers/infiniband/hw/mlx4/qp.c |6 +++---
include/linux/mlx4/qp.h |3 ++-
2 files changed, 5 insertions(+), 4 deletions(-)
diff --git a/drivers/infiniband/hw
On Mon, Apr 30, 2012 at 11:46 PM, Roland Dreier rol...@kernel.org wrote:
I'm tempted to send a lmgtfy.com link, but afaict == as far as I can tell.
Oh, sure, will go there next time... thanks for the quick response on
the uverbs lockdep thing, any chance you'll be able to look soon on
the batch
On Thu, May 3, 2012 at 8:55 PM, Roland Dreier rol...@kernel.org wrote:
thanks, applied.
Hi,
I don't see this one nor the patches to the Chelsio driver in your
kernel.org tree, for-next branch, did you push it?
Or.
--
To unsubscribe from this list: send the line unsubscribe linux-rdma in
the
From: Shlomo Pongratz shlo...@mellanox.com
Depending on the mlx4 device capabilities, support the RSS IB device
capability, using Topelitz or XOR hash functions. Support creating QP
groups where all RX and TX QPs have contiguous QP numbers.
Signed-off-by: Shlomo Pongratz shlo...@mellanox.com
---
From: Shlomo Pongratz shlo...@mellanox.com
RSS (Receive Side Scaling) TSS (Transmit Side Scaling, better known as
MQ/Multi-Queue) are common networking techniques which allow to use
contemporary NICs that support multiple receive and transmit descriptor
queues (multi-queue), see also
From: Shlomo Pongratz shlo...@mellanox.com
This patch add RSS (Receive Side Scaling) and TSS (multi-queue transmit)
support for IPoIB. The RSS and TSS implementation utilizes the new QP
groups concept.
The number of RSS and TSS rings is a function of the number of cores,
and the low level driver
On 5/8/2012 9:48 PM, Roland Dreier wrote:
thanks, applied.
Hi Roland,
I don't see this patch neither the other two you accepted last night in
your kernel.org tree
for-next branch, maybe this has something to do with the rebase to -rc6
you made?
Or.
--
To unsubscribe from this list: send
On 5/8/2012 9:48 PM, Roland Dreier wrote:
thanks, applied.
Hi Roland,
I don't see this patch nor the other two you accepted last night in your
kernel.org tree
for-next branch, maybe this has something to do with the rebase to -rc6
you made?
Or.
--
To unsubscribe from this list: send the
On 5/8/2012 7:22 PM, Or Gerlitz wrote:
--- a/drivers/infiniband/hw/ehca/ehca_qp.c
+++ b/drivers/infiniband/hw/ehca/ehca_qp.c
@@ -464,6 +464,9 @@ static struct ehca_qp *internal_create_qp(
int is_llqp = 0, has_srq = 0, is_user = 0;
int qp_type, max_send_sge, max_recv_sge, ret
From: Shlomo Pongratz shlo...@mellanox.com
RSS (Receive Side Scaling) TSS (Transmit Side Scaling, better known as
MQ/Multi-Queue) are common networking techniques which allow to use
contemporary NICs that support multiple receive and transmit descriptor
queues (multi-queue), see also
IB_SA_COMP_MASK macro
IB/mlx4: bug fix for mlx4_ib_add error flow
Or Gerlitz (1):
net/mlx4: Adjust initial value of vl_cap in mlx4_SET_PORT
Yishai Hadas (1):
IB/core: fix mismatch between locked and pinned pages
drivers/infiniband/core/umem.c |2 +-
drivers/infiniband/hw/mlx4/cq.c
From: Jack Morgenstein ja...@dev.mellanox.co.il
Under most circumstances, the bitmap allocator does not allocate the
same full 24-bit qp-number immediately after a qp is destroyed.
This operates by using the upper bits of a 24-bit qp number, beyond the
number of QPs that are actually available
From: Jack Morgenstein ja...@dev.mellanox.co.il
It needs parentheses around the argument, so that it can
be used with complex arguments (e.g., n+5 say).
Signed-off-by: Jack Morgenstein ja...@dev.mellanox.co.il
---
include/rdma/ib_mad.h |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
From: Yishai Hadas yish...@mellanox.com
Commit bc3e53f68 mm: distinguish between mlocked and pinned pages
introduced a separate counter for pinned pages and used it over
the IB stack. Specifically, in ib_umem_get the pinned counter
is incremented, but ib_umem_release wrongly decrements the
locked
RSS (Receive Side Scaling) TSS (Transmit Side Scaling, better known as
MQ/Multi-Queue) are common networking techniques which allow to use
contemporary NICs that support multiple receive and transmit descriptor
queues (multi-queue), see also Documentation/networking/scaling.txt
This patch
sebastien dugue sebastien.du...@bull.net wrote:
@@ -172,6 +172,7 @@ struct ib_cq *mlx4_ib_create_cq(struct ib_device
*ibdev, int entries, int vector
struct mlx4_uar *uar;
int err;
+ entries = roundup_pow_of_two(entries + 1);
if (entries 1 || entries
On 5/11/2012 9:38 PM, Roland Dreier wrote:
applied, with Christoph's reviewed-by and a Cc: stable tag. Thanks everyone.
Hi Roland,
Okay, thanks, I see that you still haven't pushed these updates to the
infiniband tree, will be helpful if you can do that soon, such that
we'll be able to
On Tue, May 15, 2012 at 10:16 PM, Alexey Shvetsov ale...@gentoo.org wrote:
Is it normal that kenrnel reports 8.5G speed on old SDR mellanox HBA?
yes, there used to be a bug that could cause that, what kernel
produced this output?
c-2-1 1 # ibstatus
Infiniband device 'mthca0' port 1 status:
On 5/15/2012 10:31 PM, Alexey Shvetsov wrote:
Affected kernel version 3.3
yep, there's a bug in the IB core sysfs code which is fixed in 3.4 that
can cause that 8.5Gbs to be displayed...
The bug was introduced in 3.2 or 3.3 and fixed in 3.4, see commit
On 5/8/2012 7:22 PM, Or Gerlitz wrote:
From: Shlomo Pongratzshlo...@mellanox.com
RSS (Receive Side Scaling) TSS (Transmit Side Scaling, better known as
MQ/Multi-Queue) are common networking techniques which allow to use
contemporary NICs that support multiple receive and transmit descriptor
On 5/16/2012 11:42 PM, Or Gerlitz wrote:
Also, another long pending patch is the one to allow for multiple
IPoIB childs @ http://marc.info/?l=linux-rdmam=132630202116857w=2 ,
which will be of use by the eIPoIB - the Ethernet IPoIB driver which
was presented in the last OFA conference
Hi everybody,
FWIW, word has reached me that OFA decided lately to have their site is
free for all without subscription! I find the sessions held on the
Sonoma/Monterey conferences over the years to be very helpful, there's
even a search engine, well done, Ken, many thanks!
go
On 5/19/2012 3:40 AM, Roland Dreier wrote:
+#define CX3_PPF_DEV_ID 0x1003
+static int vl_cap_start(struct mlx4_dev *dev)
+{
+ /* for non CX3 devices, start with 4 VLs to avoid errors in syslog */
+ if (dev-pdev-device != CX3_PPF_DEV_ID)
+ return 4;
+ return 8;
+}
Signed-off-by: Or Gerlitz ogerl...@mellanox.com
---
drivers/net/ethernet/mellanox/mlx4/port.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/mellanox/mlx4/port.c
b/drivers/net/ethernet/mellanox/mlx4/port.c
index 1fe2c7a..a8fb529 100644
...@dev.mellanox.co.il
Signed-off-by: Sagi Grimberg sa...@mellanox.co.il
Signed-off-by: Or Gerlitz ogerl...@mellanox.com
---
src/mlx4.c | 13 +
src/mlx4.h |3 +++
2 files changed, 16 insertions(+), 0 deletions(-)
diff --git a/src/mlx4.c b/src/mlx4.c
index 8cf249a..4989c46 100644
On Thu, May 24, 2012 at 6:42 PM, Hefty, Sean sean.he...@intel.com wrote:
I believe that I was *just* hitting into this bug.
Good, so we came just in time.
I don't understand the part about breaking the ABI. Why wouldn't you just
return the correct values from the kernel? Are the values
On 5/25/2012 6:04 AM, Or Gerlitz wrote:
I don't understand the part about breaking the ABI. Why wouldn't you just
return the correct values from the kernel? Are the values being returned now
usable?
Addressing the 2nd part of your question, the patch makes sure that
the values returned now
On 5/24/2012 5:30 PM, Or Gerlitz wrote:
The patch makes sure that older guest drivers who follows the
QUERY_DEV_FUNC command (e.g as done in mlx4_core of Linux 3.3/3.4)
will notice that they need an update to be able to work with the
PPF since the returned pf_context_behaviour will not be zero
On Tue, May 29, 2012 at 8:45 PM, Roland Dreier rol...@kernel.org wrote:
In general I'm kind of sad about the way the hardware works: having
to choose the incompatible 64-byte CQE format globally at startup
means we're kind of stuck breaking userspace in some cases.
yes, indeed, that's the way
On 6/4/2012 9:05 AM, Roland Dreier wrote:
thanks, applied
Happy to hear that! any questions/clarifications you still need on patch #2?
Or.
--
To unsubscribe from this list: send the line unsubscribe linux-rdma in
the body of a message to majord...@vger.kernel.org
More majordomo info at
Signed-off-by: Or Gerlitz ogerl...@mellanox.com
---
drivers/infiniband/hw/mlx4/main.c|5 +
drivers/infiniband/hw/mlx4/mlx4_ib.h | 13 ++
drivers/infiniband/hw/mlx4/qp.c | 342 -
3 files changed, 349 insertions(+), 11 deletions(-)
diff --git a/drivers
Pongratz shlo...@mellanox.com
Signed-off-by: Or Gerlitz ogerl...@mellanox.com
---
drivers/infiniband/core/uverbs_cmd.c |1 +
drivers/infiniband/core/verbs.c |3 +++
drivers/infiniband/hw/amso1100/c2_provider.c |3 +++
drivers/infiniband/hw/cxgb3/iwch_provider.c |2
Signed-off-by: Or Gerlitz ogerl...@mellanox.com
---
drivers/infiniband/ulp/ipoib/ipoib.h | 19 +-
drivers/infiniband/ulp/ipoib/ipoib_cm.c|5 -
drivers/infiniband/ulp/ipoib/ipoib_ib.c| 10 +
drivers/infiniband/ulp/ipoib/ipoib_main.c | 144 ++-
drivers/infiniband/ulp/ipoib
From: Shlomo Pongratz shlo...@mellanox.com
Hi Roland, Sean, everyone!
With 3.5-rc1 being out by now, here's V1 of the TSS/RSS patch series,
basically its very similar to V0, with taking out what was already
accepted and few minor fixes for issues we stepped over testing since
the V0 submission.
On Mon, Jun 4, 2012 at 8:06 PM, Hefty, Sean sean.he...@intel.com wrote:
Still, the 1st and most thing to handle here is feedback on the QP
groups concept suggested by this patch set to support TSS/RSS over
verbs. The plan is for this concept to (with little help from a
framework for verbs
On 6/12/2012 10:00 AM, Roland Dreier wrote:
Jack Morgensteinja...@dev.mellanox.co.il wrote:
several of the patches have notations indicating things that will be fixed in V1
Not sure what you want me to do with this -- it seems you yourself are saying
this series is not ready to merge yet?
Or Gerlitz or.gerl...@gmail.com wrote:
Hefty, Sean sean.he...@intel.com wrote:
Conceptually, it seems that there should be more alignment with XRC, which
also
ends up with an associated group of QPs.
Yep, sure, if its possible to align/squeez/unite these QP groups into the XRC
interfaces
On 6/14/2012 4:21 PM, Yann Droneaud wrote:
How will interact vHCA/HCA regarding Automatic Path Migration (APM)
and IPoIB bonding with fail-over (HA), with RDMA_CM and IP usages in
mind ?
work on vHCA the same way they do on HCA, please let me know if you have
anything more special to realize
On 7/2/2012 2:44 PM, Klaus Wacker wrote:
[...] So whats the nature of the returned DMA address of ib_dma_map_single and
can we
assume that it is the same value on different devices on one system?
Currently, over all IB drivers/devices except for ipath and qib,
ib_dma_map_single is just plain
Let me stress this once again...
1.) Is it possible/allowed to call ib_dma_map_single() on Linux, same
buffer address, size and dma_data direction, for two different ib devices?
For the data transmission we will have controls in place that not both
devices write at the same time into that
ibnetdiscover shows FDR10 speeds as QDR due to bug in setting
default parameters
How old is this bug?
Or.
--
To unsubscribe from this list: send the line unsubscribe linux-rdma in
the body of a message to majord...@vger.kernel.org
More majordomo info at
On Fri, Jul 6, 2012 at 3:09 AM, Roland Dreier rol...@kernel.org wrote:
On Tue, Jun 19, 2012 at 1:21 AM, Jack Morgenstein
ja...@dev.mellanox.co.il wrote:
1. Slave may not set the IS_SM capability for the port.
So I can't run a SM in a guest?
nope, guests are untrusted and we don't let them
On Fri, Jul 6, 2012 at 2:26 AM, Roland Dreier rol...@kernel.org wrote:
Part of my problem is I don't see anywhere that
MLX4_RESERVED_QKEY_MASK is actually used in this patch...
see in patch 13/29
@ -1209,8 +1375,24 @@ static int __mlx4_ib_modify_qp(struct ib_qp *ibqp,
if (attr_mask
On Fri, Jul 6, 2012 at 3:09 AM, Roland Dreier rol...@kernel.org wrote:
2. No DEV_MGR in multifunc mode.
I can't run an SRP target in a guest?
To be precise, you can run the target, but you would need to discover it not
through the regular mechnism which makes use of the DM bit of the port.
On 7/6/2012 2:26 AM, Roland Dreier wrote:
Jack Morgenstein ja...@dev.mellanox.co.il wrote:
For security reasons (i.e., to prevent guests from sending MADs to tunnel QPs
belonging to other guests), each proxy-tunnel qp pair is assigned a unique,
reserved, qkey. These qkeys are available only
On Fri, Jul 6, 2012 at 6:09 AM, Roland Dreier rol...@kernel.org wrote:
So I can't run a SM in a guest?
[...]
I can't run an SRP target in a guest?
Seems like an unfortunate set of limitations, especially if I want a
completely virtualized environment. In my case I might want to
test the
and deletes every ipoib_neigh instance that was idle for at least 60
seconds. The deletion is safe since the ipoib_neigh instances are protected
using RCU and reference count mechanisms.
Signed-off-by: Shlomo Pongratz shlo...@mellanox.com
Signed-off-by: Or Gerlitz ogerl...@mellanox.com
---
The patch
On 7/10/2012 7:57 PM, Roland Dreier wrote:
thanks, applied
thanks, I see now that you've picked also patch #8, so we're making
progress...
any further thoughts/feedback following the responses I provided on your
questions around DM and SM?
Or.
--
To unsubscribe from this list: send the line
Hi Roland,
Here's a batch of small fixes from Dotan for 3.6
Or.
Dotan Barak (6):
IB/mthca: Events received for non-existent QPs should generate a warning
IB/mthca: Fill in the attribute sq_sig_type value in query QP
IB/mlx4: Fill the masked_atomic_cap attribute in query device
From: Dotan Barak dot...@dev.mellanox.co.il
The query QP code was didn't fill that attribute, do that.
Signed-off-by: Dotan Barak dot...@dev.mellanox.co.il
Reviewed-by: Jack Morgenstein ja...@dev.mellanox.co.il
Signed-off-by: Or Gerlitz ogerl...@mellanox.com
---
drivers/infiniband/hw/mthca
From: Dotan Barak dot...@dev.mellanox.co.il
In mlx4_init_icm_table, free the allocated table if we failed to allocate
memory to its entries.
Signed-off-by: Dotan Barak dot...@dev.mellanox.co.il
Reviewed-by: Yevgeny Petrilin yevge...@mellanox.co.il
Signed-off-by: Or Gerlitz ogerl...@mellanox.com
From: Dotan Barak dot...@dev.mellanox.co.il
Clean the idr as part of the error flow since it is a resource too.
Signed-off-by: Dotan Barak dot...@dev.mellanox.co.il
Reviewed-by: Sean Hefty sean.he...@intel.com
Signed-off-by: Or Gerlitz ogerl...@mellanox.com
---
drivers/infiniband/core/cm.c
From: Dotan Barak dot...@dev.mellanox.co.il
Spotted four duplicate declarations in icm.h, remove them.
Signed-off-by: Dotan Barak dot...@dev.mellanox.co.il
Signed-off-by: Or Gerlitz ogerl...@dev.mellanox.com
---
drivers/net/ethernet/mellanox/mlx4/icm.h |6 --
1 files changed, 0
...@mellanox.com
Signed-off-by: Or Gerlitz ogerl...@dev.mellanox.com
---
drivers/infiniband/hw/mlx4/main.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/infiniband/hw/mlx4/main.c
b/drivers/infiniband/hw/mlx4/main.c
index 4f230c2..5f50d4f 100644
--- a/drivers/infiniband
From: Dotan Barak dot...@dev.mellanox.co.il
Events received for non-existent QPs should generate a warning along
with the event type which was received.
Signed-off-by: Dotan Barak dot...@dev.mellanox.co.il
Reviewed-by: Jack Morgenstein ja...@dev.mellanox.co.il
Signed-off-by: Or Gerlitz ogerl
Hi Roland,
Here's a batch of small fixes from Dotan for 3.6
Please ignore the prev posting, it had wrong sign-off address for me.
Or.
Dotan Barak (6):
IB/mthca: Events received for non-existent QPs should generate a warning
IB/mthca: Fill in the attribute sq_sig_type value in query QP
From: Dotan Barak dot...@dev.mellanox.co.il
Events received for non-existent QPs should generate a warning along
with the event type which was received.
Signed-off-by: Dotan Barak dot...@dev.mellanox.co.il
Reviewed-by: Jack Morgenstein ja...@dev.mellanox.co.il
Signed-off-by: Or Gerlitz ogerl
From: Dotan Barak dot...@dev.mellanox.co.il
The query QP code was didn't fill that attribute, do that.
Signed-off-by: Dotan Barak dot...@dev.mellanox.co.il
Reviewed-by: Jack Morgenstein ja...@dev.mellanox.co.il
Signed-off-by: Or Gerlitz ogerl...@mellanox.com
---
drivers/infiniband/hw/mthca
From: Dotan Barak dot...@dev.mellanox.co.il
In mlx4_init_icm_table, free the allocated table if we failed to allocate
memory to its entries.
Signed-off-by: Dotan Barak dot...@dev.mellanox.co.il
Reviewed-by: Yevgeny Petrilin yevge...@mellanox.co.il
Signed-off-by: Or Gerlitz ogerl...@mellanox.com
From: Dotan Barak dot...@dev.mellanox.co.il
Spotted four duplicate declarations in icm.h, remove them.
Signed-off-by: Dotan Barak dot...@dev.mellanox.co.il
Signed-off-by: Or Gerlitz ogerl...@mellanox.com
---
drivers/net/ethernet/mellanox/mlx4/icm.h |6 --
1 files changed, 0 insertions
From: Dotan Barak dot...@dev.mellanox.co.il
Clean the idr as part of the error flow since it is a resource too.
Signed-off-by: Dotan Barak dot...@dev.mellanox.co.il
Reviewed-by: Sean Hefty sean.he...@intel.com
Signed-off-by: Or Gerlitz ogerl...@mellanox.com
---
drivers/infiniband/core/cm.c
...@mellanox.com
Signed-off-by: Or Gerlitz ogerl...@mellanox.com
---
drivers/infiniband/hw/mlx4/main.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/infiniband/hw/mlx4/main.c
b/drivers/infiniband/hw/mlx4/main.c
index 4f230c2..5f50d4f 100644
--- a/drivers/infiniband/hw
On 7/11/2012 6:40 PM, Roland Dreier wrote:
On Wed, Jul 11, 2012 at 8:33 AM, Or Gerlitz ogerl...@mellanox.com wrote:
- mthca_warn(dev, Async event for bogus QP %08x\n, qpn);
+ mthca_warn(dev, Async event %d for bogus QP %08x\n,
+ (int
any reason not to remove it all together?
Or.
--
To unsubscribe from this list: send the line unsubscribe linux-rdma in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On 7/10/2012 1:01 PM, Or Gerlitz wrote:
[...] This patch aims to solve the race conditions found in the IPoIB driver.
The patch breaks the connection between the core networking neighbour structure
and the ipoib_neigh structure. Except for avoiding the race, it allows to in
under a setup where
On Fri, Jul 13, 2012 at 3:58 AM, David Miller da...@davemloft.net wrote:
You don't need a R/W lock for that, we have RCU hash tables that get
resized dynamically and the lookup still only needs pure RCU protection.
Hi Dave,
Thanks for the feedback, Shlomo will look into this and if needed,
On Wed, Jul 11, 2012 at 9:37 PM, Roland Dreier rol...@kernel.org wrote:
thanks, applied
cool, so we have now 8 out of 29 merged... any info from our side
needed to continue with the review/acceptance process?
Or.
--
To unsubscribe from this list: send the line unsubscribe linux-rdma in
the body
On 7/13/2012 3:58 AM, David Miller wrote:
From: Shlomo Pongratz shlo...@mellanox.com
Date: Thu, 12 Jul 2012 20:13:28 +
The RCU and reference count protect the individual entries in the hash. The R/W
lock protects the hash table itself. e.g. deleting the hash table itself, or in
the
since the ipoib_neigh instances are protected
using RCU and reference count mechanisms.
Signed-off-by: Shlomo Pongratz shlo...@mellanox.com
Signed-off-by: Or Gerlitz ogerl...@mellanox.com
---
drivers/infiniband/ulp/ipoib/ipoib.h | 59 ++-
drivers/infiniband/ulp/ipoib/ipoib_cm.c
It seems that for some reason the cover-letter wasn't sent properly,
here's listing of the changes:
changes from V0:
- following feedback from Mike and Dave, changed the ipoib_neigh hash table
to allow for lock-free read side, the model follows the RCU based
implementation
in
changes from V0:
- following feedback from Mike and Dave, changed the ipoib_neigh hash table
to allow for lock-free read side, the model follows the RCU based
implementation
in net/core/neighbour.c
- since RCU hash table uses unidirectional collision list, now ipoib_neigh_free
needs to
Adding netdev, as of the high relevancy, see V0 @
http://marc.info/?l=linux-rdmam=134191474831867w=2
changes from V0:
- following feedback from Mike and Dave, changed the ipoib_neigh hash table
to allow for lock-free read side, the model follows the RCU based
implementation
in
since the ipoib_neigh instances are protected
using RCU and reference count mechanisms.
Signed-off-by: Shlomo Pongratz shlo...@mellanox.com
Signed-off-by: Or Gerlitz ogerl...@mellanox.com
---
drivers/infiniband/ulp/ipoib/ipoib.h | 59 ++-
drivers/infiniband/ulp/ipoib/ipoib_cm.c
On 7/19/2012 6:24 PM, Christoph Lameter wrote:
On Thu, 19 Jul 2012, Shlomo Pongartz wrote:
The garbage collection and stale times follow the default ipv4/6
neigh.default.gc_yyy
sysctl values, for example
net.ipv4.neigh.default.gc_interval = 30
net.ipv4.neigh.default.gc_stale_time = 60
If
On Thu, Jul 19, 2012 at 9:26 PM, Roland Dreier rol...@purestorage.com wrote:
I think this is pushing the module parameter facility way past the
breaking point of usability. We really need to come up with a better
way to get complex structured config info like this into the drive
IB's netlink
On Thu, Jul 19, 2012 at 4:18 PM, Or Gerlitz ogerl...@mellanox.com wrote:
From: Shlomo Pongratz shlo...@mellanox.com
Dave Miller da...@davemloft.net provided a detailed description of why the
way IPoIB is using neighbours for its own ipoib_neigh struct is buggy:
[...]
This patch aims to solve
On Fri, Jul 20, 2012 at 2:40 PM, Marciniszyn, Mike mike.marcinis...@intel.com
If you could give me some code to look at?
include/rdma/rdma_netlink.h
drivers/infiniband/core/netlink.c
--
To unsubscribe from this list: send the line unsubscribe linux-rdma in
the body of a message to
On 7/19/2012 8:08 PM, David Miller wrote:
These numbers come from the IPV6 Neighbour Discovery RFCs. IPV4 replicates the
Neighbour Unreachability Detection schemes of IPV6 in pretty much it's
entirety, and therefore takes on the same timeout et al. parameters.
OK, got it. At this point, I
On 7/19/2012 4:04 PM, Mike Marciniszyn wrote:
Added a congestion control agent in the driver that handles
gets and sets from the congestion control manager in the
fabric for the Performance Scale Messagin (PSM) library.
Hi Mike,
Nice doing.
Can you elaborate a little on the role/usage of the
On 20/07/2012 18:49, Or Gerlitz wrote:
On Thu, Jul 19, 2012 at 4:18 PM, Or Gerlitzogerl...@mellanox.com wrote:
From: Shlomo Pongratzshlo...@mellanox.com
Dave Millerda...@davemloft.net provided a detailed description of why the
way IPoIB is using neighbours for its own ipoib_neigh struct
On Mon, Jul 23, 2012 at 8:17 PM, Eric Dumazet eric.duma...@gmail.com wrote:
I have no idea of what you are talking about, I have not the patch or a
copy of it ;)
http://marc.info/?t=13427149132r=1w=2
http://marc.info/?t=13427149135r=1w=2
--
To unsubscribe from this list: send the line
changes from V1:
- applied feeback from Dave on hash usage and identation
- applied feedback from Christoph, use values fom the exported arp_tbl
for the hash table size and the frequency of garbage collection
changes from V0:
- following feedback from Mike and Dave, changed the ipoib_neigh
...@mellanox.com
Signed-off-by: Or Gerlitz ogerl...@mellanox.com
---
drivers/infiniband/ulp/ipoib/ipoib.h | 54 ++-
drivers/infiniband/ulp/ipoib/ipoib_cm.c| 16 +-
drivers/infiniband/ulp/ipoib/ipoib_main.c | 641 +--
drivers/infiniband/ulp/ipoib/ipoib_multicast.c
501 - 600 of 2157 matches
Mail list logo
