[PATCH] ARM: S5P: Remove the unused clk_arm clock from plat-s5p

2010-09-28 Thread Kukjin Kim
From: Thomas Abraham thomas...@samsung.com All the S5P series SoCs use the 'struct clksrc_clk' type to represent the armclk. So the clk_arm clock instance available in the plat-s5p clock code is not used in any of the S5P series SoCs. This patch removes the unused clk_arm instance from plat-s5p

Re: [PATCH] ARM: S5PV210: Add Torbreck board support

2010-09-28 Thread Kyungmin Park
On Tue, Sep 28, 2010 at 2:55 PM, Kukjin Kim kgene@samsung.com wrote: 최규호 wrote: Hi, Welcome to Linux mainline ;-) I have some comments about your patches. Firstly could you please use English character in the representing name in e-mail client not Korean character :-) And make sure

RE: [PATCHv2 7/7] ARM: S5PC110: add support for MMC regulators on Goni board

2010-09-28 Thread Kukjin Kim
Marek Szyprowski wrote: Add required platform definitions for MMC power regulators on Samsung Goni board. GPIO pin GONI_EXT_FLASH_EN has been transferred from machine startup code to fixed voltage regulator. Signed-off-by: Marek Szyprowski m.szyprow...@samsung.com Signed-off-by: Kyungmin

RE: [PATCHv2 2/7] ARM: S5PC110: fb setup for Goni - remove pixel clock

2010-09-28 Thread Kukjin Kim
Marek Szyprowski wrote: Since commit 67a38950f0917aecfe1a3e46720d8bbb0020 there is no need to set pixel clock for the s3c-fb driver's window information. The correct pixel clock value can be automatically calculated from the other screen parameters. This patch removes the redundant pixel

RE: [PATCHv2 3/7] ARM: S5PC110: add support for S6E63M0 LCD controller on Goni board

2010-09-28 Thread Kukjin Kim
Marek Szyprowski wrote: Add required platform definitions for S6E63M0 LCD controller on Samsung Goni board. Signed-off-by: Marek Szyprowski m.szyprow...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- arch/arm/mach-s5pv210/mach-goni.c | 71

RE: [PATCHv2 4/7] ARM: S5PC110: Add si470x radio device to the GONI board

2010-09-28 Thread Kukjin Kim
Marek Szyprowski wrote: Add required platform definitions for si470x radio device on Samsung Goni board. Signed-off-by: Joonyoung Shim jy0922.s...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com Signed-off-by: Marek Szyprowski m.szyprow...@samsung.com ---

RE: [PATCHv2 5/7] ARM: S5PV210: Enable USB HSOTG gadget build

2010-09-28 Thread Kukjin Kim
Marek wrote: Add the necessary definitions and mapping information to enable the s3c-hsotg gadget to build. Signed-off-by: Marek Szyprowski m.szyprow...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com s5pv210 otg Maybe miss typing? ;-) ---

RE: [PATCHv2 6/7] ARM: S5PC110: add support for otg usb gadget on Goni board

2010-09-28 Thread Kukjin Kim
Marek Szyprowski wrote: Add required platform definitions for s3c-hsotg driver to enable usb gadget support on Samsung Goni board. Signed-off-by: Marek Szyprowski m.szyprow...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- arch/arm/mach-s5pv210/Kconfig |1

RE: [PATCH v3] regulators: add support max8952 regulator

2010-09-28 Thread Kukjin Kim
Kukjin Kim wrote: Kyungmin Park wrote: Do you check the DVS feature? It can support the DVS by GPIOs and platform can set the each voltages at each mode. Ok...I agree about the feature's necessity that you said. However, we don't need separate driver which has same/similar

Re: [PATCH v3] regulators: add support max8952 regulator

2010-09-28 Thread Kyungmin Park
On Tue, Sep 28, 2010 at 4:58 PM, Kukjin Kim kgene@samsung.com wrote: Kukjin Kim wrote: Kyungmin Park wrote: Do you check the DVS feature? It can support the DVS by GPIOs and platform can set the each voltages at each mode. Ok...I agree about the feature's necessity that you

Re: [PATCH] ARM: S5PV210: Add Torbreck board support

2010-09-28 Thread 최규호
On Tue, Sep 28, 2010 at 2:55 PM, Kukjin Kim kgene@samsung.com wrote: 최규호 wrote: Hi, Welcome to Linux mainline ;-) I have some comments about your patches. Firstly could you please use English character in the representing name in e-mail client not Korean character :-) And make sure

RE: [PATCHv2 3/7] ARM: S5PC110: add support for S6E63M0 LCD controller on Goni board

2010-09-28 Thread Marek Szyprowski
Hello, On Tuesday, September 28, 2010 9:39 AM wrote: Marek Szyprowski wrote: Add required platform definitions for S6E63M0 LCD controller on Samsung Goni board. Signed-off-by: Marek Szyprowski m.szyprow...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com ---

Re: [PATCH] ARM: S5PV310: Optimize interrupt source searching code

2010-09-28 Thread Sergei Shtylyov
Hello. On 28-09-2010 5:31, Kukjin Kim wrote: From: Changhwan Younchaos.y...@samsung.com It is reported by Junseok Jung that using clz instruction is better instead of using for-loop to find the interrupt source. This patch modifies interrupt source searching code using __fls(). The __fls()

RE: [PATCHv2 4/7] ARM: S5PC110: Add si470x radio device to the GONI board

2010-09-28 Thread Marek Szyprowski
Hello, On Tuesday, September 28, 2010 9:44 AM Kukjin Kim wrote: Marek Szyprowski wrote: Add required platform definitions for si470x radio device on Samsung Goni board. Signed-off-by: Joonyoung Shim jy0922.s...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com

[PATCH v3] ARM: S5PC110: add support for S6E63M0 LCD controller on Goni board

2010-09-28 Thread Marek Szyprowski
Add required platform definitions for S6E63M0 LCD controller on Samsung Goni board. Signed-off-by: Marek Szyprowski m.szyprow...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- Changes since v2: - removed defines for lcd pin names arch/arm/mach-s5pv210/mach-goni.c | 66

RE: [PATCH 1/6] ARM: Samsung: Add common s5p gpio interrupt support

2010-09-28 Thread Kukjin Kim
Marek Szyprowski wrote: This patch adds common code to enable support of gpio interrupts on s5p series. The total number of gpio pins is quite large on s5p series. Registering irq support for all of them would be a resource waste. Because of that the interrupt support for standard gpio

RE: [PATCH] ARM: S5PV310: Optimize interrupt source searching code

2010-09-28 Thread Kukjin Kim
Michal Nazarewicz wrote: Hi :-) On Tue, 28 Sep 2010 14:45:59 +0200, Sergei Shtylyov sshtyl...@mvista.com wrote: Hello. On 28-09-2010 5:31, Kukjin Kim wrote: From: Changhwan Younchaos.y...@samsung.com It is reported by Junseok Jung that using clz instruction is better instead

RE: [PATCH 1/6] ARM: Samsung: Add common s5p gpio interrupt support

2010-09-28 Thread Marek Szyprowski
Hello, On Tuesday, September 28, 2010 4:04 PM Kukjin Kim wrote: Marek Szyprowski wrote: This patch adds common code to enable support of gpio interrupts on s5p series. The total number of gpio pins is quite large on s5p series. Registering irq support for all of them would be a

[PATCH 1/6] ARM: Samsung: Add common s5p gpio interrupt support

2010-09-28 Thread Kyungmin Park
Hi Marek, On Sep 28, 2010 11:24 PM, Marek Szyprowski m.szyprow...@samsung.com wrote: Hello, On Tuesday, September 28, 2010 4:04 PM Kukjin Kim wrote: Marek Szyprowski wrote: This patch adds common code to enable support of gpio interrupts on s5p series. The total number of gpio pins

Re: [PATCH] ARM: S5PC100: Bug fix EPLL_CON MASK settings

2010-09-28 Thread Ben Dooks
On Tue, Sep 28, 2010 at 06:23:24PM +0900, Kukjin Kim wrote: From: Seungwhan Youn sw.y...@samsung.com This patch fixes EPLL_CON MASK settings which did not contain its shift values when set epll rate on S5PC100. Signed-off-by: Seungwhan Youn sw.y...@samsung.com Signed-off-by: Kukjin Kim

RE: [PATCH v2 1/3] ARM: S5PC110: Place the common SPARSEMEM at ARCH_S5PV210

2010-09-28 Thread Kukjin Kim
Kyungmin Park wrote: From: Kyungmin Park kyungmin.p...@samsung.com In case of s5pc110 CPU. It uses the SPARSEMEM as default memory configuration. So move to ARCH_S5PV210 config. Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- arch/arm/Kconfig |1 +

RE: [PATCH v2 2/3] ARM: S5PC210: Place the common SPARSEMEM at ARCH_S5PV310

2010-09-28 Thread Kukjin Kim
Kyungmin Park wrote: From: Kyungmin Park kyungmin.p...@samsung.com In case of s5pc210 CPU. It uses the SPARSEMEM as default memory configuration So move to ARCH_S5PV310 config. Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- arch/arm/Kconfig |1 +

RE: [PATCH v2 3/3] ARM: S5PC100/S5PC110/S5PC210: Selete PLAT_S5P at each ARCH_S5P series

2010-09-28 Thread Kukjin Kim
Kyungmin Park wrote: From: Kyungmin Park kyungmin.p...@samsung.com As it's default configuration for each SoC, Move to the machine config. Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- arch/arm/Kconfig |3 +++ arch/arm/mach-s5pc100/Kconfig |1 -

RE: [PATCHv2 4/7] ARM: S5PC110: Add si470x radio device to the GONI board

2010-09-28 Thread Marek Szyprowski
Hello, On Tuesday, September 28, 2010 4:05 PM Kukjin Kim wrote: On Tuesday, September 28, 2010 9:44 AM Kukjin Kim wrote: Marek Szyprowski wrote: Add required platform definitions for si470x radio device on Samsung Goni board. Signed-off-by: Joonyoung Shim