Re: [PATCH 4/4] usb: register usb port to usb_bus_type

2013-03-28 Thread Lan Tianyu
On 2013/3/29 6:56, Greg KH wrote: On Thu, Mar 28, 2013 at 03:16:08PM -0400, Alan Stern wrote: On Thu, 28 Mar 2013, Greg KH wrote: On Thu, Mar 28, 2013 at 02:44:01PM -0400, Alan Stern wrote: On Thu, 28 Mar 2013, Greg KH wrote: ls /sys/bus/usb/devices 1-0:1.02-0:1.0 port1-1 port1-1.

Re: [PATCH 2/4] usb: introduce usb force power off mechanism

2013-03-28 Thread Lan Tianyu
On 2013/3/29 6:43, Sarah Sharp wrote: On Thu, Mar 28, 2013 at 05:00:23PM -0400, Alan Stern wrote: On Thu, 28 Mar 2013, Sarah Sharp wrote: On Thu, Mar 28, 2013 at 01:11:02AM +0800, Lan Tianyu wrote: Some devices' firmware will be broken at some points. Power down and power on device can help d

Re: [PATCH 3/4] usb: Add usb port system pm support

2013-03-28 Thread Lan Tianyu
On 2013/3/29 4:47, Sarah Sharp wrote: On Thu, Mar 28, 2013 at 07:58:47AM +0800, Lan Tianyu wrote: On 2013/3/28 2:47, Alan Stern wrote: On Thu, 28 Mar 2013, Lan Tianyu wrote What happens if there's no device plugged in to the port, but the hub is enabled for remote wakeup? How will the hub be a

RE: usb video capture issue due to uvc_complete callback spends more time

2013-03-28 Thread B, Ravi
Hi, On Thu, Mar 28, 2013 at 9:27 PM, Felipe Balbi wrote: On Thu, Mar 28, 2013 at 03:23:46PM +0200, Felipe Balbi wrote: > Hi, > > On Thu, Mar 28, 2013 at 08:53:03PM +0800, Ming Lei wrote: > > On Thu, Mar 28, 2013 at 8:30 PM, B, Ravi wrote: > > > > > > For example, in one iteration I have observed

Re: [PATCH v3 2/7] USB: EHCI: make ehci-spear a separate driver

2013-03-28 Thread Viresh Kumar
On Fri, Mar 29, 2013 at 3:25 AM, Arnd Bergmann wrote: > From: Manjunath Goudar > > Separate the SPEAr host controller driver from ehci-hcd host code > so that it can be built as a separate driver module. > This work is part of enabling multi-platform kernels on ARM; > however, note that other cha

drivers/usb/musb/tusb6010.c:946:2: error: implicit declaration of function 'irq_set_irq_type'

2013-03-28 Thread Fengguang Wu
Greetings, These *huge number* of *long standing* errors make me wonder whether the below USB driver code should be disabled on s390? tree: git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux master head: 9064171268d838b8f283fe111ef086b9479d059a commit: dced35aeb0367dda2636ee9ee914bd

Re: Piggy-backing new hardware using old usb-serial

2013-03-28 Thread Xiaofan Chen
On Thu, Mar 28, 2013 at 10:58 PM, Wesley W. Terpstra wrote: > In case anyone else cares, I found some nice Dutch folks who resell PIDs > under their VID for cheap: > http://www.mcselec.com/index.php?page=shop.product_details&flypage=shop.flypage&product_id=92&option=com_phpshop&Itemid=1 > > I will

Re: [PATCH 2/2] xhci: Rename SEGMENT_SIZE and SEGMENT_SHIFT as the former is used in a.out.h

2013-03-28 Thread Sarah Sharp
On Thu, Mar 28, 2013 at 10:32:53PM +, David Howells wrote: > Sarah Sharp wrote: > > > I'm a little bit confused about your description for the second one. > > Did you need to change the #defines names because they could conflict > > with other drivers when the xHCI driver is built in? Or is

Re: [PATCH 4/4] usb: register usb port to usb_bus_type

2013-03-28 Thread Sarah Sharp
On Thu, Mar 28, 2013 at 03:56:17PM -0700, Greg KH wrote: > Has anyone tried this patch with libusb? At this point, I don't know if it has tested with libusb or even lsusb. I didn't see this patch until today, and I have not tested it on the Intel platform that actually implements the port power of

[PATCH v9 3/8] usb: chipidea: udc: read status of td only once in hardware_dequeue

2013-03-28 Thread Michael Grzeschik
This patch changes the read of the td status to one atomic operation to analyse coherent bits. Signed-off-by: Michael Grzeschik --- drivers/usb/chipidea/udc.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/usb/chipidea/udc.c b/drivers/usb/chipidea/udc.c index

[PATCH v9 2/8] usb: chipidea: udc: move ZLT flag change to ep_enable

2013-03-28 Thread Michael Grzeschik
Its not necessary and also not specified in the datasheet to change the ZLT flag before every ep_prime. This patch moves this to the ep_enable and applies it only for non configuration endpoints. Signed-off-by: Michael Grzeschik Reviewed-by: Felipe Balbi --- drivers/usb/chipidea/udc.c | 3 ++-

[PATCH v9 6/8] usb: chipidea: udc: move _ep_queue into an unlocked function

2013-03-28 Thread Michael Grzeschik
There is no need to call ep_queue unlocked inside the own driver. We move its functionionality into an unlocked version. This patch removes potential unlocked timeslots inside isr_setup_status_phase and isr_get_status_response, in which the lock got released just before acquired again inside usb_e

[PATCH v9 4/8] usb: chipidea: udc: rework ep_enable cap setting

2013-03-28 Thread Michael Grzeschik
This patch reworks the cap value from several read and write operations to one single operation. Signed-off-by: Michael Grzeschik Reviewed-by: Felipe Balbi --- drivers/usb/chipidea/udc.c | 17 - 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/drivers/usb/chipidea/u

[PATCH v9 5/8] usb: chipidea: udc: don't truncate requests to single tds

2013-03-28 Thread Michael Grzeschik
It is not safe to truncate requests to the maximum possible size the controller can handle with one td and to keep working. That patch fixes that with proper error handling instead. Reported-by: Felipe Balbi Signed-off-by: Michael Grzeschik --- drivers/usb/chipidea/udc.c | 4 ++-- 1 file change

[PATCH v9 0/8] usb: chipidea: udc: cleanups and fixes for v3.10

2013-03-28 Thread Michael Grzeschik
Hi, this series contains simples fixes and cleanup patches for the chipidea udc. It is based on Alexander Shishkins ci-for-greg. Regards, Michael Michael Grzeschik (8): usb: chipidea: udc: only clear active and halted bits in qhead usb: chipidea: udc: move ZLT flag change to ep_enable usb:

[PATCH v9 8/8] usb: chipidea: udc: add the define TD_PAGE_COUNT and fix all users

2013-03-28 Thread Michael Grzeschik
A static count of transfer descriptors was used everywhere in the driver with the fixed number 5. This patch adds a define, named TD_PAGE_COUNT, and replaces all users of this value. This way its possible to have only one parameter to change and limit the amount of buffer pointers per TD. Signed-o

[PATCH v9 7/8] usb: chipidea: udc: prepare qhead with dma_alloc_coherent

2013-03-28 Thread Michael Grzeschik
The prepared memory for the qhead needs to be contiguos and 2K aligned. We change the code from allocating extra buffer for every ep qhead to one big area. This patch lowers the amount of code to prepare the memory. Signed-off-by: Michael Grzeschik --- drivers/usb/chipidea/ci.h | 9 +++--

[PATCH v9 1/8] usb: chipidea: udc: only clear active and halted bits in qhead

2013-03-28 Thread Michael Grzeschik
The datasheet of the synopsys core describes only to overwrite the active and halted bits in the qhead before priming any endpoint. Signed-off-by: Michael Grzeschik Reviewed-by: Felipe Balbi --- drivers/usb/chipidea/udc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drive

Re: [PATCH 4/4] usb: register usb port to usb_bus_type

2013-03-28 Thread Greg KH
On Thu, Mar 28, 2013 at 03:16:08PM -0400, Alan Stern wrote: > On Thu, 28 Mar 2013, Greg KH wrote: > > > On Thu, Mar 28, 2013 at 02:44:01PM -0400, Alan Stern wrote: > > > On Thu, 28 Mar 2013, Greg KH wrote: > > > > > > > > >>ls /sys/bus/usb/devices > > > > > >>1-0:1.02-0:1.0 port1-1 port

Re: [PATCH 4/4] usb: register usb port to usb_bus_type

2013-03-28 Thread Greg KH
On Fri, Mar 29, 2013 at 03:08:17AM +0800, Lan Tianyu wrote: > On 2013/3/29 2:53, Greg KH wrote: > >On Thu, Mar 28, 2013 at 02:44:01PM -0400, Alan Stern wrote: > >>On Thu, 28 Mar 2013, Greg KH wrote: > >> > >>ls /sys/bus/usb/devices > >>1-0:1.02-0:1.0 port1-1 port1-1.3 port2-1.2

Re: [PATCH 2/4] usb: introduce usb force power off mechanism

2013-03-28 Thread Sarah Sharp
On Thu, Mar 28, 2013 at 05:00:23PM -0400, Alan Stern wrote: > On Thu, 28 Mar 2013, Sarah Sharp wrote: > > > On Thu, Mar 28, 2013 at 01:11:02AM +0800, Lan Tianyu wrote: > > > Some devices' firmware will be broken at some points. Power down > > > and power on device can help device to rework in this

Re: [PATCH 2/2] xhci: Rename SEGMENT_SIZE and SEGMENT_SHIFT as the former is used in a.out.h

2013-03-28 Thread David Howells
Sarah Sharp wrote: > I'm a little bit confused about your description for the second one. > Did you need to change the #defines names because they could conflict > with other drivers when the xHCI driver is built in? Or is there some > other point I'm missing? Sorry, I should say. I'm trying t

RE: [PATCH v2 1/2] usb: chipidea: big-endian support

2013-03-28 Thread Svetoslav Neykov
Alexander Shishkin wrote: > Svetoslav Neykov writes: > >> Convert between big-endian and little-endian format when accessing the usb controller structures which are little-endian by specification. >> Fix cases where the little-endian memory layout is taken for granted. >> The patch doesn't have an

RE: [PATCH v2 2/2] usb: chipidea: AR933x platform support for the chipidea driver

2013-03-28 Thread Svetoslav Neykov
Alexander Shishkin wrote: >No need to initialize it like this, it should save a few bytes in >.data. Ok. >Why can't you just use ci13xxx_platform_data? >It looks like you don't need a glue driver is drivers/usb/chipidea at >all, you can register ci_hdrc right from the ath79/dev-usb.c You are righ

[PATCH v3 6/7] USB: EHCI: make ehci-msm a separate driver

2013-03-28 Thread Arnd Bergmann
From: Manjunath Goudar Separate the Qualcomm QSD/MSM on-chip host controller driver from ehci-hcd host code so that it can be built as a separate driver module. This work is part of enabling multi-platform kernels on ARM; however, note that other changes are still needed before Qualcomm QSD/MSM

[PATCH v3 1/7] USB: EHCI: make ehci-orion a separate driver

2013-03-28 Thread Arnd Bergmann
From: Manjunath Goudar Separate the Orion host controller driver from ehci-hcd host code into its own driver module because of following reason. With the multiplatform changes in arm-soc tree, it becomes possible to enable the mvebu platform (which uses ehci-orion) at the same time as other plat

[PATCH v3 3/7] USB: EHCI: make ehci-s5p a separate driver

2013-03-28 Thread Arnd Bergmann
From: Manjunath Goudar Separate the Samsung S5P/EXYNOS host controller driver from ehci-hcd host code so that it can be built as a separate driver module. This work is part of enabling multi-platform kernels on ARM; however, note that other changes are still needed before S5P/EXYNOS can be boote

[PATCH v3 4/7] USB: EHCI: export ehci_shutdown

2013-03-28 Thread Arnd Bergmann
The ehci_shutdown function is used by the platform specific ehci backends for at91, tegra and ps3. In order to turn any of these into separate modules, we need to make this function globally visible and export it. Signed-off-by: Arnd Bergmann Cc: Greg KH Cc: Alan Stern Cc: linux-usb@vger.kernel

[PATCH v3 5/7] USB: EHCI: make ehci-atmel a separate driver

2013-03-28 Thread Arnd Bergmann
From: Manjunath Goudar Separate the Atmel host controller driver from ehci-hcd host code so that it can be built as a separate driver module. This work is part of enabling multi-platform kernels on ARM; however, note that other changes are still needed before Atmel can be booted with a multi-plat

[PATCH v3 0/7] USB EHCI multiplatform series again

2013-03-28 Thread Arnd Bergmann
Hi Alan, These are the current patches from Manjunath, after I helped him address the remaining review comments and found a few more in the process. Unfortunately, Manjunath is currently on vacation and I will be away for the next couple of days when he returns, so I took the liberty to send the

[PATCH v3 7/7] USB: OHCI: avoid conflicting platform drivers

2013-03-28 Thread Arnd Bergmann
Like the EHCI driver, OHCI supports a large number of different platform glue drivers by directly including them, which causes problems with conflicting macro definitions in some cases. As more ARM architecture specific back-ends are required to coexist in a single build, we should split those out

[PATCH v3 2/7] USB: EHCI: make ehci-spear a separate driver

2013-03-28 Thread Arnd Bergmann
From: Manjunath Goudar Separate the SPEAr host controller driver from ehci-hcd host code so that it can be built as a separate driver module. This work is part of enabling multi-platform kernels on ARM; however, note that other changes are still needed before SPEAr can be booted with a multi-plat

RE: [PATCH v2 1/2] usb: chipidea: big-endian support

2013-03-28 Thread Svetoslav Neykov
Hi Michael, On Thu, March 28, 2013 4:13 PM Michael Grzeschik wrote: >On Thu, Mar 28, 2013 at 11:28:32AM +0200, Alexander Shishkin wrote: >> Svetoslav Neykov writes: >> >> > Convert between big-endian and little-endian format when accessing the usb controller structures which are little-endian b

Re: [PATCH] usb: ehci: mark unlink_empty_async_suspended() as __maybe_unused

2013-03-28 Thread Tony Prisk
On 29/03/13 10:16, Arnd Bergmann wrote: On Thursday 28 March 2013, Arnd Bergmann wrote: Patch 4d053fdac3 "usb: ehci: unlink_empty_async_suspended() only used with CONFIG_PM" tried to hide the unlink_empty_async_suspended function inside of an #ifdef to work around an unused function warning. Hi

Re: [PATCH] usb: ehci: mark unlink_empty_async_suspended() as __maybe_unused

2013-03-28 Thread Arnd Bergmann
On Thursday 28 March 2013, Arnd Bergmann wrote: > Patch 4d053fdac3 "usb: ehci: unlink_empty_async_suspended() only used > with CONFIG_PM" tried to hide the unlink_empty_async_suspended function > inside of an #ifdef to work around an unused function warning. Hi Greg, Apparently the warning is now

[PATCH] usb: ehci: mark unlink_empty_async_suspended() as __maybe_unused

2013-03-28 Thread Arnd Bergmann
Patch 4d053fdac3 "usb: ehci: unlink_empty_async_suspended() only used with CONFIG_PM" tried to hide the unlink_empty_async_suspended function inside of an #ifdef to work around an unused function warning. Unfortunately that had the effect of introducing a new warning: drivers/usb/host/ehci-q.c:12

Re: [PATCH 2/4] usb: introduce usb force power off mechanism

2013-03-28 Thread Alan Stern
On Thu, 28 Mar 2013, Sarah Sharp wrote: > On Thu, Mar 28, 2013 at 01:11:02AM +0800, Lan Tianyu wrote: > > Some devices' firmware will be broken at some points. Power down > > and power on device can help device to rework in this case. > > > > This patch is to add ioctl cmd USBDEVFS_POWER_RESET fo

Re: [PATCH 3/4] usb: Add usb port system pm support

2013-03-28 Thread Sarah Sharp
On Thu, Mar 28, 2013 at 07:58:47AM +0800, Lan Tianyu wrote: > On 2013/3/28 2:47, Alan Stern wrote: > >On Thu, 28 Mar 2013, Lan Tianyu wrote > >What happens if there's no device plugged in to the port, but the hub > >is enabled for remote wakeup? How will the hub be able to detect a > >plug-in even

Re: [PATCH 2/4] usb: introduce usb force power off mechanism

2013-03-28 Thread Sarah Sharp
On Fri, Mar 29, 2013 at 03:51:50AM +0800, Lan Tianyu wrote: > On 2013/3/29 3:38, Alan Stern wrote: > >On Fri, 29 Mar 2013, Lan Tianyu wrote: > >It looks okay. When you test it, does the attached device get detected > >and initialized properly? > I test usb2.0 key on my machine. It works. Did you

Re: [PATCH 2/4] usb: introduce usb force power off mechanism

2013-03-28 Thread Sarah Sharp
On Thu, Mar 28, 2013 at 01:11:02AM +0800, Lan Tianyu wrote: > Some devices' firmware will be broken at some points. Power down > and power on device can help device to rework in this case. > > This patch is to add ioctl cmd USBDEVFS_POWER_RESET for usbfs node > to repower usb device. First, call h

Re: [PATCH 2/2] xhci: Rename SEGMENT_SIZE and SEGMENT_SHIFT as the former is used in a.out.h

2013-03-28 Thread Sarah Sharp
Hi Dave, I'm a little bit confused about your description for the second one. Did you need to change the #defines names because they could conflict with other drivers when the xHCI driver is built in? Or is there some other point I'm missing? Are these feature patches for 3.10, or bug fixes for

Re: [PATCH 2/4] usb: introduce usb force power off mechanism

2013-03-28 Thread Lan Tianyu
On 2013/3/29 3:38, Alan Stern wrote: On Fri, 29 Mar 2013, Lan Tianyu wrote: Ok. I just refresh patch "usb: introduce usb force power off mechanism" Please have a look. From 16f5c7c6dd00830530a9ac758af25b575e0b8731 Mon Sep 17 00:00:00 2001 From: Lan Tianyu Date: Tue, 26 Feb 2013 11:12:09 +08

Re: [PATCH 2/4] usb: introduce usb force power off mechanism

2013-03-28 Thread Alan Stern
On Fri, 29 Mar 2013, Lan Tianyu wrote: > Ok. I just refresh patch "usb: introduce usb force power off mechanism" > Please have a look. > > From 16f5c7c6dd00830530a9ac758af25b575e0b8731 Mon Sep 17 00:00:00 2001 > From: Lan Tianyu > Date: Tue, 26 Feb 2013 11:12:09 +0800 > Subject: [PATCH] usb: in

[PATCH] USB: remove CONFIG_USB_SUSPEND from Documentation

2013-03-28 Thread Alan Stern
An earlier patch removed the CONFIG_USB_SUSPEND symbol but forgot to update the Documentation files. This patch (as1676) rectifies that omission. Signed-off-by: Alan Stern --- Documentation/ABI/testing/sysfs-bus-usb |6 +++--- Documentation/usb/power-management.txt | 10 ++ 2 f

Re: [PATCH/RFC] staging: dwc: Moving all hwcfg accesses to one place

2013-03-28 Thread Matthijs Kooijman
Hi Paul, > If you look closely at the databook, you will see that DPTXFSIZn and > DIEPTXFn are both aliases for the same register address. Ah, right. Remebmer I don't have the databook, only the register descriptions from the RT3052 datasheet, which are riddled with typos, so I had assumed the ide

Re: [PATCH 4/4] usb: register usb port to usb_bus_type

2013-03-28 Thread Alan Stern
On Thu, 28 Mar 2013, Greg KH wrote: > On Thu, Mar 28, 2013 at 02:44:01PM -0400, Alan Stern wrote: > > On Thu, 28 Mar 2013, Greg KH wrote: > > > > > > >>ls /sys/bus/usb/devices > > > > >>1-0:1.02-0:1.0 port1-1 port1-1.3 port2-1.2 port2-2 > > > > >>port4-3 > > > > >>1-12-1

RE: [PATCH/RFC] staging: dwc: Moving all hwcfg accesses to one place

2013-03-28 Thread Paul Zimmerman
Whoops, resending as text instead of html. > From: Matthijs Kooijman [mailto:matth...@stdin.nl] > Sent: Thursday, March 28, 2013 9:32 AM > > Hi Paul, > > while continuing this patch, I stumbled upon a bit of code which doesn't > make sense to me. In dwc2_dump_global_registers is the following bi

Re: [PATCH 4/4] usb: register usb port to usb_bus_type

2013-03-28 Thread Lan Tianyu
On 2013/3/29 2:53, Greg KH wrote: On Thu, Mar 28, 2013 at 02:44:01PM -0400, Alan Stern wrote: On Thu, 28 Mar 2013, Greg KH wrote: ls /sys/bus/usb/devices 1-0:1.02-0:1.0 port1-1 port1-1.3 port2-1.2 port2-2 port4-3 1-12-1 port1-1.1port1-1.4 port2-1.3 port3-1 port

[PATCH refreshed] USB: improve port transitions when EHCI starts up

2013-03-28 Thread Alan Stern
It seems to be getting more common recently for EHCI host controllers to be probed after their companion UHCI or OHCI controllers. This may be caused partly by splitting the ehci-pci driver out from ehci-hcd, or it may be caused by changes in the way the kernel does driver probing. Regardless, it

Re: [PATCH 4/4] usb: register usb port to usb_bus_type

2013-03-28 Thread Lan Tianyu
On 2013/3/29 2:44, Alan Stern wrote: On Thu, 28 Mar 2013, Greg KH wrote: ls /sys/bus/usb/devices 1-0:1.02-0:1.0 port1-1 port1-1.3 port2-1.2 port2-2 port4-3 1-12-1 port1-1.1port1-1.4 port2-1.3 port3-1 port4-4 1-1.1 2-1:1.0 port1-1.2port1-1.5 port2-1.4

Re: [PATCH 4/4] usb: register usb port to usb_bus_type

2013-03-28 Thread Greg KH
On Thu, Mar 28, 2013 at 02:44:01PM -0400, Alan Stern wrote: > On Thu, 28 Mar 2013, Greg KH wrote: > > > > >>ls /sys/bus/usb/devices > > > >>1-0:1.02-0:1.0 port1-1 port1-1.3 port2-1.2 port2-2 port4-3 > > > >>1-12-1 port1-1.1port1-1.4 port2-1.3 port3-1 port4-4 > > >

Re: [PATCH 2/2] USB: remove CONFIG_USB_SUSPEND option

2013-03-28 Thread Alan Stern
On Thu, 28 Mar 2013, Greg KH wrote: > On Wed, Mar 27, 2013 at 04:14:46PM -0400, Alan Stern wrote: > > This patch (as1675) removes the CONFIG_USB_SUSPEND option, essentially > > replacing it everywhere with CONFIG_PM_RUNTIME (except for one place > > in hub.c, where it is replaced with CONFIG_PM be

Re: [PATCH] USB: improve port transitions when EHCI starts up

2013-03-28 Thread Alan Stern
On Thu, 28 Mar 2013, Greg KH wrote: > On Wed, Mar 27, 2013 at 04:13:36PM -0400, Alan Stern wrote: > > It seems to be getting more common recently for EHCI host controllers > > to be probed after their companion UHCI or OHCI controllers. This may > > be caused partly by splitting the ehci-pci driv

[PATCH 1/2] xhci: Use ilog2() rather than __ffs() for calculating SEGMENT_SHIFT

2013-03-28 Thread David Howells
Use ilog2() rather than __ffs() for calculating SEGMENT_SHIFT as ilog2() can be worked out at compile time, whereas __ffs() must be calculated at runtime. Signed-off-by: David Howells cc: Sarah Sharp cc: Greg Kroah-Hartman cc: linux-usb@vger.kernel.org --- drivers/usb/host/xhci.h |2 +- 1

[PATCH 2/2] xhci: Rename SEGMENT_SIZE and SEGMENT_SHIFT as the former is used in a.out.h

2013-03-28 Thread David Howells
Rename SEGMENT_SIZE and SEGMENT_SHIFT as the former is used in a.out.h. Signed-off-by: David Howells cc: Sarah Sharp cc: Greg Kroah-Hartman cc: linux-usb@vger.kernel.org --- drivers/usb/host/xhci-mem.c | 16 drivers/usb/host/xhci.h |4 ++-- 2 files changed, 10 inser

Re: [PATCH 4/4] usb: register usb port to usb_bus_type

2013-03-28 Thread Alan Stern
On Thu, 28 Mar 2013, Greg KH wrote: > > >>ls /sys/bus/usb/devices > > >>1-0:1.02-0:1.0 port1-1 port1-1.3 port2-1.2 port2-2 port4-3 > > >>1-12-1 port1-1.1port1-1.4 port2-1.3 port3-1 port4-4 > > >>1-1.1 2-1:1.0 port1-1.2port1-1.5 port2-1.4 port3-2 usb1 >

Re: Help with USB issues at boot-up on i.MX25 (linux 3.5.4)

2013-03-28 Thread Alan Stern
On Thu, 28 Mar 2013, David Linares wrote: > Ok so here is what I did: > - compiled all USB stuff as modules > - boot up the device with nothing plugged in > - Checked that "lsmod | grep usb" didn't return anything > - modprobe usbmon (this will also load usbcore) > - start the capture : cat /sys/k

Re: [PATCH v4 0/6] Generic PHY Framework

2013-03-28 Thread David Miller
You really need to CC: net...@vger.kernel.org rather than me explicitly on this patch set. Thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 4/4] usb: register usb port to usb_bus_type

2013-03-28 Thread Lan Tianyu
On 2013/3/29 2:21, Greg KH wrote: What does it look like if you reverse the naming scheme (hub dev name + "port")? Doesn't that show the devices in a bit more logical way? Hi Greg: Do you mean e.g "port1.2-1", originally it's "port2-1.1". 2-1 is hub dev name? No, I mean "2-1.port1" as

Re: [PATCH 4/4] usb: register usb port to usb_bus_type

2013-03-28 Thread Greg KH
On Fri, Mar 29, 2013 at 02:17:02AM +0800, Lan Tianyu wrote: > On 2013/3/29 1:59, Greg KH wrote: > >On Thu, Mar 28, 2013 at 01:11:04AM +0800, Lan Tianyu wrote: > >>Usb port isn't assigned to any bus_type. This seems not good from > >>Greg's comments. > >>http://marc.info/?l=linux-usb&m=136200364

Re: [PATCH 4/4] usb: register usb port to usb_bus_type

2013-03-28 Thread Lan Tianyu
On 2013/3/29 1:59, Greg KH wrote: On Thu, Mar 28, 2013 at 01:11:04AM +0800, Lan Tianyu wrote: Usb port isn't assigned to any bus_type. This seems not good from Greg's comments. http://marc.info/?l=linux-usb&m=136200364929942&w=2 This patch is to register usb port to usb_bus_type. The us

Re: [PATCH 2/2] USB: remove CONFIG_USB_SUSPEND option

2013-03-28 Thread Greg KH
On Wed, Mar 27, 2013 at 04:14:46PM -0400, Alan Stern wrote: > This patch (as1675) removes the CONFIG_USB_SUSPEND option, essentially > replacing it everywhere with CONFIG_PM_RUNTIME (except for one place > in hub.c, where it is replaced with CONFIG_PM because the code needs > to be used in both run

Re: [PATCH] USB: improve port transitions when EHCI starts up

2013-03-28 Thread Greg KH
On Wed, Mar 27, 2013 at 04:13:36PM -0400, Alan Stern wrote: > It seems to be getting more common recently for EHCI host controllers > to be probed after their companion UHCI or OHCI controllers. This may > be caused partly by splitting the ehci-pci driver out from ehci-hcd, > or it may be caused b

Re: [PATCH 4/4] usb: register usb port to usb_bus_type

2013-03-28 Thread Greg KH
On Thu, Mar 28, 2013 at 01:11:04AM +0800, Lan Tianyu wrote: > Usb port isn't assigned to any bus_type. This seems not good from > Greg's comments. > http://marc.info/?l=linux-usb&m=136200364929942&w=2 > > This patch is to register usb port to usb_bus_type. The usb port's > original name is "

Re: [PATCH 2/4] usb: introduce usb force power off mechanism

2013-03-28 Thread Lan Tianyu
On 2013/3/29 1:49, Alan Stern wrote: On Fri, 29 Mar 2013, Lan Tianyu wrote: On 2013/3/29 0:50, Alan Stern wrote: On Fri, 29 Mar 2013, Lan Tianyu wrote: About the path "usb: Add usb port system pm support", do you think it's ok? Generally yes. But why doesn't usb_port_system_suspend check

Re: [PATCH 2/4] usb: introduce usb force power off mechanism

2013-03-28 Thread Alan Stern
On Fri, 29 Mar 2013, Lan Tianyu wrote: > On 2013/3/29 0:50, Alan Stern wrote: > > On Fri, 29 Mar 2013, Lan Tianyu wrote: > > > >> About the path "usb: Add usb port system pm support", do you think it's > >> ok? > > > > Generally yes. But why doesn't usb_port_system_suspend check for any > > PM_QO

Re: 3.8.4: ohci question

2013-03-28 Thread Alan Stern
On Thu, 28 Mar 2013, Udo van den Heuvel wrote: > On 2013-03-28 15:35, Alan Stern wrote: > >>> When my dmesg gives me a growing number of lines like the one below, > >>> what is going on? > >>> > >>> ohci_hcd :00:12.0: urb 88023025c500 path 2 ep1in 6c16 cc 6 > >>> --> status -71 > >>>

[GIT PATCH] USB fixes for 3.9-rc4

2013-03-28 Thread Greg KH
The following changes since commit 8bb9660418e05bb1845ac1a2428444d78e322cc7: Linux 3.9-rc4 (2013-03-23 16:52:44 -0700) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git/ tags/usb-3.9-rc4 for you to fetch changes up to 482b0b5d82bd916cc0c55a

Re: Help with USB issues at boot-up on i.MX25 (linux 3.5.4)

2013-03-28 Thread David Linares
On 27 March 2013 20:00, Alan Stern wrote: > On Wed, 27 Mar 2013, David Linares wrote: > >> Please correct me if I am wrong. >> On my iMX25 board, I have got a 1-port root_hub which will provide >> 500mA max to its unique child. > > You should check that against the iMX25's specs. It's possible th

Re: [PATCH 2/4] usb: introduce usb force power off mechanism

2013-03-28 Thread Lan Tianyu
On 2013/3/29 0:50, Alan Stern wrote: On Fri, 29 Mar 2013, Lan Tianyu wrote: About the path "usb: Add usb port system pm support", do you think it's ok? Generally yes. But why doesn't usb_port_system_suspend check for any PM_QOS constraints? Either on the port itself or on the child device.

Re: 3.8.4: ohci question

2013-03-28 Thread Udo van den Heuvel
On 2013-03-28 15:35, Alan Stern wrote: >>> When my dmesg gives me a growing number of lines like the one below, >>> what is going on? >>> >>> ohci_hcd :00:12.0: urb 88023025c500 path 2 ep1in 6c16 cc 6 >>> --> status -71 >>> >>> Please let me know! > > -71 errors indicate a low-level p

Re: [PATCH 2/4] usb: introduce usb force power off mechanism

2013-03-28 Thread Alan Stern
On Fri, 29 Mar 2013, Lan Tianyu wrote: > About the path "usb: Add usb port system pm support", do you think it's > ok? Generally yes. But why doesn't usb_port_system_suspend check for any PM_QOS constraints? Either on the port itself or on the child device. Alan Stern -- To unsubscribe from t

Re: [PATCH/RFC] staging: dwc: Moving all hwcfg accesses to one place

2013-03-28 Thread Matthijs Kooijman
Hi Paul, while continuing this patch, I stumbled upon a bit of code which doesn't make sense to me. In dwc2_dump_global_registers is the following bit: if (hsotg->core_params->en_multiple_tx_fifo <= 0) { ep_num = hsotg->hwcfg4 >> GHWCFG4_NUM_DEV_PERIO_IN_EP_SHIFT &

[PATCH 2/2 v3] sierra_net: keep status interrupt URB active

2013-03-28 Thread Dan Williams
The driver and firmware sync up through SYNC messages, and the firmware's affirmative reply to these SYNC messages appears to be the "Reset" indication received via the status interrupt endpoint. Thus the driver needs the status interrupt endpoint always active so that the Reset indication can be

[PATCH 1/2 v3] usbnet: allow status interrupt URB to always be active

2013-03-28 Thread Dan Williams
Some drivers (sierra_net) need the status interrupt URB active even when the device is closed, because they receive custom indications from firmware. Add functions to refcount the status interrupt URB submit/kill operation so that sub-drivers and the generic driver don't fight over whether the sta

Re: [PATCH 2/4] usb: introduce usb force power off mechanism

2013-03-28 Thread Lan Tianyu
On 2013/3/28 22:46, Alan Stern wrote: On Thu, 28 Mar 2013, Lan Tianyu wrote: How long do you think the power should remain turned off? This code will leave it off for only a few milliseconds at most. That may not even be long enough for the voltage to drop all the way to 0. The delay probabl

Re: [PATCH v2 1/2] usb: chipidea: big-endian support

2013-03-28 Thread Alexander Shishkin
Michael Grzeschik writes: > On Thu, Mar 28, 2013 at 11:28:32AM +0200, Alexander Shishkin wrote: >> Svetoslav Neykov writes: >> >> > Convert between big-endian and little-endian format when accessing the usb >> > controller structures which are little-endian by specification. >> > Fix cases whe

Re: [PATCH v4 1/6] drivers: phy: add generic PHY framework

2013-03-28 Thread Stephen Warren
On 03/27/2013 11:43 PM, Kishon Vijay Abraham I wrote: > The PHY framework provides a set of APIs for the PHY drivers to > create/destroy a PHY and APIs for the PHY users to obtain a reference to the > diff --git a/Documentation/devicetree/bindings/phy/phy-bindings.txt > b/Documentation/devicetree

Re: Piggy-backing new hardware using old usb-serial

2013-03-28 Thread Dan Williams
On Thu, 2013-03-28 at 15:58 +0100, Wesley W. Terpstra wrote: > On Thu, 2013-03-28 at 09:39 -0500, Dan Williams wrote: > > Greg's right, there's no reason not to use cdc-acm if you want to do > > that, since not all cdc-acm devices are modems. If you get a USBIF > > vendor ID, then I'll happily add

[PATCH] usb: ftdi_sio: Add support for Mitsubishi FX-USB-AW/-BD

2013-03-28 Thread Konstantin Holoborodko
It enhances the driver for FTDI-based USB serial adapters to recognize Mitsubishi Electric Corp. USB/RS422 Converters as FT232BM chips and support them. https://search.meau.com/?q=FX-USB-AW Signed-off-by: Konstantin Holoborodko Tested-by: Konstantin Holoborodko --- drivers/usb/serial/ftdi_sio.c

Re: Piggy-backing new hardware using old usb-serial

2013-03-28 Thread Wesley W. Terpstra
On Thu, 2013-03-28 at 09:39 -0500, Dan Williams wrote: > Greg's right, there's no reason not to use cdc-acm if you want to do > that, since not all cdc-acm devices are modems. If you get a USBIF > vendor ID, then I'll happily add your device to the ModemManager probing > blacklist too. Yes, the c

Re: [PATCH 2/4] usb: introduce usb force power off mechanism

2013-03-28 Thread Alan Stern
On Thu, 28 Mar 2013, Lan Tianyu wrote: > > How long do you think the power should remain turned off? This code > > will leave it off for only a few milliseconds at most. That may not > > even be long enough for the voltage to drop all the way to 0. > > > > The delay probably should be at least 1

Re: [PATCH/RFC] uvcvideo: Disable USB autosuspend for Creative Live! Cam Optia AF

2013-03-28 Thread Alan Stern
On Thu, 28 Mar 2013, Laurent Pinchart wrote: > The camera fails to start video streaming after having been autosuspend. > Add a new quirk to selectively disable autosuspend for devices that > don't support it. > > Signed-off-by: Laurent Pinchart > --- > drivers/media/usb/uvc/uvc_driver.c | 14 +

Re: Linux USB file storage gadget with new UDC

2013-03-28 Thread Alan Stern
On Thu, 28 Mar 2013, victor yeo wrote: > There is a problem with SCSI_READ_10 command if looking at usbmon. I > pasted the usbmon log that starts from SCSI_READ_10. Basically, the > SCSI_READ_10 was received by gadget, processed, sent CSW, followed by > control packets. Then another SCSI_READ_10,

Re: Piggy-backing new hardware using old usb-serial

2013-03-28 Thread Dan Williams
On Wed, 2013-03-27 at 16:13 -0700, Greg KH wrote: > On Wed, Mar 27, 2013 at 09:28:11PM +0100, Wesley W. Terpstra wrote: > > On Wed, 2013-03-27 at 13:06 -0700, Greg KH wrote: > > > > Our current prototypes borrow the Sierra VID > > > And the USB-IF might revoke your vendor id, if they find you shipp

Re: [PATCH V2 3/6] usb: ehci: mv_ehci: remove unused clock

2013-03-28 Thread Alan Stern
On Thu, 28 Mar 2013, Chao Xie wrote: > hi, Alan > > This is the patch for EHCI clock fix. Can you help to review and ack it? > Thanks. > > On Mon, Mar 25, 2013 at 3:06 PM, Chao Xie wrote: > > The origianl understanding of clock is wrong. The EHCI controller > > only have one clock input. > > P

Re: 3.8.4: ohci question

2013-03-28 Thread Alan Stern
On Wed, 27 Mar 2013, Bjorn Helgaas wrote: > [+cc linux-usb] > > On Wed, Mar 27, 2013 at 11:37 AM, Udo van den Heuvel wrote: > > Hello, > > > > When my dmesg gives me a growing number of lines like the one below, > > what is going on? > > > > ohci_hcd :00:12.0: urb 88023025c500 path 2 ep

Re: [PATCH v2 1/2] usb: chipidea: big-endian support

2013-03-28 Thread Marc Kleine-Budde
On 03/28/2013 10:28 AM, Alexander Shishkin wrote: > Svetoslav Neykov writes: > >> Convert between big-endian and little-endian format when accessing >> the usb controller structures which are little-endian by >> specification. Fix cases where the little-endian memory layout is >> taken for grante

Re: [PATCH v2 1/2] usb: chipidea: big-endian support

2013-03-28 Thread Michael Grzeschik
On Thu, Mar 28, 2013 at 11:28:32AM +0200, Alexander Shishkin wrote: > Svetoslav Neykov writes: > > > Convert between big-endian and little-endian format when accessing the usb > > controller structures which are little-endian by specification. > > Fix cases where the little-endian memory layout

Re: xhci page fault panic on Ubuntu kernel with HP desktop hardware

2013-03-28 Thread Yann Sionneau
Le 27/03/2013 23:40, Sarah Sharp a écrit : > On Wed, Mar 27, 2013 at 02:24:24PM +0100, Yann Sionneau wrote: >> Le 26/03/2013 17:30, Sarah Sharp a écrit : >>> On Tue, Mar 26, 2013 at 12:11:13PM +0100, Yann Sionneau wrote: Le 25/03/2013 19:13, Sarah Sharp a écrit : > On Mon, Mar 25, 2013 at

Re: [PATCH RESEND v2 1/1] usb: musb: implement (un)map_urb_for_dma hooks

2013-03-28 Thread Felipe Balbi
On Thu, Mar 28, 2013 at 03:44:50PM +0200, Ruslan Bilovol wrote: > Hi Felipe, > > On Wed, Mar 27, 2013 at 3:17 PM, Felipe Balbi wrote: > > Hi, > > > > On Thu, Mar 14, 2013 at 08:12:09PM +0200, Ruslan Bilovol wrote: > >> MUSB controller cannot work in DMA mode with misaligned buffers, > >> switchin

Re: [PATCH RESEND v2 1/1] usb: musb: implement (un)map_urb_for_dma hooks

2013-03-28 Thread Ruslan Bilovol
Hi Felipe, On Wed, Mar 27, 2013 at 3:17 PM, Felipe Balbi wrote: > Hi, > > On Thu, Mar 14, 2013 at 08:12:09PM +0200, Ruslan Bilovol wrote: >> MUSB controller cannot work in DMA mode with misaligned buffers, >> switching in PIO mode. >> >> HCD core has hooks that allow to override the default DMA >

Re: [PATCH 2/4] usb: introduce usb force power off mechanism

2013-03-28 Thread Lan Tianyu
On 2013/3/28 2:45, Alan Stern wrote: +int usb_hub_port_power_reset(struct usb_device *hdev, int port1) +{ + struct usb_hub *hub = usb_hub_to_struct_hub(hdev); + struct usb_interface *intf = to_usb_interface(hub->intfdev); + int ret; + + usb_autopm_get_interface(intf); Wh

Re: usb video capture issue due to uvc_complete callback spends more time

2013-03-28 Thread Felipe Balbi
On Thu, Mar 28, 2013 at 03:23:46PM +0200, Felipe Balbi wrote: > Hi, > > On Thu, Mar 28, 2013 at 08:53:03PM +0800, Ming Lei wrote: > > On Thu, Mar 28, 2013 at 8:30 PM, B, Ravi wrote: > > > > > > For example, in one iteration I have observed, the time taken by > > > uvc_video_decode_isoc() was 2175

Re: usb video capture issue due to uvc_complete callback spends more time

2013-03-28 Thread Felipe Balbi
Hi, On Thu, Mar 28, 2013 at 08:53:03PM +0800, Ming Lei wrote: > On Thu, Mar 28, 2013 at 8:30 PM, B, Ravi wrote: > > > > For example, in one iteration I have observed, the time taken by > > uvc_video_decode_isoc() was 2175 usec. In this maximum amount of > > time was consumed by uvc_video_decode_d

Re: [PATCH 3/5] USB chipidea: introduce dual role mode pdata flags

2013-03-28 Thread Alexander Shishkin
Felipe Balbi writes: > Hi, Hi, > On Thu, Mar 28, 2013 at 01:13:00PM +0200, Alexander Shishkin wrote: >> >> + dr_mode = ci->platdata->dr_mode; >> >> + if (dr_mode == USB_DR_MODE_UNKNOWN || dr_mode == >> >> USB_DR_MODE_DUAL_ROLE) >> >> + dr_mode = USB_DR_M

Re: usb video capture issue due to uvc_complete callback spends more time

2013-03-28 Thread Ming Lei
On Thu, Mar 28, 2013 at 8:30 PM, B, Ravi wrote: > > For example, in one iteration I have observed, the time taken by > uvc_video_decode_isoc() was 2175 usec. In this maximum amount of time was > consumed by uvc_video_decode_data() around 1792 usec. uvc_video_decode_data() is basically a memcpy(

RE: usb video capture issue due to uvc_complete callback spends more time

2013-03-28 Thread B, Ravi
Laurent > > > > > > Some more debugging, Most of the time spend in stream->decode() > function > > > > That points to uvc_video_decode_isoc(). > > You are correct, that points to uvc_video_decode_isoc() > > > > > > in uvc_video_complete() callback handler. > > > > It's not very surprising, but d

Re: [PATCH v2 2/2] usb: chipidea: AR933x platform support for the chipidea driver

2013-03-28 Thread Alexander Shishkin
Svetoslav Neykov writes: > Support host and device usb modes for the chipidea controller in AR933x. > > Changes since last version of the patch: > * conditionally include ci13xxx_ar933x.c for compilation > * removed __devinit/__devexit/__devexit_p() > * use a dynamically allocat

[PATCH/RFC] uvcvideo: Disable USB autosuspend for Creative Live! Cam Optia AF

2013-03-28 Thread Laurent Pinchart
The camera fails to start video streaming after having been autosuspend. Add a new quirk to selectively disable autosuspend for devices that don't support it. Signed-off-by: Laurent Pinchart --- drivers/media/usb/uvc/uvc_driver.c | 14 +- drivers/media/usb/uvc/uvcvideo.h | 1 + 2

  1   2   >