Re: [linux-usb-devel] Re: [PATCH] Driver to Add Usability for Maxtor External Drives

2005-04-01 Thread Alan Stern
On Thu, 31 Mar 2005, Nick Sillik wrote: > Matthew Dharm wrote: > > The SCSI messages bother me a little bit... > > > > They indicate to me that you're accessing the disk (mount, etc.) when you > > yank the cable. But, you don't mention that you are... so I'm wondering > > what's going on. > > >

Re: [linux-usb-devel] Re: [PATCH] Driver to Add Usability for Maxtor External Drives

2005-03-31 Thread Nick Sillik
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Matthew Dharm wrote: > > > Well, at least we know what's causing one set of error messages. > > I would strongly suggest turning off the automounter until we have a better > handle on what's going on. > > Matt > With the automounter turned off, a

Re: [linux-usb-devel] Re: [PATCH] Driver to Add Usability for Maxtor External Drives

2005-03-31 Thread Matthew Dharm
On Thu, Mar 31, 2005 at 09:35:44PM -0500, Nick Sillik wrote: > Matthew Dharm wrote: > > The SCSI messages bother me a little bit... > > > > They indicate to me that you're accessing the disk (mount, etc.) when you > > yank the cable. But, you don't mention that you are... so I'm wondering > > wha

Re: [linux-usb-devel] Re: [PATCH] Driver to Add Usability for Maxtor External Drives

2005-03-31 Thread Nick Sillik
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Matthew Dharm wrote: > The SCSI messages bother me a little bit... > > They indicate to me that you're accessing the disk (mount, etc.) when you > yank the cable. But, you don't mention that you are... so I'm wondering > what's going on. > > Clarifi

Re: [linux-usb-devel] Re: [PATCH] Driver to Add Usability for Maxtor External Drives

2005-03-31 Thread Matthew Dharm
The SCSI messages bother me a little bit... They indicate to me that you're accessing the disk (mount, etc.) when you yank the cable. But, you don't mention that you are... so I'm wondering what's going on. Clarification? Matt On Thu, Mar 31, 2005 at 07:09:28PM -0500, Nick Sillik wrote: > When

Re: [linux-usb-devel] Re: [PATCH] Driver to Add Usability for Maxtor External Drives

2005-03-31 Thread Nick Sillik
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 When I unplugged the drive again all I got was this: Mar 31 18:55:03 localhost kernel: ehci_hcd :00:02.2: GetStatus port 1 status 001002 POWER sig=se0 CSC Mar 31 18:55:03 localhost kernel: usb 3-1: USB disconnect, address 6 Mar 31 18:55:03 localh

Re: [linux-usb-devel] Re: [PATCH] Driver to Add Usability for Maxtor External Drives

2005-03-31 Thread Nick Sillik
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 When I unplug the drive I get this: Mar 31 18:45:43 localhost kernel: ehci_hcd :00:02.2: devpath 1 ep1in 3strikes Mar 31 18:45:43 localhost kernel: usb 3-1: unlink qh32-0001/ddc8b100 start 31 [7/0 us] Mar 31 18:45:43 localhost kernel: ehci_hcd 00

Re: [usb-storage] Re: [linux-usb-devel] Re: [PATCH] Driver to Add Usability for Maxtor External Drives

2005-03-26 Thread Nick Sillik
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Nick Sillik wrote: > Alan Stern wrote: > >>>On Thu, 24 Mar 2005, Matthew Dharm wrote: >>> >>> >>> Well, let's start with the obvious: Remove the line of code you mention, and instead do: snprintf(onetouch->name, 128, "Maxtor Test Stri

Re: [usb-storage] Re: [linux-usb-devel] Re: [PATCH] Driver to Add Usability for Maxtor External Drives

2005-03-26 Thread Nick Sillik
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Alan Stern wrote: > On Thu, 24 Mar 2005, Matthew Dharm wrote: > > >>Well, let's start with the obvious: Remove the line of code you mention, >>and instead do: >> snprintf(onetouch->name, 128, "Maxtor Test String"); >> >>If that doesn't fix the

Re: [usb-storage] Re: [linux-usb-devel] Re: [PATCH] Driver to Add Usability for Maxtor External Drives

2005-03-25 Thread Alan Stern
On Thu, 24 Mar 2005, Matthew Dharm wrote: > Well, let's start with the obvious: Remove the line of code you mention, > and instead do: > snprintf(onetouch->name, 128, "Maxtor Test String"); > > If that doesn't fix the problem, then it's not the culprit and you need to > keep looking. > >

Re: [linux-usb-devel] Re: [PATCH] Driver to Add Usability for Maxtor External Drives

2005-03-24 Thread Matthew Dharm
Well, let's start with the obvious: Remove the line of code you mention, and instead do: snprintf(onetouch->name, 128, "Maxtor Test String"); If that doesn't fix the problem, then it's not the culprit and you need to keep looking. If that is the problem, then my guess is more that this i

Re: [linux-usb-devel] Re: [PATCH] Driver to Add Usability for Maxtor External Drives

2005-03-24 Thread Nick Sillik
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Okay, I have a serious problem. Everything goes fine when the device is unplugged. When the device is plugged back in however, everything goes bad, then the system hangs. The only change that I can recall happening in the interim is that us_data no log

Re: [linux-usb-devel] Re: [PATCH] Driver to Add Usability for Maxtor External Drives

2005-03-24 Thread Nicholas Sillik
Sorry! I have no idea why the patch was attached to the last message. It won't happen again. Nick Sillik [EMAIL PROTECTED] --- SF email is sponsored by - The IT Product Guide Read honest & candid reviews on hundreds of IT Products from real use

Re: [linux-usb-devel] Re: [PATCH] Driver to Add Usability for Maxtor External Drives

2005-03-24 Thread Alan Stern
Nick, please stop spamming the lists with your patch every time you send a message! On Wed, 23 Mar 2005, Nick Sillik wrote: > Well, I have a problem. This patch hangs the computer when the drive is > plugged > in then unplugged. > > Any Ideas where this is coming from? On Wed, 23 Mar 2005, Ni

Re: [linux-usb-devel] Re: [PATCH] Driver to Add Usability for Maxtor External Drives

2005-03-23 Thread Phil Dibowitz
Nick Sillik wrote: Here's the patch with those two changes, as well as the change to the min and max in unusual_devs.h that Sergey suggested. I also eliminated the encoding problem from the patch. You mean Phil... Sergey had other suggestions, unusual_devs comments were from me. =) The entry looks

Re: [linux-usb-devel] Re: [PATCH] Driver to Add Usability for Maxtor External Drives

2005-03-23 Thread Dmitry Torokhov
On Wednesday 23 March 2005 12:07, Sergey Vlasov wrote: > > +static void onetouch_close(struct input_dev *dev) > > +{ > > +Âstruct usb_onetouch *onetouch = dev->private; > > + > > +Âif (!--onetouch->open_count) > > +Âusb_kill_urb(onetouch->irq); > > However, I don't see lock_ker

Re: [linux-usb-devel] Re: [PATCH] Driver to Add Usability for Maxtor External Drives

2005-03-23 Thread Nick Sillik
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 And now this. The computer doesn't hang all the time, but it does register the device incorrectly: When I put the drive back it, sometimes I get the right message (the first message), but after a while I almost certainly get the second (wrong)

Re: [linux-usb-devel] Re: [PATCH] Driver to Add Usability for Maxtor External Drives

2005-03-23 Thread Nick Sillik
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Well, I have a problem. This patch hangs the computer when the drive is plugged in then unplugged. Any Ideas where this is coming from? Nick Sillik [EMAIL PROTECTED] Nick Sillik wrote: > Here's the patch with those two changes, as well as the change

Re: [linux-usb-devel] Re: [PATCH] Driver to Add Usability for Maxtor External Drives

2005-03-23 Thread Nick Sillik
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Here's the patch with those two changes, as well as the change to the min and max in unusual_devs.h that Sergey suggested. I also eliminated the encoding problem from the patch. Signed-off-by: Nick Sillik <[EMAIL PROTECTED]> Alan Stern wrote: > On Tu

Re: [linux-usb-devel] Re: [PATCH] Driver to Add Usability for Maxtor External Drives

2005-03-23 Thread Sergey Vlasov
On Tue, Mar 22, 2005 at 10:37:29PM -0500, Nick Sillik wrote: > diff -urN -X dontdiff linux-2.6.12-rc1-mm1/drivers/usb/storage/Kconfig > linux-2.6.12-rc1-mm1-onetouch/drivers/usb/storage/Kconfig > --- linux-2.6.12-rc1-mm1/drivers/usb/storage/Kconfig 2005-03-22 > 18:27:15.0 -0500 > +++ lin

Re: [linux-usb-devel] Re: [PATCH] Driver to Add Usability for Maxtor External Drives

2005-03-23 Thread Nick Sillik
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Alan Stern wrote: > On Mon, 21 Mar 2005, Nick Sillik wrote: > > >>I made all of the changes you (Alan, Matt, Greg) talked about. > > > No you didn't. You still #include , , and > "usb.h" from within onetouch.h. It's not necessary to do that beca

Re: [linux-usb-devel] Re: [PATCH] Driver to Add Usability for Maxtor External Drives

2005-03-23 Thread Nick Sillik
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 IGNORE THAT LAST MESSAGE FROM 22/03/2005 ~6:36pm! I seem to have forgotten the "read all messages before you post (and especially patch)" rule. Nick Sillik [EMAIL PROTECTED] -BEGIN PGP SIGNATURE- Version: GnuPG v1.2.5 (GNU/Linux) iD8DBQFCQLXh

Re: [linux-usb-devel] Re: [PATCH] Driver to Add Usability for Maxtor External Drives

2005-03-23 Thread Alan Stern
On Tue, 22 Mar 2005, Nick Sillik wrote: > Well, I have attached the diff for linux-2.6.12-rc1-mm1 to this message. This > patch does cleanly compile. Take a look at it, if you like it apply it. If > not, > I'll keep hacking. (I'll keep this bottle of champagne - which has been > waiting > for a

Re: [linux-usb-devel] Re: [PATCH] Driver to Add Usability for Maxtor External Drives

2005-03-23 Thread Alan Stern
On Tue, 22 Mar 2005, Nick Sillik wrote: > I haven't been seeing my replies to this list. Has anyone else seen anything > from me anytime today? (March 22nd?) > > Nick Sillik > [EMAIL PROTECTED] lists.sourceforge.net has been running very slow recently. My mail doesn't get echoed back through t

Re: [linux-usb-devel] Re: [PATCH] Driver to Add Usability for Maxtor External Drives

2005-03-23 Thread Nick Sillik
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 IGNORE THAT LAST MESSAGE FROM 22/03/2005 ~6:36pm! I seem to have forgotten the "read all messages before you post (and especially patch)" rule. Nick Sillik [EMAIL PROTECTED] -BEGIN PGP SIGNATURE- Version: GnuPG v1.2.5 (GNU/Linux) iD8DBQFCQLp2

Re: [linux-usb-devel] Re: [PATCH] Driver to Add Usability for Maxtor External Drives

2005-03-23 Thread Nick Sillik
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Nick Sillik wrote: > I haven't been seeing my replies to this list. Has anyone else seen anything > from me anytime today? (March 22nd?) > > Nick Sillik > [EMAIL PROTECTED] Well. It showed up now. I have no idea. An update for everyone who is si

Re: [linux-usb-devel] Re: [PATCH] Driver to Add Usability for Maxtor External Drives

2005-03-23 Thread Alan Stern
On Mon, 21 Mar 2005, Nick Sillik wrote: > I made all of the changes you (Alan, Matt, Greg) talked about. No you didn't. You still #include , , and "usb.h" from within onetouch.h. It's not necessary to do that because those files are already #included by the source files that #include "onetou

Re: [linux-usb-devel] Re: [PATCH] Driver to Add Usability for Maxtor External Drives

2005-03-23 Thread Nicholas Sillik
Alan Stern wrote: > On Mon, 21 Mar 2005, Nick Sillik wrote: > > >>I made all of the changes you (Alan, Matt, Greg) talked about. > > > No you didn't. You still #include , , and > "usb.h" from within onetouch.h. It's not necessary to do that because > those files are already #included by the

Re: [linux-usb-devel] Re: [PATCH] Driver to Add Usability for Maxtor External Drives

2005-03-23 Thread Nick Sillik
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 I haven't been seeing my replies to this list. Has anyone else seen anything from me anytime today? (March 22nd?) Nick Sillik [EMAIL PROTECTED] Alan Stern wrote: > On Mon, 21 Mar 2005, Nick Sillik wrote: > > >>I made all of the changes you (Alan, M

Re: [linux-usb-devel] Re: [PATCH] Driver to Add Usability for Maxtor External Drives

2005-03-23 Thread Nick Sillik
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Here it is patched against 2.6.12-rc1-mm1 . I hope this is correct! Signed-off-by: Nick Sillik <[EMAIL PROTECTED]> Alan Stern wrote: > On Mon, 21 Mar 2005, Nick Sillik wrote: > > >>I can get a current diff once I get patches installed. Should I jus

Re: [linux-usb-devel] Re: [PATCH] Driver to Add Usability for Maxtor External Drives

2005-03-23 Thread Phil Dibowitz
I'll comment on the unusual_devs part since that's my area Nicholas Sillik wrote: --- linux-2.6.12-rc1-mm1/drivers/usb/storage/unusual_devs.h 2005-03-22 18:27:55.0 -0500 +++ linux-2.6.12-rc1-mm1-onetouch/drivers/usb/storage/unusual_devs.h 2005-03-22 20:09:12.0 -0500 @@

Re: [linux-usb-devel] Re: [PATCH] Driver to Add Usability for Maxtor External Drives

2005-03-22 Thread Alan Stern
On Mon, 21 Mar 2005, Nick Sillik wrote: > I can get a current diff once I get patches installed. Should I just diff this > against rc1? Or should I wait a few weeks until .12 is out? You don't have to wait for 2.6.12 to appear. But Matt Dharm just sent in a bunch of patches; you should wait for

Re: [linux-usb-devel] Re: [PATCH] Driver to Add Usability for Maxtor External Drives

2005-03-21 Thread Nick Sillik
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 I made all of the changes you (Alan, Matt, Greg) talked about. I'll send you the code to make sure I got everything. And here is what I've added to unusual_devs.h: #ifdef CONFIG_USB_STORAGE_ONETOUCH UNUSUAL_DEV( 0x0d49, 0x7010, 0x, 0x,

Re: [linux-usb-devel] Re: [PATCH] Driver to Add Usability for Maxtor External Drives

2005-03-21 Thread Nick Sillik
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Alan Stern wrote: > On Mon, 21 Mar 2005, Nick Sillik wrote: > > >>Yes, I figured this one out already, now my problem is the other message I >>sent >>here, and a new one, I'm getting: >> >>In file included from drivers/usb/storage/usb.c:184: >>drive

Re: [linux-usb-devel] Re: [PATCH] Driver to Add Usability for Maxtor External Drives

2005-03-21 Thread Nick Sillik
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Alan Stern wrote: > On Mon, 21 Mar 2005, Nick Sillik wrote: > > > Why did you specify US_PR_CBI when the device actually uses US_PR_BULK? > > And why didn't you specify both US_SC_DEVICE and US_PR_DEVICE? > > Alan Stern > > > Fixed it before yo

Re: [linux-usb-devel] Re: [PATCH] Driver to Add Usability for Maxtor External Drives

2005-03-21 Thread Alan Stern
On Mon, 21 Mar 2005, Nick Sillik wrote: > Yes, I figured this one out already, now my problem is the other message I > sent > here, and a new one, I'm getting: > > In file included from drivers/usb/storage/usb.c:184: > drivers/usb/storage/unusual_devs.h:921: warning: initialization from > incomp

Re: [linux-usb-devel] Re: [PATCH] Driver to Add Usability for Maxtor External Drives

2005-03-21 Thread Alan Stern
On Mon, 21 Mar 2005, Nick Sillik wrote: > An here's the code to add the destructor to the us_data: > > void onetouch_connect_input(struct us_data *ss) > { > struct usb_device *udev = ss->pusb_dev; > struct usb_onetouch *onetouch; > > ... > ss->extra_destructor = onetouc

Re: [linux-usb-devel] Re: [PATCH] Driver to Add Usability for Maxtor External Drives

2005-03-21 Thread Alan Stern
On Mon, 21 Mar 2005, Nick Sillik wrote: > Nick Sillik wrote: > > I changed it to use the unusual devs code. Now I get this error when > > insmodding. > > > > usb-storage: This device (0d49,7010,0200 S 06 P 50) has an unneeded SubClass > > entry in unusual_devs.h > >Please send a copy of this

Re: [linux-usb-devel] Re: [PATCH] Driver to Add Usability for Maxtor External Drives

2005-03-21 Thread Alan Stern
On Mon, 21 Mar 2005, Nick Sillik wrote: > I changed it to use the unusual devs code. Now I get this error when > insmodding. > > usb-storage: This device (0d49,7010,0200 S 06 P 50) has an unneeded SubClass > entry in unusual_devs.h >Please send a copy of this message to > > > hmmm? You p

Re: [linux-usb-devel] Re: [PATCH] Driver to Add Usability for Maxtor External Drives

2005-03-21 Thread Nick Sillik
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Matthew Dharm wrote: > Change US_SC_SCSI to US_SC_DEVICE. > > In fact, it's probably a good idea to change US_PR_CBI to US_PR_DEVICE. > Especially since the device is advertising US_PR_BULK, which is very > different from US_PR_CBI. > > Matt Yes, I f

Re: [linux-usb-devel] Re: [PATCH] Driver to Add Usability for Maxtor External Drives

2005-03-21 Thread Matthew Dharm
Change US_SC_SCSI to US_SC_DEVICE. In fact, it's probably a good idea to change US_PR_CBI to US_PR_DEVICE. Especially since the device is advertising US_PR_BULK, which is very different from US_PR_CBI. Matt On Mon, Mar 21, 2005 at 07:53:17PM -0500, Nick Sillik wrote: > Nick Sillik wrote: > > I c

Re: [linux-usb-devel] Re: [PATCH] Driver to Add Usability for Maxtor External Drives

2005-03-21 Thread Nick Sillik
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 An here's the code to add the destructor to the us_data: void onetouch_connect_input(struct us_data *ss) { struct usb_device *udev = ss->pusb_dev; struct usb_onetouch *onetouch; ... ss->extra_destructor = onetouch_rele

Re: [linux-usb-devel] Re: [PATCH] Driver to Add Usability for Maxtor External Drives

2005-03-21 Thread Nick Sillik
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Nick Sillik wrote: > I changed it to use the unusual devs code. Now I get this error when > insmodding. > > usb-storage: This device (0d49,7010,0200 S 06 P 50) has an unneeded SubClass > entry in unusual_devs.h >Please send a copy of this message

Re: [linux-usb-devel] Re: [PATCH] Driver to Add Usability for Maxtor External Drives

2005-03-21 Thread Nick Sillik
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 I changed it to use the unusual devs code. Now I get this error when insmodding. usb-storage: This device (0d49,7010,0200 S 06 P 50) has an unneeded SubClass entry in unusual_devs.h Please send a copy of this message to hmmm? Nick Sillik [EMAIL

Re: [linux-usb-devel] Re: [PATCH] Driver to Add Usability for Maxtor External Drives

2005-03-20 Thread Alan Stern
On Sun, 20 Mar 2005, Nick Sillik wrote: > I see that unusual devs have an initFunction, which is exactly what I need. > The > only problem is that I also need a function to be run on disconnect. Right now > I'm running my own code it in usb_stor_acquire_resources and > usb_store_release_resources

Re: [linux-usb-devel] Re: [PATCH] Driver to Add Usability for Maxtor External Drives

2005-03-20 Thread Nick Sillik
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 I see that unusual devs have an initFunction, which is exactly what I need. The only problem is that I also need a function to be run on disconnect. Right now I'm running my own code it in usb_stor_acquire_resources and usb_store_release_resources. The

Re: [linux-usb-devel] Re: [PATCH] Driver to Add Usability for Maxtor External Drives

2005-03-19 Thread Nick Sillik
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Looking more into the unusual devs code, it obvious that this is the correct way to do this. I will have this coded ASAP. Nick Sillik [EMAIL PROTECTED] Matthew Dharm wrote: > You're going to need to rediff this against the latest patches that > re-or

Re: [linux-usb-devel] Re: [PATCH] Driver to Add Usability for Maxtor External Drives

2005-03-19 Thread Nick Sillik
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Matthew Dharm wrote: > You're going to need to rediff this against the latest patches that > re-organize how some of the internal data structures are allocated (which > gives us refcounting). > > Also, could you use the unusual_devs.h init functions i

[linux-usb-devel] Re: [PATCH] Driver to Add Usability for Maxtor External Drives

2005-03-19 Thread Matthew Dharm
You're going to need to rediff this against the latest patches that re-organize how some of the internal data structures are allocated (which gives us refcounting). Also, could you use the unusual_devs.h init functions instead? Or does that not work out for some reason? This may also be a good t