Re: Research + questions on brcmfmac and support for monitor mode

On 6/18/2018 1:54 PM, Rafał Miłecki wrote: On Mon, 11 Jun 2018 at 12:48, Arend van Spriel wrote: On 5/30/2018 1:52 PM, Rafał Miłecki wrote: I'm providing extra version info of tested firmware images as requested by Arend in another e-mail thread. Looking into our firmware repo

Re: Atheros AR9462 - 5Ghz not working

+ Martin On 6/18/2018 3:53 PM, mgre...@cinci.rr.com wrote: Tom Psyborg wrote: Hi Your log only show attemps on ch 2447, Can you try connecting to 5GHz AP? Connect to Hidden Wireless Network option at the bottom of the nm-applet? Running airodump in monitor mode to see if it captures

Re: [PATCH 0/4] cfg80211/mac80211: Add support to configure and monitor txrate threshold

On 6/13/2018 5:10 PM, Toke Høiland-Jørgensen wrote: Tamizh Chelvam Raja writes: This patchsets introduced new NL command and api to support configuring txrate threshold for the connected stations and api to notify userspace application upon crossing the configured txrate threshold. This will

Re: [PATCH V2 2/3] brcmfmac: handle monitor mode marked msgbuf packets

On 5/30/2018 10:13 PM, Rafał Miłecki wrote: From: Rafał Miłecki New Broadcom firmwares mark monitor mode packets using a newly defined bit in the flags field. Use it to filter them out and pass to the monitor interface. These defines were found in bcmmsgbuf.h from SDK. As not every firmware

Re: How to let devcoredump know data has been read?

On 6/6/2018 12:53 AM, Brian Norris wrote: Unfortunately, devcoredump is a bit lacking in documentation. Arend was writing a bit for the new trigger mechanism at least. I did indeed write ABI doc for user-space trigger mechanism and you brought up the need to have ABI doc for devcoredump. I

Re: How to let devcoredump know data has been read?

On 6/6/2018 7:04 PM, Ben Greear wrote: On 06/05/2018 03:53 PM, Brian Norris wrote: Hi, On Tue, Jun 05, 2018 at 03:27:28PM -0700, Ben Greear wrote: I have been testing ath10k on 4.16, which uses the devcoredump API to notify about dumps. I am able to see the binary crash dump at

Re: [PATCH V2 2/3] brcmfmac: handle monitor mode marked msgbuf packets

On 5/30/2018 10:13 PM, Rafał Miłecki wrote: From: Rafał Miłecki New Broadcom firmwares mark monitor mode packets using a newly defined bit in the flags field. Use it to filter them out and pass to the monitor interface. These defines were found in bcmmsgbuf.h from SDK. As not every firmware

Re: [PATCH 2/3] brcmfmac: handle monitor mode marked msgbuf packets

On 5/22/2018 3:18 PM, Rafał Miłecki wrote: From: Rafał Miłecki New Broadcom firmwares mark monitor mode packets using a newly defined bit in the flags field. Use it to filter them out and pass to the monitor interface. These defines were found in bcmmsgbuf.h from SDK. As not every firmware

Re: [PATCH 2/3] brcmfmac: handle monitor mode marked msgbuf packets

On 5/27/2018 7:34 AM, Julian Calaby wrote: Hi Arend, On Fri, May 25, 2018 at 12:38 PM Arend van Spriel < arend.vanspr...@broadcom.com> wrote: On 5/22/2018 3:18 PM, Rafał Miłecki wrote: From: Rafał Miłecki New Broadcom firmwares mark monitor mode packets using a newly defin

Re: [PATCH] brcmfmac: stop watchdog before detach and free everything

On 5/28/2018 9:50 AM, Michael Trimarchi wrote: Watchdog need to be stopped in brcmf_sdio_remove to avoid i The system is going down NOW! [ 1348.110759] Unable to handle kernel NULL pointer dereference at virtual address 02f8 Sent SIGTERM to all processes [ 1348.121412] Mem abort info: [

Re: [RFC 1/3] cfg80211: Add support for HE

On 5/25/2018 9:51 PM, Luca Coelho wrote: Arend, On Fri, 2018-05-25 at 13:11 +0300, Luca Coelho wrote: On Mon, 2018-05-21 at 21:47 +0200, Arend van Spriel wrote: On 5/18/2018 4:05 PM, Luca Coelho wrote: @@ -781,6 +783,23 @@ int wiphy_register(struct wiphy *wiphy) sband

Re: [RFC 1/3] cfg80211: Add support for HE

On 5/25/2018 12:11 PM, Luca Coelho wrote: +static int > >+nl80211_send_ift_data(struct sk_buff *msg, > >+const struct ieee80211_sband_iftype_data *iftdata) > >make it nl80211_send_iftype_data. Okay, I'll replace all ift instances to iftype. My comment is mainly about

Re: [PATCH 1/3] brcmfmac: allow specifying features per firmware version

On 5/22/2018 3:18 PM, Rafał Miłecki wrote: From: Rafał Miłecki Some features supported by firmware aren't advertised and there is no way for a driver to query them. This includes e.g. monitor mode details. Some firmwares support tagging monitor frames, some build radiotap

Re: [PATCH 2/3] brcmfmac: handle monitor mode marked msgbuf packets

On 5/22/2018 3:18 PM, Rafał Miłecki wrote: From: Rafał Miłecki New Broadcom firmwares mark monitor mode packets using a newly defined bit in the flags field. Use it to filter them out and pass to the monitor interface. These defines were found in bcmmsgbuf.h from SDK. As not

Re: [PATCH 1/3] brcmfmac: allow specifying features per firmware version

On 5/24/2018 10:21 AM, Rafał Miłecki wrote: OT: is your brcmfmac4366c-pcie.bin going to include BCM4366E support? I would think so. I actually tested with 4366E before passing the firmware for verification. Regards, Arend

Re: [PATCH 1/3] brcmfmac: allow specifying features per firmware version

On 5/24/2018 7:27 AM, Rafał Miłecki wrote: On 23.05.2018 09:58, Arend van Spriel wrote: On 5/22/2018 3:18 PM, Rafał Miłecki wrote: From: Rafał Miłecki <ra...@milecki.pl> Some features supported by firmware aren't advertised and there is no way for a driver to query them. This includ

Re: [EXT] Re: [PATCH V2 3/6] mwifiex: support sysfs initiated device coredump

On 5/23/2018 9:54 AM, Kalle Valo wrote: Ganapathi Bhat writes: In V2: return ret; } +EXPORT_SYMBOL_GPL(mwifiex_send_cmd); Instead of exporting 'mwifiex_send_cmd' we can prepare a wrapper for the command 'MWIFIEX_IFACE_WORK_DEVICE_DUMP' in mwifiex module. Let me

Re: [PATCH 1/3] brcmfmac: allow specifying features per firmware version

On 5/22/2018 3:18 PM, Rafał Miłecki wrote: From: Rafał Miłecki Some features supported by firmware aren't advertised and there is no way for a driver to query them. This includes e.g. monitor mode details. Some firmwares support tagging monitor frames, some build radiotap

Re: [PATCH] nl80211: Reject disconnect commands except from conn_owner

On 5/22/2018 12:33 PM, Andrew Zaborowski wrote: On 22 May 2018 at 09:53, Arend van Spriel <arend.vanspr...@broadcom.com> wrote: On 5/22/2018 2:46 AM, Andrew Zaborowski wrote: Reject NL80211_CMD_DISCONNECT, NL80211_CMD_DISASSOCIATE, NL80211_CMD_DEAUTHENTICATE and NL80211_CMD_ASSOCIATE co

Re: [PATCH] nl80211: Reject disconnect commands except from conn_owner

On 5/8/2018 5:05 PM, Denis Kenzior wrote: Hi Arend, Sure. I guess we all have been there kicking of wpa_s and discovering there is already one running in the background. I am just a bit squeamish to change the behavior like this. H. Is wpa_s already using SOCKET_OWNER. If so, I might

Re: [PATCH] nl80211: Reject disconnect commands except from conn_owner

On 5/22/2018 10:21 AM, Johannes Berg wrote: On Tue, 2018-05-22 at 09:53 +0200, Arend van Spriel wrote: On 5/22/2018 2:46 AM, Andrew Zaborowski wrote: Reject NL80211_CMD_DISCONNECT, NL80211_CMD_DISASSOCIATE, NL80211_CMD_DEAUTHENTICATE and NL80211_CMD_ASSOCIATE commands from clients other than

[PATCH 3/3] nl80211: Update ERP info using NL80211_CMD_UPDATE_CONNECT_PARAMS

;vidyulla...@codeaurora.org> [arend: extended fils-sk kernel doc and added check in wiphy_register()] Reviewed-by: Jithu Jance <jithu.ja...@broadcom.com> Reviewed-by: Eylon Pedinovsky <eylon.pedinov...@broadcom.com> Signed-off-by: Arend van Spriel <arend.vanspr...@broadcom.com> --- inc

[PATCH 1/3] cfg80211: use separate struct for fils parameters

Put FILS related parameters into their own struct definition so it can be reused for roam events in subsequent change. Reviewed-by: Jithu Jance <jithu.ja...@broadcom.com> Reviewed-by: Eylon Pedinovsky <eylon.pedinov...@broadcom.com> Signed-off-by: Arend van Spriel <arend.vanspr.

[PATCH 2/3] nl80211: add FILS related parameters to ROAM event

In case of FILS shared key offload the parameters can change upon roaming of which user-space needs to be notified. Reviewed-by: Jithu Jance <jithu.ja...@broadcom.com> Reviewed-by: Eylon Pedinovsky <eylon.pedinov...@broadcom.com> Signed-off-by: Arend van Spriel <arend.vanspr.

[PATCH 0/3] nl80211: support offloading FILS-SK roaming scenarios

branch of the mac80211-next repository. Arend van Spriel (2): cfg80211: use separate struct for fils parameters nl80211: add FILS related parameters to ROAM event Vidyullatha Kanchanapally (1): nl80211: Update ERP info using NL80211_CMD_UPDATE_CONNECT_PARAMS include/net/cfg80211.h | 51

Re: [PATCH] nl80211: Reject disconnect commands except from conn_owner

On 5/22/2018 2:46 AM, Andrew Zaborowski wrote: Reject NL80211_CMD_DISCONNECT, NL80211_CMD_DISASSOCIATE, NL80211_CMD_DEAUTHENTICATE and NL80211_CMD_ASSOCIATE commands from clients other than the connection owner set in the connect, authenticate or associate commands, if it was set. The main

Re: [PATCH] cfg80211: Fix support for flushing old scan results

On 5/18/2018 9:00 PM, Denis Kenzior wrote: Hi Arend, On 05/18/2018 01:54 PM, Arend van Spriel wrote: On 5/18/2018 6:47 PM, Denis Kenzior wrote: Hi Johannes, On 05/18/2018 03:13 AM, Johannes Berg wrote: On Fri, 2018-05-11 at 09:48 -0700, Tim Kourt wrote: __cfg80211_bss_expire function

Re: [RFC 1/3] cfg80211: Add support for HE

On 5/18/2018 4:05 PM, Luca Coelho wrote: From: Luca Coelho Add support for the HE in cfg80211 and also add userspace API to nl80211 to send rate information out, conforming with P802.11ax_D1.4. A couple of things changed in D2.0 so does it make sense to introduce

Re: [PATCH] cfg80211: Fix support for flushing old scan results

On 5/18/2018 6:47 PM, Denis Kenzior wrote: Hi Johannes, On 05/18/2018 03:13 AM, Johannes Berg wrote: On Fri, 2018-05-11 at 09:48 -0700, Tim Kourt wrote: __cfg80211_bss_expire function was incorrectly used to flush the BSS entries from the previous scan results, causing NL80211_SCAN_FLAG_FLUSH

Re: [PATCH 2/2] cfg80211: release station info tidstats where needed

On 5/18/2018 11:47 AM, Johannes Berg wrote: From: Johannes Berg <johannes.b...@intel.com> This fixes memory leaks in cases where we got the station info but failed sending it out properly. Reviewed-by: Arend van Spriel <arend.vanspr...@broadcom.com> Fixes: 8689c051a20

Re: [RESEND PATCH] cfg80211: dynamically allocate per-tid stats for station info

On 5/18/2018 11:25 AM, Johannes Berg wrote: On Thu, 2018-05-10 at 13:50 +0200, Arend van Spriel wrote: Here an alternative approach. Currently the only cfg80211-based driver providing per-tid stats is mac80211. This patch only changes mac80211 and the other driver can keep using stack

Re: [PATCH V3 0/5] Update brcm firmware files

On 5/18/2018 9:04 AM, Hans de Goede wrote: Hi, On 15-05-18 10:43, Arend van Spriel wrote: On 5/14/2018 2:05 PM, Josh Boyer wrote: n Mon, May 14, 2018 at 6:11 AM Arend van Spriel < arend.vanspr...@broadcom.com> wrote: On 3/16/2018 3:08 PM, Chi-Hsien Lin wrote: Update brcm firmware

Re: ACS ACR122U not working: pn533_usb 1-1:1.0: NFC: Couldn't poweron...

On 5/17/2018 6:46 PM, Greg KH wrote: On Thu, May 17, 2018 at 06:40:04PM +0200, Greg KH wrote: Adding the network and NFC developers as this really is a NFC driver bug, not a USB core issue... On Thu, May 17, 2018 at 04:12:17PM +0200, Greg KH wrote: On Thu, May 17, 2018 at 02:10:57PM +0100,

Re: [PATCH V2 3/6] mwifiex: support sysfs initiated device coredump

On 5/16/2018 3:50 PM, Kalle Valo wrote: Arend van Spriel <arend.vanspr...@broadcom.com> writes: Since commit 3c47d19ff4dc ("drivers: base: add coredump driver ops") it is possible to initiate a device coredump from user-space. This patch adds support for it adding the .c

[PATCH V2 5/6] brcmfmac: trigger memory dump upon firmware halt signal

From: Franky Lin <franky@broadcom.com> PCIe dongle firmware signals a halt/trap through mailbox interrupt. Trigger a memory dump upon receiving such signal could help to provide useful information for issue debug. Reviewed-by: Arend van Spriel <arend.vanspr...@broadcom.com>

[PATCH V2 1/6] brcmfmac: move ALLFFMAC variable in flowring module

The only user of ALLFFMAC is the flowring module so no need to expose it in a header file. Reviewed-by: Hante Meuleman <hante.meule...@broadcom.com> Reviewed-by: Pieter-Paul Giesberts <pieter-paul.giesbe...@broadcom.com> Reviewed-by: Franky Lin <franky@broadcom.com> Signed

[PATCH V2 6/6] brcmfmac: trigger memory dump on SDIO firmware halt message

From: Franky Lin <franky@broadcom.com> Attempt to dump dongle memory for debug upon receiving firmware halt message through dongle to host mail box interrupt. Reviewed-by: Arend van Spriel <arend.vanspr...@broadcom.com> Signed-off-by: Franky Lin <franky@broadcom.com> Si

[PATCH V2 0/6] brcmfmac: coredump functionality and fixes

present since v4.17-rc3: commit ed4564bab4fb19fe4ec0beabe29754e380f9 Author: Arend van Spriel <aspr...@gmail.com> Date: Sun Apr 8 23:57:07 2018 +0200 drivers: change struct device_driver::coredump() return type to void This patch is not in w-d-next yet. Arend van Spr

[PATCH V2 4/6] brcmfmac: validate user provided data for memdump before copying

e data is always valid and should perform a check before copying. Reviewed-by: Arend van Spriel <arend.vanspr...@broadcom.com> Signed-off-by: Franky Lin <franky@broadcom.com> Signed-off-by: Arend van Spriel <arend.vanspr...@broadcom.com> --- drivers/net/wireless/broadcom/brcm8021

[PATCH V2 3/6] mwifiex: support sysfs initiated device coredump

Signed-off-by: Arend van Spriel <arend.vanspr...@broadcom.com> --- V2: - export mwifiex_send_cmd() needed by mwifiex_usb.ko. --- drivers/net/wireless/marvell/mwifiex/cmdevt.c | 1 + drivers/net/wireless/marvell/mwifiex/debugfs.c | 31 +- drivers/net/wireless/marvel

[PATCH V2 2/6] brcmfmac: add support for sysfs initiated coredump

e Meuleman <hante.meule...@broadcom.com> Reviewed-by: Pieter-Paul Giesberts <pieter-paul.giesbe...@broadcom.com> Reviewed-by: Franky Lin <franky@broadcom.com> Signed-off-by: Arend van Spriel <arend.vanspr...@broadcom.com> --- drivers/net/wireless/broadcom/brcm80211/brcmfmac/bc

Re: [PATCH 4/8] mwifiex: support sysfs initiated device coredump

is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Arend-van-Spriel/brcmfmac-coredump-functionality-and-fixes/20180515-233022 config: i386-allmodconfig (attached as .config) compiler: gcc-7 (Debian 7.3.0-16) 7.3.0

Re: Research + questions on brcmfmac and support for monitor mode

On 5/15/2018 2:29 PM, Rafał Miłecki wrote: I'm interested in adding support for monitor mode to the brcmfmac. I did some early research on firmware capabilities & behavior using various firmwares I could find for my devices: 43602a1, 4366b1, 4366c0 (BCM4366 and BCM4366E). I am interested too

Re: [PATCH 5/8] btmrvl: support sysfs initiated firmware coredump

On 5/15/2018 12:02 PM, Kalle Valo wrote: Arend van Spriel <arend.vanspr...@broadcom.com> writes: + Marcel, bt-list On 5/15/2018 11:30 AM, Kalle Valo wrote: Arend van Spriel <arend.vanspr...@broadcom.com> writes: Since commit 3c47d19ff4dc ("drivers: base: add co

Re: [PATCH 0/8] brcmfmac: coredump functionality and fixes

On 5/15/2018 11:32 AM, Kalle Valo wrote: Arend van Spriel <arend.vanspr...@broadcom.com> writes: This series is intended for 4.18: * fix variable initialization found by kbuild bot. * make ALLFFMAC variable static. * support user-space initiated coredump. The first two p

Re: [PATCH 5/8] btmrvl: support sysfs initiated firmware coredump

+ Marcel, bt-list On 5/15/2018 11:30 AM, Kalle Valo wrote: Arend van Spriel <arend.vanspr...@broadcom.com> writes: Since commit 3c47d19ff4dc ("drivers: base: add coredump driver ops") it is possible to initiate a device coredump from user-space. This patch adds support for i

[PATCH 2/8] brcmfmac: move ALLFFMAC variable in flowring module

The only user of ALLFFMAC is the flowring module so no need to expose it in a header file. Reviewed-by: Hante Meuleman <hante.meule...@broadcom.com> Reviewed-by: Pieter-Paul Giesberts <pieter-paul.giesbe...@broadcom.com> Reviewed-by: Franky Lin <franky@broadcom.com> Signed

[PATCH 6/8] brcmfmac: validate user provided data for memdump before copying

e data is always valid and should perform a check before copying. Reviewed-by: Arend van Spriel <arend.vanspr...@broadcom.com> Signed-off-by: Franky Lin <franky@broadcom.com> Signed-off-by: Arend van Spriel <arend.vanspr...@broadcom.com> --- drivers/net/wireless/broadcom/brcm8021

[PATCH 1/8] brcmfmac: fix initialization of struct cfg80211_inform_bss variable

From: Franky Lin <franky@broadcom.com> This patch fixes a sparse warning "Using plain integer as NULL pointer" about cfg80211_inform_bss structure initialization. Reported-by: kbuild test robot <l...@intel.com> Reviewed-by: Arend van Spriel <arend.vanspr...

[PATCH 3/8] brcmfmac: add support for sysfs initiated coredump

e Meuleman <hante.meule...@broadcom.com> Reviewed-by: Pieter-Paul Giesberts <pieter-paul.giesbe...@broadcom.com> Reviewed-by: Franky Lin <franky@broadcom.com> Signed-off-by: Arend van Spriel <arend.vanspr...@broadcom.com> --- drivers/net/wireless/broadcom/brcm80211/brcmfmac/bc

[PATCH 8/8] brcmfmac: trigger memory dump on SDIO firmware halt message

From: Franky Lin <franky@broadcom.com> Attempt to dump dongle memory for debug upon receiving firmware halt message through dongle to host mail box interrupt. Reviewed-by: Arend van Spriel <arend.vanspr...@broadcom.com> Signed-off-by: Franky Lin <franky@broadcom.com> Si

[PATCH 0/8] brcmfmac: coredump functionality and fixes

to coredump functionality are dependent upon a commit present since v4.17-rc3: commit ed4564bab4fb19fe4ec0beabe29754e380f9 Author: Arend van Spriel <aspr...@gmail.com> Date: Sun Apr 8 23:57:07 2018 +0200 drivers: change struct device_driver::coredump() return type to void

[PATCH 5/8] btmrvl: support sysfs initiated firmware coredump

-by: Arend van Spriel <arend.vanspr...@broadcom.com> --- drivers/bluetooth/btmrvl_debugfs.c | 31 --- drivers/bluetooth/btmrvl_drv.h | 2 -- drivers/bluetooth/btmrvl_main.c| 6 -- drivers/bluetooth/btmrvl_sdio.c| 11 --- 4 files changed, 8 i

[PATCH 4/8] mwifiex: support sysfs initiated device coredump

Signed-off-by: Arend van Spriel <arend.vanspr...@broadcom.com> --- drivers/net/wireless/marvell/mwifiex/debugfs.c | 31 +- drivers/net/wireless/marvell/mwifiex/pcie.c| 18 +-- drivers/net/wireless/marvell/mwifiex/sdio.c| 12 ++ drivers/net/wireless

[PATCH 7/8] brcmfmac: trigger memory dump upon firmware halt signal

From: Franky Lin <franky@broadcom.com> PCIe dongle firmware signals a halt/trap through mailbox interrupt. Trigger a memory dump upon receiving such signal could help to provide useful information for issue debug. Reviewed-by: Arend van Spriel <arend.vanspr...@broadcom.com>

Re: [PATCH V3 0/5] Update brcm firmware files

On 5/14/2018 2:05 PM, Josh Boyer wrote: n Mon, May 14, 2018 at 6:11 AM Arend van Spriel < arend.vanspr...@broadcom.com> wrote: On 3/16/2018 3:08 PM, Chi-Hsien Lin wrote: Update brcm firmware files and WHENCE accordingly. Hi firmware-maintainers, It seems this series somehow go

Re: [PATCH V3 0/5] Update brcm firmware files

On 3/16/2018 3:08 PM, Chi-Hsien Lin wrote: Update brcm firmware files and WHENCE accordingly. Hi firmware-maintainers, It seems this series somehow got lost. Can these still be applied. They can be found in the linux-wireless patchwork database. I provided links below. Regards, Arend ---

Re: brcmfmac: Updating Broadcom/Cypress Wifi/BT firmware

On 5/2/2018 8:05 PM, Stefan Wahren wrote: Hi, i wanted to know, if there are any plans to update the Broadcom/Cypress firmware under: https://git.kernel.org/pub/scm/linux/kernel/git/firmware/linux-firmware.git As BCM2835 maintainer i'm interested in the following files:

Re: [PATCH] brcmfmac: add debugfs entry for reading firmware capabilities

On 5/14/2018 7:11 AM, Rafał Miłecki wrote: +/** + * brcmf_cap_read() - expose firmware capabilities to debugfs. Please stick to naming convention brcmf__foo(), ie. brcmf_feat_cap_read(). Will do, thanks! I missed that naming convention because of brcmf_debugfs_fws_stats_read() /

Re: [PATCH] brcmfmac: add debugfs entry for reading firmware capabilities

s, e.g. supported modes, supported standards, power saving details, max BSS-es. Access to all that info is useful for trying new firmwares, comparing them and debugging features AKA bugs. What are you implying :-p ? Some comments below. Reviewed-by: Arend van Spriel <arend.vanspr...@broadcom.com>

Re: [PATCH] brcmfmac: set WIPHY_FLAG_HAVE_AP_SME flag

oesn't have to subscribe to or handle management frames. Some authenticators (e.g. hostapd) were working with brcmfmac thanks to some extra assumptions. This commit clears up the situation. Thanks for this patch. Acked-by: Arend van Spriel <arend.vanspr...@broadcom.com> Signed-off-by: Rafał

[RESEND PATCH] cfg80211: dynamically allocate per-tid stats for station info

From: Arend van Spriel <aspr...@gmail.com> With the addition of TXQ stats in the per-tid statistics the struct station_info grew significantly. This resulted in stack limit warnings like below: CC [M] drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.o drivers/net/wireless/br

[wl-testing/master] build regression in brcmfmac

Since yesterday I get the following build error on wl-testing/master: CC [M] drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.o drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c: In function ‘brcmf_notify_connect_status_ap’:

Re: [PATCH] nl80211: Reject disconnect commands except from conn_owner

On 5/8/2018 2:19 PM, Johannes Berg wrote: On Tue, 2018-05-08 at 14:18 +0200, Arend van Spriel wrote: On 5/7/2018 9:19 PM, Johannes Berg wrote: On Sun, 2018-04-29 at 20:30 +0200, Andrew Zaborowski wrote: On 28 April 2018 at 15:07, Kalle Valo <kv...@codeaurora.org> wrote: Andrew Zabo

Re: [PATCH] nl80211: Reject disconnect commands except from conn_owner

On 5/7/2018 9:19 PM, Johannes Berg wrote: On Sun, 2018-04-29 at 20:30 +0200, Andrew Zaborowski wrote: On 28 April 2018 at 15:07, Kalle Valo wrote: Andrew Zaborowski writes: Reject NL80211_CMD_DISCONNECT, NL80211_CMD_DISASSOCIATE,

Re: [PATCH] brcmfmac: Add support for bcm43364 wireless chipset

+ Kalle (explicitly) On 5/8/2018 9:58 AM, Ulf Hansson wrote: On 4 May 2018 at 08:48, Sean Lanigan wrote: Add support for the BCM43364 chipset via an SDIO interface, as used in e.g. the Murata 1FX module. The BCM43364 uses the same firmware as the BCM43430 (which is already

[PATCH 0/6] brcmfmac: new pcie fw-api support and cleanup

This series contains following: * support for PCIe rev7 firmware api. * include boottime stamp for bss. * check user-space provided P2P DEVICE mac address. The series applies to the master branch of wireless-drivers-next repository. Arend van Spriel (2): brcmfmac: check p2pdev mac

[PATCH 2/6] brcmfmac: reports boottime_ns while informing bss

From: Franky Lin <franky@broadcom.com> Provides a timestamp in bss information so user space can see when the bss info was updated. Since tsf is not available from the dongle events boottime is reported instead. Reported-by: Dmitry Shmidt <dimitr...@google.com> Reviewed-by: Aren

[PATCH 4/6] brcmfmac: constify firmware mapping tables

gned-off-by: Arend van Spriel <arend.vanspr...@broadcom.com> --- drivers/net/wireless/broadcom/brcm80211/brcmfmac/firmware.c | 2 +- drivers/net/wireless/broadcom/brcm80211/brcmfmac/firmware.h | 2 +- drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c | 2 +- drivers/net/wireless/bro

[PATCH 1/6] brcmfmac: check p2pdev mac address uniqueness

ul.giesbe...@broadcom.com> Reviewed-by: Franky Lin <franky@broadcom.com> Signed-off-by: Arend van Spriel <arend.vanspr...@broadcom.com> --- drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/net/wireless/bro

[PATCH 3/6] brcmfmac: use nl80211_band directly to get ieee80211 channel

From: Franky Lin <franky@broadcom.com> The enum nl80211_band used to retrieve wiphy->bands is the same as wiphy->bands->band which is checked by wiphy_register(). So it can be used directly as parameter of ieee80211_channel_to_frequency(). Reviewed-by: Arend van Sprie

[PATCH 6/6] brcmfmac: coarse support for PCIe shared structure rev7

makes brcmfmac compatible with rev7 firmware. Reviewed-by: Arend van Spriel <arend.vanspr...@broadcom.com> Signed-off-by: Franky Lin <franky@broadcom.com> Signed-off-by: Arend van Spriel <arend.vanspr...@broadcom.com> --- .../wireless/broadcom/brcm80211/brcmfmac/msgbuf.h |

[PATCH 5/6] brcmfmac: add hostready indication

From: Franky Lin <franky@broadcom.com> A hostready signal is introduced to inform firmware through mailbox doorbell1 when common ring initialized or D3 exited. Reviewed-by: Arend van Spriel <arend.vanspr...@broadcom.com> Signed-off-by: Franky Lin <franky@broadcom.

Re: [PATCH 9/9] brcmfmac: use request_firmware_nowait2 to load firmware without warnings

On 4/20/2018 12:26 PM, Kalle Valo wrote: Andres Rodriguez writes: This reduces the unnecessary spew when trying to load optional firmware: "Direct firmware load for ... failed with error -2" So what happened with the request_firmware_nowarn() api (discussed in another

Re: [PATCH v2 4/4] ath10k: Enable sta idle power save

On 4/20/2018 9:21 AM, Sebastian Gottschall wrote: Yes this is WIFI chip set level power-save(based on idleness) and not related to protocol power save. FW will turn off/scale down the resources(clock/rails) based on opportunity(when ever idle mode is detected). This power save is mostly done

Re: [PATCH v2 4/4] ath10k: Enable sta idle power save

On 4/18/2018 3:16 PM, Kalle Valo wrote: (fixing top posting) govi...@codeaurora.org writes: On 2018-04-18 12:36, Sebastian Gottschall wrote: from my point of view powersave should be optional and not forced. consider : iw dev set power_save on/off so there is already a config option made

Re: [PATCH 2/2] ath10k: support MAC address randomization in scan

+ Johannes (to confirm/correct my understanding regarding "supported commands") On 4/18/2018 4:35 AM, Dan Williams wrote: On Tue, 2018-04-17 at 15:26 -0700, Brian Norris wrote: On Tue, Apr 17, 2018 at 2:49 PM, Arend van Spriel <arend.vanspr...@broadcom.com> wrote: On 4/17/201

Re: [PATCH 2/2] ath10k: support MAC address randomization in scan

On 4/17/2018 6:07 PM, Brian Norris wrote: On Tue, Apr 17, 2018 at 10:22:13AM +0200, Arend van Spriel wrote: On 4/17/2018 2:28 AM, Brian Norris wrote: It looks like the status quo for looking for SCHED_SCAN support is to check if NL80211_CMD_START_SCHED_SCAN shows up in the command support list

Re: Driver crashes on resume after suspend

+ linux-wireless On 4/17/2018 12:02 AM, Carl-Erik Kopseng wrote: I have a BCM4350 on my Ubuntu 18.04 system. Until today, I could never suspend my computer, as the driver brcmfmac would crash on resume (looking in dmesg) and only a reboot would make the device reappear. Today, I found a

Re: [PATCH 2/2] ath10k: support MAC address randomization in scan

On 4/17/2018 2:28 AM, Brian Norris wrote: Hi, On Mon, Apr 16, 2018 at 02:32:47PM +0300, Kalle Valo wrote: cjhu...@codeaurora.org writes: On 2018-04-14 05:13, Arend van Spriel wrote: On 4/13/2018 1:28 PM, Kalle Valo wrote: cjhu...@codeaurora.org writes: + if (test_bit

Re: [PATCH 2/2] mt7601u: run calibration works after finishing scanning

On 4/14/2018 12:56 PM, Stanislaw Gruszka wrote: On Fri, Apr 13, 2018 at 11:06:13AM -0700, Jakub Kicinski wrote: >On Fri, 13 Apr 2018 16:44:38 +0200, Stanislaw Gruszka wrote: > >When finishing scanning we switch to operational channel sill with > >SCANNING flag. This mean that we never perform

Re: [PATCH 2/2] ath10k: support MAC address randomization in scan

On 4/13/2018 1:28 PM, Kalle Valo wrote: cjhu...@codeaurora.org writes: + if (test_bit(WMI_SERVICE_SPOOF_MAC_SUPPORT, ar->wmi.svc_map)) { + ret = ath10k_wmi_scan_prob_req_oui(ar, ar->mac_addr); + if (ret) { + ath10k_err(ar, "failed to set

Re: second wifi card enforce CN reg dom

It seems you are already pissed off, but could you please reply inline instead of top posting. Its a drag to scroll up and down. On 4/12/2018 7:05 PM, solsTiCe d'Hiver wrote: Hi. I thought I made myself clear. I leave in France. My system(s) is/are set up to use FR as default regulatory

Re: second wifi card enforce CN reg dom

On 4/12/2018 5:52 PM, Dan Williams wrote: On Thu, 2018-04-12 at 08:18 -0700, Steve deRosier wrote: On Thu, Apr 12, 2018 at 3:51 AM, Arend van Spriel <arend.vanspr...@broadcom.com> wrote: On 4/12/2018 10:42 AM, solsTiCe d'Hiver wrote: Hi. This is beyond my comprehension that you could

Re: second wifi card enforce CN reg dom

broken everyhting even before I am entering monitor mode for the cards. Well, non issue... sight 2018-04-12 9:48 GMT+02:00 Arend van Spriel <arend.vanspr...@broadcom.com>: On 4/12/2018 9:00 AM, solsTiCe d'Hiver wrote: Nobody cares about this ? Should I report this as a bug to th

Re: second wifi card enforce CN reg dom

On 4/12/2018 9:00 AM, solsTiCe d'Hiver wrote: Nobody cares about this ? Should I report this as a bug to the LKML ? or elsewhere ? to ath9k_htc dev ? to crda dev ? Please. Hi, I do not think nobody cares, but what you describe is actually no issue as far as I can determine. Wifi cards are

Re: iwlwifi-7265-ucode-25.30.14.0.tgz. in Centos 7

On 4/9/2018 6:18 PM, Larry Finger wrote: On 04/08/2018 11:56 PM, Dusan Bruncko wrote: Dear Larry, Thank you for your mail. But concerning to "capa flags index 3", I am not sure. Please look following message receiving for command "ps aux", /usr/bin/abrt-watch-log -F BUG: WARNING: at WARNING:

Re: [PATCH v2] rsi: remove unecessary PTR_ALIGN()s

On 4/6/2018 10:37 AM, Dan Carpenter wrote: The issue here is that we allocate "data" and then set "data = PTR_ALIGN(data, 8);" and then we free the aligned pointer instead of the original pointer. kmalloc() pointers are already ARCH_SLAB_MINALIGN aligned which is 8 or more on everything except

Re: [PATCH net-next v2 2/2] dt: bindings: add new dt entries for brcmfmac

On 4/5/2018 3:10 PM, Kalle Valo wrote: Ulf Hansson <ulf.hans...@linaro.org> writes: On 20 March 2018 at 10:55, Kalle Valo <kv...@codeaurora.org> wrote: Arend van Spriel <arend.vanspr...@broadcom.com> writes: If I get it right, you mean something like this:

Re: [PATCH 07/12] brcmfmac: Convert ALLFFMAC to ether_broadcast_addr

-by: Arend van Spriel <arend.vanspr...@broadcom.com> Signed-off-by: Joe Perches <j...@perches.com> --- drivers/net/wireless/broadcom/brcm80211/brcmfmac/common.c | 2 -- drivers/net/wireless/broadcom/brcm80211/brcmfmac/common.h | 2 -- drivers/net/wireless/broadcom/brcm80

Re: Wi-Fi Disconnection on Suspend for no wowlan triggers

On 4/5/2018 9:59 AM, Johannes Berg wrote: On Thu, 2018-04-05 at 09:41 +0200, Arend van Spriel wrote: So for a full-mac device or a mac80211 device with certain offloads (that we may already have, eg. 4way-hs offloads) you could keep up the connection for a while, but if it is receiving data

Re: Wi-Fi Disconnection on Suspend for no wowlan triggers

On 4/3/2018 6:55 PM, Steve deRosier wrote: Hi Sunil, On Tue, Apr 3, 2018 at 5:39 AM, Sunil Dutt Undekari wrote: Hi All , I would like to discuss on the commit 8125696991194aacb1173b6e8196d19098b44e17 (cfg80211/mac80211: disconnect on suspend) which triggers the STA

Re: [PATCH] nl80211: Update ERP info using NL80211_CMD_UPDATE_CONNECT_PARAMS

On 4/4/2018 12:36 PM, Johannes Berg wrote: Hi, Started working on this and actually the "weird flags thing" is done for a reason. Maybe the reason was because it is done like that in the CMD_CONNECT case, but the better reason is that we need to return -EINVAL for "no-fils-offload-support,

Re: [PATCH] nl80211: Update ERP info using NL80211_CMD_UPDATE_CONNECT_PARAMS

On 3/29/2018 1:31 PM, Arend van Spriel wrote: So yeah, I'd argue that what the patch needed was somebody taking a critical look at my review ;-) And perhaps fixing the weird flags thing I pointed out. Yup. That made sense. Hi Johannes, Started working on this and actually the "weird

Re: Request for brcmfmac4366c-pcie.bin

On 4/4/2018 4:12 AM, Hubert Wiedeke wrote: On Mon, 19 Feb 2018 12:51:07 +0100 Arend van Spriel <arend.vanspr...@broadcom.com> wrote: On 2/17/2018 9:19 AM, Hubert Wiedeke wrote: Hi, I'd like to ask about the current status of 4366c firmware preparation for linux-firmware.git . Is it

Re: [PATCH] brcmfmac: add support for BCM4366E chipset

On 4/3/2018 12:17 PM, Rafał Miłecki wrote: On 3 April 2018 at 10:22, Arend van Spriel <arend.vanspr...@broadcom.com> wrote: [...] My first reaction to this email needed to some cooldown time, but managed to swallow it. I'm sorry you keep reacting to my e-mails/patches that way. I

Re: [PATCH] brcmfmac: fix firmware request processing if nvram load fails

On 4/3/2018 12:04 PM, Kalle Valo wrote: Arend van Spriel <arend.vanspr...@broadcom.com> writes: When nvram loading fails a double free occurred. Fix this and reorg the code a little. Fixes: commit d09ae51a4b67 ("brcmfmac: pass struct in brcmf_fw_get_firmwares()") This s

[PATCH] brcmfmac: add support for BCM4366E chipset

From: Dan Haab <dh...@luxul.com> BCM4366E is a wireless chipset with a BCM43664 ChipCommon. It's supported by the same firmware as 4366c0. Signed-off-by: Dan Haab <dan.h...@luxul.com> [arend: rebase patch and remove unnecessary definition] Signed-off-by: Arend van Spriel &

Re: [PATCH] brcmfmac: add support for BCM4366E chipset

On 3/30/2018 9:26 AM, Rafał Miłecki wrote: On 23 March 2018 at 10:31, Arend van Spriel <arend.vanspr...@broadcom.com> wrote: On 3/22/2018 4:58 PM, Dan Haab wrote: From: Dan Haab <dh...@luxul.com> BCM4366E is a wireless chipset with a BCM43664 ChipCommon. It's supported by the s

[PATCH] brcmfmac: fix firmware request processing if nvram load fails

When nvram loading fails a double free occurred. Fix this and reorg the code a little. Fixes: commit d09ae51a4b67 ("brcmfmac: pass struct in brcmf_fw_get_firmwares()") Reported-by: Dan Carpenter <dan.carpen...@oracle.com> Signed-off-by: Arend van Spriel <arend.vanspr...@broadco

<    1   2   3   4   5   6   7   8   9   10   >