Re: [PATCH RFC 2/2] brcmfmac: add brcmf_err_pub macro for better error messages

On 20-1-2017 12:17, Rafał Miłecki wrote: > On 01/20/2017 11:26 AM, Arend Van Spriel wrote: >> On 18-1-2017 15:27, Rafał Miłecki wrote: >>> From: Rafał Miłecki <ra...@milecki.pl> >>> >>> This macro accepts an extra argument of struct brcmf_pub pointe

Re: [PATCH RFC 1/2] brcmfmac: merge two brcmf_err macros into one

On 20-1-2017 11:58, Rafał Miłecki wrote: > On 20 January 2017 at 11:14, Arend Van Spriel > <arend.vanspr...@broadcom.com> wrote: >> On 20-1-2017 11:13, Arend Van Spriel wrote: >>> On 18-1-2017 15:27, Rafał Miłecki wrote: >>>> From: Rafał Miłecki <ra...@mil

Re: [PATCH RFC 2/2] brcmfmac: add brcmf_err_pub macro for better error messages

On 18-1-2017 15:27, Rafał Miłecki wrote: > From: Rafał Miłecki > > This macro accepts an extra argument of struct brcmf_pub pointer. It > allows referencing struct device and printing error using dev_err. This > is very useful on devices with more than one wireless card

Re: [PATCH] brcmfmac: drop duplicated core selection from brcmf_pcie_attach

On 19-1-2017 10:51, Rafał Miłecki wrote: > From: Rafał Miłecki <ra...@milecki.pl> > > It was left after reworking PCIe reset in commit 07fe2e38c7fd > ("brcmfmac: Reset PCIE devices after recognition."). > > Cc: Hante Meuleman <hante.meule...@broadcom.com>

Re: [PATCH RFC 1/2] brcmfmac: merge two brcmf_err macros into one

On 20-1-2017 11:13, Arend Van Spriel wrote: > On 18-1-2017 15:27, Rafał Miłecki wrote: >> From: Rafał Miłecki <ra...@milecki.pl> >> >> This allows simplifying the code by adding a simple IS_ENABLED check for >> CONFIG_BRCMDB symbol. Actually it should be CONFIG_BR

Re: [PATCH RFC 1/2] brcmfmac: merge two brcmf_err macros into one

On 18-1-2017 15:27, Rafał Miłecki wrote: > From: Rafał Miłecki <ra...@milecki.pl> > > This allows simplifying the code by adding a simple IS_ENABLED check for > CONFIG_BRCMDB symbol. Nice! Acked-by: Arend van Spriel <arend.vanspr...@broadcom.com> > Signed-off-by: Rafa

Re: [PATCH v2 01/13] wil6210: add sysfs file for FTM calibration

On 19-1-2017 13:36, Lior David wrote: > On 1/19/2017 2:24 PM, Valo, Kalle wrote: >> Maya Erez writes: >> >>> From: Lior David >>> >>> In fine timing measurements, the calculation is affected by >>> 2 parts: timing of packets over the air,

Re: [PATCH] nl80211: fix validation of scheduled scan info for wowlan netdetect

On 19-1-2017 13:00, Luca Coelho wrote: > On Thu, 2017-01-19 at 10:01 +0000, Arend van Spriel wrote: >> For wowlan netdetect a separate limit is defined for the number of >> matchsets. Currently, this limit is ignored and the regular limit >> for scheduled scan matchs

[PATCH] nl80211: fix validation of scheduled scan info for wowlan netdetect

ed-off-by: Arend van Spriel <arend.vanspr...@broadcom.com> --- net/wireless/nl80211.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/net/wireless/nl80211.c b/net/wireless/nl80211.c index b4e7bdd..df0675d 100644 --- a/net/wireless/nl80211.c +++ b/net/wirele

Re: [PATCH V2 4/4] brcmfmac: rename brcmf_bus_start function to brcmf_bus_started

sn't undoing things done there. This function > is supposed to be called by bus specific code when the bus is ready. Acked-by: Arend van Spriel <arend.vanspr...@broadcom.com> > Signed-off-by: Rafał Miłecki <ra...@milecki.pl> > --- > V2: Use "brcmf_bus_started" name instead of

Re: [PATCH v3] brcmfmac: fix incorrect event channel deduction

d a couple of kernel versions back and only a performance regression so seems ok to let this go in 4.11 for now and backport as needed for stable later. Acked-by: Arend van Spriel <arend.vanspr...@broadcom.com> > Signed-off-by: Gavin Li <g...@thegavinli.com> > Cc: <sta...@vger.ker

Re: [PATCH 1/2] brcmfmac: rename brcmf_bus_start function to brcmf_attach_phase2

On 18-1-2017 10:51, Rafał Miłecki wrote: > On 18 January 2017 at 10:25, Arend Van Spriel > <arend.vanspr...@broadcom.com> wrote: >> On 17-1-2017 20:23, Rafał Miłecki wrote: >>> From: Rafał Miłecki <ra...@milecki.pl> >>> >>> This change i

Re: [PATCH 2/2] brcmfmac: move function declarations to proper headers

On 18-1-2017 10:06, Rafał Miłecki wrote: > On 18 January 2017 at 09:58, Arend Van Spriel > <arend.vanspr...@broadcom.com> wrote: >> On 17-1-2017 17:34, Rafał Miłecki wrote: >>> From: Rafał Miłecki <ra...@milecki.pl> >>> >>> Function b

Re: [PATCH 2/2] brcmfmac: drop brcmf_bus_detach and inline its code

and simplify the code. > There also isn't brcmf_bus_attach function which one could expect so it > looks more consistent this way. Acked-by: Arend van Spriel <arend.vanspr...@broadcom.com> > Signed-off-by: Rafał Miłecki <ra...@milecki.pl> > --- > drivers/net/

Re: [PATCH 1/2] brcmfmac: rename brcmf_bus_start function to brcmf_attach_phase2

On 17-1-2017 20:23, Rafał Miłecki wrote: > From: Rafał Miłecki > > This change intends to make init/attach process easier to follow. > > What driver were doing in brcmf_bus_start wasn't bus specific at all and > function brcmf_bus_stop wasn't undoing things done there. It

Re: [PATCH 2/2] brcmfmac: move function declarations to proper headers

On 17-1-2017 17:34, Rafał Miłecki wrote: > From: Rafał Miłecki > > Function brcmf_c_set_joinpref_default is in common.c, so move it to the > related header. All other (touched) ones are in core.c so take them out > of the bus.h. > I just needed to include bus.h to have enum

Re: [PATCH 1/2] brcmfmac: drop unneeded function declarations from headers

p from header as well. brcmf_c_prec_enq has been long gone (3.18 or so). Thanks for the cleanup. Acked-by: Arend van Spriel <arend.vanspr...@broadcom.com> > Signed-off-by: Rafał Miłecki <ra...@milecki.pl> > --- > drivers/net/wireless/broadcom/brcm80211/brcmfmac/bus.h

[RFC V2 0/5] cfg80211: support multiple scheduled scans

branch of the mac80211-next repository. Arend van Spriel (5): nl80211: allow multiple active scheduled scan requests nl80211: include request id in scheduled scan event messages cfg80211: add request id parameter to .sched_scan_stop() signature cfg80211: add request id

[RFC V2 4/5] cfg80211: add request id to cfg80211_sched_scan_results() api

Lin <franky@broadcom.com> Signed-off-by: Arend van Spriel <arend.vanspr...@broadcom.com> --- drivers/net/wireless/ath/ath6kl/wmi.c | 2 +- .../broadcom/brcm80211/brcmfmac/cfg80211.c | 2 +- drivers/net/wireless/marvell/mwifiex/sta_cmdresp.c | 2 +-

[RFC V2 1/5] nl80211: allow multiple active scheduled scan requests

NL80211_ATTR_SCHED_SCAN_MULTI to indicate support. If not the request is treated as a legacy scan. Reviewed-by: Hante Meuleman <hante.meule...@broadcom.com> Reviewed-by: Pieter-Paul Giesberts <pieter-paul.giesbe...@broadcom.com> Reviewed-by: Franky Lin <franky@broadcom.com> Signed

[RFC V2 2/5] nl80211: include request id in scheduled scan event messages

com> Signed-off-by: Arend van Spriel <arend.vanspr...@broadcom.com> --- net/wireless/nl80211.c | 23 +++ net/wireless/nl80211.h | 3 +-- net/wireless/scan.c| 5 ++--- 3 files changed, 14 insertions(+), 17 deletions(-) diff --git a/net/wireless/nl80211.c b/net/wireless

[RFC V2 5/5] cfg80211: add request id in cfg80211_sched_scan_stopped{,_rtnl}() api

com> Signed-off-by: Arend van Spriel <arend.vanspr...@broadcom.com> --- drivers/net/wireless/ath/ath6kl/cfg80211.c | 2 +- .../net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c | 2 +- drivers/net/wireless/marvell/mwifiex/cfg80211.c | 6 +++--- drivers/net/wireles

[RFC V2 3/5] cfg80211: add request id parameter to .sched_scan_stop() signature

adcom.com> Reviewed-by: Franky Lin <franky@broadcom.com> Signed-off-by: Arend van Spriel <arend.vanspr...@broadcom.com> --- drivers/net/wireless/ath/ath6kl/cfg80211.c| 2 +- .../net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c | 6 +++--- drivers/net/wireless/ma

Re: [PATCH] brcmfmac: add support for BCM43455 with modalias sdio:c00v02D0dA9BF

pported because the chip itself is already supported (due to BCM4345 > support in the driver). Hopefully Kalle can take this through his tree, ie. wireless-drivers-next. Acked-by: Arend van Spriel <arend.vanspr...@broadcom.com> > Signed-off-by: Martin Blumenstingl <mart

Re: support for Ampak AP6255 (bcm43455c0 with SDIO device ID 0xa9bf)

On 15-1-2017 0:18, Martin Blumenstingl wrote: > Hello, > > I recently got a "Khadas VIM Pro" (see [0] for more information) > The "Pro" version comes with an AP6255 wifi chipset. > Looking at the vendor firmware this seems to be a bcm43455 device: [1] > > To my surprise brcmfmac from a mainline

Re: linux driver bcm4311 failure

On 14-1-2017 11:15, message wrote: > On 2017-01-02 20:04, Arend van Spriel wrote: >> On 02-01-17 15:33, message wrote: >>> On 2016-12-30 19:46, message wrote: >>>> On 2016-09-17 08:11, message wrote: >>>>> On 2016-09-09 07:57, Arend Van Spriel wrote: &

Re: [RFC 4/5] cfg80211: add request id to cfg80211_sched_scan_results() api

On 13-1-2017 13:47, Arend van Spriel wrote: > Have proper request id filled in the SCHED_SCAN_RESULTS notification > toward user-space by having the driver provide it through the api. > > Reviewed-by: Hante Meuleman <hante.meule...@broadcom.com> > Reviewed-by: Pieter-P

[RFC 1/5] nl80211: allow multiple active scheduled scan requests

NL80211_ATTR_SCHED_SCAN_MULTI to indicate support. If not the request is treated as a legacy scan. Reviewed-by: Hante Meuleman <hante.meule...@broadcom.com> Reviewed-by: Pieter-Paul Giesberts <pieter-paul.giesbe...@broadcom.com> Reviewed-by: Franky Lin <franky@broadcom.com> Signed

[RFC 4/5] cfg80211: add request id to cfg80211_sched_scan_results() api

Lin <franky@broadcom.com> Signed-off-by: Arend van Spriel <arend.vanspr...@broadcom.com> --- drivers/net/wireless/ath/ath6kl/wmi.c | 2 +- .../broadcom/brcm80211/brcmfmac/cfg80211.c | 2 +- drivers/net/wireless/marvell/mwifiex/sta_cmdresp.c | 2 +-

[RFC 3/5] cfg80211: add request id parameter to .sched_scan_stop() signature

adcom.com> Reviewed-by: Franky Lin <franky@broadcom.com> Signed-off-by: Arend van Spriel <arend.vanspr...@broadcom.com> --- drivers/net/wireless/ath/ath6kl/cfg80211.c| 2 +- .../net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c | 6 +++--- drivers/net/wireless/ma

[RFC 0/5] cfg80211: support multiple scheduled scans

After sending out the initial RFC for multiple scheduled scan support [1] here a series that deal with it all (I hope) so including events and the driver function call apis. It is applies to the master branch of the mac80211-next repository. Arend van Spriel (5): nl80211: allow multiple active

[RFC 2/5] nl80211: include request id in scheduled scan event messages

com> Signed-off-by: Arend van Spriel <arend.vanspr...@broadcom.com> --- net/wireless/nl80211.c | 23 +++ net/wireless/nl80211.h | 3 +-- net/wireless/scan.c| 5 ++--- 3 files changed, 14 insertions(+), 17 deletions(-) diff --git a/net/wireless/nl80211.c b/net/wireless

[RFC 5/5] cfg80211: add request id in cfg80211_sched_scan_stopped{,_rtnl}() api

com> Signed-off-by: Arend van Spriel <arend.vanspr...@broadcom.com> --- drivers/net/wireless/ath/ath6kl/cfg80211.c | 2 +- .../broadcom/brcm80211/brcmfmac/cfg80211.c | 2 +- drivers/net/wireless/marvell/mwifiex/cfg80211.c| 6 ++--- drivers/net/wireless/marvell/mw

Re: [PATCH 3/3] cfg80211: Specify the reason for connect timeout

On 9-1-2017 18:53, Jouni Malinen wrote: > From: Purushottam Kushwaha > > This enhances the connect timeout API to also carry the reason for the > timeout. These reason codes for the connect time out are represented by > enum nl80211_timeout_reason and are passed to

Re: [PATCH v3 1/3] cfg80211: Add support to sched scan to report better BSSs

On 9-1-2017 18:53, Jouni Malinen wrote: > From: vamsi krishna > > Enhance sched scan to support option of finding a better BSS while in > connected state. Firmware scans the medium and reports when it finds a > known BSS which has better RSSI than the current connected

Re: [PATCH] cfg80211: size various nl80211 messages correctly

On 9-1-2017 11:10, Johannes Berg wrote: > From: Johannes Berg > > Ilan reported that sometimes nl80211 messages weren't working if > the frames being transported got very large, which was really a > problem for userspace-to-kernel messages, but prompted me to look > at

Re: [PATCH] RFC: Universal scan proposal

On 9-1-2017 11:48, Johannes Berg wrote: > On Thu, 2017-01-05 at 20:59 +0100, Arend Van Spriel wrote: >> >> From what Dmitry listed I guess there's really only one. > > Ok. I guess I need to go back to that then. > >> Early on in the thread Luca gave some other exa

Re: [PATCH] RFC: Universal scan proposal

On 9-1-2017 11:45, Johannes Berg wrote: > On Thu, 2017-01-05 at 12:45 -0800, Dmitry Shmidt wrote: >> >>> Oh, then again, maybe you're thinking of full-MAC devices - does a >>> roam/autojoin scan really already *imply* a new connection? And if >>> so, do we have to do it that way, or can we remove

Re: [PATCH V6 4/3] brcmfmac: use wiphy_read_of_freq_limits to respect extra limits

On 9-1-2017 9:58, Johannes Berg wrote: > On Sat, 2017-01-07 at 13:58 +0100, Rafał Miłecki wrote: > >>> I indeed prefer to talk about the driver instead of we. Indeed it >>> is true due to the orig_flags behavior although that only seems to >>> involve regulatory code. Could it be that brcmfmac

Re: [PATCH 2/2] brcmfmac: setup wiphy bands after registering it first

and previous patch are too dependent and prefer to have them in a single patch. Despite that for both: Acked-by: Arend van Spriel <arend.vanspr...@broadcom.com> > Signed-off-by: Rafał Miłecki <ra...@milecki.pl> > --- > drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg

Re: [PATCH V6 4/3] brcmfmac: use wiphy_read_of_freq_limits to respect extra limits

On 5-1-2017 11:02, Rafał Miłecki wrote: > On 5 January 2017 at 10:31, Arend Van Spriel > <arend.vanspr...@broadcom.com> wrote: >> On 4-1-2017 22:19, Rafał Miłecki wrote: >>> On 4 January 2017 at 21:07, Arend Van Spriel >>> <arend.vanspr...@broadcom.com> wr

Re: [PATCH] brcmfmac: check if we can support used firmware API version

On 5-1-2017 11:06, Rafał Miłecki wrote: > On 5 January 2017 at 10:50, Arend Van Spriel > <arend.vanspr...@broadcom.com> wrote: >> On 3-1-2017 17:11, Rafał Miłecki wrote: >>> From: Rafał Miłecki <ra...@milecki.pl> >>> >>> Every new firmwa

Re: [PATCH] RFC: Universal scan proposal

On 5-1-2017 14:44, Johannes Berg wrote: > On Thu, 2017-01-05 at 14:39 +0100, Arend Van Spriel wrote: > >> Today we already have roaming offload, right? > > I guess - you defined the BSS selection stuff for it :) Well I was referring to: 3047 WIPHY_FLA

Re: [PATCH] RFC: Universal scan proposal

Merging my draft reply in this one. Hope it still makes sense :-p On 5-1-2017 12:46, Johannes Berg wrote: > >> If we go with approach to use parameters and let FW or MAC80211 >> layer to decide what type of scan to do, > > At that point though, is it even meaningful to ask "what type of scan >

Re: [PATCH] brcmfmac: check if we can support used firmware API version

On 3-1-2017 17:11, Rafał Miłecki wrote: > From: Rafał Miłecki > > Every new firmware API will most likely require changes in our code to > support it. Right now we support 2 versions only. Refuse to init if we > detect newer version. > > Signed-off-by: Rafał Miłecki

Re: [PATCH V6 4/3] brcmfmac: use wiphy_read_of_freq_limits to respect extra limits

On 4-1-2017 22:19, Rafał Miłecki wrote: > On 4 January 2017 at 21:07, Arend Van Spriel > <arend.vanspr...@broadcom.com> wrote: >> On 4-1-2017 18:58, Rafał Miłecki wrote: >>> From: Rafał Miłecki <ra...@milecki.pl> >>> >>> There are some device

Re: [PATCH V6 4/3] brcmfmac: use wiphy_read_of_freq_limits to respect extra limits

On 4-1-2017 18:58, Rafał Miłecki wrote: > From: Rafał Miłecki > > There are some devices (e.g. Netgear R8000 home router) with one chipset > model used for different radios, some of them limited to subbands. NVRAM > entries don't contain any extra info on such limitations and

Re: [PATCH 1/2] dt-bindings: document common IEEE 802.11 frequency properties

On 4-1-2017 15:53, Rafał Miłecki wrote: > On 4 January 2017 at 15:32, Kalle Valo wrote: >> Rafał Miłecki writes: >> >>> On 3 January 2017 at 20:55, Rob Herring wrote: On Wed, Dec 28, 2016 at 04:59:54PM +0100, Rafał Miłecki wrote:

Re: [PATCH V3] brcmfmac: avoid writing channel out of allocated array

oids using channel[index] over and over. > > Fixes: 58de92d2f95e ("brcmfmac: use static superset of channels for wiphy > bands") Acked-by: Arend van Spriel <arend.vanspr...@broadcom.com> > Signed-off-by: Rafał Miłecki <ra...@milecki.pl> > --- > V2: Add extra c

[PATCH] cfg80211: only pass sband to set_mandatory_flags_band()

that. Signed-off-by: Arend van Spriel <arend.vanspr...@broadcom.com> --- Stumbled upon this function and wanted to start the new year lightly. It applies to master branch of mac80211-next repo. Best wishes, Arend --- net/wireless/util.c | 8 1 file changed, 4 insertions(+), 4 deletions(-)

Re: [PATCH next V2] brcmfmac: avoid writing channel out of allocated array

On 4-1-2017 11:40, Rafał Miłecki wrote: > On 4 January 2017 at 10:39, Arend Van Spriel > <arend.vanspr...@broadcom.com> wrote: >> On 3-1-2017 17:49, Rafał Miłecki wrote: >>> From: Rafał Miłecki <ra...@milecki.pl> >>> >>> Our code was

Re: [RFC] nl80211: allow multiple active scheduled scan requests

On 4-1-2017 11:30, Johannes Berg wrote: >> However, we need to prefer something >>> - >>> always preferring the new sched scan could lead to bounces, so we >>> can >>> prefer (1) existing, (2) legacy-single type or (3) new-multi type, >>> but >>> not (4) new sched scan. >> >> Not sure I can

Re: [RFC] nl80211: allow multiple active scheduled scan requests

On 4-1-2017 10:59, Johannes Berg wrote: > On Tue, 2017-01-03 at 13:25 +0100, Arend Van Spriel wrote: >> On 2-1-2017 11:44, Johannes Berg wrote: >>> >>>> + /* >>>> + * allow only one legacy scheduled scan if user-space >>>> +

Re: [PATCH V5 1/3] dt-bindings: document common IEEE 802.11 frequency limit property

On 4-1-2017 7:20, Rafał Miłecki wrote: > Hi Rob, > > On 01/03/2017 11:57 PM, Rafał Miłecki wrote: >> From: Rafał Miłecki >> >> This new file should be used for properties that apply to all wireless >> devices. >> >> Signed-off-by: Rafał Miłecki >> --- >> V2:

Re: [PATCH next V2] brcmfmac: avoid writing channel out of allocated array

On 3-1-2017 17:49, Rafał Miłecki wrote: > From: Rafał Miłecki > > Our code was assigning number of channels to the index variable by > default. If firmware reported channel we didn't predict this would > result in using that initial index value and writing out of array. This >

Re: [PATCH] brcmfmac: avoid writing channel out of allocated array

On 3-1-2017 12:31, Rafał Miłecki wrote: >>> + if (!channel) { >>> + brcmf_err("Firmware reported unexpected channel %d\n", >>> + ch.control_ch_num); >>> + continue; >>> + } >> As stated above something is

Re: [PATCH V4 3/2] brcmfmac: use wiphy_read_of_freq_limits to respect extra limits

What is with the patch numbering, ie. 3/2? On 3-1-2017 12:03, Rafał Miłecki wrote: > From: Rafał Miłecki > > There are some devices (e.g. Netgear R8000 home router) with one chipset > model used for different radios, some of them limited to subbands. NVRAM > entries don't

Re: [RFC] nl80211: allow multiple active scheduled scan requests

On 2-1-2017 11:44, Johannes Berg wrote: > >> +/* >> + * allow only one legacy scheduled scan if user-space >> + * does not indicate multiple scheduled scan support. >> + */ >> +if (!info->attrs[NL80211_ATTR_SCHED_SCAN_MULTI] && >> +

Re: [PATCH V4 2/2] cfg80211: support ieee80211-freq-limit DT property

On 3-1-2017 12:03, Rafał Miłecki wrote: > From: Rafał Miłecki > > This patch adds a helper for reading that new property and applying > limitations or supported channels specified this way. > It may be useful for specifying single band devices or devices that > support only

Re: [PATCH] brcmfmac: avoid writing channel out of allocated array

On 3-1-2017 9:38, Rafał Miłecki wrote: > From: Rafał Miłecki > > Our code was assigning number of channels to the index variable by > default. If firmware reported channel we didn't predict this would > result in using that initial index value and writing out of array. > > Fix

Re: [PATCH V3 2/2] cfg80211: support ieee80211-freq-limit DT property

On 02-01-17 18:52, Johannes Berg wrote: >> +static void wiphy_freq_limits_apply(struct wiphy *wiphy) > [...] >> +if (!wiphy_freq_limits_valid_chan(wiphy, >> chan)) { >> +pr_debug("Disabling freq %d MHz as >> it's out of OF limits\n", >> +

Re: [PATCH 2/2] cfg80211: reg: support ieee80211-(min|max)-center-freq DT properties

On 29-12-16 10:43, Rafał Miłecki wrote: > On 29 December 2016 at 09:57, Arend van Spriel > <arend.vanspr...@broadcom.com> wrote: >> On 28-12-16 22:30, Rafał Miłecki wrote: >>> On 28 December 2016 at 22:28, Rafał Miłecki <zaj...@gmail.com> wrote: >>>> O

Re: [PATCH 2/2] cfg80211: reg: support ieee80211-(min|max)-center-freq DT properties

On 28-12-16 22:30, Rafał Miłecki wrote: > On 28 December 2016 at 22:28, Rafał Miłecki <zaj...@gmail.com> wrote: >> On 28 December 2016 at 22:07, Arend van Spriel >> <arend.vanspr...@broadcom.com> wrote: >>> On 28-12-16 16:59, Rafał Miłecki wrote: >&g

Re: [PATCH 2/2] cfg80211: reg: support ieee80211-(min|max)-center-freq DT properties

On 28-12-16 16:59, Rafał Miłecki wrote: > From: Rafał Miłecki > > They allow specifying hardware limitations of supported channels. This > may be useful for specifying single band devices or devices that support > only some part of the whole band. > E.g. some tri-band routers

Re: [PATCH 1/2] dt-bindings: document common IEEE 802.11 frequency properties

On 28-12-16 16:59, Rafał Miłecki wrote: > From: Rafał Miłecki > > This new file should be used for properties handled at higher level and > so usable with all drivers. > > Signed-off-by: Rafał Miłecki > --- >

Re: [PATCH 2/6] wl1251: Use request_firmware_prefer_user() for loading NVS calibration data

On 24-12-2016 17:52, Pali Rohár wrote: > NVS calibration data for wl1251 are model specific. Every one device with > wl1251 chip has different and calibrated in factory. > > Not all wl1251 chips have own EEPROM where are calibration data stored. And > in that case there is no "standard" place.

Re: [PATCH] brcmfmac: fix spelling mistakes on "Ivalid"

On 23-12-2016 1:43, Colin King wrote: > From: Colin Ian King <colin.k...@canonical.com> > > Trivial fixes to spelling mistake "Ivalid" to "Invalid" in > brcmf_err error messages. Acked-by: Arend van Spriel <arend.vanspr...@broadcom.com> > Signed-o

Re: [PATCH 2/2] net: wireless: fix to uses struct

On 21-12-2016 23:23, Ozgur Karatas wrote: > > The patch fixed to struct uses in reg.c, I think doesn't need to be use to > "struct". > There is dataype not have to logical link and each is different definitons. > > I'm undecided on this patch. I compiled and didn't to errors. There must be

[RFC] nl80211: allow multiple active scheduled scan requests

NL80211_ATTR_SCHED_SCAN_MULTI to indicate support. If not the request is treated as a legacy scan. Cc: Dmitry Shmidt <dimitr...@google.com> Signed-off-by: Arend van Spriel <arend.vanspr...@broadcom.com> --- Hi Johannes, Did a bit of coding on the Universal/multi-scheduled scan idea. Thi

Re: [PATCH v2 2/2] cfg80211: Add support to sched scan to report better BSSs

On 20-12-2016 21:52, Malinen, Jouni wrote: > On Fri, Dec 16, 2016 at 10:56:51AM +0100, Johannes Berg wrote: >> On Thu, 2016-12-15 at 11:06 +, Malinen, Jouni wrote: >>> Maybe the nl80211.h description was not clear enough, but the >>> comments in cfg80211.h should be quite clear on how this was

Re: [PATCH 1/2] brcm: add firmware for the BCM4356 SDIO device

On 19-12-2016 1:28, Rafał Miłecki wrote: > Hi Arend, > > On 18 December 2016 at 21:16, Arend van Spriel > <arend.vanspr...@broadcom.com> wrote: >> This patch adds firmware for the BCM4356 2x2 11ac SDIO device. > > I'm really happy to see Broadcom submitting fir

Re: wl1251 & mac address & calibration data

On 18-12-2016 13:09, Pali Rohár wrote: > On Sunday 18 December 2016 12:54:00 Arend Van Spriel wrote: >> On 18-12-2016 12:04, Pali Rohár wrote: >>> On Sunday 18 December 2016 11:49:53 Arend Van Spriel wrote: >>>> On 16-12-2016 11:40, Pali Rohár wrote: >>>

Re: wl1251 & mac address & calibration data

On 18-12-2016 12:04, Pali Rohár wrote: > On Sunday 18 December 2016 11:49:53 Arend Van Spriel wrote: >> On 16-12-2016 11:40, Pali Rohár wrote: >>> On Friday 16 December 2016 08:25:44 Daniel Wagner wrote: >>>> On 12/16/2016 03:03 AM, Luis R. Rodriguez wrote: &g

Re: wl1251 & mac address & calibration data

On 16-12-2016 11:40, Pali Rohár wrote: > On Friday 16 December 2016 08:25:44 Daniel Wagner wrote: >> On 12/16/2016 03:03 AM, Luis R. Rodriguez wrote: >>> For the new API a solution for "fallback mechanisms" should be >>> clean though and I am looking to stay as far as possible from the >>>

Re: [RFC V3 03/11] nl80211: add support for gscan

On 16-12-2016 11:13, Johannes Berg wrote: > On Wed, 2016-12-14 at 10:01 +0100, Arend Van Spriel wrote: > >> Had to look for "> 16" ;-) > > Sorry. > >> Here an instance of the tab vs. space issue you mentioned. Will go >> over the patch and fix that.

Re: [RFC V3 04/11] nl80211: add driver api for gscan notifications

On 16-12-2016 11:02, Johannes Berg wrote: > >> Not sure what is meant by "through the buckets". > > TBH, I was handwaving because I don't understand this part of gscan > well :-) > >> Referring to your >> remark/question in the "Unversal scan proposal" thread: >> >> """ >> I'm much more worried

[PATCH] nl80211: better describe field in struct nl80211_bss_select_rssi_adjust

The two fields in struct nl80211_bss_select_rssi_adjust did not state their type or unit. Adding documentation. Reported-by: Jouni Malinen <j...@w1.fi> Signed-off-by: Arend van Spriel <arend.vanspr...@broadcom.com> --- include/uapi/linux/nl80211.h | 5 +++-- 1 file changed, 3 inse

[PATCH] nl80211: rework {sched_,}scan event related functions

A couple of functions used with scan events were named with term "send" although they were only preparing the the event message so renamed those. Signed-off-by: Arend van Spriel <arend.vanspr...@broadcom.com> --- net/wireless/nl80211.c | 34

Re: [PATCH 8/8] Makefile: drop -D__CHECK_ENDIAN__ from cflags

| 2 -- > drivers/net/wireless/ath/wil6210/Makefile | 2 -- > drivers/net/wireless/broadcom/brcm80211/brcmfmac/Makefile | 2 -- > drivers/net/wireless/broadcom/brcm80211/brcmsmac/Makefile | 1 - For brcm80211 drivers: Acked-by: Arend van Spriel <arend.vanspr...@broadcom.com> Regards, Arend

Re: wl1251 & mac address & calibration data

On 15-12-2016 16:33, Pali Rohár wrote: > On Thu Dec 15 09:18:44 2016 Kalle Valo wrote: >> (Adding Luis because he has been working on request_firmware() lately) >> >> Pali Rohár writes: >> > So no, there is no argument against... request_firmware()

Re: [RFC V3 04/11] nl80211: add driver api for gscan notifications

On 13-12-2016 17:20, Johannes Berg wrote: > On Mon, 2016-12-12 at 11:59 +0000, Arend van Spriel wrote: >> The driver can indicate gscan results are available or gscan >> operation has stopped. > > This patch is renumbering the previous patches' nl80211 API, which is > be

Re: [RFC V3 03/11] nl80211: add support for gscan

On 13-12-2016 23:29, Johannes Berg wrote: > On Tue, 2016-12-13 at 21:09 +0100, Arend Van Spriel wrote: >> >>> There's a bit of a weird hard-coded restriction to 16 channels too, >>> that's due to the bucket map? >> >> Uhm. Is there? I will check,

Re: [RFC V3 03/11] nl80211: add support for gscan

On 13-12-2016 17:19, Johannes Berg wrote: > On Mon, 2016-12-12 at 11:59 +0000, Arend van Spriel wrote: >> This patch adds support for GScan which is a scan offload feature >> used in Android. > > Found a few places with spaces instead of tabs as indentation, and > spuri

Re: [RFC V3 01/11] nl80211: add reporting of gscan capabilities

On 13-12-2016 17:15, Johannes Berg wrote: > >> +case 14: >> +if (!rdev->wiphy.gscan) { >> +/* done */ >> +state->split_start = 0; >> +break; >> +} >> > > Nit, but I'm not really happy with this - this

Re: [RFC V3 03/11] nl80211: add support for gscan

On 12-12-2016 18:43, Dan Williams wrote: >> + >> +/** >> + * enum nl80211_bucket_band - GScan bucket band selection. > Quite possibly this was already covered and somebody requested you to > change this to the current name. If that's the case, ignore this. Nope. You are the first ;-) > But

[RFC V3 04/11] nl80211: add driver api for gscan notifications

The driver can indicate gscan results are available or gscan operation has stopped. Reviewed-by: Hante Meuleman <hante.meule...@broadcom.com> Reviewed-by: Pieter-Paul Giesberts <pieter-paul.giesbe...@broadcom.com> Reviewed-by: Franky Lin <franky@broadcom.com> Signed-off-by

[RFC V3 06/11] brcmfmac: fix uninitialized field in scheduled scan ssid configuration

-by: Pieter-Paul Giesberts <pieter-paul.giesbe...@broadcom.com> Reviewed-by: Franky Lin <franky@broadcom.com> Signed-off-by: Arend van Spriel <arend.vanspr...@broadcom.com> --- drivers/net/wireless/broadcom/brcm80211/brcmfmac/pno.c | 1 + 1 file changed, 1 insertion(+)

[RFC V3 05/11] brcmfmac: fix memory leak in brcmf_cfg80211_attach()

Lin <franky@broadcom.com> Signed-off-by: Arend van Spriel <arend.vanspr...@broadcom.com> --- drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c

[RFC V3 10/11] brcmfmac: handle gscan events from firmware

Lin <franky@broadcom.com> Signed-off-by: Arend van Spriel <arend.vanspr...@broadcom.com> --- .../broadcom/brcm80211/brcmfmac/cfg80211.c | 200 ++--- .../broadcom/brcm80211/brcmfmac/cfg80211.h | 10 +- .../wireless/broadcom/brcm80211/brcmfmac/fweh.h

[RFC V3 03/11] nl80211: add support for gscan

This patch adds support for GScan which is a scan offload feature used in Android. Reviewed-by: Hante Meuleman <hante.meule...@broadcom.com> Reviewed-by: Pieter-Paul Giesberts <pieter-paul.giesbe...@broadcom.com> Reviewed-by: Franky Lin <franky@broadcom.com> Signed-off-by

[RFC V3 08/11] brcmfmac: report gscan capabilities if firmware supports it

From: Arend van Spriel <ar...@broadcom.com> Fill the gscan capability information in the wiphy structure if it is supported by firmware. The values are hardcoded as it can not be obtained from firmware. Reviewed-by: Hante Meuleman <hante.meule...@broadcom.com> Reviewed-by: Pieter-Pa

[RFC V3 00/11] nl80211: add support for g-scan

nl80211.c - get rid of #if 0 code. - reordered patches resolving compilation issue. V3 - drop support for RTT info in scan results. - cleanup attribute definitions. - add driver implementation for brcmfmac. Arend van Spriel (11): nl80211: add reporting of gscan capabilities nl80211

[RFC V3 11/11] brcmfmac: allow gscan to run concurrent with scheduled scan

r-Paul Giesberts <pieter-paul.giesbe...@broadcom.com> Reviewed-by: Franky Lin <franky@broadcom.com> Signed-off-by: Arend van Spriel <arend.vanspr...@broadcom.com> --- .../broadcom/brcm80211/brcmfmac/cfg80211.c | 12 +- .../broadcom/brcm80211/brcmfmac/cfg80211.h | 2

[RFC V3 09/11] brcmfmac: implement gscan functionality

sberts <pieter-paul.giesbe...@broadcom.com> Reviewed-by: Franky Lin <franky@broadcom.com> Signed-off-by: Arend van Spriel <arend.vanspr...@broadcom.com> --- .../broadcom/brcm80211/brcmfmac/cfg80211.c | 31 .../broadcom/brcm80211/brcmfmac/fwil_types.h |

[RFC V3 02/11] nl80211: rename some notification functions

aming them to nl80211_send_scan_event{,_msg}(). Reviewed-by: Hante Meuleman <hante.meule...@broadcom.com> Reviewed-by: Pieter-Paul Giesberts <pieter-paul.giesbe...@broadcom.com> Reviewed-by: Franky Lin <franky@broadcom.com> Signed-off-by: Arend van Spriel <arend.vanspr...@broadcom.com>

[RFC V3 01/11] nl80211: add reporting of gscan capabilities

From: Arend van Spriel <ar...@broadcom.com> GScan is a scan offload feature used in recent Android releases. This patch adds possibility for wireless device drivers to report their capabilities and provide it to user-space. Reviewed-by: Hante Meuleman <hante.meule...@broadcom.com&

[RFC V3 07/11] brcmfmac: add firmware feature detection for gscan feature

From: Arend van Spriel <ar...@broadcom.com> Detect gscan support in firmware by doing pfn_gscan_cfg iovar with invalid version. Reviewed-by: Hante Meuleman <hante.meule...@broadcom.com> Reviewed-by: Pieter-Paul Giesberts <pieter-paul.giesbe...@broadcom.com> Reviewed-by:

[PATCH for-4.10 2/2] brcmfmac: fix uninitialized field in scheduled scan ssid configuration

-by: Pieter-Paul Giesberts <pieter-paul.giesbe...@broadcom.com> Reviewed-by: Franky Lin <franky@broadcom.com> Signed-off-by: Arend van Spriel <arend.vanspr...@broadcom.com> --- drivers/net/wireless/broadcom/brcm80211/brcmfmac/pno.c | 1 + 1 file changed, 1 insertion(+)

[PATCH for-4.10 0/2] brcmfmac: small fixes for after merge window

-drivers/master after the merge window (fingers crossed). Arend van Spriel (2): brcmfmac: fix memory leak in brcmf_cfg80211_attach() brcmfmac: fix uninitialized field in scheduled scan ssid configuration drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c | 7 +-- drivers/net

[PATCH for-4.10 1/2] brcmfmac: fix memory leak in brcmf_cfg80211_attach()

Lin <franky@broadcom.com> Signed-off-by: Arend van Spriel <arend.vanspr...@broadcom.com> --- drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c

<    6   7   8   9   10   11   12   13   14   15   >