Re: [PATCH 0/2] iw: fixes to Android.mk to include iw in AOSP builds

2015-08-13 Thread Johannes Berg
On Thu, 2015-07-30 at 14:35 -0700, Filipe Brandenburger wrote: Hi, I'm working on including iw on Android AOSP eng builds and it turns out we need some fixes to Android.mk to make it build on a current AOSP tree. We have a very similar patch internally as well (that I was still

Re: [PATCH 0/2] iw: fixes to Android.mk to include iw in AOSP builds

2015-08-13 Thread Filipe Brandenburger
Hi Johannes, On Thu, Aug 13, 2015 at 2:01 AM, Johannes Berg johan...@sipsolutions.net wrote: We have a very similar patch internally as well (that I was still evualating/reviewing) but it was less complete, so I've applied this despite Arik's objections. Thank you! I think that if anyone

Re: [PATCH 0/2] iw: fixes to Android.mk to include iw in AOSP builds

2015-08-13 Thread Johannes Berg
On Thu, 2015-08-13 at 09:55 -0700, Filipe Brandenburger wrote: Long term, considering this is in AOSP and is part of eng/userdebug builds, it's likely to be automatically available in future versions of Android. Yeah, but most vendors don't actually build/run/ship AOSP nor necessarily an

Re: [PATCH 0/2] iw: fixes to Android.mk to include iw in AOSP builds

2015-08-13 Thread Johannes Berg
On Thu, 2015-08-13 at 12:48 -0700, enh wrote: i think you misunderstand what AOSP is. this code is currently in AOSP master, and thus in internal master, and thus in a future release. Great, but as I understand it, vendors are under no obligation to actually ship that code on their

Re: [PATCH 0/2] iw: fixes to Android.mk to include iw in AOSP builds

2015-08-13 Thread Johannes Berg
On Thu, 2015-08-13 at 13:44 -0700, enh wrote: but given that our iw is your iw anyway... i don't understand the situation in which they'd be inconvenienced here? But it's not. We can reasonably expect everyone who actually cares to have local modifications to iw that they aren't publishing

[PATCH 0/2] iw: fixes to Android.mk to include iw in AOSP builds

2015-07-30 Thread Filipe Brandenburger
Hi, I'm working on including iw on Android AOSP eng builds and it turns out we need some fixes to Android.mk to make it build on a current AOSP tree. We already have an Android git repo set up with the iw tree: https://android.googlesource.com/platform/external/iw.git The two patches in this