On Thu, 19 Jul 2007, Jens Axboe wrote:
> On Wed, Jul 18 2007, Andrew Morton wrote:
> > On Mon, 16 Jul 2007 18:15:40 +0200
> > Geert Uytterhoeven <[EMAIL PROTECTED]> wrote:
> >
> > > From: Geert Uytterhoeven <[EMAIL PROTECTED]>
> > >
> > > Add a Disk Storage Driver for the PS3:
> >
> > Your patch
Hello.
> I didn't hear anything from the misc device maintainer (for the FLASH ROM
> Storage Driver).
Actually, I am not acting as a maintainer. I'm not active enough nor
up to date with all the structure of kernel maintainance. So please
don't wait for me.
Actually, I tried a pair of times to
Hi Andrew,
On Wed, 18 Jul 2007, Andrew Morton wrote:
> On Mon, 16 Jul 2007 18:15:40 +0200
> Geert Uytterhoeven <[EMAIL PROTECTED]> wrote:
>
> > From: Geert Uytterhoeven <[EMAIL PROTECTED]>
> >
> > Add a Disk Storage Driver for the PS3:
>
> Your patchset significantly hits powerpc, scsi
On Wed, 18 Jul 2007, Andrew Morton wrote:
> > +struct ps3rom_private {
> > + struct ps3_storage_device *dev;
> > + struct scsi_cmnd *curr_cmd;
> > +};
> > +#define ps3rom_priv(dev) ((dev)->sbd.core.driver_data)
> > +
>
> Someone should invent a keyboard which delivers an electric shock when
On Thu, 19 Jul 2007 10:57:53 +0200 (CEST) Geert Uytterhoeven <[EMAIL
PROTECTED]> wrote:
> Hi Andrew,
>
> On Wed, 18 Jul 2007, Andrew Morton wrote:
> > On Mon, 16 Jul 2007 18:15:40 +0200
> > Geert Uytterhoeven <[EMAIL PROTECTED]> wrote:
> >
> > > From: Geert Uytterhoeven <[EMAIL PROTECTED]
On Thu, 19 Jul 2007 11:02:07 +0200 (CEST) Geert Uytterhoeven <[EMAIL
PROTECTED]> wrote:
> On Wed, 18 Jul 2007, Andrew Morton wrote:
> > > +struct ps3rom_private {
> > > + struct ps3_storage_device *dev;
> > > + struct scsi_cmnd *curr_cmd;
> > > +};
> > > +#define ps3rom_priv(dev) ((dev)->sbd.core
On Thu, 19 Jul 2007 10:57:53 +0200 (CEST),
Geert Uytterhoeven <[EMAIL PROTECTED]> wrote:
> Were .probe()/.remove() made concurrent again? I thought that idea was dropped
> because it caused too many problems?
Well, for a given device, ->probe()/->remove() are locked by dev->sem,
so that there can
On Thu, 19 Jul 2007, Cornelia Huck wrote:
> On Thu, 19 Jul 2007 10:57:53 +0200 (CEST),
> Geert Uytterhoeven <[EMAIL PROTECTED]> wrote:
>
> > Were .probe()/.remove() made concurrent again? I thought that idea was
> > dropped
> > because it caused too many problems?
>
> Well, for a given device, -
On Thu, 19 Jul 2007, Andrew Morton wrote:
> On Thu, 19 Jul 2007 11:02:07 +0200 (CEST) Geert Uytterhoeven <[EMAIL
> PROTECTED]> wrote:
>
> > On Wed, 18 Jul 2007, Andrew Morton wrote:
> > > > +struct ps3rom_private {
> > > > + struct ps3_storage_device *dev;
> > > > + struct scsi_cmnd *
On Thu, Jul 19 2007, Geert Uytterhoeven wrote:
> On Thu, 19 Jul 2007, Andrew Morton wrote:
> > On Thu, 19 Jul 2007 11:02:07 +0200 (CEST) Geert Uytterhoeven <[EMAIL
> > PROTECTED]> wrote:
> >
> > > On Wed, 18 Jul 2007, Andrew Morton wrote:
> > > > > +struct ps3rom_private {
> > > > > + struct
On Thu, 19 Jul 2007 11:39:32 +0200 (CEST) Geert Uytterhoeven <[EMAIL
PROTECTED]> wrote:
> > Oh dear.
> >
> > ps3rom_priv(dev) = host;
> >
> > that's 'orrid. We have an identifier pretending to be a function, only we
> > go and treat it as an lvalue.
> >
> > I mean, C code should look like
Hi Andrew,
On Wed, 18 Jul 2007, Andrew Morton wrote:
> > +struct ps3flash_private {
> > + struct mutex mutex; /* Bounce buffer mutex */
> > +};
> > +#define ps3flash_priv(dev) ((dev)->sbd.core.driver_data)
>
> bzzzt!
Same defense as ps3rom ;-)
> > +static loff_t ps3flash_llseek(st
On Thu, 19 Jul 2007 11:36:31 +0200 (CEST),
Geert Uytterhoeven <[EMAIL PROTECTED]> wrote:
> We have a probe thread that checks for new storage devices and adds them to
> the
> bus with ps3_system_bus_device_register(), which calls device_register().
>
> I guess the actual bus probe() routine gets
On Thu, 19 Jul 2007, Cornelia Huck wrote:
> On Thu, 19 Jul 2007 11:36:31 +0200 (CEST),
> Geert Uytterhoeven <[EMAIL PROTECTED]> wrote:
>
> > We have a probe thread that checks for new storage devices and adds them to
> > the
> > bus with ps3_system_bus_device_register(), which calls device_regist
On Thu, 19 Jul 2007 14:13:33 +0200 (CEST),
Geert Uytterhoeven <[EMAIL PROTECTED]> wrote:
> Any chance this will change? I already added a mutex to ps3disk to protect
> against this.
Probably not in the near future. A mutex looks like a good idea though,
since one never knows (and the driver core
Jeff Garzik wrote:
> Brian King wrote:
>> This patchset enables TCP checksum offload support for IPV4
>> on ibmveth. This completely eliminates the generation and checking of
>> the checksum for packets that are completely virtual and never
>> touch a physical network. A simple TCP_STREAM netperf r
Hi Andrew,
On Thu, 19 Jul 2007, Andrew Morton wrote:
> On Thu, 19 Jul 2007 10:57:53 +0200 (CEST) Geert Uytterhoeven <[EMAIL
> PROTECTED]> wrote:
> > On Wed, 18 Jul 2007, Andrew Morton wrote:
> > > Your patchset significantly hits powerpc, scsi and block. So who gets to
> > > merge this?
ps3disk: use correct bio vector size
This fixes the O_DIRECT corruptions, as reported by Olaf Hering (triggered by
e.g. parted >= 1.8.0).
Signed-off-by: Geert Uytterhoeven <[EMAIL PROTECTED]>
---
drivers/block/ps3disk.c |2 +-
1 files changed, 1 insertion(+), 1 deletion(-)
--- a/drivers/blo
ps3disk: updates after final review:
o Kill KERNEL_SECTOR_SIZE, just hardcode `512' or `>> 9'
o Kill confusing ps3disk_priv() macro, open code it instead
o ps3disk_scatter_gather(): Kill unused variable `sectors'
o Introduce ps3disk_mask_mutex to protect ps3disk_mask
o Minor coding style
ps3rom: updates after final review:
o Kill confusing ps3rom_priv() macro, open code it instead
o kmap_atomic() cannot fail
Signed-off-by: Geert Uytterhoeven <[EMAIL PROTECTED]>
---
drivers/scsi/ps3rom.c | 15 +--
1 files changed, 5 insertions(+), 10 deletions(-)
--- a/drivers/s
ps3flash: updates after final review:
o Kill confusing ps3flash_priv() macro, open code it instead
o ps3flash_llseek(): Add missing locking (using i_mutex)
o Replace do_div_llr() by `/' and `%'
o ps3flash_read(): Use a common return for the error path
o Minor coding style fixes not report
> - d-cache-line-size = <20>; // 32 bytes
> - i-cache-line-size = <20>; // 32 bytes
> - d-cache-size = <2000>; // L1, 8K
> - i-cache-size = <4000>; // L1, 16K
> + d-cach
> I've seen significant network corruption on a PCI network
> card (e1000) with the mpc8272ads; the corruption went away
> when I set CONFIG_NOT_COHERENT_CACHE.
That doesn't mean it's the correct fix. Any idea what the
root cause is?
If you want this patch as a workaround, please document it
in
On Jul 18, 2007, at 11:32 AM, Scott Wood wrote:
> Kumar Gala wrote:
>>> diff --git a/arch/powerpc/boot/dts/mpc8272ads.dts b/arch/powerpc/
>>> boot/dts/mpc8272ads.dts
>>> index 4d09dca..16a77f4 100644
>>> --- a/arch/powerpc/boot/dts/mpc8272ads.dts
>>> +++ b/arch/powerpc/boot/dts/mpc8272ads.dts
>
On Jul 18, 2007, at 3:08 PM, Scott Wood wrote:
> Kumar Gala wrote:
>> On Jul 17, 2007, at 10:28 PM, David Gibson wrote:
>>> Hrm... I for one would be a lot more comfortable with this patch if
>>> you had a theoretical explanation for why it's necessary, in
>>> addition
>>> to the "seems to fix
Arnd Bergmann wrote:
> On Wednesday 18 July 2007, Scott Wood wrote:
>
>>+static void __init pq2fads_setup_arch(void)
>>+{
>>+ struct device_node *np;
>>+ struct resource r;
>>+ u32 *bcsr;
>
>
> bcsr should be __iomem, right?
Oops, yes.
> Did you run your code through sparse?
No, i
> The CPU15 erratum on MPC8xx chips can cause incorrect code execution
> under certain circumstances, where there is a conditional or indirect
> branch in the last word of a page, with a target in the last cache
> line
> of the next page. This patch implements one of the suggested
> workarounds,
Arnd Bergmann wrote:
> On Wednesday 18 July 2007, Scott Wood wrote:
>
>>+static struct cpm_pin mpc8272ads_pins[] = {
>>+ /* SCC1 */
>>+ {3, 30, CPM_PIN_OUTPUT | CPM_PIN_SECONDARY},
>>+ {3, 31, CPM_PIN_INPUT | CPM_PIN_PRIMARY},
>>+
>>+ /* SCC4 */
>>+ {3, 21, CPM_PIN_OU
Roland Dreier <[EMAIL PROTECTED]> wrote on 17.07.2007 19:52:55:
> At a higher level, I'm left wondering why nobody talked about multiple
> EQs during the last months of the 2.6.22 process and now all of a
> sudden it becomes urgent in the last few days of the 2.6.23 merge
> window. That's not real
David Gibson wrote:
> On Wed, Jul 18, 2007 at 11:13:05AM -0500, Scott Wood wrote:
>>Well, no. Even on a given board, it depends on the version of u-boot.
>>
>>There's nothing after enet1addr that the bootwrapper cares about,
>>though, so the only harm is if the device tree has a second network
>
>> + "fsl,cpm-uart";
>> reg = <11a00 20 8000 100>;
>> -current-speed = <1c200>;
> Hmm, how is it supposed to work without speed? I was testing my u-
> boot OF bindings for 82xx and spotted into it.
"c
>>> -device_type = "cpm";
>>> -model = "CPM2";
>>> +compatible = "fsl,mpc8272-cpm", "fsl,cpm2", "fsl,cpm";
>>
>> Does 'fsl,cpm' really mean anything useful?
>
> Yes. It's can't be used on its own to show the complete programming
> model,
So please remove it.
>
Hi Paul,
I did a git-pull this morning but it had a conflict. Should I have
reset it to something?
Thanks,
Mark
___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev
This creates linux/of.h and includes asm/prom.h from it.
We also include linux/of.h from asm/prom.h while we transition.
Signed-off-by: Stephen Rothwell <[EMAIL PROTECTED]>
---
include/asm-powerpc/prom.h | 43 --
include/asm-sparc/prom.h | 46 ---
This creates drivers/of/base.c (depending on CONFIG_OF) and puts
the first trivially common bits from the prom.c files into it.
Signed-off-by: Stephen Rothwell <[EMAIL PROTECTED]>
---
arch/powerpc/Kconfig |3 ++
arch/powerpc/kernel/prom.c | 41 ---
arch/sparc/K
The only difference here is that Sparc uses strncmp to match compatibility
names while PowerPC uses strncasecmp.
Signed-off-by: Stephen Rothwell <[EMAIL PROTECTED]>
---
arch/powerpc/kernel/prom.c | 25 -
arch/sparc/kernel/prom.c | 21 -
arch/sparc
The only change here is that a readlock is taken while the property list
is being traversed on Sparc where it was not taken previously.
Also, Sparc uses strcasecmp to compare property names while PowerPC
uses strcmp.
Signed-off-by: Stephen Rothwell <[EMAIL PROTECTED]>
---
arch/powerpc/kernel/pro
This requires creating dummy of_node_{get,put} routines for sparc and
sparc64. It also adds a read_lock around the parent accesses.
Signed-off-by: Stephen Rothwell <[EMAIL PROTECTED]>
---
arch/powerpc/kernel/prom.c | 21 -
arch/sparc/kernel/prom.c | 13 -
ar
This adds a read_lock around the child/next accesses on Sparc.
Signed-off-by: Stephen Rothwell <[EMAIL PROTECTED]>
---
arch/powerpc/kernel/prom.c | 24
arch/sparc/kernel/prom.c | 14 --
arch/sparc64/kernel/prom.c | 14 --
drivers/of/base.c
This consolidates the routines of_find_node_by_path, of_find_node_by_name,
of_find_node_by_type and of_find_compatible_device. Again, the comparison
of strings are done differently by Sparc and PowerPC and also these add
read_locks around the iterations.
Signed-off-by: Stephen Rothwell <[EMAIL PR
This moves all the common parts for the Sparc, Sparc64 and PowerPC
of_device.c files into drivers/of/device.c.
Apart from the simple move, Sparc gains of_match_node() and a call to
of_node_put in of_release_dev(). PowerPC gains better recovery if
device_create_file() fails in of_device_register()
This just moves the common stuff from the arch of_device.h files to
linux/of_device.h.
Signed-off-by: Stephen Rothwell <[EMAIL PROTECTED]>
---
drivers/of/device.c |2 +-
include/asm-powerpc/of_device.h | 22 +-
include/asm-sparc/of_device.h | 15 -
This is to make the of merge easier. Also rename of_bus_type.
Signed-off-by: Stephen Rothwell <[EMAIL PROTECTED]>
---
arch/sparc/kernel/of_device.c | 42
arch/sparc/kernel/time.c|2 +-
arch/sparc64/kernel/auxio.c |2 +-
arch/sparc64/kernel
Move common stuff from asm-powerpc/of_platform.h to here and
move the common bits from asm-sparc*/of_device.h here as well.
Create asm-sparc*/of_platform.h and move appropriate parts of
of_device.h to them.
Signed-off-by: Stephen Rothwell <[EMAIL PROTECTED]>
---
include/asm-powerpc/of_platform.h
and populate it with the common parts from PowerPC and Sparc[64].
Signed-off-by: Stephen Rothwell <[EMAIL PROTECTED]>
---
arch/powerpc/kernel/of_platform.c | 82 +-
arch/sparc/kernel/of_device.c | 107 +++--
arch/sparc64/kernel/of_device.
Hi Mark,
On Thu, 19 Jul 2007 08:17:46 -0700 "Mark A. Greer" <[EMAIL PROTECTED]> wrote:
>
> I did a git-pull this morning but it had a conflict. Should I have
> reset it to something?
What did you pull it into? There were conflicts with Linus' tree in the
last merge, so there may be conflicts wi
On Fri, Jul 20, 2007 at 01:27:08AM +1000, Stephen Rothwell wrote:
> Hi Mark,
>
> On Thu, 19 Jul 2007 08:17:46 -0700 "Mark A. Greer" <[EMAIL PROTECTED]> wrote:
> >
> > I did a git-pull this morning but it had a conflict. Should I have
> > reset it to something?
>
> What did you pull it into? The
>> Your device is an rs5c372b. So, that's what you put in
>> your device tree. Simple so far, right?
>>
>> Now some OF I2C code goes looking for IIC devices in the
>> device tree. It finds this thing, and from a table or
>> something it derives that it has to tell the kernel I2C
>> layer this is
Segher Boessenkool wrote:
>> The CPU15 erratum on MPC8xx chips can cause incorrect code execution
>> under certain circumstances, where there is a conditional or indirect
>> branch in the last word of a page, with a target in the last cache line
>> of the next page. This patch implements one of t
On Thu, 19 Jul 2007 08:32:17 -0700 "Mark A. Greer" <[EMAIL PROTECTED]> wrote:
>
> I was in the master branch of powerpc.git and did a 'git-pull'
Sorry, I hadn't updated since this afternoon. Looks like Paul has reset
his master tree to be the same as Linus', so you do need to do a reset.
Or check
On Fri, 20 Jul 2007 01:44:32 +1000 Stephen Rothwell <[EMAIL PROTECTED]> wrote:
>
> git remote add powerpc
> git://git.kernel.org/pub/scm/linux/kernel/git/paulus/powerpc.git
> git fetch powerpc
>
> This will track the tree in branches called powerpc/ and do
> resets as necessary.
You should not m
This patchset enables TCP checksum offload support for IPV4
on ibmveth. This completely eliminates the generation and checking of
the checksum for packets that are completely virtual and never
touch a physical network. A simple TCP_STREAM netperf run on
a virtual network with maximum mtu set yield
This patch adds the appropriate ethtool hooks to allow for enabling/disabling
of hypervisor assisted checksum offload for TCP.
Signed-off-by: Brian King <[EMAIL PROTECTED]>
---
linux-2.6-bjking1/drivers/net/ibmveth.c | 120 +++-
linux-2.6-bjking1/drivers/net/ibmveth
Add ethtool hooks to ibmveth to retrieve driver statistics.
Signed-off-by: Brian King <[EMAIL PROTECTED]>
---
linux-2.6-bjking1/drivers/net/ibmveth.c | 53 +++-
1 file changed, 52 insertions(+), 1 deletion(-)
diff -puN drivers/net/ibmveth.c~ibmveth_ethtool_driver_
Add handlers for get_tso and get_ufo to prevent errors being printed
by ethtool.
Signed-off-by: Brian King <[EMAIL PROTECTED]>
---
linux-2.6-bjking1/drivers/net/ibmveth.c |4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff -puN drivers/net/ibmveth.c~ibmveth_ethtool_get_tso drivers
> + compatible = "MPC8548CDS", "MPC85xxCDS";
No new "xx" please.
> + memory {
> + device_type = "memory";
> + reg = < 0800>; // 128M at 0x0
[EMAIL PROTECTED] Simplified rule: whenever there is a "reg",
there is an "@".
> + [EMAIL PROTECTED]
On Fri, Jul 20, 2007 at 01:10:12AM +1000, Stephen Rothwell wrote:
> The only difference here is that Sparc uses strncmp to match compatibility
> names while PowerPC uses strncasecmp.
Could we put a comment in saying that both should really just use
strcmp(), and that this mechanism should go away
On Fri, Jul 20, 2007 at 01:44:32AM +1000, Stephen Rothwell wrote:
> On Thu, 19 Jul 2007 08:32:17 -0700 "Mark A. Greer" <[EMAIL PROTECTED]> wrote:
> >
> > I was in the master branch of powerpc.git and did a 'git-pull'
>
> Sorry, I hadn't updated since this afternoon. Looks like Paul has reset
> hi
On Fri, Jul 20, 2007 at 01:46:18AM +1000, Stephen Rothwell wrote:
> On Fri, 20 Jul 2007 01:44:32 +1000 Stephen Rothwell <[EMAIL PROTECTED]> wrote:
> >
> > git remote add powerpc
> > git://git.kernel.org/pub/scm/linux/kernel/git/paulus/powerpc.git
> > git fetch powerpc
> >
> > This will track the
Hi Scott,
On Thu, 19 Jul 2007 10:52:07 -0500 Scott Wood <[EMAIL PROTECTED]> wrote:
>
> On Fri, Jul 20, 2007 at 01:10:12AM +1000, Stephen Rothwell wrote:
> > The only difference here is that Sparc uses strncmp to match compatibility
> > names while PowerPC uses strncasecmp.
>
> Could we put a comm
This removes the requirement for callers to get_cpu() to check in simple
cases. i386 and x86_64 already received a similar treatment.
Signed-off-by: Avi Kivity <[EMAIL PROTECTED]>
---
arch/powerpc/kernel/smp.c |7 ++-
1 files changed, 6 insertions(+), 1 deletions(-)
diff --git a/arch/po
On Wed, 2007-07-18 at 16:54, Benjamin Herrenschmidt wrote:
> Cache line size is used by the kernel on ppc64 for things like clearing
> memory (to get the stride between subsequent dcbz) or flushing the
> cache :-) It's also passed on to userland.
>
> If it's absent from the device-tree, we defaul
Hi all,
Here is a list of some known regressions in 2.6.22-git.
Feel free to add new regressions/remove fixed etc.
http://kernelnewbies.org/known_regressions
List of Aces
NameRegressions fixed since 21-Jun-2007
Adrian Bunk3
Andi Kleen
Kumar Gala wrote:
> Can you dump the POCMRx registers and report their values and what /
> proc/iomem looks like.
POTAR0: 0x0008
POTAR1: 0x000a
POTAR2: 0x
POBAR0: 0x0008
POBAR1: 0x000a
POBAR2: 0x000f6000
POCMR0: 0xa00e
POCMR1: 0x800e
POCMR2: 0xc00fe000
PITAR0: 0
On Thu, Jul 19, 2007 at 06:34:55PM +0200, Michal Piotrowski wrote:
> SYSFS
>
> Subject : sysfs root link count broken in 2.6.22-git5
> References : http://lkml.org/lkml/2007/7/15/62
> Last known good : ?
> Submitter : Jean Delvare <[EMAIL PROTECTED]>
> Caused-By : ?
> Hand
On Wed, 2007-07-18 at 19:00, Paul Mackerras wrote:
> Hmmm. The dangling else clauses are pretty gross, and in fact we have
> the same problem on POWER3 and RS64 processors (to be fair, we had
> the problem before and didn't notice, but we should still fix it).
>
> How about this instead? Could
On Wed, 2007-07-18 at 01:35, Andy Fleming wrote:
> phy_read() returns a negative number if there's an error, but the
> error-checking code in the Vitesse driver's config_intr function
> triggers if phy_read() returns non-zero. Correct that.
>
> Signed-off-by: Andy Fleming <[EMAIL PROTECTED]>
> --
>> Yes indeed. The problem with your suggested "obvious way"
>
> I said it was obvious, not obviously correct. :-)
I know :-)
>> is that you wouldn't get a unit address included if your
>> interrupt-map points (for some entry) at your device tree
>> parent, either. Not all that hypothetical.
>
just my 2 cents.
[snip]
>
> > + fsl,cpm-brg = <1>;
> > + fsl,cpm-command = <0090>;
>
> Are these two documented? Your patch queue is too
> long for me to check for myself.
>
In fact, there were different approaches to describe CPM, and I am su
>> The only difference here is that Sparc uses strncmp to match
>> compatibility
>> names while PowerPC uses strncasecmp.
>
> Could we put a comment in saying that both should really just use
> strcmp(), and that this mechanism should go away once any
> compatibility
> issues are found and addr
>>> compatible = "fsl,mpc8241-i2c", "fsl-i2c";
>>
>> That looks good yes. Or if the kernel side code for
>> recognising fsl,mpc8241-i2c gets merged in time, you
>> can leave out fsl-i2c from your device tree completely.
>
> Hmm, there are really only two fsl,i2c controllers. The one we
> ca
> Subject : ext4 build warnings
> References : http://lkml.org/lkml/2007/7/18/420
> Last known good : ?
> Submitter : Jeff Garzik <[EMAIL PROTECTED]>
> Caused-By : ?
> Handled-By : Mingming Cao <[EMAIL PROTECTED]>
> Status : unknown
Mingming Cao fixed this:
+ /* Following required by dtc but not used */
+ i-cache-line-size = <0>;
+ d-cache-line-size = <0>;
+ i-cache-size = <4000>;
+ d-cache-size = <4000>;
+ };
>>>
>>> The 32 bits
>>> + fsl,cpm-brg = <1>;
>>> + fsl,cpm-command = <0090>;
>>
>> Are these two documented? Your patch queue is too
>> long for me to check for myself.
>>
> In fact, there were different approaches to describe CPM, and I am
> sure this is not the
>> Hmmm. The dangling else clauses are pretty gross, and in fact we
>> have
>> the same problem on POWER3 and RS64 processors (to be fair, we had
>> the problem before and didn't notice, but we should still fix it).
>>
>> How about this instead? Could people test it please? (Note that
>> CPU_F
Satyam Sharma wrote:
>> Subject : ext4 build warnings
>> References : http://lkml.org/lkml/2007/7/18/420
>> Last known good : ?
>> Submitter : Jeff Garzik <[EMAIL PROTECTED]>
>> Caused-By : ?
>> Handled-By : Mingming Cao <[EMAIL PROTECTED]>
>> Status : unknown
ext Brian King wrote:
> +
> +static int ibmveth_set_rx_csum(struct net_device *dev, u32 data)
> +{
> + struct ibmveth_adapter *adapter = dev->priv;
> +
Why do not to do
if ((data && adapter->rx_csum) || (!data && !adapter->rx_csum))
return 0;
less two lines.
> +
Ragner Magalhaes wrote:
> ext Brian King wrote:
>
>> +
>> +static int ibmveth_set_rx_csum(struct net_device *dev, u32 data)
>> +{
>> +struct ibmveth_adapter *adapter = dev->priv;
>> +
>
> Why do not to do
>
> if ((data && adapter->rx_csum) || (!data && !adapter->rx_csum))
>
ext Brian King wrote:
> Ragner Magalhaes wrote:
>> ext Brian King wrote:
>>
>>> +
>>> +static int ibmveth_set_rx_csum(struct net_device *dev, u32 data)
>>> +{
>>> + struct ibmveth_adapter *adapter = dev->priv;
>>> +
>> Why do not to do
>>
>> if ((data && adapter->rx_csum) || (!data && !adapt
Ragner Magalhaes wrote:
> ext Brian King wrote:
>> Ragner Magalhaes wrote:
>>> here also, as above ...
+ if (data && (dev->features & NETIF_F_IP_CSUM))
+ return 0;
+ if (!data && !(dev->features & NETIF_F_IP_CSUM))
+ return 0;
>> This change would make the li
On 19/07/07, Satyam Sharma <[EMAIL PROTECTED]> wrote:
> > Subject : ext4 build warnings
> > References : http://lkml.org/lkml/2007/7/18/420
> > Last known good : ?
> > Submitter : Jeff Garzik <[EMAIL PROTECTED]>
> > Caused-By : ?
> > Handled-By : Mingming Cao <[EMAIL P
On 07/19/2007 11:47 AM, Andrew Morton wrote:
> On Thu, 19 Jul 2007 11:39:32 +0200 (CEST) Geert Uytterhoeven <[EMAIL
> PROTECTED]> wrote:
>
>>> Oh dear.
>>>
>>> ps3rom_priv(dev) = host;
>>>
>>> that's 'orrid. We have an identifier pretending to be a function, only we
>>> go and treat it as a
> Hmmm. The dangling else clauses are pretty gross,
I hoped you wouldn't notice. I guess I shouldn't have
commented them :-)
"It was the cleanest thing I could come up with". Every
other thing I tried ended up as a maze of #ifdefs or some
incomprehensible cross-jumping mess; and I was aiming f
Segher Boessenkool wrote:
> Since you are using generic names, the only use for the "name"
> of a node is for a human reader to understand your tree. Maybe
> everyone using this specific SoC knows what a BCSR is; or maybe
> there is a more friendly name you could use.
It's the standard term used
On Thu, 2007-07-19 at 12:16, Segher Boessenkool wrote:
> > Tested on 8641HPCN.
>
> Which glibc versions? glibc-2.4 and newer are fine without the
> patch already, glibc-2.3 seems to get away by accident; but 2.2
> (and before) are the problematic ones.
>
> No other userland program has been ide
Grant Likely wrote:
> From: Grant Likely <[EMAIL PROTECTED]>
>
> To boot from a cuImage requires the device tree to have a
> linux,stdout-path property in the chosen node. This patch adds it
> to the .dts files.
This will break many current u-boots, as they blindly add a /chosen node
regardless
On Thu, Jul 19, 2007 at 01:57:00PM -0500, Jon Loeliger wrote:
> Needless to say, one that showed the problem beforehand. :-)
> But to be precise:
>
> [root:~] ls -lsa /usr/lib/libglib*
>0 lrwxrwxrwx1 18005314 24012 21 Aug 15 2005
> /usr/lib/libglib-1.2.so.0 -> libglib-1.2.so.0.0
>> Since you are using generic names, the only use for the "name"
>> of a node is for a human reader to understand your tree. Maybe
>> everyone using this specific SoC knows what a BCSR is; or maybe
>> there is a more friendly name you could use.
>
> It's the standard term used in Freescale board
On Thu, 2007-07-19 at 14:02, Scott Wood wrote:
> glib != glibc.
>
> -Scott
D'oh.
So, It doesn't say what version it is.
But it is also dated 8-Apr-2003.
jdl
___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/l
On Thursday 19 July 2007, Michal Piotrowski wrote:
> IDE
>
> Subject : compile error if CONFIG_BLOCK not enabled related to
> linux/ide.h include
> References : http://lkml.org/lkml/2007/7/18/11
> Last known good : ?
> Submitter : Kumar Gala <[EMAIL PROTECTED]>
> Caused-By
On 19/07/07, Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> wrote:
> On Thursday 19 July 2007, Michal Piotrowski wrote:
>
> > IDE
> >
> > Subject : compile error if CONFIG_BLOCK not enabled related to
> > linux/ide.h include
> > References : http://lkml.org/lkml/2007/7/18/11
> > Last k
From: Grant Likely <[EMAIL PROTECTED]>
Signed-off-by: Grant Likely <[EMAIL PROTECTED]>
CC: Scott Wood <[EMAIL PROTECTED]>
CC: Kumar Gala <[EMAIL PROTECTED]>
---
arch/powerpc/boot/devtree.c | 14 +++---
1 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/arch/powerpc/boot/dev
From: Grant Likely <[EMAIL PROTECTED]>
cuImage need to know the logical index of the ethernet devices in order
to assign mac addresses. This patch adds the needed properties
Signed-off-by: Grant Likely <[EMAIL PROTECTED]>
CC: Scott Wood <[EMAIL PROTECTED]>
CC: Kumar Gala <[EMAIL PROTECTED]>
---
The following series makes the mpc8349emitx* cuImage work 'out of the box'
Major changes are adding the linux,network-index property to the Ethernet
nodes and adding a default linux,stdout-path to the .dts files. With
these changes, a cuImage created by 'make mpc834x_itx_defconfig; make zImage'
sh
From: Grant Likely <[EMAIL PROTECTED]>
To boot from a cuImage requires the device tree to have a
linux,stdout-path property in the chosen node. This patch adds it
to the .dts files.
Signed-of-by: Grant Likely <[EMAIL PROTECTED]>
CC: Scott Wood <[EMAIL PROTECTED]>
CC: Kumar Gala <[EMAIL PROTECTED
From: Grant Likely <[EMAIL PROTECTED]>
Signed-off-by: Grant Likely <[EMAIL PROTECTED]>
CC: Scott Wood <[EMAIL PROTECTED]>
CC: Kumar Gala <[EMAIL PROTECTED]>
---
arch/powerpc/configs/mpc834x_itx_defconfig | 251 +--
arch/powerpc/configs/mpc834x_itxgp_defconfig | 349 ++
On 7/19/07, Scott Wood <[EMAIL PROTECTED]> wrote:
> Grant Likely wrote:
> > From: Grant Likely <[EMAIL PROTECTED]>
> >
> > To boot from a cuImage requires the device tree to have a
> > linux,stdout-path property in the chosen node. This patch adds it
> > to the .dts files.
>
> This will break many
commit id bafdb645779c63300763acb383f7b9dd2d427228 (on Linus' tree)
causes breakage on my mpc8349 build (see below). I've worked around
it by removing ps3* from arch/powerpc/boot/Makefile, but I have not
dug into what the 'proper' solution should be.
Cheers,
g.
Toolchain: gcc version 4.0.0 (DENX
On Jul 19, 2007, at 12:30 AM, Andrew Morton wrote:
> On Fri, 13 Jul 2007 21:20:33 -0400 Mathieu Desnoyers
> <[EMAIL PROTECTED]> wrote:
>
>> Powerpc - Include pagemap.h in asm/powerpc/tlb.h
>>
>> Fixes this powerpc build error in 2.6.22-rc6-mm1 for powerpc 64 :
>>
>> In file included from includ
On Jul 18, 2007, at 1:35 AM, Andy Fleming wrote:
> phy_read() returns a negative number if there's an error, but the
> error-checking code in the Vitesse driver's config_intr function
> triggers if phy_read() returns non-zero. Correct that.
>
> Signed-off-by: Andy Fleming <[EMAIL PROTECTED]>
Je
1 - 100 of 148 matches
Mail list logo
