Re: [Linuxwacom-devel] RFC: [PATCH 2/4] Add '_get' function to handle retrieval of property data

2011-10-12 Thread Eduard Hasenleithner
Hi 2011/10/12 Peter Hutterer : > There's nothing wrong with using void*, other than that you _always_ have to > typecast when you want to use it. char* you only need to typecast for other > formats. In this case, you'll probably notice that XGetDeviceProperty > returns a unsigned char* too. > (uch

Re: [Linuxwacom-devel] RFC: [PATCH 2/4] Add '_get' function to handle retrieval of property data

2011-10-12 Thread Eduard Hasenleithner
Hi 2011/9/28 Jason Gerecke : > Replaces several near-identical calls to XGetDeviceProperty with > a single centralized function to do the same thing. The new '_get' > function is responsible for reading the property from the server, > verifying its format matches that which is intended, and return

[Linuxwacom-devel] [PATCH v4 2/2] First version of Button Image setting

2011-10-09 Thread Eduard Hasenleithner
' TODO: * Add ability to read images from files * Add ability for more sophisticated "text layout" * Add support for non TrueColor mode X Server * Add function for setting luminance Signed-off-by: Eduard Hasenleithner --- include/wacom-properties.h | 14 +++ man/xsetwacom.

[Linuxwacom-devel] [PATCH v4 1/2] Make InitWcmAtom support arbitrary property types

2011-10-09 Thread Eduard Hasenleithner
needed for the upcoming OLED commit. Signed-off-by: Eduard Hasenleithner --- src/wcmXCommand.c | 62 +--- 1 files changed, 35 insertions(+), 27 deletions(-) diff --git a/src/wcmXCommand.c b/src/wcmXCommand.c index fe71bd1..82f9b80 100644 --- a/src

[Linuxwacom-devel] [PATCH] Fixing format strings in list_mod

2011-10-09 Thread Eduard Hasenleithner
27;int', but argument 2 has type 'long unsigned int' [-Wformat] Signed-off-by: Eduard Hasenleithner --- tools/xsetwacom.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/xsetwacom.c b/tools/xsetwacom.c index 2dc0c2b..99ca974 100644 --- a/to

Re: [Linuxwacom-devel] [PATCH v3] First version of Button Image setting

2011-10-05 Thread Eduard Hasenleithner
2011/10/5 Peter Hutterer : > On Wed, Oct 05, 2011 at 10:51:39AM +0200, Eduard Hasenleithner wrote: >> Hi, >> >> I'm just commenting on one point for now: >> >> 2011/10/5 Peter Hutterer : >> >> Just for the "record": No, I don't thin

Re: [Linuxwacom-devel] [PATCH v3] First version of Button Image setting

2011-10-05 Thread Eduard Hasenleithner
Hi, I'm just commenting on one point for now: 2011/10/5 Peter Hutterer : >> Just for the "record": No, I don't think we have a performance problem >> when always setting all the pixmaps at once. It is just that I did not >> figure out yet on how to blank the pixmaps in-server. > > blank? or free?

Re: [Linuxwacom-devel] [PATCH v3] First version of Button Image setting

2011-10-05 Thread Eduard Hasenleithner
Hi 2011/10/5 Peter Hutterer : > On Sun, Oct 02, 2011 at 02:14:56PM +0200, Eduard Hasenleithner wrote: >> The LED extensions in the wacom kernel driver are scheduled for >> inclusion into linux-3.2. This commit provides a first >> demonstration on how the OLED part of n

Re: [Linuxwacom-devel] The future of xsetwacom && the need for a client library

2011-10-03 Thread Eduard Hasenleithner
2011/9/29 Peter Hutterer : > Much further down the line is the magic LED changes that we talked about in > the other thread - changing the LED at the same time as all button > assignments. Here some of my thoughts. Please take them with a grain of salt, because I'm just "thinking loud". * Having

[Linuxwacom-devel] [PATCH v3] First version of Button Image setting

2011-10-02 Thread Eduard Hasenleithner
of Button 3 to 'example' > xsetwacom --set 'Wacom Intuos4 8x13 pad' Image 3 'example' TODO: * Add ability to read images from files * Add ability for more sophisticated "text layout" * Add support for non TrueColor mode X Server * Add function for setting lumi

Re: [Linuxwacom-devel] [PATCH v2] First version of Button Image setting

2011-09-29 Thread Eduard Hasenleithner
2011/9/29 Peter Hutterer : > On Wed, Sep 28, 2011 at 11:29:39PM +0200, Eduard Hasenleithner wrote: >> Here is some further thought about the pixmap handling. What I somehow >> dislike is the "dirty" handling of pixmaps when the client is closed. >> How about pre-a

Re: [Linuxwacom-devel] [PATCH] First version of Button Image setting

2011-09-28 Thread Eduard Hasenleithner
2011/9/29 Peter Hutterer : >> Ah, finally I understand the whole picture which Ping wanted me (us) >> to tell. I see it similar. When looking at the 4 leds, I'm seeing >> something like a software settable "rotary selection switch". >> Applications want to be informed immediately when the value cha

Re: [Linuxwacom-devel] [PATCH v2] First version of Button Image setting

2011-09-28 Thread Eduard Hasenleithner
Here is some further thought about the pixmap handling. What I somehow dislike is the "dirty" handling of pixmaps when the client is closed. How about pre-allocating the pixmaps at driver startup: void wcmLedInitPixmap(WacomDevicePtr priv, int *values, int count) { int i; ScreenPtr

Re: [Linuxwacom-devel] [PATCH] First version of Button Image setting

2011-09-28 Thread Eduard Hasenleithner
Hi 2011/9/28 Ping Cheng : > On Wed, Sep 28, 2011 at 4:10 AM, Peter Hutterer > wrote: >> sorry, I'm just going to reply to this message here instead of each of them >> in the thread because otherwise my answers would be too split up. Also, I'm >> a bit confused because some of the msgs in this thr

Re: [Linuxwacom-devel] [PATCH v2] First version of Button Image setting

2011-09-27 Thread Eduard Hasenleithner
Hi This is v2 of the patch. The xsetwacom side of the patch is considered only for demonstration/testing purposes. I want to deal with that side when the x11 input driver is stabilized. For the x11 input driver part, we still need to continue the discussion on pixmap handling. Thanks, Eduard --

[Linuxwacom-devel] [PATCH v2] First version of Button Image setting

2011-09-27 Thread Eduard Hasenleithner
ty for more sophisticated "text layout" * Add support for non TrueColor mode X Server Signed-off-by: Eduard Hasenleithner --- include/wacom-properties.h |7 ++ man/xsetwacom.man |4 + src/common.mk |1 + src/wcm

Re: [Linuxwacom-devel] [PATCH] First version of Button Image setting

2011-09-27 Thread Eduard Hasenleithner
Hi. 2011/9/27 Ping Cheng : > On Tue, Sep 27, 2011 at 12:09 PM, Eduard Hasenleithner > wrote: >> So let me summarize: The only important point of the function selector >> (led) is to provide another axis to the X11 client application. >> The X11 client is free to decid

Re: [Linuxwacom-devel] [PATCH] First version of Button Image setting

2011-09-27 Thread Eduard Hasenleithner
Hi Ping. 2011/9/27 Ping Cheng : > On Mon, Sep 26, 2011 at 4:04 PM, Eduard Hasenleithner > wrote: >> 2011/9/27 Ping Cheng : >>> On Sun, Sep 25, 2011 at 1:23 PM, Eduard Hasenleithner >>> wrote: >>>> TODO: >>>> * Add function for setting the

Re: [Linuxwacom-devel] [PATCH] First version of Button Image setting

2011-09-27 Thread Eduard Hasenleithner
Hi Peter. Thanks for the detailled comments. 2011/9/27 Peter Hutterer : > On Sun, Sep 25, 2011 at 10:23:13PM +0200, Eduard Hasenleithner wrote: >> Linux kernels starting with version number 3.2 are supposed to have >> the LED extensions included in the wacom driver. This commi

Re: [Linuxwacom-devel] [PATCH] First version of Button Image setting

2011-09-26 Thread Eduard Hasenleithner
Hi Ping Thanks for the ACK. 2011/9/27 Ping Cheng : > On Sun, Sep 25, 2011 at 1:23 PM, Eduard Hasenleithner > wrote: >> TODO: >> * Add function for setting the status led > > I am working on patches to support this function as well as retrieving > the LED status from

[Linuxwacom-devel] [PATCH] Backport of Intuos4 LED and OLED control

2011-09-26 Thread Eduard Hasenleithner
cise This commit enables control of the LEDs and OLED displays found on the Wacom Intuos4 M, L, and XL. For this purpose, a new "wacom_led" attribute group is added to the sysfs entry of the USB device. This "wacom_led" group only shows up when the correct device (M, L, or XL) is de

[Linuxwacom-devel] [PATCH] First version of Button Image setting

2011-09-25 Thread Eduard Hasenleithner
phisticated "text layout" * Add support for non TrueColor mode X Server Signed-off-by: Eduard Hasenleithner --- include/wacom-properties.h |7 ++ man/xsetwacom.man |4 + src/common.mk |1 + src/wcmConfig.c

Re: [Linuxwacom-devel] Intuos4 OLED support, question on XA_PIXMAP property

2011-09-24 Thread Eduard Hasenleithner
2011/9/24 Eduard Hasenleithner : > when wcmSetProperty() is called in the input module, it does not have > the ClientPtr parameter. This parameter is required for the > dixLookupDrawable, which would give back the PixmapPtr. Is there a > method to get the ClientPtr, or am I missing so

[Linuxwacom-devel] Intuos4 OLED support, question on XA_PIXMAP property

2011-09-24 Thread Eduard Hasenleithner
Hi Peter It appears, that my Intuos4 OLED patch has been accepted into the kernel (a bit hard to tell since the kernel git server is currently down). Time to get back to implement OLED support into the X11 wacom input module. We were talking about alternatives on how to pass image data to the wac

Re: [Linuxwacom-devel] RFC: how to report a new value to XInput

2011-09-02 Thread Eduard Hasenleithner
2011/8/19 Ping Cheng : > On Thu, Aug 18, 2011 at 9:40 PM, Peter Hutterer > wrote: >> >> On Wed, Aug 17, 2011 at 08:26:26AM -0700, Ping Cheng wrote: >> > On Wed, Aug 17, 2011 at 12:02 AM, Peter Hutterer >> > wrote: >> > >> > > On Tue, Aug 16, 2011 at 11:48:51PM -0700, Ping Cheng wrote: >> > > > > >

Re: [Linuxwacom-devel] Eduard Hasenleithner's Intuos4 LED and OLED patch and sysfs permissions

2011-09-02 Thread Eduard Hasenleithner
Hi. 2011/7/7 Peter Hutterer : > On Wed, Jul 06, 2011 at 10:36:22PM +1200, Jason alavaliant wrote: >> On Wed, Jul 6, 2011 at 12:37 PM, Chris Bagwell wrote: >> > I do not know the long term plan for this as well but I can make some >> > educated guesses.  It doesn't make sense to use xsetwacom for

Re: [Linuxwacom-devel] [PATCH 1/9] Fix "buttons must be set twice" bug from d650b139

2011-03-30 Thread Eduard Hasenleithner
Hi I join the discussion, because I have to deal with "Array of Atom" constructs also for my OLED Images. 2011/3/30 Peter Hutterer : > applied, but from a cursory glance I'm not sure why. In fact, I would have > guessed the other way round. anyway, I've added a comment to avoid this in > the futu

Re: [Linuxwacom-devel] Kernel driver for OLED support (was: OLED setting for xsetwacom)

2011-03-24 Thread Eduard Hasenleithner
2011/3/24 Ping Cheng : > Happy hacking. I have another question. Is there documentation (from Wacom) on how to access the OLEDs? If not, how did Nicolas Hirsch manage to write the patch? It is just that I want to check if minor improvements to the IOCTL interface can be done, and for that it migh

[Linuxwacom-devel] Kernel driver for OLED support (was: OLED setting for xsetwacom)

2011-03-23 Thread Eduard Hasenleithner
2011/3/23 Ping Cheng : > On Wed, Mar 23, 2011 at 12:55 PM, Eduard Hasenleithner > wrote: >> Now I even tested the linuxwacom/src/2.6.30 driver on a fresh >> linux-2.6.38 from kernel.org. I had to do a few minor modifications to >> the driver source (ioctl has been rena

Re: [Linuxwacom-devel] [draft-patch] OLED setting for xsetwacom

2011-03-23 Thread Eduard Hasenleithner
Now I even tested the linuxwacom/src/2.6.30 driver on a fresh linux-2.6.38 from kernel.org. I had to do a few minor modifications to the driver source (ioctl has been renamed to unlocked_ioctl in usb_device and input->abs is missing) but it works perfectly! Apparently the driver did not diverge too

Re: [Linuxwacom-devel] [draft-patch] OLED setting for xsetwacom

2011-03-23 Thread Eduard Hasenleithner
2011/3/23 Favux ... : > usbfs was deprecated in kernel 2.6.31 I think.  Certainly by 2.6.32 > Ubuntu (Lucid 10.04) and several other distributions dropped it.  This > all happened at about the same time.  There was some conflict with > changes in udev.  Apparently since usbfs implicitly changes eve

Re: [Linuxwacom-devel] [draft-patch] OLED setting for xsetwacom

2011-03-23 Thread Eduard Hasenleithner
2011/3/23 Peter Hutterer : > On Tue, Mar 22, 2011 at 10:47:12PM +0100, Eduard Hasenleithner wrote: >> For accessing USB-FS, I already considered libusb, just to find out >> that it does not (yet?) provide the USBDEVFS_IOCTL. Ideal would be >> IOCTL tunneling through the lin

Re: [Linuxwacom-devel] [draft-patch] OLED setting for xsetwacom

2011-03-22 Thread Eduard Hasenleithner
Hi 2011/3/22 Peter Hutterer : >> It defines a new pseudo-property "Wacom Button Image". When >> XChangeDeviceProperty is called with a 2049 octet data, the first >> octet is taken as the button number, and the remaining 2048 octets are >> taken as the image. > > this approach isn't all too differe

[Linuxwacom-devel] [draft-patch] OLED setting for xsetwacom

2011-03-21 Thread Eduard Hasenleithner
Hi Here I have a very early draft for setting the Intuos4 OLED display by means of xsetwacom. It defines a new pseudo-property "Wacom Button Image". When XChangeDeviceProperty is called with a 2049 octet data, the first octet is taken as the button number, and the remaining 2048 octets are taken

[Linuxwacom-devel] [PATCH] Provide Intuos4 LED ioctl for kernel 2.6.24ff

2011-03-13 Thread Eduard Hasenleithner
LED-ioctl, LEDs are still not configurable. This commit exposes wacom_ioctl for src/2.6.30 so that LEDs can be set at least with the src/2.6.30 and src/2.6.24 driver. Signed-off-by: Eduard Hasenleithner --- src/2.6.30/wacom_sys.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) d

Re: [Linuxwacom-devel] [PATCH] Re-vamp source inclusion for test build suite.

2011-03-12 Thread Eduard Hasenleithner
2011/3/12 Eduard Hasenleithner : > One thing I can notice is that nothing in the "test" directory is > built automatically when doing make in the root directory. A "make > wacom-tests" in "test" does work though. Ah, I found now the wiki page for TestSuite.

Re: [Linuxwacom-devel] [PATCH] Re-vamp source inclusion for test build suite.

2011-03-12 Thread Eduard Hasenleithner
when doing make in the root directory. A "make wacom-tests" in "test" does work though. While not having much clue about the automake syntax, to me the patch seems also to be OK on the functional level. Tested-by: Eduard Hasenleithner > On Wed, Mar 9, 2011 at 4:20 PM, Peter H

[Linuxwacom-devel] Unit test problem in build system (was Re: Intuos4 L on Ubuntu 10.04)

2011-03-09 Thread Eduard Hasenleithner
2011/3/9 Chris Bagwell : > Cool.  Thanks for solving the mystery. I did some further investigations, and it appears that both src/Makefile.am and test/Makefile.am generate rules for "make install". Since "make install" is called first for src and second for test, test overwrites the src installati

Re: [Linuxwacom-devel] Intuos4 L on Ubuntu 10.04

2011-03-08 Thread Eduard Hasenleithner
2011/3/6 Chris Bagwell : > Did you see in this weeks git that a VCOPY bugfix was submitted that > stops crashes on xorg 1.7 servers?  It so happens that 0.10.8 is also > last release without VCOPY bug. If found the likely reason for the vcopy bug: When the "test" directory of xf86-input-wacom is b

Re: [Linuxwacom-devel] Intuos4 L on Ubuntu 10.04

2011-03-06 Thread Eduard Hasenleithner
2011/3/7 Peter Hutterer : >> The bug only exists if xf86-input-wacom later than 0.10.8 on xorg >> 1.7.6 server with an intuos4 L tablet is used. The bug does not show >> up if the mentioned patch >> (http://lists.x.org/archives/xorg-devel/2010-April/007333.html) is >> included in the x-server. It d

Re: [Linuxwacom-devel] Intuos4 L on Ubuntu 10.04

2011-03-06 Thread Eduard Hasenleithner
2011/3/6 Ping Cheng : >> Just as a note: I compiled xf86-input-wacom-0.10.8 which is the last >> release before commit 19c24dc4e852bae384f16411d5f59add487be5f0 and it >> appears to work correctly. > > > Oh, too bad. I wonder why the others have not seen the issue yet. Do you > have multi-monitor se

Re: [Linuxwacom-devel] Intuos4 L on Ubuntu 10.04

2011-03-06 Thread Eduard Hasenleithner
2011/3/6 Ping Cheng : > Which X server version are you running? Please post the output of "X > -version" from your system here. If you are running a server older than 1.7, > you need linuxwacom-0.8.8-11 instead. I'm using the default X server from Ubuntu 10.04: $ X -version X.Org X Server 1.7.6 R

[Linuxwacom-devel] Intuos4 L on Ubuntu 10.04

2011-03-06 Thread Eduard Hasenleithner
Hi As also reported in http://ubuntuforums.org/showthread.php?t=1120029 my Intuos4 L does not work properly on Ubuntu Lucid with a quite new git version of the xf86-input-wacom. Only the left half of the tablet is usable, if the stylus is moved to the right half it jumps to the leftmost location.