Re: [Linuxwacom-devel] Cintiq 24HD

2011-10-08 Thread Jason Gerecke
Discussion seems to have died down, so I'd like to propose a design. If there are any comments you'd like to make, be sure to get them in. I hope to start start the coding phase on Monday, and the less backpedaling I have to do, the better :) I plan on exposing the three "hardware control buttons"

Re: [Linuxwacom-devel] Cintiq 24HD

2011-10-09 Thread Jason Gerecke
On Sun, Oct 9, 2011 at 5:36 PM, Chris Bagwell wrote: > On Sun, Oct 9, 2011 at 6:08 PM, Peter Hutterer > wrote: >> On Fri, Oct 07, 2011 at 06:34:01PM -0700, Jason Gerecke wrote: >>> On Wed, Oct 5, 2011 at 12:52 PM, Chris Bagwell wrote: >>> > On Wed, Oct

Re: [Linuxwacom-devel] RFC: [PATCH 2/4] Add '_get' function to handle retrieval of property data

2011-10-11 Thread Jason Gerecke
On Tue, Oct 4, 2011 at 9:13 PM, Peter Hutterer wrote: > On Tue, Sep 27, 2011 at 06:03:55PM -0700, Jason Gerecke wrote: >> + * @return Pointer to the requested data. Must be 'free()'-ed >> + */ >> +static void* _get_property(Display *dpy, XDevice

[Linuxwacom-devel] [PATCH 1/3] Only convert I4 tilt bits to rotation for the I4 mouse

2011-10-20 Thread Jason Gerecke
The comment claims that the conversion is to be performed for the I4 mouse only, but doesn't actually check to see if the tool is indeed a mouse. This patch adds in the necessary check, allowing the I4 stylus to properly report tilt data. Signed-off-by: Jason Gerecke --- src/wcmCommon.c |

[Linuxwacom-devel] [PATCH 2/3] Correct Cintiq 21UX2 features to advertise touch strips, not rings

2011-10-20 Thread Jason Gerecke
Moves the 0xCC case (21UX2) to be in the proper spot. There are touch strips, not rings on this device. Signed-off-by: Jason Gerecke --- src/wcmValidateDevice.c |5 + 1 files changed, 1 insertions(+), 4 deletions(-) diff --git a/src/wcmValidateDevice.c b/src/wcmValidateDevice.c index

[Linuxwacom-devel] [PATCH 3/3] Add 0x10804 to recognized Art Pen device IDs

2011-10-20 Thread Jason Gerecke
placed one nybble *too* high. Until a proper fix is made and tested for the kernel, we need to check for an ID of "0x100804" instead of "0x10804". Signed-off-by: Jason Gerecke --- src/wcmCommon.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/wcmCo

[Linuxwacom-devel] [PATCH 1/5] Add basic support for Cintiq 24HD

2011-10-21 Thread Jason Gerecke
Adds the Cintiq 24HD (056a:00f4) to the device lists. The 24HD has two features not found on prior tablets: three capacitive buttons, and a second touch ring. Subsuquent patches will address adding support for them. Signed-off-by: Jason Gerecke --- src/wcmUSB.c|1 + src

[Linuxwacom-devel] [PATCH 2/5] Treat KEY_PROG1, KEY_PROG2, and KEY_PROG3 as buttons

2011-10-21 Thread Jason Gerecke
-off-by: Jason Gerecke --- src/wcmUSB.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/src/wcmUSB.c b/src/wcmUSB.c index c92ce41..0a9ce9b 100644 --- a/src/wcmUSB.c +++ b/src/wcmUSB.c @@ -156,7 +156,8 @@ static unsigned short padkey_codes [] = { BTN_A, BTN_B

[Linuxwacom-devel] [PATCH 3/5] Add 'abswheel2' to device state for dual-ring devices

2011-10-21 Thread Jason Gerecke
This patch adds an 'abswheel2' field to the _WacomDeviceState structure, along with corresponding 'oldWheel2' field to the _WacomDeviceRec structure. These fields store the state of the second touch ring on dual-ring devices such as the Cintiq 24HD. Signed-off-by: Jas

[Linuxwacom-devel] [PATCH 4/5] Have the second touch ring emulate wheel events by default

2011-10-21 Thread Jason Gerecke
Touch strips as well as the first touch ring are set up to emulate mouse wheel events by default. This patch duplicates this behavior for the second touch ring, so that it behaves in an identical manner. Signed-off-by: Jason Gerecke --- src/wcmCommon.c | 29

[Linuxwacom-devel] [PATCH 5/5] Expose the second touch ring's raw value in a new 7th valuator

2011-10-21 Thread Jason Gerecke
This patch expands the number of valuators reported by devices to seven. The new seventh valuator reports the raw value provided from the kernel for the second touch ring. Signed-off-by: Jason Gerecke --- src/wcmCommon.c | 11 +++ src/wcmConfig.c |2 +- src/xf86Wacom.c | 33

Re: [Linuxwacom-devel] [PATCH 4/5] Have the second touch ring emulate wheel events by default

2011-10-26 Thread Jason Gerecke
On Sun, Oct 23, 2011 at 9:13 PM, Peter Hutterer wrote: > On Fri, Oct 21, 2011 at 06:37:25PM -0700, Jason Gerecke wrote: >> Touch strips as well as the first touch ring are set up to emulate >> mouse wheel events by default. This patch duplicates this behavior >> for the secon

[Linuxwacom-devel] [PATCH v2 5/5] Expose the second touch ring's raw value in a new 7th valuator

2011-10-26 Thread Jason Gerecke
This patch expands the number of valuators reported by pad devices to seven. The new seventh valuator reports the raw value provided from the kernel for the second touch ring. Signed-off-by: Jason Gerecke --- Changes from v1: * Number of axes back to 6 by default * 7th axis only initialized

[Linuxwacom-devel] xf86-input-wacom 0.11.99.1

2011-10-30 Thread Jason Gerecke
Its been 5 months since 0.11.1, which means we're long overdue for our next release. Shortly I'll be uploading a tarball of 0.11.99.1 which will be our first of two or three RCs. The next few weeks should be focused on testing, fixing bugs, and addressing regressions that have snuck in since the la

[Linuxwacom-devel] [PATCH] Migrate Tablet(Has|Set)Feature to use the wacom-util macros

2011-11-09 Thread Jason Gerecke
In addition to consolidating code, this happens to fix a bug in the implementation of TabletHasFeature which would return true provided *any* bit of a multi-bit mask was set. Ever since 7c667678 when WCM_TPC was changed to a multi-bit mask, tablets with WCM_LCD set have been (mis-)treated as tablet

[Linuxwacom-devel] [PATCH 1/2] Revert "Only convert I4 tilt bits to rotation for the I4 mouse"

2011-11-09 Thread Jason Gerecke
This reverts commit 9be9719d78af035c45ea4b191c21fab0ee54f198. Under the right conditions, the 'tool' pointer can be NULL, leading to the X server crashing. An easy way to trigger the crash is to spam pad events (such as button presses) while holding the stylus on the edge of proximity. Rather than

[Linuxwacom-devel] [PATCH 2/2] Only convert I4 tilt bits to rotation for the I4 mouse (v2)

2011-11-09 Thread Jason Gerecke
This re-implements commit 9be9719d78af035c45ea4b191c21fab0ee54f198. Ping pointed out the device_type field that I had somehow missed when making the earlier commit. This provides essentially the same information as the IsCursor() macro that the original patch went through so much trouble to use. --

Re: [Linuxwacom-devel] [PATCH 2/2] Only convert I4 tilt bits to rotation for the I4 mouse (v2)

2011-11-09 Thread Jason Gerecke
On Wed, Nov 9, 2011 at 2:12 PM, Jason Gerecke wrote: > This re-implements commit 9be9719d78af035c45ea4b191c21fab0ee54f198. > Ping pointed out the device_type field that I had somehow missed > when making the earlier commit. This provides essentially the same > information as the IsCu

Re: [Linuxwacom-devel] Higher Point Calibration

2011-11-12 Thread Jason Gerecke
On Sat, Nov 12, 2011 at 2:37 AM, Cedric Sodhi wrote: > Hello everybody, > > are there any intentions or just the possibility to calibrate Wacoms > with n-point (n+1-th order) maps? I assume there is a good reason why so > far we only have 1st-order/2-point mappings? I think this is a point > which

Re: [Linuxwacom-devel] [PATCH 4/4] Default to touch tool for multi-touch devices

2011-11-14 Thread Jason Gerecke
On Sun, Jun 26, 2011 at 5:44 PM, Peter Hutterer wrote: > On Sun, Jun 26, 2011 at 07:40:35PM -0500, Chris Bagwell wrote: >> On Sun, Jun 26, 2011 at 7:31 PM, Peter Hutterer >> wrote: >> > On Sat, Jun 25, 2011 at 01:05:52PM -0500, ch...@cnpbagwell.com wrote: >> >> From: Chris Bagwell >> >> >> >> We

Re: [Linuxwacom-devel] [PATCH 4/4] Default to touch tool for multi-touch devices

2011-11-14 Thread Jason Gerecke
On Mon, Nov 14, 2011 at 2:40 PM, Chris Bagwell wrote: > On Mon, Nov 14, 2011 at 3:48 PM, Jason Gerecke wrote: >> On Sun, Jun 26, 2011 at 5:44 PM, Peter Hutterer >> wrote: >>> On Sun, Jun 26, 2011 at 07:40:35PM -0500, Chris Bagwell wrote: >>>> On Sun, Jun

Re: [Linuxwacom-devel] [PATCH 4/4] Default to touch tool for multi-touch devices

2011-11-14 Thread Jason Gerecke
On Mon, Nov 14, 2011 at 3:08 PM, Chris Bagwell wrote: > On Mon, Nov 14, 2011 at 4:40 PM, Chris Bagwell wrote: >> On Mon, Nov 14, 2011 at 3:48 PM, Jason Gerecke wrote: >>> On Sun, Jun 26, 2011 at 5:44 PM, Peter Hutterer >>> wrote: >>>> On Sun, Jun 26,

Re: [Linuxwacom-devel] [PATCH 4/4] Default to touch tool for multi-touch devices

2011-11-14 Thread Jason Gerecke
On Mon, Nov 14, 2011 at 4:28 PM, Jason Gerecke wrote: > On Mon, Nov 14, 2011 at 3:08 PM, Chris Bagwell wrote: >> On Mon, Nov 14, 2011 at 4:40 PM, Chris Bagwell wrote: >>> On Mon, Nov 14, 2011 at 3:48 PM, Jason Gerecke wrote: >>>> On Sun, Jun 26, 2011 at 5:44

Re: [Linuxwacom-devel] wacom panel integrated in hp tablet 2710p crashes x

2011-11-17 Thread Jason Gerecke
On Wed, Nov 16, 2011 at 1:40 PM, Michael Spreng wrote: > Hello > > I already wrote on the discuss mailing list, to get my tablet working > again. Now I got a bit further, The device sows up as /dev/ttyS0, but it > crashes the X server: > > Backtrace: > 0: X (xorg_backtrace+0x28) [0x45fcb8] > 1: X

Re: [Linuxwacom-devel] [PATCH 2/3] default gesture distance values based on hw maximums

2011-11-23 Thread Jason Gerecke
, for all three patches: Reviewed-by: Jason Gerecke Jason --- Day xee-nee-svsh duu-'ushtlh-ts'it; nuu-wee-ya' duu-xan' 'vm-nvshtlh-ts'it. Huu-chan xuu naa~-gha. On Tue, Nov 22, 2011 at 7:39 PM, wrote: > From: Chris Bagwell > > 2 finger Gestures

Re: [Linuxwacom-devel] Gesture HW-based fixes on github

2011-11-28 Thread Jason Gerecke
On Sat, Nov 26, 2011 at 4:45 PM, Chris Bagwell wrote: > The following changes since commit 31dbd9fc9fdd3691d9ef43c707ecc780e0c62d24: > >  xf86-input-wacom 0.12.0 (2011-11-15 11:21:46 -0800) > > are available in the git repository at: >  git://github.com/cbagwell/xf86-input-wacom.git gesture5 > > C

Re: [Linuxwacom-devel] wacom panel integrated in hp tablet 2710p crashes x

2011-11-29 Thread Jason Gerecke
; After writing an if(file) in front of the fclose, it crashes in > /lib64/ld-linux-x86-64.so.2, called from xf86SetSerialSpeed, for which I > do not have debug symbols yet. Also needs more investigation. > > Michael > > On 17.11.2011 18:47, Jason Gerecke wrote: >> On Wed, Nov 16,

Re: [Linuxwacom-devel] [PATCH 2/3] Input: wacom - remove unneeded ABS_MISC events

2011-12-07 Thread Jason Gerecke
This patch breaks puck buttons on the Graphire 3. Motion gets through fine, but clicking (left, middle, or right) is impossible. Interestingly, scrolling still works. Graphire 4 is unaffected. Jason --- Day xee-nee-svsh duu-'ushtlh-ts'it; nuu-wee-ya' duu-xan' 'vm-nvshtlh-ts'it. Huu-chan xuu naa~-

Re: [Linuxwacom-devel] [PATCH 3/3] Input: wacom - refactor grapire irq handler

2011-12-07 Thread Jason Gerecke
This patch breaks the Graphire 4. The X driver appears to get confused about what buttons are being pressed. This happens with all tools, from what I can tell. Only the right mouse button appears to work correctly, and can be used to get the driver back in sync with reality until you make another n

Re: [Linuxwacom-devel] [PATCH 3/3] Input: wacom - refactor grapire irq handler

2011-12-07 Thread Jason Gerecke
On Wed, Dec 7, 2011 at 12:42 PM, Chris Bagwell wrote: > On Wed, Dec 7, 2011 at 2:16 PM, Jason Gerecke wrote: >> This patch breaks the Graphire 4. The X driver appears to get confused >> about what buttons are being pressed. This happens with all tools, >> from what I can

Re: [Linuxwacom-devel] [PATCH 2/3] Input: wacom - remove unneeded ABS_MISC events

2011-12-07 Thread Jason Gerecke
hris Bagwell wrote: > On Wed, Dec 7, 2011 at 2:14 PM, Jason Gerecke wrote: >> This patch breaks puck buttons on the Graphire 3. Motion gets through >> fine, but clicking (left, middle, or right) is impossible. >> Interestingly, scrolling still works. Graphire 4 is unaffect

[Linuxwacom-devel] [PATCH v3 1/5] Add basic support for Cintiq 24HD

2011-12-13 Thread Jason Gerecke
Adds the Cintiq 24HD (056a:00f4) to the device lists. The 24HD has two features not found on prior tablets: three capacitive buttons, and a second touch ring. Subsuquent patches will address adding support for them. Signed-off-by: Jason Gerecke --- src/wcmUSB.c|1 + src

[Linuxwacom-devel] [PATCH v3 4/5] Expose the second touch ring's raw value in a new 7th valuator

2011-12-13 Thread Jason Gerecke
This patch expands the number of valuators reported by devices to seven. The new seventh valuator reports the raw value provided from the kernel for the second touch ring. Signed-off-by: Jason Gerecke --- src/wcmCommon.c | 11 +++ src/xf86Wacom.c | 28 ++-- 2

[Linuxwacom-devel] [PATCH v3 2/5] Add 'abswheel2' to device state for dual-ring devices

2011-12-13 Thread Jason Gerecke
This patch adds an 'abswheel2' field to the _WacomDeviceState structure, along with corresponding 'oldWheel2' field to the _WacomDeviceRec structure. These fields store the state of the second touch ring on dual-ring devices such as the Cintiq 24HD. Signed-off-by: Jas

[Linuxwacom-devel] [PATCH v3 5/5] De-duplicate code for wheel/strip scrolling

2011-12-13 Thread Jason Gerecke
returning a single button/action. Signed-off-by: Jason Gerecke --- src/wcmCommon.c | 206 --- 1 files changed, 121 insertions(+), 85 deletions(-) diff --git a/src/wcmCommon.c b/src/wcmCommon.c index 0e719cf..170d1d0 100644 --- a/src/wcmCommon.c

[Linuxwacom-devel] [PATCH v3 3/5] Have the second touch ring emulate wheel events by default

2011-12-13 Thread Jason Gerecke
Touch strips as well as the first touch ring are set up to emulate mouse wheel events by default. This patch duplicates this behavior for the second touch ring, so that it behaves in an identical manner. Signed-off-by: Jason Gerecke --- src/wcmCommon.c | 29

[Linuxwacom-devel] [PATCH v4 2/5] Add 'abswheel2' to device state for dual-ring devices

2011-12-13 Thread Jason Gerecke
This patch adds an 'abswheel2' field to the _WacomDeviceState structure, along with corresponding 'oldWheel2' field to the _WacomDeviceRec structure. These fields store the state of the second touch ring on dual-ring devices such as the Cintiq 24HD. Signed-off-by: Jason Gerec

Re: [Linuxwacom-devel] [PATCH 2/3] test: add more #defines to fix build issues.

2011-12-19 Thread Jason Gerecke
ZE(parameters) == 34); > +       assert(ARRAY_SIZE(parameters) == 36); >        assert(ARRAY_SIZE(deprecated_parameters) == 17); >  } > > -- > 1.7.7.1 > Aside from the change I need to make to xsetwacom accidentally slipping its way in to this patch... For the series: Reviewed

Re: [Linuxwacom-devel] [PATCH v3 5/5] De-duplicate code for wheel/strip scrolling

2011-12-19 Thread Jason Gerecke
On Sun, Dec 18, 2011 at 10:06 PM, Peter Hutterer wrote: > On Tue, Dec 13, 2011 at 01:59:02PM -0800, Jason Gerecke wrote: >> Replaces sendWheelStripEvents and getWheelButton with several >> small functions to reduce unnecessary code duplication. >> >> As a side-effect,

[Linuxwacom-devel] [PATCH v5 2/5] Add basic support for Cintiq 24HD

2011-12-21 Thread Jason Gerecke
Adds the Cintiq 24HD (056a:00f4) to the device lists. The 24HD has two features not found on prior tablets: three capacitive buttons, and a second touch ring. Subsuquent patches will address adding support for them. Signed-off-by: Jason Gerecke Reviewed-by: Chris Bagwell Reviewed-by: Peter

[Linuxwacom-devel] [PATCH v5 4/5] Have the second touch ring emulate wheel events by default

2011-12-21 Thread Jason Gerecke
Touch strips as well as the first touch ring are set up to emulate mouse wheel events by default. This patch duplicates this behavior for the second touch ring, so that it behaves in an identical manner. Signed-off-by: Jason Gerecke --- Changes from v3: * Move after de-duplication patch

[Linuxwacom-devel] [PATCH v5 1/5] De-duplicate code for wheel/strip scrolling

2011-12-21 Thread Jason Gerecke
returning a single button/action. Signed-off-by: Jason Gerecke --- Changes from v3: * Move to head of patchset * Add tests for getScrollDelta and getWheelButton * Fix bugs in getScrollDelta doc (wrap is max, not max+1) * Fix bugs in getScrollDelta implementation * log2(0) is undef; caused

[Linuxwacom-devel] [PATCH v5 5/5] Expose the second touch ring's raw value in a new 7th valuator

2011-12-21 Thread Jason Gerecke
This patch expands the number of valuators reported by devices to seven. The new seventh valuator reports the raw value provided from the kernel for the second touch ring. Signed-off-by: Jason Gerecke Reviewed-by: Peter Hutterer Reviewed-by: Chris Bagwell --- src/wcmCommon.c | 11

[Linuxwacom-devel] [PATCH v5 3/5] Add 'abswheel2' to device state for dual-ring devices

2011-12-21 Thread Jason Gerecke
This patch adds an 'abswheel2' field to the _WacomDeviceState structure, along with corresponding 'oldWheel2' field to the _WacomDeviceRec structure. These fields store the state of the second touch ring on dual-ring devices such as the Cintiq 24HD. Signed-off-by: Jason

Re: [Linuxwacom-devel] [PATCH v5 1/5] De-duplicate code for wheel/strip scrolling

2011-12-29 Thread Jason Gerecke
On Wed, Dec 21, 2011 at 9:27 PM, Peter Hutterer wrote: > On Wed, Dec 21, 2011 at 03:28:54PM -0800, Jason Gerecke wrote: >> Replaces sendWheelStripEvents and getWheelButton with several >> small functions to reduce unnecessary code duplication. >> >> As a side-effect,

[Linuxwacom-devel] Getting Ready for 0.13

2011-12-29 Thread Jason Gerecke
Its been six weeks since 0.12 was released, so I'd like to start looking at getting 0.13 out of the door. There are a few patches in need of review, and a couple bug reports that need further action. I'll be making the RC1 release on Saturday, so now's the time to submit/review/nominate anything yo

Re: [Linuxwacom-devel] [PATCH] lib: Don't export private symbols

2012-01-11 Thread Jason Gerecke
I've been meaning to get around to fixing up and submitting the Solaris patches that were submitted a while back (they work fine, but are in need of some editing)... Higher priority projects keep appearing on my plate before I can do much with it, but I'd still like to keep the GNU-isms to a minimu

Re: [Linuxwacom-devel] [PATCH v2] Enable LED status change through xsetwacom

2012-01-20 Thread Jason Gerecke
On Thu, Jan 19, 2012 at 8:12 PM, Peter Hutterer wrote: > CC-ing Eduard, since he's been working on this as well > > On Wed, Jan 18, 2012 at 08:15:47PM -0600, Chris Bagwell wrote: >> Well, this showed up just in time for me to be conflicted.  I've >> completed support for monitoring the battery on

Re: [Linuxwacom-devel] [PATCH v2] Enable LED status change through xsetwacom

2012-01-20 Thread Jason Gerecke
Ping's out for a little while, so I'll be taking over the patch. I've got other stuff on my plate though, so it may take some time to fold in the changes. On Thu, Jan 19, 2012 at 8:13 PM, Peter Hutterer wrote: > Thank you, I CC'd Eduard here to, he may have some comments related to his > code. >

Re: [Linuxwacom-devel] [PATCH v2] Enable LED status change through xsetwacom

2012-01-23 Thread Jason Gerecke
On Sun, Jan 22, 2012 at 8:43 PM, Peter Hutterer wrote: > On Fri, Jan 20, 2012 at 10:56:23AM -0800, Jason Gerecke wrote: >> Ping's out for a little while, so I'll be taking over the patch. I've >> got other stuff on my plate though, so it may take some time to fold &

Re: [Linuxwacom-devel] [PATCH v2] Enable LED status change through xsetwacom

2012-01-23 Thread Jason Gerecke
On Sun, Jan 22, 2012 at 8:49 PM, Peter Hutterer wrote: > On Fri, Jan 20, 2012 at 10:55:59AM -0800, Jason Gerecke wrote: >> On Thu, Jan 19, 2012 at 8:12 PM, Peter Hutterer >> wrote: >> > CC-ing Eduard, since he's been working on this as well >> > >>

Re: [Linuxwacom-devel] [PATCH v2] Enable LED status change through xsetwacom

2012-01-23 Thread Jason Gerecke
On Mon, Jan 23, 2012 at 3:36 PM, Peter Hutterer wrote: > On Mon, Jan 23, 2012 at 10:30:34AM -0800, Jason Gerecke wrote: >> On Sun, Jan 22, 2012 at 8:49 PM, Peter Hutterer >> wrote: >> > On Fri, Jan 20, 2012 at 10:55:59AM -0800, Jason Gerecke wrote: >> >> On

[Linuxwacom-devel] [PATCH v3] Enable LED status change through xsetwacom

2012-01-25 Thread Jason Gerecke
Signed-off-by: Jason Gerecke --- Changes from v2: Deduplicate storing in sysfs Deduplicate fd closing Deduplicate LED setting by looping through all groups Change wording of xsetwacom property description Consolidate led{0,1}_status variables into led_status array Stop

Re: [Linuxwacom-devel] [PATCH v3] Enable LED status change through xsetwacom

2012-01-25 Thread Jason Gerecke
u naa~-gha. On Wed, Jan 25, 2012 at 1:54 PM, Jason Gerecke wrote: > Signed-off-by: Jason Gerecke > --- > Changes from v2: >    Deduplicate storing in sysfs >    Deduplicate fd closing >    Deduplicate LED setting by looping through all groups >    Change wording of xs

[Linuxwacom-devel] [PATCH 1/4] Update stylus definitions

2012-01-30 Thread Jason Gerecke
Information compiled from public information cross-referenced with internal Wacom documents. Note that IDs 0x012, 0x022, 0x032, 0x112, and 0x0fa are not listed in the documents I have available. I'm not sure if they're legitimate IDs or not. Signed-off-by: Jason Gerecke

[Linuxwacom-devel] [PATCH 2/4] data: Update existing and add new tablets to database

2012-01-30 Thread Jason Gerecke
Adds most professional tablets to the database, and updates items which are incorrect. Signed-off-by: Jason Gerecke --- data/cintiq-12wx.tablet| 14 ++ data/cintiq-20wsx.tablet | 14 ++ data/cintiq-21ux.tablet|4 +++- data/cintiq-21ux2.tablet | 11

[Linuxwacom-devel] [PATCH 3/4] Introduce Puck type and IDs

2012-01-30 Thread Jason Gerecke
Since I have them handy, it only makes sense to add them as well. Signed-off-by: Jason Gerecke --- data/intuos-12x12.tablet |2 +- data/intuos-12x18.tablet |2 +- data/intuos-4x5.tablet |2 +- data/intuos-6x8.tablet |2 +- data/intuos-9x12.tablet |2

[Linuxwacom-devel] [PATCH 4/4] data: Add additional metadata that isn't yet representable

2012-01-30 Thread Jason Gerecke
Adds in additional metadata that doesn't currently have a way of being formally expressed. All hail ASCII art. Signed-off-by: Jason Gerecke --- data/cintiq-12wx.tablet| 32 data/cintiq-20wsx.tablet | 36 data/c

Re: [Linuxwacom-devel] [PATCH 1/4] Update stylus definitions

2012-01-31 Thread Jason Gerecke
On Tue, Jan 31, 2012 at 7:14 AM, Bastien Nocera wrote: > Jason Gerecke writes: > >> >> Information compiled from public information cross-referenced >> with internal Wacom documents. > > Awesome! > > Do you have stylus definitions for the Graphire and oth

Re: [Linuxwacom-devel] [PATCH 4/4] data: Add additional metadata that isn't yet representable

2012-01-31 Thread Jason Gerecke
On Tue, Jan 31, 2012 at 7:16 AM, Bastien Nocera wrote: > Jason Gerecke writes: > >> >> Adds in additional metadata that doesn't currently have a way of >> being formally expressed. All hail ASCII art. > > Very interesting data, I can't imagine how long it

Re: [Linuxwacom-devel] [PATCH 4/4] data: Add additional metadata that isn't yet representable

2012-02-02 Thread Jason Gerecke
On Thu, Feb 2, 2012 at 7:56 AM, Bastien Nocera wrote: > Jason Gerecke writes: >> Thankfully, not too terribly long. I've got representatives of most of >> the tablets handy, though some with different button layouts (e.g. >> Intuos4 Small) were guesses. > > I

Re: [Linuxwacom-devel] libwacom

2012-02-02 Thread Jason Gerecke
On Thu, Feb 2, 2012 at 12:09 PM, Chris Bagwell wrote: > On Thu, Feb 2, 2012 at 12:31 PM, Bastien Nocera wrote: >> On Thu, 2012-02-02 at 11:55 -0600, Favux ... wrote: >>> Hi Bastien, >>> >>> Thanks for reviewing the wiki page. >>> >>> On Thu, Feb 2, 2012 at 10:31 AM, Bastien Nocera wrote: >>> >>>

Re: [Linuxwacom-devel] [PATCH 4/4] data: Add additional metadata that isn't yet representable

2012-02-02 Thread Jason Gerecke
On Thu, Feb 2, 2012 at 11:27 AM, Bastien Nocera wrote: > On Thu, 2012-02-02 at 11:16 -0800, Jason Gerecke wrote: >> On Thu, Feb 2, 2012 at 7:56 AM, Bastien Nocera wrote: >> > Jason Gerecke writes: >> >> Thankfully, not too terribly long. I've got represent

Re: [Linuxwacom-devel] [PATCH v3] Enable LED status change through xsetwacom

2012-02-08 Thread Jason Gerecke
On Wed, Jan 25, 2012 at 1:57 PM, Jason Gerecke wrote: > This covers most of the suggested changes. I'm not sure yet how we > want to expose the properties through X, so changes regarding that > haven't been folded in. > > Jason > > --- > Day xee-nee-svsh duu-&#

[Linuxwacom-devel] [PATCH] Remove redundant redeclaration of 'wcmInitialScreens'

2012-02-09 Thread Jason Gerecke
>From GCC: In file included from ../src/xf86Wacom.c:46:0: ../src/xf86Wacom.h:147:13: warning: redundant redeclaration of 'wcmInitialScreens' [-Wredundant-decls] ../src/xf86Wacom.h:146:13: note: previous declaration of 'wcmInitialScreens' was here Signe

[Linuxwacom-devel] [PATCH] Check for appropriate number of properties when setting buttons

2012-02-09 Thread Jason Gerecke
the proper size. Signed-off-by: Jason Gerecke --- src/wcmXCommand.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/src/wcmXCommand.c b/src/wcmXCommand.c index d0963f1..0fd5664 100644 --- a/src/wcmXCommand.c +++ b/src/wcmXCommand.c @@ -849,7 +849,8 @@ int wcmSetProperty

[Linuxwacom-devel] [PATCH] Remove AC_CORE status print

2012-02-09 Thread Jason Gerecke
Flag is deprecated, has no effect, and serves no purpose anymore. Remove from the DBG statement. Signed-off-by: Jason Gerecke --- src/wcmCommon.c |5 ++--- 1 files changed, 2 insertions(+), 3 deletions(-) diff --git a/src/wcmCommon.c b/src/wcmCommon.c index 11340ea..034a3a3 100644 --- a

[Linuxwacom-devel] [PATCH] Extend length of wheel_actions array to 6

2012-02-17 Thread Jason Gerecke
This array was apparently overlooked when adding support for the second touch ring present on the 24HD. Signed-off-by: Jason Gerecke --- src/xf86WacomDefs.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/xf86WacomDefs.h b/src/xf86WacomDefs.h index ef425f5..625b07e

Re: [Linuxwacom-devel] [SOLVED] Pad buttons on Intuos4 WL (bluetooth and USB connection)

2012-02-27 Thread Jason Gerecke
On Mon, Feb 27, 2012 at 5:29 AM, Przemo Firszt wrote: > Dnia 2012-02-27, pon o godzinie 10:54 +, Przemo Firszt pisze: >> I'm experiencing some problems with pad buttons. They are not >> overlapping with pen buttons (that's OK), but if I try to redefine them >> using: >> >> xsetwacom --set "Wac

[Linuxwacom-devel] [PATCH 0/4] Driver cleanup

2012-02-27 Thread Jason Gerecke
This set of patches does some cleaning up of the driver. The first two patches are somewhat related, as are the last two. Patch 3 may be somewhat contraversial since it removes functionality that 3rd- party utilities may rely on (though I would have expected to hear people mentioning the "This is a

[Linuxwacom-devel] [PATCH 2/4] Replace multiple default variables with arrays

2012-02-27 Thread Jason Gerecke
Storing the defaults for strips and wheels in individual variables makes updating and scanning through them very tedious. This patch replaces the variables with arrays and introduces new #define statements to keep the level of semantic meaning we had. Signed-off-by: Jason Gerecke --- src

[Linuxwacom-devel] [PATCH 1/4] Directly index into the various *keys arrays

2012-02-27 Thread Jason Gerecke
ons has been removed, systems which set both raw *and* action button mappings will appear to have the button number associated with actions change. Since the only way to set raw button mappings is via xorg.conf, there is little expected fallout from this change. Signed-off-by: Jason Gerecke --- src/wc

[Linuxwacom-devel] [PATCH 3/4] Remove support for 8-bit (raw button) strip/ring properties

2012-02-27 Thread Jason Gerecke
, but the actual fallout is expected to be minimal. Applications which don't understand Actions are already broken (since they can't work with buttons) and those that do understand Actions but don't use them can be easily modified. Signed-off-by: Jason Gerecke --- src/wcmXC

[Linuxwacom-devel] [PATCH 4/4] Cleanup call chain for action properties

2012-02-27 Thread Jason Gerecke
This patch rewrites the call chains used for setting the three action properties by introducing a single function to handle the 'Actions' properties, and a single function for 'Action' properties. Functions which were merely helper functions have been inlined if appropriate.

Re: [Linuxwacom-devel] [PATCH] Export current tool ID in the property too

2012-02-29 Thread Jason Gerecke
6WacomDefs.h > index ef425f5..01aa4d4 100644 > --- a/src/xf86WacomDefs.h > +++ b/src/xf86WacomDefs.h > @@ -226,6 +226,7 @@ struct _WacomDeviceRec >        double factorY;         /* Y factor */ >        unsigned int serial;    /* device serial number this device takes (if > 0, an

Re: [Linuxwacom-devel] [PATCH 3/3] xsetwacom: fix compiler warning

2012-02-29 Thread Jason Gerecke
_user(param, argv[0], &head_no)) > -               success = set_output_xinerama(dpy, dev, head_no); > +               set_output_xinerama(dpy, dev, head_no); >        else >                fprintf(stderr, "Unable to find an output '%s'.\n", argv[0]); >  } > -- > 1

Re: [Linuxwacom-devel] [PATCH] wcmXCommand: Fix invalid array size for serial values.

2012-03-05 Thread Jason Gerecke
On Thu, Mar 1, 2012 at 1:24 PM, Peter Hutterer wrote: > From: Colin Walters > > Introduced in c21b6876b435bb34112956716fea14477ef9e8d7 > > Signed-off-by: Peter Hutterer > --- > oops. > >  src/wcmXCommand.c |    2 +- >  1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/src/wcmXCom

Re: [Linuxwacom-devel] Tilt value meaning

2012-03-07 Thread Jason Gerecke
On Wed, Mar 7, 2012 at 2:10 PM, Chris Bagwell wrote: > On Wed, Mar 7, 2012 at 2:18 PM, Nikolai Kondrashov wrote: >> Hi everyone, >> >> Today I've started implementing a driver for Waltop Sirius Battery Free >> tablet. As it turns out, it reports pen tilting, which is a rare thing for >> non-Wacom

Re: [Linuxwacom-devel] Tilt value meaning

2012-03-08 Thread Jason Gerecke
On Thu, Mar 8, 2012 at 4:14 AM, Nikolai Kondrashov wrote: > On 03/08/2012 02:18 AM, Jason Gerecke wrote: >> >> Our kernel driver reports values from [0, 127] with 0 corresponding to >> top/left and 127 to bottom/right. The midpoint is assumed to be >> vertic

Re: [Linuxwacom-devel] [PATCH 1/2] HID: wacom: Reset stylus buttons - Intuos4 WL

2012-03-09 Thread Jason Gerecke
vger.kernel.org > More majordomo info at  http://vger.kernel.org/majordomo-info.html Reviewed-by: Jason Gerecke Jason --- Day xee-nee-svsh duu-'ushtlh-ts'it; nuu-wee-ya' duu-xan' 'vm-nvshtlh-ts'it. Huu-chan xuu naa~-gha. ---

Re: [Linuxwacom-devel] [PATCH 2/2] HID: wacom: Add reporting of wheel for Intuos4 WL

2012-03-09 Thread Jason Gerecke
On Fri, Mar 9, 2012 at 5:20 AM, Przemo Firszt wrote: > This patch adds reporting of ABS_WHEEL event. Raported walues are 0..71 > and are related to absolute location of the finger on the wheel. > > Signed-off-by: Przemo Firszt > --- >  drivers/hid/hid-wacom.c |   19 +++ >  1 files

Re: [Linuxwacom-devel] [PATCH] HID: wacom: Add reporting of wheel for Intuos4 WL

2012-03-09 Thread Jason Gerecke
        if (new_whlstate & 0x10) { Should be 0x80 to get the highest bit. Aside from that issue though: Reviewed-by: Jason Gerecke Jason --- Day xee-nee-svsh duu-'ushtlh-ts'it; nuu-wee-ya' duu-xan' 'vm-nvshtlh-ts'it. Huu-chan xuu naa~-gha. > +      

[Linuxwacom-devel] [PATCH 1/4] input: wacom: Intuos5 basic support

2012-03-09 Thread Jason Gerecke
This patch adds support for the basic pen functions of Intuos5 tablets. --- drivers/input/tablet/wacom_wac.c | 36 +--- drivers/input/tablet/wacom_wac.h |3 +++ 2 files changed, 36 insertions(+), 3 deletions(-) diff --git a/drivers/input/tablet/wacom_wac.c b/

[Linuxwacom-devel] [PATCH 2/4] input: wacom: Intuos5 Touch Ring/ExpressKey support

2012-03-09 Thread Jason Gerecke
Intuos5 uses a new report type for Touch Ring and ExpressKey data. Note that data from the capacitive sensors present on the ExpressKeys will be ignored until a proper way is found to expose it. --- drivers/input/tablet/wacom_wac.c | 33 +++-- drivers/input/tablet/wac

[Linuxwacom-devel] [PATCH 3/4] input: wacom: Intous5 Touch Ring LED support

2012-03-09 Thread Jason Gerecke
The Touch Ring LEDs on Intuos5 tablets use a different report format which supports only 4 levels of brightness. We remap the 7-bit value obtained from sysfs to an appropriate value for the tablet. Control of the crop mark LEDs (new to the I5) is left for a later patch. --- Documentation/ABI/testi

[Linuxwacom-devel] [PATCH 4/4] input: wacom: Intuos5 multitouch sensor support

2012-03-09 Thread Jason Gerecke
Intuos5 tablets with PTH-* model numbers include a multitouch sensor which use the same touch reports as the 3rd-generation Bamboo. No useful information is in the HID descriptor for the touch interface so hardcoded values are used during setup. --- drivers/input/tablet/wacom_sys.c | 24

[Linuxwacom-devel] [PATCH] Add support for the Intuos5

2012-03-12 Thread Jason Gerecke
Signed-off-by: Jason Gerecke --- src/wcmUSB.c|7 +++ src/wcmValidateDevice.c |5 + 2 files changed, 12 insertions(+), 0 deletions(-) diff --git a/src/wcmUSB.c b/src/wcmUSB.c index a2d30da..472f470 100644 --- a/src/wcmUSB.c +++ b/src/wcmUSB.c @@ -98,6 +98,7

[Linuxwacom-devel] [PATCH v2 4/4] input: wacom: Intuos5 multitouch sensor support

2012-03-12 Thread Jason Gerecke
Intuos5 tablets with PTH-* model numbers include a multitouch sensor which use the same touch reports as the 3rd-generation Bamboo. No useful information is in the HID descriptor for the touch interface so hardcoded values are used during setup. Signed-off-by: Jason Gerecke --- Changes from v1

[Linuxwacom-devel] [PATCH] input: wacom: Fix physical size calculation for 3rd-gen Bamboo

2012-03-12 Thread Jason Gerecke
amboo since the resolution and scale factor happen to be identical, but will produce an incorrect result for other cases. Signed-off-by: Jason Gerecke --- drivers/input/tablet/wacom_sys.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/input/tablet/wacom_sys.c b/dr

Re: [Linuxwacom-devel] [PATCH] Add support for the Intuos5

2012-03-12 Thread Jason Gerecke
On Mon, Mar 12, 2012 at 3:48 PM, Bastien Nocera wrote: > Em Mon, 2012-03-12 às 15:22 -0700, Jason Gerecke escreveu: >> Signed-off-by: Jason Gerecke > > Can I have the same one for libwacom? :) > libwacom patch pushed up to the repo :) Jason --- Day xee-nee-svsh duu-'u

[Linuxwacom-devel] [PATCH] Don't share names of action atoms across properties

2012-03-14 Thread Jason Gerecke
revent this aliasing from occuring. Signed-off-by: Jason Gerecke --- tools/xsetwacom.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/tools/xsetwacom.c b/tools/xsetwacom.c index 2c546b1..7cf0d05 100644 --- a/tools/xsetwacom.c +++ b/tools/xsetwacom.c @@ -1264,7 +1

Re: [Linuxwacom-devel] [PATCH] Don't share names of action atoms across properties

2012-03-14 Thread Jason Gerecke
eftUp" "key +g -g" > $ xsetwacom --get "Wacom Intuos3 6x8 pad" "StripLeftUp" > key +g -g > $ xsetwacom --set "Wacom Intuos3 6x8 pad" "Button" "1" "key +h -h" > $ xsetwacom --get "Wacom Intuos3 6x8 pad"

Re: [Linuxwacom-devel] [PATCH libwacom] data: Add missing [Buttons] section to Intuos, Cintiq series

2012-03-28 Thread Jason Gerecke
h-l.tablet > index d3c2571..cbd2685 100644 > --- a/data/intuos5-touch-l.tablet > +++ b/data/intuos5-touch-l.tablet > @@ -59,5 +59,7 @@ Ring=true >  BuiltIn=false > >  [Buttons] > +Left=A;B;C;D;E;F;G;H;I > + >  Ring=A >  RingNumModes=4 > diff --git a/data/intuos5-to

Re: [Linuxwacom-devel] [PATCH libwacom] data: add DTU-720, DTU-1631 and DTU-2231 to tablet database

2012-03-28 Thread Jason Gerecke
fied the info is correct for the 2231. > + > +[Device] > +Name=Wacom DTU-2231 > +DeviceMatch=usb:056a:00ce > +Width=19 > +Height=11 > + > +[Features] > +Stylus=true > +Buttons=0 > +BuiltIn=true > + > -- > 1.7.7.6 > > Reviewed-by: Jason Gerecke Jason

Re: [Linuxwacom-devel] [PATCH libwacom] data: update Graphire series

2012-03-28 Thread Jason Gerecke
* > +#      |                      | > +#      |                      | > +#      |                      | > +#      |        TABLET        | > +#      |                      | > +#      |                      | > +#      |                      | > +#      *--* > +# >  [Device] >  Name=Wacom Graphire4 4x5 >  DeviceMatch=usb:056a:0015 > @@ -7,3 +25,7 @@ Height=4 > &

[Linuxwacom-devel] [PATCH input-wacom 2/2] backport: add LED support for Cintiq 24HD

2012-03-28 Thread Jason Gerecke
Based on upstream commit 246835fccdc0dadeda20cd51f7ec868031fa8142 Signed-off-by: Jason Gerecke --- 2.6.30/wacom_sys.c |5 - 2.6.36/wacom_sys.c |5 - 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/2.6.30/wacom_sys.c b/2.6.30/wacom_sys.c index d460d6d..41dd54b

[Linuxwacom-devel] [PATCH input-wacom 1/2] backport: add support for Cintiq 24HD

2012-03-28 Thread Jason Gerecke
Based on upstream commit 803296b678a43005e3bc0aaa1951d211bd76a054 Signed-off-by: Jason Gerecke --- 2.6.30/wacom_wac.c | 77 +++- 2.6.30/wacom_wac.h |1 + 2.6.36/wacom_wac.c | 77 +++- 2.6.36

[Linuxwacom-devel] [PATCH linuxwacom] Specify correct buffer size in wacom_query_tablet_data

2012-03-28 Thread Jason Gerecke
Changes the spciefied buffer size from 3 bytes to 2 bytes to match the amount we allocated. Hasn't caused problems yet, but probably could. Signed-off-by: Jason Gerecke --- src/2.6.16/wacom_sys.c |2 +- src/2.6.30/wacom_sys.c |2 +- 2 files changed, 2 insertions(+), 2 deletions(-)

Re: [Linuxwacom-devel] [PATCH input-wacom 1/2] backport: add support for Cintiq 24HD

2012-03-29 Thread Jason Gerecke
On Thu, Mar 29, 2012 at 6:54 AM, Chris Bagwell wrote: > On Wed, Mar 28, 2012 at 12:31 PM, Ping Cheng wrote: >> On Wed, Mar 28, 2012 at 9:29 AM, Jason Gerecke wrote: >>> Based on upstream commit 803296b678a43005e3bc0aaa1951d211bd76a054 >>> >>> Signed-off-by:

Re: [Linuxwacom-devel] [PATCH 1/1] Use kernel-reported tilt range and resolution

2012-03-29 Thread Jason Gerecke
I've been meaning to get around to reviewing your patch (I'm glad to see you taking it on!), but have been pretty busy lately. Sorry for the delay... On Thu, Mar 22, 2012 at 12:37 PM, Nikolai Kondrashov wrote: > Use tilt range and, optionally, resolution reported by the kernel for event > devices

<    1   2   3   4   5   6   7   8   9   10   >