labath added inline comments.
Comment at: source/Host/posix/DomainSocket.cpp:74
@@ +73,3 @@
+FileSystem::Unlink(FileSpec{name, true});
+
+Error error;
If we're going to use unique names, then this won't be necessary (and I would
much rather see a random e
labath added a subscriber: labath.
labath added a comment.
Not really my area, but couldn't the needed functionality be implemented on top
of GetChildAtIndex(). I mean, if GetChildAtIndex(50) returns a valid SBValue,
then the container has at least 50 elements, right?
Then `HasAtLeastNChildren(n
Author: ewancrawford
Date: Fri Oct 16 03:28:47 2015
New Revision: 250499
URL: http://llvm.org/viewvc/llvm-project?rev=250499&view=rev
Log:
Resubmit: RenderScript command for printing allocation contents
Previous commit r250281 broke TestDataFormatterSmartArray.py
Resolved in in this patch by ad
This revision was automatically updated to reflect the committed changes.
Closed by commit rL250499: Resubmit: RenderScript command for printing
allocation contents (authored by EwanCrawford).
Changed prior to commit:
http://reviews.llvm.org/D13730?vs=37356&id=37562#toc
Repository:
rL LLVM
labath added a comment.
Zachary, I don't think using std::async is a good idea because it provides a
very different threading model than the one we want here. Let me demonstrate
that with an example:
#include
#include
#include
#include
#include
using namespace std;
u
Author: labath
Date: Fri Oct 16 04:32:05 2015
New Revision: 250502
URL: http://llvm.org/viewvc/llvm-project?rev=250502&view=rev
Log:
Fix temporary directory computation on linux (pr25147)
Summary:
On linux, the environment variables for temp directories that lldb checks for
are generally not
def
This revision was automatically updated to reflect the committed changes.
Closed by commit rL250502: Fix temporary directory computation on linux
(pr25147) (authored by labath).
Changed prior to commit:
http://reviews.llvm.org/D13772?vs=37485&id=37565#toc
Repository:
rL LLVM
http://reviews.
evgeny777 created this revision.
evgeny777 added reviewers: granata.enrico, ki.stfu, abidh.
evgeny777 added subscribers: lldb-commits, KLapshin.
Current revision do not use lldb type summaries for simple types with no
children (like function pointers). So this patch makes MI use lldb type
summar
tberghammer updated this revision to Diff 37566.
tberghammer added a comment.
Create optional std::async based implementation
http://reviews.llvm.org/D13727
Files:
include/lldb/Utility/TaskPool.h
source/Utility/CMakeLists.txt
source/Utility/TaskPool.cpp
unittests/Utility/CMakeLists.txt
tberghammer added a comment.
Based on Pavel's example and some additional experimenting we done I am not
sure if std::async will give us any benefit even on Windows as it don't limit
the number of threads to the number of cores (because it can't do if it want to
implement the standard). I have
labath added a comment.
In http://reviews.llvm.org/D13727#268747, @tberghammer wrote:
> Based on Pavel's example and some additional experimenting we done I am not
> sure if std::async will give us any benefit even on Windows as it don't limit
> the number of threads to the number of cores (bec
sivachandra added a comment.
There could be an error reading the k-th element for k < n.In which case, we
will wrongly conclude that there are only k-1 elements.
http://reviews.llvm.org/D13778
___
lldb-commits mailing list
lldb-commits@lists.llvm.o
labath added a comment.
How big of an error does it have to be for that to happen? Is that something we
would consider an "lldb bug"/"data formatter bug" or it can be caused by
something out of our control, like missing debug info on one of the children?
http://reviews.llvm.org/D13778
_
tfiala added a comment.
I'm in agreement with Pavel's assessment on this.
Regarding the tests, I had brought that up with Greg earlier. We can handle
that in a few different ways:
- We do nothing, and perhaps some collections of tests run slower if they are
all pounding on their thread pools
labath created this revision.
labath added reviewers: clayborg, tberghammer.
labath added a subscriber: lldb-commits.
Herald added subscribers: srhines, danalbert, tberghammer.
ADB packets have a fixed size of 4k. This means the size of memory reads does
not affect speed
too much (as long as it f
zturner accepted this revision.
zturner added a comment.
Your example makes sense. So go ahead and delete the std async implementation
for now. As Tamas said, its very easy to put in, so a better thing to do
perhaps is once there's something doing actual parallel work, just test it in a
real
zturner added a comment.
Sorry, should have mentioned that the lgtm is contingent on Todd's concerns. I
like the idea of having a setting in LLDB that controls the maximum number of
threads to use for parallel work. We should probably set this at a very h igh
level in dotest so that all insta
ovyalov added inline comments.
Comment at: source/Host/posix/DomainSocket.cpp:74
@@ +73,3 @@
+FileSystem::Unlink(FileSpec{name, true});
+
+Error error;
labath wrote:
> If we're going to use unique names, then this won't be necessary (and I would
> much ra
Author: zturner
Date: Fri Oct 16 11:39:18 2015
New Revision: 250525
URL: http://llvm.org/viewvc/llvm-project?rev=250525&view=rev
Log:
Update SWIG typemaps to use `PythonFile`.
Using the Python native C API is non-portable across Python versions,
so this patch changes them to use the `PythonFile`
granata.enrico added inline comments.
Comment at: tools/lldb-mi/MICmnLLDBDebugger.cpp:37
@@ +36,3 @@
+return false;
+stream.Printf("%d %s", (int)value.GetValueAsSigned(), value.GetValue());
+return true;
I would definitely not stop the revision for
evgeny777 added inline comments.
Comment at: tools/lldb-mi/MICmnLLDBDebugger.cpp:835
@@ +834,3 @@
+
+if (!MI_add_summary(miCategory, "char", MI_char_summary_provider,
+lldb::eTypeOptionHideValue |
lldb::eTypeOptionSkipPointers))
granat
artagnon updated this revision to Diff 37611.
artagnon added a comment.
Er, silly mistake (build failure)
http://reviews.llvm.org/D13816
Files:
source/Commands/CommandObjectMemory.cpp
tools/debugserver/source/RNBRemote.cpp
tools/debugserver/source/debugserver.cpp
Index: tools/debugserver
artagnon created this revision.
artagnon added a reviewer: clayborg.
artagnon added a subscriber: lldb-commits.
http://reviews.llvm.org/D13816
Files:
source/Commands/CommandObjectMemory.cpp
tools/debugserver/source/RNBRemote.cpp
tools/debugserver/source/debugserver.cpp
Index: tools/debugse
sivachandra added a comment.
When such an error occurs, it is unlikely to be an lldb bug, or data-formatter
bug. One can come up with a data structure for which reading a child element
would require complete debug info, but reading the # of child elements need not
require complete debug info (t
Author: zturner
Date: Fri Oct 16 12:51:49 2015
New Revision: 250530
URL: http://llvm.org/viewvc/llvm-project?rev=250530&view=rev
Log:
Convert SWIG typemap string operations to PythonObjects.
Modified:
lldb/trunk/scripts/Python/python-typemaps.swig
lldb/trunk/source/Plugins/ScriptInterpret
Author: zturner
Date: Fri Oct 16 12:52:03 2015
New Revision: 250531
URL: http://llvm.org/viewvc/llvm-project?rev=250531&view=rev
Log:
Fix linkage of `init_lldb` SWIG method in Python 3.
Modified:
lldb/trunk/source/API/SystemInitializerFull.cpp
lldb/trunk/source/Plugins/ScriptInterpreter/P
Author: zturner
Date: Fri Oct 16 12:52:12 2015
New Revision: 250532
URL: http://llvm.org/viewvc/llvm-project?rev=250532&view=rev
Log:
Make swig generation python scripts python 3 compatible.
Modified:
lldb/trunk/scripts/Python/finishSwigPythonLLDB.py
lldb/trunk/scripts/finishSwigWrapperCl
Author: zturner
Date: Fri Oct 16 12:52:32 2015
New Revision: 250533
URL: http://llvm.org/viewvc/llvm-project?rev=250533&view=rev
Log:
Make some more of the LLDB/SWIG/Python glue Python 3 aware.
Mostly this is just converting some print statements to print
functions.
Modified:
lldb/trunk/scri
evgeny777 added inline comments.
Comment at: tools/lldb-mi/MICmnLLDBDebugger.cpp:37
@@ +36,3 @@
+return false;
+stream.Printf("%d %s", (int)value.GetValueAsSigned(), value.GetValue());
+return true;
granata.enrico wrote:
> I would definitely not st
granata.enrico added inline comments.
Comment at: tools/lldb-mi/MICmnLLDBDebugger.cpp:835
@@ +834,3 @@
+
+if (!MI_add_summary(miCategory, "char", MI_char_summary_provider,
+lldb::eTypeOptionHideValue |
lldb::eTypeOptionSkipPointers))
e
artagnon created this revision.
artagnon added reviewers: chaoren, brucem.
artagnon added a subscriber: lldb-commits.
http://reviews.llvm.org/D13819
Files:
cmake/modules/LLDBStandalone.cmake
Index: cmake/modules/LLDBStandalone.cmake
=
Author: eugenezelenko
Date: Fri Oct 16 13:49:42 2015
New Revision: 250538
URL: http://llvm.org/viewvc/llvm-project?rev=250538&view=rev
Log:
[LLDB] Fix Clang-tidy modernize-use-override warnings in source/Plugins/ABI;
other minor fixes.
Differential Revision: http://reviews.llvm.org/D13684
Modif
This revision was automatically updated to reflect the committed changes.
Closed by commit rL250538: [LLDB] Fix Clang-tidy modernize-use-override
warnings in source/Plugins/ABI… (authored by eugenezelenko).
Changed prior to commit:
http://reviews.llvm.org/D13684?vs=37206&id=37622#toc
Repositor
Eugene.Zelenko added a comment.
Ping. Please review this patch, since these files is largest source of
modernize-use-override warnings warnings in LLDB code.
Repository:
rL LLVM
http://reviews.llvm.org/D13602
___
lldb-commits mailing list
lldb-c
sivachandra updated this revision to Diff 37630.
sivachandra added a comment.
Address comments.
http://reviews.llvm.org/D13778
Files:
include/lldb/API/SBValue.h
include/lldb/Core/ValueObject.h
include/lldb/Core/ValueObjectCast.h
include/lldb/Core/ValueObjectChild.h
include/lldb/Core/V
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
I would rather you be able to ask the current platform for the default memory
cache line size and have lldb_private::Process do this automatically on the
first memory read if the
Eugene.Zelenko created this revision.
Eugene.Zelenko added reviewers: brucem, labath, clayborg.
Eugene.Zelenko added a subscriber: lldb-commits.
Eugene.Zelenko set the repository for this revision to rL LLVM.
Herald added a subscriber: emaste.
I checked this patch on my own build on RHEL 6.
Repos
Hello everyone,
I just added public staging buildbot and every owner of build machine is
welcome to use it.
Its' copy of our current LLVM buildbot, but it does not send any
notifications.
The web page is here:
http://lab.llvm.org:8014
Any builder could be easy switched to staging buildbot by simp
Author: enrico
Date: Fri Oct 16 17:51:56 2015
New Revision: 250567
URL: http://llvm.org/viewvc/llvm-project?rev=250567&view=rev
Log:
Move TypeSummaryImpl over to LLVM-style RTTI for subclassing
Modified:
lldb/trunk/include/lldb/DataFormatters/TypeSummary.h
lldb/trunk/source/API/SBTypeSum
Author: amccarth
Date: Fri Oct 16 18:19:22 2015
New Revision: 250576
URL: http://llvm.org/viewvc/llvm-project?rev=250576&view=rev
Log:
Skip hanging watchpoint test on Windows (rather than just xfailing).
Modified:
lldb/trunk/test/python_api/watchpoint/condition/TestWatchpointConditionAPI.py
Author: gclayton
Date: Fri Oct 16 18:34:40 2015
New Revision: 250580
URL: http://llvm.org/viewvc/llvm-project?rev=250580&view=rev
Log:
Split getting the key from a window from the code that handles the key.
Modified:
lldb/trunk/test/lldbcurses.py
Modified: lldb/trunk/test/lldbcurses.py
URL:
Author: enrico
Date: Fri Oct 16 18:42:04 2015
New Revision: 250581
URL: http://llvm.org/viewvc/llvm-project?rev=250581&view=rev
Log:
Handle eFormatVectorOfFloat16
Modified:
lldb/trunk/source/Commands/CommandObjectMemory.cpp
Modified: lldb/trunk/source/Commands/CommandObjectMemory.cpp
URL:
zturner created this revision.
zturner added reviewers: clayborg, granata.enrico.
zturner added a subscriber: lldb-commits.
When we acquire the GIL with `Locker`, we save off the current stdio handles,
redirect them, and when we release the GIL we put the old handles back. This
triggers a poten
Author: eugenezelenko
Date: Fri Oct 16 19:19:57 2015
New Revision: 250593
URL: http://llvm.org/viewvc/llvm-project?rev=250593&view=rev
Log:
[LLDB] Fix Clang-tidy modernize-use-override warnings in some headers in
source/Plugins/Process/Utility; other minor fixes.
Differential Revision: http://re
This revision was automatically updated to reflect the committed changes.
Closed by commit rL250593: [LLDB] Fix Clang-tidy modernize-use-override
warnings in some headers in… (authored by eugenezelenko).
Changed prior to commit:
http://reviews.llvm.org/D13830?vs=37634&id=37662#toc
Repository:
Eugene.Zelenko created this revision.
Eugene.Zelenko added reviewers: brucem, labath, clayborg.
Eugene.Zelenko added a subscriber: lldb-commits.
Eugene.Zelenko set the repository for this revision to rL LLVM.
I checked this patch on my own build on RHEL 6.
Repository:
rL LLVM
http://reviews.ll
Author: enrico
Date: Fri Oct 16 20:05:50 2015
New Revision: 250599
URL: http://llvm.org/viewvc/llvm-project?rev=250599&view=rev
Log:
Teach an old pony a few new tricks.
ValueObjectPrinter can now mask out pointer values during a printout; also, it
supports helper functions to print declarations
47 matches
Mail list logo
