[Lldb-commits] [PATCH] D72413: Add missing nullptr checks.

2020-01-10 Thread Raphael Isemann via Phabricator via lldb-commits
teemperor added a comment. The C++ expression parser will probably behave incredibly incorrectly without a persistent state but before this patch it just crashed, so I think this is good to go. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72413/new/ https://reviews.llvm.org/D72413

[Lldb-commits] [PATCH] D72413: Add missing nullptr checks.

2020-01-10 Thread Raphael Isemann via Phabricator via lldb-commits
teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. In D72413#1811038 , @aprantl wrote: > In D72413#1810969 , @jingham wrote: > > > If we can't make a persis

[Lldb-commits] [PATCH] D67793: new api class: SBFile

2020-01-10 Thread Vadim Chugunov via Phabricator via lldb-commits
vadimcn added inline comments. Comment at: lldb/trunk/scripts/Python/python-typemaps.swig:481 + PyBuffer_Release(&view); + $1 = ($1_ltype) buf; + $2 = ($2_ltype) (size/sizeof($*1_type)); Sorry for being late to the party, but I just stumbled upon this code...

[Lldb-commits] [PATCH] D71905: [lldb][tests] Take into account all parent's categories when traverse folders upwards

2020-01-10 Thread Pavel Labath via Phabricator via lldb-commits
labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. lgtm Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71905/new/ https://reviews.llvm.org/D71905 ___ lldb-commits

[Lldb-commits] [PATCH] D71372: [lldb] Add additional validation on return address in 'thread step-out'

2020-01-10 Thread Pavel Labath via Phabricator via lldb-commits
labath added a comment. In D71372#1813142 , @ted wrote: > In D71372#1811594 , @labath wrote: > > > In D71372#1810687 , @ted wrote: > > > > > I've got another failure case for

[Lldb-commits] [PATCH] D72460: RangeDataVector: Support custom sorting for D63540

2020-01-10 Thread Pavel Labath via Phabricator via lldb-commits
labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Looks good. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72460/new/ https://reviews.llvm.org/D72460

[Lldb-commits] [PATCH] D72489: [DWARF] Emit DW_AT_call_return_pc as an address

2020-01-10 Thread Pavel Labath via Phabricator via lldb-commits
labath added a comment. Thanks for fixing this. The lldb parts look good to me. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72489/new/ https://reviews.llvm.org/D72489 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists

[Lldb-commits] [PATCH] D72133: Data formatters: Look through array element typedefs

2020-01-10 Thread Jaroslav Sevcik via Phabricator via lldb-commits
jarin added a comment. Raphael, could you possibly land the patch for me? Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72133/new/ https://reviews.llvm.org/D72133 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lis

[Lldb-commits] [PATCH] D72133: Data formatters: Look through array element typedefs

2020-01-10 Thread Raphael Isemann via Phabricator via lldb-commits
teemperor added a comment. In D72133#1813724 , @jarin wrote: > Raphael, could you possibly land the patch for me? Thanks! It's in my queue, but the green dragon bot (and my own CI) are currently dead due to a libc++ change that breaks the data formatter

[Lldb-commits] [PATCH] D72133: Data formatters: Look through array element typedefs

2020-01-10 Thread Raphael Isemann via Phabricator via lldb-commits
teemperor added a comment. Actually the failures are gmodules only so I'll land this now. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72133/new/ https://reviews.llvm.org/D72133 ___ lldb-commits mailing list lldb-commits@lists.llvm.org htt

[Lldb-commits] [PATCH] D70238: [lldb] Allow loading of minidumps with no process id

2020-01-10 Thread Pavel Labath via Phabricator via lldb-commits
labath added a comment. In D70238#1813280 , @clayborg wrote: > The pid usually comes from the MinidumpMiscInfoFlags::ProcessID right? This > is a minidump supported directory entry. We don't actually rely on > /proc/%d/status right? Actually, we are. :

[Lldb-commits] [lldb] 9029742 - Data formatters: Look through array element typedefs

2020-01-10 Thread Raphael Isemann via lldb-commits
Author: Jaroslav Sevcik Date: 2020-01-10T11:45:24+01:00 New Revision: 902974277d507a149e33487d32e4ba58c41451b6 URL: https://github.com/llvm/llvm-project/commit/902974277d507a149e33487d32e4ba58c41451b6 DIFF: https://github.com/llvm/llvm-project/commit/902974277d507a149e33487d32e4ba58c41451b6.dif

[Lldb-commits] [PATCH] D72133: Data formatters: Look through array element typedefs

2020-01-10 Thread Raphael Isemann via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG902974277d50: Data formatters: Look through array element typedefs (authored by jarin, committed by teemperor). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[Lldb-commits] [PATCH] D71825: [lldb/Lua] Support loading Lua modules.

2020-01-10 Thread Pavel Labath via Phabricator via lldb-commits
labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. This looks fine to me now. Thanks for your patience. Comment at: lldb/source/Plugins/ScriptInterpreter/Lua/Lua.h:43-46 + llvm::Expected FormatQuoted(llvm::StringRef str);

[Lldb-commits] [PATCH] D71151: [lldb][test] Remove symlink for API tests.

2020-01-10 Thread Pavel Labath via Phabricator via lldb-commits
labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Judging by the direction of the lua patches, it doesn't look like we will have lua "dotest" tests, so I think it's fine to just put this into API directly (without the extra "test" subfolder")

[Lldb-commits] [PATCH] D70238: [lldb] Allow loading of minidumps with no process id

2020-01-10 Thread Pavel Labath via Phabricator via lldb-commits
labath updated this revision to Diff 237274. labath added a comment. PID := 1 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70238/new/ https://reviews.llvm.org/D70238 Files: lldb/source/Plugins/Process/minidump/ProcessMinidump.cpp lldb/test/Sh

[Lldb-commits] [lldb] 5b76127 - [lldb/lua] Make convenience_variables.test compatible with lua-5.1

2020-01-10 Thread Pavel Labath via lldb-commits
Author: Pavel Labath Date: 2020-01-10T13:02:01+01:00 New Revision: 5b7612792aeb5b161fdd69997db2a64b08f075b6 URL: https://github.com/llvm/llvm-project/commit/5b7612792aeb5b161fdd69997db2a64b08f075b6 DIFF: https://github.com/llvm/llvm-project/commit/5b7612792aeb5b161fdd69997db2a64b08f075b6.diff

[Lldb-commits] [PATCH] D71825: [lldb/Lua] Support loading Lua modules.

2020-01-10 Thread Pavel Labath via Phabricator via lldb-commits
labath added inline comments. Comment at: lldb/source/Plugins/ScriptInterpreter/Lua/Lua.cpp:46 + int error = luaL_loadfile(m_lua_state, filename.data()) || + lua_pcall(m_lua_state, 0, LUA_MULTRET, 0); + if (error) { It would be better to put `1` he

[Lldb-commits] [lldb] e65282d - [lldb/DWARF] Don't automatically search dwo unit attributes

2020-01-10 Thread Pavel Labath via lldb-commits
Author: Pavel Labath Date: 2020-01-10T13:29:24+01:00 New Revision: e65282deca8455d1cc6d83b7016af9aa374f9f89 URL: https://github.com/llvm/llvm-project/commit/e65282deca8455d1cc6d83b7016af9aa374f9f89 DIFF: https://github.com/llvm/llvm-project/commit/e65282deca8455d1cc6d83b7016af9aa374f9f89.diff

[Lldb-commits] [lldb] c88e298 - [lldb] Surpress "bitfield too small" gcc warning

2020-01-10 Thread Pavel Labath via lldb-commits
Author: Pavel Labath Date: 2020-01-10T13:43:05+01:00 New Revision: c88e298b69409e35e35ab601592197f5a2bc1c30 URL: https://github.com/llvm/llvm-project/commit/c88e298b69409e35e35ab601592197f5a2bc1c30 DIFF: https://github.com/llvm/llvm-project/commit/c88e298b69409e35e35ab601592197f5a2bc1c30.diff

[Lldb-commits] [lldb] 9ba1512 - [lldb][test] NFC, re-use _getTestPath() function

2020-01-10 Thread Tatyana Krasnukha via lldb-commits
Author: Tatyana Krasnukha Date: 2020-01-10T16:31:03+03:00 New Revision: 9ba151274869c377921a09ba0bd635412da755ef URL: https://github.com/llvm/llvm-project/commit/9ba151274869c377921a09ba0bd635412da755ef DIFF: https://github.com/llvm/llvm-project/commit/9ba151274869c377921a09ba0bd635412da755ef.d

[Lldb-commits] [lldb] e4d6729 - [lldb][tests] Take into account all parent's categories when traverse folders upwards

2020-01-10 Thread Tatyana Krasnukha via lldb-commits
Author: Tatyana Krasnukha Date: 2020-01-10T16:31:02+03:00 New Revision: e4d672971030fe26dbb8237038038c3ff9ae7541 URL: https://github.com/llvm/llvm-project/commit/e4d672971030fe26dbb8237038038c3ff9ae7541 DIFF: https://github.com/llvm/llvm-project/commit/e4d672971030fe26dbb8237038038c3ff9ae7541.d

[Lldb-commits] [PATCH] D71905: [lldb][tests] Take into account all parent's categories when traverse folders upwards

2020-01-10 Thread Tatyana Krasnukha via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGe4d672971030: [lldb][tests] Take into account all parent's categories when traverse folders… (authored by tatyana-krasnukha). Changed prior to commit: https://reviews.llvm.org/D71905?vs=237079&id=237294

[Lldb-commits] [lldb] b3af8ab - [lldb][tests] Cleanup '.categories'

2020-01-10 Thread Tatyana Krasnukha via lldb-commits
Author: Tatyana Krasnukha Date: 2020-01-10T16:39:38+03:00 New Revision: b3af8ab7f83c2a825c584ddedf5cc9207ca66b44 URL: https://github.com/llvm/llvm-project/commit/b3af8ab7f83c2a825c584ddedf5cc9207ca66b44 DIFF: https://github.com/llvm/llvm-project/commit/b3af8ab7f83c2a825c584ddedf5cc9207ca66b44.d

[Lldb-commits] [lldb] 2f2f41e - RangeDataVector: Support custom sorting for D63540

2020-01-10 Thread Jan Kratochvil via lldb-commits
Author: Jan Kratochvil Date: 2020-01-10T15:14:38+01:00 New Revision: 2f2f41e12c5201b600d887d22ce5cb4afd2ff594 URL: https://github.com/llvm/llvm-project/commit/2f2f41e12c5201b600d887d22ce5cb4afd2ff594 DIFF: https://github.com/llvm/llvm-project/commit/2f2f41e12c5201b600d887d22ce5cb4afd2ff594.diff

[Lldb-commits] [PATCH] D72460: RangeDataVector: Support custom sorting for D63540

2020-01-10 Thread Jan Kratochvil via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG2f2f41e12c52: RangeDataVector: Support custom sorting for D63540 (authored by jankratochvil). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72460/new/ https

[Lldb-commits] [lldb] 3eea082 - [lldb][tests] Make it possible to expect failure for a whole category

2020-01-10 Thread Tatyana Krasnukha via lldb-commits
Author: Tatyana Krasnukha Date: 2020-01-10T17:37:55+03:00 New Revision: 3eea082535e232b35e6b2dab45dd81728b2ae7f4 URL: https://github.com/llvm/llvm-project/commit/3eea082535e232b35e6b2dab45dd81728b2ae7f4 DIFF: https://github.com/llvm/llvm-project/commit/3eea082535e232b35e6b2dab45dd81728b2ae7f4.d

[Lldb-commits] [PATCH] D71906: [lldb][tests] Make it possible to expect failure for a whole category

2020-01-10 Thread Tatyana Krasnukha via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG3eea082535e2: [lldb][tests] Make it possible to expect failure for a whole category (authored by tatyana-krasnukha). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[Lldb-commits] [lldb] e20a3b9 - [lldb][tests][NFC] Unify variable naming convention

2020-01-10 Thread Tatyana Krasnukha via lldb-commits
Author: Tatyana Krasnukha Date: 2020-01-10T17:37:55+03:00 New Revision: e20a3b9b6c028ef3fea92ddb19e98db45e3d0509 URL: https://github.com/llvm/llvm-project/commit/e20a3b9b6c028ef3fea92ddb19e98db45e3d0509 DIFF: https://github.com/llvm/llvm-project/commit/e20a3b9b6c028ef3fea92ddb19e98db45e3d0509.d

[Lldb-commits] [PATCH] D72507: [lldb] Remove FieldDecl stealing hack by rerouting indirect imports to the original AST

2020-01-10 Thread Raphael Isemann via Phabricator via lldb-commits
teemperor added a comment. FWIW, this isn't really a finished patch yet as I actually wanted to write several unit tests for this, but as it fixes the gmodules failures on master I thought I might as well put it up now. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm

[Lldb-commits] [PATCH] D72507: [lldb] Remove FieldDecl stealing hack by rerouting indirect imports to the original AST

2020-01-10 Thread Raphael Isemann via Phabricator via lldb-commits
teemperor created this revision. teemperor added reviewers: shafik, aprantl. Herald added subscribers: lldb-commits, JDevlieghere. Herald added a project: LLDB. teemperor added a comment. FWIW, this isn't really a finished patch yet as I actually wanted to write several unit tests for this, but a

[Lldb-commits] [PATCH] D72510: [lldb/Expression] Improve interpreter error message with a non-running process

2020-01-10 Thread Med Ismail Bennani via Phabricator via lldb-commits
mib created this revision. mib added reviewers: jingham, JDevlieghere. mib added a project: LLDB. Herald added a subscriber: lldb-commits. mib edited the summary of this revision. When trying to interprete an expression with a function call, if the process haven't been launched, the expression fai

[Lldb-commits] [PATCH] D72510: [lldb/Expression] Improve interpreter error message with a non-running target

2020-01-10 Thread Vedant Kumar via Phabricator via lldb-commits
vsk added a comment. Nice. So, does !support_function_calls always imply that the target isn’t running? Also — s/interprete/interpret/, I think. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72510/new/ https://reviews.llvm.org/D72510 _

[Lldb-commits] [PATCH] D72513: Don't fail step out if remote server doesn't implement qMemoryRegionInfo

2020-01-10 Thread Ted Woodward via Phabricator via lldb-commits
ted created this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. ted added reviewers: labath, jingham, clayborg. The return address validation in D71372 will fail if the memory permissions can't be determined. Many embedded stubs

[Lldb-commits] [PATCH] D71372: [lldb] Add additional validation on return address in 'thread step-out'

2020-01-10 Thread Ted Woodward via Phabricator via lldb-commits
ted added a comment. In D71372#1813703 , @labath wrote: > In D71372#1813142 , @ted wrote: > > > In D71372#1811594 , @labath wrote: > > > > > In D71372#1810687

[Lldb-commits] [PATCH] D72510: [lldb/Expression] Improve interpreter error message with a non-running target

2020-01-10 Thread Med Ismail Bennani via Phabricator via lldb-commits
mib added a comment. Actually, the target could be running but doesn't support interpreting expression with function calls. May be I should add another error message for target that doesn't support interpreting function calls. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D72413: Add missing nullptr checks.

2020-01-10 Thread Adrian Prantl via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGe9331a56fead: Add missing nullptr checks. (authored by aprantl). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72413/new/ http

[Lldb-commits] [lldb] e9331a5 - Add missing nullptr checks.

2020-01-10 Thread Adrian Prantl via lldb-commits
Author: Adrian Prantl Date: 2020-01-10T08:52:46-08:00 New Revision: e9331a56fead1823d528d6412828fb9e16fd62ff URL: https://github.com/llvm/llvm-project/commit/e9331a56fead1823d528d6412828fb9e16fd62ff DIFF: https://github.com/llvm/llvm-project/commit/e9331a56fead1823d528d6412828fb9e16fd62ff.diff

[Lldb-commits] [PATCH] D72489: [DWARF] Emit DW_AT_call_return_pc as an address

2020-01-10 Thread Adrian Prantl via Phabricator via lldb-commits
aprantl added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/functionalities/tail_call_frames/cross_dso/Makefile:10 + +lib_One: lib_Two + It seems like one of the lib_Two dependencies is redundant? Presumably the one in a.out? CHANGES SINCE

[Lldb-commits] [PATCH] D72507: [lldb] Remove FieldDecl stealing hack by rerouting indirect imports to the original AST

2020-01-10 Thread Shafik Yaghmour via Phabricator via lldb-commits
shafik accepted this revision. shafik added a comment. This revision is now accepted and ready to land. LGTM Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72507/new/ https://reviews.llvm.org/D72507 ___ lldb-commits

[Lldb-commits] [PATCH] D71575: [LLDB] Add ObjectFileWasm plugin for WebAssembly debugging

2020-01-10 Thread Paolo Severini via Phabricator via lldb-commits
paolosev marked 2 inline comments as done. paolosev added inline comments. Comment at: lldb/source/Plugins/ObjectFile/wasm/ObjectFileWasm.cpp:342-343 +section_type, // Section type. +sect_info.offset & 0x, /

[Lldb-commits] [lldb] ef23997 - [lldb] Remove FieldDecl stealing hack by rerouting indirect imports to the original AST

2020-01-10 Thread Raphael Isemann via lldb-commits
Author: Raphael Isemann Date: 2020-01-10T19:18:07+01:00 New Revision: ef239972614cc3c67006f9c298fcfa841818dc77 URL: https://github.com/llvm/llvm-project/commit/ef239972614cc3c67006f9c298fcfa841818dc77 DIFF: https://github.com/llvm/llvm-project/commit/ef239972614cc3c67006f9c298fcfa841818dc77.dif

[Lldb-commits] [PATCH] D72413: Add missing nullptr checks.

2020-01-10 Thread Davide Italiano via Phabricator via lldb-commits
davide added a comment. In D72413#1813630 , @teemperor wrote: > The C++ expression parser will probably behave incredibly incorrectly without > a persistent state but before this patch it just crashed, so I think this is > good to go. Should we conside

[Lldb-commits] [lldb] 572b9f4 - [lldb/Lua] Support loading Lua modules

2020-01-10 Thread Jonas Devlieghere via lldb-commits
Author: Jonas Devlieghere Date: 2020-01-10T10:22:30-08:00 New Revision: 572b9f468ad6844795fec29a7e671ba64d82e8c2 URL: https://github.com/llvm/llvm-project/commit/572b9f468ad6844795fec29a7e671ba64d82e8c2 DIFF: https://github.com/llvm/llvm-project/commit/572b9f468ad6844795fec29a7e671ba64d82e8c2.d

[Lldb-commits] [PATCH] D71825: [lldb/Lua] Support loading Lua modules.

2020-01-10 Thread Jonas Devlieghere via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG572b9f468ad6: [lldb/Lua] Support loading Lua modules (authored by JDevlieghere). Changed prior to commit: https://reviews.llvm.org/D71825?vs=237088&id=237383#toc Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D71825: [lldb/Lua] Support loading Lua modules.

2020-01-10 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere added a comment. In D71825#1813766 , @labath wrote: > This looks fine to me now. Thanks for your patience. Thank you for the review! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71825/new/ https://reviews.llvm.org/D71825 _

[Lldb-commits] [PATCH] D72507: [lldb] Remove FieldDecl stealing hack by rerouting indirect imports to the original AST

2020-01-10 Thread Raphael Isemann via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGef239972614c: [lldb] Remove FieldDecl stealing hack by rerouting indirect imports to the… (authored by teemperor). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[Lldb-commits] [PATCH] D71575: [LLDB] Add ObjectFileWasm plugin for WebAssembly debugging

2020-01-10 Thread Paolo Severini via Phabricator via lldb-commits
paolosev marked an inline comment as done. paolosev added a comment. I apologize for the noob question, but how do I schedule a build for this diff with Harbormaster? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71575/new/ https://reviews.llvm.or

[Lldb-commits] [PATCH] D72495: [lldb] Make CompleteTagDeclsScope completion order deterministic

2020-01-10 Thread Shafik Yaghmour via Phabricator via lldb-commits
shafik accepted this revision. shafik added a comment. This revision is now accepted and ready to land. This is a good change, we do see bugs that are sometimes not totally deterministic so this should hopefully reduce those. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews

[Lldb-commits] [PATCH] D72495: [lldb] Make CompleteTagDeclsScope completion order deterministic

2020-01-10 Thread Davide Italiano via Phabricator via lldb-commits
davide accepted this revision. davide added a comment. LGTM Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72495/new/ https://reviews.llvm.org/D72495 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https:/

[Lldb-commits] [PATCH] D72489: [DWARF] Emit DW_AT_call_return_pc as an address

2020-01-10 Thread David Blaikie via Phabricator via lldb-commits
dblaikie added a comment. I ran some size analysis (& hadn't realized that this special case was only done in the DWARFv5 codepath... that leads me to wonder about size impact in DWARFv4, so maybe I'll need to go back and run some general size analysis cost of these call sites). The .rela.debu

[Lldb-commits] [lldb] 77da826 - [lldb] Make CompleteTagDeclsScope completion order deterministic

2020-01-10 Thread Raphael Isemann via lldb-commits
Author: Raphael Isemann Date: 2020-01-10T21:19:04+01:00 New Revision: 77da826edad0a7b906c734c6bee3489ef495c746 URL: https://github.com/llvm/llvm-project/commit/77da826edad0a7b906c734c6bee3489ef495c746 DIFF: https://github.com/llvm/llvm-project/commit/77da826edad0a7b906c734c6bee3489ef495c746.dif

[Lldb-commits] [PATCH] D72495: [lldb] Make CompleteTagDeclsScope completion order deterministic

2020-01-10 Thread Raphael Isemann via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG77da826edad0: [lldb] Make CompleteTagDeclsScope completion order deterministic (authored by teemperor). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72495/n

[Lldb-commits] [lldb] 9e13cff - [lldb] Fix TestClangASTContext.TestFunctionTemplateInRecordConstruction in Debug builds

2020-01-10 Thread Raphael Isemann via lldb-commits
Author: Raphael Isemann Date: 2020-01-10T21:34:07+01:00 New Revision: 9e13cff44d6b8b9c9c8420870132931c218707cb URL: https://github.com/llvm/llvm-project/commit/9e13cff44d6b8b9c9c8420870132931c218707cb DIFF: https://github.com/llvm/llvm-project/commit/9e13cff44d6b8b9c9c8420870132931c218707cb.dif

[Lldb-commits] [PATCH] D72359: [lldb] Fix TestClangASTContext.TestFunctionTemplateInRecordConstruction in Debug builds

2020-01-10 Thread Raphael Isemann via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG9e13cff44d6b: [lldb] Fix TestClangASTContext.TestFunctionTemplateInRecordConstruction in… (authored by teemperor). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[Lldb-commits] [PATCH] D72489: [DWARF] Emit DW_AT_call_return_pc as an address

2020-01-10 Thread Vedant Kumar via Phabricator via lldb-commits
vsk marked an inline comment as done. vsk added a comment. In D72489#1813533 , @dblaikie wrote: > Thanks for looking into this! > > Could you measure the size of the object files of, for example, the clang > binary before/after this change - and, if possi

[Lldb-commits] [PATCH] D72489: [DWARF] Emit DW_AT_call_return_pc as an address

2020-01-10 Thread Vedant Kumar via Phabricator via lldb-commits
vsk updated this revision to Diff 237419. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72489/new/ https://reviews.llvm.org/D72489 Files: lldb/include/lldb/Symbol/Function.h lldb/packages/Python/lldbsuite/test/functionalities/tail_call_frames/cross_dso/Makefile lldb/packages/Pyth

[Lldb-commits] [PATCH] D72489: [DWARF] Emit DW_AT_call_return_pc as an address

2020-01-10 Thread Vedant Kumar via Phabricator via lldb-commits
vsk marked an inline comment as done. vsk added a subscriber: djtodoro. vsk added inline comments. Comment at: llvm/lib/CodeGen/AsmPrinter/DwarfCompileUnit.cpp:984-991 // from one function to another. if (DD->getDwarfVersion() == 4 && DD->tuneForGDB()) { assert(PCAddr

[Lldb-commits] [lldb] 1a8c996 - [lldb/Scripts] Remove buildbot.py

2020-01-10 Thread Jonas Devlieghere via lldb-commits
Author: Jonas Devlieghere Date: 2020-01-10T13:44:41-08:00 New Revision: 1a8c996a8894a6ae2bf3b98780972bc7bdb6b8e6 URL: https://github.com/llvm/llvm-project/commit/1a8c996a8894a6ae2bf3b98780972bc7bdb6b8e6 DIFF: https://github.com/llvm/llvm-project/commit/1a8c996a8894a6ae2bf3b98780972bc7bdb6b8e6.d

[Lldb-commits] [lldb] e6d2191 - [lldb/Scripts] Remove remote-build.py

2020-01-10 Thread Jonas Devlieghere via lldb-commits
Author: Jonas Devlieghere Date: 2020-01-10T13:53:12-08:00 New Revision: e6d219122d5a94fa8642c67c391aeb47fc032c89 URL: https://github.com/llvm/llvm-project/commit/e6d219122d5a94fa8642c67c391aeb47fc032c89 DIFF: https://github.com/llvm/llvm-project/commit/e6d219122d5a94fa8642c67c391aeb47fc032c89.d

[Lldb-commits] [lldb] 7c47a37 - [lldb/Scripts] Move android script from underneath Python dir

2020-01-10 Thread Jonas Devlieghere via lldb-commits
Author: Jonas Devlieghere Date: 2020-01-10T13:54:33-08:00 New Revision: 7c47a3719a9e587fdf993637dc09d97b5397483b URL: https://github.com/llvm/llvm-project/commit/7c47a3719a9e587fdf993637dc09d97b5397483b DIFF: https://github.com/llvm/llvm-project/commit/7c47a3719a9e587fdf993637dc09d97b5397483b.d

[Lldb-commits] [PATCH] D72539: [lldb/Scripts] Remove SWIG bot

2020-01-10 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere created this revision. JDevlieghere added reviewers: LLDB, labath, zturner. Herald added a project: LLDB. I don't think is used and it hasn't been touched since 2015. I think this can go away. Repository: rLLDB LLDB https://reviews.llvm.org/D72539 Files: lldb/scripts/swig_bot

[Lldb-commits] [PATCH] D72541: [lldb/Utils] Remove vim-lldb

2020-01-10 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere created this revision. JDevlieghere added a reviewer: LLDB. Herald added a subscriber: abidh. Herald added a project: LLDB. The vim-lldb plugin is unmaintained and doesn't work with a recent vim installation that uses Python 3. I propose we remove it from the LLDB repository and hou

[Lldb-commits] [PATCH] D72541: [lldb/Utils] Remove vim-lldb

2020-01-10 Thread Alex Langford via Phabricator via lldb-commits
xiaobai accepted this revision. xiaobai added a comment. This revision is now accepted and ready to land. The only things that have touched vim-lldb in the past 5-6 years have been the result of repository-wide changes (e.g. reformatting, documentation changes, python compatability and version t

[Lldb-commits] [lldb] 7ce92dc - [lldb/Test] Bypass LLDB_TEST_COMMON_ARGS for certain dotest args (NFC)

2020-01-10 Thread Jonas Devlieghere via lldb-commits
Author: Jonas Devlieghere Date: 2020-01-10T14:40:17-08:00 New Revision: 7ce92dc0b4bcc1044052a06df3f07a94eb890823 URL: https://github.com/llvm/llvm-project/commit/7ce92dc0b4bcc1044052a06df3f07a94eb890823 DIFF: https://github.com/llvm/llvm-project/commit/7ce92dc0b4bcc1044052a06df3f07a94eb890823.d

[Lldb-commits] [lldb] c5adcdc - [lldb/Utils] Remove vim-lldb

2020-01-10 Thread Jonas Devlieghere via lldb-commits
Author: Jonas Devlieghere Date: 2020-01-10T14:40:42-08:00 New Revision: c5adcdc5c88a89241b1150824fc44370c62c7132 URL: https://github.com/llvm/llvm-project/commit/c5adcdc5c88a89241b1150824fc44370c62c7132 DIFF: https://github.com/llvm/llvm-project/commit/c5adcdc5c88a89241b1150824fc44370c62c7132.d

[Lldb-commits] [PATCH] D72541: [lldb/Utils] Remove vim-lldb

2020-01-10 Thread Jonas Devlieghere via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGc5adcdc5c88a: [lldb/Utils] Remove vim-lldb (authored by JDevlieghere). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72541/new/ https://reviews.llvm.org/D72

[Lldb-commits] [lldb] 4c00dbf - lldbutil: Forward ASan launch info to test inferiors

2020-01-10 Thread Vedant Kumar via lldb-commits
Author: Vedant Kumar Date: 2020-01-10T14:52:51-08:00 New Revision: 4c00dbf22d7f0ad005444b412b450ee4b4779b6a URL: https://github.com/llvm/llvm-project/commit/4c00dbf22d7f0ad005444b412b450ee4b4779b6a DIFF: https://github.com/llvm/llvm-project/commit/4c00dbf22d7f0ad005444b412b450ee4b4779b6a.diff

[Lldb-commits] [PATCH] D71379: lldbutil: Forward ASan launch info to test inferiors

2020-01-10 Thread Vedant Kumar via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG4c00dbf22d7f: lldbutil: Forward ASan launch info to test inferiors (authored by vsk). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[Lldb-commits] [lldb] d3ba1e0 - [lldb/Reproducer] Add SBReproducer::Replay overload (again)

2020-01-10 Thread Jonas Devlieghere via lldb-commits
Author: Jonas Devlieghere Date: 2020-01-10T15:02:21-08:00 New Revision: d3ba1e026dbc44e9097ce6ea1c92d065f1fe33e8 URL: https://github.com/llvm/llvm-project/commit/d3ba1e026dbc44e9097ce6ea1c92d065f1fe33e8 DIFF: https://github.com/llvm/llvm-project/commit/d3ba1e026dbc44e9097ce6ea1c92d065f1fe33e8.d

[Lldb-commits] [PATCH] D69820: [Symbol] Add TypeSystem::GetClassName

2020-01-10 Thread Alex Langford via Phabricator via lldb-commits
xiaobai updated this revision to Diff 237445. xiaobai added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69820/new/ https://reviews.llvm.org/D69820 Files: lldb/include/lldb/Symbol/ClangASTContext.h lldb/include/lldb/Symbol/T

[Lldb-commits] [PATCH] D69820: [Symbol] Add TypeSystem::GetClassName

2020-01-10 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69820/new/ https://reviews.llvm.org/D69820 ___