[Lldb-commits] [PATCH] D117712: [lldb] Disconnect instrumentation from the reproducers

JDevlieghere updated this revision to Diff 401505. JDevlieghere added a comment. Rebase CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117712/new/ https://reviews.llvm.org/D117712 Files: lldb/include/lldb/Utility/Instrumentation.h

[Lldb-commits] [PATCH] D117748: [lldb] Revive lldb-instr

JDevlieghere created this revision. JDevlieghere added a reviewer: labath. Herald added a subscriber: mgorny. JDevlieghere requested review of this revision. I revived `lldb-instr` to update the macros for D117712 . I think the new macros are simple enough that

[Lldb-commits] [PATCH] D117712: [lldb] Disconnect instrumentation from the reproducers

JDevlieghere updated this revision to Diff 401503. JDevlieghere added a comment. Simplify macros CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117712/new/ https://reviews.llvm.org/D117712 Files: lldb/include/lldb/Utility/Instrumentation.h

[Lldb-commits] [PATCH] D117490: [lldb] Log prototype

JDevlieghere added a comment. Very cool Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117490/new/ https://reviews.llvm.org/D117490 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D112825: [lldb] Add MemoryTagMap class

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112825/new/ https://reviews.llvm.org/D112825

[Lldb-commits] [PATCH] D117707: siginfo_t synthesis WIP

mgorny updated this revision to Diff 401421. mgorny added a comment. Initial PoC unit test — the idea is to verify field offsets and sizes against known values taken from real siginfo_t. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117707/new/ https://reviews.llvm.org/D117707 Files:

[Lldb-commits] [lldb] 742bfb3 - [lldb] Fix LLDB_FULL_VERSION_STRING

Author: Jonas Devlieghere Date: 2022-01-19T14:20:22-08:00 New Revision: 742bfb3581e72909dce913cc2d6d77b54777ecdc URL: https://github.com/llvm/llvm-project/commit/742bfb3581e72909dce913cc2d6d77b54777ecdc DIFF:

[Lldb-commits] [PATCH] D117707: siginfo_t synthesis WIP

mgorny updated this revision to Diff 401378. mgorny added a comment. Herald added a subscriber: fedor.sergeev. Use `CreateStructForIdentifier()` whenever possible. Describe the remaining union members. Open question: do we care for 100% correct SPARC support? Given that it has different

[Lldb-commits] [PATCH] D117712: [lldb] Disconnect instrumentation from the reproducers

JDevlieghere added a comment. In D117712#3255978 , @labath wrote: > It seems the set of macros could be reduced. If you don't need to generate > "unique identifiers" for each method, then you can stop worrying about const > methods, constructors, etc.

[Lldb-commits] [PATCH] D117632: [lldb] Instrument SB API with signposts

JDevlieghere added a comment. Yup, at this point I might as well inline it. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117632/new/ https://reviews.llvm.org/D117632 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D117632: [lldb] Instrument SB API with signposts

aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. Assuming UpdateBoundary is only called in the destructor this looks nice! Comment at: lldb/source/Utility/Instrumentation.cpp:21 +// Instrument SB API calls with

[Lldb-commits] [PATCH] D117712: [lldb] Disconnect instrumentation from the reproducers

labath added a comment. It seems the set of macros could be reduced. If you don't need to generate "unique identifiers" for each method, then you can stop worrying about const methods, constructors, etc. I think this could boil down to one or two macros... CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D117632: Instrument SB API with signposts

JDevlieghere updated this revision to Diff 401369. JDevlieghere retitled this revision from "Instrument SBAPI with scoped timers" to "Instrument SB API with signposts". JDevlieghere edited the summary of this revision. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117632/new/

[Lldb-commits] [PATCH] D117712: [lldb] Disconnect instrumentation from the reproducers

JDevlieghere created this revision. JDevlieghere added reviewers: aprantl, labath. Herald added a subscriber: mgorny. JDevlieghere requested review of this revision. Herald added a reviewer: jdoerfert. Herald added a subscriber: sstefan1. Remove the last remaining references to the reproducers

[Lldb-commits] [PATCH] D117707: siginfo_t synthesis WIP

mgorny updated this revision to Diff 401364. mgorny added a comment. Cover more union members. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117707/new/ https://reviews.llvm.org/D117707 Files: lldb/bindings/interface/SBPlatform.i lldb/include/lldb/API/SBPlatform.h

[Lldb-commits] [PATCH] D117707: siginfo_t synthesis WIP

mgorny created this revision. mgorny added reviewers: labath, emaste, krytarowski. mgorny requested review of this revision. To get some early feedback. https://reviews.llvm.org/D117707 Files: lldb/bindings/interface/SBPlatform.i lldb/include/lldb/API/SBPlatform.h

[Lldb-commits] [PATCH] D117632: Instrument SBAPI with scoped timers

JDevlieghere commandeered this revision. JDevlieghere edited reviewers, added: aprantl; removed: JDevlieghere. JDevlieghere added a comment. I can do this after the rename. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117632/new/ https://reviews.llvm.org/D117632

[Lldb-commits] [PATCH] D117632: Instrument SBAPI with scoped timers

aprantl added a comment. > I'm a little confused about what you want to achieve as well. With signposts you get a flamegraph of all nested signposted functions, which is really intuitive to look at. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117632/new/

[Lldb-commits] [PATCH] D117632: Instrument SBAPI with scoped timers

aprantl abandoned this revision. aprantl added a comment. In D117632#3255158 , @JDevlieghere wrote: > Do you actually care about the timers or is this really about getting these > methods instrumented with signposts on our platform? If it's the latter,

[Lldb-commits] [PATCH] D117601: [lldb] Make Python initialization atomic

This revision was automatically updated to reflect the committed changes. Closed by commit rGeb5c0ea68180: [lldb] Initialize Python exactly once (authored by JDevlieghere). Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/D117601?vs=401267=401300#toc Repository:

[Lldb-commits] [lldb] eb5c0ea - [lldb] Initialize Python exactly once

Author: Jonas Devlieghere Date: 2022-01-19T09:56:55-08:00 New Revision: eb5c0ea681803361a1944c966f4becaa9e22dc1a URL: https://github.com/llvm/llvm-project/commit/eb5c0ea681803361a1944c966f4becaa9e22dc1a DIFF:

[Lldb-commits] [PATCH] D117601: [lldb] Make Python initialization atomic

labath accepted this revision. labath added a comment. LG, thanks CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117601/new/ https://reviews.llvm.org/D117601 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D117632: Instrument SBAPI with scoped timers

JDevlieghere added a comment. Do you actually care about the timers or is this really about getting these methods instrumented with signposts on our platform? If it's the latter, I think it would make more sense to put that call in the `LLDB_RECORD_*` macros (which I'm planning to rename

[Lldb-commits] [PATCH] D117601: [lldb] Make Python initialization atomic

JDevlieghere added inline comments. Comment at: lldb/source/Plugins/ScriptInterpreter/Python/ScriptInterpreterPython.cpp:3154-3176 -#if LLDB_USE_PYTHON_SET_INTERRUPT -namespace { -/// Saves the current signal handler for the specified signal and restores -/// it at the end of

[Lldb-commits] [PATCH] D117601: [lldb] Make Python initialization atomic

JDevlieghere updated this revision to Diff 401267. JDevlieghere edited the summary of this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Do private initialization exactly once in ScriptInterpreterPython::Initialize CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D117564: [lldb] Remove the requirement for windows clients to specify -DIMPORT_LIBLLDB

thakis added a comment. > The background here is that I found this patch in one of my old WIP branches. > The next patch in the series was going to define LLDB_API to > `__attribute__((visibility("default")))` on the non-windows path (and make > everything else hidden), but I have no idea why

[Lldb-commits] [PATCH] D117637: Fix build break on CentOS due to gcc 7.3.1

labath added a comment. It's in as 8bfa7a6dcc274bf46ce1587cf51996a3389ceb63 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117637/new/ https://reviews.llvm.org/D117637

[Lldb-commits] [PATCH] D117564: [lldb] Remove the requirement for windows clients to specify -DIMPORT_LIBLLDB

labath added a comment. In D117564#3254798 , @thakis wrote: >> So what happens now if you define LLDB_IN_LIBLLDB? Does dllexport explode if >> used in a static library? > > Do you mean define it for all targets, instead of for just liblldb? > > If just

[Lldb-commits] [PATCH] D117637: Fix build break on CentOS due to gcc 7.3.1

codemzs added a comment. In D117637#3254195 , @labath wrote: > I needed to dust off my old-deps build for another patch, so I also fixed > this in the process. @labath Have you already committed your change? I need this for our builds that are broken.

[Lldb-commits] [PATCH] D117637: Fix build break on CentOS due to gcc 7.3.1

codemzs added a comment. In D117637#3254195 , @labath wrote: > I needed to dust off my old-deps build for another patch, so I also fixed > this in the process. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D117564: [lldb] Remove the requirement for windows clients to specify -DIMPORT_LIBLLDB

thakis added a comment. > So what happens now if you define LLDB_IN_LIBLLDB? Does dllexport explode if > used in a static library? Do you mean define it for all targets, instead of for just liblldb? If just for liblldb, then the link fails because (e.g.) driver tries to dllimport the symbols

[Lldb-commits] [lldb] 4f89157 - [lldb] Make StatsDuration thread-safe

Author: Pavel Labath Date: 2022-01-19T16:42:53+01:00 New Revision: 4f89157b9d73711a7ce20b597f93eb17a3133adf URL: https://github.com/llvm/llvm-project/commit/4f89157b9d73711a7ce20b597f93eb17a3133adf DIFF: https://github.com/llvm/llvm-project/commit/4f89157b9d73711a7ce20b597f93eb17a3133adf.diff

[Lldb-commits] [PATCH] D117474: [lldb] Make StatsDuration thread-safe

This revision was automatically updated to reflect the committed changes. Closed by commit rG4f89157b9d73: [lldb] Make StatsDuration thread-safe (authored by labath). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117474/new/

[Lldb-commits] [PATCH] D117564: [lldb] Remove the requirement for windows clients to specify -DIMPORT_LIBLLDB

labath added a comment. Well.. I wouldn't say it was intentional, but building (lib)lldb as a static library is not really supported either. Like, there's no way to do that from cmake. Some people using other build systems do that nonetheless, but it comes with all kinds of strings (regardless

[Lldb-commits] [PATCH] D117474: [lldb] Make StatsDuration thread-safe

labath added a comment. The precision is now limited to microseconds (arbitrary choice that I though should be sufficient) whereas previously it was... floating. There are no changes besides that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D117564: [lldb] Remove the requirement for windows clients to specify -DIMPORT_LIBLLDB

thakis added a comment. Before this change, it was very easy to build liblldb as a static library (just don't define IMPORT_LIBLLDB and EXPORT_LIBLLDB). After this change, this is no longer possible on Windows (but it still works fine everywhere else). Is this intentional? Repository: rG

[Lldb-commits] [PATCH] D117676: [LLDB] Port toolchain-msvc.test for Arm/AArch4 Windows

labath added a comment. To put it in a more constructive light, what I was trying to say that if you find yourself spending a lot of time struggling with the script, definitely down be afraid to strip it down, change how it works, or remove it completely. CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D117676: [LLDB] Port toolchain-msvc.test for Arm/AArch4 Windows

labath added a comment. FWIW, I consider the build.py script a failed experiment. The idea itself was not completely bad, but the lack of buy-in from sufficient amount of developers meant that it never really had a chance of fulfilling its (rather lofty) goals. I think it should be removed or

[Lldb-commits] [lldb] 9c4e93c - [LLDB] Adjust compiler-full-path.test for Windows/Arm64

Author: TCWG Date: 2022-01-19T19:47:03+05:00 New Revision: 9c4e93c71a80e9d6d4e9f1e9f90b14a6126e1f47 URL: https://github.com/llvm/llvm-project/commit/9c4e93c71a80e9d6d4e9f1e9f90b14a6126e1f47 DIFF: https://github.com/llvm/llvm-project/commit/9c4e93c71a80e9d6d4e9f1e9f90b14a6126e1f47.diff LOG:

[Lldb-commits] [PATCH] D117581: [lldb] Use lldb-server by default on Windows

labath added a comment. TBH, I am not really surprised by that. My recollection was that windows lldb-server was still missing some features to be a viable replacement, but I was hoping that I have recalled incorrectly. It'd definitely be interesting to see what the missing pieces are.

[Lldb-commits] [PATCH] D117676: [LLDB] Port toolchain-msvc.test for Arm/AArch4 Windows

omjavaid created this revision. omjavaid added a reviewer: JDevlieghere. Herald added a subscriber: kristof.beyls. omjavaid requested review of this revision. This patch updates toolchain-msvc.test to cater for Arm64 windows platform. https://reviews.llvm.org/D117676 Files:

[Lldb-commits] [PATCH] D117671: [lldb] Rename MemoryTagManager RemoveNonAddressBits to RemoveTagBits

DavidSpickett added a reviewer: omjavaid. DavidSpickett added a comment. As promised on https://reviews.llvm.org/D112824. I hope to get to a point where the tag managers only remove memory tag bits so this is a step toward that. Comment at:

[Lldb-commits] [PATCH] D117490: [lldb] Log prototype

labath added inline comments. Comment at: lldb/include/lldb/Utility/Logging.h:19 +enum class LLDBLog : uint32_t { + Process = 1u << 1, + LLVM_MARK_AS_BITMASK_ENUM(UINT32_MAX) clayborg wrote: > Why wouldn't we just add all of the categories in the enum? Are we

[Lldb-commits] [PATCH] D117672: [lldb] Remove non-address bits from addresses given to memory tag commands

DavidSpickett created this revision. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Although the memory tag commands use a memory tag manager to handle addresses, that only removes the top byte. That top byte is 4 bits of

[Lldb-commits] [PATCH] D117671: [lldb] Rename MemoryTagManager RemoveNonAddressBits to RemoveTagBits

DavidSpickett created this revision. Herald added a subscriber: kristof.beyls. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This better describes the intent of the method. Which for AArch64 is removing the top byte which

[Lldb-commits] [PATCH] D117632: Instrument SBAPI with scoped timers

labath added a comment. In D117632#3253445 , @jingham wrote: > I was about to say this shouldn't matter, since most people don't run with > timers enabled and the timers should be no-ops when timing is off. But > LLDB_SCOPED_TIMER seems to do a bunch

Re: [Lldb-commits] [PATCH] D117559: [lldb] Remove remote testing ability from lldb**-server** tests

On Wed, 19 Jan 2022 at 17:53, Pavel Labath via Phabricator < revi...@reviews.llvm.org> wrote: > labath added a comment. > > In D117559#3254095 , > @DavidSpickett wrote: > > > I'm running >

[Lldb-commits] [PATCH] D117559: [lldb] Remove remote testing ability from lldb**-server** tests

labath added a comment. In D117559#3254095 , @DavidSpickett wrote: > I'm running > `lldb/test/API/tools/lldb-server/memory-tagging/TestGdbRemoteMemoryTagging.py`. > > If the details matter any... > > In qemu: > > $ ./build-cross/bin/lldb-server

[Lldb-commits] [PATCH] D117637: Fix build break on CentOS due to gcc 7.3.1

labath added a comment. I needed to dust off my old-deps build for another patch, so I also fixed this in the process. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117637/new/ https://reviews.llvm.org/D117637

[Lldb-commits] [PATCH] D117550: [lldb] Introduce SBPlatform::SetSDKRoot

This revision was automatically updated to reflect the committed changes. Closed by commit rG903424532f0b: [lldb] Introduce SBPlatform::SetSDKRoot (authored by labath). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117550/new/

[Lldb-commits] [PATCH] D117564: [lldb] Remove the requirement for windows clients to specify -DIMPORT_LIBLLDB

This revision was automatically updated to reflect the committed changes. Closed by commit rGb2a162e63bd7: [lldb] Remove the requirement for windows clients to specify -DIMPORT_LIBLLDB (authored by labath). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] 9034245 - [lldb] Introduce SBPlatform::SetSDKRoot

Author: Pavel Labath Date: 2022-01-19T12:49:47+01:00 New Revision: 903424532f0b018447a00f8a534f362a9b3c246b URL: https://github.com/llvm/llvm-project/commit/903424532f0b018447a00f8a534f362a9b3c246b DIFF: https://github.com/llvm/llvm-project/commit/903424532f0b018447a00f8a534f362a9b3c246b.diff

[Lldb-commits] [lldb] b2a162e - [lldb] Remove the requirement for windows clients to specify -DIMPORT_LIBLLDB

Author: Pavel Labath Date: 2022-01-19T12:49:47+01:00 New Revision: b2a162e63bd735742fa22ed8d2465095db386bad URL: https://github.com/llvm/llvm-project/commit/b2a162e63bd735742fa22ed8d2465095db386bad DIFF: https://github.com/llvm/llvm-project/commit/b2a162e63bd735742fa22ed8d2465095db386bad.diff

[Lldb-commits] [lldb] 8bfa7a6 - [lldb] Fix NativeThreadLinux to build with older compilers

Author: Pavel Labath Date: 2022-01-19T12:49:47+01:00 New Revision: 8bfa7a6dcc274bf46ce1587cf51996a3389ceb63 URL: https://github.com/llvm/llvm-project/commit/8bfa7a6dcc274bf46ce1587cf51996a3389ceb63 DIFF: https://github.com/llvm/llvm-project/commit/8bfa7a6dcc274bf46ce1587cf51996a3389ceb63.diff

[Lldb-commits] [lldb] 6ff4af8 - [lldb] Fix D114722 for python<=3.6

Author: Pavel Labath Date: 2022-01-19T12:49:46+01:00 New Revision: 6ff4af8e182333740a58176a3e9cbc84f6828216 URL: https://github.com/llvm/llvm-project/commit/6ff4af8e182333740a58176a3e9cbc84f6828216 DIFF: https://github.com/llvm/llvm-project/commit/6ff4af8e182333740a58176a3e9cbc84f6828216.diff

[Lldb-commits] [PATCH] D117559: [lldb] Remove remote testing ability from lldb**-server** tests

omjavaid added a comment. This doesnt interfere with LLDB tests for SVE. Rather I have not used it in a while for SVE tests I ahve using setup similar to to one David has explained above. @labath Do you know if android adb based tests are being run anywhere? Are we still maintaining this

[Lldb-commits] [PATCH] D117559: [lldb] Remove remote testing ability from lldb**-server** tests

DavidSpickett added a comment. I'm running `lldb/test/API/tools/lldb-server/memory-tagging/TestGdbRemoteMemoryTagging.py`. If the details matter any... In qemu: $ ./build-cross/bin/lldb-server platform --server --listen 0.0.0.0:54321 On the host: $ ./bin/lldb-dotest --platform-name

[Lldb-commits] [PATCH] D117559: [lldb] Remove remote testing ability from lldb**-server** tests

labath added a comment. Thanks for the info. If you are using it then I think we can come up with something would support your use case. TBH, I am kinda surprised this even works (are you sure you're running lldb-*server* tests and not just the "normal" lldb ones?) -- I haven't seen any

[Lldb-commits] [PATCH] D117559: [lldb] Remove remote testing ability from lldb**-server** tests

DavidSpickett added a comment. Omair can comment on how useful this is for SVE testing. I do use this to run the memory tagging tests on qemu, we don't have real hardware yet. Let me see what extra steps I need to run them within qemu instead. Repository: rG LLVM Github Monorepo CHANGES

[Lldb-commits] [PATCH] D114722: [LLDB] Fix Python GIL-not-held issues

sylvestre.ledru added a comment. Seems that it broke apt.llvm.org on ubuntu bionic with Python 3.6: I reported this issue: https://github.com/llvm/llvm-project/issues/53291 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114722/new/