[Lldb-commits] [PATCH] D120595: [WIP][trace][intelpt] Add TSC to Nanosecond conversion for IntelPT traces

wallace added a comment. The main change is to make the counter conversion generic, so that we don't need to add more APIs in the future. Besides that, you don't need to make any drastic change. Good job so far! Comment at: lldb/docs/lldb-gdb-remote.txt:455 +//}], +//

[Lldb-commits] [PATCH] D121078: Replace links to archived mailing lists by links to Discourse forums

aaron.ballman accepted this revision. aaron.ballman added a comment. In D121078#3368424 , @tonic wrote: > In D121078#3367950 , @aaron.ballman > wrote: > >> I've added comments to the few places I'd like to see a

[Lldb-commits] [PATCH] D121168: Cleanup includes: LLVMTarget

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. Thanks! Comment at: llvm/include/llvm/Target/TargetMachine.h:21 #include "llvm/IR/PassManager.h" -#include "llvm/Pass.h" #include "llvm/Support/CodeGen.h"

[Lldb-commits] [PATCH] D121078: Replace links to archived mailing lists by links to Discourse forums

tonic added a comment. In D121078#3367950 , @aaron.ballman wrote: > In D121078#3367289 , @tonic wrote: > >> In D121078#3366825 , >> @aaron.ballman wrote: >> >>> In

[Lldb-commits] [PATCH] D121078: Replace links to archived mailing lists by links to Discourse forums

aaron.ballman requested changes to this revision. aaron.ballman added a reviewer: aaron.ballman. aaron.ballman added a comment. In D121078#3367289 , @tonic wrote: > In D121078#3366825 , @aaron.ballman > wrote: >

[Lldb-commits] [PATCH] D121348: Don't try to get memory returns for ABIMacOSX_arm64

jingham created this revision. jingham added reviewers: JDevlieghere, jasonmolenda. Herald added a subscriber: kristof.beyls. Herald added a project: All. jingham requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The ARM64 ABI does not

[Lldb-commits] [PATCH] D119508: [LLDB][NativePDB] Add support for S_DEFRANGE_REGISTER and S_DEFRANGE_SUBFIELD_REGISTER

zequanwu updated this revision to Diff 414210. zequanwu marked 3 inline comments as done. zequanwu edited the summary of this revision. zequanwu added a comment. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Update. Repository: rG LLVM Github Monorepo CHANGES SINCE

[Lldb-commits] [PATCH] D120972: [lldb] Show progress events in the command line driver

JDevlieghere added a comment. To summarize: I will remove the check because this doesn't matter for VSCode/Xcode because they don't use the default event loop and for those clients who might care about this, they should use the setting. Repository: rG LLVM Github Monorepo CHANGES SINCE

Re: [Lldb-commits] [PATCH] D120972: [lldb] Show progress events in the command line driver

That's certainly good enough for users. If you were the developer of another client, I think you'd want to keep people from inadvertently turning this back on. But that's probably a minor concern. And there isn't an equivalent good way to turn off the stop description from being printed if

[Lldb-commits] [PATCH] D120972: [lldb] Show progress events in the command line driver

labath added a comment. In D120972#3370850 , @jingham wrote: > But using the standard event loop and "I want to handle async notifications > by hand" seem like they should be separable choices. Is the `show-progress` setting not enough of separation?

[Lldb-commits] [PATCH] D120972: [lldb] Show progress events in the command line driver

jingham added a comment. But using the standard event loop and "I want to handle async notifications by hand" seem like they should be separable choices. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120972/new/ https://reviews.llvm.org/D120972

[Lldb-commits] [PATCH] D120972: [lldb] Show progress events in the command line driver

jingham added a comment. In D120972#3370814 , @clayborg wrote: > In D120972#3370688 , @jingham wrote: > >> In D120972#3370529 , @clayborg >> wrote: >> >>> I liked that

[Lldb-commits] [PATCH] D120972: [lldb] Show progress events in the command line driver

clayborg added a comment. In D120972#3370688 , @jingham wrote: > In D120972#3370529 , @clayborg > wrote: > >> I liked that part of the patch where it wouldn't report events through the >> debugger if someone is

[Lldb-commits] [PATCH] D120972: [lldb] Show progress events in the command line driver

jingham added a comment. In D120972#3370529 , @clayborg wrote: > I liked that part of the patch where it wouldn't report events through the > debugger if someone is already handling them. lldb-vscode handles these > events already, but we also set the

[Lldb-commits] [PATCH] D121316: [lldb/Plugin] Test that a scripted process blueprint can be loaded for the dSYM

mib created this revision. mib added reviewers: JDevlieghere, jingham. mib added a project: LLDB. Herald added a project: All. mib requested review of this revision. Herald added a subscriber: lldb-commits. This patch ensures that lldb can automatically load a scripted process blueprint from a

[Lldb-commits] [PATCH] D121305: [lldb/gdb-remote] Remove ancient debugserver workaround

jingham added a comment. Note this isn't about thread-suffix, that was an accidental marker for the debugservers that had an unrelated bug with shutting down when there was a thread stopped at a breakpoint or exception. But you are right about the main point, there hasn't been a debugserver

[Lldb-commits] [lldb] f52b5a8 - lldb/ObjectFile: reflow a comment (NFC)

Author: Saleem Abdulrasool Date: 2022-03-09T18:47:31Z New Revision: f52b5a852a4b4d48b9c049e68569cfdb184f11ab URL: https://github.com/llvm/llvm-project/commit/f52b5a852a4b4d48b9c049e68569cfdb184f11ab DIFF: https://github.com/llvm/llvm-project/commit/f52b5a852a4b4d48b9c049e68569cfdb184f11ab.diff

[Lldb-commits] [PATCH] D120972: [lldb] Show progress events in the command line driver

clayborg added a comment. I liked that part of the patch where it wouldn't report events through the debugger if someone is already handling them. lldb-vscode handles these events already, but we also set the debugger's out and error file handle to /dev/null Repository: rG LLVM Github

[Lldb-commits] [PATCH] D120972: [lldb] Show progress events in the command line driver

labath added inline comments. Comment at: lldb/source/Core/Debugger.cpp:1624 + if (!m_broadcaster.EventTypeHasListeners(Debugger::eBroadcastBitProgress)) { +listener_sp->StartListeningForEvents(_broadcaster, JDevlieghere wrote: > labath wrote: > > labath

[Lldb-commits] [PATCH] D120972: [lldb] Show progress events in the command line driver

JDevlieghere added inline comments. Comment at: lldb/source/Core/Debugger.cpp:1624 + if (!m_broadcaster.EventTypeHasListeners(Debugger::eBroadcastBitProgress)) { +listener_sp->StartListeningForEvents(_broadcaster, labath wrote: > labath wrote: > > Why is

[Lldb-commits] [PATCH] D121305: [lldb/gdb-remote] Remove ancient debugserver workaround

JDevlieghere added a comment. In D121305#3370357 , @labath wrote: > In D121305#3370337 , @JDevlieghere > wrote: > >> Assuming this isn't relevant anymore > > I was hoping you would be able to tell me that. :P

[Lldb-commits] [PATCH] D121305: [lldb/gdb-remote] Remove ancient debugserver workaround

labath added a comment. In D121305#3370337 , @JDevlieghere wrote: > Assuming this isn't relevant anymore I was hoping you would be able to tell me that. :P I mean, it keys off of `GetThreadSuffixSupported() == false`, which means it must catch only

[Lldb-commits] [PATCH] D121161: [lldb] Avoid global constructor in LLDBLog.cpp

JDevlieghere abandoned this revision. JDevlieghere added a comment. In D121161#3369641 , @labath wrote: > Amusingly enough, the problem is the custom operator| used for bitmask enums. > D121281 ought to fix that (by

[Lldb-commits] [PATCH] D121305: [lldb/gdb-remote] Remove ancient debugserver workaround

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Assuming this isn't relevant anymore, LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121305/new/

[Lldb-commits] [PATCH] D121305: [lldb/gdb-remote] Remove ancient debugserver workaround

labath added a comment. Phabricator didn't turn the commit reference into a link as I'd hoped, so here is it now: rG43c555dfcd76004d56ba03fd33ebbdba09f58d47 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D121290: [lldb] Create an enum to specify the kind of ArchSpec matching

JDevlieghere accepted this revision. JDevlieghere added a comment. Thanks! LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121290/new/ https://reviews.llvm.org/D121290 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D121305: [lldb/gdb-remote] Remove ancient debugserver workaround

labath created this revision. labath added reviewers: jingham, JDevlieghere, jasonmolenda. Herald added a subscriber: mgorny. Herald added a project: All. labath requested review of this revision. Herald added a project: LLDB. This workaround is the source of an awkwared Process->Platform

[Lldb-commits] [PATCH] D120810: [lldb] Remove the global platform list

labath added inline comments. Comment at: lldb/source/Plugins/Platform/gdb-server/CMakeLists.txt:10 lldbPluginProcessUtility +lldbPluginProcessGDBRemote ) thakis wrote: > It doesn't seem like lldb cares about this kind of thing, but this adds a >

[Lldb-commits] [lldb] d65e6ff - Revert "[lldb] Remove the global platform list"

Author: Pavel Labath Date: 2022-03-09T18:13:45+01:00 New Revision: d65e6ff2f1a480df52b275cadc9bc3e7b31d4fb6 URL: https://github.com/llvm/llvm-project/commit/d65e6ff2f1a480df52b275cadc9bc3e7b31d4fb6 DIFF: https://github.com/llvm/llvm-project/commit/d65e6ff2f1a480df52b275cadc9bc3e7b31d4fb6.diff

[Lldb-commits] [PATCH] D121290: [lldb] Create an enum to specify the kind of ArchSpec matching

jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. That is easier to read for sure. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121290/new/ https://reviews.llvm.org/D121290

[Lldb-commits] [PATCH] D120810: [lldb] Remove the global platform list

thakis added inline comments. Comment at: lldb/source/Plugins/Platform/gdb-server/CMakeLists.txt:10 lldbPluginProcessUtility +lldbPluginProcessGDBRemote ) It doesn't seem like lldb cares about this kind of thing, but this adds a dependency cycle:

[Lldb-commits] [lldb] 02def06 - [lldb] Fix step-avoid-regexp logging

Author: Dave Lee Date: 2022-03-09T08:35:15-08:00 New Revision: 02def06e60369d616456251cb0f8e60115287128 URL: https://github.com/llvm/llvm-project/commit/02def06e60369d616456251cb0f8e60115287128 DIFF: https://github.com/llvm/llvm-project/commit/02def06e60369d616456251cb0f8e60115287128.diff

[Lldb-commits] [PATCH] D119298: [lldb] Fix step-avoid-regexp logging

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG02def06e6036: [lldb] Fix step-avoid-regexp logging (authored by kastiglione). Herald added a project: All. Repository:

[Lldb-commits] [PATCH] D121252: [lldb] Add SBType::IsAggregateType

This revision was automatically updated to reflect the committed changes. Closed by commit rG704001e90b3d: [lldb] Add SBType::IsAggregateType (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121252/new/

[Lldb-commits] [lldb] 704001e - [lldb] Add SBType::IsAggregateType

Author: Dave Lee Date: 2022-03-09T08:33:08-08:00 New Revision: 704001e90b3d434c710ed178c95ae42961a7f7b0 URL: https://github.com/llvm/llvm-project/commit/704001e90b3d434c710ed178c95ae42961a7f7b0 DIFF: https://github.com/llvm/llvm-project/commit/704001e90b3d434c710ed178c95ae42961a7f7b0.diff

[Lldb-commits] [lldb] 49cffe3 - [lldb] Fix TestDebuggerAPI on windows (broken by D120810)

Author: Pavel Labath Date: 2022-03-09T16:54:24+01:00 New Revision: 49cffe3c7fab74252d4b6a073303c803dc1659f0 URL: https://github.com/llvm/llvm-project/commit/49cffe3c7fab74252d4b6a073303c803dc1659f0 DIFF: https://github.com/llvm/llvm-project/commit/49cffe3c7fab74252d4b6a073303c803dc1659f0.diff

[Lldb-commits] [PATCH] D120810: [lldb] Remove the global platform list

This revision was automatically updated to reflect the committed changes. Closed by commit rGffb9429b6f3c: [lldb] Remove the global platform list (authored by labath). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120810/new/

[Lldb-commits] [lldb] ffb9429 - [lldb] Remove the global platform list

Author: Pavel Labath Date: 2022-03-09T16:11:16+01:00 New Revision: ffb9429b6f3c29ab4687b96fd85374924c98ad16 URL: https://github.com/llvm/llvm-project/commit/ffb9429b6f3c29ab4687b96fd85374924c98ad16 DIFF: https://github.com/llvm/llvm-project/commit/ffb9429b6f3c29ab4687b96fd85374924c98ad16.diff

[Lldb-commits] [PATCH] D120810: [lldb] Remove the global platform list

labath added inline comments. Comment at: lldb/source/Target/Platform.cpp:1891 + +PlatformSP PlatformList::GetOrCreate(const ArchSpec , + ArchSpec *platform_arch_ptr, JDevlieghere wrote: > [Nit/pedantic] We have a few calls to

[Lldb-commits] [PATCH] D121290: [lldb] Create an enum to specify the kind of ArchSpec matching

labath created this revision. labath added a reviewer: JDevlieghere. Herald added a project: All. labath requested review of this revision. Herald added a project: LLDB. s/true/ArchSpec::ExactMatch s/false/ArchSpec::CompatibleMatch Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D120595: [WIP][trace][intelpt] Add TSC to Nanosecond conversion for IntelPT traces

jj10306 marked 10 inline comments as done. jj10306 added inline comments. Comment at: lldb/include/lldb/Target/TraceCursor.h:193 + // TODO: add docs and rename once naming convention is agreed upon + virtual llvm::Optional GetNanos() = 0; + wallace wrote: >

[Lldb-commits] [PATCH] D120803: [lldb] Don't print *trailing* nuls in char arrays

This revision was automatically updated to reflect the committed changes. Closed by commit rGacf77bd2fd90: [lldb] Dont print *trailing* nuls in char arrays (authored by labath). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120803/new/

[Lldb-commits] [PATCH] D120320: [lldb/driver] Fix SIGTSTP handling

This revision was automatically updated to reflect the committed changes. Closed by commit rG4bcadd66864b: [lldb/driver] Fix SIGTSTP handling (authored by labath). Changed prior to commit: https://reviews.llvm.org/D120320?vs=412643=414078#toc Repository: rG LLVM Github Monorepo CHANGES

[Lldb-commits] [PATCH] D120892: [lldb] Warn when we fail to find dwo/dwp files

This revision was automatically updated to reflect the committed changes. Closed by commit rG8f6ee17f22a7: [lldb] Warn when we fail to find dwo/dwp files (authored by labath). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120892/new/

[Lldb-commits] [lldb] acf77bd - [lldb] Don't print *trailing* nuls in char arrays

Author: Pavel Labath Date: 2022-03-09T14:31:17+01:00 New Revision: acf77bd2fd90d3b1347e50219c556057ef882d55 URL: https://github.com/llvm/llvm-project/commit/acf77bd2fd90d3b1347e50219c556057ef882d55 DIFF: https://github.com/llvm/llvm-project/commit/acf77bd2fd90d3b1347e50219c556057ef882d55.diff

[Lldb-commits] [lldb] 4bcadd6 - [lldb/driver] Fix SIGTSTP handling

Author: Pavel Labath Date: 2022-03-09T14:31:17+01:00 New Revision: 4bcadd66864bf4af929ac8753a51d7ad408cdef0 URL: https://github.com/llvm/llvm-project/commit/4bcadd66864bf4af929ac8753a51d7ad408cdef0 DIFF: https://github.com/llvm/llvm-project/commit/4bcadd66864bf4af929ac8753a51d7ad408cdef0.diff

[Lldb-commits] [lldb] 8f6ee17 - [lldb] Warn when we fail to find dwo/dwp files

Author: Pavel Labath Date: 2022-03-09T14:31:17+01:00 New Revision: 8f6ee17f22a7575671ad1581231f29947a6a280a URL: https://github.com/llvm/llvm-project/commit/8f6ee17f22a7575671ad1581231f29947a6a280a DIFF: https://github.com/llvm/llvm-project/commit/8f6ee17f22a7575671ad1581231f29947a6a280a.diff

[Lldb-commits] [PATCH] D120972: [lldb] Show progress events in the command line driver

labath added inline comments. Comment at: lldb/source/Core/Debugger.cpp:1624 + if (!m_broadcaster.EventTypeHasListeners(Debugger::eBroadcastBitProgress)) { +listener_sp->StartListeningForEvents(_broadcaster, labath wrote: > Why is this conditional on

[Lldb-commits] [PATCH] D120972: [lldb] Show progress events in the command line driver

labath added inline comments. Comment at: lldb/source/Core/Debugger.cpp:1624 + if (!m_broadcaster.EventTypeHasListeners(Debugger::eBroadcastBitProgress)) { +listener_sp->StartListeningForEvents(_broadcaster, Why is this conditional on someone else

[Lldb-commits] [PATCH] D121161: [lldb] Avoid global constructor in LLDBLog.cpp

labath added a comment. Amusingly enough, the problem is the custom operator| used for bitmask enums. D121281 ought to fix that (by making the function constexpr). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121161/new/

[Lldb-commits] [lldb] ad709bc - [lldb] Fix -Wformat warning after 5a27b99825a5ba3a7a2eec3d35aea381a3ba9a31

Author: Krasimir Georgiev Date: 2022-03-09T12:41:34+01:00 New Revision: ad709bcfb02e5bc7c92a8f1b9b6f0ef76a8081fd URL: https://github.com/llvm/llvm-project/commit/ad709bcfb02e5bc7c92a8f1b9b6f0ef76a8081fd DIFF: