[Lldb-commits] [PATCH] D128323: [lldb] Add support for specifying a log handler

JDevlieghere created this revision. JDevlieghere added reviewers: labath, clayborg, kastiglione, mib. Herald added a project: All. JDevlieghere requested review of this revision. This patch adds a new flag to `log enable` allowing the user to specify a log handler. This makes it possible to

[Lldb-commits] [PATCH] D128321: [lldb] Add OSLog log handler

JDevlieghere created this revision. JDevlieghere added reviewers: aprantl, labath, clayborg. Herald added a project: All. JDevlieghere requested review of this revision. Add an OSLog log handler on macOS. These log messages end up in Console.app and will be part of a sysdiagnose.

[Lldb-commits] [PATCH] D128152: [lldb] [llgs] Support multiprocess in qfThreadInfo

mgorny updated this revision to Diff 438914. mgorny marked an inline comment as done. mgorny added a comment. Simplify to use a single loop for both multiprocess and non-multiprocess modes. Replace the static function with `include_pid` with a class method, to prepare for adding a new helper to

[Lldb-commits] [PATCH] D50304: [lldb] Fix thread step until to not set breakpoint(s) on incorrect line numbers

RamNalamothu added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D50304/new/ https://reviews.llvm.org/D50304 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D128152: [lldb] [llgs] Support multiprocess in qfThreadInfo

mgorny marked an inline comment as done. mgorny added inline comments. Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp:1967 + + if (multiprocess) { +for (auto _ptr : m_debugged_processes) labath wrote: > without

[Lldb-commits] [lldb] 5e9aed1 - [lldb] [test] Mark TestNonStop as LLGS-specific

Author: Michał Górny Date: 2022-06-22T05:36:30+02:00 New Revision: 5e9aed1be5a5608d97c2ec3ac87698a8257b0ea7 URL: https://github.com/llvm/llvm-project/commit/5e9aed1be5a5608d97c2ec3ac87698a8257b0ea7 DIFF: https://github.com/llvm/llvm-project/commit/5e9aed1be5a5608d97c2ec3ac87698a8257b0ea7.diff

[Lldb-commits] [PATCH] D125575: [lldb] [llgs] Implement non-stop style stop notification packets

mgorny added a comment. In D125575#3600640 , @mib wrote: > Hi @mgorny ! `TestNonStop.py` is also failing on the macOS bots: > https://green.lab.llvm.org/green/job/lldb-cmake/44743/ > > Let me know if you need help reproducing the issue, otherwise skip

[Lldb-commits] [PATCH] D128312: [lldb] Add a setting to specify the preferred dynamic class info extractor function

This revision was automatically updated to reflect the committed changes. Closed by commit rGc866f8544c92: [lldb] Add a setting to specify the preferred dynamic class info extractor o (authored by JDevlieghere). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE

[Lldb-commits] [PATCH] D128306: [lldb] Instantiate lazily named classes on macOS Ventura.

This revision was automatically updated to reflect the committed changes. Closed by commit rGc08f61b45e3b: [lldb] Instantiate lazily named classes on macOS Ventura. (authored by JDevlieghere). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] c08f61b - [lldb] Instantiate lazily named classes on macOS Ventura.

Author: Jonas Devlieghere Date: 2022-06-21T18:51:38-07:00 New Revision: c08f61b45e3b93c25bc0405a489a382a54a5d941 URL: https://github.com/llvm/llvm-project/commit/c08f61b45e3b93c25bc0405a489a382a54a5d941 DIFF:

[Lldb-commits] [lldb] c866f85 - [lldb] Add a setting to specify the preferred dynamic class info extractor o

Author: Jonas Devlieghere Date: 2022-06-21T18:51:39-07:00 New Revision: c866f8544c929578a49e0b222f2171da71c9f415 URL: https://github.com/llvm/llvm-project/commit/c866f8544c929578a49e0b222f2171da71c9f415 DIFF:

[Lldb-commits] [PATCH] D127986: [lldb] Support a buffered logging mode

JDevlieghere added a comment. @labath let me know if this is what you had in mind CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127986/new/ https://reviews.llvm.org/D127986 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D125575: [lldb] [llgs] Implement non-stop style stop notification packets

mib added a comment. Herald added a subscriber: JDevlieghere. Hi @mgorny ! `TestNonStop.py` is also failing on the macOS bots: https://green.lab.llvm.org/green/job/lldb-cmake/44743/ Let me know if you need help reproducing the issue, otherwise skip the test on Darwin systems `@skipIfDarwin`

[Lldb-commits] [PATCH] D128316: [trace] Add an option to dump instructions in json and to a file

wallace updated this revision to Diff 438884. wallace added a comment. add a test for -a Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128316/new/ https://reviews.llvm.org/D128316 Files: lldb/include/lldb/Target/TraceCursor.h

[Lldb-commits] [PATCH] D128316: [trace] Add an option to dump instructions in json and to a file

wallace created this revision. wallace added a reviewer: jj10306. Herald added a project: All. wallace requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. In order to provide simple scripting support on top of instruction traces, a simple

[Lldb-commits] [PATCH] D126513: Add -b (--continue-to-breakpoint) option to the "process continue" command

jingham updated this revision to Diff 438879. jingham added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126513/new/ https://reviews.llvm.org/D126513 Files: lldb/source/Commands/CommandObjectProcess.cpp

[Lldb-commits] [PATCH] D128312: [lldb] Add a setting to specify the preferred dynamic class info extractor function

JDevlieghere updated this revision to Diff 438876. JDevlieghere marked 2 inline comments as done. JDevlieghere added a comment. Adress Adrian's code review feedback CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128312/new/ https://reviews.llvm.org/D128312 Files:

[Lldb-commits] [PATCH] D128312: [lldb] Add a setting to specify the preferred dynamic class info extractor function

aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. Patch looks fine. Wording suggestion for the user-visible parts inside. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128312/new/ https://reviews.llvm.org/D128312

[Lldb-commits] [PATCH] D128312: [lldb] Add a setting to specify the preferred dynamic class info extractor function

aprantl added inline comments. Comment at: lldb/source/Target/TargetProperties.td:57 " C++ standard library types.">; + def DynamicClassInfoHelper: Property<"dynamic-class-info-helper", "Enum">, +DefaultEnumValue<"eDynamicClassInfoHelperAuto">,

[Lldb-commits] [PATCH] D128026: [lldb] Add a BufferedLogHandler

JDevlieghere abandoned this revision. JDevlieghere added a comment. With D127986 I don't think we need this anymore. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128026/new/ https://reviews.llvm.org/D128026

[Lldb-commits] [PATCH] D128312: [lldb] Add a setting to specify the preferred dynamic class info extractor function

JDevlieghere created this revision. JDevlieghere added a reviewer: aprantl. Herald added a project: All. JDevlieghere requested review of this revision. Add a setting to specify the preferred dynamic class info extractor function. https://reviews.llvm.org/D128312 Files:

[Lldb-commits] [PATCH] D128306: [lldb] Instantiate lazily named classes on macOS Ventura.

aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128306/new/ https://reviews.llvm.org/D128306 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D126513: Add -b (--continue-to-breakpoint) option to the "process continue" command

kastiglione accepted this revision. kastiglione added a comment. This revision is now accepted and ready to land. thanks Jim Comment at: lldb/source/Commands/CommandObjectProcess.cpp:600 + m_options.m_run_to_bkpt_args, target, result, _to_bkpt_ids, +

[Lldb-commits] [PATCH] D128026: [lldb] Add a BufferedLogHandler

clayborg added a comment. This is an interesting take that makes more sense than specifying a size in bytes and a "m_circular" since that kind of thing could cut the first message. Saving entire messages as they are logged might make more sense for our circular log messages as we would ensure

[Lldb-commits] [PATCH] D128264: [lldb/dyld-posix] Avoid reading the module list in inconsistent states

emrekultursay added a comment. > Mainly added you in case you want to try this out on android. Thanks. I tested this on a few Android API levels, and it looks good to me. Comment at: lldb/source/Plugins/DynamicLoader/POSIX-DYLD/DynamicLoaderPOSIXDYLD.cpp:441 +

[Lldb-commits] [PATCH] D127986: [lldb] Support a buffered logging mode

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Looks good! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127986/new/ https://reviews.llvm.org/D127986 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D128292: [lldb/Fuzzer] Add command interpreter fuzzer for LLDB

cassanova added inline comments. Comment at: lldb/tools/lldb-fuzzer/lldb-commandinterpreter-fuzzer/lldb-commandinterpreter-fuzzer.cpp:39 + SBCommandReturnObject ro = SBCommandReturnObject(); + SBCommandInterpreter thisinterpreter = debugger.GetCommandInterpreter(); +

[Lldb-commits] [PATCH] D128292: [lldb/Fuzzer] Add command interpreter fuzzer for LLDB

cassanova updated this revision to Diff 438839. cassanova added a comment. Sorted subdirectories alphabetically in top-level CMakeLists file. Removed lldbfuzzer link library in command interpreter CMakeLists file. Fixed ASCII art in command interpreter source file, renamed `thisinterpreter` to

[Lldb-commits] [PATCH] D128306: [lldb] Instantiate lazily named classes on macOS Ventura.

JDevlieghere created this revision. JDevlieghere added a reviewer: aprantl. Herald added a project: All. JDevlieghere requested review of this revision. Recent revisions of the Objective-C runtime changed objc_debug_class_getNameRaw() in a way that no longer triggers lazy names to be

[Lldb-commits] [PATCH] D128026: [lldb] Add a BufferedLogHandler

JDevlieghere added a comment. In D128026#3595457 , @labath wrote: > I feel I should note that the llvm streams already have a buffered mode, and > given the way things are implemented now (our log class writes the entire log > message in one call, and

[Lldb-commits] [PATCH] D127986: [lldb] Support a buffered logging mode

JDevlieghere updated this revision to Diff 438831. JDevlieghere edited the summary of this revision. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127986/new/ https://reviews.llvm.org/D127986 Files: lldb/include/lldb/Core/Debugger.h lldb/include/lldb/Utility/Log.h

[Lldb-commits] [PATCH] D125509: [LLDB][NFC] Decouple dwarf location table from DWARFExpression.

zequanwu added inline comments. Comment at: lldb/source/Expression/DWARFExpressionList.cpp:179 + if (m_exprs.GetSize() == 1) { +expr = m_exprs.Back()->data; + } else { labath wrote: > I don't think this is correct. > > We should be able to distinguish

[Lldb-commits] [PATCH] D128292: [lldb/Fuzzer] Add command interpreter fuzzer for LLDB

mib added inline comments. Comment at: lldb/tools/lldb-fuzzer/lldb-commandinterpreter-fuzzer/lldb-commandinterpreter-fuzzer.cpp:39 + SBCommandReturnObject ro = SBCommandReturnObject(); + SBCommandInterpreter thisinterpreter = debugger.GetCommandInterpreter(); +

[Lldb-commits] [PATCH] D128292: [lldb/Fuzzer] Add command interpreter fuzzer for LLDB

cassanova added inline comments. Comment at: lldb/tools/lldb-fuzzer/lldb-commandinterpreter-fuzzer/CMakeLists.txt:15 +liblldb +lldbFuzzerUtils +) JDevlieghere wrote: > I don't think this used any longer. Ok, I can remove this library.

[Lldb-commits] [PATCH] D128170: [lldb] [llgs] Implement the 'T' packet

mgorny updated this revision to Diff 438823. mgorny added a comment. Rebase. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128170/new/ https://reviews.llvm.org/D128170 Files: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp

[Lldb-commits] [PATCH] D127862: [lldb] [llgs] Support resuming one process with PID!=current via vCont

mgorny updated this revision to Diff 438822. mgorny added a comment. Rebase. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127862/new/ https://reviews.llvm.org/D127862 Files: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp

[Lldb-commits] [PATCH] D127667: [lldb] [llgs] Implement the vKill packet

mgorny updated this revision to Diff 438819. mgorny added a comment. Rebase. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127667/new/ https://reviews.llvm.org/D127667 Files: lldb/include/lldb/Utility/StringExtractorGDBRemote.h

[Lldb-commits] [PATCH] D127500: [lldb] [llgs] Make `k` kill all processes, and fix multiple exits

mgorny updated this revision to Diff 438818. mgorny added a comment. Rebase and fix for nonstop. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127500/new/ https://reviews.llvm.org/D127500 Files: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp

[Lldb-commits] [PATCH] D125509: [LLDB][NFC] Decouple dwarf location table from DWARFExpression.

zequanwu updated this revision to Diff 438817. zequanwu marked 5 inline comments as done. zequanwu added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125509/new/ https://reviews.llvm.org/D125509 Files:

[Lldb-commits] [PATCH] D128292: [lldb/Fuzzer] Add command interpreter fuzzer for LLDB

mib added inline comments. Comment at: lldb/tools/lldb-fuzzer/lldb-commandinterpreter-fuzzer/lldb-commandinterpreter-fuzzer.cpp:39 + SBCommandReturnObject ro = SBCommandReturnObject(); + SBCommandInterpreter thisinterpreter = debugger.GetCommandInterpreter(); +

[Lldb-commits] [PATCH] D128292: [lldb/Fuzzer] Add command interpreter fuzzer for LLDB

mib added inline comments. Comment at: lldb/tools/lldb-fuzzer/lldb-commandinterpreter-fuzzer/lldb-commandinterpreter-fuzzer.cpp:39 + SBCommandReturnObject ro = SBCommandReturnObject(); + SBCommandInterpreter thisinterpreter = debugger.GetCommandInterpreter(); +

[Lldb-commits] [PATCH] D128292: [lldb/Fuzzer] Add command interpreter fuzzer for LLDB

JDevlieghere added inline comments. Comment at: lldb/tools/lldb-fuzzer/CMakeLists.txt:1-2 add_subdirectory(lldb-target-fuzzer) +add_subdirectory(lldb-commandinterpreter-fuzzer) add_subdirectory(utils) nit: I'd sort these alphabetically

[Lldb-commits] [PATCH] D128292: [lldb/Fuzzer] Add command interpreter fuzzer for LLDB

cassanova updated this revision to Diff 438810. cassanova added a comment. Removed ObjectYAML link component from CMakeLists file, changed fuzzer invocation to use a relative path for the dictionary file, removed line that sets a breakpoint in the fuzzer's LLDB process. CHANGES SINCE LAST

[Lldb-commits] [PATCH] D128292: [lldb/Fuzzer] Add command interpreter fuzzer for LLDB

cassanova added inline comments. Comment at: lldb/tools/lldb-fuzzer/lldb-commandinterpreter-fuzzer/CMakeLists.txt:3 + Support + ObjectYAML + ) JDevlieghere wrote: > I assume we don't need this anymore if we're using the dummy target? Yes this isn't necessary

[Lldb-commits] [lldb] 1490f87 - Roll back Michał's changes to debugserver, not meant for there

Author: Jason Molenda Date: 2022-06-21T12:57:42-07:00 New Revision: 1490f87154fb31222903a05f6d64c0508016f55c URL: https://github.com/llvm/llvm-project/commit/1490f87154fb31222903a05f6d64c0508016f55c DIFF: https://github.com/llvm/llvm-project/commit/1490f87154fb31222903a05f6d64c0508016f55c.diff

[Lldb-commits] [PATCH] D128292: [lldb/Fuzzer] Add command interpreter fuzzer for LLDB

JDevlieghere added inline comments. Comment at: lldb/tools/lldb-fuzzer/lldb-commandinterpreter-fuzzer/CMakeLists.txt:3 + Support + ObjectYAML + ) I assume we don't need this anymore if we're using the dummy target? Comment at:

[Lldb-commits] [PATCH] D128069: [lldb] add SBSection.alignment to python bindings

clayborg added a comment. In D128069#3599456 , @dmlary wrote: > Sent this via email, but doesn't look like it showed up here: > >> I'm less concerned about the getter and the property and more about the >> underlying functionality. It doesn't look like

[Lldb-commits] [PATCH] D128292: [lldb/Fuzzer] Add command interpreter fuzzer for LLDB

cassanova created this revision. cassanova added reviewers: JDevlieghere, mib. cassanova added a project: LLDB. Herald added a subscriber: mgorny. Herald added a project: All. cassanova requested review of this revision. Herald added a subscriber: lldb-commits. This adds a command interpreter

[Lldb-commits] [lldb] 80c04c6 - [lldb] [llgs] Attempt to fix LLGS tests on Windows

Author: Michał Górny Date: 2022-06-21T20:12:07+02:00 New Revision: 80c04c664a2a1900c5fdbf88c2c11e3f4f4ebf71 URL: https://github.com/llvm/llvm-project/commit/80c04c664a2a1900c5fdbf88c2c11e3f4f4ebf71 DIFF: https://github.com/llvm/llvm-project/commit/80c04c664a2a1900c5fdbf88c2c11e3f4f4ebf71.diff

[Lldb-commits] [PATCH] D127291: [lldb] [llgs] Add a test for detach-all packet

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG13eb5b3455fb: [lldb] [llgs] Add a test for detach-all packet (authored by mgorny). Herald added a project: LLDB. Repository: rG LLVM Github

[Lldb-commits] [lldb] 13eb5b3 - [lldb] [llgs] Add a test for detach-all packet

Author: Michał Górny Date: 2022-06-21T19:47:31+02:00 New Revision: 13eb5b3455fbeb959ab36974e17ba03222d6a4d0 URL: https://github.com/llvm/llvm-project/commit/13eb5b3455fbeb959ab36974e17ba03222d6a4d0 DIFF: https://github.com/llvm/llvm-project/commit/13eb5b3455fbeb959ab36974e17ba03222d6a4d0.diff

[Lldb-commits] [PATCH] D127290: [lldb] [llgs] Refactor fork/vfork tests, verify state

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG313d9c1519b7: [lldb] [llgs] Refactor fork/vfork tests, verify state (authored by mgorny). Herald added a project: LLDB. Changed prior to commit:

[Lldb-commits] [lldb] 313d9c1 - [lldb] [llgs] Refactor fork/vfork tests, verify state

Author: Michał Górny Date: 2022-06-21T19:47:30+02:00 New Revision: 313d9c1519b7f93b3dcb9ae1d535adf7b0da821d URL: https://github.com/llvm/llvm-project/commit/313d9c1519b7f93b3dcb9ae1d535adf7b0da821d DIFF: https://github.com/llvm/llvm-project/commit/313d9c1519b7f93b3dcb9ae1d535adf7b0da821d.diff

[Lldb-commits] [PATCH] D127193: [lldb] [llgs] Fix signo sent with fork/vfork/vforkdone events

This revision was automatically updated to reflect the committed changes. Closed by commit rGd6b3de72566f: [lldb] [llgs] Fix signo sent with fork/vfork/vforkdone events (authored by mgorny). Herald added a project: LLDB. Changed prior to commit:

[Lldb-commits] [PATCH] D128253: [lldb] [MainLoop] Support "pending callbacks", to be called once

This revision was automatically updated to reflect the committed changes. Closed by commit rG5b04eb23ae1a: [lldb] [MainLoop] Support pending callbacks, to be called once (authored by mgorny). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] d6b3de7 - [lldb] [llgs] Fix signo sent with fork/vfork/vforkdone events

Author: Michał Górny Date: 2022-06-21T19:47:30+02:00 New Revision: d6b3de72566f874f198b2ddcecbec53e95c623fe URL: https://github.com/llvm/llvm-project/commit/d6b3de72566f874f198b2ddcecbec53e95c623fe DIFF: https://github.com/llvm/llvm-project/commit/d6b3de72566f874f198b2ddcecbec53e95c623fe.diff

[Lldb-commits] [lldb] 5b04eb2 - [lldb] [MainLoop] Support "pending callbacks", to be called once

Author: Michał Górny Date: 2022-06-21T19:47:30+02:00 New Revision: 5b04eb23ae1a4db074b7ddc2e0c136d008fb5bc7 URL: https://github.com/llvm/llvm-project/commit/5b04eb23ae1a4db074b7ddc2e0c136d008fb5bc7 DIFF: https://github.com/llvm/llvm-project/commit/5b04eb23ae1a4db074b7ddc2e0c136d008fb5bc7.diff

[Lldb-commits] [PATCH] D127500: [lldb] [llgs] Make `k` kill all processes, and fix multiple exits

mgorny planned changes to this revision. mgorny added a comment. This is now pending rebase due to the nonstop patch landing. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127500/new/ https://reviews.llvm.org/D127500 ___ lldb-commits mailing

[Lldb-commits] [PATCH] D125575: [lldb] [llgs] Implement non-stop style stop notification packets

This revision was automatically updated to reflect the committed changes. Closed by commit rGbc04d240850b: [lldb] [llgs] Implement non-stop style stop notification packets (authored by mgorny). Herald added a project: LLDB. Changed prior to commit:

[Lldb-commits] [lldb] bc04d24 - [lldb] [llgs] Implement non-stop style stop notification packets

Author: Michał Górny Date: 2022-06-21T19:04:20+02:00 New Revision: bc04d240850bab340341eaf3601c5ca996667319 URL: https://github.com/llvm/llvm-project/commit/bc04d240850bab340341eaf3601c5ca996667319 DIFF: https://github.com/llvm/llvm-project/commit/bc04d240850bab340341eaf3601c5ca996667319.diff

[Lldb-commits] [PATCH] D128069: [lldb] add SBSection.alignment to python bindings

dmlary added a comment. Sent this via email, but doesn't look like it showed up here: > I'm less concerned about the getter and the property and more about the > underlying functionality. It doesn't look like it's being tested, and adding > it to the SB API allows to change that. Just to

[Lldb-commits] [PATCH] D127436: [lldb] Resolve exe location for `target create`

alvinhochun updated this revision to Diff 438737. alvinhochun added a comment. Added Windows-specific test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127436/new/ https://reviews.llvm.org/D127436 Files:

[Lldb-commits] [PATCH] D127234: [lldb] Add setting to override PE/COFF ABI by module name

alvinhochun updated this revision to Diff 438734. alvinhochun added a comment. Added test and improved setting description as suggested. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127234/new/ https://reviews.llvm.org/D127234 Files:

[Lldb-commits] [PATCH] D128268: [lldb] Fix reading i686-windows executables with GNU environment

mstorsjo updated this revision to Diff 438733. mstorsjo added a comment. Added a comment to the testcase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128268/new/ https://reviews.llvm.org/D128268 Files: lldb/source/Utility/ArchSpec.cpp

[Lldb-commits] [PATCH] D127193: [lldb] [llgs] Fix signo sent with fork/vfork/vforkdone events

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. cool CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127193/new/ https://reviews.llvm.org/D127193 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D128152: [lldb] [llgs] Support multiprocess in qfThreadInfo

labath accepted this revision. labath added inline comments. This revision is now accepted and ready to land. Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp:1967 + + if (multiprocess) { +for (auto _ptr : m_debugged_processes)

[Lldb-commits] [PATCH] D127667: [lldb] [llgs] Implement the vKill packet

mgorny updated this revision to Diff 438706. mgorny added a comment. Rebase and update for changes in D127500 . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127667/new/ https://reviews.llvm.org/D127667 Files:

[Lldb-commits] [lldb] 1004d6e - [lldb] Skip Recognizer/assert.test on linux

Author: Pavel Labath Date: 2022-06-21T16:51:02+02:00 New Revision: 1004d6e7e2eb24edc01d7e330c538ce5cb590001 URL: https://github.com/llvm/llvm-project/commit/1004d6e7e2eb24edc01d7e330c538ce5cb590001 DIFF: https://github.com/llvm/llvm-project/commit/1004d6e7e2eb24edc01d7e330c538ce5cb590001.diff

[Lldb-commits] [PATCH] D128268: [lldb] Fix reading i686-windows executables with GNU environment

DavidSpickett added a comment. > Now since the addition of the new setting in > 25c8a061c5739677d2fc0af29a8cc9520207b923 > , > ObjectFile::GetModuleSpecifications can return i386-pc-windows-gnu and > i686-pc-windows-gnu,

[Lldb-commits] [PATCH] D128268: [lldb] Fix reading i686-windows executables with GNU environment

mstorsjo added a comment. In D128268#3598967 , @DavidSpickett wrote: >> However, after this commit, if the object file is advertised with the >> different environment (either when built in a mingw environment, or if that >> setting is set), the fat

[Lldb-commits] [PATCH] D125575: [lldb] [llgs] Implement non-stop style stop notification packets

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Ok, looks good. Some extra suggestions inline. Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp:490 +

[Lldb-commits] [PATCH] D128268: [lldb] Fix reading i686-windows executables with GNU environment

alvinhochun added a comment. Yes, this looks right to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128268/new/ https://reviews.llvm.org/D128268 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D128268: [lldb] Fix reading i686-windows executables with GNU environment

DavidSpickett added a comment. > However, after this commit, if the object file is advertised with the > different environment (either when built in a mingw environment, or if that > setting is set), the fat binary validation won't accept the file any longer. Is "this commit" referring to

[Lldb-commits] [PATCH] D125509: [LLDB][NFC] Decouple dwarf location table from DWARFExpression.

labath added a comment. In D125509#3586928 , @zequanwu wrote: >> The main thing I am wondering is if it wouldn't be better to (instead of >> essentially duplicating the DWARFExpression interface in the >> DWARFExpressionList class) somehow split the

[Lldb-commits] [PATCH] D128268: [lldb] Fix reading i686-windows executables with GNU environment

mstorsjo created this revision. mstorsjo added reviewers: labath, DavidSpickett, omjavaid, alvinhochun. Herald added a project: All. mstorsjo requested review of this revision. Herald added a project: LLDB. 25c8a061c5739677d2fc0af29a8cc9520207b923

[Lldb-commits] [PATCH] D128126: Support expressions in the context of a reference

This revision was automatically updated to reflect the committed changes. Closed by commit rG6a85b9d16387: Support expressions in the context of a reference (authored by emrekultursay, committed by labath). Changed prior to commit: https://reviews.llvm.org/D128126?vs=438454=438659#toc

[Lldb-commits] [lldb] 6a85b9d - Support expressions in the context of a reference

Author: Emre Kultursay Date: 2022-06-21T14:30:07+02:00 New Revision: 6a85b9d16387ddd7c356336c8a77ba6b88f9a610 URL: https://github.com/llvm/llvm-project/commit/6a85b9d16387ddd7c356336c8a77ba6b88f9a610 DIFF:

[Lldb-commits] [PATCH] D128264: [lldb/dyld-posix] Avoid reading the module list in inconsistent states

labath added a comment. (This was breaking several shared library tests, most notably TestLoadUnload) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128264/new/ https://reviews.llvm.org/D128264 ___

[Lldb-commits] [PATCH] D128264: [lldb/dyld-posix] Avoid reading the module list in inconsistent states

labath added a comment. Herald added a subscriber: JDevlieghere. @emrekultursay: Mainly added you in case you want to try this out on android. Comment at: lldb/source/Plugins/DynamicLoader/POSIX-DYLD/DynamicLoaderPOSIXDYLD.cpp:425 // and all DT_NEEDED entries on *BSD.

[Lldb-commits] [PATCH] D128264: [lldb/dyld-posix] Avoid reading the module list in inconsistent states

labath created this revision. labath added reviewers: mgorny, emrekultursay. Herald added a project: All. labath requested review of this revision. Herald added a project: LLDB. New glibc versions (since 2.34 or including this

[Lldb-commits] [PATCH] D127500: [lldb] [llgs] Make `k` kill all processes, and fix multiple exits

mgorny updated this revision to Diff 438643. mgorny added a comment. Updated to delay removing the process (and therefore stopping lldb-server) until the last process exits. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127500/new/ https://reviews.llvm.org/D127500 Files:

[Lldb-commits] [PATCH] D128253: [lldb] [MainLoop] Support "pending callbacks", to be called once

mgorny created this revision. mgorny added reviewers: labath, krytarowski, emaste, jingham. Herald added a subscriber: arichardson. Herald added a project: All. mgorny requested review of this revision. Support adding a "pending callback" to the main loop, that will be called once after all the

[Lldb-commits] [PATCH] D128221: [LLDB] Add Arm64 CodeView to LLDB regnum mapping

DavidSpickett added a reviewer: DavidSpickett. DavidSpickett added a comment. Are there public docs for these numbers? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128221/new/ https://reviews.llvm.org/D128221 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D128226: [lldb] Remove an outdated comment. NFC.

DavidSpickett accepted this revision. DavidSpickett added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128226/new/ https://reviews.llvm.org/D128226

[Lldb-commits] [PATCH] D128201: [lldb][windows] Fix crash on getting nested exception

DavidSpickett accepted this revision. DavidSpickett added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128201/new/ https://reviews.llvm.org/D128201

[Lldb-commits] [PATCH] D127234: [lldb] Add setting to override PE/COFF ABI by module name

DavidSpickett added inline comments. Comment at: lldb/source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFFProperties.td:13 +EnumValues<"OptionEnumValues(g_abi_enums)">, +Desc<"A mapping of ABI override to use for specific modules. The module name is matched by its file

[Lldb-commits] [lldb] ed8fcea - Don't use Optional::getValue (NFC)

Author: Kazu Hirata Date: 2022-06-20T23:35:53-07:00 New Revision: ed8fceaa09cd66324c6efc1070f962731a62e2dc URL: https://github.com/llvm/llvm-project/commit/ed8fceaa09cd66324c6efc1070f962731a62e2dc DIFF: https://github.com/llvm/llvm-project/commit/ed8fceaa09cd66324c6efc1070f962731a62e2dc.diff