[Lldb-commits] [lldb] bd3976f - [lldb] Refactor Symbols::DownloadObjectAndSymbolFile

Author: Jonas Devlieghere Date: 2022-08-08T20:14:07-07:00 New Revision: bd3976fed470343be8df9caf0e35d290455b700c URL: https://github.com/llvm/llvm-project/commit/bd3976fed470343be8df9caf0e35d290455b700c DIFF:

[Lldb-commits] [PATCH] D131303: [lldb] Refactor Symbols::DownloadObjectAndSymbolFile

This revision was automatically updated to reflect the committed changes. Closed by commit rGbd3976fed470: [lldb] Refactor Symbols::DownloadObjectAndSymbolFile (authored by JDevlieghere). Herald added a project: LLDB. Changed prior to commit:

[Lldb-commits] [PATCH] D131460: [LLDB] Remove undefined behavior in TestConstStaticIntegralMember.py

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG1438639a2f7e: [LLDB] Remove undefined behavior in TestConstStaticIntegralMember.py (authored by shafik). Herald added a

[Lldb-commits] [lldb] 1438639 - [LLDB] Remove undefined behavior in TestConstStaticIntegralMember.py

Author: Shafik Yaghmour Date: 2022-08-08T19:23:53-07:00 New Revision: 1438639a2f7eb9e9cba01454d3a9b1b16d179c9a URL: https://github.com/llvm/llvm-project/commit/1438639a2f7eb9e9cba01454d3a9b1b16d179c9a DIFF:

[Lldb-commits] [PATCH] D131460: [LLDB] Remove undefined behavior in TestConstStaticIntegralMember.py

shafik added a comment. I will probably land this soon since this is being reported by several built bots and I this should bring the builds back to green. I just wanted the interested parties to see this in case there is some functionality this is testing that I am missing and some additions

[Lldb-commits] [PATCH] D131460: [LLDB] Remove undefined behavior in TestConstStaticIntegralMember.py

shafik created this revision. shafik added reviewers: JDevlieghere, werat, aaron.ballman. Herald added a project: All. shafik requested review of this revision. Setting an enum without a fixed underlying type to a value which is outside the value range is undefined behavior. The initializer

[Lldb-commits] [PATCH] D131459: Move FormattersMatchCandidate flags to a struct.

jgorbe created this revision. Herald added a project: All. jgorbe requested review of this revision. Herald added a project: LLDB. Move FormattersMatchCandidate flags to a struct. This removes some error-prone repetition in FormatManager::GetPossibleMatches, where the same three boolean flags

[Lldb-commits] [PATCH] D131085: [lldb/crashlog] Refactor the CrashLogParser logic

mib marked 2 inline comments as done. mib added inline comments. Comment at: lldb/examples/python/crashlog.py:434 except CrashLogFormatException: -return TextCrashLogParser(debugger, path, verbose).parse() +return

[Lldb-commits] [PATCH] D131333: [lldb] abi_tag support 2/3 - Make FindBestAlternateFunctionMangledName local to the C++ language plugin

JDevlieghere added inline comments. Comment at: lldb/include/lldb/Target/Language.h:317 + /// function names. + /// + /// \param[in] mangled_names List of mangled names to generate I was wondering the same. I think it's worth the churn.

[Lldb-commits] [PATCH] D131085: [lldb/crashlog] Refactor the CrashLogParser logic

JDevlieghere added inline comments. Comment at: lldb/examples/python/crashlog.py:434 except CrashLogFormatException: -return TextCrashLogParser(debugger, path, verbose).parse() +return object().__new__(TextCrashLogParser) mib

[Lldb-commits] [PATCH] D131036: [lldb/crashlog] Add `-s|--skip-status` option to interactive mode

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131036/new/ https://reviews.llvm.org/D131036

[Lldb-commits] [PATCH] D131085: [lldb/crashlog] Refactor the CrashLogParser logic

mib marked 3 inline comments as done. mib added inline comments. Comment at: lldb/examples/python/crashlog.py:434 except CrashLogFormatException: -return TextCrashLogParser(debugger, path, verbose).parse() +return

[Lldb-commits] [PATCH] D131212: Allow host platform to use sdk sysroot directory option when resolving shared modules

trevorj added a comment. > It does not. You _can_ connect to a remote server if you want to, but you > don't have to. Many workflows need to select a remote platform to let LLDB > know how to locate files when doing symbolication and when loading core > files, so you should just be able to use

[Lldb-commits] [PATCH] D131328: [lldb] Support fetching symbols with dsymForUUID in the background

JDevlieghere updated this revision to Diff 450999. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131328/new/ https://reviews.llvm.org/D131328 Files: lldb/include/lldb/Core/Debugger.h lldb/include/lldb/Core/DebuggerEvents.h lldb/include/lldb/Core/ModuleList.h

[Lldb-commits] [PATCH] D131328: [lldb] Support fetching symbols with dsymForUUID in the background

JDevlieghere added a comment. In D131328#3706814 , @labath wrote: > In D131328#3706749 , @JDevlieghere > wrote: > >> There was another approach I considered initially which might alleviate some >> of the issues

[Lldb-commits] [PATCH] D131333: [lldb] abi_tag support 2/3 - Make FindBestAlternateFunctionMangledName local to the C++ language plugin

Michael137 added inline comments. Herald added a subscriber: JDevlieghere. Comment at: lldb/include/lldb/Target/Language.h:315 + /// + /// \param[out] results Will contain alternative mangled + /// function names. aprantl wrote: > Why not

[Lldb-commits] [PATCH] D131328: [lldb] Support fetching symbols with dsymForUUID in the background

JDevlieghere updated this revision to Diff 450993. JDevlieghere added a comment. - Use a debugger event to execute the notification of the targets on the event handler thread CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131328/new/ https://reviews.llvm.org/D131328 Files:

[Lldb-commits] [PATCH] D131333: [lldb] abi_tag support 2/3 - Make FindBestAlternateFunctionMangledName local to the C++ language plugin

Michael137 created this revision. Michael137 added a reviewer: aprantl. Herald added a project: All. Michael137 updated this revision to Diff 450757. Michael137 added a comment. Michael137 updated this revision to Diff 450991. Michael137 retitled this revision from "[lldb] abi_tag support 2/4 -

[Lldb-commits] [PATCH] D131335: WIP: [lldb] abi_tag support 4/4 - Use mangle tree API to determine approximate mangle matches

Michael137 updated this revision to Diff 450992. Michael137 added a comment. Herald added a subscriber: JDevlieghere. - Reword commit message - Replace `SymbolNameFitsToLanguage` check Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131335/new/

[Lldb-commits] [PATCH] D131332: [lldb][unittests] Add more test cases to CPlusPlusNameParser unit-tests

aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. More tests are always welcome! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131332/new/ https://reviews.llvm.org/D131332

[Lldb-commits] [PATCH] D131335: WIP: [lldb] abi_tag support 4/4 - Use mangle tree API to determine approximate mangle matches

Michael137 created this revision. Michael137 added a reviewer: aprantl. Herald added a project: All. Michael137 added a reviewer: jingham. Michael137 edited the summary of this revision. Michael137 updated this revision to Diff 450751. Michael137 added a comment. Michael137 added a reviewer:

[Lldb-commits] [PATCH] D130401: Implement better path matching in FileSpecList::FindCompatibleIndex(...).

This revision was automatically updated to reflect the committed changes. Closed by commit rGc0124084537b: Implement better path matching in FileSpecList::FindCompatibleIndex(...). (authored by clayborg). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] c012408 - Implement better path matching in FileSpecList::FindCompatibleIndex(...).

Author: Greg Clayton Date: 2022-08-08T15:20:38-07:00 New Revision: c0124084537bad33180d2e675475baf1a4b79afe URL: https://github.com/llvm/llvm-project/commit/c0124084537bad33180d2e675475baf1a4b79afe DIFF: https://github.com/llvm/llvm-project/commit/c0124084537bad33180d2e675475baf1a4b79afe.diff

[Lldb-commits] [PATCH] D131085: [lldb/crashlog] Refactor the CrashLogParser logic

kastiglione added inline comments. Comment at: lldb/examples/python/crashlog.py:447 +class JSONCrashLogParser(CrashLogParser): +def __new__(cls, debugger, path, verbose): +with open(path, 'r') as f: can this be an `__init__`? CHANGES SINCE LAST

[Lldb-commits] [PATCH] D131085: [lldb/crashlog] Refactor the CrashLogParser logic

kastiglione added inline comments. Comment at: lldb/examples/python/crashlog.py:422-425 +# When `__new__` is overriden, if the returned type is the same +# as the class type, or related to it, the `__init__` method is +# automatically called after

[Lldb-commits] [PATCH] D131212: Allow host platform to use sdk sysroot directory option when resolving shared modules

clayborg added a comment. In D131212#3708142 , @trevorj wrote: > @clayborg The problem with the second variation is it doesn't prefix the > path, it just looks for shared objects of the same basename in the folders > you specify. Yes, that is correct

[Lldb-commits] [PATCH] D131212: Allow host platform to use sdk sysroot directory option when resolving shared modules

trevorj added a comment. @clayborg The problem with the second variation is it doesn't prefix the path, it just looks for shared objects of the same basename in the folders you specify. I thought that remote-linux requires a server? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[Lldb-commits] [PATCH] D130689: [LLVM] Update C++ standard to 17

mstorsjo added a comment. In D130689#3700094 , @thakis wrote: > In D130689#3696186 , @thieta wrote: > >> @nikic @thakis I fixed this issue in https://reviews.llvm.org/D131063 and it >> can be built with

[Lldb-commits] [PATCH] D131081: [lldb] Prevent race condition when fetching /proc/cpuinfo

clayborg added a comment. In D131081#3707956 , @wallace wrote: > That's important to know. At least in this case this code only runs on Linux, > so hopefully we are good with the atomic static initialization. Good point! Should be good to go

[Lldb-commits] [PATCH] D131212: Allow host platform to use sdk sysroot directory option when resolving shared modules

clayborg added a comment. What Pavel said should work (there is always a "remote-" name for everything like "remote-linux" even if you are on linux to start with. The host platform assumes that everything comes from the current host. That being said we also have a few ways to make this work

[Lldb-commits] [PATCH] D131081: [lldb] Prevent race condition when fetching /proc/cpuinfo

wallace added a comment. That's important to know. At least in this case this code only runs on Linux, so hopefully we are good with the atomic static initialization. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131081/new/

[Lldb-commits] [PATCH] D131081: [lldb] Prevent race condition when fetching /proc/cpuinfo

clayborg added a comment. In D131081#3699295 , @labath wrote: > It's not clear to me why you're insisting on `call_once`, when c++ guarantees > that the function-local statics will only be initialized once (atomically). > And with the new version, we

[Lldb-commits] [PATCH] D131437: Don't index the skeleton CU when we have a fission compile unit.

clayborg created this revision. clayborg added reviewers: labath, JDevlieghere. Herald added a subscriber: arphaman. Herald added a project: All. clayborg requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. When fission is enabled, we were

[Lldb-commits] [PATCH] D131159: [lldb] Use WSAEventSelect for MainLoop polling on windows

mstorsjo added a subscriber: alvinhochun. mstorsjo added a comment. I don't really have experience with this API - is this pattern (creating and closing event objects for each poll run) the common way of using this API? Is there any potential performance risk compared with keeping event objects

[Lldb-commits] [PATCH] D131081: [lldb] Prevent race condition when fetching /proc/cpuinfo

This revision was automatically updated to reflect the committed changes. Closed by commit rGddd576ab87a1: [lldb] Prevent race condition when fetching /proc/cpuinfo (authored by Walter Erquinigo wall...@fb.com). Changed prior to commit: https://reviews.llvm.org/D131081?vs=450226=450905#toc

[Lldb-commits] [lldb] ddd576a - [lldb] Prevent race condition when fetching /proc/cpuinfo

Author: Walter Erquinigo Date: 2022-08-08T12:31:42-07:00 New Revision: ddd576ab87a16eb7fb06531da8040ac2ece0c9a3 URL: https://github.com/llvm/llvm-project/commit/ddd576ab87a16eb7fb06531da8040ac2ece0c9a3 DIFF:

[Lldb-commits] [PATCH] D130689: [LLVM] Update C++ standard to 17

mehdi_amini added a comment. > There should be a better way than this. Comprehensive pre-merge testing of > all PRs etc. We already have pre-commit tests on Phabricator on Windows and Linux, but that's not exhaustive and for many reasons I don't believe this is realistic in any way: we will

[Lldb-commits] [PATCH] D131422: [lldb] Remove include/lldb/lldb-private.h

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGcdeb50c32155: [lldb] Remove include/lldb/lldb-private.h (authored by MaskRay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] cdeb50c - [lldb] Remove include/lldb/lldb-private.h

Author: Fangrui Song Date: 2022-08-08T12:03:53-07:00 New Revision: cdeb50c3215593bffe9e5a46bdc9a9e34fd93dcc URL: https://github.com/llvm/llvm-project/commit/cdeb50c3215593bffe9e5a46bdc9a9e34fd93dcc DIFF: https://github.com/llvm/llvm-project/commit/cdeb50c3215593bffe9e5a46bdc9a9e34fd93dcc.diff

[Lldb-commits] [PATCH] D129611: [lldb/crashlog] Add '-t|--target' option to interactive mode

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM modulo the `# Return error` but that's addressed in a follow up patch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129611/new/ https://reviews.llvm.org/D129611

[Lldb-commits] [PATCH] D131032: [lldb/crashlog] Update frame regex matcher

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131032/new/ https://reviews.llvm.org/D131032 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D131422: [lldb] Remove include/lldb/lldb-private.h

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131422/new/ https://reviews.llvm.org/D131422

[Lldb-commits] [PATCH] D131422: [lldb] Remove include/lldb/lldb-private.h

MaskRay created this revision. MaskRay added reviewers: JDevlieghere, kastiglione. Herald added a subscriber: StephenFan. Herald added a project: All. MaskRay requested review of this revision. Herald added projects: clang, LLDB. Herald added subscribers: lldb-commits, cfe-commits. The header

[Lldb-commits] [PATCH] D130689: [LLVM] Update C++ standard to 17

Trass3r added a comment. In D130689#3707296 , @mehdi_amini wrote: > land the change, wait for a couple of hours to ensure that all bots have > picked up the revision, then revert There should be a better way than this. Comprehensive pre-merge testing

[Lldb-commits] [lldb] 59d2495 - [lldb] LLVM_FALLTHROUGH => [[fallthrough]]. NFC

Author: Fangrui Song Date: 2022-08-08T11:31:49-07:00 New Revision: 59d2495fe2c1254f84ad4d2bd61a41e79ff0d44d URL: https://github.com/llvm/llvm-project/commit/59d2495fe2c1254f84ad4d2bd61a41e79ff0d44d DIFF: https://github.com/llvm/llvm-project/commit/59d2495fe2c1254f84ad4d2bd61a41e79ff0d44d.diff

[Lldb-commits] [PATCH] D130689: [LLVM] Update C++ standard to 17

thakis added a comment. Re MSVC: For what it's worth, our Chromium windows bot (which builds trunk llvm and then chromium with that) is happy. It builds with MSVC 2019. Here's the build log (which includes cmake invocations):

[Lldb-commits] [PATCH] D131304: [lldb] Remove uses of six module (NFC)

JDevlieghere accepted this revision. JDevlieghere added a comment. 拾 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131304/new/ https://reviews.llvm.org/D131304 ___ lldb-commits mailing list

[Lldb-commits] [lldb] 5fff4b7 - [lldb] Pass TestExternCSymbols.py on Windows

Author: Alex Langford Date: 2022-08-08T11:01:16-07:00 New Revision: 5fff4b75ca0d72759f7ded4c96fc5493d917a3a9 URL: https://github.com/llvm/llvm-project/commit/5fff4b75ca0d72759f7ded4c96fc5493d917a3a9 DIFF: https://github.com/llvm/llvm-project/commit/5fff4b75ca0d72759f7ded4c96fc5493d917a3a9.diff

[Lldb-commits] [PATCH] D130689: [LLVM] Update C++ standard to 17

mehdi_amini added a comment. > Agreed, I think we need to update the protocol for changing the C++ standard > in the future to account for more testing beforehand. The way I would do it is: wait for a Sunday so that the bots aren't loaded, land the change, wait for a couple of hours to ensure

[Lldb-commits] [PATCH] D131294: [LLDB][NFC] Reliability fixes to TCPSocket code

fixathon added a comment. Commented on feedback. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131294/new/ https://reviews.llvm.org/D131294 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D131294: [LLDB][NFC] Reliability fixes to TCPSocket code

fixathon added a comment. In D131294#3707154 , @jingham wrote: > We don't use the constant first so you don't accidentally use "=" rather than > "==" convention anywhere else in lldb, so it looks weird here. Good feedback. I'll switch that around.

[Lldb-commits] [PATCH] D131294: [LLDB][NFC] Reliability fixes to TCPSocket code

jingham added a comment. We don't use the constant first so you don't accidentally use "=" rather than "==" convention anywhere else in lldb, so it looks weird here. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131294/new/

[Lldb-commits] [PATCH] D131244: [LLDB] Missing break in a switch statement alters the execution flow.

fixathon abandoned this revision. fixathon marked an inline comment as done. fixathon added a comment. closing as already patched. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131244/new/ https://reviews.llvm.org/D131244

[Lldb-commits] [PATCH] D131304: [lldb] Remove uses of six module (NFC)

kastiglione added inline comments. Comment at: lldb/bindings/python/CMakeLists.txt:63-68 - if(NOT LLDB_USE_SYSTEM_SIX) -add_custom_command(TARGET ${swig_target} POST_BUILD VERBATIM - COMMAND ${CMAKE_COMMAND} -E copy -

[Lldb-commits] [PATCH] D131304: [lldb] Remove uses of six module (NFC)

kastiglione updated this revision to Diff 450843. kastiglione added a comment. Herald added a subscriber: mgorny. remove LLDB_USE_SYSTEM_SIX Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131304/new/ https://reviews.llvm.org/D131304 Files:

[Lldb-commits] [PATCH] D131159: [lldb] Use WSAEventSelect for MainLoop polling on windows

mgorny accepted this revision. mgorny added a comment. Thanks for doing this. The common and POSIX parts LGTM. Just one minor suggestion since you've touched that line. Comment at: lldb/source/Host/posix/MainLoopPosix.cpp:124 assert(ret == 0); - (void) ret; + (void)ret;

[Lldb-commits] [PATCH] D131312: [LLDB][NFC] Fix suspicious bitwise expression in PrintBTEntry()

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. fixathon marked an inline comment as done. Closed by commit rG06ff46d2d77f: [LLDB][NFC] Fix suspicious bitwise expression in PrintBTEntry()

[Lldb-commits] [lldb] 06ff46d - [LLDB][NFC] Fix suspicious bitwise expression in PrintBTEntry()

Author: Slava Gurevich Date: 2022-08-08T09:04:22-07:00 New Revision: 06ff46d2d77feba285e672e2da42039c88dc965a URL: https://github.com/llvm/llvm-project/commit/06ff46d2d77feba285e672e2da42039c88dc965a DIFF:

[Lldb-commits] [PATCH] D131244: [LLDB] Missing break in a switch statement alters the execution flow.

fixathon marked an inline comment as done. fixathon added inline comments. Comment at: lldb/source/Plugins/Process/Utility/ARMUtils.h:49 shift_t = SRType_Invalid; return UINT32_MAX; } DavidSpickett wrote: > This is now dead code? This will execute for the

[Lldb-commits] [PATCH] D131328: [lldb] Support fetching symbols with dsymForUUID in the background

labath added a comment. In D131328#3706749 , @JDevlieghere wrote: > There was another approach I considered initially which might alleviate some > of the issues Pavel raised. Instead of using the global thread pool, that > plan consisted of a

[Lldb-commits] [PATCH] D131407: [lldb] Flush the global thread pool in Debugger::Terminate

JDevlieghere updated this revision to Diff 450827. JDevlieghere added a comment. - Create the thread pool before the plugin callback CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131407/new/ https://reviews.llvm.org/D131407 Files: lldb/source/Core/Debugger.cpp Index:

[Lldb-commits] [PATCH] D131407: [lldb] Flush the global thread pool in Debugger::Terminate

JDevlieghere created this revision. JDevlieghere added reviewers: labath, llunak. Herald added a project: All. JDevlieghere requested review of this revision. Use the Initialize/Terminate pattern for the global thread pool to make sure it gets flushed during teardown.

[Lldb-commits] [PATCH] D131159: [WIP][lldb] Use WSAEventSelect for MainLoop polling

labath updated this revision to Diff 450825. labath added a comment. Herald added a subscriber: krytarowski. non-wip version Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131159/new/ https://reviews.llvm.org/D131159 Files:

[Lldb-commits] [PATCH] D131328: [lldb] Support fetching symbols with dsymForUUID in the background

JDevlieghere added a comment. There was another approach I considered initially which might alleviate some of the issues Pavel raised. Instead of using the global thread pool, that plan consisted of a dedicated thread to fetch symbols in the background. That would allow us to add the symbol

[Lldb-commits] [PATCH] D131275: [lldb] Make Process and subclass constructors protected

This revision was automatically updated to reflect the committed changes. Closed by commit rG9b031d5e3a7b: [lldb] Make Process and subclass constructors protected (authored by mgorny). Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/D131275?vs=450332=450822#toc

[Lldb-commits] [lldb] 9b031d5 - [lldb] Make Process and subclass constructors protected

Author: Michał Górny Date: 2022-08-08T17:34:27+02:00 New Revision: 9b031d5e3a7b455308257a71116a603e76c8c679 URL: https://github.com/llvm/llvm-project/commit/9b031d5e3a7b455308257a71116a603e76c8c679 DIFF: https://github.com/llvm/llvm-project/commit/9b031d5e3a7b455308257a71116a603e76c8c679.diff

[Lldb-commits] [PATCH] D131328: [lldb] Support fetching symbols with dsymForUUID in the background

labath added a comment. In D131328#3706565 , @JDevlieghere wrote: > In D131328#3706202 , @labath wrote: > >> I see two problems with this patch. >> >> - it makes shutting down lldb safely impossible (because you

[Lldb-commits] [PATCH] D131328: [lldb] Support fetching symbols with dsymForUUID in the background

JDevlieghere added a comment. In D131328#3706202 , @labath wrote: > I see two problems with this patch. > > - it makes shutting down lldb safely impossible (because you never know if > there are any unfinished tasks running). We already have problems

[Lldb-commits] [PATCH] D130689: [LLVM] Update C++ standard to 17

thieta added a comment. In D130689#3706424 , @aaron.ballman wrote: > +1, thank you for thinking about how we can improve this process in the > future! Given that C++17 adoption across compilers has been far better than > C++20, I suspect the next time

[Lldb-commits] [PATCH] D130689: [LLVM] Update C++ standard to 17

aaron.ballman added a comment. In D130689#3706377 , @thieta wrote: > In D130689#3706336 , @aaron.ballman > wrote: > >> That's the only reason this hasn't been reverted already. Landing sweeping >> changes on a

[Lldb-commits] [PATCH] D131275: [lldb] Make Process and subclass constructors protected

mgorny added inline comments. Comment at: lldb/include/lldb/Target/Process.h:478-487 +protected: /// Construct with a shared pointer to a target, and the Process listener. /// Uses the Host UnixSignalsSP by default. Process(lldb::TargetSP target_sp, lldb::ListenerSP

[Lldb-commits] [PATCH] D130689: [LLVM] Update C++ standard to 17

thieta added a comment. In D130689#3706336 , @aaron.ballman wrote: > That's the only reason this hasn't been reverted already. Landing sweeping > changes on a weekend is a good way to reduce the pain, but we really need to > be sure someone watches

[Lldb-commits] [PATCH] D131275: [lldb] Make Process and subclass constructors protected

labath accepted this revision. labath added inline comments. This revision is now accepted and ready to land. Comment at: lldb/include/lldb/Target/Process.h:478-487 +protected: /// Construct with a shared pointer to a target, and the Process listener. /// Uses the Host

[Lldb-commits] [PATCH] D131312: [LLDB][NFC] Fix suspicious bitwise expression in PrintBTEntry()

DavidSpickett added inline comments. Comment at: lldb/tools/intel-features/intel-mpx/cli-wrapper-mpxtable.cpp:66 - if ((lbound == one_cmpl64 || one_cmpl32) && ubound == 0) { result.Printf("Null bounds on map: pointer value = 0x%" PRIu64 "\n", value);

[Lldb-commits] [PATCH] D131312: [LLDB][NFC] Fix suspicious bitwise expression in PrintBTEntry()

DavidSpickett added inline comments. Comment at: lldb/tools/intel-features/intel-mpx/cli-wrapper-mpxtable.cpp:66 - if ((lbound == one_cmpl64 || one_cmpl32) && ubound == 0) { result.Printf("Null bounds on map: pointer value = 0x%" PRIu64 "\n", value);

[Lldb-commits] [PATCH] D130689: [LLVM] Update C++ standard to 17

aaron.ballman added a comment. In D130689#3706303 , @thieta wrote: > In D130689#3706263 , @aaron.ballman > wrote: > >> > > > >> Something odd is going on here and we might want to consider a revert of >> this

[Lldb-commits] [PATCH] D130689: [LLVM] Update C++ standard to 17

jhenderson added a comment. FWIW, I've got a Visual Studio configuration (admittedly using a direct Visual Studio generator, not ninja), and I don't have any issues - C++17 is being used. However, I currently only have LLD as an additional project enabled, and don't build compiler-rt.

[Lldb-commits] [PATCH] D131160: [WIP][lldb] Add "event" capability to the MainLoop class

labath added a comment. In D131160#3701839 , @mgorny wrote: > To be honest, I'm not sure if "event" is the best name for it. I get it's a > WSA name but it's a bit non-obvious to outsiders (I mean, technically > everything is an event). Not that I have

[Lldb-commits] [PATCH] D131312: [LLDB][NFC] Fix suspicious bitwise expression in PrintBTEntry()

hawkinsw added inline comments. Comment at: lldb/tools/intel-features/intel-mpx/cli-wrapper-mpxtable.cpp:66 - if ((lbound == one_cmpl64 || one_cmpl32) && ubound == 0) { result.Printf("Null bounds on map: pointer value = 0x%" PRIu64 "\n", value);

[Lldb-commits] [PATCH] D130689: [LLVM] Update C++ standard to 17

thieta added a comment. In D130689#3706263 , @aaron.ballman wrote: > > Something odd is going on here and we might want to consider a revert of this > patch until we resolve it. When I do a git pull and cmake files change, > Visual Studio's

[Lldb-commits] [PATCH] D130689: [LLVM] Update C++ standard to 17

aaron.ballman added a comment. In D130689#3706276 , @barannikov88 wrote: > In D130689#3706263 , @aaron.ballman > wrote: > >> The failures I am getting are the same as what's shown by the sanitizer bot >> for

[Lldb-commits] [PATCH] D130689: [LLVM] Update C++ standard to 17

barannikov88 added a comment. In D130689#3706263 , @aaron.ballman wrote: > The failures I am getting are the same as what's shown by the sanitizer bot > for Windows: > https://lab.llvm.org/buildbot/#/builders/127/builds/33980/steps/4/logs/stdio >

[Lldb-commits] [PATCH] D130689: [LLVM] Update C++ standard to 17

aaron.ballman added a comment. In D130689#3706200 , @thieta wrote: > In D130689#3706199 , @cor3ntin > wrote: > >> Trying to read the logs,, notably >>

[Lldb-commits] [PATCH] D131159: [WIP][lldb] Use WSAEventSelect for MainLoop polling

labath added a comment. In D131159#3699826 , @jingham wrote: > This is a WIP, presumably in the final version there won't be prominent > #ifdef _WIN32 in a file in the "Host/common" directory. Yeah, that's the main reason for the WIPness. I still have

[Lldb-commits] [PATCH] D131212: Allow host platform to use sdk sysroot directory option when resolving shared modules

labath added a comment. > In LLDB, I assume I should do something like `platform select host -S > /path/to/sysroot` I /think/ you're expected to do `platform select remote-whatever -S /path/to/sysroot` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D131081: [lldb] Prevent race condition when fetching /proc/cpuinfo

labath accepted this revision. labath added inline comments. This revision is now accepted and ready to land. Comment at: lldb/source/Plugins/Process/Linux/Procfs.cpp:27-29 + return ArrayRef( + reinterpret_cast(buffer.getBufferStart()), +

[Lldb-commits] [PATCH] D130796: [LLDB][NativePDB] Switch to use DWARFLocationList.

labath accepted this revision. labath added inline comments. This revision is now accepted and ready to land. Comment at: lldb/include/lldb/Utility/RangeMap.h:54 +base += s; +size -= size > s ? s : size; + } `std::min(s, size)`? Repository: rG LLVM

[Lldb-commits] [PATCH] D131328: [lldb] Support fetching symbols with dsymForUUID in the background

labath added a comment. I see two problems with this patch. - it makes shutting down lldb safely impossible (because you never know if there are any unfinished tasks running). We already have problems with shutting down (grep for "intentionally leaked"), but this is guaranteed to make the

[Lldb-commits] [PATCH] D130689: [LLVM] Update C++ standard to 17

thieta added a comment. In D130689#3706199 , @cor3ntin wrote: > Trying to read the logs,, notably > `C:\PROGRA~2\MIB055~1\2019\PROFES~1\VC\Tools\MSVC\1429~1.301\bin\Hostx64\x64\cl.exe > `, it would seem that this particular bot is running a version

[Lldb-commits] [PATCH] D130689: [LLVM] Update C++ standard to 17

cor3ntin added a comment. In D130689#3706135 , @aaron.ballman wrote: > In D130689#3705131 , @royjacobson > wrote: > >> This seems to have been more disruptive than expected, since an existing >> CMakeCache.txt

[Lldb-commits] [PATCH] D130689: [LLVM] Update C++ standard to 17

aaron.ballman added a comment. In D130689#3705131 , @royjacobson wrote: > This seems to have been more disruptive than expected, since an existing > CMakeCache.txt can make LLVM compile in previous C++14 configuration. This > seems to make some of the

[Lldb-commits] [PATCH] D131332: [lldb][unittests] Add more test cases to CPlusPlusNameParser unit-tests

Michael137 updated this revision to Diff 450756. Michael137 added a comment. - Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131332/new/ https://reviews.llvm.org/D131332 Files: lldb/unittests/Language/CPlusPlus/CPlusPlusLanguageTest.cpp

[Lldb-commits] [PATCH] D131312: [LLDB][NFC] Fix suspicious bitwise expression in PrintBTEntry()

DavidSpickett added a comment. The original change was https://reviews.llvm.org/D29078. Are you able to run the tests with this applied? Comment at: lldb/tools/intel-features/intel-mpx/cli-wrapper-mpxtable.cpp:66 - if ((lbound == one_cmpl64 || one_cmpl32) && ubound == 0) {

[Lldb-commits] [PATCH] D131244: [LLDB] Missing break in a switch statement alters the execution flow.

DavidSpickett added inline comments. Comment at: lldb/source/Plugins/Process/Utility/ARMUtils.h:49 shift_t = SRType_Invalid; return UINT32_MAX; } This is now dead code? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D131304: [lldb] Remove uses of six module (NFC)

DavidSpickett added a comment. There is also a cmake var `LLDB_USE_SYSTEM_SIX` which can be removed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131304/new/ https://reviews.llvm.org/D131304 ___

[Lldb-commits] [PATCH] D130689: [LLVM] Update C++ standard to 17

thieta added a comment. In D130689#3705579 , @Jake-Egan wrote: > There is a failure on the AIX bot also: > ... > https://lab.llvm.org/buildbot/#/builders/214/builds/2707/steps/5/logs/stdio Filed an issue here:

[Lldb-commits] [PATCH] D130689: [LLVM] Update C++ standard to 17

thieta added a comment. In D130689#3705474 , @dyung wrote: > We are seeing an additional failure on an internal linux bot due to the > change to using C++17 by default when using GNU ld: > ... > Switching between BFD ld and gold still fails (although