[Lldb-commits] [PATCH] D154542: Further refinements on reporting interruption in lldb

jingham added inline comments. Comment at: lldb/include/lldb/Core/Debugger.h:455-456 +InterruptionReport(std::string function_name, std::string description) : +m_function_name(function_name), +m_description(description), +

[Lldb-commits] [PATCH] D154542: Further refinements on reporting interruption in lldb

jingham updated this revision to Diff 537551. jingham added a comment. Protect InterruptRequested from null function & format strings. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154542/new/ https://reviews.llvm.org/D154542 Files:

[Lldb-commits] [PATCH] D154542: Further refinements on reporting interruption in lldb

jingham added inline comments. Comment at: lldb/include/lldb/Core/Debugger.h:430-431 + template + bool InterruptRequested(const char *cur_func, + const char *formatv, Args &&... args) { +bool ret_val = InterruptRequested();

[Lldb-commits] [PATCH] D154386: [lldb][NFCI] Remove use of ConstString from OptionValue

jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154386/new/ https://reviews.llvm.org/D154386

[Lldb-commits] [PATCH] D154542: Further refinements on reporting interruption in lldb

jingham updated this revision to Diff 537544. jingham added a comment. Address review comments: Made the in_process target list shared pointers. Removed sstream includes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154542/new/

[Lldb-commits] [PATCH] D154030: [lldb-vscode] Creating a new flag for adjusting the behavior of evaluation repl expressions to allow users to more easily invoke lldb commands.

ashgti updated this revision to Diff 537538. ashgti added a comment. Removing a log statement that is not needed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154030/new/ https://reviews.llvm.org/D154030 Files:

[Lldb-commits] [PATCH] D154030: [lldb-vscode] Creating a new flag for adjusting the behavior of evaluation repl expressions to allow users to more easily invoke lldb commands.

ashgti updated this revision to Diff 537536. ashgti added a comment. Uploading latest diff Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154030/new/ https://reviews.llvm.org/D154030 Files: lldb/tools/lldb-vscode/JSONUtils.cpp

[Lldb-commits] [PATCH] D154542: Further refinements on reporting interruption in lldb

jingham added inline comments. Comment at: lldb/include/lldb/Core/Debugger.h:435-436 + ReportInterruption(InterruptionReport(cur_func, +llvm::formatv(formatv, +

[Lldb-commits] [PATCH] D154505: [lldb][NFC] Remove code duplication in InitOSO

fdeazeve updated this revision to Diff 537524. fdeazeve added a comment. Address review comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154505/new/ https://reviews.llvm.org/D154505 Files:

[Lldb-commits] [PATCH] D154534: [lldb][NFCI] Minor cleanups to StructuredData::GetObjectForDotSeparatedPath

bulbazord updated this revision to Diff 537523. bulbazord added a comment. Address feedback from @mib Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154534/new/ https://reviews.llvm.org/D154534 Files: lldb/source/Utility/StructuredData.cpp

[Lldb-commits] [PATCH] D154542: Further refinements on reporting interruption in lldb

mib added a comment. I had an offline chat with Jim and I misunderstood originally, what he was trying to achieve with the `InterruptionReport:: m_function_name` so my suggestion of using `LLVM_PRETTY_FUNCTION` doesn't actually work here. Repository: rG LLVM Github Monorepo CHANGES SINCE

[Lldb-commits] [PATCH] D154549: [lldb][NFCI] Remove use of Stream * from TypeSystem

bulbazord created this revision. bulbazord added reviewers: JDevlieghere, fdeazeve, kastiglione. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. We always assume these streams are valid, might as well

[Lldb-commits] [PATCH] D154542: Further refinements on reporting interruption in lldb

bulbazord added a comment. I really like the change to the interface, I especially like that it can report what was interrupted and how much work actually done. I had a lot of the same feedback as Ismail but also had some questions to help me understand all the details.

[Lldb-commits] [PATCH] D153489: [lldb] Print hint if object description is requested but not implemented

augusto2112 added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153489/new/ https://reviews.llvm.org/D153489 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D154030: [lldb-vscode] Creating a new flag for adjusting the behavior of evaluation repl expressions to allow users to more easily invoke lldb commands.

ashgti added inline comments. Comment at: lldb/tools/lldb-vscode/JSONUtils.h:239 +/// useful to ensure the same column provided by the setBreakpoints request +/// are returned to the IDE as a fallback. /// DavidSpickett wrote: > Appears that this got

[Lldb-commits] [PATCH] D154030: [lldb-vscode] Creating a new flag for adjusting the behavior of evaluation repl expressions to allow users to more easily invoke lldb commands.

ashgti updated this revision to Diff 537496. ashgti marked 4 inline comments as done. ashgti added a comment. Updating the behavior of auto mode to try to evalute local variables over lldb commands. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D154542: Further refinements on reporting interruption in lldb

mib added a comment. This looks very cool! I left "a few" comments on how I think we can simplify this patch, and also had some remarks regarding the `in_process_target` sanity checks. Comment at: lldb/include/lldb/Core/Debugger.h:435-436 +

[Lldb-commits] [PATCH] D154542: Further refinements on reporting interruption in lldb

jingham created this revision. jingham added reviewers: JDevlieghere, mib, bulbazord, labath. Herald added a project: All. jingham requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This patch enhances the interruption features I added a

[Lldb-commits] [PATCH] D154534: [lldb][NFCI] Minor cleanups to StructuredData::GetObjectForDotSeparatedPath

bulbazord added inline comments. Comment at: lldb/source/Utility/StructuredData.cpp:125 +if (match.second.empty()) return this->shared_from_this(); + mib wrote: > Good catch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D154534: [lldb][NFCI] Minor cleanups to StructuredData::GetObjectForDotSeparatedPath

mib accepted this revision. mib added a comment. LGTM with nits. Comment at: lldb/source/Utility/StructuredData.cpp:125 +if (match.second.empty()) return this->shared_from_this(); + Comment at:

[Lldb-commits] [PATCH] D153840: [LLDB] Fix buffer overflow problem in DWARFExpression::Evaluate.

dblaikie added a comment. In D153840#4474213 , @cmtice wrote: > Hi Jason, > > I had been talking more with David, and yes, I had come to the conclusion > that you are both right and that this was not the right fix. I am planning > on reverting this,

[Lldb-commits] [lldb] 58370ee - Revert "Change the dyld notification function that lldb puts a breakpoint in"

Author: Jason Molenda Date: 2023-07-05T12:52:21-07:00 New Revision: 58370eef673e80f3aea1bb431a291d1564e0f9f4 URL: https://github.com/llvm/llvm-project/commit/58370eef673e80f3aea1bb431a291d1564e0f9f4 DIFF: https://github.com/llvm/llvm-project/commit/58370eef673e80f3aea1bb431a291d1564e0f9f4.diff

[Lldb-commits] [PATCH] D154534: [lldb][NFCI] Minor cleanups to StructuredData::GetObjectForDotSeparatedPath

fdeazeve accepted this revision. fdeazeve added a comment. This revision is now accepted and ready to land. LGTM! Thanks for improving this Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154534/new/ https://reviews.llvm.org/D154534

[Lldb-commits] [PATCH] D154534: [lldb][NFCI] Minor cleanups to StructuredData::GetObjectForDotSeparatedPath

bulbazord updated this revision to Diff 537451. bulbazord added a comment. Remove unneeded `else` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154534/new/ https://reviews.llvm.org/D154534 Files: lldb/source/Utility/StructuredData.cpp Index:

[Lldb-commits] [PATCH] D154534: [lldb][NFCI] Minor cleanups to StructuredData::GetObjectForDotSeparatedPath

bulbazord added inline comments. Comment at: lldb/source/Utility/StructuredData.cpp:120 +return value->GetObjectForDotSeparatedPath(match.second); + } else if (GetType() == lldb::eStructuredDataTypeArray) { std::pair match = path.split('['); fdeazeve

[Lldb-commits] [PATCH] D154532: [lldb] Fix incorrect uses of formatv specifiers in LLDB_LOG

This revision was automatically updated to reflect the committed changes. Closed by commit rG520681e56d3a: [lldb] Fix incorrect uses of formatv specifiers in LLDB_LOG (authored by JDevlieghere). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D154530: [lldb] Fix incorrect uses of LLDB_LOG_ERROR

This revision was automatically updated to reflect the committed changes. Closed by commit rGe0e36e3725b5: [lldb] Fix incorrect uses of LLDB_LOG_ERROR (authored by JDevlieghere). Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/D154530?vs=537425=537447#toc

[Lldb-commits] [lldb] 520681e - [lldb] Fix incorrect uses of formatv specifiers in LLDB_LOG

Author: Jonas Devlieghere Date: 2023-07-05T11:27:52-07:00 New Revision: 520681e56d3ab9a9f187a1f9c805ff281b815d55 URL: https://github.com/llvm/llvm-project/commit/520681e56d3ab9a9f187a1f9c805ff281b815d55 DIFF:

[Lldb-commits] [lldb] e0e36e3 - [lldb] Fix incorrect uses of LLDB_LOG_ERROR

Author: Jonas Devlieghere Date: 2023-07-05T11:27:52-07:00 New Revision: e0e36e3725b50ac690d1839f0e9476e93ff7988d URL: https://github.com/llvm/llvm-project/commit/e0e36e3725b50ac690d1839f0e9476e93ff7988d DIFF:

[Lldb-commits] [PATCH] D154534: [lldb][NFCI] Minor cleanups to StructuredData::GetObjectForDotSeparatedPath

fdeazeve added inline comments. Comment at: lldb/source/Utility/StructuredData.cpp:120 +return value->GetObjectForDotSeparatedPath(match.second); + } else if (GetType() == lldb::eStructuredDataTypeArray) { std::pair match = path.split('['); Shouldn't

[Lldb-commits] [PATCH] D154532: [lldb] Fix incorrect uses of formatv specifiers in LLDB_LOG

bulbazord accepted this revision. bulbazord added a comment. This revision is now accepted and ready to land. I see you updated it while I typed it up. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154532/new/ https://reviews.llvm.org/D154532

[Lldb-commits] [PATCH] D154532: [lldb] Fix incorrect uses of formatv specifiers in LLDB_LOG

bulbazord requested changes to this revision. bulbazord added a comment. This revision now requires changes to proceed. The 2nd argument to `LLDB_LOG_ERROR` is the error itself, so these should be something like `LLDB_LOG_ERROR(GetLog(whatever), std::move(err), "message: {0}");` or something to

[Lldb-commits] [PATCH] D154532: [lldb] Fix incorrect uses of formatv specifiers in LLDB_LOG

fdeazeve accepted this revision. fdeazeve added a comment. This revision is now accepted and ready to land. Ah you updated the review as I typed the question! LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154532/new/ https://reviews.llvm.org/D154532

[Lldb-commits] [PATCH] D154532: [lldb] Fix incorrect uses of formatv specifiers in LLDB_LOG

fdeazeve added a comment. In https://reviews.llvm.org/D154532, the string argument comes after the error. Are these interchangeable? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154532/new/ https://reviews.llvm.org/D154532 ___ lldb-commits

[Lldb-commits] [PATCH] D154532: [lldb] Fix incorrect uses of formatv specifiers in LLDB_LOG

JDevlieghere updated this revision to Diff 537442. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154532/new/ https://reviews.llvm.org/D154532 Files: lldb/source/API/SBTarget.cpp lldb/source/Core/Debugger.cpp lldb/source/Core/ThreadedCommunication.cpp

[Lldb-commits] [PATCH] D154534: [lldb][NFCI] Minor cleanups to StructuredData::GetObjectForDotSeparatedPath

bulbazord created this revision. bulbazord added reviewers: JDevlieghere, mib, fdeazeve. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This accomplishes a few minor things: - Removed unnecessary

[Lldb-commits] [PATCH] D154530: [lldb] Fix incorrect uses of LLDB_LOG_ERROR

fdeazeve accepted this revision. fdeazeve added a comment. Nice catch! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154530/new/ https://reviews.llvm.org/D154530 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D154532: [lldb] Fix incorrect uses of formatv specifiers in LLDB_LOG

JDevlieghere updated this revision to Diff 537435. JDevlieghere edited the summary of this revision. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154532/new/ https://reviews.llvm.org/D154532 Files: lldb/source/API/SBTarget.cpp lldb/source/Core/Debugger.cpp

[Lldb-commits] [PATCH] D154532: [lldb] Fix incorrect uses of formatv specifiers in LLDB_LOG

JDevlieghere added a comment. In D154532#4474534 , @bulbazord wrote: > These uses of `LLDB_LOG` are taking errors, consuming them while turning them > into strings, and logging them. Unless I'm missing something, I think it > would make more sense to

[Lldb-commits] [PATCH] D154532: [lldb] Fix incorrect uses of formatv specifiers in LLDB_LOG

bulbazord added inline comments. Comment at: lldb/source/Core/Debugger.cpp:1918-1919 } else { - LLDB_LOG(GetLog(LLDBLog::Host), "failed to launch host thread: {}", + LLDB_LOG(GetLog(LLDBLog::Host), "failed to launch host thread: {0}",

[Lldb-commits] [PATCH] D154532: [lldb] Fix incorrect uses of formatv specifiers in LLDB_LOG

bulbazord added a comment. These uses of `LLDB_LOG` are taking errors, consuming them while turning them into strings, and logging them. Unless I'm missing something, I think it would make more sense to convert these to use `LLDB_LOG_ERROR`. Comment at:

[Lldb-commits] [PATCH] D154530: [lldb] Fix incorrect uses of LLDB_LOG_ERROR

bulbazord accepted this revision. bulbazord added a comment. This revision is now accepted and ready to land. I was actually looking at this today independently, guess you beat me to the punch  . LGTM modulo one comment. Comment at: lldb/source/Target/Target.cpp:2413-2414

[Lldb-commits] [PATCH] D154413: [lldb] Fix crash when completing register names after program exit

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154413/new/ https://reviews.llvm.org/D154413

[Lldb-commits] [PATCH] D154532: [lldb] Fix incorrect uses of formatv specifiers in LLDB_LOG

JDevlieghere created this revision. JDevlieghere added reviewers: bulbazord, fdeazeve, mib. Herald added a project: All. JDevlieghere requested review of this revision. Fix incorrect uses of formatv specifiers in LLDB_LOG. Unlike Python, arguments must be numbered.

[Lldb-commits] [PATCH] D154530: [lldb] Fix incorrect uses of LLDB_LOG_ERROR

JDevlieghere created this revision. JDevlieghere added reviewers: bulbazord, fdeazeve. Herald added a project: All. JDevlieghere requested review of this revision. Fix incorrect uses of LLDB_LOG_ERROR. The macro doesn't automatically inject the error in the log message: it merely passes the

[Lldb-commits] [PATCH] D154505: [lldb][NFC] Remove code duplication in InitOSO

fdeazeve added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARFDebugMap.cpp:347-348 + uint32_t sibling_idx = so_symbol->GetSiblingIndex(); + // The sibling index can't be less that or equal to the current index + // "i" + if

[Lldb-commits] [PATCH] D153840: [LLDB] Fix buffer overflow problem in DWARFExpression::Evaluate.

cmtice marked an inline comment as done. cmtice added a comment. Hi Jason, I had been talking more with David, and yes, I had come to the conclusion that you are both right and that this was not the right fix. I am planning on reverting this, but I am trying to figure out the right fix to

[Lldb-commits] [PATCH] D154505: [lldb][NFC] Remove code duplication in InitOSO

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. In D154505#4473986 , @bulbazord wrote: > I'm a big fan of refactoring deeply-nested code to be flatter, so I'm happy > to see this work

[Lldb-commits] [PATCH] D154387: [lldb][NFCI] Minor cleanup of default OptionValue::GetSubValue implementation

This revision was automatically updated to reflect the committed changes. Closed by commit rGfd5748cb5a45: [lldb][NFCI] Minor cleanup of default OptionValue::GetSubValue implementation (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] fd5748c - [lldb][NFCI] Minor cleanup of default OptionValue::GetSubValue implementation

Author: Alex Langford Date: 2023-07-05T09:00:59-07:00 New Revision: fd5748cb5a45c4178b84eb329bea9055f8ee485d URL: https://github.com/llvm/llvm-project/commit/fd5748cb5a45c4178b84eb329bea9055f8ee485d DIFF: https://github.com/llvm/llvm-project/commit/fd5748cb5a45c4178b84eb329bea9055f8ee485d.diff

[Lldb-commits] [PATCH] D153918: [lldb][NFCI] Deprecate SBValue::GetOpaqueType

This revision was automatically updated to reflect the committed changes. Closed by commit rG20f99278dbb8: [lldb][NFCI] Deprecate SBValue::GetOpaqueType (authored by bulbazord). Herald added a subscriber: wangpc. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] 20f9927 - [lldb][NFCI] Deprecate SBValue::GetOpaqueType

Author: Alex Langford Date: 2023-07-05T08:52:32-07:00 New Revision: 20f99278dbb81e880c23c65688e9752ce7ad019a URL: https://github.com/llvm/llvm-project/commit/20f99278dbb81e880c23c65688e9752ce7ad019a DIFF: https://github.com/llvm/llvm-project/commit/20f99278dbb81e880c23c65688e9752ce7ad019a.diff

[Lldb-commits] [PATCH] D153900: [lldb] Deprecate SBHostOS threading functionality

bulbazord added a comment. In D153900#4469649 , @mib wrote: > LGTM! @bulbazord when you land this, make sure to close @teemperor's diff > (D104231 ). Thanks!  Repository: rG LLVM Github Monorepo CHANGES SINCE

[Lldb-commits] [PATCH] D104231: [lldb] Deprecate the threading functionality in SBHostOS

bulbazord commandeered this revision. bulbazord added a reviewer: teemperor. bulbazord added a comment. Herald added a project: All. Commandeering this change in order to close it. I've effectively done this already with D153900 . CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D153900: [lldb] Deprecate SBHostOS threading functionality

This revision was automatically updated to reflect the committed changes. Closed by commit rG1c7c9970379e: [lldb] Deprecate SBHostOS threading functionality (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153900/new/

[Lldb-commits] [lldb] 1c7c997 - [lldb] Deprecate SBHostOS threading functionality

Author: Alex Langford Date: 2023-07-05T08:46:48-07:00 New Revision: 1c7c9970379e1949a0b338eba2746dbf84b0bda4 URL: https://github.com/llvm/llvm-project/commit/1c7c9970379e1949a0b338eba2746dbf84b0bda4 DIFF: https://github.com/llvm/llvm-project/commit/1c7c9970379e1949a0b338eba2746dbf84b0bda4.diff

[Lldb-commits] [PATCH] D154029: [lldb-vscode] Adding support for column break points.

wallace accepted this revision. wallace added a comment. This revision is now accepted and ready to land. Nice! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154029/new/ https://reviews.llvm.org/D154029

[Lldb-commits] [PATCH] D154505: [lldb][NFC] Remove code duplication in InitOSO

bulbazord added a comment. I'm a big fan of refactoring deeply-nested code to be flatter, so I'm happy to see this work being done! I wasn't aware of `llvm::concat` before, I probably would have used a lambda or something to do this, so it was interesting learning about that. 

[Lldb-commits] [PATCH] D154513: [lldb][NFC] Factor out code from SymbolFileDWARF::ParseVariableDIE

fdeazeve added inline comments. Herald added a subscriber: JDevlieghere. Comment at: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:3272 +/// Creates a DWARFExpressionList from an DW_AT_location form_value. +static DWARFExpressionList

[Lldb-commits] [PATCH] D154513: [lldb][NFC] Factor out code from SymbolFileDWARF::ParseVariableDIE

fdeazeve created this revision. Herald added a project: All. fdeazeve requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This function does a _lot_ of different things: 1. Parses a DIE, 2. Builds an ExpressionList 3. Figures out lifetime of

[Lldb-commits] [PATCH] D154505: [lldb][NFC] Remove code duplication in InitOSO

fdeazeve created this revision. Herald added a project: All. fdeazeve requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Two identical loops were iterating over different ranges, leading to code duplication. We replace this by a loop over the