[Lldb-commits] [PATCH] D157347: [lldb] Fix data race in NativeFile

JDevlieghere added inline comments. Comment at: lldb/source/Host/common/File.cpp:609 num_bytes = bytes_written; - } else if (StreamIsValid()) { + } else if (ValueGuard stream_guard = StreamIsValid()) { bytes_written = ::fwrite(buf, 1, num_bytes, m_stream);

[Lldb-commits] [PATCH] D157347: [lldb] Fix data race in NativeFile

JDevlieghere updated this revision to Diff 548849. JDevlieghere marked 4 inline comments as done. JDevlieghere added a comment. Limit scope of `ValueGuard` by avoiding `else if`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157347/new/ https://reviews.llvm.org/D157347 Files:

[Lldb-commits] [PATCH] D157347: [lldb] Fix data race in NativeFile

augusto2112 added inline comments. Comment at: lldb/source/Host/common/File.cpp:609 num_bytes = bytes_written; - } else if (StreamIsValid()) { + } else if (ValueGuard stream_guard = StreamIsValid()) { bytes_written = ::fwrite(buf, 1, num_bytes, m_stream);

[Lldb-commits] [PATCH] D157347: [lldb] Fix data race in NativeFile

bulbazord requested changes to this revision. bulbazord added inline comments. This revision now requires changes to proceed. Comment at: lldb/source/Host/common/File.cpp:609 num_bytes = bytes_written; - } else if (StreamIsValid()) { + } else if (ValueGuard stream_guard

[Lldb-commits] [PATCH] D157347: [lldb] Fix data race in NativeFile

augusto2112 accepted this revision. augusto2112 added a comment. I have one nit that I'll leave up to you whether it should be addressed now or not. Comment at: lldb/source/Host/common/File.cpp:545 num_bytes = bytes_read; - } else if (StreamIsValid()) { + } else if

[Lldb-commits] [PATCH] D157460: [lldb] Sink StreamFile into lldbHost

This revision was automatically updated to reflect the committed changes. Closed by commit rGf2d32ddcec82: [lldb] Sink StreamFile into lldbHost (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157460/new/

[Lldb-commits] [lldb] f2d32dd - [lldb] Sink StreamFile into lldbHost

Author: Alex Langford Date: 2023-08-09T17:17:18-07:00 New Revision: f2d32ddcec82c20582c6aa32558b82ca7c3d3c50 URL: https://github.com/llvm/llvm-project/commit/f2d32ddcec82c20582c6aa32558b82ca7c3d3c50 DIFF: https://github.com/llvm/llvm-project/commit/f2d32ddcec82c20582c6aa32558b82ca7c3d3c50.diff

[Lldb-commits] [PATCH] D157460: [lldb] Sink StreamFile into lldbHost

bulbazord updated this revision to Diff 548828. bulbazord added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157460/new/ https://reviews.llvm.org/D157460 Files: lldb/include/lldb/Core/Debugger.h

[Lldb-commits] [PATCH] D157463: [lldb] Sink StreamBuffer into lldbUtility

This revision was automatically updated to reflect the committed changes. Closed by commit rG20c77a578933: [lldb] Sink StreamBuffer into lldbUtility (authored by bulbazord). Changed prior to commit: https://reviews.llvm.org/D157463?vs=548419=548826#toc Repository: rG LLVM Github Monorepo

[Lldb-commits] [lldb] 20c77a5 - [lldb] Sink StreamBuffer into lldbUtility

Author: Alex Langford Date: 2023-08-09T17:10:13-07:00 New Revision: 20c77a5789331956cd47d1804df7885a82094964 URL: https://github.com/llvm/llvm-project/commit/20c77a5789331956cd47d1804df7885a82094964 DIFF: https://github.com/llvm/llvm-project/commit/20c77a5789331956cd47d1804df7885a82094964.diff

[Lldb-commits] [PATCH] D157556: Replace the singleton "ShadowListener" with a primary and N secondary listeners

bulbazord added inline comments. Comment at: lldb/include/lldb/Target/Process.h:348-357 eBroadcastBitStateChanged = (1 << 0), eBroadcastBitInterrupt = (1 << 1), eBroadcastBitSTDOUT = (1 << 2), eBroadcastBitSTDERR = (1 << 3), eBroadcastBitProfileData = (1

[Lldb-commits] [PATCH] D157556: Replace the singleton "ShadowListener" with a primary and N secondary listeners

mib accepted this revision. mib added a comment. This revision is now accepted and ready to land. LGTM with some comments :) Comment at: lldb/source/Target/Process.cpp:372 +const int Process::g_all_event_bits = eBroadcastBitStateChanged + |

[Lldb-commits] [PATCH] D157455: [lldb][NFCI] Remove MappedHash.h

This revision was automatically updated to reflect the committed changes. Closed by commit rG44c876fd75c2: [lldb][NFCI] Remove MappedHash.h (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157455/new/

[Lldb-commits] [lldb] 44c876f - [lldb][NFCI] Remove MappedHash.h

Author: Alex Langford Date: 2023-08-09T15:48:23-07:00 New Revision: 44c876fd75c26482d197a5c5312eac6f43fe URL: https://github.com/llvm/llvm-project/commit/44c876fd75c26482d197a5c5312eac6f43fe DIFF: https://github.com/llvm/llvm-project/commit/44c876fd75c26482d197a5c5312eac6f43fe.diff

[Lldb-commits] [PATCH] D157556: Replace the singleton "ShadowListener" with a primary and N secondary listeners

jingham created this revision. jingham added reviewers: mib, bulbazord, clayborg, JDevlieghere. Herald added a project: All. jingham requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Allow a Broadcaster to have one "Primary" listener, and

[Lldb-commits] [PATCH] D157361: [lldb] FIx data race in ThreadedCommunication

This revision was automatically updated to reflect the committed changes. Closed by commit rG1a8d9a7657bb: [lldb] Fix data race in ThreadedCommunication (authored by JDevlieghere). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] 1a8d9a7 - [lldb] Fix data race in ThreadedCommunication

Author: Jonas Devlieghere Date: 2023-08-09T15:15:42-07:00 New Revision: 1a8d9a7657bba79099e6e2a6b0568db53d1e9a23 URL: https://github.com/llvm/llvm-project/commit/1a8d9a7657bba79099e6e2a6b0568db53d1e9a23 DIFF:

[Lldb-commits] [PATCH] D156970: Fix crash in lldb-vscode when missing function name

clayborg added inline comments. Comment at: lldb/tools/lldb-vscode/JSONUtils.cpp:699-703 + // `function_name` can be a nullptr, which throws an error when assigned to an + // `std::string`. + const char *function_name = frame.GetDisplayFunctionName(); + std::string

[Lldb-commits] [PATCH] D157455: [lldb][NFCI] Remove MappedHash.h

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157455/new/ https://reviews.llvm.org/D157455

[Lldb-commits] [PATCH] D157538: [lldb][NFCI] Remove use of ifdef __cpluplus where unneeded

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157538/new/ https://reviews.llvm.org/D157538

[Lldb-commits] [PATCH] D157347: [lldb] Fix data race in NativeFile

bulbazord accepted this revision. bulbazord added a comment. This revision is now accepted and ready to land. Looks right to me now. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157347/new/ https://reviews.llvm.org/D157347 ___

[Lldb-commits] [PATCH] D157347: [lldb] Fix data race in NativeFile

JDevlieghere updated this revision to Diff 548729. JDevlieghere marked an inline comment as done. JDevlieghere added a comment. Address @bulbazord's code review feedback CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157347/new/ https://reviews.llvm.org/D157347 Files:

[Lldb-commits] [PATCH] D157538: [lldb][NFCI] Remove use of ifdef __cpluplus where unneeded

bulbazord created this revision. bulbazord added reviewers: JDevlieghere, mib, jasonmolenda, jingham. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Just about every file in the lldb project is built

[Lldb-commits] [PATCH] D157450: [lldb][NFCI] Remove unused IOStreamMacros

This revision was automatically updated to reflect the committed changes. Closed by commit rG335d0e3a6e8d: [lldb][NFCI] Remove unused IOStreamMacros (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157450/new/

[Lldb-commits] [lldb] 335d0e3 - [lldb][NFCI] Remove unused IOStreamMacros

Author: Alex Langford Date: 2023-08-09T11:42:41-07:00 New Revision: 335d0e3a6e8de8cccd535d9dbaa3df5600884ad7 URL: https://github.com/llvm/llvm-project/commit/335d0e3a6e8de8cccd535d9dbaa3df5600884ad7 DIFF: https://github.com/llvm/llvm-project/commit/335d0e3a6e8de8cccd535d9dbaa3df5600884ad7.diff

[Lldb-commits] [PATCH] D157460: [lldb] Sink StreamFile into lldbHost

mib accepted this revision. mib added inline comments. This revision is now accepted and ready to land. Comment at: lldb/include/lldb/Host/StreamFile.h:12 #include "lldb/Host/File.h" #include "lldb/Utility/Stream.h" bulbazord wrote: > mib wrote: > >

[Lldb-commits] [PATCH] D157460: [lldb] Sink StreamFile into lldbHost

bulbazord added inline comments. Comment at: lldb/include/lldb/Host/StreamFile.h:12 #include "lldb/Host/File.h" #include "lldb/Utility/Stream.h" mib wrote: > bulbazord wrote: > > mib wrote: > > > Do we really need this header ? We could forward declare

[Lldb-commits] [PATCH] D157460: [lldb] Sink StreamFile into lldbHost

mib added inline comments. Comment at: lldb/include/lldb/Host/StreamFile.h:12 #include "lldb/Host/File.h" #include "lldb/Utility/Stream.h" bulbazord wrote: > mib wrote: > > Do we really need this header ? We could forward declare FileSP do avoid > > having

[Lldb-commits] [PATCH] D157512: [lldb][PlatformDarwin] Only parse SDK from debug-info if target language is Objective-C

jingham added a comment. It's fairly common for AppKit developers to use access to static methods under NSApplication to see the state of the application. Since you aren't actually accessing the frame variables for this purpose, it's also pretty common for those folks to do: (lldb) process

[Lldb-commits] [PATCH] D157460: [lldb] Sink StreamFile into lldbHost

bulbazord added a comment. In D157460#4571772 , @mib wrote: > Shouldn't this be next to the other `Stream` class in `lldbUtility` ? `lldbUtility` is the lowest layer and does not depend on anything in `lldbHost`. That being said, `StreamFile` uses

[Lldb-commits] [PATCH] D157512: [lldb][PlatformDarwin] Only parse SDK from debug-info if target language is Objective-C

Michael137 created this revision. Michael137 added a reviewer: aprantl. Herald added a subscriber: kadircet. Herald added a project: All. Michael137 requested review of this revision. Herald added subscribers: lldb-commits, ilya-biryukov. Herald added a project: LLDB. The call to

[Lldb-commits] [PATCH] D156774: [lldb][DWARFASTParserClang] Resolve nested types when parsing structures

Michael137 added a comment. In D156774#4572967 , @Endill wrote: > In D156774#4572947 , @Michael137 > wrote: > >> Are you still planning on moving this forward? Otherwise I could commandeer >> the revision to

[Lldb-commits] [PATCH] D156774: [lldb][DWARFASTParserClang] Resolve nested types when parsing structures

Endill added a comment. In D156774#4572947 , @Michael137 wrote: > Are you still planning on moving this forward? Otherwise I could commandeer > the revision to get this in. I do think it's a useful bug to address I do. Locally I've been preparing

[Lldb-commits] [PATCH] D156774: [lldb][DWARFASTParserClang] Resolve nested types when parsing structures

Michael137 added a comment. Are you still planning on moving this forward? Otherwise I could commandeer the revision to get this in. I do think it's a useful bug to address Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156774/new/

[Lldb-commits] [PATCH] D157059: [lldb][PECOFF] Exclude alignment padding when reading section data

Michael137 added a comment. Hi, this is failing on swift-ci (runs on x86 bots) with the following error: /Users/ec2-user/jenkins/workspace/oss-lldb-incremental-macos-cmake/build/Ninja-ReleaseAssert+stdlib-Release/lldb-macosx-x86_64/unittests/ObjectFile/PECOFF/./ObjectFilePECOFFTests

[Lldb-commits] [PATCH] D157488: [lldb][AArch64] Add testing of save/restore for Linux MTE control register

DavidSpickett created this revision. Herald added a subscriber: kristof.beyls. Herald added a project: All. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This has always worked but had no coverage. Adding testing now so

[Lldb-commits] [PATCH] D157486: Triple Patch

Pivnoy created this revision. Herald added a reviewer: JDevlieghere. Herald added a reviewer: aaron.ballman. Herald added a project: All. Pivnoy requested review of this revision. Herald added projects: clang, LLDB, LLVM. Herald added subscribers: llvm-commits, lldb-commits, cfe-commits.