[Lldb-commits] [lldb] 0fa3320 - [lldb] reject `.debug_arange` sections with nonzero segment size

Author: Luke Drummond Date: 2020-03-12T12:22:50Z New Revision: 0fa3320931e93d658f68c1f19eb45b922158b61e URL: https://github.com/llvm/llvm-project/commit/0fa3320931e93d658f68c1f19eb45b922158b61e DIFF: https://github.com/llvm/llvm-project/commit/0fa3320931e93d658f68c1f19eb45b922158b61e.diff

[Lldb-commits] [lldb] r290957 - Add a debuginfo version check for RenderScript modules

Author: ldrumm Date: Wed Jan 4 06:11:04 2017 New Revision: 290957 URL: http://llvm.org/viewvc/llvm-project?rev=290957=rev Log: Add a debuginfo version check for RenderScript modules Added an extra field parser to the `RSModuleDescriptor` class enabling us to check whether the versions of LLVM

[Lldb-commits] [lldb] r290359 - Fix a couple of incorrect format string warnings

Author: ldrumm Date: Thu Dec 22 13:15:07 2016 New Revision: 290359 URL: http://llvm.org/viewvc/llvm-project?rev=290359=rev Log: Fix a couple of incorrect format string warnings This patch fixes use of incorrect `%zi` to format a plain `int`, and using `%llu` to format a `uint64_t`. The fix is to

[Lldb-commits] [lldb] r290117 - Expression evaluation for overloaded C functions (redux)

Author: ldrumm Date: Mon Dec 19 11:22:44 2016 New Revision: 290117 URL: http://llvm.org/viewvc/llvm-project?rev=290117=rev Log: Expression evaluation for overloaded C functions (redux) This is a redux of [Ewan's patch](https://reviews.llvm.org/D17957) , refactored to properly substitute

[Lldb-commits] [lldb] r289956 - Fix broken escaping of commands in the build

Author: ldrumm Date: Fri Dec 16 10:38:25 2016 New Revision: 289956 URL: http://llvm.org/viewvc/llvm-project?rev=289956=rev Log: Fix broken escaping of commands in the build A combination of broken escaping in CMake and in the python swig generation scripts meant that the swig generation step

Re: [Lldb-commits] [PATCH] D26757: Fix broken escaping of commands in the build

Hi Zachary On 15/12/16 17:52, Zachary Turner wrote: I think this was lgtm'ed wasn't it? Chris checked the cmake changes, so if you're happy with the python fixes I'll go ahead and commit this. Thanks Luke ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D26757: Fix broken escaping of commands in the build

ldrumm added inline comments. Comment at: scripts/Python/prepare_binding_Python.py:222 +) +logging.info("running swig with: %r", command) bryant wrote: > ldrumm wrote: > > bryant wrote: > > > You can reduce diff noise by limiting your changes to

[Lldb-commits] [PATCH] D26757: Fix broken escaping of commands in the build

ldrumm added inline comments. Comment at: scripts/CMakeLists.txt:38 + COMMAND +${PYTHON_EXECUTABLE} ${CMAKE_CURRENT_SOURCE_DIR}/prepare_bindings.py + ${framework_arg} bryant wrote: > Move this back up. Will do https://reviews.llvm.org/D26757

[Lldb-commits] [PATCH] D26757: Fix broken escaping of commands in the build

ldrumm added inline comments. Comment at: scripts/Python/prepare_binding_Python.py:222 +) +logging.info("running swig with: %r", command) bryant wrote: > You can reduce diff noise by limiting your changes to removing the %s. So, > > ```python > #

[Lldb-commits] [PATCH] D26757: Fix broken escaping of commands in the build

ldrumm added inline comments. Comment at: CMakeLists.txt:46 +COMMAND + ${PYTHON_EXECUTABLE} ${CMAKE_CURRENT_SOURCE_DIR}/scripts/finishSwigWrapperClasses.py + --srcRoot=${LLDB_SOURCE_DIR} bryant wrote: > You can reduce diff noise

[Lldb-commits] [PATCH] D26757: Fix broken escaping of commands in the build

ldrumm added inline comments. Comment at: scripts/Python/prepare_binding_Python.py:229 stderr=subprocess.PIPE, -shell=True) +) # Wait for SWIG process to terminate bryant wrote: > ldrumm wrote: > > granata.enrico wrote: > > > This

[Lldb-commits] [PATCH] D26757: Fix broken escaping of commands in the build

ldrumm added inline comments. Comment at: scripts/Python/prepare_binding_Python.py:229 stderr=subprocess.PIPE, -shell=True) +) # Wait for SWIG process to terminate granata.enrico wrote: > This worries me a little bit.. Are we sure we

[Lldb-commits] [PATCH] D26757: Fix broken escaping of commands in the build

ldrumm created this revision. ldrumm added reviewers: zturner, granata.enrico. ldrumm added a subscriber: LLDB. Herald added a subscriber: mgorny. A combination of broken escaping in CMake and in the python swig generation scripts meant that the swig generation step would fail whenever there

[Lldb-commits] [lldb] r286387 - [RenderScript] Fix reduction argument printing

Author: ldrumm Date: Wed Nov 9 13:20:39 2016 New Revision: 286387 URL: http://llvm.org/viewvc/llvm-project?rev=286387=rev Log: [RenderScript] Fix reduction argument printing When placing function name breakpoints on RenderScript Reduction kernel functions, we were not skipping over the function

[Lldb-commits] [lldb] r283362 - Add the ability to set breakpoints on named RenderScript reductions

Author: ldrumm Date: Wed Oct 5 14:10:47 2016 New Revision: 283362 URL: http://llvm.org/viewvc/llvm-project?rev=283362=rev Log: Add the ability to set breakpoints on named RenderScript reductions - Add new `lldb_private::lldb_renderscript::RSReduceBreakpointResolver` class that can set

[Lldb-commits] [lldb] r283335 - [RenderScript] reflow/reword some comments and normalize names

Author: ldrumm Date: Wed Oct 5 11:27:48 2016 New Revision: 283335 URL: http://llvm.org/viewvc/llvm-project?rev=283335=rev Log: [RenderScript] reflow/reword some comments and normalize names Pay more attention to comment alignement (Since _The Great Reformat_ (a015ff50) comments are no longer

[Lldb-commits] [lldb] r283320 - cleanup RSCoordinate handling and factor out coordinate parser

Author: ldrumm Date: Wed Oct 5 09:34:52 2016 New Revision: 283320 URL: http://llvm.org/viewvc/llvm-project?rev=283320=rev Log: cleanup RSCoordinate handling and factor out coordinate parser - This change updates the signature of `RenderScriptRuntime::PlaceBreakpointOnKernel` to take a default

[Lldb-commits] [PATCH] D24793: Delete an (apparently unused) global in ClangExpressionVaraible.cpp

This revision was automatically updated to reflect the committed changes. Closed by commit rL283313: Delete unused global in ClangExpressionVariable.cpp (authored by ldrumm). Changed prior to commit: https://reviews.llvm.org/D24793?vs=72021=73636#toc Repository: rL LLVM

[Lldb-commits] [lldb] r283313 - Delete unused global in ClangExpressionVariable.cpp

Author: ldrumm Date: Wed Oct 5 07:40:49 2016 New Revision: 283313 URL: http://llvm.org/viewvc/llvm-project?rev=283313=rev Log: Delete unused global in ClangExpressionVariable.cpp Differential Revision: https://reviews.llvm.org/D24793 Modified:

[Lldb-commits] [lldb] r282066 - Remove an invalid doxygen `@return` docstring on a void function

Author: ldrumm Date: Wed Sep 21 06:12:50 2016 New Revision: 282066 URL: http://llvm.org/viewvc/llvm-project?rev=282066=rev Log: Remove an invalid doxygen `@return` docstring on a void function `ClangASTSource::FindExternalVisibleDecls` has void return type, so the previous docstring was

[Lldb-commits] [PATCH] D24793: Delete an (apparently unused) global in ClangExpressionVaraible.cpp

ldrumm created this revision. ldrumm added reviewers: spyffe, clayborg. ldrumm added a subscriber: LLDB. ldrumm added a project: LLDB. I've grepped the entire llvm source tree, and can't find any external references, to this symbol. The build is also clean without it, so I think this is safe to

Re: [Lldb-commits] [lldb] r281717 - [RenderScript] Support tracking and dumping reduction kernels

Hi Zachary Thanks for the review. My comments are inline (I've cut down some of the diff context for brevity) On 16/09/16 15:57, Zachary Turner wrote: [snip] -#define MAXLINESTR_(x) "%" STRINGIFY(x) "s" -#define MAXLINESTR MAXLINESTR_(MAXLINE) +bool

[Lldb-commits] [lldb] r281717 - [RenderScript] Support tracking and dumping reduction kernels

Author: ldrumm Date: Fri Sep 16 06:28:12 2016 New Revision: 281717 URL: http://llvm.org/viewvc/llvm-project?rev=281717=rev Log: [RenderScript] Support tracking and dumping reduction kernels Initial implementation of support for tracking [RenderScript

[Lldb-commits] [lldb] r277613 - [RenderScript] Always create a new allocation ID in CaptureAllocationInit hook

Author: ldrumm Date: Wed Aug 3 12:31:58 2016 New Revision: 277613 URL: http://llvm.org/viewvc/llvm-project?rev=277613=rev Log: [RenderScript] Always create a new allocation ID in CaptureAllocationInit hook Due to internal reuse of buffers in the RenderScript runtime by the system allocator,

Re: [Lldb-commits] [PATCH] D22923: cleanup some format string warnings

This revision was automatically updated to reflect the committed changes. Closed by commit rL277016: Cleanup some format string warnings (authored by ldrumm). Changed prior to commit: https://reviews.llvm.org/D22923?vs=65941=65960#toc Repository: rL LLVM https://reviews.llvm.org/D22923

[Lldb-commits] [lldb] r277016 - Cleanup some format string warnings

Author: ldrumm Date: Thu Jul 28 13:19:33 2016 New Revision: 277016 URL: http://llvm.org/viewvc/llvm-project?rev=277016=rev Log: Cleanup some format string warnings Clean up format string warnings in ValueObjectSyntheticFilter.cpp to explictly cast "%p" params to void *` Subscribers:

Re: [Lldb-commits] [PATCH] D18059: Add IR fixups for RenderScript ABI mismatch between ARMV7 frontend and x86 backend

ldrumm added a comment. In https://reviews.llvm.org/D18059#499525, @tfiala wrote: > In https://reviews.llvm.org/D18059#499522, @ldrumm wrote: > > > In https://reviews.llvm.org/D18059#499521, @tfiala wrote: > > > > > I've got a fix to make this work in Xcode, but I'm currently stuck behind > > >

Re: [Lldb-commits] [PATCH] D18059: Add IR fixups for RenderScript ABI mismatch between ARMV7 frontend and x86 backend

ldrumm added a comment. In https://reviews.llvm.org/D18059#499521, @tfiala wrote: > I've got a fix to make this work in Xcode, but I'm currently stuck behind the > missing Condition.cpp from r277011 to verify. Thanks Todd. I don't really deal with XCode, so that's a real help. Regarding

[Lldb-commits] [PATCH] D22923: cleanup some format string warnings

ldrumm created this revision. ldrumm added reviewers: clayborg, granata.enrico. ldrumm added a subscriber: lldb-commits. ldrumm added a project: LLDB. clean up format string warnings in `ValueObjectSyntheticFilter.cpp` to explictly cast `"%p" params to `void *` https://reviews.llvm.org/D22923

Re: [Lldb-commits] [PATCH] D18059: Add IR fixups for RenderScript ABI mismatch between ARMV7 frontend and x86 backend

This revision was automatically updated to reflect the committed changes. Closed by commit rL276976: Add IR fixups for RenderScript ABI mismatch between ARMV7 frontend and x86… (authored by ldrumm). Changed prior to commit: https://reviews.llvm.org/D18059?vs=65927=65929#toc Repository: rL

[Lldb-commits] [lldb] r276976 - Add IR fixups for RenderScript ABI mismatch between ARMV7 frontend and x86 backend

Author: ldrumm Date: Thu Jul 28 09:21:07 2016 New Revision: 276976 URL: http://llvm.org/viewvc/llvm-project?rev=276976=rev Log: Add IR fixups for RenderScript ABI mismatch between ARMV7 frontend and x86 backend Expression evaluation for function calls to certain public RenderScript API

Re: [Lldb-commits] [PATCH] D18059: Add IR fixups for RenderScript ABI mismatch between ARMV7 frontend and x86 backend

ldrumm updated this revision to Diff 65927. Herald added a subscriber: samparker. https://reviews.llvm.org/D18059 Files: source/Plugins/LanguageRuntime/RenderScript/RenderScriptRuntime/CMakeLists.txt

Re: [Lldb-commits] [PATCH] D22052: Respect `ANDROID_SERIAL` environment variable used by ADB

This revision was automatically updated to reflect the committed changes. ldrumm marked an inline comment as done. Closed by commit rL274776: Respect ANDROID_SERIAL environment variable used by ADB (authored by ldrumm). Changed prior to commit: http://reviews.llvm.org/D22052?vs=63055=63095#toc

[Lldb-commits] [lldb] r274776 - Respect ANDROID_SERIAL environment variable used by ADB

Author: ldrumm Date: Thu Jul 7 13:02:44 2016 New Revision: 274776 URL: http://llvm.org/viewvc/llvm-project?rev=274776=rev Log: Respect ANDROID_SERIAL environment variable used by ADB When multiple Android devices are attached, the default behaviour of ADB is to resolve a device number based on

Re: [Lldb-commits] [PATCH] D22081: Use shell cat command as a workaround if ADB stat cannot lookup a file

ldrumm added a subscriber: ldrumm. Comment at: source/Plugins/Platform/Android/PlatformAndroid.cpp:244 @@ +243,3 @@ +char cmd[PATH_MAX]; +snprintf (cmd, sizeof (cmd), "cat '%s'", source_spec.GetCString (false)); + I have some issues with this

Re: [Lldb-commits] [PATCH] D22052: Respect `ANDROID_SERIAL` environment variable used by ADB

ldrumm removed rL LLVM as the repository for this revision. ldrumm updated this revision to Diff 63055. ldrumm added a comment. - Ensure if ANDROID_SERIAL is set, it exists in the list of connected devices (Address feedback from @ovyalov) - Also add a hint in the error message in case multiple

[Lldb-commits] [PATCH] D22060: [expression evaluation] Prevent invalid function declarations ending up in clang AST

ldrumm created this revision. ldrumm added reviewers: spyffe, jingham. ldrumm added a subscriber: lldb-commits. Due to the way the lldb override for `clang::ExternalASTSource::FindExternalGlobalVisibleDeclsByName` callback was searching for functions, it was possible for invalid declarations to

[Lldb-commits] [PATCH] D22052: Respect `ANDROID_SERIAL` environment variable used by ADB

ldrumm created this revision. ldrumm added reviewers: tberghammer, ovyalov. ldrumm added a subscriber: lldb-commits. ldrumm set the repository for this revision to rL LLVM. Herald added subscribers: srhines, danalbert, tberghammer. Respect `ANDROID_SERIAL` environment variable used by ADB

Re: [Lldb-commits] [PATCH] D17027: [expression evaluator] Allow runtimes to execute custom LLVM ModulePasses over the generated IR at various stages after expression compilation.

ldrumm abandoned this revision. ldrumm added a comment. committed in http://reviews.llvm.org/rL272800 http://reviews.llvm.org/D17027 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [lldb] r272800 - Allow runtimes to execute custom LLVM ModulePasses over the expression IR

Author: ldrumm Date: Wed Jun 15 11:19:46 2016 New Revision: 272800 URL: http://llvm.org/viewvc/llvm-project?rev=272800=rev Log: Allow runtimes to execute custom LLVM ModulePasses over the expression IR During expression evaluation, the ClangExpressionParser preforms a number of hard-coded fixups

Re: [Lldb-commits] [PATCH] D17027: [expression evaluator] Allow runtimes to execute custom LLVM ModulePasses over the generated IR at various stages after expression compilation.

ldrumm added a comment. I'd like to give this another *bump*, and commit this soon assuming positive review. @spyffe http://reviews.llvm.org/D17027 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

Re: [Lldb-commits] [PATCH] D17027: [expression evaluator] Allow runtimes to execute custom LLVM ModulePasses over the generated IR at various stages after expression compilation.

ldrumm updated this revision to Diff 57199. ldrumm added a comment. rebased on current HEAD http://reviews.llvm.org/D17027 Files: include/lldb/Expression/LLVMUserExpression.h include/lldb/Target/LanguageRuntime.h source/Plugins/ExpressionParser/Clang/ClangExpressionParser.cpp Index:

[Lldb-commits] [lldb] r265808 - Remove bad indentation introduced in 263859

Author: ldrumm Date: Fri Apr 8 11:52:40 2016 New Revision: 265808 URL: http://llvm.org/viewvc/llvm-project?rev=265808=rev Log: Remove bad indentation introduced in 263859 This commit touches whitespace only. This commit was the original intention of the botched 265797 Modified:

[Lldb-commits] [lldb] r265799 - Revert bad commit 265797.

Author: ldrumm Date: Fri Apr 8 11:35:58 2016 New Revision: 265799 URL: http://llvm.org/viewvc/llvm-project?rev=265799=rev Log: Revert bad commit 265797. Modified: lldb/trunk/include/lldb/Expression/LLVMUserExpression.h Modified: lldb/trunk/include/lldb/Expression/LLVMUserExpression.h URL:

[Lldb-commits] [lldb] r265797 - Fix indentation for commit 263859.

Author: ldrumm Date: Fri Apr 8 11:30:55 2016 New Revision: 265797 URL: http://llvm.org/viewvc/llvm-project?rev=265797=rev Log: Fix indentation for commit 263859. Modified: lldb/trunk/include/lldb/Expression/LLVMUserExpression.h Modified:

Re: [Lldb-commits] [PATCH] D17027: [expression evaluator] Allow runtimes to execute custom LLVM ModulePasses over the generated IR at various stages after expression compilation.

ldrumm added a comment. Hi Sean Did you get a chance to look over this? It'd be great to have your input. Best Luke http://reviews.llvm.org/D17027 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

Re: [Lldb-commits] [PATCH] D18005: Fixed ValueObject::GetExpressionPath() for paths including anonymous struct/union

ldrumm added a subscriber: ldrumm. ldrumm added a comment. Hi all This differential may also be somewhat relevant / of interest, although it deals only with typedefs of untagged struct types. Best Luke Repository: rL LLVM http://reviews.llvm.org/D18005

Re: [Lldb-commits] [PATCH] D17719: Track expression language from one place in ClangExpressionParser

ldrumm added a comment. Hi all I'm still keen to have someone more familiar with this code to let me know if anything's amiss, but I'll probably move ahead and commit this tomorrow if I don't hear anything. Let me know if you'd like any changes made - or the patch is simply rotten to the core

Re: [Lldb-commits] [PATCH] D17719: Track expression language from one place in ClangExpressionParser

ldrumm added a comment. Hi all If there are no objections, I'd like to commit this. Is this in an acceptable state? Best Luke http://reviews.llvm.org/D17719 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

Re: [Lldb-commits] [PATCH] D17719: Track expression language from one place in ClangExpressionParser

ldrumm updated this revision to Diff 49531. ldrumm added a comment. Updated diff to show full context http://reviews.llvm.org/D17719 Files: source/Plugins/ExpressionParser/Clang/ClangExpressionParser.cpp source/Plugins/ExpressionParser/Clang/ClangExpressionParser.h Index:

[Lldb-commits] [PATCH] D17719: Track expression language from one place in ClangExpressionParser

ldrumm created this revision. ldrumm added reviewers: clayborg, spyffe. ldrumm added a subscriber: lldb-commits. The current expression language is currently tracked in a few places within the `ClangExpressionParser` constructor. This patch adds a private `lldb::LanguageType` attribute to the

Re: [Lldb-commits] [PATCH] D17274: improve readability and performance of ClangExpressionParser::FindFunctionInModule

ldrumm added inline comments. Comment at: source/Plugins/ExpressionParser/Clang/ClangExpressionParser.cpp:559-560 @@ -558,5 +558,4 @@ -static bool FindFunctionInModule (ConstString _name, - llvm::Module *module, -

Re: [Lldb-commits] [PATCH] D17027: [expression evaluator] Allow runtimes to execute custom LLVM ModulePasses over the generated IR at various stages after expression compilation.

ldrumm added a comment. Hi @spyffe @jingham If you have the time, I'd appreciate your comments. Thanks Luke http://reviews.llvm.org/D17027 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

Re: [Lldb-commits] [PATCH] D17274: improve readability and performance of ClangExpressionParser::FindFunctionInModule

ldrumm added inline comments. Comment at: source/Plugins/ExpressionParser/Clang/ClangExpressionParser.cpp:559-560 @@ -558,5 +558,4 @@ -static bool FindFunctionInModule (ConstString _name, - llvm::Module *module, -

Re: [Lldb-commits] [PATCH] D16412: remove unused local string in IRForTarget.cpp

ldrumm updated this revision to Diff 48006. ldrumm added a comment. rebased on current HEAD http://reviews.llvm.org/D16412 Files: source/Plugins/ExpressionParser/Clang/IRForTarget.cpp Index: source/Plugins/ExpressionParser/Clang/IRForTarget.cpp

Re: [Lldb-commits] [PATCH] D17027: [expression evaluator] Allow runtimes to execute custom LLVM ModulePasses over the generated IR at various stages after expression compilation.

ldrumm added a subscriber: ldrumm. ldrumm added a comment. Hi Jim http://reviews.llvm.org/D17027 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D17027: [expression evaluator] Allow runtimes to execute custom LLVM ModulePasses over the generated IR at various stages after expression compilation.

Hi Jim On 10/02/16 17:02, Jim Ingham wrote: On Feb 10, 2016, at 3:45 AM, Luke Drummond wrote: ldrumm added a comment. In http://reviews.llvm.org/D17027#347487, @jingham wrote: This seems fine as a generic instrumentation point. Obviously, the onus in on

[Lldb-commits] [PATCH] D17274: improve readability and performance of ClangExpressionParser::FindFunctionInModule

ldrumm created this revision. ldrumm added reviewers: spyffe, dawn. ldrumm added a subscriber: lldb-commits. - Prefer `llvm::StringRef::find` over allocating a `std::string` and then discarding it after calling the equivalent `find` method. - improve readability of function iterator, and make

[Lldb-commits] [PATCH] D17273: refactor/cleanup ClangExpressionParser::Parse

ldrumm created this revision. ldrumm added reviewers: clayborg, zturner, spyffe. ldrumm added a subscriber: lldb-commits. - fix return type: `ClangExpressionParser::Parse` returns unsigned, but was actually returning a signed value, `num_errors`. - use helper

[Lldb-commits] [PATCH] D17266: delete unused function in ClangExpressionParser`

ldrumm created this revision. ldrumm added reviewers: clayborg, spyffe, jingham. ldrumm added a subscriber: lldb-commits. [git 65dafa83] introduced the `GetBuiltinIncludePath` function copied from

Re: [Lldb-commits] [PATCH] D17027: [expression evaluator] Allow runtimes to execute custom LLVM ModulePasses over the generated IR at various stages after expression compilation.

ldrumm added a comment. In http://reviews.llvm.org/D17027#347487, @jingham wrote: > This seems fine as a generic instrumentation point. Obviously, the onus in > on the passes, since they could totally ruin the expression evaluation if > they don't do their job right... But I'm not sure

Re: [Lldb-commits] [PATCH] D17022: [LLDB][MIPS] Provide CPU string to compiler for appropriate code generation for MIPS

ldrumm added a subscriber: ldrumm. ldrumm added a comment. Hi This patch is on an out of date ClangExpressionParser.cpp. The feature added in http://reviews.llvm.org/rL259644 allows a more generic way of implementing what I believe you're trying to achieve with this patch. It's probably worth

[Lldb-commits] [PATCH] D17027: [expression evaluator] Allow runtimes to execute custom LLVM ModulePasses over the generated IR at various stages after expression compilation.

ldrumm created this revision. ldrumm added reviewers: jingham, spyffe. ldrumm added a subscriber: lldb-commits. During expression evaluation, the `ClangExpressionParser` preforms a number of hard-coded fixups on the expression's IR before the module is assembled and dispatched to be run in a

Re: [Lldb-commits] [PATCH] D15527: Add ability to override JIT expr compiler options.

ldrumm added a comment. I'd like a final review on this patch if one of the code owners can take the time, please? http://reviews.llvm.org/D15527 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

Re: [Lldb-commits] [PATCH] D15527: Add ability to override JIT expr compiler options.

ldrumm added a comment. Hi Sean If you have the time I'd appreciate it if you could take another look over my latest iteration of this feature. Thanks Luke http://reviews.llvm.org/D15527 ___ lldb-commits mailing list

Re: [Lldb-commits] [PATCH] D16107: Fix for Bug 25338

ldrumm added a subscriber: ldrumm. ldrumm added a comment. This differential seems to have introduced a regression on x86_64 Android, where `std::bad_alloc` is thrown during process attach. I've reverted this locally, and filed a bug , but as this

Re: [Lldb-commits] [PATCH] D15527: Add ability to override JIT expr compiler options.

ldrumm updated this revision to Diff 45588. ldrumm added a comment. Address @spyffe's previous suggestions regarding modifying target options in place. This allows for a simpler and more maintainable solution than previously implemented, and requires no extra datatype definitions. - removed

Re: [Lldb-commits] [PATCH] D15527: Add ability to override JIT expr compiler options.

ldrumm updated this revision to Diff 44794. ldrumm added a comment. Responding to Sean Callanan's suggestions in previous differential RE accepting an existing set of TargetOptions as the basis to configure a custom set. http://reviews.llvm.org/D15527 Files:

[Lldb-commits] [PATCH] D16155: possible ambigous resolution of clang::ArrayType/llvm::ArrayType in ClangAstContext

ldrumm created this revision. ldrumm added a reviewer: spyffe. ldrumm added a subscriber: lldb-commits. source/Symbol/ClangASTContext.cpp has `using namespace llvm; using namespace clang;` Both [llvm](http://llvm.org/docs/doxygen/html/classllvm_1_1ArrayType.html) and

Re: [Lldb-commits] [PATCH] D15527: Add ability to override JIT expr compiler options.

ldrumm added a comment. In http://reviews.llvm.org/D15527#324919, @spyffe wrote: > I'm a little concerned that LanguageRuntime::GetOverrideExprOptions() appears > to generate a new set of options from whole cloth rather than using the > existing set as a starting point. > > Specifically, since

Re: [Lldb-commits] [PATCH] D15527: Add ability to override JIT expr compiler options.

ldrumm requested a review of this revision. ldrumm added a comment. bump Comment at: source/Plugins/ExpressionParser/Clang/ClangExpressionParser.cpp:85-97 @@ -83,1 +84,15 @@ +namespace { +void debugStringVector(Log *log, const std::vector& vec, const char *name) +{

[Lldb-commits] [PATCH] D15948: Remove duplicate header added in http://reviews.llvm.org/rL256927

ldrumm created this revision. ldrumm added a reviewer: EwanCrawford. ldrumm added a subscriber: lldb-commits. rL256927 included a duplicate `StreamString` header file. This patch simply removes the duplicate. http://reviews.llvm.org/D15948 Files: source/Core/StringList.cpp Index:

Re: [Lldb-commits] [PATCH] D15773: Add LogDump methods to lldb_private::StringList to ease printing of iterable string containers

ldrumm added a subscriber: lldb-commits. ldrumm updated this revision to Diff 44000. ldrumm added a comment. Addresses @clayborg's feedback in http://reviews.llvm.org/D15773 http://reviews.llvm.org/D15773 Files: source/Core/StringList.cpp Index: source/Core/StringList.cpp

[Lldb-commits] [PATCH] D15527: Add ability to override JIT expr compiler options.

ldrumm created this revision. ldrumm added reviewers: clayborg, spyffe. ldrumm added a subscriber: lldb-commits. ldrumm set the repository for this revision to rL LLVM. Runtimes should be able to pass custom compilation options to the JIT for their stack frame. This patch adds a custom