Re: [lng-odp] [PATCH 1/3] test: l2fwd: add group option

2017-04-07 Thread Ola Liljedahl
On 6 April 2017 at 13:59, Petri Savolainen wrote: > > User may give number of scheduling groups to test > scheduler performance with other that the default (all > threads) group. Both pktios and threads are allocated Isn't all *workers* a better default scheduler

Re: [lng-odp] [API-NEXT PATCH v2 00/16] A scalable software scheduler

2017-04-07 Thread Ola Liljedahl
On 7 April 2017 at 08:40, Peltonen, Janne (Nokia - FI/Espoo) < janne.pelto...@nokia.com> wrote: > Hi, > > On Thu, Apr 6, 2017 at 1:46 PM, Bill Fischofer > wrote: > > On Thu, Apr 6, 2017 at 1:32 PM, Ola Liljedahl > wrote: > > > On 6 April 2017

Re: [lng-odp] [API-NEXT PATCH v2 00/16] A scalable software scheduler

2017-04-07 Thread Maxim Uvarov
I forget to note that it will be great to update .travis file for testing new option. Maxim. On 04/04/17 21:47, Brian Brooks wrote: > This work derives from Ola Liljedahl's prototype [1] which introduced a > scalable scheduler design based on primarily lock-free algorithms and > data structures

Re: [lng-odp] [API-NEXT PATCH] api: ipsec: spi_overlap and lookup modes

2017-04-07 Thread Maxim Uvarov
Merged this patch. Maxim. On 04/07/17 15:47, Bill Fischofer wrote: > On Fri, Apr 7, 2017 at 7:35 AM, Petri Savolainen > wrote: >> Lookup modes are per SA and thus may be used in a mix. Spi_overlap >> parameter is global. So, removed comment about ignoring it in >>

[lng-odp] [Linaro/odp] 384857: api: ipsec: spi_overlap and lookup modes

2017-04-07 Thread GitHub
Branch: refs/heads/api-next Home: https://github.com/Linaro/odp Commit: 38485719c028918b019c6a5fc67cf05053421c83 https://github.com/Linaro/odp/commit/38485719c028918b019c6a5fc67cf05053421c83 Author: Petri Savolainen Date: 2017-04-07 (Fri, 07 Apr

Re: [lng-odp] [PATCH] validation: scheduler: Release context before the end of the scheduler test

2017-04-07 Thread Honnappa Nagarahalli
On 7 April 2017 at 07:29, Ola Liljedahl wrote: > On 7 April 2017 at 14:06, Savolainen, Petri (Nokia - FI/Espoo) < > petri.savolai...@nokia-bell-labs.com> wrote: >> >> >> From: Kevin Wang [mailto:kevin.w...@linaro.org] >> Sent: Friday, April 07, 2017 11:45 AM >> To:

Re: [lng-odp] linux-gen: timer: ODP general timer timeout machenism on massive timers usage

2017-04-07 Thread Honnappa Nagarahalli
On 7 April 2017 at 10:33, Bill Fischofer wrote: > Thanks for your note Mario. As an aside, please subscribe to the ODP > mailing list otherwise I have to approve each post you make manually, > which will only add delay. Please see >

Re: [lng-odp] [PATCH] Use different name to create pool and queue

2017-04-07 Thread Honnappa Nagarahalli
On 7 April 2017 at 03:12, Savolainen, Petri (Nokia - FI/Espoo) wrote: > First, should this patch be a part of a series with a cover letter subject > "Avoid shm namespace collisions and allow shmblock per queue". Now > everything is just separate

Re: [lng-odp] linux-gen: timer: ODP general timer timeout machenism on massive timers usage

2017-04-07 Thread Bill Fischofer
Thanks for your note Mario. As an aside, please subscribe to the ODP mailing list otherwise I have to approve each post you make manually, which will only add delay. Please see https://lists.linaro.org/mailman/listinfo/lng-odp for that. We also have a weekly public call on Tuesdays at 15:00 UTC

Re: [lng-odp] [API-NEXT] API: IPSEC: Updating ipsec APIs to support sNIC implementation.

2017-04-07 Thread Peltonen, Janne (Nokia - FI/Espoo)
Hi, > > Shally - enque in order-of-completion or in-order-submission? What does > > this mean in- > > context of ipsec? > > In general, there is bit of confusion when we are using terms async in ODP > > context here. > > It imply that queue is used to output events. an async implementation can

Re: [lng-odp] [API-NEXT PATCH] abi: event: add ODP_EVENT_IPSEC_STATUS

2017-04-07 Thread Bill Fischofer
On Fri, Apr 7, 2017 at 9:41 AM, Peltonen, Janne (Nokia - FI/Espoo) wrote: > I think it is a good suggestion. But I understood that in C++ > the comma is not allowed until C++11 so I wonder if it is > ok to add it in ODP (in C it is ok from C99 on). Given that ODP

Re: [lng-odp] [API-NEXT] API: IPSEC: Updating ipsec APIs to support sNIC implementation.

2017-04-07 Thread Nikhil Agarwal
CoS will be applicable in case of inline mode and packets will follow default pktio CoS. -Original Message- From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of Bogdan Pricope Sent: Friday, April 07, 2017 5:10 PM To: Verma, Shally Cc:

Re: [lng-odp] [API-NEXT] API: IPSEC: Updating ipsec APIs to support sNIC implementation.

2017-04-07 Thread Nikhil Agarwal
-Original Message- From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of Verma, Shally Sent: Friday, April 07, 2017 4:45 PM To: Nikhil Agarwal ; lng-odp@lists.linaro.org Subject: Re: [lng-odp] [API-NEXT] API: IPSEC: Updating ipsec APIs to

Re: [lng-odp] [PATCH] Relax the assert check with enqueue fails in the scheduler test case

2017-04-07 Thread Ola Liljedahl
>From test/common_plat/validation/api/scheduler/scheduler.c #define BUFS_PER_QUEUE_EXCL 1 The scalable scheduler has a default queue size of 4096 which seemed reasonable to us. We can always increase the value but applications and test prorgams should not expect infinite queue size.

Re: [lng-odp] [API-NEXT PATCH] abi: event: add ODP_EVENT_IPSEC_STATUS

2017-04-07 Thread Peltonen, Janne (Nokia - FI/Espoo)
I think it is a good suggestion. But I understood that in C++ the comma is not allowed until C++11 so I wonder if it is ok to add it in ODP (in C it is ok from C99 on). Perhaps someone can just add the comma when pushing the patch? Janne > -Original Message- > From: Bill

Re: [lng-odp] [API-NEXT PATCH v2 07/16] test: odp_scheduling: Handle dequeueing from a concurrent queue

2017-04-07 Thread Ola Liljedahl
On 6 April 2017 at 20:51, Maxim Uvarov wrote: > On 04/06/17 13:35, Ola Liljedahl wrote: > > On 5 April 2017 at 23:39, Maxim Uvarov wrote: > >> On 04/05/17 17:30, Ola Liljedahl wrote: > >>> On 5 April 2017 at 14:50, Maxim Uvarov

[lng-odp] linux-gen: timer: ODP general timer timeout machenism on massive timers usage

2017-04-07 Thread Mario (Miao) Mao
Hi All, We have a project to adapt an existed firewall implementation to ODP framework. The current implementation needs to generate massive number of timer which link to each flow element. So there is requirement to run up to a million of timers to trigger the flow event. An straightforward

Re: [lng-odp] [API-NEXT PATCH] abi: event: add ODP_EVENT_IPSEC_STATUS

2017-04-07 Thread Bill Fischofer
On Fri, Apr 7, 2017 at 4:54 AM, Janne Peltonen wrote: > > Update ABI spec with the new IPsec event type. > > Signed-off-by: Janne Peltonen Reviewed-by: Bill Fischofer > --- >

Re: [lng-odp] [API-NEXT PATCH] api: ipsec: spi_overlap and lookup modes

2017-04-07 Thread Bill Fischofer
On Fri, Apr 7, 2017 at 7:35 AM, Petri Savolainen wrote: > Lookup modes are per SA and thus may be used in a mix. Spi_overlap > parameter is global. So, removed comment about ignoring it in > LOOKUP_SPI mode. > > Signed-off-by: Petri Savolainen

Re: [lng-odp] [API-NEXT PATCH v2 07/16] test: odp_scheduling: Handle dequeueing from a concurrent queue

2017-04-07 Thread Ola Liljedahl
On 7 April 2017 at 01:33, Bill Fischofer wrote: > On Thu, Apr 6, 2017 at 1:51 PM, Maxim Uvarov > wrote: > > On 04/06/17 13:35, Ola Liljedahl wrote: > >> On 5 April 2017 at 23:39, Maxim Uvarov wrote: > >>> On 04/05/17

[lng-odp] [API-NEXT PATCH] api: ipsec: spi_overlap and lookup modes

2017-04-07 Thread Petri Savolainen
Lookup modes are per SA and thus may be used in a mix. Spi_overlap parameter is global. So, removed comment about ignoring it in LOOKUP_SPI mode. Signed-off-by: Petri Savolainen --- include/odp/api/spec/ipsec.h | 4 +--- 1 file changed, 1 insertion(+), 3

Re: [lng-odp] [PATCH] validation: scheduler: Release context before the end of the scheduler test

2017-04-07 Thread Ola Liljedahl
On 7 April 2017 at 14:06, Savolainen, Petri (Nokia - FI/Espoo) < petri.savolai...@nokia-bell-labs.com> wrote: > > > From: Kevin Wang [mailto:kevin.w...@linaro.org] > Sent: Friday, April 07, 2017 11:45 AM > To: Savolainen, Petri (Nokia - FI/Espoo) < petri.savolai...@nokia-bell-labs.com> > Cc: Kevin

Re: [lng-odp] [PATCH] validation: scheduler: Release context before the end of the scheduler test

2017-04-07 Thread Savolainen, Petri (Nokia - FI/Espoo)
From: Kevin Wang [mailto:kevin.w...@linaro.org] Sent: Friday, April 07, 2017 11:45 AM To: Savolainen, Petri (Nokia - FI/Espoo) Cc: Kevin Wang ; lng-odp@lists.linaro.org Subject: Re: [lng-odp] [PATCH] validation: scheduler: Release

Re: [lng-odp] [API-NEXT PATCH] validation: pktio: remove CRCs from parser test packets

2017-04-07 Thread Savolainen, Petri (Nokia - FI/Espoo)
Reviewed-and-tested-by: Petri Savolainen Currently make check (api-next) fails on the parser test (tap pktio) in my system. This patch corrects that. Please merge soon. -Petri > -Original Message- > From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org]

Re: [lng-odp] [API-NEXT] API: IPSEC: Updating ipsec APIs to support sNIC implementation.

2017-04-07 Thread Verma, Shally
-Original Message- From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of Nikhil Agarwal Sent: 07 April 2017 15:30 To: lng-odp@lists.linaro.org Subject: [lng-odp] [API-NEXT] API: IPSEC: Updating ipsec APIs to support sNIC implementation. Signed-off-by: Nikhil Agarwal

Re: [lng-odp] [API-NEXT] API: IPSEC: Updating ipsec APIs to support sNIC implementation.

2017-04-07 Thread Dmitry Eremin-Solenikov
On 07.04.2017 13:00, Nikhil Agarwal wrote: > +typedef union odp_ipsec_protocols_t { > + /** Cipher algorithms */ > + struct { > + /** ODP_IPSEC_ESP */ > + uint32_t esp: 1; > + > + /** ODP_IPSEC_AH */ > + uint32_t ah : 1;

Re: [lng-odp] [RFC, API-NEXT v1 1/1] comp:compression interface

2017-04-07 Thread Verma, Shally
We are sharing an Overview document of patch V1 based comp interface https://docs.google.com/document/d/1aaEo8oTvZvm2096GJzl165L571tcsKqfcaD5yypiiCA/edit?usp=sharing . It outlines possible applications, expected API usage and few key points. Please give your suggestions/comment w.r.t this to

[lng-odp] [API-NEXT] API: IPSEC: Updating ipsec APIs to support sNIC implementation.

2017-04-07 Thread Nikhil Agarwal
Signed-off-by: Nikhil Agarwal --- include/odp/api/spec/ipsec.h | 62 +++- 1 file changed, 26 insertions(+), 36 deletions(-) diff --git a/include/odp/api/spec/ipsec.h b/include/odp/api/spec/ipsec.h index b3dc0ca..d39e65d 100644

[lng-odp] [API-NEXT PATCH] abi: event: add ODP_EVENT_IPSEC_STATUS

2017-04-07 Thread Janne Peltonen
Update ABI spec with the new IPsec event type. Signed-off-by: Janne Peltonen --- include/odp/arch/default/api/abi/event.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/include/odp/arch/default/api/abi/event.h

Re: [lng-odp] [PATCH] Miss an unlock operation before exit if error happens

2017-04-07 Thread Kevin Wang
Yes, will correct it in the next patch set. Kevin 2017-04-07 16:16 GMT+08:00 Yi He : > Hi, Kevin > > 1) single patch (bug fix) may not require cover letter (community please > suggest if I misunderstands). > 2) submit message typically composed like: > linux-gen: pktio:

Re: [lng-odp] [PATCH] validation: scheduler: Release context before the end of the scheduler test

2017-04-07 Thread Kevin Wang
​1.Release context is just to be added for scalable scheduler in scheduler_test_groups(). I think it does no harms to other scheduler here. 2.This code is to be removed for the scalable scheduler, We use ring buffer to implement the queue. So it is possible the enqueue operation failed if the ring

Re: [lng-odp] [PATCH] Use different name to create pool and queue

2017-04-07 Thread Kevin Wang
1. There is just a single patch, so maybe cover letter is not needed. Will correct it in the next patchset. 2. I may understand your concern. So I'll see if we can just less shm block for multi-queue. 3. We create shm block in pool using this name,and if we use this same name to create the queue

Re: [lng-odp] [PATCH] validation: scheduler: Release context before the end of the scheduler test

2017-04-07 Thread Savolainen, Petri (Nokia - FI/Espoo)
> -Original Message- > From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of Kevin > Wang > Sent: Friday, April 07, 2017 11:07 AM > To: lng-odp@lists.linaro.org > Cc: Kevin Wang > Subject: [lng-odp] [PATCH] validation: scheduler: Release context before

Re: [lng-odp] [PATCH] Miss an unlock operation before exit if error happens

2017-04-07 Thread Yi He
Hi, Kevin 1) single patch (bug fix) may not require cover letter (community please suggest if I misunderstands). 2) submit message typically composed like: linux-gen: pktio: loop: 3) then when you git format-patch you will get email subject reflect the first line [lng-odp]

Re: [lng-odp] [PATCH] Use different name to create pool and queue

2017-04-07 Thread Savolainen, Petri (Nokia - FI/Espoo)
First, should this patch be a part of a series with a cover letter subject "Avoid shm namespace collisions and allow shmblock per queue". Now everything is just separate patches - including the cover letter. Please, use format-patch command to create the series. > -Original

[lng-odp] [PATCH] validation: scheduler: Release context before the end of the scheduler test

2017-04-07 Thread Kevin Wang
If the scheduler sync type is atomic or ordered, need to release the context. Signed-off-by: Kevin Wang Reviewed-by: Ola Liljedahl --- .../common_plat/validation/api/scheduler/scheduler.c | 20 +++- 1 file changed, 11 insertions(+), 9

Re: [lng-odp] [PATCH 1/2] add queue size param and related capability

2017-04-07 Thread Savolainen, Petri (Nokia - FI/Espoo)
See my patch series: [PATCH v3 1/2] api: queue: added queue size param > -Original Message- > From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of > Honnappa Nagarahalli > Sent: Friday, April 07, 2017 7:07 AM > To: lng-odp@lists.linaro.org > Subject: [lng-odp] [PATCH 1/2]

[lng-odp] [PATCH] Relax assert check for enqueue failures for scalable scheduler

2017-04-07 Thread Kevin Wang
Kevin Wang (1): Relax the assert check with enqueue fails in the scheduler test case test/common_plat/validation/api/scheduler/scheduler.c | 1 - 1 file changed, 1 deletion(-) -- 2.7.4

[lng-odp] [PATCH] Use different name to create pool and queue

2017-04-07 Thread Kevin Wang
Scalable scheduler requires to allocate shm memory for each queue. This patch is to avoid shm namespace collisions and allow shm block per queue. Signed-off-by: Kevin Wang Reviewed-by: Ola Liljedahl Reviewed-by: Brian Brooks

Re: [lng-odp] [API-NEXT PATCH v2 00/16] A scalable software scheduler

2017-04-07 Thread Peltonen, Janne (Nokia - FI/Espoo)
Hi, On Thu, Apr 6, 2017 at 1:46 PM, Bill Fischofer wrote: > On Thu, Apr 6, 2017 at 1:32 PM, Ola Liljedahl > wrote: > > On 6 April 2017 at 13:48, Jerin Jacob > > wrote: > >> We see ORDERED->ATOMIC as main

[lng-odp] [PATCH] Avoid shm namespace collisions and allow shm block per queue

2017-04-07 Thread Kevin Wang
Kevin Wang (1): Use different name to create pool and queue .../linux-generic/include/odp_config_internal.h| 2 +- .../api/classification/odp_classification_basic.c | 8 ++--- .../classification/odp_classification_test_pmr.c | 42 +++---