[jira] [Comment Edited] (LOG4J2-811) SimpleLogger throws ArrayIndexOutOfBoundsException for an empty array

2014-09-02 Thread Remko Popma (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14119372#comment-14119372 ] Remko Popma edited comment on LOG4J2-811 at 9/3/14 6:38 AM: Hm

[jira] [Commented] (LOG4J2-811) SimpleLogger throws ArrayIndexOutOfBoundsException for an empty array

2014-09-02 Thread Yogesh Rao (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14119431#comment-14119431 ] Yogesh Rao commented on LOG4J2-811: --- Gary has beaten me in the race to fix this defect ;

[jira] [Comment Edited] (LOG4J2-811) SimpleLogger throws ArrayIndexOutOfBoundsException for an empty array

2014-09-02 Thread Remko Popma (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14119419#comment-14119419 ] Remko Popma edited comment on LOG4J2-811 at 9/3/14 6:06 AM: As

[jira] [Commented] (LOG4J2-811) SimpleLogger throws ArrayIndexOutOfBoundsException for an empty array

2014-09-02 Thread Remko Popma (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14119419#comment-14119419 ] Remko Popma commented on LOG4J2-811: Assigned to Gary since he is working on this - I

[jira] [Assigned] (LOG4J2-811) SimpleLogger throws ArrayIndexOutOfBoundsException for an empty array

2014-09-02 Thread Remko Popma (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-811?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Remko Popma reassigned LOG4J2-811: -- Assignee: Gary Gregory > SimpleLogger throws ArrayIndexOutOfBoundsException for an empty array

Re: git commit emails

2014-09-02 Thread Gary Gregory
On Wed, Sep 3, 2014 at 1:52 AM, Ralph Goers wrote: > Found the link I was thinking of - > https://git-wip-us.apache.org/docs/commit-emails.html > > Ah, yes! I could not find this link. Since hooks are not git cloned, it sounds like we need to ask infra... Gary Ralph > > > On Sep 2, 2014, at 8:

Re: log4j-streams and ExtendedLoggers

2014-09-02 Thread Gary Gregory
On Wed, Sep 3, 2014 at 1:46 AM, Ralph Goers wrote: > The only part about this that bothers me is that it makes the DataSource > attached to the JDBC appender “special”. > JDBC is special because it is part of the JRE. What other JRE classes configure their logging with a PrintWriter or PrintStre

Re: git commit emails

2014-09-02 Thread Ralph Goers
Found the link I was thinking of - https://git-wip-us.apache.org/docs/commit-emails.html Ralph On Sep 2, 2014, at 8:00 PM, Remko Popma wrote: > I agree. I'm having trouble keeping up... :-) > > Sent from my iPhone > > On 2014/09/03, at 11:37, Ralph Goers wrote: > >> Yes. I recall seeing so

[jira] [Commented] (LOG4J2-811) SimpleLogger throws ArrayIndexOutOfBoundsException for an empty array

2014-09-02 Thread Yogesh Rao (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14119406#comment-14119406 ] Yogesh Rao commented on LOG4J2-811: --- Also notice org.apache.logging.log4j.TestLogger als

[jira] [Commented] (LOG4J2-811) SimpleLogger throws ArrayIndexOutOfBoundsException for an empty array

2014-09-02 Thread Yogesh Rao (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14119402#comment-14119402 ] Yogesh Rao commented on LOG4J2-811: --- would a unit test be required ? > SimpleLogger thr

[jira] [Resolved] (LOG4J2-811) SimpleLogger throws ArrayIndexOutOfBoundsException for an empty array

2014-09-02 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-811?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Gregory resolved LOG4J2-811. - Resolution: Fixed Fix Version/s: 2.1 Fixed in master. > SimpleLogger throws ArrayIndexOutO

[jira] [Comment Edited] (LOG4J2-811) SimpleLogger throws ArrayIndexOutOfBoundsException for an empty array

2014-09-02 Thread Yogesh Rao (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14119396#comment-14119396 ] Yogesh Rao edited comment on LOG4J2-811 at 9/3/14 5:48 AM: --- Also

[jira] [Commented] (LOG4J2-811) SimpleLogger throws ArrayIndexOutOfBoundsException for an empty array

2014-09-02 Thread Yogesh Rao (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14119396#comment-14119396 ] Yogesh Rao commented on LOG4J2-811: --- Also consider the case where the logging is done pr

[jira] [Comment Edited] (LOG4J2-811) SimpleLogger throws ArrayIndexOutOfBoundsException for an empty array

2014-09-02 Thread Yogesh Rao (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14119396#comment-14119396 ] Yogesh Rao edited comment on LOG4J2-811 at 9/3/14 5:46 AM: --- Also

Re: log4j-streams and ExtendedLoggers

2014-09-02 Thread Ralph Goers
The only part about this that bothers me is that it makes the DataSource attached to the JDBC appender “special”. What about other DataSources? What about other classes that want to use a PrintWriter or PrintStream? It would seem like you would want to register those as well and then be able

Re: log4j-streams and ExtendedLoggers

2014-09-02 Thread Ralph Goers
We handle recursion. Ralph On Sep 2, 2014, at 9:22 PM, Matt Sicker wrote: > They'd have to use a different Appender than the JDBC one for that, though, > or I think that may start some sort of logging feedback loop. > > > On 2 September 2014 23:12, Gary Gregory wrote: > On Wed, Sep 3, 2014

[jira] [Commented] (LOG4J2-811) SimpleLogger throws ArrayIndexOutOfBoundsException for an empty array

2014-09-02 Thread Yogesh Rao (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14119381#comment-14119381 ] Yogesh Rao commented on LOG4J2-811: --- IMO logging should never fail ... we wouldnt like a

[jira] [Updated] (LOG4J2-811) SimpleLogger throws ArrayIndexOutOfBoundsException for an empty array

2014-09-02 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-811?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Gregory updated LOG4J2-811: Summary: SimpleLogger throws ArrayIndexOutOfBoundsException for an empty array (was: SimpleLogger I

[jira] [Updated] (LOG4J2-811) SimpleLogger Implementation Issue for var args method's

2014-09-02 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-811?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Gregory updated LOG4J2-811: Summary: SimpleLogger Implementation Issue for var args method's (was: Log4j2's SimpleLogger Implem

[jira] [Commented] (LOG4J2-811) Log4j2's SimpleLogger Implementation Issue for var args method's

2014-09-02 Thread Remko Popma (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14119372#comment-14119372 ] Remko Popma commented on LOG4J2-811: Hm... If we check and we find that the applicatio

Re: org.apache.logging.log4j.streams.util

2014-09-02 Thread Gary Gregory
On Wed, Sep 3, 2014 at 12:32 AM, Matt Sicker wrote: > They almost seem like SPI classes in a sense of how the JDK categorizes > things sometimes. I wouldn't mind flattening them. They're all of equal > importance. > Done. I'm going to sleep now (1am here) but one thing you can look at Matt (or

[jira] [Created] (LOG4J2-811) Log4j2's SimpleLogger Implementation Issue for var args method's

2014-09-02 Thread Yogesh Rao (JIRA)
Yogesh Rao created LOG4J2-811: - Summary: Log4j2's SimpleLogger Implementation Issue for var args method's Key: LOG4J2-811 URL: https://issues.apache.org/jira/browse/LOG4J2-811 Project: Log4j 2 I

Re: git commit: Refactor LoggerOutputStream into two classes: LoggerOutputStream and LoggerFilterOutputStream. The old LoggerOutputStream is like the new LoggerFilterOutputStream which subclasses Filt

2014-09-02 Thread Gary Gregory
On Wed, Sep 3, 2014 at 12:33 AM, Matt Sicker wrote: > Kind of like the javadoc summaries. > Exactly! :-) Gary > It's just a quick indexOf()-style operation, though. Would be useful. > > > On 2 September 2014 23:00, Gary Gregory wrote: > >> Hmm... Or the git hook could be _smarter_ and parse

Re: git commit: Refactor LoggerOutputStream into two classes: LoggerOutputStream and LoggerFilterOutputStream. The old LoggerOutputStream is like the new LoggerFilterOutputStream which subclasses Filt

2014-09-02 Thread Matt Sicker
Kind of like the javadoc summaries. It's just a quick indexOf()-style operation, though. Would be useful. On 2 September 2014 23:00, Gary Gregory wrote: > Hmm... Or the git hook could be _smarter_ and parse out the first > sentence, say up to the first period. Formatting comments is just a pain

Re: org.apache.logging.log4j.streams.util

2014-09-02 Thread Matt Sicker
They almost seem like SPI classes in a sense of how the JDK categorizes things sometimes. I wouldn't mind flattening them. They're all of equal importance. On 2 September 2014 09:54, Gary Gregory wrote: > Any thoughts on folding the two classes in > > org.apache.logging.log4j.streams.util > > b

Re: log4j-streams and ExtendedLoggers

2014-09-02 Thread Matt Sicker
They'd have to use a different Appender than the JDBC one for that, though, or I think that may start some sort of logging feedback loop. On 2 September 2014 23:12, Gary Gregory wrote: > On Wed, Sep 3, 2014 at 12:04 AM, Remko Popma > wrote: > >> >> On 2014/09/03, at 12:00, Gary Gregory wrote:

Re: log4j-streams and ExtendedLoggers

2014-09-02 Thread Gary Gregory
On Wed, Sep 3, 2014 at 12:04 AM, Remko Popma wrote: > > On 2014/09/03, at 12:00, Gary Gregory wrote: > > Yes, the config creates the loggers, but something has to tell Log4j to > call DriverManager.setLogWriter(). > > > I can see how it would be nice if this can be done in the log4j config, > bu

Re: log4j-streams and ExtendedLoggers

2014-09-02 Thread Remko Popma
> On 2014/09/03, at 12:00, Gary Gregory wrote: > > Yes, the config creates the loggers, but something has to tell Log4j to call > DriverManager.setLogWriter(). I can see how it would be nice if this can be done in the log4j config, but since it's one line of code I think it's ok if the app d

Re: git commit: Refactor LoggerOutputStream into two classes: LoggerOutputStream and LoggerFilterOutputStream. The old LoggerOutputStream is like the new LoggerFilterOutputStream which subclasses Filt

2014-09-02 Thread Gary Gregory
Hmm... Or the git hook could be _smarter_ and parse out the first sentence, say up to the first period. Formatting comments is just a pain IMO. Gary On Tue, Sep 2, 2014 at 11:41 PM, Matt Sicker wrote: > This is why I make the first line of my commits really short. So it fits > in the email sub

Re: log4j-streams and ExtendedLoggers

2014-09-02 Thread Gary Gregory
Since JDBC is in the JRE and a common API I thought it might deserve special treatment. We already support configuring a data source, for example: could become: where OFF is the default level and default logger

Fwd: git commit: Refactor LoggerOutputStream into two classes: LoggerOutputStream and LoggerFilterOutputStream. The old LoggerOutputStream is like the new LoggerFilterOutputStream which subclasses Fil

2014-09-02 Thread Matt Sicker
This is why I make the first line of my commits really short. So it fits in the email subject! Now that the git emails do this, it might be a good habit to get into. ;) Commit style: Add some new thing. - Some more details. - Doesn't really need to be a list like this, I'm just used to chang

Re: log4j-streams and ExtendedLoggers

2014-09-02 Thread Matt Sicker
Wouldn't people normally use something like Spring, Guice, or OSGi to do that? I mean, we could add support for that, but it would certainly be an interesting plugin to create. We're not recreating xbean here, right? On 2 September 2014 22:00, Gary Gregory wrote: > Yes, the config creates the l

Re: log4j-streams module name

2014-09-02 Thread Remko Popma
I'm ok with log4j-streams and log4j-iostreams. Sent from my iPhone > On 2014/09/03, at 11:41, Ralph Goers wrote: > > Much better > > Sent from my iPad > >> On Sep 2, 2014, at 7:37 PM, Matt Sicker wrote: >> >> Maybe log4j-iostreams? >> >> >>> On 2 September 2014 21:35, Gary Gregory wrote

Re: git commit emails

2014-09-02 Thread Remko Popma
I agree. I'm having trouble keeping up... :-) Sent from my iPhone > On 2014/09/03, at 11:37, Ralph Goers wrote: > > Yes. I recall seeing somewhere that there were a few choices for the subject > line > > Sent from my iPad > >> On Sep 2, 2014, at 7:31 PM, Gary Gregory wrote: >> >> I'd like

Re: log4j-streams and ExtendedLoggers

2014-09-02 Thread Gary Gregory
Yes, the config creates the loggers, but something has to tell Log4j to call DriverManager.setLogWriter(). Gary On Tue, Sep 2, 2014 at 10:55 PM, Matt Sicker wrote: > Wouldn't the XML just configure the Logger itself? The streams are all > adapters. > > > On 2 September 2014 21:42, Gary Gregory

Re: Byte buffer message

2014-09-02 Thread Remko Popma
Yes I'm very interested in this topic. If I understand Gary correctly, he needs a way for the application to pass byte arrays to the logger, and output these byte arrays as text in hexadecimal format. https://issues.apache.org/jira/plugins/servlet/mobile#issue/LOG4J2-506 contains some work i

Re: log4j-streams and ExtendedLoggers

2014-09-02 Thread Matt Sicker
Wouldn't the XML just configure the Logger itself? The streams are all adapters. On 2 September 2014 21:42, Gary Gregory wrote: > On Tue, Sep 2, 2014 at 10:37 PM, Matt Sicker wrote: > >> DriverManager.setLogWriter(LoggerStreams.forLogger(DriverManager.class).atLevel(Level.DEBUG)); >> or someth

[jira] [Assigned] (LOG4J2-807) Disruptor is null when configuration is reloaded (asyncRoot + monitorInterval)

2014-09-02 Thread Remko Popma (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-807?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Remko Popma reassigned LOG4J2-807: -- Assignee: Remko Popma > Disruptor is null when configuration is reloaded (asyncRoot + monitorIn

Re: log4j-streams and ExtendedLoggers

2014-09-02 Thread Gary Gregory
On Tue, Sep 2, 2014 at 10:37 PM, Matt Sicker wrote: > DriverManager.setLogWriter(LoggerStreams.forLogger(DriverManager.class).atLevel(Level.DEBUG)); > or something like that > > Then you'd just configure the "java.sql.DriverManager" logger. > Yes, but what in the XML config triggers this code?

Re: log4j-streams module name

2014-09-02 Thread Ralph Goers
Much better Sent from my iPad > On Sep 2, 2014, at 7:37 PM, Matt Sicker wrote: > > Maybe log4j-iostreams? > > >> On 2 September 2014 21:35, Gary Gregory wrote: >> Yeah, plain 'streams' is not great. Let's see... we are talking about >> java.io classes that are OutputStreams, InputStreams, W

Re: log4j-streams module name

2014-09-02 Thread Ralph Goers
Hate them all but nothing good pops to mind right now. Frankly, I find the "streams" in java 8 a confusing term. When I looked at it I was reminded of Cocoon pipelines. I wish they had used that term instead. Sent from my iPad > On Sep 2, 2014, at 7:35 PM, Gary Gregory wrote: > > Yeah, pla

Re: log4j-streams module name

2014-09-02 Thread Matt Sicker
Maybe log4j-iostreams? On 2 September 2014 21:35, Gary Gregory wrote: > Yeah, plain 'streams' is not great. Let's see... we are talking about > java.io classes that are OutputStreams, InputStreams, Writers, and > Readers. > > - log4j-java.io >Can you have a . in a module name like that with

Re: log4j-streams and ExtendedLoggers

2014-09-02 Thread Matt Sicker
DriverManager.setLogWriter(LoggerStreams.forLogger(DriverManager.class).atLevel(Level.DEBUG)); or something like that Then you'd just configure the "java.sql.DriverManager" logger. On 2 September 2014 21:30, Gary Gregory wrote: > Let's _also_ look at the JDBC use cases from a configuration POV

Re: git commit emails

2014-09-02 Thread Gary Gregory
Well, there is already something in [ and ] so maybe for easier mailbox rules: - b=BRANCH_NAME - branch=BRANCH_NAME - ? Gary On Tue, Sep 2, 2014 at 10:34 PM, Matt Sicker wrote: > That would be nice. Like "[branch] summary"? > > > On 2 September 2014 21:31, Gary Gregory wrote: > >> I'd like to

Re: git commit emails

2014-09-02 Thread Ralph Goers
Yes. I recall seeing somewhere that there were a few choices for the subject line Sent from my iPad > On Sep 2, 2014, at 7:31 PM, Gary Gregory wrote: > > I'd like to see in the _subject_ of git commit emails, the branch name. > > Any one else? > > Gary > > -- > E-Mail: garydgreg...@gmail.c

Re: log4j-streams module name

2014-09-02 Thread Gary Gregory
Yeah, plain 'streams' is not great. Let's see... we are talking about java.io classes that are OutputStreams, InputStreams, Writers, and Readers. - log4j-java.io Can you have a . in a module name like that without causing confusion, it kinda looks weird but it the best IMO. - log4j-javaio - log

Re: git commit emails

2014-09-02 Thread Matt Sicker
That would be nice. Like "[branch] summary"? On 2 September 2014 21:31, Gary Gregory wrote: > I'd like to see in the _subject_ of git commit emails, the branch name. > > Any one else? > > Gary > > -- > E-Mail: garydgreg...@gmail.com | ggreg...@apache.org > Java Persistence with Hibernate, Secon

git commit emails

2014-09-02 Thread Gary Gregory
I'd like to see in the _subject_ of git commit emails, the branch name. Any one else? Gary -- E-Mail: garydgreg...@gmail.com | ggreg...@apache.org Java Persistence with Hibernate, Second Edition JUnit in Action, Second Edition

Re: log4j-streams and ExtendedLoggers

2014-09-02 Thread Gary Gregory
Let's _also_ look at the JDBC use cases from a configuration POV. What should my XML config look like to say: (1) Redirect all JDBC logging to DEBUG (or any level). At the low level, that means: java.sql.DriverManager. setLogWriter(new LoggerPrintWriter((*ExtendedLogger*) LogManager.getLogger(),

Re: log4-streams plan

2014-09-02 Thread Gary Gregory
OK, great. Let's plan on 2.1 next with log4-streams! Gary On Tue, Sep 2, 2014 at 9:22 PM, Matt Sicker wrote: > I'm totally OK with doing more rapid releases like that. Log4j 1 only got > up to 1.2, but I can see us being a bit more agile here. > > > On 2 September 2014 19:34, Gary Gregory wro

Re: Small addition to API suggestion.

2014-09-02 Thread Matt Sicker
I'm going to refactor the LoggerAdapter class a bit as some of its methods make more sense as protected abstract methods instead. I may end up renaming it again if a more apparent design pattern emerges. On 2 September 2014 00:12, Matt Sicker wrote: > Seeing how common of a pattern it is, I thi

Re: log4j-streams module name

2014-09-02 Thread Matt Sicker
Using the name "streams" might be confusing the Java 1.8 streams (aka lazily evaluated functions/map-reduce). I'd almost suggest javaio or jio or something similar to emphasise the compatibility. On 2 September 2014 09:22, Gary Gregory wrote: > Should the new module name/ID be: > > - log4j-stre

Re: log4j-streams and ExtendedLoggers

2014-09-02 Thread Matt Sicker
We could make a LogManager-style class that's only used for streams. The LoggerStreams class looks like a good candidate, but due to the lack of javadocs anywhere, I'm not sure what anything does anymore! Well, anything that isn't an override of all the java.io methods. Is it required that all Log

Re: log4-streams plan

2014-09-02 Thread Matt Sicker
I'm totally OK with doing more rapid releases like that. Log4j 1 only got up to 1.2, but I can see us being a bit more agile here. On 2 September 2014 19:34, Gary Gregory wrote: > All of this sounds pretty big-bang-ish to me (not in the good sense), but, > I do appreciate the work :-) and I lik

Re: log4j-streams and ExtendedLoggers

2014-09-02 Thread Gary Gregory
Matt and all: Please review *log4j-streams *in master. The current nasty is this the required type cast to *ExtendedLogger*: java.sql.DriverManager.setLogWriter(new LoggerPrintWriter((*ExtendedLogger*) LogManager.getLogger(), Level.DEBUG)); Internally, *LogManager.getLogger()* uses an *Extended

Re: log4-streams plan

2014-09-02 Thread Gary Gregory
All of this sounds pretty big-bang-ish to me (not in the good sense), but, I do appreciate the work :-) and I like what we are doing. Here is an alternative, based on RERO and Matt's avail as an RM. 2.1 adds log4j-streams 2.2 adds JUL (if we like it, which I know we will :-) 2.3 adds the JMS refa

Re: log4j-streams and ExtendedLoggers

2014-09-02 Thread Gary Gregory
I'm almost done, I'll commit, please review... Gary On Tue, Sep 2, 2014 at 7:53 PM, Matt Sicker wrote: > Yeah I think I can take care of that tonight. > > > On 2 September 2014 14:41, Gary Gregory wrote: > >> Matt, >> >> Do you have time for that today? >> >> Gary >> >> >> Original m

Re: [2/4] git commit: Migrate more methods from Loader to LoaderUtil.

2014-09-02 Thread Matt Sicker
http://logging.apache.org/log4j/2.x/manual/configuration.html#SystemProperties The current value is indeed the TCL version. I just migrated it. Perhaps both properties should be supported? On 2 September 2014 10:32, Gary Gregory wrote: > WRT: > > > > +public static final String IGNORE_TCCL_

Re: Byte buffer message

2014-09-02 Thread Matt Sicker
Wouldn't a Layout make more sense for the output format? And a byte buffer message would be nice. We can support byte[] by using ByteBuffer.wrap() and keeping things consistent. This could also work well with Remko's ideas for garbage-free binary logging. I'd like to hear what he was thinking about

Re: log4-streams plan

2014-09-02 Thread Matt Sicker
I think it might be beneficial to include the PrintWriter and PrintStream classes in the API. However, it's not completely necessary. If we're going to do a 2.1 release sooner rather than later, then there's no point in making another 2.0.x release. It would be nice to get some of the new features

Re: log4j-streams and ExtendedLoggers

2014-09-02 Thread Matt Sicker
Yeah I think I can take care of that tonight. On 2 September 2014 14:41, Gary Gregory wrote: > Matt, > > Do you have time for that today? > > Gary > > > Original message > From: Matt Sicker > Date:09/02/2014 14:20 (GMT-05:00) > To: Log4J Developers List > Subject: Re: log4j-st

[jira] [Comment Edited] (LOG4J2-808) RegexFilter does not work properly with RollingFileAppenders

2014-09-02 Thread Ralph Goers (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14118841#comment-14118841 ] Ralph Goers edited comment on LOG4J2-808 at 9/2/14 10:25 PM: -

[jira] [Commented] (LOG4J2-808) RegexFilter does not work properly with RollingFileAppenders

2014-09-02 Thread Ralph Goers (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14118841#comment-14118841 ] Ralph Goers commented on LOG4J2-808: I definitely don't understand what you are trying

[jira] [Commented] (LOG4J2-808) RegexFilter does not work properly with RollingFileAppenders

2014-09-02 Thread Pranav Pratap (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14118814#comment-14118814 ] Pranav Pratap commented on LOG4J2-808: -- I understood what you meaning with initial pa

[jira] [Comment Edited] (LOG4J2-808) RegexFilter does not work properly with RollingFileAppenders

2014-09-02 Thread Ralph Goers (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14118794#comment-14118794 ] Ralph Goers edited comment on LOG4J2-808 at 9/2/14 9:33 PM: So

[jira] [Commented] (LOG4J2-808) RegexFilter does not work properly with RollingFileAppenders

2014-09-02 Thread Ralph Goers (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14118794#comment-14118794 ] Ralph Goers commented on LOG4J2-808: So you are saying that you want to essentially dy

[jira] [Commented] (LOG4J2-808) RegexFilter does not work properly with RollingFileAppenders

2014-09-02 Thread Pranav Pratap (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14118781#comment-14118781 ] Pranav Pratap commented on LOG4J2-808: -- In the log if you do not apply the regex filt

[jira] [Commented] (LOG4J2-808) RegexFilter does not work properly with RollingFileAppenders

2014-09-02 Thread Ralph Goers (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14118749#comment-14118749 ] Ralph Goers commented on LOG4J2-808: In a Filter the 3 outcomes are: ACCEPT - log even

[jira] [Comment Edited] (LOG4J2-808) RegexFilter does not work properly with RollingFileAppenders

2014-09-02 Thread Ralph Goers (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14118642#comment-14118642 ] Ralph Goers edited comment on LOG4J2-808 at 9/2/14 8:52 PM: Hi

[jira] [Comment Edited] (LOG4J2-808) RegexFilter does not work properly with RollingFileAppenders

2014-09-02 Thread Pranav Pratap (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14118642#comment-14118642 ] Pranav Pratap edited comment on LOG4J2-808 at 9/2/14 8:10 PM: --

[jira] [Updated] (LOG4J2-808) RegexFilter does not work properly with RollingFileAppenders

2014-09-02 Thread Pranav Pratap (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-808?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pranav Pratap updated LOG4J2-808: - Attachment: log4j2.xml MainApp.java HelloWorld.java PFA new code

[jira] [Commented] (LOG4J2-808) RegexFilter does not work properly with RollingFileAppenders

2014-09-02 Thread Pranav Pratap (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14118642#comment-14118642 ] Pranav Pratap commented on LOG4J2-808: -- Hi, I tried the way you suggested and it wor

Re: log4j-streams and ExtendedLoggers

2014-09-02 Thread Gary Gregory
Matt, Do you have time for that today? Gary Original message From: Matt Sicker Date:09/02/2014 14:20 (GMT-05:00) To: Log4J Developers List Subject: Re: log4j-streams and ExtendedLoggers Yeah I think that'd be a good idea. On 2 September 2014 09:49, Gary Gregory wrote:

[jira] [Updated] (LOG4J2-808) RegexFilter does not work properly with RollingFileAppenders

2014-09-02 Thread Pranav Pratap (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-808?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pranav Pratap updated LOG4J2-808: - Attachment: (was: MainApp.java) > RegexFilter does not work properly with RollingFileAppenders

[jira] [Updated] (LOG4J2-808) RegexFilter does not work properly with RollingFileAppenders

2014-09-02 Thread Pranav Pratap (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-808?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pranav Pratap updated LOG4J2-808: - Attachment: (was: CompanyBusiness.java) > RegexFilter does not work properly with RollingFileA

[jira] [Updated] (LOG4J2-808) RegexFilter does not work properly with RollingFileAppenders

2014-09-02 Thread Pranav Pratap (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-808?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pranav Pratap updated LOG4J2-808: - Attachment: (was: CompanyBusinessImpl.java) > RegexFilter does not work properly with RollingF

[jira] [Updated] (LOG4J2-808) RegexFilter does not work properly with RollingFileAppenders

2014-09-02 Thread Pranav Pratap (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-808?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pranav Pratap updated LOG4J2-808: - Attachment: (was: Company.java) > RegexFilter does not work properly with RollingFileAppenders

[jira] [Updated] (LOG4J2-808) RegexFilter does not work properly with RollingFileAppenders

2014-09-02 Thread Pranav Pratap (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-808?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pranav Pratap updated LOG4J2-808: - Attachment: (was: els3.log) > RegexFilter does not work properly with RollingFileAppenders >

[jira] [Updated] (LOG4J2-808) RegexFilter does not work properly with RollingFileAppenders

2014-09-02 Thread Pranav Pratap (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-808?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pranav Pratap updated LOG4J2-808: - Attachment: (was: log4j2.xml) > RegexFilter does not work properly with RollingFileAppenders

[jira] [Updated] (LOG4J2-808) RegexFilter does not work properly with RollingFileAppenders

2014-09-02 Thread Pranav Pratap (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-808?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pranav Pratap updated LOG4J2-808: - Attachment: (was: HelloWorld.java) > RegexFilter does not work properly with RollingFileAppend

Re: log4j-streams and ExtendedLoggers

2014-09-02 Thread Matt Sicker
Yeah I think that'd be a good idea. On 2 September 2014 09:49, Gary Gregory wrote: > So... should retype all of the methods that cast to ExtendedLogger and in > turn their call sites? > > Gary > > > On Tue, Sep 2, 2014 at 10:22 AM, Matt Sicker wrote: > >> This was written before all that was d

Re: log4-streams plan

2014-09-02 Thread Ralph Goers
Yes, I would prefer that we make that decision before it is released. Ralph On Sep 2, 2014, at 9:27 AM, Gary Gregory wrote: > On Tue, Sep 2, 2014 at 12:17 PM, Ralph Goers > wrote: > OK - I ask because it was previously suggested that it just become integrated > with the API. As I said, makin

Re: Byte buffer message

2014-09-02 Thread Ralph Goers
The “best way”? That depends on what you want. If you only want some messages hex dumped and want that controlled in the application then use the HexDumpMessage. If you want all of them then do a HexDumpLayout. If you want to control this at runtime we might want to add the ability to choo

Re: Byte buffer message

2014-09-02 Thread Gary Gregory
Ah, yes, but then, ALL byte arrays and ByteBuffers will be hex-dumped, which should be OK. Well, this is what I am looking for, what is the best log4j2-way to do this. Gary On Tue, Sep 2, 2014 at 12:25 PM, Ralph Goers wrote: > Note that you should also be able to do this with a Layout. > > Ra

Re: log4-streams plan

2014-09-02 Thread Gary Gregory
On Tue, Sep 2, 2014 at 12:17 PM, Ralph Goers wrote: > OK - I ask because it was previously suggested that it just become > integrated with the API. As I said, making it a separate module right now > should make it easier to decide whether that is a good idea or not. > Sure, for now it's fine. On

Re: Byte buffer message

2014-09-02 Thread Ralph Goers
Note that you should also be able to do this with a Layout. Ralph On Sep 2, 2014, at 9:17 AM, Gary Gregory wrote: > On Tue, Sep 2, 2014 at 12:10 PM, Ralph Goers > wrote: > So the output from a ByteBufferMessage is a hex dump of the data? > > Yes, with formatting options. Whether we pin it

Re: Byte buffer message

2014-09-02 Thread Gary Gregory
On Tue, Sep 2, 2014 at 12:10 PM, Ralph Goers wrote: > So the output from a ByteBufferMessage is a hex dump of the data? > Yes, with formatting options. Whether we pin it to hexadecimal or allow a base to be configured is TBD. I only need hex ATM. Wouldn’t it make more sense to have a HexDumpMes

Re: log4-streams plan

2014-09-02 Thread Ralph Goers
OK - I ask because it was previously suggested that it just become integrated with the API. As I said, making it a separate module right now should make it easier to decide whether that is a good idea or not. Ralph On Sep 2, 2014, at 9:13 AM, Gary Gregory wrote: > Ralph, > > Matt merged the

Re: log4-streams plan

2014-09-02 Thread Gary Gregory
Ralph, Matt merged the code into master this weekend (the new module log4j-streams) and I've hacking on it there. Right now, it's 13 classes (which could be 14 with another refactoring) and the jar is 34,588 bytes. The 2.1-SNAPSHOT API jar is 124,401 bytes. It looks like the solution is fairly

Re: Byte buffer message

2014-09-02 Thread Ralph Goers
So the output from a ByteBufferMessage is a hex dump of the data? Wouldn’t it make more sense to have a HexDumpMessage that accepts a byte buffer or byte array or a string or whatever? Ralph On Sep 2, 2014, at 8:23 AM, Gary Gregory wrote: > Hi All: > > On every project I've worked on, at so

Re: log4-streams plan

2014-09-02 Thread Ralph Goers
Gary, How many classes is it and how much of an impact would it have on the API if it was merged there? Can you provide a link to to the branch again? Ralph On Sep 2, 2014, at 7:31 AM, Gary Gregory wrote: > Hi All: > > This is a vague plan proposal for the new log4-streams module: > > - Cl

Fwd: [2/4] git commit: Migrate more methods from Loader to LoaderUtil.

2014-09-02 Thread Gary Gregory
WRT: +public static final String IGNORE_TCCL_PROPERTY = "log4j.ignoreTCL"; Should this be: +public static final String IGNORE_TCCL_PROPERTY = "log4j.ignoreTCCL"; ? Gary -- Forwarded message -- From: Date: Tue, Sep 2, 2014 at 12:23 AM Subject: [2/4] git commit: Migra

Byte buffer message

2014-09-02 Thread Gary Gregory
Hi All: On every project I've worked on, at some point, I or someone needs to log of byte buffer (usually a byte[] but I am working a new project that uses an NIO ByteBuffer too). We do not have a Log4j ByteBufferMessage, how about adding one? That seems quite withing the scope of Log4j I would

org.apache.logging.log4j.streams.util

2014-09-02 Thread Gary Gregory
Any thoughts on folding the two classes in org.apache.logging.log4j.streams.util back into: org.apache.logging.log4j.streams They are both hard wired to an ExtendedLogger. I could see those being a Core or API util package if they are to be in one. Thoughts? Gary -- E-Mail: garydgreg...@gm

Re: log4j-streams and ExtendedLoggers

2014-09-02 Thread Gary Gregory
So... should retype all of the methods that cast to ExtendedLogger and in turn their call sites? Gary On Tue, Sep 2, 2014 at 10:22 AM, Matt Sicker wrote: > This was written before all that was done. I had to rename it from > LoggerProvider to ExtendedLogger even! > > > On 2 September 2014 09:2

[jira] [Comment Edited] (LOG4J2-807) Disruptor is null when configuration is reloaded (asyncRoot + monitorInterval)

2014-09-02 Thread Florin Marinoiu (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14118211#comment-14118211 ] Florin Marinoiu edited comment on LOG4J2-807 at 9/2/14 2:35 PM:

log4-streams plan

2014-09-02 Thread Gary Gregory
Hi All: This is a vague plan proposal for the new log4-streams module: - Clean up ALL of the current log4-streams code, add features, tweak features, remove features, bang it, tap it, test it. I do not know what is in progress in all of the classes/tests. Matt? Bruce? - Once the code is all good,

Re: NoSQL 3rd party updates

2014-09-02 Thread Matt Sicker
The JPA/EclipseLink update should be fine to test. There are a bunch of tests involving JPA and HSQL or H2 (can't remember which). As to the NoSQL ones, other than integration testing, so far we can only mock them. With something like Gora or Hazelcast or something more generic, it's possible to u

Re: log4j-streams and ExtendedLoggers

2014-09-02 Thread Matt Sicker
This was written before all that was done. I had to rename it from LoggerProvider to ExtendedLogger even! On 2 September 2014 09:21, Gary Gregory wrote: > Some of the streams API take a org.apache.logging.log4j.Logger and cast it > to an org.apache.logging.log4j.spi.ExtendedLogger. > > Why not

log4j-streams module name

2014-09-02 Thread Gary Gregory
Should the new module name/ID be: - log4j-streams - log4j-streaming - log4j- ? Gary -- E-Mail: garydgreg...@gmail.com | ggreg...@apache.org Java Persistence with Hibernate, Second Edition JUnit in Action, Second Edition Spring

  1   2   >