Re: [RFC][PATCH] Change to buffer lookup for given temporary files

2020-02-19 Thread Enrico Forestieri
On Wed, Feb 19, 2020 at 10:33:45PM +0100, Stephan Witt wrote: > > > Am 18.02.2020 um 19:55 schrieb Enrico Forestieri : > > > > On Tue, Feb 18, 2020 at 07:36:54PM +0100, Enrico Forestieri wrote: > >> On Tue, Feb 18, 2020 at 09:43:07AM +0100, Stephan Witt wrote: > >>> > >>> Because I’m unable to t

Re: lyx crashes while menu navigating to the left

2020-02-19 Thread Richard Kimberly Heck
On 2/19/20 5:23 PM, V K wrote: > > > > > > > On Wednesday, February 19, 2020, 11:36:58 PM GMT+2, V K > wrote: > > > > > > I did exactly the same as you described once more and Lyx disappeared. > Using Qt version 5.14.1 in /usr/lib. > > > > > > > On Wednesday, February 19, 2020, 10:06:32 PM GMT+2

Re: [ANNOUNCE] LyX 2.3.4.2 'Emergency' Release

2020-02-19 Thread Liviu Andronic
On 2/11/20, Richard Kimberly Heck wrote: > > This is an emergency release that fixes four bugs in 2.3.4. Only the > first two really warrant an emergency release, but while we're at it... > Ubuntu packages are now available on the PPA: https://launchpad.net/~lyx-devel/+archive/ubuntu/release Liv

Re: clang Warning: Padding Class...

2020-02-19 Thread Richard Kimberly Heck
On 2/19/20 9:56 PM, Scott Kostyshak wrote: > On Wed, Feb 19, 2020 at 05:08:47PM -0500, Richard Kimberly Heck wrote: > >> On 2/19/20 4:48 PM, Jean-Marc Lasgouttes wrote: >>> It is a good idea to have correct padding by reordering members, even if >>> the memory gains are minimal for buffer::impl .

Re: clang Warning: Padding Class...

2020-02-19 Thread Scott Kostyshak
On Wed, Feb 19, 2020 at 05:08:47PM -0500, Richard Kimberly Heck wrote: > On 2/19/20 4:48 PM, Jean-Marc Lasgouttes wrote: > > It is a good idea to have correct padding by reordering members, even if > > the memory gains are minimal for buffer::impl . Do you have that for other > > classes ? > >

Re: LaTeX3 Error: Backend request inconsistent with engine: using 'pdfmode'

2020-02-19 Thread Scott Kostyshak
On Mon, Feb 03, 2020 at 04:44:07PM +0100, Kornel Benko wrote: > Am Mon, 3 Feb 2020 10:42:06 -0500 > schrieb Scott Kostyshak : > > > On Mon, Feb 03, 2020 at 04:29:34PM +0100, Kornel Benko wrote: > > > > > > This is for instance with examples/Presentations/Foils.lyx trying to use > > > pdflatex. >

Re: Perl and Indexing? [Re: Building windows installer questions]

2020-02-19 Thread Richard Kimberly Heck
On 2/19/20 4:42 PM, Jean-Marc Lasgouttes wrote: > > Le 19 février 2020 21:11:43 GMT+01:00, Richard Kimberly Heck > a écrit : >> Actually, just saw in the change log: "install a stripped-down version >> of Perl to be able to use LyX's feature to have several indexes also >> when LyX is installed w

Re: clang Warning: Padding Class...

2020-02-19 Thread Richard Kimberly Heck
> > Le 19 février 2020 21:24:15 GMT+01:00, Richard Kimberly Heck a écrit : >> I'm seeing a lot of warnings in QtCreator of the form: >> >> Buffer.cpp:219:11: warning: padding class 'lyx::Buffer::Impl' with 3 >> bytes to align 'filename' >> >> I take it that this is because there were five bools ri

Re: clang Warning: Padding Class...

2020-02-19 Thread Jean-Marc Lasgouttes
It is a good idea to have correct padding by reordering members, even if the memory gains are minimal for buffer::impl . Do you have that for other classes ? Note that padding needs are not the same for 32bist and 64bits, and probably not the same for Linux and windows. JMarc Le 19 février 202

Re: [PATCH] Fix write to uninitialized bytes for XCB event

2020-02-19 Thread Jean-Marc Lasgouttes
Le 19 février 2020 22:25:31 GMT+01:00, Pavel Sanda a écrit : >So the oldest distro on which I regularly compile lyx master has gcc >4.8. >Because I suspect no one around is using even older config we can't >really >guarantee 4.7 (stand up if I am wrong) so we should change INSTALL >instructions

Re: Perl and Indexing? [Re: Building windows installer questions]

2020-02-19 Thread Jean-Marc Lasgouttes
Le 19 février 2020 21:11:43 GMT+01:00, Richard Kimberly Heck a écrit : >Actually, just saw in the change log: "install a stripped-down version >of Perl to be able to use LyX's feature to have several indexes also >when LyX is installed without admin privileges". I guess this must be >because on

Re: Perl and Indexing? [Re: Building windows installer questions]

2020-02-19 Thread Jean-Marc Lasgouttes
Le 19 février 2020 21:47:05 GMT+01:00, Kornel Benko a écrit : >> I'm trying to remember why LyX needs Perl on Windows. If it were >> possible to avoid it, that would be worth doing. > >Texlive has many perl scripts (in TL19 ~ 237). If it does, I guess it provides the relevant interpreter, doesn

Re: [RFC][PATCH] Change to buffer lookup for given temporary files

2020-02-19 Thread Stephan Witt
> Am 18.02.2020 um 19:55 schrieb Enrico Forestieri : > > On Tue, Feb 18, 2020 at 07:36:54PM +0100, Enrico Forestieri wrote: >> On Tue, Feb 18, 2020 at 09:43:07AM +0100, Stephan Witt wrote: >>> >>> Because I’m unable to test it with other PDF viewers with SyncTeX >>> support and/or to test it on

Re: [PATCH] Fix write to uninitialized bytes for XCB event

2020-02-19 Thread Pavel Sanda
On Wed, Feb 19, 2020 at 06:13:08PM +0100, Pavel Sanda wrote: > > We are requiring C++11 these days, right? > > Can't remember, notions of gcc 4.7 in INSTALL is not strongly indicative of > that ;) > Need to check whether one of my antique system still compiles with 4.7 or 4.8, > maybe we can bump

Re: Perl and Indexing? [Re: Building windows installer questions]

2020-02-19 Thread Kornel Benko
Am Wed, 19 Feb 2020 15:11:43 -0500 schrieb Richard Kimberly Heck : > On 2/19/20 1:01 PM, Yu Jin wrote: > >   > > Am Mi., 19. Feb. 2020 um 17:04 Uhr schrieb Richard Kimberly Heck > > mailto:rikih...@lyx.org>>: > > > > If you do update these other tools, please send me a zip of the > > depen

Re: Assertion

2020-02-19 Thread Richard Kimberly Heck
On 2/19/20 11:38 AM, Daniel wrote: > I just navigated between child documents using the outliner's Table of > Contents as a dialog appeared (attached). Any idea what this might be > about? No, that's an obscure one. The DocIterator is invalid, but why? No clue without a backtrace or a way to repro

clang Warning: Padding Class...

2020-02-19 Thread Richard Kimberly Heck
I'm seeing a lot of warnings in QtCreator of the form: Buffer.cpp:219:11: warning: padding class 'lyx::Buffer::Impl' with 3 bytes to align 'filename' I take it that this is because there were five bools right before this declaration. Do we care about this? Riki -- lyx-devel mailing list lyx-d

Perl and Indexing? [Re: Building windows installer questions]

2020-02-19 Thread Richard Kimberly Heck
On 2/19/20 1:01 PM, Yu Jin wrote: >   > Am Mi., 19. Feb. 2020 um 17:04 Uhr schrieb Richard Kimberly Heck > mailto:rikih...@lyx.org>>: > > If you do update these other tools, please send me a zip of the > dependencies package, so I can use it as well. (It'll be best to > put that somewhe

Re: [PATCH] Fix write to uninitialized bytes for XCB event

2020-02-19 Thread Enrico Forestieri
On Wed, Feb 19, 2020 at 01:19:54PM -0500, Scott Kostyshak wrote: > > It seems I committed too soon. Sorry for not waiting. Both the macro > approach and Enrico's proposal are cleaner than my approach. I was > planning to pursue the macro approach in a follow-up commit. Apparently, the macro appro

Re: [PATCH] Fix write to uninitialized bytes for XCB event

2020-02-19 Thread Scott Kostyshak
On Wed, Feb 19, 2020 at 07:22:36PM +0100, Pavel Sanda wrote: > On Wed, Feb 19, 2020 at 06:28:51PM +0100, Enrico Forestieri wrote: > > Uh? In the Requirements section I read: > > > > First of all, you will need a C++11 standard conforming compiler, like gcc > > (at least 4.7) or clang. > > My

Re: [PATCH] Fix write to uninitialized bytes for XCB event

2020-02-19 Thread Pavel Sanda
On Wed, Feb 19, 2020 at 06:28:51PM +0100, Enrico Forestieri wrote: > Uh? In the Requirements section I read: > > First of all, you will need a C++11 standard conforming compiler, like gcc > (at least 4.7) or clang. My undesrtanding was that only 4.8 is C++11 complete, especially wrt alignment

Re: [PATCH] Fix write to uninitialized bytes for XCB event

2020-02-19 Thread Scott Kostyshak
On Wed, Feb 19, 2020 at 06:28:51PM +0100, Enrico Forestieri wrote: > On Wed, Feb 19, 2020 at 06:13:08PM +0100, Pavel Sanda wrote: > > On Wed, Feb 19, 2020 at 05:24:46PM +0100, Enrico Forestieri wrote: > > > > Did not try, but I am afraid generally it won't, because > > > > xcb_selection_notify_eve

Re: Building windows installer questions

2020-02-19 Thread Yu Jin
Am Mi., 19. Feb. 2020 um 17:04 Uhr schrieb Richard Kimberly Heck < rikih...@lyx.org>: > If you do update these other tools, please send me a zip of the > dependencies package, so I can use it as well. (It'll be best to put that > somewhere on the web I can download it, if possible, as it would mak

Re: [PATCH] Fix write to uninitialized bytes for XCB event

2020-02-19 Thread Enrico Forestieri
On Wed, Feb 19, 2020 at 06:13:08PM +0100, Pavel Sanda wrote: > On Wed, Feb 19, 2020 at 05:24:46PM +0100, Enrico Forestieri wrote: > > > Did not try, but I am afraid generally it won't, because > > > xcb_selection_notify_event_t is not enforced to have 32 bits, > > > while that's requested by under

Re: [PATCH] Fix write to uninitialized bytes for XCB event

2020-02-19 Thread Pavel Sanda
On Wed, Feb 19, 2020 at 05:24:46PM +0100, Enrico Forestieri wrote: > > Did not try, but I am afraid generally it won't, because > > xcb_selection_notify_event_t is not enforced to have 32 bits, > > while that's requested by underlying X routines. That's why > > the padding by 0s. > > Ok, then pro

Assertion

2020-02-19 Thread Daniel
I just navigated between child documents using the outliner's Table of Contents as a dialog appeared (attached). Any idea what this might be about? Daniel -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel

Re: [PATCH] Fix write to uninitialized bytes for XCB event

2020-02-19 Thread Enrico Forestieri
On Wed, Feb 19, 2020 at 08:42:57AM +0100, Pavel Sanda wrote: > On Wed, Feb 19, 2020 at 08:24:43AM +0100, Enrico Forestieri wrote: > > On Tue, Feb 18, 2020 at 09:49:08PM -0500, Scott Kostyshak wrote: > > > > > > Attached is a patch. I really don't know what I'm doing. The use of > > > calloc scares

Re: Building windows installer questions

2020-02-19 Thread Richard Kimberly Heck
On 2/18/20 5:08 AM, Yu Jin wrote: > > Am Sa., 15. Feb. 2020 um 18:38 Uhr schrieb Richard Kimberly Heck > mailto:rikih...@lyx.org>>: > > FYI, I updated ImageMagick in the most recent installers. I > haven't uploaded the new stuff yet to the dependencies file online. > > I see, I have also lo

Re: bug in "view" option

2020-02-19 Thread Richard Kimberly Heck
On 2/19/20 3:11 AM, Sivan Frenkel wrote: > Hi, > > Oddly, I have not been experiencing today the bug that I have reported > yesterday, and the "view" button works fine. I will be in touch if I > could figure out when and how this bug appears. > > Sorry for the mess. No problem, but I'll add that i

Re: [PATCH] Fix write to uninitialized bytes for XCB event

2020-02-19 Thread Pavel Sanda
On Wed, Feb 19, 2020 at 09:56:20AM -0500, Scott Kostyshak wrote: > If there is interest, I can work on a patch for using the macro. It would reduce the work of relearning the topic for someone stumbling upon this TODO in 5 years. > Should I condition on the Qt version and if it is less than 5.6.3

Re: Memory leak from list

2020-02-19 Thread Scott Kostyshak
On Wed, Feb 19, 2020 at 08:52:18AM +, Neven Sajko wrote: > > Well, actually the hardest part is waiting because LyX is very slow when > > run under valgrind. > > Try sanitizers instead. They are instrumentation that GCC or Clang can > include in executables. They do basically the same thing a

Re: Memory leak from list

2020-02-19 Thread Neven Sajko
My instructions for the C compiler and linker command line were wrong: instead of -fsanitize=asan , use -fsanitize=address or -fsanitize=thread or -fsanitize=undefined or -fsanitize=memory . And, of course, include debugging symbols with "-g". Regards, Neven Sajko -- lyx-devel mailing list lyx-d

Re: [PATCH] Fix write to uninitialized bytes for XCB event

2020-02-19 Thread Scott Kostyshak
On Wed, Feb 19, 2020 at 09:53:35AM -0500, Scott Kostyshak wrote: > On Wed, Feb 19, 2020 at 11:51:58AM +0100, Jean-Marc Lasgouttes wrote: > > Stealing the definition of the macro when we do not have it is the best > > solution IMO. > > I put in the patch with comments addressing both yours and Pav

Re: [PATCH] Fix write to uninitialized bytes for XCB event

2020-02-19 Thread Scott Kostyshak
On Wed, Feb 19, 2020 at 11:51:58AM +0100, Jean-Marc Lasgouttes wrote: > Stealing the definition of the macro when we do not have it is the best > solution IMO. I put in the patch with comments addressing both yours and Pavel's ideas (to either wait until Qt 5.6.3 is required, or to copy the macro

Re: [PATCH] Fix write to uninitialized bytes for XCB event

2020-02-19 Thread Jean-Marc Lasgouttes
Stealing the definition of the macro when we do not have it is the best solution IMO. JMarc Le 19 février 2020 08:39:35 GMT+01:00, Pavel Sanda a écrit : >On Tue, Feb 18, 2020 at 09:49:08PM -0500, Scott Kostyshak wrote: >> Could anyone take a close look at this? If there is a better fix, >please

Re: Memory leak from list

2020-02-19 Thread Neven Sajko
> Well, actually the hardest part is waiting because LyX is very slow when run > under valgrind. Try sanitizers instead. They are instrumentation that GCC or Clang can include in executables. They do basically the same thing as Valgrind, but should be much faster and since you are already compili

Re: bug in "view" option

2020-02-19 Thread Sivan Frenkel
Hi, Oddly, I have not been experiencing today the bug that I have reported yesterday, and the "view" button works fine. I will be in touch if I could figure out when and how this bug appears. Sorry for the mess. Best, Sivan Sivan Frenkel Lecturer in Finance (Assistant Professor) Coller School o