Re: [LyX/master] Honor Update::SinglePar properly

2023-02-21 Thread Scott Kostyshak
On Tue, Feb 21, 2023 at 06:57:39PM +0100, Lorenzo Bertini wrote: > Il 21/02/23 17:01, Scott Kostyshak ha scritto: > > On Wed, Feb 20, 2019 at 02:37:03PM +0100, Jean-Marc Lasgouttes wrote: > > Found an instance that seems to be missing an update. > > > > Reproducing requires some fast typing. It is

Re: [LyX/master] Honor Update::SinglePar properly

2023-02-21 Thread Lorenzo Bertini
Il 21/02/23 17:01, Scott Kostyshak ha scritto: On Wed, Feb 20, 2019 at 02:37:03PM +0100, Jean-Marc Lasgouttes wrote: Found an instance that seems to be missing an update. Reproducing requires some fast typing. It is only 30% reproducible even after a shot of espresso, but 100% reproducible if I

Re: [LyX/master] Honor Update::SinglePar properly

2023-02-21 Thread Jean-Marc Lasgouttes
Le 21/02/2023 à 18:08, Scott Kostyshak a écrit : Could you put that to trac, so that I can track it? Done: https://www.lyx.org/trac/ticket/12674 I the set milestone to 2.4.0 since it's a regression, but it is a very minor issue and I don't imagine many at all will come across it and even if th

Re: [LyX/master] Honor Update::SinglePar properly

2023-02-21 Thread Scott Kostyshak
On Tue, Feb 21, 2023 at 05:56:14PM +0100, Jean-Marc Lasgouttes wrote: > Le 21/02/2023 à 17:01, Scott Kostyshak a écrit : > > On Wed, Feb 20, 2019 at 02:37:03PM +0100, Jean-Marc Lasgouttes wrote: > > > commit 9bdc0dab31337fd6788d587127842eb3558881ae > > > Author: Jean-Marc Lasgouttes > > > Date:

Re: [LyX/master] Honor Update::SinglePar properly

2023-02-21 Thread Jean-Marc Lasgouttes
Le 21/02/2023 à 17:01, Scott Kostyshak a écrit : On Wed, Feb 20, 2019 at 02:37:03PM +0100, Jean-Marc Lasgouttes wrote: commit 9bdc0dab31337fd6788d587127842eb3558881ae Author: Jean-Marc Lasgouttes Date: Wed Feb 20 12:01:44 2019 +0100 Honor Update::SinglePar properly The Single

Re: [LyX/master] Honor Update::SinglePar properly

2023-02-21 Thread Scott Kostyshak
On Wed, Feb 20, 2019 at 02:37:03PM +0100, Jean-Marc Lasgouttes wrote: > commit 9bdc0dab31337fd6788d587127842eb3558881ae > Author: Jean-Marc Lasgouttes > Date: Wed Feb 20 12:01:44 2019 +0100 > > Honor Update::SinglePar properly > > The SinglePar update flags has been a no-op for a l

Re: [LyX/master] Honor Update::SinglePar properly

2019-03-09 Thread Jean-Marc Lasgouttes
Le 9 mars 2019 12:16:17 GMT+01:00, Kornel Benko a écrit : >My try leads to > >10e2c658351c237d3b35566857a533a9d08f7f65 is the first bad commit >commit 10e2c658351c237d3b35566857a533a9d08f7f65 >Author: Jean-Marc Lasgouttes >Date: Mon Feb 18 15:41:00 2019 +0100 > >Let tm be a reference here a

Re: [LyX/master] Honor Update::SinglePar properly

2019-03-09 Thread Kornel Benko
Am Samstag, 9. März 2019 03:30:46 CET schrieb Scott Kostyshak : > On Sat, Mar 09, 2019 at 09:14:02AM +0100, Jean-Marc Lasgouttes wrote: > > Le 9 mars 2019 09:08:52 GMT+01:00, Jean-Marc Lasgouttes > > a écrit : > > >Le 9 mars 2019 00:22:22 GMT+01:00, Scott Kostyshak a > > >écrit : > > >>> Attach

Re: [LyX/master] Honor Update::SinglePar properly

2019-03-09 Thread Scott Kostyshak
On Sat, Mar 09, 2019 at 09:14:02AM +0100, Jean-Marc Lasgouttes wrote: > Le 9 mars 2019 09:08:52 GMT+01:00, Jean-Marc Lasgouttes > a écrit : > >Le 9 mars 2019 00:22:22 GMT+01:00, Scott Kostyshak a > >écrit : > >>> Attached the backtrace. > >> > >>I can reproduce. Would it help if I did a bisect?

Re: [LyX/master] Honor Update::SinglePar properly

2019-03-09 Thread Jean-Marc Lasgouttes
Le 9 mars 2019 09:08:52 GMT+01:00, Jean-Marc Lasgouttes a écrit : >Le 9 mars 2019 00:22:22 GMT+01:00, Scott Kostyshak a >écrit : >>> Attached the backtrace. >> >>I can reproduce. Would it help if I did a bisect? > > >I will return on Tuesday and have a look. I suspect that the bisect >will point

Re: [LyX/master] Honor Update::SinglePar properly

2019-03-09 Thread Jean-Marc Lasgouttes
Le 9 mars 2019 00:22:22 GMT+01:00, Scott Kostyshak a écrit : >> Attached the backtrace. > >I can reproduce. Would it help if I did a bisect? I will return on Tuesday and have a look. I suspect that the bisect will point to the new paint mechanism introduced in 2.3.1. Is 2.3 affected ? JMarc

Re: [LyX/master] Honor Update::SinglePar properly

2019-03-08 Thread Richard Kimberly Heck
On 3/8/19 6:22 PM, Scott Kostyshak wrote: > On Fri, Mar 08, 2019 at 03:31:47PM +0100, Kornel Benko wrote: >> Am Mittwoch, 20. Februar 2019 18:46:16 CET schrieb Jean-Marc Lasgouttes >> : >>> Le 20/02/2019 à 14:37, Jean-Marc Lasgouttes a écrit : commit 9bdc0dab31337fd6788d587127842eb3558881ae >

Re: [LyX/master] Honor Update::SinglePar properly

2019-03-08 Thread Scott Kostyshak
On Fri, Mar 08, 2019 at 03:31:47PM +0100, Kornel Benko wrote: > Am Mittwoch, 20. Februar 2019 18:46:16 CET schrieb Jean-Marc Lasgouttes > : > > Le 20/02/2019 à 14:37, Jean-Marc Lasgouttes a écrit : > > > commit 9bdc0dab31337fd6788d587127842eb3558881ae > > > Author: Jean-Marc Lasgouttes > > > Date

Re: [LyX/master] Honor Update::SinglePar properly

2019-03-08 Thread Kornel Benko
Am Mittwoch, 20. Februar 2019 18:46:16 CET schrieb Jean-Marc Lasgouttes : > Le 20/02/2019 à 14:37, Jean-Marc Lasgouttes a écrit : > > commit 9bdc0dab31337fd6788d587127842eb3558881ae > > Author: Jean-Marc Lasgouttes > > Date: Wed Feb 20 12:01:44 2019 +0100 > > > > Honor Update::SinglePar properl

Re: [LyX/master] Honor Update::SinglePar properly

2019-02-20 Thread Scott Kostyshak
On Wed, Feb 20, 2019 at 11:04:55PM +0100, Jean-Marc Lasgouttes wrote: > Le 20/02/2019 à 20:51, Scott Kostyshak a écrit : > > > Note that this commit may (will?) produce bad update at some places, since > > > we have been ignoring this flag for so long. We have now to discover the > > > places where

Re: [LyX/master] Honor Update::SinglePar properly

2019-02-20 Thread Jean-Marc Lasgouttes
Le 20/02/2019 à 20:51, Scott Kostyshak a écrit : Note that this commit may (will?) produce bad update at some places, since we have been ignoring this flag for so long. We have now to discover the places where it was forgotten. I think it is worth the it because we avoid redraws (thing moving cur

Re: [LyX/master] Honor Update::SinglePar properly

2019-02-20 Thread Scott Kostyshak
On Wed, Feb 20, 2019 at 06:46:16PM +0100, Jean-Marc Lasgouttes wrote: > Le 20/02/2019 à 14:37, Jean-Marc Lasgouttes a écrit : > > commit 9bdc0dab31337fd6788d587127842eb3558881ae > > Author: Jean-Marc Lasgouttes > > Date: Wed Feb 20 12:01:44 2019 +0100 > > > > Honor Update::SinglePar proper

Re: [LyX/master] Honor Update::SinglePar properly

2019-02-20 Thread Jean-Marc Lasgouttes
Le 20/02/2019 à 14:37, Jean-Marc Lasgouttes a écrit : commit 9bdc0dab31337fd6788d587127842eb3558881ae Author: Jean-Marc Lasgouttes Date: Wed Feb 20 12:01:44 2019 +0100 Honor Update::SinglePar properly Note that this commit may (will?) produce bad update at some places, since we have b