Re: [PATCH] Clean up configure.py

2006-04-01 Thread Lars Gullik Bjønnes
Angus Leeming <[EMAIL PROTECTED]> writes: | 1. LyX on non-*nix platforms is limited because it doesn't understand the | "native exe-finding" mechanism. | 2. The LyX C++ code base should be extended so that LyX can understand this | "native exe-finding" mechanism. On *nix that's the PATH environme

Re: [PATCH] Clean up configure.py

2006-04-01 Thread Angus Leeming
Lars Gullik Bjønnes <[EMAIL PROTECTED]> writes: > Not adding our own "path search" mechanism, but use the system for > that. If the system not setup to give access to the correct progs, use > absolute paths for those. > (If we distrubuted our own 'bin' dir then, OTOH, I'd think it ok to > modify t

Re: [PATCH] Clean up configure.py

2006-04-01 Thread Lars Gullik Bjønnes
Andre Poenitz <[EMAIL PROTECTED]> writes: | > Fixing bugs that have bothered *you* is quite ok and welcomed. _but_ | > all of us must expect our patches to be scrutinized and demanded | > rewritten before inclusion. | | Not exactly true when you think of it. I'd rather that you spelled it our fo

Re: [PATCH] Clean up configure.py

2006-04-01 Thread Lars Gullik Bjønnes
Angus Leeming <[EMAIL PROTECTED]> writes: | Lars Gullik Bjønnes <[EMAIL PROTECTED]> writes: | > | path_prefix is essentially a Windows thing. Windows has a PATH environment | > | variable but most native Windows apps don't use it; they use the registry | > | instead. LyX, however, knows nothing a

Re: [PATCH] Clean up configure.py

2006-04-01 Thread Abdelrazak Younes
Georg Baum a écrit : Am Freitag, 31. März 2006 10:21 schrieb Abdelrazak Younes: Agreed, a knowledgeable python programmer could do it in no time. A C++ version could be more complicated. Also I don't know if this is the case already (I think so) but it is (should be) an unsynchronized process;

Re: [PATCH] Clean up configure.py

2006-04-01 Thread Georg Baum
Am Freitag, 31. März 2006 10:21 schrieb Abdelrazak Younes: > Agreed, a knowledgeable python programmer could do it in no time. A C++ > version could be more complicated. Also I don't know if this is the case > already (I think so) but it is (should be) an unsynchronized process; > i.e. we don't

Re: [PATCH] Clean up configure.py

2006-04-01 Thread Andre Poenitz
On Thu, Mar 30, 2006 at 08:30:33PM +0200, Lars Gullik Bjønnes wrote: > If at anything it is my workload during the week, usually during > weekends I have some more time to spare. 1. Attract new developers. 2. [Be forced to] Spend no time yourself. 3. Have control. You might get two of them, but n

Re: [PATCH] Clean up configure.py

2006-03-31 Thread Bo Peng
> have you incorporated my patch about the cygwin test? Without it the > setting of \cygwin_path_fix_needed is completely wrong. No. I do not have write access to lyx/svn, and do not want to post repetitive patches, please apply your patch by yourself, after Georg applies mine. It actually makes s

Re: [PATCH] Clean up configure.py

2006-03-31 Thread Enrico Forestieri
On Fri, Mar 31, 2006 at 07:25:48AM -0600, Bo Peng wrote: > > > * configure.py: Major clean up. > > > > I could have written that one myself. I was thinking about something more > > detailed, but I'll use that now. > > I do not think there are more details. :-) This is only a clean up > with things

Re: [PATCH] Clean up configure.py

2006-03-31 Thread Bo Peng
> > * configure.py: Major clean up. > > I could have written that one myself. I was thinking about something more > detailed, but I'll use that now. I do not think there are more details. :-) This is only a clean up with things are grouped together and packed into functions, No new feature is intr

Re: [PATCH] Clean up configure.py

2006-03-31 Thread Georg Baum
Bo Peng wrote: > 2006-03-30 Bo Peng <[EMAIL PROTECTED]> > > * configure.py: Major clean up. I could have written that one myself. I was thinking about something more detailed, but I'll use that now. >> Note also that the pdflatex format changes are missing. > > Which one? Line 224 has > ch

Re: [PATCH] Clean up configure.py

2006-03-31 Thread Jean-Marc Lasgouttes
> "Angus" == Angus Leeming <[EMAIL PROTECTED]> writes: >> Why cannot programs we defined with absolute paths when the prog is >> not in the default path? Why should lyx have its own path lookup >> logic? Angus> path_prefix is essentially a Windows thing. Windows has a PATH Angus> environment

Re: [PATCH] Clean up configure.py

2006-03-31 Thread Angus Leeming
Lars Gullik Bjønnes <[EMAIL PROTECTED]> writes: > | path_prefix is essentially a Windows thing. Windows has a PATH environment > | variable but most native Windows apps don't use it; they use the registry > | instead. LyX, however, knows nothing about the registry, so we givea > | our users locali

Re: [PATCH] Clean up configure.py

2006-03-31 Thread Jean-Marc Lasgouttes
> "Bo" == Bo Peng <[EMAIL PROTECTED]> writes: Bo> Question: Do we need to set the following in lyxrc.default during Bo> configure.py under windows? What do you mean exactly? What would the alternative be? Bo> \pdf_viewer 'c:\program Bo> files\acrobat\reader\7.0\bin\acroread32.exe' \gs_viewer

Re: [PATCH] Clean up configure.py

2006-03-31 Thread Abdelrazak Younes
Georg Baum a écrit : Am Donnerstag, 30. März 2006 10:50 schrieb Abdelrazak Younes: I wouldn't like you to be frustrated by people not having enough time to review your (big and frequent) patches. This problem would not be solved by rw access. rw access is good for small obvious stuff that ca

Re: [PATCH] Clean up configure.py

2006-03-31 Thread Abdelrazak Younes
Jose' Matos a écrit : On Thursday 30 March 2006 20:14, Georg Baum wrote: If the goal is really to go to C++ I would skip the python part. Why create additional work? Probably because it is easier to create and develop, it is cross platform and a better approach than what we have now. Agre

Re: [PATCH] Clean up configure.py

2006-03-30 Thread Lars Gullik Bjønnes
Angus Leeming <[EMAIL PROTECTED]> writes: | path_prefix is essentially a Windows thing. Windows has a PATH environment | variable but most native Windows apps don't use it; they use the registry | instead. LyX, however, knows nothing about the registry, so we give our users a | localized way of t

Re: [PATCH] Clean up configure.py

2006-03-30 Thread Enrico Forestieri
On Thu, Mar 30, 2006 at 08:59:37PM +, Angus Leeming wrote: > Enrico Forestieri <[EMAIL PROTECTED]> writes: > > It is used by LyX to set the PATH prefix. In *nix it should be omitted, > > as everything needed should already be in the PATH. In the native win32 > > LyX it will be set by the instal

Re: [PATCH] Clean up configure.py

2006-03-30 Thread Bo Peng
> > I will do that, as well as the \Format+spacing later. Please apply the > > current patch first. > > I'll do that if you submit a log entry. 2006-03-30 Bo Peng <[EMAIL PROTECTED]> * configure.py: Major clean up. > Note also that the pdflatex format changes are missing. Which one?

Re: [PATCH] Clean up configure.py

2006-03-30 Thread Bo Peng
> Setting it in the installer is a kludge. The correct place to set this thing > is > in the configure script so that it can be updated as you install software. We > couldn't do that before now because shell scripts have "limited" support for > interogation of the registry ;-) This is part of the

Re: [PATCH] Clean up configure.py

2006-03-30 Thread Angus Leeming
Enrico Forestieri <[EMAIL PROTECTED]> writes: > It is used by LyX to set the PATH prefix. In *nix it should be omitted, > as everything needed should already be in the PATH. In the native win32 > LyX it will be set by the installer, so also in this case it is probably > not needed. This leaves cygw

Re: [PATCH] Clean up configure.py

2006-03-30 Thread Angus Leeming
Lars Gullik Bjønnes <[EMAIL PROTECTED]> writes: > > Georg Baum <[EMAIL PROTECTED]> writes: > > | Am Donnerstag, 30. März 2006 18:09 schrieb Bo Peng: > | > | > > I think that the configure script should also provide for a default > | > > \path_prefix in lyxrc.default, probably based on platform.

Re: [PATCH] Clean up configure.py

2006-03-30 Thread Georg Baum
Am Donnerstag, 30. März 2006 21:33 schrieb Lars Gullik Bjønnes: > Why cannot programs we defined with absolute paths when the prog is > not in the default path? Why should lyx have its own path lookup > logic? There have been long discussions about that around jan 2005. I forgot the reasons, but

Re: [PATCH] Clean up configure.py

2006-03-30 Thread Georg Baum
Am Donnerstag, 30. März 2006 21:31 schrieb Bo Peng: > I will do that, as well as the \Format+spacing later. Please apply the > current patch first. I'll do that if you submit a log entry. Note also that the pdflatex format changes are missing. Georg

Re: [PATCH] Clean up configure.py

2006-03-30 Thread Jose' Matos
On Thursday 30 March 2006 20:14, Georg Baum wrote: > If the goal is really to go to C++ I would skip the python part. Why > create additional work? Probably because it is easier to create and develop, it is cross platform and a better approach than what we have now. > Georg -- José Abílio

Re: [PATCH] Clean up configure.py

2006-03-30 Thread Enrico Forestieri
On Thu, Mar 30, 2006 at 09:46:57PM +0200, Enrico Forestieri wrote: > Please, attached find a patch correcting this problems. I forgot to attach the patch. -- Enrico --- configure.py.orig Thu Mar 30 12:58:18 2006 +++ configure.pyThu Mar 30 21:27:14 2006 @@ -33,7 +33,7 @@ def removeF

Re: [PATCH] Clean up configure.py

2006-03-30 Thread Bo Peng
> Please, attached find a patch correcting this problems. I have > substituted "cmdOutput('cygpath -w ' + ...).replace('\\', '/')" > with "cmdOutput('cygpath -m ' + ...)", as the -m flag to cygpath > already does what you do with the replace(). > I also have corrected the logic: path correction is

Re: [PATCH] Clean up configure.py

2006-03-30 Thread Enrico Forestieri
On Thu, Mar 30, 2006 at 10:09:07AM -0600, Bo Peng wrote: > > > > I tested it on cygwin. Here are the results. > > > > 1) After launching, the script was hanging in checkCygwinPath(). > >I had to kill the latex.exe process to let it continue (I use > >MikTeX, so latex.exe is a native win32 p

Re: [PATCH] Clean up configure.py

2006-03-30 Thread Lars Gullik Bjønnes
Georg Baum <[EMAIL PROTECTED]> writes: | Am Donnerstag, 30. März 2006 18:09 schrieb Bo Peng: | | > > I think that the configure script should also provide for a default | > > \path_prefix in lyxrc.default, probably based on platform. When | > > sys.platform == 'cygwin', it would be: | > > | > > \

Re: [PATCH] Clean up configure.py

2006-03-30 Thread Lars Gullik Bjønnes
"Bo Peng" <[EMAIL PROTECTED]> writes: | > But also the windows size storing stuff put me a bit off and I am a | > lot more unsure if that is the right approach at all. (I think it is | > in combination with the (reworked) other lyxrc patch). | | I think this is a quite common approach. If you are

Re: [PATCH] Clean up configure.py

2006-03-30 Thread Bo Peng
> > > \path_prefix "/usr/local/bin:/usr/bin:/usr/X11R6/bin" > > > > Where will it be used? > > For running utility programs such as converters, viewers etc. This was > introduced for native windows and is not needed for unix, because > normally all programs are in the path. I don't know how it is o

Re: [PATCH] Clean up configure.py

2006-03-30 Thread Georg Baum
Am Donnerstag, 30. März 2006 18:09 schrieb Bo Peng: > > I think that the configure script should also provide for a default > > \path_prefix in lyxrc.default, probably based on platform. When > > sys.platform == 'cygwin', it would be: > > > > \path_prefix "/usr/local/bin:/usr/bin:/usr/X11R6/bin" >

Re: [PATCH] Clean up configure.py

2006-03-30 Thread Georg Baum
Am Donnerstag, 30. März 2006 17:58 schrieb Bo Peng: > Then, we would also need rc_copier_entry, rc_spell_command_entry ... . > The real issue is actually people have been adjusting spaces to let > the rc file look better and I don't want to mess it up again. You could compute the needed amount of

Re: [PATCH] Clean up configure.py

2006-03-30 Thread Georg Baum
Am Donnerstag, 30. März 2006 13:33 schrieb Enrico Forestieri: > I think that the configure script should also provide for a default > \path_prefix in lyxrc.default, probably based on platform. When > sys.platform == 'cygwin', it would be: > > \path_prefix "/usr/local/bin:/usr/bin:/usr/X11R6/bin"

Re: [PATCH] Clean up configure.py

2006-03-30 Thread Georg Baum
Am Donnerstag, 30. März 2006 10:50 schrieb Abdelrazak Younes: > Your work load is impressive! I would like to advice you to ask for svn > RW access to Lars. I would support that. > I wouldn't like you to be frustrated by people not > having enough time to review your (big and frequent) patche

Re: [PATCH] Clean up configure.py

2006-03-30 Thread Bo Peng
> If at anything it is my workload during the week, usually during > weekends I have some more time to spare. I understand that. I am under the same situation. > But also the windows size storing stuff put me a bit off and I am a > lot more unsure if that is the right approach at all. (I think it

Re: [PATCH] Clean up configure.py

2006-03-30 Thread Lars Gullik Bjønnes
"Bo Peng" <[EMAIL PROTECTED]> writes: | > I would like to advice you to ask for svn RW access to | > Lars. I wouldn't like you to be frustrated by people not | > having enough time to review your (big and frequent) | > patches. | | I admit that I have been a little frustrated. I think, to be fair

Re: [PATCH] Clean up configure.py

2006-03-30 Thread Enrico Forestieri
On Thu, Mar 30, 2006 at 01:43:34PM +0200, Georg Baum wrote: > Enrico Forestieri wrote: > > > 2) lyxrc.defaults had CRLF terminators. > > This should not matter at all. Does LyX have problems reading it? I don't think so. I simply noticed it because I made a diff with the old lyxrc.default. --

Re: [PATCH] Clean up configure.py

2006-03-30 Thread Bo Peng
> I understand the frustration (gone through this) but this job, if you > accept it :-), is equally applicable to linux. You know how I was working on windows? I set up a cygwin/ssh server and ssh to it from linux. I edit files locally (under linux) and transfer files through scp, rsync or svn...

Re: [PATCH] Clean up configure.py

2006-03-30 Thread Abdelrazak Younes
Bo Peng a écrit : [...] I would love to have svn RW access and I will take my greatest caution not to abuse this privilege. hint, hint... [...] and there is a big TODO with regards to Windows user. The problem is related to graphics conversion for on-screen display I hope I caught your inter

Re: [PATCH] Clean up configure.py

2006-03-30 Thread Bo Peng
> I would like to advice you to ask for svn RW access to > Lars. I wouldn't like you to be frustrated by people not > having enough time to review your (big and frequent) > patches. I admit that I have been a little frustrated. I think, to be fairer to the time I spent, Lars would better apply my

Re: [PATCH] Clean up configure.py

2006-03-30 Thread Bo Peng
> > I tested it on cygwin. Here are the results. > > 1) After launching, the script was hanging in checkCygwinPath(). >I had to kill the latex.exe process to let it continue (I use >MikTeX, so latex.exe is a native win32 program, whereas python >is a cygwin application). Doing so, the c

Re: [PATCH] Clean up configure.py

2006-03-30 Thread Bo Peng
> Just a thought, but rather than hard code the formating of the "Format" and > "Converter" entries, so: > rc_entry = [ r'\Format agragr Grace "" "%%" > "%%"'] > why not define rc_format_entry and rc_converter_entry functions, to be used > so: > rc_format_ent

Re: [PATCH] Clean up configure.py

2006-03-30 Thread Georg Baum
Enrico Forestieri wrote: > 2) lyxrc.defaults had CRLF terminators. This should not matter at all. Does LyX have problems reading it? Georg

Re: [PATCH] Clean up configure.py

2006-03-30 Thread Enrico Forestieri
On Wed, Mar 29, 2006 at 10:55:19PM -0600, Bo Peng wrote: > Dear list, > > configure.py was first written as a direct translation of the > configure.m4 file. It is not structured, and use all global variables. > Attached is a more pythonic version. It is the first step towards my > goal of automati

Re: [PATCH] Clean up configure.py

2006-03-30 Thread Abdelrazak Younes
Bo Peng a écrit : Dear list, configure.py was first written as a direct translation of the configure.m4 file. It is not structured, and use all global variables. Attached is a more pythonic version. It is the first step towards my goal of automatic partial re-configuration. Hi Bo, Your work l

Re: [PATCH] Clean up configure.py

2006-03-30 Thread Angus Leeming
Bo Peng <[EMAIL PROTECTED]> writes: > > Dear list, > > configure.py was first written as a direct translation of the > configure.m4 file. It is not structured, and use all global variables. > Attached is a more pythonic version. It is the first step towards my > goal of automatic partial re-conf