Re: [PATCH] buffer_funcs cleanup

2006-04-06 Thread Abdelrazak Younes
Jean-Marc Lasgouttes a écrit : Abdelrazak == Abdelrazak Younes [EMAIL PROTECTED] writes: Abdelrazak Jean-Marc Lasgouttes a écrit : bool needsUpdateCounters(Buffer const buf, ParIterator it) { if (it-layout()-counter.empty()) { Abdelrazak Apparently, this is not a good test for enumerate

Re: [PATCH] buffer_funcs cleanup

2006-04-06 Thread Andre Poenitz
On Wed, Apr 05, 2006 at 03:53:22PM +0200, Abdelrazak Younes wrote: Index: buffer_funcs.C === --- buffer_funcs.C(revision 13538) +++ buffer_funcs.C(working copy) @@ -328,7 +328,6 @@ } } - bool

Re: [PATCH] buffer_funcs cleanup

2006-04-06 Thread Abdelrazak Younes
Andre Poenitz a écrit : Two empty lines between functions, please. OK, Abdel.

[Patch] Paragrah creation/deletion optimisation (was Re: [PATCH] buffer_funcs cleanup)

2006-04-06 Thread Abdelrazak Younes
Abdelrazak Younes a écrit : Jean-Marc Lasgouttes a écrit : Abdelrazak == Abdelrazak Younes [EMAIL PROTECTED] writes: Abdelrazak Jean-Marc Lasgouttes a écrit : bool needsUpdateCounters(Buffer const buf, ParIterator it) { if (it-layout()-counter.empty()) { Abdelrazak Apparently, this is

Re: [PATCH] buffer_funcs cleanup

2006-04-06 Thread Abdelrazak Younes
Jean-Marc Lasgouttes a écrit : "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes: Abdelrazak> Jean-Marc Lasgouttes a écrit : bool needsUpdateCounters(Buffer const & buf, ParIterator & it) { if (it->layout()->counter.empty()) { Abdelrazak> Apparently, this is not a good test for

Re: [PATCH] buffer_funcs cleanup

2006-04-06 Thread Andre Poenitz
On Wed, Apr 05, 2006 at 03:53:22PM +0200, Abdelrazak Younes wrote: > Index: buffer_funcs.C > === > --- buffer_funcs.C(revision 13538) > +++ buffer_funcs.C(working copy) > @@ -328,7 +328,6 @@ > } > } > > - > bool

Re: [PATCH] buffer_funcs cleanup

2006-04-06 Thread Abdelrazak Younes
Andre Poenitz a écrit : Two empty lines between functions, please. OK, Abdel.

[Patch] Paragrah creation/deletion optimisation (was Re: [PATCH] buffer_funcs cleanup)

2006-04-06 Thread Abdelrazak Younes
Abdelrazak Younes a écrit : Jean-Marc Lasgouttes a écrit : "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes: Abdelrazak> Jean-Marc Lasgouttes a écrit : bool needsUpdateCounters(Buffer const & buf, ParIterator & it) { if (it->layout()->counter.empty()) { Abdelrazak> Apparently,

Re: [PATCH] buffer_funcs cleanup

2006-04-05 Thread Lars Gullik Bjønnes
Abdelrazak Younes [EMAIL PROTECTED] writes: | This would be closer to the XML way indeed but I didn't dare to say | it. I know that you guys are thinking about a switch to XML; a real | switch would mean more than a format. Only if we want it to. The plan so far has been that when we move to a

Re: [PATCH] buffer_funcs cleanup

2006-04-05 Thread Martin Vermeer
On Mon, Apr 03, 2006 at 05:05:56PM +0200, Abdelrazak Younes wrote: Martin Vermeer a écrit : On Mon, 2006-04-03 at 14:44 +0200, Abdelrazak Younes wrote: Is it the use of needsUpdateCounters (should maybe be needsCountersUpdate) that helps? Yes. This is important. I suggest you create

Re: [PATCH] buffer_funcs cleanup

2006-04-05 Thread Abdelrazak Younes
Martin Vermeer a écrit : On Mon, Apr 03, 2006 at 05:05:56PM +0200, Abdelrazak Younes wrote: Martin Vermeer a écrit : On Mon, 2006-04-03 at 14:44 +0200, Abdelrazak Younes wrote: Is it the use of needsUpdateCounters (should maybe be needsCountersUpdate) that helps? Yes. This is important.

Re: [PATCH] buffer_funcs cleanup

2006-04-05 Thread Jean-Marc Lasgouttes
Abdelrazak == Abdelrazak Younes [EMAIL PROTECTED] writes: Abdelrazak Fine! Then I'll commit it to 1.5 if nobody object. If Abdelrazak somebody want to object, speak now please. If it is still time, I have a few comments: - I like the setItemLabel separation (and the setEnumLabel in the other

Re: [PATCH] buffer_funcs cleanup

2006-04-05 Thread Abdelrazak Younes
Jean-Marc Lasgouttes a écrit : Abdelrazak == Abdelrazak Younes [EMAIL PROTECTED] writes: Abdelrazak Fine! Then I'll commit it to 1.5 if nobody object. If Abdelrazak somebody want to object, speak now please. If it is still time, I have a few comments: Are those comments only for the 1.5

Re: [PATCH] buffer_funcs cleanup

2006-04-05 Thread Jean-Marc Lasgouttes
Abdelrazak == Abdelrazak Younes [EMAIL PROTECTED] writes: Abdelrazak Jean-Marc Lasgouttes a écrit : Abdelrazak == Abdelrazak Younes [EMAIL PROTECTED] writes: Abdelrazak Fine! Then I'll commit it to 1.5 if nobody object. If Abdelrazak somebody want to object, speak now please. If it is still

Re: [PATCH] buffer_funcs cleanup

2006-04-05 Thread Abdelrazak Younes
Jean-Marc Lasgouttes a écrit : Abdelrazak == Abdelrazak Younes [EMAIL PROTECTED] writes: [...] I would be OK with that. OTOH if you manage not to call setItemLabel directly in 1.4 but setCounter instead, you could leave the remainder of the code as it stands (with one bug setCounter function).

Re: [PATCH] buffer_funcs cleanup

2006-04-05 Thread Bennett Helm
On Apr 5, 2006, at 6:27 AM, Abdelrazak Younes wrote: I seem to remember remember some problem like this on Mac also. Bennet could you try test this patch? I haven't been following this carefully. What exactly should I be testing? Bennett

Re: [PATCH] buffer_funcs cleanup

2006-04-05 Thread Abdelrazak Younes
Bennett Helm a écrit : On Apr 5, 2006, at 6:27 AM, Abdelrazak Younes wrote: I seem to remember remember some problem like this on Mac also. Bennet could you try test this patch? I haven't been following this carefully. What exactly should I be testing? Paragraph creation/deletion induce a

Re: [PATCH] buffer_funcs cleanup

2006-04-05 Thread Jean-Marc Lasgouttes
Abdelrazak == Abdelrazak Younes [EMAIL PROTECTED] writes: Abdelrazak I don't know the LyX API by heart yet ;-) Are we sure that Abdelrazak the cursor is on the right paragraph after a deletion or a Abdelrazak creation? The cursor is moved later in breakParagraph, so you may have to move some

Re: [PATCH] buffer_funcs cleanup

2006-04-05 Thread Abdelrazak Younes
Jean-Marc Lasgouttes a écrit : bool needsUpdateCounters(Buffer const buf, ParIterator it) { if (it-layout()-counter.empty()) { Apparently, this is not a good test for enumerate (returns true). Do you know why? setCounter(buf, it); return false;

Re: [PATCH] buffer_funcs cleanup

2006-04-05 Thread Bennett Helm
On Apr 5, 2006, at 9:53 AM, Abdelrazak Younes wrote: Bennett Helm a écrit : On Apr 5, 2006, at 6:27 AM, Abdelrazak Younes wrote: I seem to remember remember some problem like this on Mac also. Bennet could you try test this patch? I haven't been following this carefully. What exactly should

Re: [PATCH] buffer_funcs cleanup

2006-04-05 Thread Jean-Marc Lasgouttes
Abdelrazak == Abdelrazak Younes [EMAIL PROTECTED] writes: Abdelrazak Jean-Marc Lasgouttes a écrit : bool needsUpdateCounters(Buffer const buf, ParIterator it) { if (it-layout()-counter.empty()) { Abdelrazak Apparently, this is not a good test for enumerate (returns Abdelrazak true). Do you

Re: [PATCH] buffer_funcs cleanup

2006-04-05 Thread Lars Gullik Bjønnes
Abdelrazak Younes <[EMAIL PROTECTED]> writes: | This would be closer to the XML way indeed but I didn't dare to say | it. I know that you guys are thinking about a switch to XML; a real | switch would mean more than a format. Only if we want it to. The plan so far has been that when we move to

Re: [PATCH] buffer_funcs cleanup

2006-04-05 Thread Martin Vermeer
On Mon, Apr 03, 2006 at 05:05:56PM +0200, Abdelrazak Younes wrote: > Martin Vermeer a écrit : > >On Mon, 2006-04-03 at 14:44 +0200, Abdelrazak Younes wrote: > > > >>> Is it the use of > >>>needsUpdateCounters (should maybe be needsCountersUpdate) that helps? > >>> > >>Yes. > > > >This is

Re: [PATCH] buffer_funcs cleanup

2006-04-05 Thread Abdelrazak Younes
Martin Vermeer a écrit : On Mon, Apr 03, 2006 at 05:05:56PM +0200, Abdelrazak Younes wrote: Martin Vermeer a écrit : On Mon, 2006-04-03 at 14:44 +0200, Abdelrazak Younes wrote: Is it the use of needsUpdateCounters (should maybe be needsCountersUpdate) that helps? Yes. This is important.

Re: [PATCH] buffer_funcs cleanup

2006-04-05 Thread Jean-Marc Lasgouttes
> "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes: Abdelrazak> Fine! Then I'll commit it to 1.5 if nobody object. If Abdelrazak> somebody want to object, speak now please. If it is still time, I have a few comments: - I like the setItemLabel separation (and the setEnumLabel in

Re: [PATCH] buffer_funcs cleanup

2006-04-05 Thread Abdelrazak Younes
Jean-Marc Lasgouttes a écrit : "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes: Abdelrazak> Fine! Then I'll commit it to 1.5 if nobody object. If Abdelrazak> somebody want to object, speak now please. If it is still time, I have a few comments: Are those comments only for the

Re: [PATCH] buffer_funcs cleanup

2006-04-05 Thread Jean-Marc Lasgouttes
> "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes: Abdelrazak> Jean-Marc Lasgouttes a écrit : >>> "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes: Abdelrazak> Fine! Then I'll commit it to 1.5 if nobody object. If Abdelrazak> somebody want to object, speak now

Re: [PATCH] buffer_funcs cleanup

2006-04-05 Thread Abdelrazak Younes
Jean-Marc Lasgouttes a écrit : "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes: [...] I would be OK with that. OTOH if you manage not to call setItemLabel directly in 1.4 but setCounter instead, you could leave the remainder of the code as it stands (with one bug setCounter

Re: [PATCH] buffer_funcs cleanup

2006-04-05 Thread Bennett Helm
On Apr 5, 2006, at 6:27 AM, Abdelrazak Younes wrote: I seem to remember remember some problem like this on Mac also. Bennet could you try test this patch? I haven't been following this carefully. What exactly should I be testing? Bennett

Re: [PATCH] buffer_funcs cleanup

2006-04-05 Thread Abdelrazak Younes
Bennett Helm a écrit : On Apr 5, 2006, at 6:27 AM, Abdelrazak Younes wrote: I seem to remember remember some problem like this on Mac also. Bennet could you try test this patch? I haven't been following this carefully. What exactly should I be testing? Paragraph creation/deletion induce a

Re: [PATCH] buffer_funcs cleanup

2006-04-05 Thread Jean-Marc Lasgouttes
> "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes: Abdelrazak> I don't know the LyX API by heart yet ;-) Are we sure that Abdelrazak> the cursor is on the right paragraph after a deletion or a Abdelrazak> creation? The cursor is moved later in breakParagraph, so you may have to

Re: [PATCH] buffer_funcs cleanup

2006-04-05 Thread Abdelrazak Younes
Jean-Marc Lasgouttes a écrit : bool needsUpdateCounters(Buffer const & buf, ParIterator & it) { if (it->layout()->counter.empty()) { Apparently, this is not a good test for enumerate (returns true). Do you know why? setCounter(buf, it); return false;

Re: [PATCH] buffer_funcs cleanup

2006-04-05 Thread Bennett Helm
On Apr 5, 2006, at 9:53 AM, Abdelrazak Younes wrote: Bennett Helm a écrit : On Apr 5, 2006, at 6:27 AM, Abdelrazak Younes wrote: I seem to remember remember some problem like this on Mac also. Bennet could you try test this patch? I haven't been following this carefully. What exactly should

Re: [PATCH] buffer_funcs cleanup

2006-04-05 Thread Jean-Marc Lasgouttes
> "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes: Abdelrazak> Jean-Marc Lasgouttes a écrit : >> bool needsUpdateCounters(Buffer const & buf, ParIterator & it) { if >> (it->layout()->counter.empty()) { Abdelrazak> Apparently, this is not a good test for enumerate (returns

Re: [PATCH] buffer_funcs cleanup

2006-04-04 Thread Abdelrazak Younes
Andre Poenitz a écrit : On Mon, Apr 03, 2006 at 04:09:44PM +0200, Abdelrazak Younes wrote: IMHO even if there's no performance penalty on linux (which I really doubt on slow machine) the way the counters are updated is too heavy. We should instead maintains lists of interdependent numbered

Re: [PATCH] buffer_funcs cleanup

2006-04-04 Thread Andre Poenitz
On Mon, Apr 03, 2006 at 04:09:44PM +0200, Abdelrazak Younes wrote: IMHO even if there's no performance penalty on linux (which I really doubt on slow machine) the way the counters are updated is too heavy. We should instead maintains lists of interdependent numbered paragraphs and update

Re: [PATCH] buffer_funcs cleanup

2006-04-04 Thread Andre Poenitz
On Mon, Apr 03, 2006 at 03:07:57PM +0200, Abdelrazak Younes wrote: Angus Leeming a écrit : Abdelrazak Younes [EMAIL PROTECTED] writes: Anyway, do what you want with the patch. I will maintain my own version locally. Hey, Abdel! Don't get stroppy; I am not. I just don't have the courage

Re: [PATCH] buffer_funcs cleanup

2006-04-04 Thread Andre Poenitz
On Mon, Apr 03, 2006 at 02:44:16PM +0200, Abdelrazak Younes wrote: Anyway, do what you want with the patch. I will maintain my own version locally. Hm.. Jean-Marc is not the enemy. Never was. Andre'

Re: [PATCH] buffer_funcs cleanup

2006-04-04 Thread Andre Poenitz
On Tue, Apr 04, 2006 at 04:24:49PM +0200, Abdelrazak Younes wrote: We should instead maintains lists of interdependent numbered paragraphs and update only those paragraphs that need updates. In this context, a kind of DocIterator that will iterates other one of these lists would be really

Re: [PATCH] buffer_funcs cleanup

2006-04-04 Thread Abdelrazak Younes
Andre Poenitz a écrit : On Tue, Apr 04, 2006 at 04:24:49PM +0200, Abdelrazak Younes wrote: We should instead maintains lists of interdependent numbered paragraphs and update only those paragraphs that need updates. In this context, a kind of DocIterator that will iterates other one of these

Re: [PATCH] buffer_funcs cleanup

2006-04-04 Thread Abdelrazak Younes
Andre Poenitz a écrit : On Mon, Apr 03, 2006 at 04:09:44PM +0200, Abdelrazak Younes wrote: IMHO even if there's no performance penalty on linux (which I really doubt on slow machine) the way the counters are updated is too heavy. We should instead maintains lists of interdependent numbered

Re: [PATCH] buffer_funcs cleanup

2006-04-04 Thread Andre Poenitz
On Mon, Apr 03, 2006 at 04:09:44PM +0200, Abdelrazak Younes wrote: > IMHO even if there's no performance penalty on linux (which I really > doubt on slow machine) the way the counters are updated is too heavy. We > should instead maintains lists of interdependent numbered paragraphs and >

Re: [PATCH] buffer_funcs cleanup

2006-04-04 Thread Andre Poenitz
On Mon, Apr 03, 2006 at 03:07:57PM +0200, Abdelrazak Younes wrote: > Angus Leeming a écrit : > >Abdelrazak Younes <[EMAIL PROTECTED]> writes: > >>Anyway, do what you want with the patch. I will maintain my own version > >>locally. > > > >Hey, Abdel! Don't get stroppy; > > I am not. I just don't

Re: [PATCH] buffer_funcs cleanup

2006-04-04 Thread Andre Poenitz
On Mon, Apr 03, 2006 at 02:44:16PM +0200, Abdelrazak Younes wrote: > Anyway, do what you want with the patch. I will maintain my own version > locally. Hm.. Jean-Marc is not the enemy. Never was. Andre'

Re: [PATCH] buffer_funcs cleanup

2006-04-04 Thread Andre Poenitz
On Tue, Apr 04, 2006 at 04:24:49PM +0200, Abdelrazak Younes wrote: > >>We should instead maintains lists of interdependent numbered > >>paragraphs and update only those paragraphs that need updates. In > >>this context, a kind of DocIterator that will iterates other one of > >>these lists would

Re: [PATCH] buffer_funcs cleanup

2006-04-04 Thread Abdelrazak Younes
Andre Poenitz a écrit : On Tue, Apr 04, 2006 at 04:24:49PM +0200, Abdelrazak Younes wrote: We should instead maintains lists of interdependent numbered paragraphs and update only those paragraphs that need updates. In this context, a kind of DocIterator that will iterates other one of these

[PATCH] buffer_funcs cleanup (was Re: [PATCH] Re: Another brake)

2006-04-03 Thread Abdelrazak Younes
Jean-Marc Lasgouttes a écrit : Abdelrazak == Abdelrazak Younes [EMAIL PROTECTED] writes: Abdelrazak bool needEnumCounterReset(ParagraphList pars, size_t const pos) Abdelrazak Maybe I am missing something but this is simpler. Please Abdelrazak correct me if I am wrong. I agree

Re: [PATCH] buffer_funcs cleanup (was Re: [PATCH] Re: Another brake)

2006-04-03 Thread Lars Gullik Bjønnes
Abdelrazak Younes [EMAIL PROTECTED] writes: | Jean-Marc Lasgouttes a écrit : | Abdelrazak == Abdelrazak Younes [EMAIL PROTECTED] writes: | | | Abdelrazak bool needEnumCounterReset(ParagraphList pars, size_t | const pos) Abdelrazak Maybe I am missing something but this is | simpler. Please

Re: [PATCH] buffer_funcs cleanup (was Re: [PATCH] Re: Another brake)

2006-04-03 Thread Abdelrazak Younes
Lars Gullik Bjønnes a écrit : Abdelrazak Younes [EMAIL PROTECTED] writes: [...] | IMHO, this is because the code is not object oriented. In this context | docIterator is an advantage. The code is not 'not object oriented' either. IMHO, it is not _much_ object oriented. That's just an

Re: [PATCH] buffer_funcs cleanup

2006-04-03 Thread Jean-Marc Lasgouttes
Abdelrazak == Abdelrazak Younes [EMAIL PROTECTED] writes: Abdelrazak IMHO, this is because the code is not object oriented. In Abdelrazak this context docIterator is an advantage. When/if we move Abdelrazak to a truly object oriented way of dealing with insets I Abdelrazak believe that most of

Re: [PATCH] buffer_funcs cleanup

2006-04-03 Thread Abdelrazak Younes
Jean-Marc Lasgouttes a écrit : Abdelrazak == Abdelrazak Younes [EMAIL PROTECTED] writes: Abdelrazak IMHO, this is because the code is not object oriented. In Abdelrazak this context docIterator is an advantage. When/if we move Abdelrazak to a truly object oriented way of dealing

Re: [PATCH] buffer_funcs cleanup

2006-04-03 Thread Angus Leeming
Abdelrazak Younes [EMAIL PROTECTED] writes: Anyway, do what you want with the patch. I will maintain my own version locally. Hey, Abdel! Don't get stroppy; JMarc is one of the good guys! And besides, you Frenchies should stick together ;-) Angus

Re: [PATCH] buffer_funcs cleanup

2006-04-03 Thread Abdelrazak Younes
Angus Leeming a écrit : Abdelrazak Younes [EMAIL PROTECTED] writes: Anyway, do what you want with the patch. I will maintain my own version locally. Hey, Abdel! Don't get stroppy; I am not. I just don't have the courage nor the time to argue for days. So I just gave up. Nothing to be upset

Re: [PATCH] buffer_funcs cleanup

2006-04-03 Thread Jean-Marc Lasgouttes
Angus == Angus Leeming [EMAIL PROTECTED] writes: Angus Abdelrazak Younes [EMAIL PROTECTED] writes: Anyway, do what you want with the patch. I will maintain my own version locally. Angus Hey, Abdel! Don't get stroppy; JMarc is one of the good guys! Angus And besides, you Frenchies should stick

Re: [PATCH] buffer_funcs cleanup

2006-04-03 Thread Martin Vermeer
On Mon, 2006-04-03 at 14:44 +0200, Abdelrazak Younes wrote: Is it the use of needsUpdateCounters (should maybe be needsCountersUpdate) that helps? Yes. This is important. I suggest you create a minimal patch doing only this. We test it, make sure it's OK, have it in, and continue from

Re: [PATCH] buffer_funcs cleanup

2006-04-03 Thread Jean-Marc Lasgouttes
Abdelrazak == Abdelrazak Younes [EMAIL PROTECTED] writes: Abdelrazak Sorry but I do not see why modifying an enum in one Abdelrazak footnote should impact a caption inside a float inset. I put some of the 'interesting' constructs in the attached file. Abdelrazak Beside, counters inside a float

Re: [PATCH] buffer_funcs cleanup

2006-04-03 Thread Abdelrazak Younes
Jean-Marc Lasgouttes a écrit : Angus == Angus Leeming [EMAIL PROTECTED] writes: Angus Abdelrazak Younes [EMAIL PROTECTED] writes: Anyway, do what you want with the patch. I will maintain my own version locally. Angus Hey, Abdel! Don't get stroppy; JMarc is one of the good guys! Angus And

Re: [PATCH] buffer_funcs cleanup

2006-04-03 Thread Jean-Marc Lasgouttes
Abdelrazak == Abdelrazak Younes [EMAIL PROTECTED] writes: JMarc PS: Hmm, ``stroppy''. One more word in the weekly english lesson. Thanks Angus. Webster says it is a contraction of obstreperous. This one looks even better in a casual conversation ! Abdelrazak Google translate that in

Re: [PATCH] buffer_funcs cleanup

2006-04-03 Thread Jean-Marc Lasgouttes
Jean-Marc == Jean-Marc Lasgouttes [EMAIL PROTECTED] writes: Abdelrazak == Abdelrazak Younes [EMAIL PROTECTED] writes: Abdelrazak Sorry but I do not see why modifying an enum in one Abdelrazak footnote should impact a caption inside a float inset. Jean-Marc I put some of the 'interesting'

Re: [PATCH] buffer_funcs cleanup

2006-04-03 Thread Abdelrazak Younes
Jean-Marc Lasgouttes a écrit : Abdelrazak == Abdelrazak Younes [EMAIL PROTECTED] writes: Abdelrazak Sorry but I do not see why modifying an enum in one Abdelrazak footnote should impact a caption inside a float inset. I put some of the 'interesting' constructs in the attached file. I

Re: [PATCH] buffer_funcs cleanup

2006-04-03 Thread Abdelrazak Younes
Martin Vermeer a écrit : On Mon, 2006-04-03 at 14:44 +0200, Abdelrazak Younes wrote: Is it the use of needsUpdateCounters (should maybe be needsCountersUpdate) that helps? Yes. This is important. I suggest you create a minimal patch doing only this. We test it, make sure it's OK, have

Re: [PATCH] buffer_funcs cleanup

2006-04-03 Thread Jean-Marc Lasgouttes
Abdelrazak == Abdelrazak Younes [EMAIL PROTECTED] writes: Abdelrazak IMHO even if there's no performance penalty on linux Abdelrazak (which I really doubt on slow machine) the way the Abdelrazak counters are updated is too heavy. We should instead Abdelrazak maintains lists of interdependent

Re: [PATCH] buffer_funcs cleanup

2006-04-03 Thread Martin Vermeer
On Mon, Apr 03, 2006 at 05:05:56PM +0200, Abdelrazak Younes wrote: Martin Vermeer a écrit : On Mon, 2006-04-03 at 14:44 +0200, Abdelrazak Younes wrote: Is it the use of needsUpdateCounters (should maybe be needsCountersUpdate) that helps? Yes. This is important. I suggest you create

[PATCH] buffer_funcs cleanup (was Re: [PATCH] Re: Another brake)

2006-04-03 Thread Abdelrazak Younes
Jean-Marc Lasgouttes a écrit : "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes: Abdelrazak> bool needEnumCounterReset(ParagraphList & pars, size_t const pos) Abdelrazak> Maybe I am missing something but this is simpler. Please Abdelrazak> correct me if I am wrong.

Re: [PATCH] buffer_funcs cleanup (was Re: [PATCH] Re: Another brake)

2006-04-03 Thread Lars Gullik Bjønnes
Abdelrazak Younes <[EMAIL PROTECTED]> writes: | Jean-Marc Lasgouttes a écrit : | >> "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes: | >> | > | > Abdelrazak> bool needEnumCounterReset(ParagraphList & pars, size_t | > const pos) Abdelrazak> Maybe I am missing something but

Re: [PATCH] buffer_funcs cleanup (was Re: [PATCH] Re: Another brake)

2006-04-03 Thread Abdelrazak Younes
Lars Gullik Bjønnes a écrit : Abdelrazak Younes <[EMAIL PROTECTED]> writes: [...] | IMHO, this is because the code is not object oriented. In this context | docIterator is an advantage. The code is not 'not object oriented' either. IMHO, it is not _much_ object oriented. That's just an

Re: [PATCH] buffer_funcs cleanup

2006-04-03 Thread Jean-Marc Lasgouttes
> "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes: Abdelrazak> IMHO, this is because the code is not object oriented. In Abdelrazak> this context docIterator is an advantage. When/if we move Abdelrazak> to a truly object oriented way of dealing with insets I Abdelrazak> believe

Re: [PATCH] buffer_funcs cleanup

2006-04-03 Thread Abdelrazak Younes
Jean-Marc Lasgouttes a écrit : "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes: Abdelrazak> IMHO, this is because the code is not object oriented. In Abdelrazak> this context docIterator is an advantage. When/if we move Abdelrazak> to a truly object oriented way of

Re: [PATCH] buffer_funcs cleanup

2006-04-03 Thread Angus Leeming
Abdelrazak Younes <[EMAIL PROTECTED]> writes: > Anyway, do what you want with the patch. I will maintain my own version > locally. Hey, Abdel! Don't get stroppy; JMarc is one of the good guys! And besides, you Frenchies should stick together ;-) Angus

Re: [PATCH] buffer_funcs cleanup

2006-04-03 Thread Abdelrazak Younes
Angus Leeming a écrit : Abdelrazak Younes <[EMAIL PROTECTED]> writes: Anyway, do what you want with the patch. I will maintain my own version locally. Hey, Abdel! Don't get stroppy; I am not. I just don't have the courage nor the time to argue for days. So I just gave up. Nothing to be

Re: [PATCH] buffer_funcs cleanup

2006-04-03 Thread Jean-Marc Lasgouttes
> "Angus" == Angus Leeming <[EMAIL PROTECTED]> writes: Angus> Abdelrazak Younes <[EMAIL PROTECTED]> writes: >> Anyway, do what you want with the patch. I will maintain my own >> version locally. Angus> Hey, Abdel! Don't get stroppy; JMarc is one of the good guys! Angus> And besides, you

Re: [PATCH] buffer_funcs cleanup

2006-04-03 Thread Martin Vermeer
On Mon, 2006-04-03 at 14:44 +0200, Abdelrazak Younes wrote: > > Is it the use of > > needsUpdateCounters (should maybe be needsCountersUpdate) that helps? > > > Yes. This is important. I suggest you create a minimal patch doing only this. We test it, make sure it's OK, have it in, and

Re: [PATCH] buffer_funcs cleanup

2006-04-03 Thread Jean-Marc Lasgouttes
> "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes: Abdelrazak> Sorry but I do not see why modifying an enum in one Abdelrazak> footnote should impact a caption inside a float inset. I put some of the 'interesting' constructs in the attached file. Abdelrazak> Beside, counters

Re: [PATCH] buffer_funcs cleanup

2006-04-03 Thread Abdelrazak Younes
Jean-Marc Lasgouttes a écrit : "Angus" == Angus Leeming <[EMAIL PROTECTED]> writes: Angus> Abdelrazak Younes <[EMAIL PROTECTED]> writes: Anyway, do what you want with the patch. I will maintain my own version locally. Angus> Hey, Abdel! Don't get stroppy; JMarc is one of the good guys!

Re: [PATCH] buffer_funcs cleanup

2006-04-03 Thread Jean-Marc Lasgouttes
> "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes: >> JMarc PS: Hmm, ``stroppy''. One more word in the weekly english >> lesson. Thanks Angus. Webster says it is a contraction of >> obstreperous. This one looks even better in a casual conversation ! Abdelrazak> Google translate

Re: [PATCH] buffer_funcs cleanup

2006-04-03 Thread Jean-Marc Lasgouttes
> "Jean-Marc" == Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes: > "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes: Abdelrazak> Sorry but I do not see why modifying an enum in one Abdelrazak> footnote should impact a caption inside a float inset. Jean-Marc> I put some of

Re: [PATCH] buffer_funcs cleanup

2006-04-03 Thread Abdelrazak Younes
Jean-Marc Lasgouttes a écrit : "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes: Abdelrazak> Sorry but I do not see why modifying an enum in one Abdelrazak> footnote should impact a caption inside a float inset. I put some of the 'interesting' constructs in the attached file. I

Re: [PATCH] buffer_funcs cleanup

2006-04-03 Thread Abdelrazak Younes
Martin Vermeer a écrit : On Mon, 2006-04-03 at 14:44 +0200, Abdelrazak Younes wrote: Is it the use of needsUpdateCounters (should maybe be needsCountersUpdate) that helps? Yes. This is important. I suggest you create a minimal patch doing only this. We test it, make sure it's OK, have

Re: [PATCH] buffer_funcs cleanup

2006-04-03 Thread Jean-Marc Lasgouttes
> "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes: Abdelrazak> IMHO even if there's no performance penalty on linux Abdelrazak> (which I really doubt on slow machine) the way the Abdelrazak> counters are updated is too heavy. We should instead Abdelrazak> maintains lists of

Re: [PATCH] buffer_funcs cleanup

2006-04-03 Thread Martin Vermeer
On Mon, Apr 03, 2006 at 05:05:56PM +0200, Abdelrazak Younes wrote: > Martin Vermeer a écrit : > >On Mon, 2006-04-03 at 14:44 +0200, Abdelrazak Younes wrote: > > > >>> Is it the use of > >>>needsUpdateCounters (should maybe be needsCountersUpdate) that helps? > >>> > >>Yes. > > > >This is