Re: [PATCH] caching translated string

2007-01-15 Thread Jean-Marc Lasgouttes
Abdelrazak == Abdelrazak Younes [EMAIL PROTECTED] writes: Abdelrazak Take this patch if you want to see some debug outputs. Abdelrazak It's working perfectly here and it's really a _huge_ Abdelrazak performance boost under Windows! So this was the cause of the mysterious delay when renumbering

Re: [PATCH] caching translated string

2007-01-15 Thread younes . a
Quoting Jean-Marc Lasgouttes [EMAIL PROTECTED]: Abdelrazak == Abdelrazak Younes [EMAIL PROTECTED] writes: Abdelrazak Take this patch if you want to see some debug outputs. Abdelrazak It's working perfectly here and it's really a _huge_ Abdelrazak performance boost under Windows! So this

Re: [PATCH] caching translated string

2007-01-15 Thread Jean-Marc Lasgouttes
> "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes: Abdelrazak> Take this patch if you want to see some debug outputs. Abdelrazak> It's working perfectly here and it's really a _huge_ Abdelrazak> performance boost under Windows! So this was the cause of the mysterious delay when

Re: [PATCH] caching translated string

2007-01-15 Thread younes . a
Quoting Jean-Marc Lasgouttes <[EMAIL PROTECTED]>: > > "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes: > > Abdelrazak> Take this patch if you want to see some debug outputs. > Abdelrazak> It's working perfectly here and it's really a _huge_ > Abdelrazak> performance boost under

Re: [PATCH] caching translated string

2007-01-14 Thread Edwin Leuven
i tried a new compile again and still get the crash with the patch... Edwin Leuven wrote: i compiled clean from scratch. have to run now... Abdelrazak Younes wrote: Edwin Leuven wrote: Abdelrazak Younes wrote: This is weird, I did not touch this part and it works fine on my platform. Maybe

Re: [PATCH] caching translated string

2007-01-14 Thread Edwin Leuven
i tried a new compile again and still get the crash with the patch... Edwin Leuven wrote: i compiled clean from scratch. have to run now... Abdelrazak Younes wrote: Edwin Leuven wrote: Abdelrazak Younes wrote: This is weird, I did not touch this part and it works fine on my platform. Maybe

Re: [PATCH] caching translated string

2007-01-13 Thread Enrico Forestieri
On Fri, Jan 12, 2007 at 11:07:55PM +0100, Abdelrazak Younes wrote: Abdelrazak Younes wrote: Could someone please test this under Linux? Enrico, if you could test it under Cygwin as well, that would be great. Take this patch if you want to see some debug outputs. It's working

Re: [PATCH] caching translated string

2007-01-13 Thread Abdelrazak Younes
Angus Leeming wrote: Abdelrazak Younes [EMAIL PROTECTED] writes: Abdelrazak Younes wrote: Could someone please test this under Linux? Enrico, if you could test it under Cygwin as well, that would be great. Take this patch if you want to see some debug outputs. It's working perfectly here and

Re: [PATCH] caching translated string

2007-01-13 Thread Abdelrazak Younes
Enrico Forestieri wrote: On Fri, Jan 12, 2007 at 11:07:55PM +0100, Abdelrazak Younes wrote: Abdelrazak Younes wrote: Could someone please test this under Linux? Enrico, if you could test it under Cygwin as well, that would be great. Take this patch if you want to see some debug outputs. It's

Re: [PATCH] caching translated string

2007-01-13 Thread Abdelrazak Younes
Abdelrazak Younes wrote: The problem is that we can't use this internal cache because. because... it does not work with our way of setting the language at each gettext call. Abdel.

Re: [PATCH] caching translated string

2007-01-13 Thread Enrico Forestieri
On Sat, Jan 13, 2007 at 09:39:44AM +0100, Abdelrazak Younes wrote: Yes, I wanted you to check that the translation process is still working correctly. Especially, at the section level. Could you set create a document with the report class and set a different language of one 'Chapter'

Re: [PATCH] caching translated string

2007-01-13 Thread Abdelrazak Younes
Enrico Forestieri wrote: On Sat, Jan 13, 2007 at 09:39:44AM +0100, Abdelrazak Younes wrote: Yes, I wanted you to check that the translation process is still working correctly. Especially, at the section level. Could you set create a document with the report class and set a different language

Re: [PATCH] caching translated string

2007-01-13 Thread Edwin Leuven
lyx crashes here with your patch: msvcr80d.dll!10202b13() [Frames below may be incorrect and/or missing, no symbols loaded for msvcr80d.dll] shlwapi.dll!77f643d0() msvcr80d.dll!1021866b() shlwapi.dll!77f643dd()

Re: [PATCH] caching translated string

2007-01-13 Thread Abdelrazak Younes
Edwin Leuven wrote: lyx crashes here with your patch: [...] std::basic_stringchar,std::char_traitschar,std::allocatorchar str=File|F) Line 46 + 0x19 bytesC++ lyx-qt4.exe!lyx::translateIfPossible(const This is weird, I did not touch this part and it works fine on my platform.

Re: [PATCH] caching translated string

2007-01-13 Thread Edwin Leuven
Abdelrazak Younes wrote: This is weird, I did not touch this part and it works fine on my platform. Maybe there is sth wrong when passing const ref instead of full docstring copy I cannot immagine why... Could you try to remove to do this change and try again? yes, this gets rid of the

Re: [PATCH] caching translated string

2007-01-13 Thread Abdelrazak Younes
Edwin Leuven wrote: Abdelrazak Younes wrote: This is weird, I did not touch this part and it works fine on my platform. Maybe there is sth wrong when passing const ref instead of full docstring copy I cannot immagine why... Could you try to remove to do this change and try again? yes, this

Re: [PATCH] caching translated string

2007-01-13 Thread Edwin Leuven
i compiled clean from scratch. have to run now... Abdelrazak Younes wrote: Edwin Leuven wrote: Abdelrazak Younes wrote: This is weird, I did not touch this part and it works fine on my platform. Maybe there is sth wrong when passing const ref instead of full docstring copy I cannot immagine

Re: [PATCH] caching translated string

2007-01-13 Thread Abdelrazak Younes
Edwin Leuven wrote: i compiled clean from scratch. have to run now... OK. I have my LyxLex cleanup on my local tree so this is maybe interfering at this point. But this is still weird. Abdel.

Re: [PATCH] caching translated string

2007-01-13 Thread Abdelrazak Younes
Abdelrazak Younes wrote: Edwin Leuven wrote: i compiled clean from scratch. have to run now... OK. I have my LyxLex cleanup on my local tree so this is maybe interfering at this point. But this is still weird. I cannot reproduce the crash with a clean tree either. Abdel.

Re: [PATCH] caching translated string

2007-01-13 Thread Georg Baum
Am Samstag, 13. Januar 2007 12:35 schrieb Abdelrazak Younes: Abdelrazak Younes wrote: Edwin Leuven wrote: i compiled clean from scratch. have to run now... OK. I have my LyxLex cleanup on my local tree so this is maybe interfering at this point. But this is still weird. I cannot

Re: [PATCH] caching translated string

2007-01-13 Thread Abdelrazak Younes
Georg Baum wrote: Am Samstag, 13. Januar 2007 12:35 schrieb Abdelrazak Younes: Abdelrazak Younes wrote: Edwin Leuven wrote: i compiled clean from scratch. have to run now... OK. I have my LyxLex cleanup on my local tree so this is maybe interfering at this point. But this is still weird. I

Re: [PATCH] caching translated string

2007-01-13 Thread Peter Kümmel
Maybe this helps against the crashes, it then there will be a copy again: Abdelrazak Younes wrote: Abdelrazak Younes wrote: Could someone please test this under Linux? Enrico, if you could test it under Cygwin as well, that would be great. Take this patch if you want to see some debug

Re: [PATCH] caching translated string

2007-01-13 Thread Abdelrazak Younes
Peter Kümmel wrote: Maybe this helps against the crashes, it then there will be a copy again: [...] - return from_ascii(m); + return empty_string; + CacheType::iterator it = cache_.find(m); + if (it != cache_.end()) { +

Re: [PATCH] caching translated string

2007-01-13 Thread Enrico Forestieri
On Fri, Jan 12, 2007 at 11:07:55PM +0100, Abdelrazak Younes wrote: > Abdelrazak Younes wrote: > > Could someone please test this under Linux? > > > > Enrico, if you could test it under Cygwin as well, that would be great. > > Take this patch if you want to see some debug outputs. It's working

Re: [PATCH] caching translated string

2007-01-13 Thread Abdelrazak Younes
Angus Leeming wrote: Abdelrazak Younes <[EMAIL PROTECTED]> writes: Abdelrazak Younes wrote: Could someone please test this under Linux? Enrico, if you could test it under Cygwin as well, that would be great. Take this patch if you want to see some debug outputs. It's working perfectly here

Re: [PATCH] caching translated string

2007-01-13 Thread Abdelrazak Younes
Enrico Forestieri wrote: On Fri, Jan 12, 2007 at 11:07:55PM +0100, Abdelrazak Younes wrote: Abdelrazak Younes wrote: Could someone please test this under Linux? Enrico, if you could test it under Cygwin as well, that would be great. Take this patch if you want to see some debug outputs. It's

Re: [PATCH] caching translated string

2007-01-13 Thread Abdelrazak Younes
Abdelrazak Younes wrote: The problem is that we can't use this internal cache because. because... it does not work with our way of setting the language at each gettext call. Abdel.

Re: [PATCH] caching translated string

2007-01-13 Thread Enrico Forestieri
On Sat, Jan 13, 2007 at 09:39:44AM +0100, Abdelrazak Younes wrote: > Yes, I wanted you to check that the translation process is still working > correctly. Especially, at the section level. Could you set create a > document with the report class and set a different language of one > 'Chapter'

Re: [PATCH] caching translated string

2007-01-13 Thread Abdelrazak Younes
Enrico Forestieri wrote: On Sat, Jan 13, 2007 at 09:39:44AM +0100, Abdelrazak Younes wrote: Yes, I wanted you to check that the translation process is still working correctly. Especially, at the section level. Could you set create a document with the report class and set a different language

Re: [PATCH] caching translated string

2007-01-13 Thread Edwin Leuven
lyx crashes here with your patch: msvcr80d.dll!10202b13() [Frames below may be incorrect and/or missing, no symbols loaded for msvcr80d.dll] shlwapi.dll!77f643d0() msvcr80d.dll!1021866b() shlwapi.dll!77f643dd()

Re: [PATCH] caching translated string

2007-01-13 Thread Abdelrazak Younes
Edwin Leuven wrote: lyx crashes here with your patch: [...] std::basic_string & str="File|F") Line 46 + 0x19 bytesC++ lyx-qt4.exe!lyx::translateIfPossible(const This is weird, I did not touch this part and it works fine on my platform.

Re: [PATCH] caching translated string

2007-01-13 Thread Edwin Leuven
Abdelrazak Younes wrote: This is weird, I did not touch this part and it works fine on my platform. Maybe there is sth wrong when passing const ref instead of full docstring copy I cannot immagine why... Could you try to remove to do this change and try again? yes, this gets rid of the

Re: [PATCH] caching translated string

2007-01-13 Thread Abdelrazak Younes
Edwin Leuven wrote: Abdelrazak Younes wrote: This is weird, I did not touch this part and it works fine on my platform. Maybe there is sth wrong when passing const ref instead of full docstring copy I cannot immagine why... Could you try to remove to do this change and try again? yes, this

Re: [PATCH] caching translated string

2007-01-13 Thread Edwin Leuven
i compiled clean from scratch. have to run now... Abdelrazak Younes wrote: Edwin Leuven wrote: Abdelrazak Younes wrote: This is weird, I did not touch this part and it works fine on my platform. Maybe there is sth wrong when passing const ref instead of full docstring copy I cannot immagine

Re: [PATCH] caching translated string

2007-01-13 Thread Abdelrazak Younes
Edwin Leuven wrote: i compiled clean from scratch. have to run now... OK. I have my LyxLex cleanup on my local tree so this is maybe interfering at this point. But this is still weird. Abdel.

Re: [PATCH] caching translated string

2007-01-13 Thread Abdelrazak Younes
Abdelrazak Younes wrote: Edwin Leuven wrote: i compiled clean from scratch. have to run now... OK. I have my LyxLex cleanup on my local tree so this is maybe interfering at this point. But this is still weird. I cannot reproduce the crash with a clean tree either. Abdel.

Re: [PATCH] caching translated string

2007-01-13 Thread Georg Baum
Am Samstag, 13. Januar 2007 12:35 schrieb Abdelrazak Younes: > Abdelrazak Younes wrote: > > Edwin Leuven wrote: > >> i compiled clean from scratch. have to run now... > > > > OK. I have my LyxLex cleanup on my local tree so this is maybe > > interfering at this point. But this is still weird. >

Re: [PATCH] caching translated string

2007-01-13 Thread Abdelrazak Younes
Georg Baum wrote: Am Samstag, 13. Januar 2007 12:35 schrieb Abdelrazak Younes: Abdelrazak Younes wrote: Edwin Leuven wrote: i compiled clean from scratch. have to run now... OK. I have my LyxLex cleanup on my local tree so this is maybe interfering at this point. But this is still weird. I

Re: [PATCH] caching translated string

2007-01-13 Thread Peter Kümmel
Maybe this helps against the crashes, it then there will be a copy again: Abdelrazak Younes wrote: > Abdelrazak Younes wrote: >> Could someone please test this under Linux? >> >> Enrico, if you could test it under Cygwin as well, that would be great. > > Take this patch if you want to see some

Re: [PATCH] caching translated string

2007-01-13 Thread Abdelrazak Younes
Peter Kümmel wrote: Maybe this helps against the crashes, it then there will be a copy again: [...] - return from_ascii(m); + return empty_string; + CacheType::iterator it = cache_.find(m); + if (it != cache_.end()) { +

[PATCH] caching translated string

2007-01-12 Thread Abdelrazak Younes
Could someone please test this under Linux? Enrico, if you could test it under Cygwin as well, that would be great. Thanks in advance, Abdel. Index: messages.C === --- messages.C (revision 16645) +++ messages.C (working copy) @@

Re: [PATCH] caching translated string

2007-01-12 Thread Abdelrazak Younes
Abdelrazak Younes wrote: Could someone please test this under Linux? Enrico, if you could test it under Cygwin as well, that would be great. Take this patch if you want to see some debug outputs. It's working perfectly here and it's really a _huge_ performance boost under Windows! Abdel.

Re: [PATCH] caching translated string

2007-01-12 Thread Angus Leeming
Abdelrazak Younes [EMAIL PROTECTED] writes: Abdelrazak Younes wrote: Could someone please test this under Linux? Enrico, if you could test it under Cygwin as well, that would be great. Take this patch if you want to see some debug outputs. It's working perfectly here and it's really a

[PATCH] caching translated string

2007-01-12 Thread Abdelrazak Younes
Could someone please test this under Linux? Enrico, if you could test it under Cygwin as well, that would be great. Thanks in advance, Abdel. Index: messages.C === --- messages.C (revision 16645) +++ messages.C (working copy) @@

Re: [PATCH] caching translated string

2007-01-12 Thread Abdelrazak Younes
Abdelrazak Younes wrote: Could someone please test this under Linux? Enrico, if you could test it under Cygwin as well, that would be great. Take this patch if you want to see some debug outputs. It's working perfectly here and it's really a _huge_ performance boost under Windows! Abdel.

Re: [PATCH] caching translated string

2007-01-12 Thread Angus Leeming
Abdelrazak Younes <[EMAIL PROTECTED]> writes: > Abdelrazak Younes wrote: > > Could someone please test this under Linux? > > > > Enrico, if you could test it under Cygwin as well, that would be great. > > Take this patch if you want to see some debug outputs. It's working > perfectly here and