Re: Updated [Re: [PATCH] Branch/Note, finally :-)]

2003-07-07 Thread Michael Schmitt
Actually, the more I think about it, the more I come to the conclusion that your approach mixes at least two different concepts which should be separated: I. Insets that show/hide parts of the document - i.e. Branch, Comment, Note, Greyedout - Can contain very large contents up to a complete

Re: Updated [Re: [PATCH] Branch/Note, finally :-)]

2003-07-07 Thread Juergen Spitzmueller
Michael Schmitt wrote: I am a bit confused. I thought we agreed that each branch/note inset should have two properties that correspond to I. and II. above. That means, in the document dialog, you can both activate/deactive an inset _and_ define its position (or, more general, its appearance)

Re: Updated [Re: [PATCH] Branch/Note, finally :-)]

2003-07-07 Thread Michael Schmitt
Actually, the more I think about it, the more I come to the conclusion that your approach mixes at least two different concepts which should be separated: I. Insets that show/hide parts of the document -> i.e. Branch, Comment, Note, Greyedout -> Can contain very large contents up to a complete

Re: Updated [Re: [PATCH] Branch/Note, finally :-)]

2003-07-07 Thread Juergen Spitzmueller
Michael Schmitt wrote: > I am a bit confused. I thought we agreed that each branch/note inset > should have two properties that correspond to I. and II. above. That > means, in the document dialog, you can both activate/deactive an inset > _and_ define its position (or, more general, its

Re: Updated [Re: [PATCH] Branch/Note, finally :-)]

2003-07-06 Thread Martin Vermeer
On Thu, Jul 03, 2003 at 10:45:30AM +0200, Juergen Spitzmueller spake thusly: ... Actually, the more I think about it, the more I come to the conclusion that your approach mixes at least two different concepts which should be separated: I. Insets that show/hide parts of the document -

Re: Updated [Re: [PATCH] Branch/Note, finally :-)]

2003-07-06 Thread Juergen Spitzmueller
Martin Vermeer wrote: You have a point. Actually I think I'll drop petite for now (I don't seem to find a LaTeX env of that name -- I did see one somewhere). I just had a look. There is relsize.sty, but this seems only to change the fontsize of standard environments (could be used to make

Re: Updated [Re: [PATCH] Branch/Note, finally :-)]

2003-07-06 Thread John Levon
On Sun, Jul 06, 2003 at 07:28:22PM +0200, Juergen Spitzmueller wrote: Ia: Note, Comment, Greyedout -- insetnote Ib: Branch -- insetbranch (new). What would your preference be? It sounds logical to me, since (intention-wise) an annotation (Ia) is a completely different thing than

Re: Updated [Re: [PATCH] Branch/Note, finally :-)]

2003-07-06 Thread Martin Vermeer
On Sun, Jul 06, 2003 at 07:13:20PM +0100, John Levon spake thusly: ... Or couldn't we have a branch editor in the Document Settings dialog where the user can name branches, and set the eventual effect of each named branch ? Nah. That's what we need your character styles for :-) Do one

Re: Updated [Re: [PATCH] Branch/Note, finally :-)]

2003-07-06 Thread Martin Vermeer
On Thu, Jul 03, 2003 at 10:45:30AM +0200, Juergen Spitzmueller spake thusly: > ... > Actually, the more I think about it, the more I come to the conclusion that > your approach mixes at least two different concepts which should be > separated: > > I. Insets that show/hide parts of the document

Re: Updated [Re: [PATCH] Branch/Note, finally :-)]

2003-07-06 Thread Juergen Spitzmueller
Martin Vermeer wrote: > You have a point. Actually I think I'll drop petite for now (I don't > seem to find a LaTeX env of that name -- I did see one somewhere). I just had a look. There is relsize.sty, but this seems only to change the fontsize of standard environments (could be used to make

Re: Updated [Re: [PATCH] Branch/Note, finally :-)]

2003-07-06 Thread John Levon
On Sun, Jul 06, 2003 at 07:28:22PM +0200, Juergen Spitzmueller wrote: > > Ia: Note, Comment, Greyedout <--> insetnote > > > > Ib: Branch <--> insetbranch (new). > > > > What would your preference be? > > It sounds logical to me, since (intention-wise) an annotation (Ia) is a > completely

Re: Updated [Re: [PATCH] Branch/Note, finally :-)]

2003-07-06 Thread Martin Vermeer
On Sun, Jul 06, 2003 at 07:13:20PM +0100, John Levon spake thusly: ... > Or couldn't we have a branch editor in the Document Settings dialog > where the user can name branches, and set the eventual effect of each > named branch ? Nah. That's what we need your "character styles" for :-) Do one

Re: Updated [Re: [PATCH] Branch/Note, finally :-)]

2003-07-03 Thread Juergen Spitzmueller
Martin Vermeer wrote: Ah. That's not right. Perhaps we should continue to call it Note, not blind. What would be most suitable name? I think this string is defined in factory.C line 74. You could try changing it. I think Note is best. People are used to it. But the complete inset (i.e. the

Re: Updated [Re: [PATCH] Branch/Note, finally :-)]

2003-07-03 Thread Juergen Spitzmueller
Martin Vermeer wrote: > Ah. That's not right. Perhaps we should continue to call it "Note", > not "blind". What would be most suitable name? I think this string is > defined in factory.C line 74. You could try changing it. I think "Note" is best. People are used to it. But the complete inset

Updated [Re: [PATCH] Branch/Note, finally :-)]

2003-07-02 Thread Martin Vermeer
On Tue, Jul 01, 2003 at 08:11:19PM +0200, Juergen Spitzmueller spake thusly: Martin Vermeer wrote: Here it is... working and all -- for me at least. Can you send an updated patch, please? It does not apply cleanly anymore. Thanks, Juergen OK Jürgen, here is the updated patch (I do not

Re: Updated [Re: [PATCH] Branch/Note, finally :-)]

2003-07-02 Thread Juergen Spitzmueller
Martin Vermeer wrote: OK Jürgen, here is the updated patch Thanks, Martin. Compiling now (though I don't know if I can test much this week). Juergen.

Re: Updated [Re: [PATCH] Branch/Note, finally :-)]

2003-07-02 Thread Andre Poenitz
On Wed, Jul 02, 2003 at 01:09:57PM +0300, Martin Vermeer wrote: OK Jürgen, here is the updated patch Is this something that should go into CVS at some time or just some 'private add-on'? If the former I have some minor nitpicks: Index: bufferparams.C

Re: Updated [Re: [PATCH] Branch/Note, finally :-)]

2003-07-02 Thread Andre Poenitz
On Wed, Jul 02, 2003 at 02:11:08PM +0300, Martin Vermeer wrote: + branch_sel = ; This is not needed. Sure? Sure. branch_sel is a std::string. + } else if ((tmptok == Note) || (tmptok == comment) + || (tmptok ==blind) ||

Re: Updated [Re: [PATCH] Branch/Note, finally :-)]

2003-07-02 Thread Martin Vermeer
On Wed, Jul 02, 2003 at 01:23:09PM +0200, Andre Poenitz spake thusly: On Wed, Jul 02, 2003 at 02:11:08PM +0300, Martin Vermeer wrote: Should not be needed if all branches end in 'return'. gcc doesn't seem to think so :-( I think it does. Otherwise we'd get much more warnings in

Re: Updated [Re: [PATCH] Branch/Note, finally :-)]

2003-07-02 Thread Andre Poenitz
On Wed, Jul 02, 2003 at 04:24:26PM +0300, Martin Vermeer wrote: Don't you think I've tried? Not too hard, actually. Currently I have switch (cmd.action) { case LFUN_INSET_MODIFY: { InsetNoteParams params; InsetNoteMailer::string2params(cmd.argument,

Re: Updated [Re: [PATCH] Branch/Note, finally :-)]

2003-07-02 Thread Martin Vermeer
On Wed, Jul 02, 2003 at 03:04:49PM +0200, Andre Poenitz spake thusly: On Wed, Jul 02, 2003 at 04:24:26PM +0300, Martin Vermeer wrote: Don't you think I've tried? Not too hard, actually. Currently I have switch (cmd.action) { case LFUN_INSET_MODIFY: {

Re: Updated [Re: [PATCH] Branch/Note, finally :-)]

2003-07-02 Thread Andre Poenitz
On Wed, Jul 02, 2003 at 04:32:00PM +0300, Martin Vermeer wrote: Is it OK to substitute return UNDISPATCHED here? The safe way would be to call localDispatch in the base (like the default branch), but it shouldn't make much of a difference in this case. Andre' -- Those who desire to give up

Re: Updated [Re: [PATCH] Branch/Note, finally :-)]

2003-07-02 Thread Juergen Spitzmueller
Martin Vermeer wrote: OK Jürgen, here is the updated patch From a first glance (without looking at the source): - What's the Note state for which is used by default and does not do anything obviously? - The branch input field does not get enabled after switching the combo to branch. I have

Re: Updated [Re: [PATCH] Branch/Note, finally :-)]

2003-07-02 Thread John Levon
On Wed, Jul 02, 2003 at 04:33:07PM +0200, Juergen Spitzmueller wrote: From a first glance (without looking at the source): - What's the Note state for which is used by default and does not do anything obviously? Sorry to be a pain Martin, but can I get up to date screenshots (for Qt ?)

Re: Updated [Re: [PATCH] Branch/Note, finally :-)]

2003-07-02 Thread Jose' Matos
On Wednesday 02 July 2003 15:33, Juergen Spitzmueller wrote: Also, you should get rid of the comment environment and hassle José to let lyx2lyx convert comment environments to comment insets. Drop me a note when this code is ready to cvs, it should be easy to translate it. :-) Apart from

Re: Updated [Re: [PATCH] Branch/Note, finally :-)]

2003-07-02 Thread Martin Vermeer
On Wed, Jul 02, 2003 at 06:54:30PM +0100, John Levon spake thusly: On Wed, Jul 02, 2003 at 04:33:07PM +0200, Juergen Spitzmueller wrote: From a first glance (without looking at the source): - What's the Note state for which is used by default and does not do anything obviously?

Re: Updated [Re: [PATCH] Branch/Note, finally :-)]

2003-07-02 Thread Martin Vermeer
On Wed, Jul 02, 2003 at 04:33:07PM +0200, Juergen Spitzmueller spake thusly: Martin Vermeer wrote: OK Jürgen, here is the updated patch From a first glance (without looking at the source): - What's the Note state for which is used by default and does not do anything obviously? ? I

Re: Updated [Re: [PATCH] Branch/Note, finally :-)]

2003-07-02 Thread Juergen Spitzmueller
Martin Vermeer wrote: - What's the Note state for which is used by default and does not do anything obviously? ? I think I called it blind note. Of course names are not fixed yet, just working titles (disabled?, post-it?) Yes, there is a blind note that works analogous to the old Note. But

Re: Updated [Re: [PATCH] Branch/Note, finally :-)]

2003-07-02 Thread John Levon
On Wed, Jul 02, 2003 at 11:42:04PM +0300, Martin Vermeer wrote: www.hut.fi/~mvermeer/branch7.jpeg Thanks. I don't like the Note dialog (apart from the branch list issue mentioned already). The Type thing seems unclear and non-obvious. I haven't thought through a nicer UI yet. It may just

Re: Updated [Re: [PATCH] Branch/Note, finally :-)]

2003-07-02 Thread Martin Vermeer
On Wed, Jul 02, 2003 at 10:10:32PM +0100, John Levon spake thusly: On Wed, Jul 02, 2003 at 11:42:04PM +0300, Martin Vermeer wrote: www.hut.fi/~mvermeer/branch7.jpeg Thanks. I don't like the Note dialog (apart from the branch list issue mentioned already). The Type thing seems

Re: Updated [Re: [PATCH] Branch/Note, finally :-)]

2003-07-02 Thread Martin Vermeer
On Wed, Jul 02, 2003 at 10:55:54PM +0200, Juergen Spitzmueller spake thusly: Martin Vermeer wrote: - What's the Note state for which is used by default and does not do anything obviously? ? I think I called it blind note. Of course names are not fixed yet, just working titles

Updated [Re: [PATCH] Branch/Note, finally :-)]

2003-07-02 Thread Martin Vermeer
On Tue, Jul 01, 2003 at 08:11:19PM +0200, Juergen Spitzmueller spake thusly: > Martin Vermeer wrote: > > Here it is... working and all -- for me at least. > > Can you send an updated patch, please? It does not apply cleanly anymore. > > Thanks, > Juergen OK Jürgen, here is the updated patch

Re: Updated [Re: [PATCH] Branch/Note, finally :-)]

2003-07-02 Thread Juergen Spitzmueller
Martin Vermeer wrote: > OK Jürgen, here is the updated patch Thanks, Martin. Compiling now (though I don't know if I can test much this week). Juergen.

Re: Updated [Re: [PATCH] Branch/Note, finally :-)]

2003-07-02 Thread Andre Poenitz
On Wed, Jul 02, 2003 at 01:09:57PM +0300, Martin Vermeer wrote: > OK Jürgen, here is the updated patch Is this something that should go into CVS at some time or just some 'private add-on'? If the former I have some minor nitpicks: > Index: bufferparams.C >

Re: Updated [Re: [PATCH] Branch/Note, finally :-)]

2003-07-02 Thread Andre Poenitz
On Wed, Jul 02, 2003 at 02:11:08PM +0300, Martin Vermeer wrote: > > > + branch_sel = ""; > > > > This is not needed. > > Sure? Sure. branch_sel is a std::string. > > > + } else if ((tmptok == "Note") || (tmptok == "comment") > > > + || (tmptok

Re: Updated [Re: [PATCH] Branch/Note, finally :-)]

2003-07-02 Thread Martin Vermeer
On Wed, Jul 02, 2003 at 01:23:09PM +0200, Andre Poenitz spake thusly: > > On Wed, Jul 02, 2003 at 02:11:08PM +0300, Martin Vermeer wrote: > > > Should not be needed if all branches end in 'return'. > > > > gcc doesn't seem to think so :-( > > I think it does. > > Otherwise we'd get much more

Re: Updated [Re: [PATCH] Branch/Note, finally :-)]

2003-07-02 Thread Andre Poenitz
On Wed, Jul 02, 2003 at 04:24:26PM +0300, Martin Vermeer wrote: > Don't you think I've tried? Not too hard, actually. > Currently I have > > switch (cmd.action) { > case LFUN_INSET_MODIFY: > { > InsetNoteParams params; >

Re: Updated [Re: [PATCH] Branch/Note, finally :-)]

2003-07-02 Thread Martin Vermeer
On Wed, Jul 02, 2003 at 03:04:49PM +0200, Andre Poenitz spake thusly: > > On Wed, Jul 02, 2003 at 04:24:26PM +0300, Martin Vermeer wrote: > > Don't you think I've tried? > > Not too hard, actually. > > > Currently I have > > > > switch (cmd.action) { > > case LFUN_INSET_MODIFY: > >

Re: Updated [Re: [PATCH] Branch/Note, finally :-)]

2003-07-02 Thread Andre Poenitz
On Wed, Jul 02, 2003 at 04:32:00PM +0300, Martin Vermeer wrote: > Is it OK to substitute "return UNDISPATCHED" here? The safe way would be to call localDispatch in the base (like the default branch), but it shouldn't make much of a difference in this case. Andre' -- Those who desire to give up

Re: Updated [Re: [PATCH] Branch/Note, finally :-)]

2003-07-02 Thread Juergen Spitzmueller
Martin Vermeer wrote: > OK Jürgen, here is the updated patch From a first glance (without looking at the source): - What's the "Note" state for which is used by default and does not do anything obviously? - The "branch" input field does not get enabled after switching the combo to "branch". I

Re: Updated [Re: [PATCH] Branch/Note, finally :-)]

2003-07-02 Thread John Levon
On Wed, Jul 02, 2003 at 04:33:07PM +0200, Juergen Spitzmueller wrote: > From a first glance (without looking at the source): > > - What's the "Note" state for which is used by default and does not do > anything obviously? Sorry to be a pain Martin, but can I get up to date screenshots (for

Re: Updated [Re: [PATCH] Branch/Note, finally :-)]

2003-07-02 Thread Jose' Matos
On Wednesday 02 July 2003 15:33, Juergen Spitzmueller wrote: > Also, you should get rid of the comment environment and hassle José to let > lyx2lyx convert comment environments to comment insets. Drop me a note when this code is ready to cvs, it should be easy to translate it. :-) > Apart

Re: Updated [Re: [PATCH] Branch/Note, finally :-)]

2003-07-02 Thread Martin Vermeer
On Wed, Jul 02, 2003 at 06:54:30PM +0100, John Levon spake thusly: > > On Wed, Jul 02, 2003 at 04:33:07PM +0200, Juergen Spitzmueller wrote: > > > From a first glance (without looking at the source): > > > > - What's the "Note" state for which is used by default and does not do > > anything

Re: Updated [Re: [PATCH] Branch/Note, finally :-)]

2003-07-02 Thread Martin Vermeer
On Wed, Jul 02, 2003 at 04:33:07PM +0200, Juergen Spitzmueller spake thusly: > Martin Vermeer wrote: > > OK Jürgen, here is the updated patch > > From a first glance (without looking at the source): > > - What's the "Note" state for which is used by default and does not do > anything

Re: Updated [Re: [PATCH] Branch/Note, finally :-)]

2003-07-02 Thread Juergen Spitzmueller
Martin Vermeer wrote: > > - What's the "Note" state for which is used by default and does not do > > anything obviously? > > ? I think I called it "blind" note. Of course names are not fixed yet, > just working titles ("disabled"?, "post-it"?) Yes, there is a "blind" note that works analogous to

Re: Updated [Re: [PATCH] Branch/Note, finally :-)]

2003-07-02 Thread John Levon
On Wed, Jul 02, 2003 at 11:42:04PM +0300, Martin Vermeer wrote: > www.hut.fi/~mvermeer/branch7.jpeg Thanks. I don't like the Note dialog (apart from the branch list issue mentioned already). The "Type" thing seems unclear and non-obvious. I haven't thought through a nicer UI yet. It may

Re: Updated [Re: [PATCH] Branch/Note, finally :-)]

2003-07-02 Thread Martin Vermeer
On Wed, Jul 02, 2003 at 10:10:32PM +0100, John Levon spake thusly: > On Wed, Jul 02, 2003 at 11:42:04PM +0300, Martin Vermeer wrote: > > > www.hut.fi/~mvermeer/branch7.jpeg > > Thanks. I don't like the Note dialog (apart from the branch list issue > mentioned already). The "Type" thing

Re: Updated [Re: [PATCH] Branch/Note, finally :-)]

2003-07-02 Thread Martin Vermeer
On Wed, Jul 02, 2003 at 10:55:54PM +0200, Juergen Spitzmueller spake thusly: > > Martin Vermeer wrote: > > > - What's the "Note" state for which is used by default and does not do > > > anything obviously? > > > > ? I think I called it "blind" note. Of course names are not fixed yet, > > just