Re: Work on Windows installer

2020-06-01 Thread Scott Kostyshak
On Mon, Jun 01, 2020 at 12:02:41PM -0400, Richard Kimberly Heck wrote: > > Nice work! I'm going to build the 2.3.5 tarball probably today. I'll use > the old installer for the official one, but we can release 'testing' > installers built from this code, as well (including the 64 bit binary). > We

Re: Work on Windows installer

2020-06-01 Thread Yu Jin
Am Mo., 1. Juni 2020 um 15:43 Uhr schrieb Kornel Benko : > Instead of changing strings, it should be possible to change the handling > of > the translatable strings (e.g. replace "\r\n" to "$\r$\n" on the fly) > Makes sense, why did I not think about that. I have done that now and replaced

Re: Work on Windows installer

2020-06-01 Thread Richard Kimberly Heck
Nice work! I'm going to build the 2.3.5 tarball probably today. I'll use the old installer for the official one, but we can release 'testing' installers built from this code, as well (including the 64 bit binary). We can advertise those just on the lists, as we did the last time. That should get

Re: Work on Windows installer

2020-06-01 Thread Richard Kimberly Heck
On 6/1/20 11:23 AM, Jean-Marc Lasgouttes wrote: > Le 01/06/2020 à 17:19, Jürgen Spitzmüller a écrit : >> Am Montag, den 01.06.2020, 15:43 +0200 schrieb Kornel Benko: >>> The position of these files could be >>> development/Win32/packaging/installerCommon/lang/*.nsh >>> to be used by both

Re: Work on Windows installer

2020-06-01 Thread Richard Kimberly Heck
On 6/1/20 9:43 AM, Kornel Benko wrote: > Am Mon, 1 Jun 2020 14:56:47 +0200 > schrieb Yu Jin : > >> Am Mo., 1. Juni 2020 um 14:01 Uhr schrieb Kornel Benko :0 >> >>> From what I can see, the patch adds only Windows install in extra dir. >>> >>> The duplication of language-files >>>

Re: Work on Windows installer

2020-06-01 Thread Jean-Marc Lasgouttes
Le 01/06/2020 à 17:19, Jürgen Spitzmüller a écrit : Am Montag, den 01.06.2020, 15:43 +0200 schrieb Kornel Benko: The position of these files could be development/Win32/packaging/installerCommon/lang/*.nsh to be used by both installers. I understand the old installer will we ditched

Re: Work on Windows installer

2020-06-01 Thread Jürgen Spitzmüller
Am Montag, den 01.06.2020, 15:43 +0200 schrieb Kornel Benko: > The position of these files could be > development/Win32/packaging/installerCommon/lang/*.nsh > to be used by both installers. I understand the old installer will we ditched anyway after the new one has been sufficiently

Re: Work on Windows installer

2020-06-01 Thread Kornel Benko
Am Mon, 1 Jun 2020 14:56:47 +0200 schrieb Yu Jin : > Am Mo., 1. Juni 2020 um 14:01 Uhr schrieb Kornel Benko :0 > > > From what I can see, the patch adds only Windows install in extra dir. > > > > The duplication of language-files > > development/Win32/packaging/installer2/src/lang/*.nsh

Re: Work on Windows installer

2020-06-01 Thread Yu Jin
Am Mo., 1. Juni 2020 um 14:01 Uhr schrieb Kornel Benko :0 > From what I can see, the patch adds only Windows install in extra dir. > > The duplication of language-files > development/Win32/packaging/installer2/src/lang/*.nsh > vs > development/Win32/packaging/installer/lang/*.nsh

Re: Work on Windows installer

2020-06-01 Thread Kornel Benko
Am Mon, 01 Jun 2020 13:36:51 +0200 schrieb Jürgen Spitzmüller : > Am Montag, den 01.06.2020, 12:40 +0200 schrieb Yu Jin: > > > Track also has a size limit, though (2 MB per attachment). > > > > Ticked created #11882 > > Thanks. I suspect there are not many (are there any?) people who feel >

Re: Work on Windows installer

2020-06-01 Thread Jürgen Spitzmüller
Am Montag, den 01.06.2020, 12:40 +0200 schrieb Yu Jin: > > Track also has a size limit, though (2 MB per attachment). > > Ticked created #11882 Thanks. I suspect there are not many (are there any?) people who feel competent to comment on this. I propose to go ahead and commit to master so it can

Re: Work on Windows installer

2020-06-01 Thread Yu Jin
Am Mo., 1. Juni 2020 um 10:16 Uhr schrieb Jürgen Spitzmüller : > Am Montag, den 01.06.2020, 10:13 +0200 schrieb Yu Jin: > > What if I create a Ticket on track and upload it there? > > Track also has a size limit, though (2 MB per attachment). > Ticked created #11882

Re: Work on Windows installer

2020-06-01 Thread Jürgen Spitzmüller
Am Montag, den 01.06.2020, 10:13 +0200 schrieb Yu Jin: > What if I create a Ticket on track and upload it there? Track also has a size limit, though (2 MB per attachment). Jürgen signature.asc Description: This is a digitally signed message part -- lyx-devel mailing list

Re: Work on Windows installer

2020-06-01 Thread Yu Jin
Am Mo., 1. Juni 2020 um 08:56 Uhr schrieb Jürgen Spitzmüller : > Am Samstag, den 30.05.2020, 09:38 +0200 schrieb Yu Jin: > > I think I'm finished with the new installer... I have tested a few > > obvious cases and how the installer behaves there makes sense imho. > > How do I best share my work?

Re: Work on Windows installer

2020-06-01 Thread Jürgen Spitzmüller
Am Samstag, den 30.05.2020, 09:38 +0200 schrieb Yu Jin: > I think I'm finished with the new installer... I have tested a few > obvious cases and how the installer behaves there makes sense imho. > How do I best share my work? The patch would have a couple of > thousands lines, I think there was a

Re: Work on Windows installer

2020-05-30 Thread Yu Jin
I think I'm finished with the new installer... I have tested a few obvious cases and how the installer behaves there makes sense imho. How do I best share my work? The patch would have a couple of thousands lines, I think there was a limit in the mailing list? Eugene -- lyx-devel mailing list

Re: Work on Windows installer

2020-05-20 Thread Yu Jin
A quick update on this. So far I have made good progress imo, some things are finished already, I will list the big ones now: 1. The whole installer UI including the LatexFolder page, which I have recreated with NSIS dialog designer. 2. Code for searching latex distribution, which is related to

Re: Work on Windows installer

2020-05-16 Thread Kornel Benko
Am Sat, 16 May 2020 21:08:44 +0200 schrieb Yu Jin : > Am Sa., 16. Mai 2020 um 08:45 Uhr schrieb Jürgen Spitzmüller >: > > > The list of language supported by LyX is lib/languages. > > > Alright, I have compared the languages in that file with the available > dictionaries in lyxsvn. There are

Re: Work on Windows installer

2020-05-16 Thread Yu Jin
Am Sa., 16. Mai 2020 um 08:45 Uhr schrieb Jürgen Spitzmüller : > The list of language supported by LyX is lib/languages. > Alright, I have compared the languages in that file with the available dictionaries in lyxsvn. There are more supported languages than available dictionaries. In particular I

Re: Work on Windows installer

2020-05-16 Thread Jürgen Spitzmüller
Am Freitag, den 15.05.2020, 18:56 +0200 schrieb Yu Jin: > There are more dictionaries available in lyxsvn than defined in the > Windows installer. I have searched the web for a sorted list of > language names in their native form, but didn't find any. How do you > usually get native names and how

Re: Work on Windows installer

2020-05-15 Thread Yu Jin
There are more dictionaries available in lyxsvn than defined in the Windows installer. I have searched the web for a sorted list of language names in their native form, but didn't find any. How do you usually get native names and how do you sort them? (Well I could get the unsorted names, but I

Re: Work on Windows installer

2020-05-14 Thread Jean-Marc Lasgouttes
Le 13/05/2020 à 13:04, Pavel Sanda a écrit : - Any major rewrite better be finished before we start releasing 2.4 betas so it gets proper testing. JMarc did not share any release plans yet, but my sense is we are talking about couple months(?). My plan has always been clear: release an

Re: Work on Windows installer

2020-05-13 Thread Yu Jin
Am Mi., 13. Mai 2020 um 18:58 Uhr schrieb Richard Kimberly Heck < rikih...@lyx.org>: > On 5/13/20 7:04 AM, Pavel Sanda wrote: > > Thanks for sharing all these thoughts. > > Let me add my thanks, too. This is all old code and a bit of a mess, so > it certainly could use a re-write. > > > > If you

Re: Work on Windows installer

2020-05-13 Thread Richard Kimberly Heck
On 5/13/20 7:04 AM, Pavel Sanda wrote: > On Wed, May 13, 2020 at 07:30:51AM +0200, Yu Jin wrote: >> 1. I could rewrite everything that I think is doable in a much better way, >> this would mean actually creating a new installer, then checking the old >> one function by function and then deciding

Re: Work on Windows installer

2020-05-13 Thread Richard Kimberly Heck
On 5/13/20 3:14 AM, Yu Jin wrote: > Am Mi., 13. Mai 2020 um 07:47 Uhr schrieb Jürgen Spitzmüller > mailto:sp...@lyx.org>>: > > Generally, having well documented and readable code is a good thing. A > non-well written installer distracts developers and is bug prone. So > I'd second your

Re: Work on Windows installer

2020-05-13 Thread Pavel Sanda
On Wed, May 13, 2020 at 07:30:51AM +0200, Yu Jin wrote: > 1. I could rewrite everything that I think is doable in a much better way, > this would mean actually creating a new installer, then checking the old > one function by function and then deciding which to rewarite and which to > adopt. This

Re: Work on Windows installer

2020-05-13 Thread Yu Jin
Am Mi., 13. Mai 2020 um 07:47 Uhr schrieb Jürgen Spitzmüller : > Generally, having well documented and readable code is a good thing. A > non-well written installer distracts developers and is bug prone. So > I'd second your preference. Having written this, it seems most > important to me that

Re: Work on Windows installer

2020-05-12 Thread Jürgen Spitzmüller
Am Mittwoch, den 13.05.2020, 07:30 +0200 schrieb Yu Jin: > 1. I could rewrite everything that I think is doable in a much better > way, this would mean actually creating a new installer, then checking > the old one function by function and then deciding which to rewarite > and which to adopt. This

Work on Windows installer

2020-05-12 Thread Yu Jin
Ive been studying the code for windows installer and understand it pretty well now. However the more I understand it, the more I find it hardly readable and not intuitive. There are many little things that can be made more elegant, but also the whole setup of the files and how they are structured