Re: [RFC][PATCH] Change to GuiView::goToFileRow

2020-02-16 Thread Enrico Forestieri
On Sun, Feb 16, 2020 at 01:47:43AM +0100, Stephan Witt wrote: > Am 16.02.2020 um 01:25 schrieb Enrico Forestieri : [...] > Did you try my patch and did you saw any problem with it on Linux? I could not, due to the following problem. > > I tried to reproduce your configurat

Re: [PATCH] lyxpreview_tools.py: fix a regular expression

2020-02-15 Thread Scott Kostyshak
On Sat, Feb 15, 2020 at 10:26:15PM -0500, Richard Kimberly Heck wrote: > On 2/15/20 10:07 PM, Scott Kostyshak wrote: > > > >> I'm curious, why is it necessary to support Python 2? > > I forget what the discussion is regarding why we chose those versions. > > From what I understand, requiring 2.7

Re: [PATCH] lyxpreview_tools.py: fix a regular expression

2020-02-15 Thread Richard Kimberly Heck
On 2/15/20 10:07 PM, Scott Kostyshak wrote: > >> I'm curious, why is it necessary to support Python 2? > I forget what the discussion is regarding why we chose those versions. > From what I understand, requiring 2.7 (as opposed to some earlier 2.x) > makes things easier. Probably we will not allow

Re: [PATCH] lyxpreview_tools.py: fix a regular expression

2020-02-15 Thread Scott Kostyshak
On Sat, Feb 15, 2020 at 09:25:40PM +0100, Kornel Benko wrote: > Am Sat, 15 Feb 2020 21:15:17 +0100 > schrieb Kornel Benko : > > > Am Sat, 15 Feb 2020 14:03:43 -0500 > > schrieb Scott Kostyshak : > > > > > Attached is a patch for lyxpreview_tools.py, but I don'

Re: [PATCH] lyxpreview_tools.py: fix a regular expression

2020-02-15 Thread Scott Kostyshak
d "byte" strings, Thanks for the suggestions on the patch, Neven. Your alternative suggestions give me something to look into and learn more about Python quoting and encoding. > on the other hand it seems like > the Lyx guys want > the script to work for both Python 2 and Python 3. Th

Re: [PATCH] lyxpreview_tools.py: fix a regular expression

2020-02-15 Thread Scott Kostyshak
On Sun, Feb 16, 2020 at 01:37:34AM +0100, Enrico Forestieri wrote: > On Sat, Feb 15, 2020 at 02:03:43PM -0500, Scott Kostyshak wrote: > > > Attached is a patch for lyxpreview_tools.py, but I don't know Python > > well and I don't know how to test whether this code works a

Re: [RFC][PATCH] Change to GuiView::goToFileRow

2020-02-15 Thread Stephan Witt
;>>> I came up with another path. IMHO easier to understand. >>>> And it works with all variants of Qt and input. >>> >>> Unfortunately, it confuses me more than the previous one. >>> Please, can you apply the attached debug patch and report the

Re: [PATCH] lyxpreview_tools.py: fix a regular expression

2020-02-15 Thread Enrico Forestieri
On Sat, Feb 15, 2020 at 02:03:43PM -0500, Scott Kostyshak wrote: > Attached is a patch for lyxpreview_tools.py, but I don't know Python > well and I don't know how to test whether this code works as intended > now or not. All I know is it gets rid of the error. > > I originally

Re: [RFC][PATCH] Change to GuiView::goToFileRow

2020-02-15 Thread Enrico Forestieri
;> And it works with all variants of Qt and input. > > > > Unfortunately, it confuses me more than the previous one. > > Please, can you apply the attached debug patch and report the > > results you obtain with both Qt 5.9 and 5.12? > > Here you are: > > v

Re: [PATCH] lyxpreview_tools.py: fix a regular expression

2020-02-15 Thread Kornel Benko
Am Sat, 15 Feb 2020 21:15:17 +0100 schrieb Kornel Benko : > Am Sat, 15 Feb 2020 14:03:43 -0500 > schrieb Scott Kostyshak : > > > Attached is a patch for lyxpreview_tools.py, but I don't know Python > > well and I don't know how to test whether this code works as intended

Re: [PATCH] lyxpreview_tools.py: fix a regular expression

2020-02-15 Thread Kornel Benko
Am Sat, 15 Feb 2020 14:03:43 -0500 schrieb Scott Kostyshak : > Attached is a patch for lyxpreview_tools.py, but I don't know Python > well and I don't know how to test whether this code works as intended > now or not. All I know is it gets rid of the error. > > I originally

Re: [PATCH] lyxpreview_tools.py: fix a regular expression

2020-02-15 Thread Neven Sajko
Hmm, after looking at the last few commits, it seems this may be a more involved issue than I first thought. On the one hand one has to take care to use the proper choice between "Unicode" and "byte" strings, on the other hand it seems like the Lyx guys want the script to work for both Python 2

Re: [PATCH] lyxpreview_tools.py: fix a regular expression

2020-02-15 Thread Neven Sajko
Actually, do something like this (no "using distributivity" like in my first message, to get a minimal git diff) def_re = re.compile(r"(\newcommandx|\renewcommandx|\global\long\def)(\[a-zA-Z]+)(.+)") Regards, Neven Sajko -- lyx-devel mailing list lyx-devel@lists.lyx.org

Re: [PATCH] lyxpreview_tools.py: fix a regular expression

2020-02-15 Thread Neven Sajko
Two notes: it would be better to use raw strings (r"string") and to maybe do r"\(a|b|c|d)" instead of r"(\a|\b|\c|\d)" (use distributivity, in other words). So, I think you want this: def_re = re.compile(r"\(newcommandx|renewcommandx|global\long\def)(\[a-zA-Z]+)(.+)") Regards, Neven Sajko --

[PATCH] lyxpreview_tools.py: fix a regular expression

2020-02-15 Thread Scott Kostyshak
Attached is a patch for lyxpreview_tools.py, but I don't know Python well and I don't know how to test whether this code works as intended now or not. All I know is it gets rid of the error. I originally saw that error on master when opening the User Guide with Preview enabled. Can someone give

Re: [RFC][PATCH] Change to GuiView::goToFileRow

2020-02-15 Thread Stephan Witt
me more than the previous one. > Please, can you apply the attached debug patch and report the > results you obtain with both Qt 5.9 and 5.12? Here you are: version: 5.9.8 file_name: /var/folders/1x/zm63s22x7s591xrlgm4rl9v4gn/T/lyx_tmpdir.aScQxky52159/lyx_tmpbuf0/Tuto

Re: [RFC][PATCH] Change to GuiView::goToFileRow

2020-02-15 Thread Enrico Forestieri
On Sat, Feb 15, 2020 at 02:41:19PM +0100, Stephan Witt wrote: > > I came up with another path. IMHO easier to understand. > And it works with all variants of Qt and input. Unfortunately, it confuses me more than the previous one. Please, can you apply the attached debug patch a

Re: [RFC][PATCH] Change to GuiView::goToFileRow

2020-02-15 Thread Stephan Witt
folders/1x/zm63s22x7s591xrlgm4rl9v4gn/T/lyx_tmpdir.pfyyHSvCxUfX/lyx_tmpbuf0/Tutorial.tex >>> >>> Some normalization happens here. I’ve changed the lyxeditor script to see >>> the call. It’s not >>> the operation in line 85 (were sed is used to remove /private from path

Re: [RFC][PATCH] Change to GuiView::goToFileRow

2020-02-15 Thread Enrico Forestieri
> > Some normalization happens here. I’ve changed the lyxeditor script to see > > the call. It’s not > > the operation in line 85 (were sed is used to remove /private from path > > name). > > > > To make the GuiView::goToFileRow() implementation more robust I came to the > &

Re: [RFC][PATCH] Change to GuiView::goToFileRow

2020-02-15 Thread Enrico Forestieri
used to remove /private from path name). > > To make the GuiView::goToFileRow() implementation more robust I came to the > attached patch. > > I’m confident it cannot hurt. But as I don’t understand the situation > completely I ask for comments. > > Stephan > [-- mutt.oc

Re: [RFC][PATCH] Change to GuiView::goToFileRow

2020-02-14 Thread Stephan Witt
remove /private from path name). > > To make the GuiView::goToFileRow() implementation more robust I came to the > attached patch. > > I’m confident it cannot hurt. But as I don’t understand the situation > completely I ask for comments. I think I got it myself. The difference is t

[RFC][PATCH] Change to GuiView::goToFileRow

2020-02-14 Thread Stephan Witt
/Tutorial.tex Some normalization happens here. I’ve changed the lyxeditor script to see the call. It’s not the operation in line 85 (were sed is used to remove /private from path name). To make the GuiView::goToFileRow() implementation more robust I came to the attached patch. I’m confident it cannot

Re: [RFC][PATCH] Replace deprecated mem_fun_ref with lambda

2020-02-13 Thread Jean-Marc Lasgouttes
Le 13/02/2020 à 18:03, Pavel Sanda a écrit : On Wed, Feb 12, 2020 at 08:45:06PM +0100, Jean-Marc Lasgouttes wrote: I replace a thing I do not really understand with another thing that I do not really understand either. Can someone tell me whether the use o lambda expression is OK? I do not know

Re: [RFC][PATCH] Replace deprecated mem_fun_ref with lambda

2020-02-13 Thread Pavel Sanda
On Wed, Feb 12, 2020 at 08:45:06PM +0100, Jean-Marc Lasgouttes wrote: > I replace a thing I do not really understand with another thing that I do > not really understand either. Can someone tell me whether the use o lambda > expression is OK? I do not know how to test it. I would be more happy to

Re: [RFC][PATCH] Replace deprecated mem_fun_ref with lambda

2020-02-12 Thread Richard Kimberly Heck
On 2/12/20 2:45 PM, Jean-Marc Lasgouttes wrote: > Hi there, > > Here is a patch to fix a message from Stephan that nobody but me saw, > because I discarded it instead of accepting it :) BTW, Attachment size > was over 500k, what would be a good limit size? > > I replace a

[RFC][PATCH] Replace deprecated mem_fun_ref with lambda

2020-02-12 Thread Jean-Marc Lasgouttes
Hi there, Here is a patch to fix a message from Stephan that nobody but me saw, because I discarded it instead of accepting it :) BTW, Attachment size was over 500k, what would be a good limit size? I replace a thing I do not really understand with another thing that I do not really

Re: Comments on patch for paragraph-move-down to move sub-items as well

2020-02-02 Thread Scott Kostyshak
On Sun, Feb 02, 2020 at 08:36:53PM -0500, Scott Kostyshak wrote: > The logic in RandomAccessList is overly > complicated (and inefficient) and I'm working on simplifying it by using > a splice instead of all of those swaps. The attached patch implements the splice approach. I've tested

Re: Comments on patch for paragraph-move-down to move sub-items as well

2020-02-02 Thread Scott Kostyshak
On Sun, Feb 02, 2020 at 07:08:50PM -0500, Richard Kimberly Heck wrote: > On 2/1/20 12:40 PM, Scott Kostyshak wrote: > > I've been working on a patch for LFUN_PARAGRAPH_MOVE_DOWN move subitems > > of an item along with the item. For example, consider the following > > situat

Re: Comments on patch for paragraph-move-down to move sub-items as well

2020-02-02 Thread Richard Kimberly Heck
On 2/1/20 12:40 PM, Scott Kostyshak wrote: > I've been working on a patch for LFUN_PARAGRAPH_MOVE_DOWN move subitems > of an item along with the item. For example, consider the following > situation: > > 1. One item > a. "subitem" > 2. Another item > &g

Re: Comments on patch for paragraph-move-down to move sub-items as well

2020-02-02 Thread Scott Kostyshak
On Sat, Feb 01, 2020 at 08:43:15PM +0100, Jean-Marc Lasgouttes wrote: > Le 01/02/2020 à 18:40, Scott Kostyshak a écrit : > > I've been working on a patch for LFUN_PARAGRAPH_MOVE_DOWN move subitems > > of an item along with the item. For example, consider the following > > sit

Re: Comments on patch for paragraph-move-down to move sub-items as well

2020-02-01 Thread Jean-Marc Lasgouttes
Le 01/02/2020 à 18:40, Scott Kostyshak a écrit : I've been working on a patch for LFUN_PARAGRAPH_MOVE_DOWN move subitems of an item along with the item. For example, consider the following situation: 1. One item a. "subitem" 2. Another item Currently (i.e., without

Comments on patch for paragraph-move-down to move sub-items as well

2020-02-01 Thread Scott Kostyshak
I've been working on a patch for LFUN_PARAGRAPH_MOVE_DOWN move subitems of an item along with the item. For example, consider the following situation: 1. One item a. "subitem" 2. Another item Currently (i.e., without the patch), if the cursor is at positiion and the use

Re: Patch correcting typo in lyx_2_1.py

2019-12-29 Thread José Abílio Matos
On Sunday, 29 December 2019 15.53.32 WET Richard Kimberly Heck wrote: > Yes, that's fine. > > Riki And it is already in after your message from last November (from this year fortunately). :-) -- José Abílio -- lyx-devel mailing list lyx-devel@lists.lyx.org

Re: Patch correcting typo in lyx_2_1.py

2019-12-29 Thread Richard Kimberly Heck
On 12/27/19 9:30 PM, Scott Kostyshak wrote: > On Mon, Nov 04, 2019 at 12:07:51PM +, José Abílio Matos wrote: >> On Wednesday, 30 October 2019 13.30.48 WET Salvatore Falco wrote: >>> I am attaching a small patch to correct a typo in lyx_2_1.py, which >>> prevent

Re: Patch correcting typo in lyx_2_1.py

2019-12-28 Thread Scott Kostyshak
On Sat, Dec 28, 2019 at 10:49:05AM +, José Abílio Matos wrote: > On Saturday, 28 December 2019 02.30.53 WET Scott Kostyshak wrote: > > Bump for Riki. > > > > Scott > > Riki already gave the OK, the only issue was that I have been extremely busy > with the end of the semester around here. >

Re: Patch correcting typo in lyx_2_1.py

2019-12-28 Thread José Abílio Matos
On Saturday, 28 December 2019 02.30.53 WET Scott Kostyshak wrote: > Bump for Riki. > > Scott Riki already gave the OK, the only issue was that I have been extremely busy with the end of the semester around here. I will do it soon. :-) -- José Abílio -- lyx-devel mailing list

Re: Patch correcting typo in lyx_2_1.py

2019-12-27 Thread Scott Kostyshak
On Mon, Nov 04, 2019 at 12:07:51PM +, José Abílio Matos wrote: > On Wednesday, 30 October 2019 13.30.48 WET Salvatore Falco wrote: > > I am attaching a small patch to correct a typo in lyx_2_1.py, which > > prevented the conversion of a file > > You are right. Thank you

Re: [patch] Refresh previews on branch toggle?

2019-12-11 Thread Scott Kostyshak
On Wed, Dec 11, 2019 at 09:50:17AM -0500, Scott Kostyshak wrote: > Perhaps a reasonable approach would be to only update the previews if we > detect that the branch exists in a child document. I committed this approach at f1accdeb. Scott signature.asc Description: PGP signature -- lyx-devel

Re: [patch] Refresh previews on branch toggle?

2019-12-11 Thread Scott Kostyshak
> On 12/8/19 9:20 PM, Scott Kostyshak wrote: > > >>> Attached is a patch that refreshes previews whenever the user activates > > >>> or deactivates a branch. The motivation for this patch is that if a > > >>> child document is previewed in the master d

Re: [patch] Refresh previews on branch toggle?

2019-12-09 Thread Scott Kostyshak
On Mon, Dec 09, 2019 at 12:44:20PM -0500, Richard Kimberly Heck wrote: > On 12/9/19 10:40 AM, Scott Kostyshak wrote: > > On Sun, Dec 08, 2019 at 11:03:20PM -0500, Richard Kimberly Heck wrote: > >> On 12/8/19 9:20 PM, Scott Kostyshak wrote: > >>> Attached is a patch th

Re: [patch] Refresh previews on branch toggle?

2019-12-09 Thread Richard Kimberly Heck
On 12/9/19 10:40 AM, Scott Kostyshak wrote: > On Sun, Dec 08, 2019 at 11:03:20PM -0500, Richard Kimberly Heck wrote: >> On 12/8/19 9:20 PM, Scott Kostyshak wrote: >>> Attached is a patch that refreshes previews whenever the user activates >>> or deactivates a branch. Th

Re: [patch] Refresh previews on branch toggle?

2019-12-09 Thread Scott Kostyshak
On Sun, Dec 08, 2019 at 11:03:20PM -0500, Richard Kimberly Heck wrote: > On 12/8/19 9:20 PM, Scott Kostyshak wrote: > > Attached is a patch that refreshes previews whenever the user activates > > or deactivates a branch. The motivation for this patch is that if a > > child

Re: [patch] Refresh previews on branch toggle?

2019-12-09 Thread Kornel Benko
Am Sun, 8 Dec 2019 23:03:20 -0500 schrieb Richard Kimberly Heck : > On 12/8/19 9:20 PM, Scott Kostyshak wrote: > > Attached is a patch that refreshes previews whenever the user activates > > or deactivates a branch. The motivation for this patch is that if a > > child

Re: [patch] Refresh previews on branch toggle?

2019-12-08 Thread Richard Kimberly Heck
On 12/8/19 9:20 PM, Scott Kostyshak wrote: > Attached is a patch that refreshes previews whenever the user activates > or deactivates a branch. The motivation for this patch is that if a > child document is previewed in the master document, and if the child > document has the b

[patch] Refresh previews on branch toggle?

2019-12-08 Thread Scott Kostyshak
Attached is a patch that refreshes previews whenever the user activates or deactivates a branch. The motivation for this patch is that if a child document is previewed in the master document, and if the child document has the branch inside it as well, the preview will be incorrect when the branch

Re: Patch correcting typo in lyx_2_1.py

2019-11-04 Thread José Abílio Matos
On Wednesday, 30 October 2019 13.30.48 WET Salvatore Falco wrote: > I am attaching a small patch to correct a typo in lyx_2_1.py, which > prevented the conversion of a file You are right. Thank you. :-) Riki may I apply it to 2.3.x? Best regards, -- José Abílio -- lyx-devel mailing li

Patch correcting typo in lyx_2_1.py

2019-11-02 Thread Salvatore Falco
I am attaching a small patch to correct a typo in lyx_2_1.py, which prevented the conversion of a file -- Salvatore Falco From fbaaee6944f6fe9d761df14e80c9934e1ad0ae4a Mon Sep 17 00:00:00 2001 From: locale Date: Wed, 30 Oct 2019 14:28:02 +0100 Subject: [PATCH] corrected typo --- lib/lyx2lyx

Re: [PATCH] Port gnuplot2pdf.py to Python 3

2019-09-04 Thread Scott Kostyshak
On Wed, Sep 04, 2019 at 12:24:40PM -, Guenter Milde wrote: > On 2019-08-30, Scott Kostyshak wrote: > > > [-- Type: text/plain, Encoding: quoted-printable --] > > > The current script fails for me. The attached patch seems to work, but I > > only got it to wor

Re: [PATCH] Port gnuplot2pdf.py to Python 3

2019-09-04 Thread Guenter Milde
On 2019-08-30, Scott Kostyshak wrote: > [-- Type: text/plain, Encoding: quoted-printable --] > The current script fails for me. The attached patch seems to work, but I > only got it to work by experimenting. Can any Pythonista take a close > look? With the wait() command it seems t

[PATCH] Port gnuplot2pdf.py to Python 3

2019-08-29 Thread Scott Kostyshak
The current script fails for me. The attached patch seems to work, but I only got it to work by experimenting. Can any Pythonista take a close look? With the wait() command it seems to hang, so I substituted communicate() as mentioned here: https://docs.python.org/3/library/subprocess.html

Re: Trivial patch review request

2019-08-15 Thread Scott Kostyshak
On Thu, Aug 15, 2019 at 07:26:44AM -0600, Joel Kulesza wrote: > On Wed, Aug 14, 2019 at 5:35 PM Scott Kostyshak wrote: > > > On Wed, Aug 14, 2019 at 12:10:46PM -0600, Joel Kulesza wrote: > > > > > Hopefully my activity in the credits > > > isn't seen as too vain. > > > > Not at all. I hope my

Re: Trivial patch review request

2019-08-15 Thread Joel Kulesza
On Wed, Aug 14, 2019 at 5:35 PM Scott Kostyshak wrote: > On Wed, Aug 14, 2019 at 12:10:46PM -0600, Joel Kulesza wrote: > > > Hopefully my activity in the credits > > isn't seen as too vain. > > Not at all. I hope my attempt at humor wasn't what made you think that. > Whenever I attempt to make a

Re: Trivial patch review request

2019-08-14 Thread Scott Kostyshak
On Wed, Aug 14, 2019 at 07:32:45PM -0400, Scott Kostyshak wrote: > On Wed, Aug 14, 2019 at 12:14:02PM -0600, Joel Kulesza wrote: > > > Sorry for the quick follow-up, but Riki alerted me offline that the CREDITS > > file is generated from generate_contributors.py so this fix (and the others > > I

Re: Trivial patch review request

2019-08-14 Thread Scott Kostyshak
On Wed, Aug 14, 2019 at 12:10:46PM -0600, Joel Kulesza wrote: > Riki took care of this not long after I'd sent it, so I think we're good > but I appreciate you following up! Ah good to know. > Hopefully my activity in the credits > isn't seen as too vain. Not at all. I hope my attempt at humor

Re: Trivial patch review request

2019-08-14 Thread Scott Kostyshak
st ported the changes to the source file at 792f4282. > Sorry for submitting a bogus patch that causes you rework. No problem at all! Scott signature.asc Description: PGP signature

Re: Trivial patch review request

2019-08-14 Thread Joel Kulesza
On Wed, Aug 14, 2019 at 12:10 PM Joel Kulesza wrote: > On Wed, Aug 14, 2019 at 11:08 AM Scott Kostyshak wrote: > >> On Wed, Jul 24, 2019 at 09:10:00PM -0600, Joel Kulesza wrote: >> > LyX Developers, >> > >> > Can someone please review/incorporate

Re: Trivial patch review request

2019-08-14 Thread Joel Kulesza
On Wed, Aug 14, 2019 at 11:08 AM Scott Kostyshak wrote: > On Wed, Jul 24, 2019 at 09:10:00PM -0600, Joel Kulesza wrote: > > LyX Developers, > > > > Can someone please review/incorporate the attached, trivial, patch, which > > corrects a typo in the credits?

Re: Trivial patch review request

2019-08-14 Thread Scott Kostyshak
On Wed, Jul 24, 2019 at 09:10:00PM -0600, Joel Kulesza wrote: > LyX Developers, > > Can someone please review/incorporate the attached, trivial, patch, which > corrects a typo in the credits? > > Please let me know if a tracker issue is warranted. > > Otherwise, pl

Trivial patch review request

2019-07-24 Thread Joel Kulesza
LyX Developers, Can someone please review/incorporate the attached, trivial, patch, which corrects a typo in the credits? Please let me know if a tracker issue is warranted. Otherwise, please contact me with any comments, questions, or concerns. Thank you, Joel 0001-Correct-typo

Re: [PATCH] Make math autocorrrect work with more than 2 chars

2019-06-25 Thread Jean-Marc Lasgouttes
Le 19/06/2019 à 03:02, Isaac Oscar Gariano a écrit : > The patch that remove support for the ! command is now in. I have also added your name to Credits. Welcome aboard :) Oh cool thank you! One minor thing, can you use my normal email address "isaacos...@live.com.au" (It dosn't

Fwd: Re: [PATCH] Make math autocorrrect work with more than 2 chars

2019-06-19 Thread Jean-Marc Lasgouttes
sféré Sujet : Re: [PATCH] Make math autocorrrect work with more than 2 chars Date : Wed, 19 Jun 2019 08:37:12 + (UTC) De :Ben Houcine Pour : Jean-Marc Lasgouttes I'm a heavily Math equations user in my text and I'm not sure if MS Word has some speed over LyX (LibreOffice

Re: [PATCH] Make math autocorrrect work with more than 2 chars

2019-06-18 Thread Isaac Oscar Gariano
How did you learn about it? By the annoying status bar message and the user guide >> And finally, I have another patch, (relying on the above) that places >> autocorrect at the top of `InsetMathNest::interpretChar`, ensuring that >> any autocorrections that trigger on speci

Re: [PATCH] Make math autocorrrect work with more than 2 chars

2019-06-18 Thread Isaac Oscar Gariano
> The patch that remove support for the ! command is now in. I have also > added your name to Credits. Welcome aboard :) Oh cool thank you! One minor thing, can you use my normal email address "isaacos...@live.com.au" (It dosn't really matter, as the "@hotmail&q

Re: [PATCH] Make math autocorrrect work with more than 2 chars

2019-06-12 Thread Jean-Marc Lasgouttes
Le 02/06/2019 à 21:48, Jean-Marc Lasgouttes a écrit : I have not however removed references to this feature in docoumentation, hopefully someone more familiary with the LyX code base will know where these are. Indeed we have to check that. I actually suspect that this feature is not

Re: [Patch] Re: How to signal missing citation

2019-06-06 Thread Joel Kulesza
On Thu, Jun 6, 2019 at 5:56 PM Pavel Sanda wrote: > On Thu, Jun 06, 2019 at 03:42:05PM +0200, Pavel Sanda wrote: > > Looks little bit difficult within the current machinery (if I understand > > it correctly). Cits can be fixed by incremental runs and we see that in > > updated result value of

Re: [Patch] Re: How to signal missing citation

2019-06-06 Thread Joel Kulesza
similar) and would flush similar warnings > which are actually harmless in final pdf -- but we will bombard users with > error dialog all the time. > We can try to push to master and wait how much will people scream... > If when this is pushed, I'll try to pull and compile some documents

Re: [Patch] Re: How to signal missing citation

2019-06-06 Thread Pavel Sanda
On Thu, Jun 06, 2019 at 03:42:05PM +0200, Pavel Sanda wrote: > Looks little bit difficult within the current machinery (if I understand > it correctly). Cits can be fixed by incremental runs and we see that in > updated result value of scanres of LaTeX::run, i.e. if fixed it does not > contain

Re: [Patch] Re: How to signal missing citation

2019-06-06 Thread Pavel Sanda
milar warnings which are actually harmless in final pdf -- but we will bombard users with error dialog all the time. We can try to push to master and wait how much will people scream... > Do you have any thoughts on coloring the buttons in the GUI to indicate > breakage? Not enough visib

Re: [Patch] Re: How to signal missing citation

2019-06-05 Thread Joel Kulesza
be enough actually. > - Patch 1 will err when citation is broken > - adding patch 2 on top of that will also err in case cross-ref is broken. > > This is potentially going to affect users who live at ease with broken > refs, > so please object if you think I am going too far. > > I

[Patch] Re: How to signal missing citation

2019-06-05 Thread Pavel Sanda
On Tue, Jun 04, 2019 at 01:51:08PM -0600, Joel Kulesza wrote: > I also think a ???show anyway??? error on view is warranted for broken > citations, similar to when no citations are entered. Me too and this should be enough actually. - Patch 1 will err when citation is broken - adding p

Re: [PATCH] Make math autocorrrect work with more than 2 chars

2019-06-03 Thread Jean-Marc Lasgouttes
Le 25/05/2019 à 02:07, Isaac Oscar Gariano a écrit : I have also attached another patch here that turns off the keyboard shortcuts ("!" and "space") that turn on/off autocrrect, as I find this feature incrediably annoying and it is now unecesary thanks to the ability

Re: [PATCH] Make math autocorrrect work with more than 2 chars

2019-06-02 Thread Jean-Marc Lasgouttes
grant applies to any code I have, or will, email to lyx-devel@lists. Dear Isaac, Thanks a lot. I pushed your patch and the undo patch to master. I tried to add some description of the patch and its use, but it would be better if you can do that in the future. See commit bed546d6f. I

Re: [PATCH] Make math autocorrrect work with more than 2 chars

2019-05-24 Thread Isaac Oscar Gariano
-devel@lists. I have also attached another patch here that turns off the keyboard shortcuts ("!" and "space") that turn on/off autocrrect, as I find this feature incrediably annoying and it is now unecesary thanks to the ability to undo-autocorrects that Jean allready implemente

Re: [PATCH] Make math autocorrrect work with more than 2 chars

2019-05-24 Thread Jean-Marc Lasgouttes
rk. A few things:   * I hereby grant permission to license my contributions to LyX under     the GNU General Public License, version 2 or later I would need you to send this statement to the lyx-devel list for archival purpose.   * What do you mean by a "* a more consistent commit log

Re: [patch] Re: Line numbering to doc prefs?

2019-05-23 Thread Pavel Sanda
On Tue, May 21, 2019 at 06:10:48PM +0200, Pavel Sanda wrote: > Like the attached. This is now in. > It occurred to me that lineno might be used for referencing lines > in the document as well (and clickable with hyperref), not sure how > much work would it take to integrate with our

[patch] Re: Line numbering to doc prefs?

2019-05-21 Thread Pavel Sanda
On Mon, May 20, 2019 at 04:44:12PM +0200, Pavel Sanda wrote: > Hi, > > I'm not heavy user of lineno package for numbering of the lines > in the margin, but I regularly need it for submissions and always > need to google again for preamble two-liner: > \usepackage{lineno} > \linenumbers > > What

Re: [PATCH] Make math autocorrrect work with more than 2 chars

2019-04-17 Thread Guenter Milde
On 2019-04-17, Jean-Marc Lasgouttes wrote: > Le 15/04/2019 à 17:43, Enrico Forestieri a écrit : >> On Mon, Apr 15, 2019 at 05:33:13PM +0200, Enrico Forestieri wrote: >>> On Mon, Apr 15, 2019 at 05:18:52PM +0200, Jean-Marc Lasgouttes wrote: In this case of this rightarrow, why was it decided

Re: [PATCH] Make math autocorrrect work with more than 2 chars

2019-04-17 Thread Guenter Milde
On 2019-04-17, Isaac Oscar Gariano wrote: > In addition, I often use math symbols in my code (and they don't work > properly in text mode with LaTeX, unless I use XeTeX and raw unicode > characters...) This is solved by LyX (except for "verbatim-styles" like listings). LyX wraps literal Unicode

Re: [PATCH] Make math autocorrrect work with more than 2 chars

2019-04-17 Thread Enrico Forestieri
On Wed, Apr 17, 2019 at 09:34:22AM +0200, Jean-Marc Lasgouttes wrote: > Le 17/04/2019 à 01:32, Isaac Oscar Gariano a écrit : > > Dear Jean-Marc, > > I was using equation to write syntax-highlighted code. So I wanted to > > write something like this: > > > > $\keyword{hello} \comment{this is a

Re: [PATCH] Make math autocorrrect work with more than 2 chars

2019-04-17 Thread Jean-Marc Lasgouttes
Le 17/04/2019 à 10:09, Isaac Oscar Gariano a écrit : Dear Jean-Marc, I would say that this is not a very LaTeX-y use of maths :) Anyway, your macro would work better if you used \text to have actual text mode. With that, LyX will accept spaces in math. That is entirely the point, \texttt

Re: [PATCH] Make math autocorrrect work with more than 2 chars

2019-04-17 Thread Isaac Oscar Gariano
Dear Jean-Marc, > I would say that this is not a very LaTeX-y use of maths :) Anyway, your > macro would work better if you used \text to have actual text mode. With > that, LyX will accept spaces in math. That is entirely the point, \texttt works with spaces in LyX, however if I make a new

Re: [PATCH] Make math autocorrrect work with more than 2 chars

2019-04-17 Thread Jean-Marc Lasgouttes
Le 15/04/2019 à 17:43, Enrico Forestieri a écrit : On Mon, Apr 15, 2019 at 05:33:13PM +0200, Enrico Forestieri wrote: On Mon, Apr 15, 2019 at 05:18:52PM +0200, Jean-Marc Lasgouttes wrote: In this case of this rightarrow, why was it decided that it is a text thing? The unicode reference puts

Re: [PATCH] Make math autocorrrect work with more than 2 chars

2019-04-17 Thread Jean-Marc Lasgouttes
Le 17/04/2019 à 02:36, Isaac Oscar Gariano a écrit : Dear Scott, It does thank you! However presing "alt+m, shift+9" is a bit unconfortable and slow. A command like \( would be more convienet, however if I make one like that with an arugment, LyX places the cursor /outside/ the parantheses,

Re: [PATCH] Make math autocorrrect work with more than 2 chars

2019-04-17 Thread Jean-Marc Lasgouttes
Le 17/04/2019 à 01:32, Isaac Oscar Gariano a écrit : Dear Jean-Marc, I was using equation to write syntax-highlighted code. So I wanted to write something like this: $\keyword{hello} \comment{this is a comment}$ Which would display as hello// this is a comment Here \comment would

Re: [PATCH] Make math autocorrrect work with more than 2 chars

2019-04-17 Thread Jean-Marc Lasgouttes
the GNU General Public License, version 2 or later I would need you to send this statement to the lyx-devel list for archival purpose. * What do you mean by a "* a more consistent commit log for your patch"? Sorry, it was a French/English false friend. I meant that git commit should

Re: [PATCH] Make math autocorrrect work with more than 2 chars

2019-04-16 Thread Scott Kostyshak
On Wed, Apr 17, 2019 at 01:58:08AM +, Isaac Oscar Gariano wrote: > Most of my brackets are unfortunantly in \texttt, so stretching them dosn't > work; however for all my normal math ones I do use the stretch forms. > Interestingly for functions the \left\right version of parentheses has a >

Re: [PATCH] Make math autocorrrect work with more than 2 chars

2019-04-16 Thread Isaac Oscar Gariano
saac Oscar Gariano From: Scott Kostyshak Sent: 17 April 2019 1:23 PM To: Isaac Oscar Gariano Cc: Jean-Marc Lasgouttes; lyx-devel@lists.lyx.org Subject: Re: [PATCH] Make math autocorrrect work with more than 2 chars On Wed, Apr 17, 2019 at 12:36:56AM +, I

Re: [PATCH] Make math autocorrrect work with more than 2 chars

2019-04-16 Thread Scott Kostyshak
On Wed, Apr 17, 2019 at 12:36:56AM +, Isaac Oscar Gariano wrote: > Dear Scott, > > It does thank you! However presing "alt+m, shift+9" is a bit unconfortable > and slow. A command like \( would be more convienet, however if I make one > like that with an arugment, LyX places the cursor

Re: [PATCH] Make math autocorrrect work with more than 2 chars

2019-04-16 Thread Isaac Oscar Gariano
, it works as expected. — Isaac From: Scott Kostyshak Sent: 17 April 2019 12:26 PM To: Isaac Oscar Gariano Cc: Jean-Marc Lasgouttes; lyx-devel@lists.lyx.org Subject: Re: [PATCH] Make math autocorrrect work with more than 2 chars On Tue, Apr 16, 2019 at 11:36:

Re: [PATCH] Make math autocorrrect work with more than 2 chars

2019-04-16 Thread Scott Kostyshak
On Tue, Apr 16, 2019 at 11:36:36PM +, Isaac Oscar Gariano wrote: > Interestingly, microsoft word has a lovely feature where it autosizes braces! > So you type (a/b) and the parantheses will match the high of the fraction. I > know lyx has a way of doing this with insert->math->delimiters,

Re: [PATCH] Make math autocorrrect work with more than 2 chars

2019-04-16 Thread Isaac Oscar Gariano
ac Oscar Gariano Subject: Re: [PATCH] Make math autocorrrect work with more than 2 chars Le 15/04/2019 à 16:08, Enrico Forestieri a écrit : > On Mon, Apr 15, 2019 at 12:16:26PM +0200, Jean-Marc Lasgouttes wrote: >> >> OK, it was just a suggestion. More important would be to have new bind

Re: [PATCH] Make math autocorrrect work with more than 2 chars

2019-04-16 Thread Isaac Oscar Gariano
Gariano; LyX Mechanics Subject: Re: [PATCH] Make math autocorrrect work with more than 2 chars Hi again, Let's go through the remaining issues now. Le 12/04/2019 à 05:23, Isaac Oscar Gariano a écrit : > * It supports unicode input. LyX seems supports this as well, but when >

Re: patch to include latest supported programming languages in listings.tex

2019-04-15 Thread Jürgen Spitzmüller
Am Montag, den 15.04.2019, 10:01 -0700 schrieb Sergei Winitzki: > Thank you Jürgen for a quick response! I have been using LyX since > 1999 for every technical document I write, and I am glad to see that > the project is going strong after 20 years. Meanwhile, I also encountered that we already

Re: patch to include latest supported programming languages in listings.tex

2019-04-15 Thread Sergei Winitzki
700 schrieb Sergei Winitzki: > > > > "I hereby grant permission to license my contributions to LyX > > under the GNU General Public License, version 2 or later." > > Thanks, Sergei. Patch is in (master). > > Riki, this could also be backported. > > Jürgen > >

Re: [PATCH] Make math autocorrrect work with more than 2 chars

2019-04-15 Thread Guenter Milde
On 2019-04-15, Enrico Forestieri wrote: > On Mon, Apr 15, 2019 at 12:16:26PM +0200, Jean-Marc Lasgouttes wrote: >> Le 12/04/2019 à 05:23, Isaac Oscar Gariano a écrit : >> > * It supports unicode input. LyX seems supports this as well, but when >> > I put '→' in the autocorrect file instead

Re: [PATCH] Make math autocorrrect work with more than 2 chars

2019-04-15 Thread Enrico Forestieri
On Mon, Apr 15, 2019 at 05:33:13PM +0200, Enrico Forestieri wrote: > On Mon, Apr 15, 2019 at 05:18:52PM +0200, Jean-Marc Lasgouttes wrote: > > > > In this case of this rightarrow, why was it decided that it is a text thing? > > The unicode reference puts in the the Symbol and Math categories. I

Re: [PATCH] Make math autocorrrect work with more than 2 chars

2019-04-15 Thread Enrico Forestieri
On Mon, Apr 15, 2019 at 05:18:52PM +0200, Jean-Marc Lasgouttes wrote: > Le 15/04/2019 à 16:54, Enrico Forestieri a écrit : > > > I guess this is the question: what is the reason why the character is > > > entered as text? Don't we have means to know that this one could be > > > entered > > >

Re: [PATCH] Make math autocorrrect work with more than 2 chars

2019-04-15 Thread Jean-Marc Lasgouttes
Le 15/04/2019 à 16:54, Enrico Forestieri a écrit : I guess this is the question: what is the reason why the character is entered as text? Don't we have means to know that this one could be entered directly as math character? We already do that with some symbols such as è, which is entered in

Re: [PATCH] Make math autocorrrect work with more than 2 chars

2019-04-15 Thread Enrico Forestieri
On Mon, Apr 15, 2019 at 04:33:16PM +0200, Jean-Marc Lasgouttes wrote: > > [Enrico, please try to keep Isaac in the loop for now, at least until we > know he is subscribed] Will try to remember. > Le 15/04/2019 à 16:28, Enrico Forestieri a écrit : > > On Mon, Apr 15, 2019 at 12:16:26PM +0200,

Re: [PATCH] Make math autocorrrect work with more than 2 chars

2019-04-15 Thread Enrico Forestieri
uld be to have new bindings > > > that use the feature. I guess one candidate is > > > --> \longrightarrow > > > > Another interesting feature made possible by this patch is the > > following one: > > > > ( *\bigl( &

<    3   4   5   6   7   8   9   10   11   12   >