[MediaWiki-commits] [Gerrit] wikimedia...SmashPig[master]: Remove bogus 'inflight' store

2016-09-30 Thread Ejegg (Code Review)
Ejegg has uploaded a new change for review. https://gerrit.wikimedia.org/r/313622 Change subject: Remove bogus 'inflight' store .. Remove bogus 'inflight' store Would write things to /tmp and never do anything with them Chan

[MediaWiki-commits] [Gerrit] wikimedia...SmashPig[deployment]: Merge branch 'master' into deployment

2016-09-30 Thread Ejegg (Code Review)
Ejegg has uploaded a new change for review. https://gerrit.wikimedia.org/r/313608 Change subject: Merge branch 'master' into deployment .. Merge branch 'master' into deployment bde092f Don't return a reference to object, that

[MediaWiki-commits] [Gerrit] wikimedia...SmashPig[master]: Add required gross_currency to PP refunds

2016-09-30 Thread Ejegg (Code Review)
Ejegg has uploaded a new change for review. https://gerrit.wikimedia.org/r/313607 Change subject: Add required gross_currency to PP refunds .. Add required gross_currency to PP refunds Change-Id: I73fecdc6c0938587d1c1c7fb5694

[MediaWiki-commits] [Gerrit] wikimedia...crm[deployment]: Add check for stable data before running GC charges.

2016-09-30 Thread Ejegg (Code Review)
Ejegg has uploaded a new change for review. https://gerrit.wikimedia.org/r/313606 Change subject: Add check for stable data before running GC charges. .. Add check for stable data before running GC charges. When running drush

[MediaWiki-commits] [Gerrit] wikimedia...crm[deployment]: Merge commit '558b942b12872bfba33389640d63b592ca276368' into...

2016-09-29 Thread Ejegg (Code Review)
Ejegg has uploaded a new change for review. https://gerrit.wikimedia.org/r/313544 Change subject: Merge commit '558b942b12872bfba33389640d63b592ca276368' into deployment .. Merge commit '558b942b12872bfba33389640d63b592ca2763

[MediaWiki-commits] [Gerrit] wikimedia...crm[master]: 0 instead of '' for Unlimited messages

2016-09-29 Thread Ejegg (Code Review)
Ejegg has uploaded a new change for review. https://gerrit.wikimedia.org/r/313543 Change subject: 0 instead of '' for Unlimited messages .. 0 instead of '' for Unlimited messages New queue consumers want numbers Change-Id: I

[MediaWiki-commits] [Gerrit] wikimedia...SmashPig[deployment]: Merge branch 'master' into deployment

2016-09-29 Thread Ejegg (Code Review)
Ejegg has uploaded a new change for review. https://gerrit.wikimedia.org/r/313542 Change subject: Merge branch 'master' into deployment .. Merge branch 'master' into deployment ff080e0 Add order_id to PayPal messages Change-

[MediaWiki-commits] [Gerrit] wikimedia...SmashPig[master]: Add order_id to PayPal messages

2016-09-29 Thread Ejegg (Code Review)
Ejegg has uploaded a new change for review. https://gerrit.wikimedia.org/r/313541 Change subject: Add order_id to PayPal messages .. Add order_id to PayPal messages Change-Id: I15074fed2ce42e8427d093521395899eb9466aaf --- M P

[MediaWiki-commits] [Gerrit] wikimedia...crm[deployment]: Merge commit 'ae5a926512fb07c3a74ed5163e43f83dd93bc917' into...

2016-09-29 Thread Ejegg (Code Review)
Ejegg has uploaded a new change for review. https://gerrit.wikimedia.org/r/313535 Change subject: Merge commit 'ae5a926512fb07c3a74ed5163e43f83dd93bc917' into deployment .. Merge commit 'ae5a926512fb07c3a74ed5163e43f83dd93bc9

[MediaWiki-commits] [Gerrit] wikimedia...crm[deployment]: Revert "Revert "Mirror queue messages from wmf_audit""

2016-09-29 Thread Ejegg (Code Review)
Ejegg has uploaded a new change for review. https://gerrit.wikimedia.org/r/313532 Change subject: Revert "Revert "Mirror queue messages from wmf_audit"" .. Revert "Revert "Mirror queue messages from wmf_audit"" 'cos it's more

[MediaWiki-commits] [Gerrit] wikimedia...crm[deployment]: Revert "Revert "Mirror messages to new queues in GC audit""

2016-09-29 Thread Ejegg (Code Review)
Ejegg has uploaded a new change for review. https://gerrit.wikimedia.org/r/313533 Change subject: Revert "Revert "Mirror messages to new queues in GC audit"" .. Revert "Revert "Mirror messages to new queues in GC audit"" doub

[MediaWiki-commits] [Gerrit] wikimedia...SmashPig[deployment]: Merge branch 'master' into deployment

2016-09-29 Thread Ejegg (Code Review)
Ejegg has submitted this change and it was merged. Change subject: Merge branch 'master' into deployment .. Merge branch 'master' into deployment 6569037 Add source fields to messages (smaller version) Change-Id: I51bf01d6455b

[MediaWiki-commits] [Gerrit] wikimedia...SmashPig[deployment]: Merge branch 'master' into deployment

2016-09-29 Thread Ejegg (Code Review)
Ejegg has uploaded a new change for review. https://gerrit.wikimedia.org/r/313527 Change subject: Merge branch 'master' into deployment .. Merge branch 'master' into deployment 6569037 Add source fields to messages (smaller v

[MediaWiki-commits] [Gerrit] mediawiki...DonationInterface[master]: Fix hostname under CRM

2016-09-29 Thread Ejegg (Code Review)
Ejegg has uploaded a new change for review. https://gerrit.wikimedia.org/r/313526 Change subject: Fix hostname under CRM .. Fix hostname under CRM Bug: T144034 Change-Id: Ied69e024b16626552f23e4e2f788f44ff588546c --- M gatewa

[MediaWiki-commits] [Gerrit] wikimedia...SmashPig[master]: Add source fields to messages (smaller version)

2016-09-29 Thread Ejegg (Code Review)
Ejegg has uploaded a new change for review. https://gerrit.wikimedia.org/r/313519 Change subject: Add source fields to messages (smaller version) .. Add source fields to messages (smaller version) Still feels un-dry. Maybe we

[MediaWiki-commits] [Gerrit] wikimedia...SmashPig[master]: WIP set source fields on messages

2016-09-29 Thread Ejegg (Code Review)
Ejegg has uploaded a new change for review. https://gerrit.wikimedia.org/r/313516 Change subject: WIP set source fields on messages .. WIP set source fields on messages This can't possibly be the right way to do this... Chan

[MediaWiki-commits] [Gerrit] wikimedia...SmashPig[deployment]: Merge branch 'master' into deployment

2016-09-29 Thread Ejegg (Code Review)
Ejegg has uploaded a new change for review. https://gerrit.wikimedia.org/r/313504 Change subject: Merge branch 'master' into deployment .. Merge branch 'master' into deployment 71a57ea Deal with refunds having no txn_type Ch

[MediaWiki-commits] [Gerrit] wikimedia...SmashPig[master]: Deal with refunds having no txn_type

2016-09-29 Thread Ejegg (Code Review)
Ejegg has uploaded a new change for review. https://gerrit.wikimedia.org/r/313455 Change subject: Deal with refunds having no txn_type .. Deal with refunds having no txn_type Change-Id: Ideaa746a711dc961b0841f3d4ec2bdcfb2525d

[MediaWiki-commits] [Gerrit] wikimedia...SmashPig[deployment]: Merge branch 'master' into deployment

2016-09-29 Thread Ejegg (Code Review)
Ejegg has uploaded a new change for review. https://gerrit.wikimedia.org/r/313438 Change subject: Merge branch 'master' into deployment .. Merge branch 'master' into deployment 09ebe0a Revert "Don't escape unicode while hoop-

[MediaWiki-commits] [Gerrit] wikimedia...SmashPig[master]: Revert "Don't escape unicode while hoop-jumping"

2016-09-29 Thread Ejegg (Code Review)
Ejegg has uploaded a new change for review. https://gerrit.wikimedia.org/r/313437 Change subject: Revert "Don't escape unicode while hoop-jumping" .. Revert "Don't escape unicode while hoop-jumping" This reverts commit fb4b44

[MediaWiki-commits] [Gerrit] wikimedia...SmashPig[deployment]: Merge branch 'master' into deployment

2016-09-29 Thread Ejegg (Code Review)
Ejegg has uploaded a new change for review. https://gerrit.wikimedia.org/r/313431 Change subject: Merge branch 'master' into deployment .. Merge branch 'master' into deployment af62f8d Revert "Put an ampersand on it, maybe it

[MediaWiki-commits] [Gerrit] wikimedia...SmashPig[master]: Revert "Put an ampersand on it, maybe it'll work"

2016-09-29 Thread Ejegg (Code Review)
Ejegg has uploaded a new change for review. https://gerrit.wikimedia.org/r/313430 Change subject: Revert "Put an ampersand on it, maybe it'll work" .. Revert "Put an ampersand on it, maybe it'll work" This reverts commit fef9

[MediaWiki-commits] [Gerrit] wikimedia...SmashPig[master]: Put an ampersand on it, maybe it'll work

2016-09-29 Thread Ejegg (Code Review)
Ejegg has uploaded a new change for review. https://gerrit.wikimedia.org/r/313423 Change subject: Put an ampersand on it, maybe it'll work .. Put an ampersand on it, maybe it'll work $config->object() has an ampersand, and ph

[MediaWiki-commits] [Gerrit] wikimedia...SmashPig[master]: Revert "Get all queues with QueueFactory::getQueue"

2016-09-29 Thread Ejegg (Code Review)
Ejegg has uploaded a new change for review. https://gerrit.wikimedia.org/r/313420 Change subject: Revert "Get all queues with QueueFactory::getQueue" .. Revert "Get all queues with QueueFactory::getQueue" This is segfaulting

[MediaWiki-commits] [Gerrit] wikimedia...SmashPig[master]: Go back to old queue defaults code

2016-09-29 Thread Ejegg (Code Review)
Ejegg has uploaded a new change for review. https://gerrit.wikimedia.org/r/313419 Change subject: Go back to old queue defaults code .. Go back to old queue defaults code New code is segfaulting Change-Id: I0a37ce1abc629cbf3

[MediaWiki-commits] [Gerrit] wikimedia...SmashPig[master]: Don't escape unicode while hoop-jumping

2016-09-28 Thread Ejegg (Code Review)
Ejegg has uploaded a new change for review. https://gerrit.wikimedia.org/r/313341 Change subject: Don't escape unicode while hoop-jumping .. Don't escape unicode while hoop-jumping We're doing silly things to hydrate classes.

[MediaWiki-commits] [Gerrit] wikimedia...SmashPig[deployment]: Merge branch 'master' into deployment

2016-09-28 Thread Ejegg (Code Review)
Ejegg has submitted this change and it was merged. Change subject: Merge branch 'master' into deployment .. Merge branch 'master' into deployment 7d8021c Logging for JobQueueConsumer Change-Id: Ic86f277114b38ebfa7c910f2126b23c

[MediaWiki-commits] [Gerrit] wikimedia...crm[master]: Move Unsubscribe Queue Consumer off ActiveMQ

2016-09-28 Thread Ejegg (Code Review)
Ejegg has submitted this change and it was merged. Change subject: Move Unsubscribe Queue Consumer off ActiveMQ .. Move Unsubscribe Queue Consumer off ActiveMQ Move existing functionality over to the new queue. Bug: T145419 Ch

[MediaWiki-commits] [Gerrit] wikimedia...SmashPig[deployment]: Merge branch 'master' into deployment

2016-09-28 Thread Ejegg (Code Review)
Ejegg has uploaded a new change for review. https://gerrit.wikimedia.org/r/313339 Change subject: Merge branch 'master' into deployment .. Merge branch 'master' into deployment 7d8021c Logging for JobQueueConsumer Change-Id:

[MediaWiki-commits] [Gerrit] wikimedia...SmashPig[master]: Logging for JobQueueConsumer

2016-09-28 Thread Ejegg (Code Review)
Ejegg has uploaded a new change for review. https://gerrit.wikimedia.org/r/313337 Change subject: Logging for JobQueueConsumer .. Logging for JobQueueConsumer Change-Id: I9409efa602b076fc892f2e2d33acc633207f0bfd --- M Core/Qu

[MediaWiki-commits] [Gerrit] wikimedia...SmashPig[master]: Temporary workaround: don't check payments_initial

2016-09-28 Thread Ejegg (Code Review)
Ejegg has uploaded a new change for review. https://gerrit.wikimedia.org/r/313241 Change subject: Temporary workaround: don't check payments_initial .. Temporary workaround: don't check payments_initial Trying to get the payp

[MediaWiki-commits] [Gerrit] wikimedia...SmashPig[deployment]: Merge branch 'master' into deployment

2016-09-28 Thread Ejegg (Code Review)
Ejegg has uploaded a new change for review. https://gerrit.wikimedia.org/r/313229 Change subject: Merge branch 'master' into deployment .. Merge branch 'master' into deployment 4a4382c Fix all db accessors sharing a single in

[MediaWiki-commits] [Gerrit] wikimedia...SmashPig[master]: Explicitly create test tables in sqlite

2016-09-28 Thread Ejegg (Code Review)
Ejegg has submitted this change and it was merged. Change subject: Explicitly create test tables in sqlite .. Explicitly create test tables in sqlite Change-Id: Id48d5b2eeb84b8c181d2f9e0dcf2369ec7cebf0e --- M PaymentProviders/P

[MediaWiki-commits] [Gerrit] wikimedia...SmashPig[master]: DO NOT MERGE investigate SQLite persistence

2016-09-28 Thread Ejegg (Code Review)
Ejegg has uploaded a new change for review. https://gerrit.wikimedia.org/r/313224 Change subject: DO NOT MERGE investigate SQLite persistence .. DO NOT MERGE investigate SQLite persistence Sure seems like we get totally diffe

[MediaWiki-commits] [Gerrit] wikimedia...SmashPig[master]: Null out default config in tearDown

2016-09-27 Thread Ejegg (Code Review)
Ejegg has uploaded a new change for review. https://gerrit.wikimedia.org/r/313135 Change subject: Null out default config in tearDown .. Null out default config in tearDown Change-Id: I2152fd99730b504d8d7f646fee6d077d9702244f

[MediaWiki-commits] [Gerrit] wikimedia...SmashPig[master]: WIP use redis for Adyen jobs

2016-09-27 Thread Ejegg (Code Review)
Ejegg has uploaded a new change for review. https://gerrit.wikimedia.org/r/313130 Change subject: WIP use redis for Adyen jobs .. WIP use redis for Adyen jobs Hmm, looks like this pushing not-arrays actually works for paypal.

[MediaWiki-commits] [Gerrit] wikimedia...SmashPig[master]: Get all queues with QueueFactory::getQueue

2016-09-27 Thread Ejegg (Code Review)
Ejegg has uploaded a new change for review. https://gerrit.wikimedia.org/r/313117 Change subject: Get all queues with QueueFactory::getQueue .. Get all queues with QueueFactory::getQueue Make the 'queue' key default work ever

[MediaWiki-commits] [Gerrit] wikimedia...SmashPig[master]: Update payments_initial when donation completes

2016-09-27 Thread Ejegg (Code Review)
Ejegg has uploaded a new change for review. https://gerrit.wikimedia.org/r/313042 Change subject: Update payments_initial when donation completes .. Update payments_initial when donation completes FIXME: This direct-to-db app

[MediaWiki-commits] [Gerrit] wikimedia...crm[master]: Payments-init consumer only deletes pending on fail

2016-09-26 Thread Ejegg (Code Review)
Ejegg has uploaded a new change for review. https://gerrit.wikimedia.org/r/312939 Change subject: Payments-init consumer only deletes pending on fail .. Payments-init consumer only deletes pending on fail DonationQueueConsume

[MediaWiki-commits] [Gerrit] wikimedia...SmashPig[master]: Error-check the rest of the db calls

2016-09-26 Thread Ejegg (Code Review)
Ejegg has uploaded a new change for review. https://gerrit.wikimedia.org/r/312938 Change subject: Error-check the rest of the db calls .. Error-check the rest of the db calls Make prepareAndExecute return the executed stateme

[MediaWiki-commits] [Gerrit] wikimedia...SmashPig[master]: Always throw exception on execute failure

2016-09-26 Thread Ejegg (Code Review)
Ejegg has uploaded a new change for review. https://gerrit.wikimedia.org/r/312862 Change subject: Always throw exception on execute failure .. Always throw exception on execute failure Change-Id: I7d9763bc499f3c3fc447f76c32aa

[MediaWiki-commits] [Gerrit] wikimedia...PaymentsListeners[master]: Redirect to new listener implementation

2016-09-26 Thread Ejegg (Code Review)
Ejegg has submitted this change and it was merged. Change subject: Redirect to new listener implementation .. Redirect to new listener implementation Change-Id: I87566cfda661dcee92831d8365943cee33f4db28 TODO: rewrite nginx conf

[MediaWiki-commits] [Gerrit] wikimedia...SmashPig[master]: WIP Refactor common database code

2016-09-23 Thread Ejegg (Code Review)
Ejegg has uploaded a new change for review. https://gerrit.wikimedia.org/r/312614 Change subject: WIP Refactor common database code .. WIP Refactor common database code Ugh, why doesnt this work? Change-Id: I22e2d3101383be42

[MediaWiki-commits] [Gerrit] wikimedia...SmashPig[master]: WIP maint script to create all db tables

2016-09-23 Thread Ejegg (Code Review)
Ejegg has uploaded a new change for review. https://gerrit.wikimedia.org/r/312577 Change subject: WIP maint script to create all db tables .. WIP maint script to create all db tables To simplify e.g. vagrant setup now that we

[MediaWiki-commits] [Gerrit] wikimedia...SmashPig[master]: WIP use ct_id to find completed, avoid race

2016-09-23 Thread Ejegg (Code Review)
Ejegg has uploaded a new change for review. https://gerrit.wikimedia.org/r/312563 Change subject: WIP use ct_id to find completed, avoid race .. WIP use ct_id to find completed, avoid race We don't want to drop pending messag

[MediaWiki-commits] [Gerrit] wikimedia...SmashPig[master]: Fix all db accessors sharing a single instance

2016-09-23 Thread Ejegg (Code Review)
Ejegg has uploaded a new change for review. https://gerrit.wikimedia.org/r/312550 Change subject: Fix all db accessors sharing a single instance .. Fix all db accessors sharing a single instance Late static binding fun. Didn

[MediaWiki-commits] [Gerrit] wikimedia...SmashPig[deployment]: Merge branch 'master' into deployment

2016-09-23 Thread Ejegg (Code Review)
Ejegg has uploaded a new change for review. https://gerrit.wikimedia.org/r/312539 Change subject: Merge branch 'master' into deployment .. Merge branch 'master' into deployment and delete tests a2719e4 Test Configuration mer

[MediaWiki-commits] [Gerrit] wikimedia...SmashPig[master]: Add placeholder class for NotificationOfFraud messages

2016-09-22 Thread Ejegg (Code Review)
Ejegg has uploaded a new change for review. https://gerrit.wikimedia.org/r/312460 Change subject: Add placeholder class for NotificationOfFraud messages .. Add placeholder class for NotificationOfFraud messages Not doing anyt

[MediaWiki-commits] [Gerrit] wikimedia...crm[master]: Eradicate Stomp from crm repo

2016-09-22 Thread Ejegg (Code Review)
Ejegg has uploaded a new change for review. https://gerrit.wikimedia.org/r/312443 Change subject: Eradicate Stomp from crm repo .. Eradicate Stomp from crm repo Well, except for composer.lock, since DI still has a dependency

[MediaWiki-commits] [Gerrit] wikimedia...crm[master]: Stop mirroring to stomp from audit processors

2016-09-22 Thread Ejegg (Code Review)
Ejegg has uploaded a new change for review. https://gerrit.wikimedia.org/r/312442 Change subject: Stop mirroring to stomp from audit processors .. Stop mirroring to stomp from audit processors Not sure if those try/catch bloc

[MediaWiki-commits] [Gerrit] wikimedia...crm[master]: Remove obsolete and broken wmf_unsubscribe module

2016-09-22 Thread Ejegg (Code Review)
Ejegg has uploaded a new change for review. https://gerrit.wikimedia.org/r/312441 Change subject: Remove obsolete and broken wmf_unsubscribe module .. Remove obsolete and broken wmf_unsubscribe module This is now handled by t

[MediaWiki-commits] [Gerrit] mediawiki...CentralNotice[master]: jQuery usage tweaks

2016-09-22 Thread Ejegg (Code Review)
Ejegg has submitted this change and it was merged. Change subject: jQuery usage tweaks .. jQuery usage tweaks Use .text() instead of .html() where unneeded, break up node creation and setting value instead of concatenating user

[MediaWiki-commits] [Gerrit] wikimedia...crm[deployment]: Merge commit 'ae5a926512fb07c3a74ed5163e43f83dd93bc917' into...

2016-09-22 Thread Ejegg (Code Review)
Ejegg has uploaded a new change for review. https://gerrit.wikimedia.org/r/312332 Change subject: Merge commit 'ae5a926512fb07c3a74ed5163e43f83dd93bc917' into HEAD .. Merge commit 'ae5a926512fb07c3a74ed5163e43f83dd93bc917' in

[MediaWiki-commits] [Gerrit] wikimedia...SmashPig[master]: Move jobs-paypal under default queue key

2016-09-22 Thread Ejegg (Code Review)
Ejegg has uploaded a new change for review. https://gerrit.wikimedia.org/r/312316 Change subject: Move jobs-paypal under default queue key .. Move jobs-paypal under default queue key So we can use it while running in generic

[MediaWiki-commits] [Gerrit] mediawiki...CentralNotice[master]: Fix paren nesting bug

2016-09-21 Thread Ejegg (Code Review)
Ejegg has uploaded a new change for review. https://gerrit.wikimedia.org/r/312075 Change subject: Fix paren nesting bug .. Fix paren nesting bug Just use !empty instead of counting and comparing to zero. Change-Id: Ifb248273

[MediaWiki-commits] [Gerrit] mediawiki...CentralNotice[master]: Use IDatabase in function signatures

2016-09-21 Thread Ejegg (Code Review)
Ejegg has uploaded a new change for review. https://gerrit.wikimedia.org/r/312073 Change subject: Use IDatabase in function signatures .. Use IDatabase in function signatures See Aaron Schulz's comment on Id4e46b65355. Chang

[MediaWiki-commits] [Gerrit] mediawiki...CentralNotice[master]: Fix typos and PHPdoc hints

2016-09-21 Thread Ejegg (Code Review)
Ejegg has uploaded a new change for review. https://gerrit.wikimedia.org/r/312069 Change subject: Fix typos and PHPdoc hints .. Fix typos and PHPdoc hints One functional thing - misplaced parens with count. Rest is just casin

[MediaWiki-commits] [Gerrit] mediawiki...CentralNotice[master]: Use booleans in function signatures

2016-09-21 Thread Ejegg (Code Review)
Ejegg has uploaded a new change for review. https://gerrit.wikimedia.org/r/312063 Change subject: Use booleans in function signatures .. Use booleans in function signatures Only cast to int just before dropping stuff in the d

[MediaWiki-commits] [Gerrit] wikimedia...SmashPig[master]: Missing use statement

2016-09-20 Thread Ejegg (Code Review)
Ejegg has uploaded a new change for review. https://gerrit.wikimedia.org/r/311895 Change subject: Missing use statement .. Missing use statement Change-Id: I87d4909d1169511d0262e9460ee2dfd3a9898cf6 --- M Core/QueueConsumers/J

[MediaWiki-commits] [Gerrit] mediawiki/core[fundraising/REL1_27]: Update DonationInterface submodule

2016-09-19 Thread Ejegg (Code Review)
Ejegg has uploaded a new change for review. https://gerrit.wikimedia.org/r/311464 Change subject: Update DonationInterface submodule .. Update DonationInterface submodule Change-Id: I81caaf9727c1276560dbd482cd543b8f5556374b -

[MediaWiki-commits] [Gerrit] wikimedia...crm[deployment]: Revert "Mirror messages to new queues in GC audit"

2016-09-17 Thread Ejegg (Code Review)
Ejegg has uploaded a new change for review. https://gerrit.wikimedia.org/r/311319 Change subject: Revert "Mirror messages to new queues in GC audit" .. Revert "Mirror messages to new queues in GC audit" This reverts commit 9b

[MediaWiki-commits] [Gerrit] wikimedia...crm[deployment]: Revert "Mirror queue messages from wmf_audit"

2016-09-17 Thread Ejegg (Code Review)
Ejegg has uploaded a new change for review. https://gerrit.wikimedia.org/r/311320 Change subject: Revert "Mirror queue messages from wmf_audit" .. Revert "Mirror queue messages from wmf_audit" This reverts commit db7469fb2405

[MediaWiki-commits] [Gerrit] mediawiki...FundraisingEmailUnsubscribe[master]: Add tests for thank you unsubscribe

2016-09-16 Thread Ejegg (Code Review)
Ejegg has uploaded a new change for review. https://gerrit.wikimedia.org/r/311174 Change subject: Add tests for thank you unsubscribe .. Add tests for thank you unsubscribe Move queue instantiation into a helper class so test

[MediaWiki-commits] [Gerrit] wikimedia...SmashPig[master]: More details for PendingQueueConsumer log

2016-09-15 Thread Ejegg (Code Review)
Ejegg has uploaded a new change for review. https://gerrit.wikimedia.org/r/311071 Change subject: More details for PendingQueueConsumer log .. More details for PendingQueueConsumer log $data doesn't show up in the Jenkins out

[MediaWiki-commits] [Gerrit] mediawiki...FundraisingEmailUnsubscribe[master]: Mirror messages to php-queue backend

2016-09-15 Thread Ejegg (Code Review)
Ejegg has uploaded a new change for review. https://gerrit.wikimedia.org/r/311070 Change subject: Mirror messages to php-queue backend .. Mirror messages to php-queue backend Might want to catch potential exceptions. Bug: T1

[MediaWiki-commits] [Gerrit] mediawiki...FundraisingEmailUnsubscribe[master]: Update libs, add php-queue and predis

2016-09-15 Thread Ejegg (Code Review)
Ejegg has uploaded a new change for review. https://gerrit.wikimedia.org/r/311062 Change subject: Update libs, add php-queue and predis .. Update libs, add php-queue and predis Preparing to switch off of ActiveMQ Bug: T14541

[MediaWiki-commits] [Gerrit] wikimedia...SmashPig[deployment]: Live hack to dump configuration

2016-09-15 Thread Ejegg (Code Review)
Ejegg has submitted this change and it was merged. Change subject: Live hack to dump configuration .. Live hack to dump configuration Change-Id: I956caf3362cc5c286a0a51cd7cf73018909e8906 --- M Core/Listeners/ListenerBase.php 1

[MediaWiki-commits] [Gerrit] wikimedia...SmashPig[master]: Live hack: try restoring inst-args for one thing

2016-09-15 Thread Ejegg (Code Review)
Ejegg has uploaded a new change for review. https://gerrit.wikimedia.org/r/311039 Change subject: Live hack: try restoring inst-args for one thing .. Live hack: try restoring inst-args for one thing Change-Id: I920e8f2cdda39f

[MediaWiki-commits] [Gerrit] mediawiki...DonationInterface[deployment]: Push limbo message, don't set

2016-09-15 Thread Ejegg (Code Review)
Ejegg has uploaded a new change for review. https://gerrit.wikimedia.org/r/310888 Change subject: Push limbo message, don't set .. Push limbo message, don't set Bug: T145776 Change-Id: Ib95288761b9c6d3b10a5543e2484859f344ea82

[MediaWiki-commits] [Gerrit] mediawiki...DonationInterface[master]: Push limbo message, don't set

2016-09-15 Thread Ejegg (Code Review)
Ejegg has uploaded a new change for review. https://gerrit.wikimedia.org/r/310884 Change subject: Push limbo message, don't set .. Push limbo message, don't set Bug: T145776 Change-Id: Ib95288761b9c6d3b10a5543e2484859f344ea82

[MediaWiki-commits] [Gerrit] wikimedia...SmashPig[master]: Clean up antifraud queue usage

2016-09-14 Thread Ejegg (Code Review)
Ejegg has submitted this change and it was merged. Change subject: Clean up antifraud queue usage .. Clean up antifraud queue usage No more KeyedOpaqueStorableObject or mirroring to ActiveMQ, just push an array straight to Redi

[MediaWiki-commits] [Gerrit] wikimedia...SmashPig[master]: Add 'IF NOT EXISTS' to table creation

2016-09-14 Thread Ejegg (Code Review)
Ejegg has uploaded a new change for review. https://gerrit.wikimedia.org/r/310707 Change subject: Add 'IF NOT EXISTS' to table creation .. Add 'IF NOT EXISTS' to table creation Because too lazy for proper schema migration Ch

[MediaWiki-commits] [Gerrit] mediawiki...DonationInterface[master]: Make sure tests fail on missing response file

2016-09-14 Thread Ejegg (Code Review)
Ejegg has uploaded a new change for review. https://gerrit.wikimedia.org/r/310684 Change subject: Make sure tests fail on missing response file .. Make sure tests fail on missing response file We were relying on something tha

[MediaWiki-commits] [Gerrit] wikimedia...SmashPig[master]: Clean up antifraud queue usage

2016-09-14 Thread Ejegg (Code Review)
Ejegg has uploaded a new change for review. https://gerrit.wikimedia.org/r/310670 Change subject: Clean up antifraud queue usage .. Clean up antifraud queue usage No more KeyedOpaqueStorableObject or mirroring to ActiveMQ, ju

[MediaWiki-commits] [Gerrit] wikimedia...SmashPig[master]: Remove all traces of stomp pending queue

2016-09-14 Thread Ejegg (Code Review)
Ejegg has uploaded a new change for review. https://gerrit.wikimedia.org/r/310665 Change subject: Remove all traces of stomp pending queue .. Remove all traces of stomp pending queue DEPLOYMENT NOTE: Redis queue is now just c

[MediaWiki-commits] [Gerrit] mediawiki...CentralNotice[master]: WIP MariaDB strict mode

2016-09-13 Thread Ejegg (Code Review)
Ejegg has uploaded a new change for review. https://gerrit.wikimedia.org/r/310457 Change subject: WIP MariaDB strict mode .. WIP MariaDB strict mode Thanks for the handy 'mysql-only' comments on the transitional code! Bug: T

[MediaWiki-commits] [Gerrit] wikimedia...crm[master]: Clean up DonationQueueConsumer

2016-09-13 Thread Ejegg (Code Review)
Ejegg has uploaded a new change for review. https://gerrit.wikimedia.org/r/310415 Change subject: Clean up DonationQueueConsumer .. Clean up DonationQueueConsumer updateFromPendingDb wasn't doing enough to justify its odd sig

[MediaWiki-commits] [Gerrit] wikimedia...crm[master]: Update SmashPig & DonationInterface libraries

2016-09-13 Thread Ejegg (Code Review)
Ejegg has uploaded a new change for review. https://gerrit.wikimedia.org/r/310377 Change subject: Update SmashPig & DonationInterface libraries .. Update SmashPig & DonationInterface libraries And update SmashPig config usage

[MediaWiki-commits] [Gerrit] mediawiki...DonationInterface[master]: Update SmashPig lib & config usage

2016-09-13 Thread Ejegg (Code Review)
Ejegg has uploaded a new change for review. https://gerrit.wikimedia.org/r/310372 Change subject: Update SmashPig lib & config usage .. Update SmashPig lib & config usage Change-Id: I33d69bed8d069a11ead2f1093e9883d60601d49f -

[MediaWiki-commits] [Gerrit] wikimedia...crm[master]: Remove wmf_zendesk_reports

2016-09-12 Thread Ejegg (Code Review)
Ejegg has uploaded a new change for review. https://gerrit.wikimedia.org/r/310137 Change subject: Remove wmf_zendesk_reports .. Remove wmf_zendesk_reports Donor services is no longer using it, and the API is about to go away.

[MediaWiki-commits] [Gerrit] wikimedia...crm[deployment]: Merge branch 'master' into deployment

2016-09-12 Thread Ejegg (Code Review)
Ejegg has uploaded a new change for review. https://gerrit.wikimedia.org/r/310057 Change subject: Merge branch 'master' into deployment .. Merge branch 'master' into deployment 4e8e1cf Remove placeholder email addresses. Cha

[MediaWiki-commits] [Gerrit] wikimedia...crm[master]: Move recurring queue consumer off ActiveMQ

2016-09-09 Thread Ejegg (Code Review)
Ejegg has uploaded a new change for review. https://gerrit.wikimedia.org/r/309618 Change subject: Move recurring queue consumer off ActiveMQ .. Move recurring queue consumer off ActiveMQ Just moving to the new queue with this

[MediaWiki-commits] [Gerrit] wikimedia...crm[master]: Import refunds by contribution ID

2016-09-08 Thread Ejegg (Code Review)
Ejegg has uploaded a new change for review. https://gerrit.wikimedia.org/r/309397 Change subject: Import refunds by contribution ID .. Import refunds by contribution ID Handy for recurring transactions that have funky order I

[MediaWiki-commits] [Gerrit] mediawiki/vagrant[master]: Set up SmashPig cron and more tables

2016-09-07 Thread Ejegg (Code Review)
Ejegg has uploaded a new change for review. https://gerrit.wikimedia.org/r/309221 Change subject: Set up SmashPig cron and more tables .. Set up SmashPig cron and more tables Consume the pending queue to db once a minute. No

[MediaWiki-commits] [Gerrit] wikimedia...crm[master]: Update .gitignore

2016-09-07 Thread Ejegg (Code Review)
Ejegg has uploaded a new change for review. https://gerrit.wikimedia.org/r/309207 Change subject: Update .gitignore .. Update .gitignore Fix settings path convention, add .version-stamp Change-Id: Ia3827f6c8dd0d2cdb8b8327575

[MediaWiki-commits] [Gerrit] wikimedia...SmashPig[master]: Test for RecordCaptureJob

2016-09-07 Thread Ejegg (Code Review)
Ejegg has submitted this change and it was merged. Change subject: Test for RecordCaptureJob .. Test for RecordCaptureJob Change-Id: I65199c509e03ed0d0eeb6c3e81367d86ad6812a0 --- A PaymentProviders/Adyen/Tests/Data/capture.json

[MediaWiki-commits] [Gerrit] wikimedia...SmashPig[master]: Allow overriding with dissimilar types

2016-09-07 Thread Ejegg (Code Review)
Ejegg has submitted this change and it was merged. Change subject: Allow overriding with dissimilar types .. Allow overriding with dissimilar types Sometimes inst-args[0] needs to be an array, even when the default value is a s

[MediaWiki-commits] [Gerrit] wikimedia...SmashPig[master]: Helper to clear *Database singletons

2016-09-07 Thread Ejegg (Code Review)
Ejegg has submitted this change and it was merged. Change subject: Helper to clear *Database singletons .. Helper to clear *Database singletons Change-Id: Ie0f2c5f03ce440917feed73c74078efa275f2688 --- M Tests/PaymentsInitialDat

[MediaWiki-commits] [Gerrit] wikimedia...SmashPig[master]: Defaults for more queues

2016-09-07 Thread Ejegg (Code Review)
Ejegg has uploaded a new change for review. https://gerrit.wikimedia.org/r/309181 Change subject: Defaults for more queues .. Defaults for more queues Add Redis versions of donations, refunds, and recurring Change-Id: I73bb2

[MediaWiki-commits] [Gerrit] mediawiki/vagrant[master]: Update queue settings for payments role

2016-09-07 Thread Ejegg (Code Review)
Ejegg has uploaded a new change for review. https://gerrit.wikimedia.org/r/309179 Change subject: Update queue settings for payments role .. Update queue settings for payments role Add settings for Redis versions of all the n

[MediaWiki-commits] [Gerrit] wikimedia...crm[master]: WIP Get donation queue consumer off ActiveMQ

2016-09-06 Thread Ejegg (Code Review)
Ejegg has uploaded a new change for review. https://gerrit.wikimedia.org/r/308800 Change subject: WIP Get donation queue consumer off ActiveMQ .. WIP Get donation queue consumer off ActiveMQ Bug: T131277 Change-Id: Iae39859d0

[MediaWiki-commits] [Gerrit] wikimedia...crm[deployment]: Merge branch 'master' into deployment

2016-09-06 Thread Ejegg (Code Review)
Ejegg has uploaded a new change for review. https://gerrit.wikimedia.org/r/308781 Change subject: Merge branch 'master' into deployment .. Merge branch 'master' into deployment feffaf4 Move banner history off ActiveMQ d0ba956

[MediaWiki-commits] [Gerrit] mediawiki...DonationInterface[master]: Set order_id earlier for paypal legacy

2016-09-02 Thread Ejegg (Code Review)
Ejegg has uploaded a new change for review. https://gerrit.wikimedia.org/r/308201 Change subject: Set order_id earlier for paypal legacy .. Set order_id earlier for paypal legacy This should make sure it's in the payments-ini

[MediaWiki-commits] [Gerrit] wikimedia...crm[deployment]: Merge branch 'master' into deployment

2016-09-01 Thread Ejegg (Code Review)
Ejegg has uploaded a new change for review. https://gerrit.wikimedia.org/r/308083 Change subject: Merge branch 'master' into deployment .. Merge branch 'master' into deployment d1213d0 Move payments-init queue off ActiveMQ ea

[MediaWiki-commits] [Gerrit] wikimedia...crm[deployment]: Initialize SmashPig logger in fredge qc

2016-08-30 Thread Ejegg (Code Review)
Ejegg has uploaded a new change for review. https://gerrit.wikimedia.org/r/307685 Change subject: Initialize SmashPig logger in fredge qc .. Initialize SmashPig logger in fredge qc Change-Id: I4359576fd9d3515607a2f1daf8432468

[MediaWiki-commits] [Gerrit] wikimedia...crm[master]: Initialize SmashPig logger in fredge qc

2016-08-30 Thread Ejegg (Code Review)
Ejegg has uploaded a new change for review. https://gerrit.wikimedia.org/r/307684 Change subject: Initialize SmashPig logger in fredge qc .. Initialize SmashPig logger in fredge qc Change-Id: I4359576fd9d3515607a2f1daf8432468

[MediaWiki-commits] [Gerrit] wikimedia...crm[deployment]: Fix AntifraudQueueConsumer constructor arguments

2016-08-30 Thread Ejegg (Code Review)
Ejegg has uploaded a new change for review. https://gerrit.wikimedia.org/r/307682 Change subject: Fix AntifraudQueueConsumer constructor arguments .. Fix AntifraudQueueConsumer constructor arguments Time limit comes first, ta

[MediaWiki-commits] [Gerrit] wikimedia...crm[master]: Fix constructor args for payments-init consumer

2016-08-30 Thread Ejegg (Code Review)
Ejegg has uploaded a new change for review. https://gerrit.wikimedia.org/r/307681 Change subject: Fix constructor args for payments-init consumer .. Fix constructor args for payments-init consumer See parent patch Change-Id:

[MediaWiki-commits] [Gerrit] wikimedia...crm[master]: Fix AntifraudQueueConsumer constructor arguments

2016-08-30 Thread Ejegg (Code Review)
Ejegg has uploaded a new change for review. https://gerrit.wikimedia.org/r/307680 Change subject: Fix AntifraudQueueConsumer constructor arguments .. Fix AntifraudQueueConsumer constructor arguments Time limit comes first, me

[MediaWiki-commits] [Gerrit] wikimedia...crm[deployment]: Move antifraud queue off ActiveMQ

2016-08-30 Thread Ejegg (Code Review)
Ejegg has uploaded a new change for review. https://gerrit.wikimedia.org/r/307679 Change subject: Move antifraud queue off ActiveMQ .. Move antifraud queue off ActiveMQ Requirements: * Mirror antifraud queue to redis (in both

<    9   10   11   12   13   14   15   16   17   18   >