Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/313895
Change subject: Should be possible to scroll to footer on diff page
..
Should be possible to scroll to footer on diff page
Bug: T144579
Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/313869
Change subject: Enable Wikidata descriptions on Japanese and Spanish Wikipedias
..
Enable Wikidata descriptions on Japanese and Spanish
Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/313862
Change subject: Protected pages should show edit link and toast when clicked
..
Protected pages should show edit link and toast when
Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/313864
Change subject: Protected pages should show edit link and toast when clicked
..
Protected pages should show edit link and toast when
Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/313858
Change subject: Language selector should inherit float rather than clear it
..
Language selector should inherit float rather than clear it
Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/313611
Change subject: POC: MobileFrontend should be able to use MobileContentService
..
POC: MobileFrontend should be able to use
Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/313610
Change subject: Hygiene: Move media queries to end of the file
..
Hygiene: Move media queries to end of the file
For readability
Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/313470
Change subject: If not possible to edit user page do not show edit link
..
If not possible to edit user page do not show edit link
If
Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/313446
Change subject: jscs: Enforce 4 space indents
..
jscs: Enforce 4 space indents
Change-Id: Ic4fb02cc992baebab6046e9b2f4493997f44c66e
---
M
Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/313445
Change subject: Enforcing coding style conventions with jscs
..
Enforcing coding style conventions with jscs
(It autofixes as well yay!)
Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/313324
Change subject: Flatten image descriptions in media endpoints
..
Flatten image descriptions in media endpoints
Bug: T117941
Change-Id:
Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/313322
Change subject: Prepatory work for versioning
..
Prepatory work for versioning
Introduce buildLeadResponse and buildAllResponse
This will
Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/313316
Change subject: Update definition test
..
Update definition test
The italic tag it looks for no longer exists.
It's not clear why we need
Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/313314
Change subject: Use mw-ui-progressive rather than deprecated mw-ui-primary
..
Use mw-ui-progressive rather than deprecated mw-ui-primary
Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/313313
Change subject: Use mw-ui-progressive for buttons
..
Use mw-ui-progressive for buttons
constructive and primary are deprecated
Bug:
Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/313312
Change subject: Use mw-ui-progressive for button classes
..
Use mw-ui-progressive for button classes
mw-ui-constructive and mw-ui-primary
Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/313228
Change subject: Use mw-ui-progressive on constructive buttons
..
Use mw-ui-progressive on constructive buttons
For backwards compatibility
Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/313227
Change subject: Migrate away from deprecated mw-ui-constructive and
mw-ui-primary classes
..
Migrate away from deprecated
Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/313226
Change subject: feature-page-action-bar-v2 class is no longer necessary
..
feature-page-action-bar-v2 class is no longer necessary
This
Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/313225
Change subject: Ignore bundle when linting
..
Ignore bundle when linting
A vendor folder can be created via `bundle install`
If present
Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/313216
Change subject: Move border top from last modifier bar to footer container
..
Move border top from last modifier bar to footer container
Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/313150
Change subject: WIP: Expose references in a new endpoint
..
WIP: Expose references in a new endpoint
Bug: T146398
Change-Id:
Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/313149
Change subject: Mark reference sections with isReferenceSection flag
..
Mark reference sections with isReferenceSection flag
When a
Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/313070
Change subject: WIP: Remove MinervaUsePageActionBarV2 config variable
..
WIP: Remove MinervaUsePageActionBarV2 config variable
It doesn't
Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/312957
Change subject: Upgrade stylelint
..
Upgrade stylelint
The old version is throwing errors.
Change-Id:
Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/312950
Change subject: Always render tagline container
..
Always render tagline container
I considered moving the margin-bottom from the tagline
Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/312948
Change subject: Blank user pages should be editable
..
Blank user pages should be editable
* Untangle checking if a page is editable from
Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/312946
Change subject: Be explicit with dependency
..
Be explicit with dependency
If skins.minerva.scripts is top loaded
(ie. a module is added
Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/312935
Change subject: POC: UCMini browser should behave correctly as a NORLQ client
..
POC: UCMini browser should behave correctly as a NORLQ
Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/312431
Change subject: Improve documentation/parameter names of openPopup method
..
Improve documentation/parameter names of openPopup method
Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/312425
Change subject: Improve documentation for render methods
..
Improve documentation for render methods
The parameter types are incorrect and
Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/312428
Change subject: Hygiene: Not necessary for private methods to be globally
available
..
Hygiene: Not necessary for private methods to be
Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/312427
Change subject: Hygiene: Only allow calls to closePopup on an active link
..
Hygiene: Only allow calls to closePopup on an active link
Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/312426
Change subject: Hygiene: Add set and get methods for active link
..
Hygiene: Add set and get methods for active link
Named functions help
Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/312343
Change subject: Hygiene: Remove phantom config variable
..
Hygiene: Remove phantom config variable
This config option dates back to mobile
Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/312344
Change subject: Reflect production in config defaults
..
Reflect production in config defaults
It's confusing to see something different
Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/312339
Change subject: Cleanup deprecated MobileFrontend variables
..
Cleanup deprecated MobileFrontend variables
* Remove no longer used central
Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/312105
Change subject: Revert "Convert 'seenTime' to a global property"
..
Revert "Convert 'seenTime' to a global property"
This change breaks
Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/312082
Change subject: Use module registry for defining ext.popups.experiment
..
Use module registry for defining ext.popups.experiment
Since
Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/311753
Change subject: Dismiss event should not be tied to render method
..
Dismiss event should not be tied to render method
The dismiss event
Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/311595
Change subject: Minor refactor - use named function for wikipage.content hook
..
Minor refactor - use named function for wikipage.content
Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/311596
Change subject: Clicking a Hovercards legible link should close popup
..
Clicking a Hovercards legible link should close popup
Bug:
Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/311484
Change subject: Articles should not appear stacked on iPad Air 2
..
Articles should not appear stacked on iPad Air 2
Using a vendor prefix
Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/310458
Change subject: Talk browser test should check JS has loaded before continuing
..
Talk browser test should check JS has loaded before
Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/310389
Change subject: Toast should be centered on mobile devices
..
Toast should be centered on mobile devices
Bug: T144828
Change-Id:
Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/310141
Change subject: Run RelatedArticles browser tests on every commit
..
Run RelatedArticles browser tests on every commit
Change-Id:
Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/310139
Change subject: Beta should be available to test suite.
..
Beta should be available to test suite.
This old classic returns again.
A
Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/310135
Change subject: NORLQ clients should be able to handle images without class
attribute
..
NORLQ clients should be able to handle images
Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/309698
Change subject: Map should have `has` and `entries` methods
..
Map should have `has` and `entries` methods
Just like native Maps do.
Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/309409
Change subject: Copy height and width attributes from style to lazy placeholder
..
Copy height and width attributes from style to lazy
Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/309219
Change subject: WIP: Breaking change - drop lead section from sections property
..
WIP: Breaking change - drop lead section from sections
Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/309218
Change subject: Extract first paragraph from lead section
..
Extract first paragraph from lead section
After detecting the most suitable
Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/309200
Change subject: Extract infobox into its own property
..
Extract infobox into its own property
Bug: T145034
Change-Id:
Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/309191
Change subject: Extract page issues and promote to a readable data structure
..
Extract page issues and promote to a readable data
Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/309170
Change subject: Add class to IPA container, do not use inline style
..
Add class to IPA container, do not use inline style
This is error
Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/309165
Change subject: Remove hatnote from lead section content
..
Remove hatnote from lead section content
Please use `lead.hatnote` to obtain
Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/309164
Change subject: Hatnote should be promoted outside lead section html
..
Hatnote should be promoted outside lead section html
The
Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/309151
Change subject: Surface coordinates on Wikivoyage
..
Surface coordinates on Wikivoyage
Bug: T145003
Change-Id:
Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/309087
Change subject: Correct dblist definition
..
Correct dblist definition
It seems you cannot mix names with formulae in a dblist
definition.
Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/309033
Change subject: Remove wikidata descriptions from additional projects
..
Remove wikidata descriptions from additional projects
Change-Id:
Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/309032
Change subject: Revert "Enable Wikidata descriptions on all wikipedias"
..
Revert "Enable Wikidata descriptions on all wikipedias"
This
Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/308910
Change subject: Treat list items as inline
..
Treat list items as inline
Bug: T144567
Change-Id: I911f305fa130e60991e830708d6680599870cc13
Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/308909
Change subject: Improve handling of images without dimensions
..
Improve handling of images without dimensions
Currently these are loading
Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/308905
Change subject: Remove outdated CSS selectors
..
Remove outdated CSS selectors
None of these css selectors do anything.
They relate to old
Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/308221
Change subject: Remove styles for old Minerva design
..
Remove styles for old Minerva design
This CSS rule exists for Minerva's old
Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/308094
Change subject: Convert JsonConfigModels and JsonConfigs to attributes
..
Convert JsonConfigModels and JsonConfigs to attributes
Bug:
Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/307984
Change subject: DONOTMERGE: Purposely break Zero
..
DONOTMERGE: Purposely break Zero
Yeehhh that's right.
Change-Id:
Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/307971
Change subject: Ensure lazy image placeholders without height can be loaded
..
Ensure lazy image placeholders without height can be loaded
Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/307970
Change subject: Update router code
..
Update router code
Router has moved to core, use it. Also run checkRoute method per
documentation
Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/307969
Change subject: Enable on all wikipedias
..
Enable on all wikipedias
Bug: T143345
Change-Id: I4a5183792e260d9155bf02e89905deb9a6661f04
---
Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/307968
Change subject: Do not show Wikidata descriptions on meta or mediawiki.org
..
Do not show Wikidata descriptions on meta or mediawiki.org
Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/307967
Change subject: Enable Wikidata descriptions taglines on labs
..
Enable Wikidata descriptions taglines on labs
The default rule is
Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/307966
Change subject: Remove redundant class
..
Remove redundant class
This was introduced in 6c36175c without explanation.
I suspect it was
Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/307879
Change subject: DONOTMERGE: Test
..
DONOTMERGE: Test
Change-Id: Id7f0981fa197aa37215ee7ea4a38b62c777595b4
---
M
Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/307826
Change subject: Move qunit tests to tests/qunit
..
Move qunit tests to tests/qunit
Follow up in anticipation of phpunit tests being in
Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/307804
Change subject: Don't hit the DB unnecessarily
..
Don't hit the DB unnecessarily
If $wgRelatedArticlesShowInFooter is false, then we'll
Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/307801
Change subject: Revert "Don't hit the DB unnecessarily"
..
Revert "Don't hit the DB unnecessarily"
We forgot how namespaces work:
Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/307794
Change subject: Make ZeroBanner and MobileApps dependencies of MobileFrontend
..
Make ZeroBanner and MobileApps dependencies of
Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/307774
Change subject: Enable jquery.ui.position on mobile
..
Enable jquery.ui.position on mobile
Although this module is deprecated it appears
Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/307664
Change subject: Add basic test for Zero
..
Add basic test for Zero
If the module loads with an error we should complain.
ZeroBanner tests
Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/307631
Change subject: Enable Wikidata description taglines on all projects...
..
Enable Wikidata description taglines on all projects...
...
Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/307435
Change subject: End lazy loading reference experiments
..
End lazy loading reference experiments
This is being put on hold for a while. We
Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/307024
Change subject: Rotate chevron in opposite direction for RTL
..
Rotate chevron in opposite direction for RTL
Bug: T141002
Change-Id:
Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/306970
Change subject: Hide chevron in last modified bar for non-js users
..
Hide chevron in last modified bar for non-js users
Bug: T144036
Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/306963
Change subject: Use more widely supported 2d transform for chevron rotate
..
Use more widely supported 2d transform for chevron rotate
Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/306953
Change subject: Ensure all lazy image placeholders have a height
..
Ensure all lazy image placeholders have a height
Bug: T143768
Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/306945
Change subject: Revert "Copy style attribute to lazy placeholder"
..
Revert "Copy style attribute to lazy placeholder"
This caused several
Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/306824
Change subject: Don't cause fatals on preferences page when default skin is
Minerva
..
Don't cause fatals on preferences page when default
Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/306801
Change subject: Media viewer design tweaks
..
Media viewer design tweaks
Hide close and slider buttons on click and resposition close icon
Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/306799
Change subject: Show user icon on Diff and Contributions special pages
..
Show user icon on Diff and Contributions special pages
Both show
Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/306797
Change subject: Fix padding on language overlay search input
..
Fix padding on language overlay search input
Bug: T143437
Change-Id:
Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/306796
Change subject: Clear icon should be small
..
Clear icon should be small
Additional changes:
* Client side Icon now supports isSmall
Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/306732
Change subject: Final design tweaks to footer
..
Final design tweaks to footer
* Add a padding bottom to footer per Nirzar (totals 15px at
Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/306708
Change subject: Fix bad markup in footer
..
Fix bad markup in footer
Close footer tag not div
Change-Id:
Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/306479
Change subject: Don't treat certain image placeholders as block
..
Don't treat certain image placeholders as block
Bug: T143558
Change-Id:
Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/306473
Change subject: Add separators between footer links in beta
..
Add separators between footer links in beta
Bug: T141002
Change-Id:
Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/306472
Change subject: Footer / chrome color changes
..
Footer / chrome color changes
* Introduce new LESS variable skinContentBgColor to control
Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/306451
Change subject: Copy style attribute to lazy placeholder
..
Copy style attribute to lazy placeholder
Width and height attributes may not
Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/306058
Change subject: POC: Refactor performSearch method
..
POC: Refactor performSearch method
Change-Id:
Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/306048
Change subject: Update Gemfile
..
Update Gemfile
Bug: T143601
Change-Id: I39e49017c66a5267e1273ea4372863f8e38e4218
---
M Gemfile.lock
1
1001 - 1100 of 5253 matches
Mail list logo