[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Parser on skins other than DefaultSkins

2017-07-21 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/366988 ) Change subject: Parser on skins other than DefaultSkins .. Parser on skins other than DefaultSkins the last piece of the puzzle... Someo

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Adjustments to floating elements in print styles

2017-07-21 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/366971 ) Change subject: Adjustments to floating elements in print styles .. Adjustments to floating elements in print styles Bug: T169823 Change-

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Adjust print styles for thumb

2017-07-21 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/366970 ) Change subject: Adjust print styles for thumb .. Adjust print styles for thumb Bug: T169823 Change-Id: If32f76f11f260bb33decf1ebe934470ac

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Fix font size and backgrounds in gallery

2017-07-21 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/366967 ) Change subject: Fix font size and backgrounds in gallery .. Fix font size and backgrounds in gallery In print medium we should be explici

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Adjustments to printed table styles

2017-07-21 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/366968 ) Change subject: Adjustments to printed table styles .. Adjustments to printed table styles * Remove bolding * Remove backgrounds * Explic

[MediaWiki-commits] [Gerrit] mediawiki...mobileapps[master]: Define response behaviour for a variety of endpoints

2017-07-21 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/366947 ) Change subject: Define response behaviour for a variety of endpoints .. Define response behaviour for a variety of endpoints Per the spec

[MediaWiki-commits] [Gerrit] mediawiki...mobileapps[master]: Expose content model in response

2017-07-21 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/366909 ) Change subject: Expose content model in response .. Expose content model in response Certain pages are not wikitext. This flags those to

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Add sensible defaults to mediawiki.hlist module

2017-07-21 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/366892 ) Change subject: Add sensible defaults to mediawiki.hlist module .. Add sensible defaults to mediawiki.hlist module This allows skins to d

[MediaWiki-commits] [Gerrit] mediawiki...Vector[master]: Print styles: footer

2017-07-20 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/366738 ) Change subject: Print styles: footer .. Print styles: footer Bug: T169823 Change-Id: Ie678967a27baec8715cf86b6a0f7e7651f867be1 --- M prin

[MediaWiki-commits] [Gerrit] mediawiki...Vector[master]: Experimental table of content print styles

2017-07-20 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/366618 ) Change subject: Experimental table of content print styles .. Experimental table of content print styles Bug: T169823 Change-Id: I8a20c70

[MediaWiki-commits] [Gerrit] mediawiki...mobileapps[master]: Expose disambiguation flag on pages

2017-07-20 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/366587 ) Change subject: Expose disambiguation flag on pages .. Expose disambiguation flag on pages This will be needed by web as part of the page

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Hygiene: Fix phpcs line length complaint

2017-07-20 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/366580 ) Change subject: Hygiene: Fix phpcs line length complaint .. Hygiene: Fix phpcs line length complaint Change-Id: I532e323cdd0ce5bec7450eb5

[MediaWiki-commits] [Gerrit] mediawiki...MinervaNeue[master]: Hygiene: Copy across bits of README.md from MobileFrontend

2017-07-20 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/366578 ) Change subject: Hygiene: Copy across bits of README.md from MobileFrontend .. Hygiene: Copy across bits of README.md from MobileFrontend

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Hygiene: Update README

2017-07-20 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/366577 ) Change subject: Hygiene: Update README .. Hygiene: Update README * Remove Minerva parts * Update typo in config variable name Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...MinervaNeue[master]: Don't show ImageOverlay in desktop mode - delegate to multi...

2017-07-19 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/366482 ) Change subject: Don't show ImageOverlay in desktop mode - delegate to multimedia viewer .. Don't show ImageOverlay in desktop mode - del

[MediaWiki-commits] [Gerrit] integration/config[master]: Include Vector in phpunit tests for MobileFrontend

2017-07-19 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/366470 ) Change subject: Include Vector in phpunit tests for MobileFrontend .. Include Vector in phpunit tests for MobileFrontend It seems that pa

[MediaWiki-commits] [Gerrit] mediawiki...MinervaNeue[master]: Minerva should use mediawiki.hlist

2017-07-19 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/366423 ) Change subject: Minerva should use mediawiki.hlist .. Minerva should use mediawiki.hlist Override provided styles Bug: T42062 Depends-On

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Stop RelatedArticles A/B test and clean up config

2017-07-19 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/366314 ) Change subject: Stop RelatedArticles A/B test and clean up config .. Stop RelatedArticles A/B test and clean up config Bug: T169948 Chang

[MediaWiki-commits] [Gerrit] mediawiki...Vector[master]: Feature flagged print styles

2017-07-18 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/366173 ) Change subject: Feature flagged print styles .. Feature flagged print styles These are feature flagged to allow editors to test before ma

[MediaWiki-commits] [Gerrit] mediawiki...Thanks[wmf/1.30.0-wmf.9]: Add missing jQueryMsg dependency for mobile diff view

2017-07-18 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/366168 ) Change subject: Add missing jQueryMsg dependency for mobile diff view .. Add missing jQueryMsg dependency for mobile diff view Bug: T1709

[MediaWiki-commits] [Gerrit] mediawiki...Vector[master]: Don't print #siteSub

2017-07-18 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/366155 ) Change subject: Don't print #siteSub .. Don't print #siteSub Bug: T169823 Change-Id: I45f0abe6ab9378830fa59356b29ff6953962f477 --- M Vect

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Exclude various elements from printed view

2017-07-18 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/366113 ) Change subject: Exclude various elements from printed view .. Exclude various elements from printed view This change adds the noprint cla

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[wmf/1.30.0-wmf.10]: Ship hour last modified message

2017-07-18 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/366020 ) Change subject: Ship hour last modified message .. Ship hour last modified message This was accidentally lost in I598e9230fc27aae46d8d55c

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Ship hour last modified message

2017-07-18 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/366018 ) Change subject: Ship hour last modified message .. Ship hour last modified message This was accidentally lost in I598e9230fc27aae46d8d55c

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[wmf/1.30.0-wmf.9]: Ship hour last modified message

2017-07-18 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/366019 ) Change subject: Ship hour last modified message .. Ship hour last modified message This was accidentally lost in I598e9230fc27aae46d8d55c

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[wmf/1.30.0-wmf.9]: Revert "Revert "Fixups prior to Minerva/MobileFrontend separ...

2017-07-18 Thread Jdlrobson (Code Review)
Hello Thcipriani, Chad, Niedzielski, jenkins-bot, Siebrand, I'd like you to do a code review. Please visit https://gerrit.wikimedia.org/r/366007 to review the following change. Change subject: Revert "Revert "Fixups prior to Minerva/MobileFrontend separation"" ...

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Minerva is live everywhere

2017-07-17 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/365875 ) Change subject: Minerva is live everywhere .. Minerva is live everywhere Bug: T166748 Change-Id: Iafc085ed507dcfcad11c5f4725fe7997778d176

[MediaWiki-commits] [Gerrit] mediawiki...MinervaNeue[wmf/1.30.0-wmf.9]: Add missing Minerva skin description message key

2017-07-17 Thread Jdlrobson (Code Review)
Hello Thcipriani, Chad, Niedzielski, jenkins-bot, Siebrand, I'd like you to do a code review. Please visit https://gerrit.wikimedia.org/r/365861 to review the following change. Change subject: Add missing Minerva skin description message key ...

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Revert "Revert "Minerva is its own skin""

2017-07-17 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/365859 ) Change subject: Revert "Revert "Minerva is its own skin"" .. Revert "Revert "Minerva is its own skin"" This reverts commit 4e6cba5d18081c

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Revert "Revert "Fixups prior to Minerva/MobileFrontend separ...

2017-07-17 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/365858 ) Change subject: Revert "Revert "Fixups prior to Minerva/MobileFrontend separation"" .. Revert "Revert "Fixups prior to Minerva/MobileFron

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[wmf/1.30.0-wmf.9]: Revert "Revert "Minerva is its own skin""

2017-07-17 Thread Jdlrobson (Code Review)
Hello Thcipriani, Chad, Niedzielski, jenkins-bot, Siebrand, I'd like you to do a code review. Please visit https://gerrit.wikimedia.org/r/365845 to review the following change. Change subject: Revert "Revert "Minerva is its own skin"" ..

[MediaWiki-commits] [Gerrit] integration/config[master]: test-skins should also run testsuite extensions

2017-07-17 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/365796 ) Change subject: test-skins should also run testsuite extensions .. test-skins should also run testsuite extensions Otherwise PHPUnit test

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Skins can have tests.. find and run them

2017-07-17 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/365722 ) Change subject: Skins can have tests.. find and run them .. Skins can have tests.. find and run them Change-Id: Ic04f4a842b2912574826b01b

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Enable page previews for everyone on labs

2017-07-17 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/365696 ) Change subject: Enable page previews for everyone on labs .. Enable page previews for everyone on labs Prior to deploying to most wikis,

[MediaWiki-commits] [Gerrit] mediawiki...MinervaNeue[wmf/1.30.0-wmf.9]: Temporarily remove broken test

2017-07-17 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/365686 ) Change subject: Temporarily remove broken test .. Temporarily remove broken test This test is causing T170624 which is now blocking the t

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[wmf/1.30.0-wmf.9]: Remove tests/phpunit/MenuBuilderTest.php

2017-07-17 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/365680 ) Change subject: Remove tests/phpunit/MenuBuilderTest.php .. Remove tests/phpunit/MenuBuilderTest.php This is duplicated in mediawiki/skin

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Remove tests/phpunit/MenuBuilderTest.php

2017-07-17 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/365679 ) Change subject: Remove tests/phpunit/MenuBuilderTest.php .. Remove tests/phpunit/MenuBuilderTest.php This is duplicated in mediawiki/skin

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Log all events for page previews in beta cluster

2017-07-17 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/365659 ) Change subject: Log all events for page previews in beta cluster .. Log all events for page previews in beta cluster This allows us to ve

[MediaWiki-commits] [Gerrit] mediawiki...RelatedArticles[wmf/1.30.0-wmf.9]: Add limit via ResourceLoaderGetConfigVars

2017-07-17 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/365647 ) Change subject: Add limit via ResourceLoaderGetConfigVars .. Add limit via ResourceLoaderGetConfigVars Using MakeGlobalVariablesScript ho

[MediaWiki-commits] [Gerrit] mediawiki...RelatedArticles[master]: Add limit via ResourceLoaderGetConfigVars

2017-07-14 Thread Jdlrobson (Code Review)
Jdlrobson has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/365420 ) Change subject: Add limit via ResourceLoaderGetConfigVars .. Add limit via ResourceLoaderGetConfigVars Using MakeGlobalVariablesS

[MediaWiki-commits] [Gerrit] mediawiki...RelatedArticles[master]: Hygiene: Remove unnecessary variable

2017-07-14 Thread Jdlrobson (Code Review)
Jdlrobson has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/365417 ) Change subject: Hygiene: Remove unnecessary variable .. Hygiene: Remove unnecessary variable Improves readability... Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...MinervaNeue[master]: Hygiene: Remove and update references to MobileFrontend

2017-07-14 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/365422 ) Change subject: Hygiene: Remove and update references to MobileFrontend .. Hygiene: Remove and update references to MobileFrontend Change

[MediaWiki-commits] [Gerrit] mediawiki...RelatedArticles[master]: Add limit via ResourceLoaderGetConfigVars

2017-07-14 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/365420 ) Change subject: Add limit via ResourceLoaderGetConfigVars .. Add limit via ResourceLoaderGetConfigVars Using MakeGlobalVariablesScript ho

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[wmf/1.30.0-wmf.9]: Revert "Revert "Fixups prior to Minerva/MobileFrontend separ...

2017-07-14 Thread Jdlrobson (Code Review)
Hello Thcipriani, Chad, Niedzielski, jenkins-bot, Siebrand, I'd like you to do a code review. Please visit https://gerrit.wikimedia.org/r/365418 to review the following change. Change subject: Revert "Revert "Fixups prior to Minerva/MobileFrontend separation"" ...

[MediaWiki-commits] [Gerrit] mediawiki...RelatedArticles[master]: Hygiene: Remove unnecessary variable

2017-07-14 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/365417 ) Change subject: Hygiene: Remove unnecessary variable .. Hygiene: Remove unnecessary variable Improves readability... Change-Id: Ib0e9cbc

[MediaWiki-commits] [Gerrit] mediawiki...mobileapps[master]: Refactor: rmElementsWithSelector transform is in its own file

2017-07-14 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/365277 ) Change subject: Refactor: rmElementsWithSelector transform is in its own file .. Refactor: rmElementsWithSelector transform is in its own

[MediaWiki-commits] [Gerrit] mediawiki...MinervaNeue[master]: Add tooling for svg size checking

2017-07-13 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/365193 ) Change subject: Add tooling for svg size checking .. Add tooling for svg size checking Bug: T170639 Change-Id: Ibcd5c29340d16c9cffc6e2eb9

[MediaWiki-commits] [Gerrit] mediawiki...mobileapps[master]: Refactor: DRY and document

2017-07-13 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/365192 ) Change subject: Refactor: DRY and document .. Refactor: DRY and document Pull repeated methods into their own private functions Change-I

[MediaWiki-commits] [Gerrit] mediawiki...mobileapps[master]: Refactor: Generalise hideRedLinks

2017-07-13 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/365191 ) Change subject: Refactor: Generalise hideRedLinks .. Refactor: Generalise hideRedLinks hideRedLinks can be generalised to flatten any kin

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[wmf/1.30.0-wmf.9]: Revert "Minerva is its own skin"

2017-07-13 Thread Jdlrobson (Code Review)
Hello Chad, Niedzielski, jenkins-bot, Siebrand, I'd like you to do a code review. Please visit https://gerrit.wikimedia.org/r/365176 to review the following change. Change subject: Revert "Minerva is its own skin" .. Rev

[MediaWiki-commits] [Gerrit] mediawiki...MinervaNeue[master]: Add missing Minerva skin description message key

2017-07-13 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/365162 ) Change subject: Add missing Minerva skin description message key .. Add missing Minerva skin description message key Change-Id: I61457e70

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[wmf/1.30.0-wmf.9]: Minerva is its own skin

2017-07-13 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/365122 ) Change subject: Minerva is its own skin .. Minerva is its own skin This patch is the programmatic output of Iff1f7e63e796cc5d4a6d2ab0370e

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[wmf/1.30.0-wmf.9]: Fixups prior to Minerva/MobileFrontend separation

2017-07-13 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/365110 ) Change subject: Fixups prior to Minerva/MobileFrontend separation .. Fixups prior to Minerva/MobileFrontend separation * Correct dependen

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[wmf/1.30.0-wmf.7]: Fixups prior to Minerva/MobileFrontend separation

2017-07-13 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/365108 ) Change subject: Fixups prior to Minerva/MobileFrontend separation .. Fixups prior to Minerva/MobileFrontend separation * Correct dependen

[MediaWiki-commits] [Gerrit] mediawiki...MinervaNeue[master]: QA: Fix a flakey test

2017-07-13 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/365059 ) Change subject: QA: Fix a flakey test .. QA: Fix a flakey test This copies the approach taken in I3161c64d68c09a9a8f7d00a27eddfbe37830fab

[MediaWiki-commits] [Gerrit] mediawiki...MinervaNeue[master]: Add tooling for documentation and svg size checking

2017-07-13 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/365046 ) Change subject: Add tooling for documentation and svg size checking .. Add tooling for documentation and svg size checking Change-Id: Idb

[MediaWiki-commits] [Gerrit] mediawiki...MinervaNeue[master]: minerva-neue valid skin name should not be necessary

2017-07-12 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/364930 ) Change subject: minerva-neue valid skin name should not be necessary .. minerva-neue valid skin name should not be necessary Change-Id: I

[MediaWiki-commits] [Gerrit] mediawiki...MinervaNeue[master]: Change message prefixes to minerva- from mobile-frontend-

2017-07-12 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/364928 ) Change subject: Change message prefixes to minerva- from mobile-frontend- .. Change message prefixes to minerva- from mobile-frontend- To

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Minerva is its own skin

2017-07-12 Thread Jdlrobson (Code Review)
Jdlrobson has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/362448 ) Change subject: Minerva is its own skin .. Minerva is its own skin This patch is the programmatic output of Iff1f7e63e796cc5d4a6d

[MediaWiki-commits] [Gerrit] mediawiki...mobileapps[master]: Strip any content in brackets

2017-07-12 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/364906 ) Change subject: Strip any content in brackets .. Strip any content in brackets Change-Id: Ib631008ba15a0cc1e22db1a38159279761c71873 --- M

[MediaWiki-commits] [Gerrit] mediawiki...mobileapps[master]: POC: Use mobile content service instead of TextExtracts to g...

2017-07-12 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/364896 ) Change subject: POC: Use mobile content service instead of TextExtracts to generate summaries .. POC: Use mobile content service instead

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Final fixups prior to Minerva/MobileFrontend separation

2017-07-11 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/364654 ) Change subject: Final fixups prior to Minerva/MobileFrontend separation .. Final fixups prior to Minerva/MobileFrontend separation * Corr

[MediaWiki-commits] [Gerrit] mediawiki...MinervaNeue[master]: Fixes to migrate script with regards to i18n

2017-07-11 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/364653 ) Change subject: Fixes to migrate script with regards to i18n .. Fixes to migrate script with regards to i18n * Make sure metadata field i

[MediaWiki-commits] [Gerrit] mediawiki...MinervaNeue[master]: Add .gitignore file

2017-07-11 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/364652 ) Change subject: Add .gitignore file .. Add .gitignore file Change-Id: Ie5112a5eef02fba9b70ef7483008b27090cc3f81 --- A .gitignore 1 file c

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: test push

2017-07-11 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/364626 ) Change subject: test push .. test push Change-Id: Ib4d8eed21f9acedb1ad2e87c2ce932230c2dda92 --- A test.txt 1 file changed, 1 insertion(+)

[MediaWiki-commits] [Gerrit] mediawiki...MinervaNeue[master]: QA: Add note about git history of browser tests in this repo

2017-07-11 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/364608 ) Change subject: QA: Add note about git history of browser tests in this repo .. QA: Add note about git history of browser tests in this re

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Attempt to fix flakey test

2017-07-10 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/364348 ) Change subject: Attempt to fix flakey test .. Attempt to fix flakey test Change-Id: I3161c64d68c09a9a8f7d00a27eddfbe37830fabd --- M tests

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Remove browser tests of features that now belong to Minerva

2017-07-10 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/364325 ) Change subject: Remove browser tests of features that now belong to Minerva .. Remove browser tests of features that now belong to Minerva

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Compress srlogo for Wikipedia

2017-07-10 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/364269 ) Change subject: Compress srlogo for Wikipedia .. Compress srlogo for Wikipedia Bug: T165896 Change-Id: I9fab0db6dbf52c1c9a453d24b93611c9e

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Stop disabling MFTidyMobileViewSections

2017-07-10 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/364264 ) Change subject: Stop disabling MFTidyMobileViewSections .. Stop disabling MFTidyMobileViewSections Bug: T168671 Change-Id: Ie648b126d386e

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Logo changes for various wiki projects

2017-07-10 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/364241 ) Change subject: Logo changes for various wiki projects .. Logo changes for various wiki projects * Update sr wordmark coloring * Use loca

[MediaWiki-commits] [Gerrit] mediawiki...EventLogging[master]: Only subscribe EventLogging once

2017-07-07 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/363957 ) Change subject: Only subscribe EventLogging once .. Only subscribe EventLogging once Do not subscribe again on subsequent load events Bu

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Wikivoyage projects can show more than 1 related article

2017-07-06 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/363742 ) Change subject: Wikivoyage projects can show more than 1 related article .. Wikivoyage projects can show more than 1 related article Bug:

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[wmf/1.30.0-wmf.7]: Only message box styles should be loaded on editor

2017-07-06 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/363741 ) Change subject: Only message box styles should be loaded on editor .. Only message box styles should be loaded on editor Bug: T164892 Cha

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: DONOTMERGE: Testing unicode sections

2017-07-06 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/363668 ) Change subject: DONOTMERGE: Testing unicode sections .. DONOTMERGE: Testing unicode sections Change-Id: Iad470a9aeecd8a5e96bd0f4107c23176

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Hygiene: Stop emitting global events that are not being used...

2017-07-06 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/363658 ) Change subject: Hygiene: Stop emitting global events that are not being used anywhere .. Hygiene: Stop emitting global events that are no

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Only message box styles should be loaded on editor

2017-07-06 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/363651 ) Change subject: Only message box styles should be loaded on editor .. Only message box styles should be loaded on editor Bug: T164892 Cha

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Minor modifications to core editing elements in non-js mode

2017-07-06 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/363643 ) Change subject: Minor modifications to core editing elements in non-js mode .. Minor modifications to core editing elements in non-js mode

[MediaWiki-commits] [Gerrit] mediawiki...MinervaNeue[master]: WIP: Merge MobileFrontend's starter modules

2017-07-05 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/363441 ) Change subject: WIP: Merge MobileFrontend's starter modules .. WIP: Merge MobileFrontend's starter modules Change-Id: Ieb8fdd576d76461000

[MediaWiki-commits] [Gerrit] mediawiki...TextExtracts[master]: WIP: more test cases

2017-07-03 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/363083 ) Change subject: WIP: more test cases .. WIP: more test cases Change-Id: I928299d5f008c37d3bc7d28ce226bf4f6be02bcc --- M includes/ExtractF

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Hygiene: Remove the micro.js folder

2017-07-03 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/363018 ) Change subject: Hygiene: Remove the micro.js folder .. Hygiene: Remove the micro.js folder Library is no longer used. Not needed. Change

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Hygiene: Remove the unused mobile.mixins file

2017-07-03 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/363016 ) Change subject: Hygiene: Remove the unused mobile.mixins file .. Hygiene: Remove the unused mobile.mixins file Change-Id: Icdd14ecccaa1ef

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Close edit overlay on save to retain sensible back button be...

2017-07-03 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/363012 ) Change subject: Close edit overlay on save to retain sensible back button behaviour .. Close edit overlay on save to retain sensible back

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Allow search suggestions in skins operating in mobile mode

2017-06-30 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/362534 ) Change subject: Allow search suggestions in skins operating in mobile mode .. Allow search suggestions in skins operating in mobile mode

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Wipe out default skin search modules

2017-06-30 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/362526 ) Change subject: Wipe out default skin search modules .. Wipe out default skin search modules Otherwise jquery.suggestions will be loaded

[MediaWiki-commits] [Gerrit] mediawiki...MinervaNeue[master]: Avoid using Minerva name until it has been removed from Mobi...

2017-06-30 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/362513 ) Change subject: Avoid using Minerva name until it has been removed from MobileFrontend .. Avoid using Minerva name until it has been remo

[MediaWiki-commits] [Gerrit] mediawiki...Timeless[master]: Make Timeless compatible with MobileFrontend

2017-06-30 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/362461 ) Change subject: Make Timeless compatible with MobileFrontend .. Make Timeless compatible with MobileFrontend I'm giving you some attentio

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: ResourceLoaderSkinModule should default to mobile and deskto...

2017-06-30 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/362459 ) Change subject: ResourceLoaderSkinModule should default to mobile and desktop target .. ResourceLoaderSkinModule should default to mobile

[MediaWiki-commits] [Gerrit] mediawiki...Vector[master]: Vector should operate in responsive mode when the mobile skin

2017-06-30 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/362456 ) Change subject: Vector should operate in responsive mode when the mobile skin .. Vector should operate in responsive mode when the mobile

[MediaWiki-commits] [Gerrit] mediawiki...MinervaNeue[master]: Give MinervaNeue control of the minerva skin name

2017-06-30 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/362451 ) Change subject: Give MinervaNeue control of the minerva skin name .. Give MinervaNeue control of the minerva skin name Change-Id: I7f004b

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Minerva is its own skin

2017-06-30 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/362448 ) Change subject: Minerva is its own skin .. Minerva is its own skin Change-Id: I985c4e3a88b59461d471945ccf74cd291db45a61 Depends-On: Iff1f

[MediaWiki-commits] [Gerrit] mediawiki...release[master]: Deploy MinervaNeue

2017-06-30 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/362447 ) Change subject: Deploy MinervaNeue .. Deploy MinervaNeue Bug: T166748 Change-Id: I77acaea1d7f3b4f172dc733cb2e01889cf6d9e73 --- M make-wmf

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Reflect production defaults

2017-06-29 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/362257 ) Change subject: Reflect production defaults .. Reflect production defaults This turns on first paragraph before infobox, lazy loading ima

[MediaWiki-commits] [Gerrit] mediawiki...TextExtracts[wmf/1.30.0-wmf.7]: Play things safe when stripping HTML

2017-06-29 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/362253 ) Change subject: Play things safe when stripping HTML .. Play things safe when stripping HTML Script and input tags if outputted by other

[MediaWiki-commits] [Gerrit] mediawiki...TextExtracts[master]: Play things safe when stripping HTML

2017-06-29 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/362252 ) Change subject: Play things safe when stripping HTML .. Play things safe when stripping HTML Script and input tags if outputted by other

[MediaWiki-commits] [Gerrit] mediawiki...QuickSurveys[master]: Implement platform-dependent surveys

2017-06-28 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/362073 ) Change subject: Implement platform-dependent surveys .. Implement platform-dependent surveys Our current configuration defines the allowe

[MediaWiki-commits] [Gerrit] mediawiki...Translate[master]: Collapse tvar tags in section preview

2017-06-28 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/361971 ) Change subject: Collapse tvar tags in section preview .. Collapse tvar tags in section preview Bug: T168743 Change-Id: I4a7a83cc6d2d3d0c5

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[wmf/1.30.0-wmf.7]: Revert "Run DiffViewHeader in mobile mode, too"

2017-06-28 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/361945 ) Change subject: Revert "Run DiffViewHeader in mobile mode, too" .. Revert "Run DiffViewHeader in mobile mode, too" This reverts commit 10

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[wmf/1.30.0-wmf.6]: Revert "Run DiffViewHeader in mobile mode, too"

2017-06-28 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/361944 ) Change subject: Revert "Run DiffViewHeader in mobile mode, too" .. Revert "Run DiffViewHeader in mobile mode, too" This reverts commit 10

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Revert "Run DiffViewHeader in mobile mode, too"

2017-06-28 Thread Jdlrobson (Code Review)
Hello Florianschmidtwelzow, jenkins-bot, I'd like you to do a code review. Please visit https://gerrit.wikimedia.org/r/361943 to review the following change. Change subject: Revert "Run DiffViewHeader in mobile mode, too" ...

<    1   2   3   4   5   6   7   8   9   10   >