Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/382880 )
Change subject: Avoid notices on large articles
..
Avoid notices on large articles
Articles which have more than 500 contributors or 500
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/382854 )
Change subject: DONOTMERGE: check if tests are running
..
DONOTMERGE: check if tests are running
Change-Id:
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/382851 )
Change subject: Add PHPUnit groups for unit tests
..
Add PHPUnit groups for unit tests
Change-Id:
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/382752 )
Change subject: WIP: Prepare to have one single template and simplify rendering
..
WIP: Prepare to have one single template and simplify
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/382331 )
Change subject: Hygiene: Extract additional methods from renderCoverAndToc
..
Hygiene: Extract additional methods from renderCoverAndToc
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/382332 )
Change subject: Hygiene: renderCoverAndToc contains no logic
..
Hygiene: renderCoverAndToc contains no logic
Change-Id:
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/382323 )
Change subject: Hygiene: Make render functions dumber
..
Hygiene: Make render functions dumber
Change-Id:
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/382324 )
Change subject: WIP: Refactor non-render logic out of render.
..
WIP: Refactor non-render logic out of render.
Change-Id:
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/382238 )
Change subject: Correct feature phone threshold detection
..
Correct feature phone threshold detection
max-width should actually be one
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/381899 )
Change subject: Delete unimplemented browser tests
..
Delete unimplemented browser tests
These browser tests were added in
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/381892 )
Change subject: Stop using wgNamespace and wgTitle globals
..
Stop using wgNamespace and wgTitle globals
it's still using globals and I
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/381886 )
Change subject: WIP: Render book in one master template
..
WIP: Render book in one master template
This replaces all the templates with
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/381291 )
Change subject: Provide message/warning/error box abstraction
..
Provide message/warning/error box abstraction
This will help us
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/381315 )
Change subject: Render add discussion button in PHP not JS
..
Render add discussion button in PHP not JS
The talk page JavaScript
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/381281 )
Change subject: Update SVGs for page actions
..
Update SVGs for page actions
Additional changes:
* userNormal was not minified. This has
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/381259 )
Change subject: Revision::newFromTitle may return null
..
Revision::newFromTitle may return null
Bug: T176882
Change-Id:
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/381258 )
Change subject: Revision::newFromTitle may return null
..
Revision::newFromTitle may return null
Bug: T176882
Change-Id:
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/381222 )
Change subject: Restore feature phone threshold to 280px
..
Restore feature phone threshold to 280px
Also rename to
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/381098 )
Change subject: Load tablet device code on mobile devices
..
Load tablet device code on mobile devices
There is little benefit from
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/381071 )
Change subject: Revision::newFromTitle may return null
..
Revision::newFromTitle may return null
Bug: T176882
Change-Id:
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/381027 )
Change subject: Hygiene: Merge selectors for removal in summarize
..
Hygiene: Merge selectors for removal in summarize
Change-Id:
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/380856 )
Change subject: Redirects return 204 inside MCS
..
Redirects return 204 inside MCS
These will be handled upstream in RestBase.
To avoid
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/380811 )
Change subject: i18n: Wording nitpicks
..
i18n: Wording nitpicks
Improved wording for translators and for readability of browser tests
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/380743 )
Change subject: Only hide fmbox on editor interface
..
Only hide fmbox on editor interface
They also show up on pages that do not exist.
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/380581 )
Change subject: Hygiene: Break out removeAttributes transformation
..
Hygiene: Break out removeAttributes transformation
Allow this to
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/380554 )
Change subject: Disable RelatedArticles instrumentation on all wikis
..
Disable RelatedArticles instrumentation on all wikis
Bug:
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/380520 )
Change subject: Don't run diff test on beta cluster
..
Don't run diff test on beta cluster
While T176637 is open we should only run
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/380513 )
Change subject: QA: User edit cta browser test should not run on beta cluster
..
QA: User edit cta browser test should not run on beta
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/380505 )
Change subject: API edits should use the Selenium user
..
API edits should use the Selenium user
Otherwise every single test which uses
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/379936 )
Change subject: Fix definition of lead introduction
..
Fix definition of lead introduction
Bug: T176522
Change-Id:
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/379930 )
Change subject: WIP: Improve parenthetical handling
..
WIP: Improve parenthetical handling
New test case shows current logic can be
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/379902 )
Change subject: Test case for T176521
..
Test case for T176521
Bug: T176521
Change-Id: Ifd0c47114973fd7c1cc1c2231a52947b5dfcbe34
---
M
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/379852 )
Change subject: Strip any .reference elements
..
Strip any .reference elements
Bug: T176519
Change-Id:
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/379783 )
Change subject: Third party main page logic is incorrect
..
Third party main page logic is incorrect
On a wiki where special casing of
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/376782 )
Change subject: Avoid undefined notices when obtaining collection
..
Avoid undefined notices when obtaining collection
Instead of
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/376754 )
Change subject: Hygiene: Drop unused disableImages property
..
Hygiene: Drop unused disableImages property
Change-Id:
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/376581 )
Change subject: Allow extensions to override the print url
..
Allow extensions to override the print url
Example usage:
Checkout
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/376580 )
Change subject: Refactor ShortUrl to allow it to be used in printed version
..
Refactor ShortUrl to allow it to be used in printed
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/376557 )
Change subject: Load mobile.init module for all mobile skins
..
Load mobile.init module for all mobile skins
Bug: T173454
Depends-On:
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/376553 )
Change subject: Hygiene: M.getCurrentPage and skin should be initialised by
MobileFrontend
..
Hygiene: M.getCurrentPage and skin should
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/376554 )
Change subject: Hygiene: Do not pass mainMenu to Skin
..
Hygiene: Do not pass mainMenu to Skin
This wires the interaction between the
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/376555 )
Change subject: Hygiene: Minerva uses skin instance defined by MobileFrontend
..
Hygiene: Minerva uses skin instance defined by
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/376551 )
Change subject: Hygiene: Remove MainMenu usage inside Skin
..
Hygiene: Remove MainMenu usage inside Skin
Change-Id:
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/376550 )
Change subject: Hygiene: Begin deprecation of Skin mainMenu option
..
Hygiene: Begin deprecation of Skin mainMenu option
These are
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/376546 )
Change subject: Hygiene: Cleanup initialisation files
..
Hygiene: Cleanup initialisation files
* Remove deprecated module definitions
*
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/376543 )
Change subject: Do not use deprecated fallback handling for
History/Contributions
..
Do not use deprecated fallback handling for
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/376523 )
Change subject: OMG I am using const!
..
OMG I am using const!
Change-Id: Ief8967e2efb1d8319608b078d42e905e5b4b902c
---
M
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/376323 )
Change subject: Update banner message
..
Update banner message
Bug: T174147
Change-Id: Ie798a7363de0d58c2b8e880a90e4ff8e5a015b51
---
M
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/376282 )
Change subject: Hide last modified bar on old revisions
..
Hide last modified bar on old revisions
Bug: T153125
Change-Id:
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/376281 )
Change subject: Hygiene: Refactor SkinMinerva so it doesn't use MobilePage
..
Hygiene: Refactor SkinMinerva so it doesn't use MobilePage
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/376266 )
Change subject: Do not allow certain content to span entire page
..
Do not allow certain content to span entire page
Certain elements
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/376261 )
Change subject: Improve hatnote styling
..
Improve hatnote styling
This improves the hatnote styling on pages such as Iran.
Bug:
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/376141 )
Change subject: Show border of editor in Minerva edit mode
..
Show border of editor in Minerva edit mode
Bug: T174158
Change-Id:
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/376135 )
Change subject: EventLogging modules should be soft dependencies
..
EventLogging modules should be soft dependencies
Change-Id:
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/376100 )
Change subject: Run eslint on compiled assets to ensure code is es5 compatible
..
Run eslint on compiled assets to ensure code is es5
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/376083 )
Change subject: mediawiki.experiments is a dependency of RelatedArticles
..
mediawiki.experiments is a dependency of RelatedArticles
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/375398 )
Change subject: Adjust language icon color
..
Adjust language icon color
The hex code for the fill color was wrong resulting in it
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/375395 )
Change subject: Adjust language icon color
..
Adjust language icon color
icons.
Bug: T174747
Change-Id:
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/375390 )
Change subject: Make RelatedArticles tests QUnit 2 compatible
..
Make RelatedArticles tests QUnit 2 compatible
Bug: T174598
Change-Id:
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/375384 )
Change subject: WIP: Port Popups browser tests to selenium
..
WIP: Port Popups browser tests to selenium
Bug: T160238
Change-Id:
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/375377 )
Change subject: Add a Jenkins job for Popups browser tests
..
Add a Jenkins job for Popups browser tests
Bug: T174786
Change-Id:
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/375366 )
Change subject: ls
..
ls
Change-Id: I599c8c002c570d4911b7c86294f714279833e80b
---
M tests/browser/LocalSettings.php
1 file changed, 1
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/375075 )
Change subject: Hygiene: Refactor execute function
..
Hygiene: Refactor execute function
Trying to make sense of all the commands - the
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/375070 )
Change subject: Hygiene: Book creator HTML is created via template
..
Hygiene: Book creator HTML is created via template
This is the
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/375068 )
Change subject: Hygiene: Reorganise the ResourceLoader modules
..
Hygiene: Reorganise the ResourceLoader modules
* Organise files by
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/375056 )
Change subject: Parenthetical stripping should not be greedy
..
Parenthetical stripping should not be greedy
Bug: T174698
Change-Id:
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/375028 )
Change subject: Fix watchstar icon
..
Fix watchstar icon
xml tag was not correctly closed with "?>"
Bug: T174607
Change-Id:
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/374992 )
Change subject: Make Minerva QUnit tests v2 compatible
..
Make Minerva QUnit tests v2 compatible
Drop the checks for number of
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/374908 )
Change subject: QUnit: Drop assertions for expected number of tests
..
QUnit: Drop assertions for expected number of tests
Drop
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/374842 )
Change subject: Hygiene: Use ES5 methods
..
Hygiene: Use ES5 methods
* Use Array.isArray instead of $.isArray
Change-Id:
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/374637 )
Change subject: Refactor: Use mustache templates to create download box
..
Refactor: Use mustache templates to create download box
The
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/374617 )
Change subject: MobileFrontend shouldn't be medling with preferences on behalf
of Minerva
..
MobileFrontend shouldn't be medling with
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/374582 )
Change subject: Remove ES6 usages in Popups distribution js
..
Remove ES6 usages in Popups distribution js
Bug: T174424
This merges:
*
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/374421 )
Change subject: Enable mediawiki.hlist on mobile
..
Enable mediawiki.hlist on mobile
Bug: T42062
Change-Id:
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/374418 )
Change subject: Hygiene: Merge skins.minerva.print.styles with
skins.minerva.base.styles
..
Hygiene: Merge skins.minerva.print.styles
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/374417 )
Change subject: Hygiene: Remove FIXMEs now enough time has passed
..
Hygiene: Remove FIXMEs now enough time has passed
Routine
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/374414 )
Change subject: Switch to @colorGray5 for wikitable borders
..
Switch to @colorGray5 for wikitable borders
Bug: T168029
Change-Id:
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/374412 )
Change subject: Show CTA at bottom of anonymous editor warning
..
Show CTA at bottom of anonymous editor warning
Bug: T164628
Change-Id:
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/374408 )
Change subject: Add spacing to anonymous editing message
..
Add spacing to anonymous editing message
(Call to action will be added in a
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/374405 )
Change subject: Drop Android2 check for search
..
Drop Android2 check for search
Android2 is a grade C browser so this code will never
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/374404 )
Change subject: Hygiene: Remove checks for Android2
..
Hygiene: Remove checks for Android2
Android2 is now a grade C browser, so we
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/374390 )
Change subject: Enable Popups on en and de wiki for A/B test
..
Enable Popups on en and de wiki for A/B test
Bug: T172291
Change-Id:
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/374378 )
Change subject: Add missing wg Prefix
..
Add missing wg Prefix
Follow up to:
Ia43bd4868e9e3a9fae97088a53a7f56bd1bc0078
Change-Id:
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/374333 )
Change subject: Logout icon should not be small
..
Logout icon should not be small
Bug: T170362
Change-Id:
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/374330 )
Change subject: fmboxes should be treated the same as ambox and tmboxes
..
fmboxes should be treated the same as ambox and tmboxes
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/373962 )
Change subject: Use Function.bind in favor of $.proxy
..
Use Function.bind in favor of $.proxy
\$\.proxy\( ([^\,]*)\, \'([^\)\,\']*)\'?
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/373963 )
Change subject: Control use of $.Deferred
..
Control use of $.Deferred
Avoid using $.Deferred unless truly necessary.
We have a tendency
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/373920 )
Change subject: Enable an A/B test for page previews on EN and DE wikis
..
Enable an A/B test for page previews on EN and DE wikis
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/373916 )
Change subject: Hide last modified text in footer
..
Hide last modified text in footer
This repeats information in the last modified BAR
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/373914 )
Change subject: Do not try to enable toggling if using desktop Minerva
..
Do not try to enable toggling if using desktop Minerva
There
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/373910 )
Change subject: Collapse amboxes in edit view
..
Collapse amboxes in edit view
In edit mode various amboxes are shown which push the
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/373623 )
Change subject: Caption should inherit background from table
..
Caption should inherit background from table
Since we are fiddling with
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/373614 )
Change subject: Lighten table border color
..
Lighten table border color
Bug: T168029
Change-Id:
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/373560 )
Change subject: Tests
..
Tests
Change-Id: I00425b4b60c2567706cbd1b1de36cb8e0db7000d
---
M
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/373372 )
Change subject: Avoid global access of elements outside Views
..
Avoid global access of elements outside Views
PointerOverlay,
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/373364 )
Change subject: Hygiene: Drop usages of inArray
..
Hygiene: Drop usages of inArray
We can guarantee ES5 support so we can guarantee
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/373361 )
Change subject: Prepare for adoption of mw-ui-icon-large on user page
..
Prepare for adoption of mw-ui-icon-large on user page
When
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/373362 )
Change subject: Use mw-ui-icon-large and ResourceLoaderImage module for user
page
..
Use mw-ui-icon-large and ResourceLoaderImage module
Hello Urbanecm, Niharika29, Florianschmidtwelzow, Jhernandez, jenkins-bot,
Phuedx,
I'd like you to do a code review. Please visit
https://gerrit.wikimedia.org/r/373353
to review the following change.
Change subject: Revert "Revert "pagePreviews: Enable A/B test (BC-only)""
Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/373315 )
Change subject: Set line height to 1 for sup and sub elements
..
Set line height to 1 for sup and sub elements
Bug: T172501
Change-Id:
201 - 300 of 5253 matches
Mail list logo
