[MediaWiki-commits] [Gerrit] mediawiki...mobileapps[master]: Remove jscs in preparation for node template update

2016-11-29 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. https://gerrit.wikimedia.org/r/324266 Change subject: Remove jscs in preparation for node template update .. Remove jscs in preparation for node template update The new node

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Support inline `.hlists` for editors to avoid FOUC

2016-11-28 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. https://gerrit.wikimedia.org/r/324002 Change subject: Support inline `.hlists` for editors to avoid FOUC .. Support inline `.hlists` for editors to avoid FOUC Bug: T131423

[MediaWiki-commits] [Gerrit] mediawiki...PageImages[master]: Restrict page images to lead section

2016-11-28 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. https://gerrit.wikimedia.org/r/323989 Change subject: Restrict page images to lead section .. Restrict page images to lead section When $wgPageImagesLeadSectionOnly is true

[MediaWiki-commits] [Gerrit] mediawiki...trending-edits[master]: Track newly created pages

2016-11-28 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. https://gerrit.wikimedia.org/r/323897 Change subject: Track newly created pages .. Track newly created pages Bug: T145554 Change-Id: If71d673ac24fb229798d2c697f45b2e1deaf11cd

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Disable Popups A/B test on Russian and Italian Wikipedias

2016-11-28 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. https://gerrit.wikimedia.org/r/323878 Change subject: Disable Popups A/B test on Russian and Italian Wikipedias .. Disable Popups A/B test on Russian and Italian Wikipedias

[MediaWiki-commits] [Gerrit] mediawiki...trending-edits[master]: Edit stream should replay edits up to the maximum age

2016-11-24 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. https://gerrit.wikimedia.org/r/323490 Change subject: Edit stream should replay edits up to the maximum age .. Edit stream should replay edits up to the maximum age Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...trending-edits[master]: Use Map for storing trending information

2016-11-24 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. https://gerrit.wikimedia.org/r/323489 Change subject: Use Map for storing trending information .. Use Map for storing trending information It's better suited to this job.

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Overlay content should have white background

2016-11-23 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. https://gerrit.wikimedia.org/r/323346 Change subject: Overlay content should have white background .. Overlay content should have white background It is currently transparent

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: EditWatchlist should always show 'List' as active

2016-11-23 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. https://gerrit.wikimedia.org/r/323338 Change subject: EditWatchlist should always show 'List' as active .. EditWatchlist should always show 'List' as active Bug: T150650

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Fix empty watchlist views

2016-11-23 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. https://gerrit.wikimedia.org/r/323337 Change subject: Fix empty watchlist views .. Fix empty watchlist views A MobileCollection should be Countable Additional changes: * Add

[MediaWiki-commits] [Gerrit] mediawiki...trending-edits[master]: Record bytes change

2016-11-23 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. https://gerrit.wikimedia.org/r/323324 Change subject: Record bytes change .. Record bytes change Note the bytes changed by the first revision are not available and since we

[MediaWiki-commits] [Gerrit] mediawiki...trending-edits[master]: WIP: Implement a configurable purge strategy

2016-11-23 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. https://gerrit.wikimedia.org/r/323239 Change subject: WIP: Implement a configurable purge strategy .. WIP: Implement a configurable purge strategy To avoid taking up too much

[MediaWiki-commits] [Gerrit] mediawiki...trending-edits[master]: Use datacenter1 in development config for compatibility with...

2016-11-23 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. https://gerrit.wikimedia.org/r/323238 Change subject: Use datacenter1 in development config for compatibility with Vagrant .. Use datacenter1 in development config for

[MediaWiki-commits] [Gerrit] mediawiki...trending-edits[master]: Process move and delete events

2016-11-23 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. https://gerrit.wikimedia.org/r/323196 Change subject: Process move and delete events .. Process move and delete events Follow up to Ia711f3290e7331f4b9252289d964fa69d437e71e

[MediaWiki-commits] [Gerrit] mediawiki...trending-edits[master]: Process contributor information and how biased editing is

2016-11-22 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. https://gerrit.wikimedia.org/r/323072 Change subject: Process contributor information and how biased editing is .. Process contributor information and how biased editing is A

[MediaWiki-commits] [Gerrit] mediawiki...trending-edits[master]: Describe behaviour when pages are moved

2016-11-22 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. https://gerrit.wikimedia.org/r/323042 Change subject: Describe behaviour when pages are moved .. Describe behaviour when pages are moved Bug: T145554 Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...trending-edits[master]: Exclude bots from edit count

2016-11-21 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. https://gerrit.wikimedia.org/r/322787 Change subject: Exclude bots from edit count .. Exclude bots from edit count Bug: T145554 Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...trending-edits[master]: Ignore articles outside the main namespace

2016-11-21 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. https://gerrit.wikimedia.org/r/322784 Change subject: Ignore articles outside the main namespace .. Ignore articles outside the main namespace Bug: T145554 Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...PageImages[master]: Lint PHP code

2016-11-21 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. https://gerrit.wikimedia.org/r/322773 Change subject: Lint PHP code .. Lint PHP code Change-Id: I494b01d1396bec17d2323d585f8594123d3e574b --- M includes/ApiQueryPageImages.php

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Hygiene: Generate user page talk icon via ResourceLoaderImag...

2016-11-21 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. https://gerrit.wikimedia.org/r/322710 Change subject: Hygiene: Generate user page talk icon via ResourceLoaderImage module .. Hygiene: Generate user page talk icon via

[MediaWiki-commits] [Gerrit] mediawiki...mobileapps[master]: Main page should not have an info property

2016-11-18 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. https://gerrit.wikimedia.org/r/322287 Change subject: Main page should not have an info property .. Main page should not have an info property Doing this can disrupt the

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Limit ios header hack to older versions

2016-11-17 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. https://gerrit.wikimedia.org/r/322117 Change subject: Limit ios header hack to older versions .. Limit ios header hack to older versions This hack appears to be breaking newer

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Scope talk styles to talk overlay

2016-11-17 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. https://gerrit.wikimedia.org/r/322112 Change subject: Scope talk styles to talk overlay .. Scope talk styles to talk overlay Currently the talk styles can influence the styles

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Avoid a flash of unstyled content on most tablet devices

2016-11-17 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. https://gerrit.wikimedia.org/r/322081 Change subject: Avoid a flash of unstyled content on most tablet devices .. Avoid a flash of unstyled content on most tablet devices To

[MediaWiki-commits] [Gerrit] mediawiki...PageImages[master]: Fix test stubbing

2016-11-16 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. https://gerrit.wikimedia.org/r/321863 Change subject: Fix test stubbing .. Fix test stubbing * Mock the class we're testing * Only stub fetchFileMetadata method * The stub's

[MediaWiki-commits] [Gerrit] mediawiki...trending-edits[master]: WIP: Fix swagger file

2016-11-15 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. https://gerrit.wikimedia.org/r/321646 Change subject: WIP: Fix swagger file .. WIP: Fix swagger file Change-Id: I7f816deacdf3ab81becfae99b178c565e067 --- M spec.yaml 1 file

[MediaWiki-commits] [Gerrit] mediawiki...trending-edits[master]: Enforce coding conventions using jscs

2016-11-10 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. https://gerrit.wikimedia.org/r/320802 Change subject: Enforce coding conventions using jscs .. Enforce coding conventions using jscs Life is too short to worry about coding

[MediaWiki-commits] [Gerrit] mediawiki...trending-edits[master]: Fix test broken by I522bc288a665b9a238fbe9757a2190cef3c58d90

2016-11-10 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. https://gerrit.wikimedia.org/r/320755 Change subject: Fix test broken by I522bc288a665b9a238fbe9757a2190cef3c58d90 .. Fix test broken by

[MediaWiki-commits] [Gerrit] mediawiki...trending-edits[master]: Update config.yaml files

2016-11-10 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. https://gerrit.wikimedia.org/r/320754 Change subject: Update config.yaml files .. Update config.yaml files Bug: T145662 Change-Id: I603ead22374d99c157277179195b0007d900d19c ---

[MediaWiki-commits] [Gerrit] mediawiki...trending-edits[master]: WIP: Surface edits via kafka

2016-11-09 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. https://gerrit.wikimedia.org/r/320628 Change subject: WIP: Surface edits via kafka .. WIP: Surface edits via kafka Bug: T145553 Change-Id:

[MediaWiki-commits] [Gerrit] integration/config[master]: Add CI to trending-edits repo

2016-11-08 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. https://gerrit.wikimedia.org/r/320366 Change subject: Add CI to trending-edits repo .. Add CI to trending-edits repo Bug: T149601 Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...trending-edits[master]: Restore info test

2016-11-08 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. https://gerrit.wikimedia.org/r/320365 Change subject: Restore info test .. Restore info test @Mobrovac says this is not an example so I've restored it. I've captured my

[MediaWiki-commits] [Gerrit] mediawiki...trending-edits[master]: Rename routes/v1.js

2016-11-04 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. https://gerrit.wikimedia.org/r/319867 Change subject: Rename routes/v1.js .. Rename routes/v1.js Change-Id: I40700faba836a03aa809c3554a1f26c8074eb47a --- R

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Squash if necessary: Move inline script to skin hook

2016-11-04 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. https://gerrit.wikimedia.org/r/319856 Change subject: Squash if necessary: Move inline script to skin hook .. Squash if necessary: Move inline script to skin hook Rather than

[MediaWiki-commits] [Gerrit] mediawiki...trending-edits[master]: Updates to package.json

2016-11-04 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. https://gerrit.wikimedia.org/r/319833 Change subject: Updates to package.json .. Updates to package.json * Remove fields that are not needed until deployment and non-essential

[MediaWiki-commits] [Gerrit] mediawiki...trending-edits[master]: Use standardised HTTPError

2016-11-04 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. https://gerrit.wikimedia.org/r/319830 Change subject: Use standardised HTTPError .. Use standardised HTTPError Change-Id: I522bc288a665b9a238fbe9757a2190cef3c58d90 --- M

[MediaWiki-commits] [Gerrit] mediawiki...trending-edits[master]: Trending edits should live under feed

2016-11-04 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. https://gerrit.wikimedia.org/r/319826 Change subject: Trending edits should live under feed .. Trending edits should live under feed * Correct naming of endpoint * Update

[MediaWiki-commits] [Gerrit] mediawiki...trending-edits[master]: Assert contents of body in spec

2016-11-04 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. https://gerrit.wikimedia.org/r/319827 Change subject: Assert contents of body in spec .. Assert contents of body in spec Change-Id: I5ce9bfc0cf693c98f470770d4c37a39237ededc5

[MediaWiki-commits] [Gerrit] mediawiki...trending-edits[master]: Rename spec.template.yaml to spec.yaml

2016-11-04 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. https://gerrit.wikimedia.org/r/319828 Change subject: Rename spec.template.yaml to spec.yaml .. Rename spec.template.yaml to spec.yaml Artifact from service template no longer

[MediaWiki-commits] [Gerrit] mediawiki...Popups[master]: Revert "Fix tooltip interactions"

2016-11-03 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. https://gerrit.wikimedia.org/r/319623 Change subject: Revert "Fix tooltip interactions" .. Revert "Fix tooltip interactions" There is one reference to removeTooltips in

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Collapse sections by default

2016-11-01 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. https://gerrit.wikimedia.org/r/319067 Change subject: Collapse sections by default .. Collapse sections by default A global function mfTempOpenSection is added to the top of

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Hygiene: Make use of makeSectionHtml helper

2016-11-01 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. https://gerrit.wikimedia.org/r/319065 Change subject: Hygiene: Make use of makeSectionHtml helper .. Hygiene: Make use of makeSectionHtml helper Preparation for changes to

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Section blocks should have id attribute

2016-11-01 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. https://gerrit.wikimedia.org/r/319066 Change subject: Section blocks should have id attribute .. Section blocks should have id attribute An id attribute allows JavaScript to

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Hygiene: Tests should make use of helpers

2016-11-01 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. https://gerrit.wikimedia.org/r/319056 Change subject: Hygiene: Tests should make use of helpers .. Hygiene: Tests should make use of helpers In preparation for altering the

[MediaWiki-commits] [Gerrit] mediawiki...trending-edits[master]: Setup trending edit placeholder route

2016-10-28 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. https://gerrit.wikimedia.org/r/318507 Change subject: Setup trending edit placeholder route .. Setup trending edit placeholder route This adds a route:

[MediaWiki-commits] [Gerrit] mediawiki...Popups[master]: Hygiene: Simplify removeTooltip and restoreTooltip test

2016-10-27 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. https://gerrit.wikimedia.org/r/318277 Change subject: Hygiene: Simplify removeTooltip and restoreTooltip test .. Hygiene: Simplify removeTooltip and restoreTooltip test I'm not

[MediaWiki-commits] [Gerrit] mediawiki...Popups[master]: Hygiene: Rename getMassagedData to processHovercardEvent

2016-10-27 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. https://gerrit.wikimedia.org/r/318270 Change subject: Hygiene: Rename getMassagedData to processHovercardEvent .. Hygiene: Rename getMassagedData to processHovercardEvent This

[MediaWiki-commits] [Gerrit] mediawiki...Popups[master]: linkInteractionToken is managed by getMassagedData

2016-10-26 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. https://gerrit.wikimedia.org/r/318137 Change subject: linkInteractionToken is managed by getMassagedData .. linkInteractionToken is managed by getMassagedData Rather than

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Cleanup unused config variables

2016-10-25 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. https://gerrit.wikimedia.org/r/317868 Change subject: Cleanup unused config variables .. Cleanup unused config variables Bug: T148853 Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Clear content to avoid user page float issues

2016-10-24 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. https://gerrit.wikimedia.org/r/317738 Change subject: Clear content to avoid user page float issues .. Clear content to avoid user page float issues Post content container

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: QA: Search overlay gives false positives

2016-10-24 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. https://gerrit.wikimedia.org/r/317725 Change subject: QA: Search overlay gives false positives .. QA: Search overlay gives false positives Scenario "Closing search (overlay

[MediaWiki-commits] [Gerrit] mediawiki...Popups[master]: Event and hover events are logged but not recorded

2016-10-24 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. https://gerrit.wikimedia.org/r/317713 Change subject: Event and hover events are logged but not recorded .. Event and hover events are logged but not recorded This adds two new

[MediaWiki-commits] [Gerrit] mediawiki...Popups[master]: Hygiene: Move logic for duplicate events into getMassagedData

2016-10-24 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. https://gerrit.wikimedia.org/r/317670 Change subject: Hygiene: Move logic for duplicate events into getMassagedData .. Hygiene: Move logic for duplicate events into

[MediaWiki-commits] [Gerrit] mediawiki...Popups[master]: Tests: Test existing behaviour for getMassagedData

2016-10-24 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. https://gerrit.wikimedia.org/r/317563 Change subject: Tests: Test existing behaviour for getMassagedData .. Tests: Test existing behaviour for getMassagedData Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...Popups[master]: Hygiene: Rename track topic to be more consistent with new p...

2016-10-20 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. https://gerrit.wikimedia.org/r/316984 Change subject: Hygiene: Rename track topic to be more consistent with new plans .. Hygiene: Rename track topic to be more consistent with

[MediaWiki-commits] [Gerrit] mediawiki...Popups[master]: Hygiene: Remove dead code

2016-10-19 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. https://gerrit.wikimedia.org/r/316848 Change subject: Hygiene: Remove dead code .. Hygiene: Remove dead code Since DWELL_EVENTS_MIN_INTERACTION_TIME is always zero the check

[MediaWiki-commits] [Gerrit] mediawiki...Popups[master]: ext.popups.schemaPopups now manages logic of whether to log ...

2016-10-17 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. https://gerrit.wikimedia.org/r/316480 Change subject: ext.popups.schemaPopups now manages logic of whether to log an event .. ext.popups.schemaPopups now manages logic of

[MediaWiki-commits] [Gerrit] mediawiki...Popups[master]: Multiple hover events should not clear dwellStartTime

2016-10-17 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. https://gerrit.wikimedia.org/r/316481 Change subject: Multiple hover events should not clear dwellStartTime .. Multiple hover events should not clear dwellStartTime If a user

[MediaWiki-commits] [Gerrit] mediawiki...Popups[master]: Event and hover events are logged but not recorded

2016-10-17 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. https://gerrit.wikimedia.org/r/316479 Change subject: Event and hover events are logged but not recorded .. Event and hover events are logged but not recorded This adds two new

[MediaWiki-commits] [Gerrit] mediawiki...Popups[master]: Directory structure should reflect the ResourceLoader defini...

2016-10-17 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. https://gerrit.wikimedia.org/r/316415 Change subject: Directory structure should reflect the ResourceLoader definitions .. Directory structure should reflect the ResourceLoader

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: QA: Search.feature browser test gives false positives

2016-10-17 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. https://gerrit.wikimedia.org/r/316393 Change subject: QA: Search.feature browser test gives false positives .. QA: Search.feature browser test gives false positives * The

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: QA: Ensure JavaScript has loaded before running references a...

2016-10-14 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. https://gerrit.wikimedia.org/r/316020 Change subject: QA: Ensure JavaScript has loaded before running references and search tests .. QA: Ensure JavaScript has loaded before

[MediaWiki-commits] [Gerrit] mediawiki...Popups[master]: WIP: Add `hover` and `displayed` events

2016-10-13 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. https://gerrit.wikimedia.org/r/315862 Change subject: WIP: Add `hover` and `displayed` events .. WIP: Add `hover` and `displayed` events Although we don't log them on the

[MediaWiki-commits] [Gerrit] mediawiki...Popups[master]: Hygiene: Pull out event handler for display of Hovercards

2016-10-13 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. https://gerrit.wikimedia.org/r/315857 Change subject: Hygiene: Pull out event handler for display of Hovercards .. Hygiene: Pull out event handler for display of Hovercards *

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Enable APISandbox code on mobile

2016-10-13 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. https://gerrit.wikimedia.org/r/315698 Change subject: Enable APISandbox code on mobile .. Enable APISandbox code on mobile It's a special page and only uses mobile vetted code

[MediaWiki-commits] [Gerrit] mediawiki...Popups[master]: Move logic for dwelledButAbandoned to central log method

2016-10-12 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. https://gerrit.wikimedia.org/r/315610 Change subject: Move logic for dwelledButAbandoned to central log method .. Move logic for dwelledButAbandoned to central log method Add

[MediaWiki-commits] [Gerrit] mediawiki...Popups[master]: Wait and reset do not need to be exposed globally

2016-10-12 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. https://gerrit.wikimedia.org/r/315585 Change subject: Wait and reset do not need to be exposed globally .. Wait and reset do not need to be exposed globally Bug: T147306

[MediaWiki-commits] [Gerrit] mediawiki...Popups[master]: Log events in one central place

2016-10-12 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. https://gerrit.wikimedia.org/r/315583 Change subject: Log events in one central place .. Log events in one central place We calculate totalInteractionTime in every single log

[MediaWiki-commits] [Gerrit] mediawiki...Popups[master]: Event handlers should not be exposed globally

2016-10-12 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. https://gerrit.wikimedia.org/r/315582 Change subject: Event handlers should not be exposed globally .. Event handlers should not be exposed globally Bug: T147306 Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Avoid margin collapsing

2016-10-12 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. https://gerrit.wikimedia.org/r/315565 Change subject: Avoid margin collapsing .. Avoid margin collapsing Also remove inert css rule around border top color. Bug: T147956

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Remove dead code in SkinMinervaBeta

2016-10-12 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. https://gerrit.wikimedia.org/r/315540 Change subject: Remove dead code in SkinMinervaBeta .. Remove dead code in SkinMinervaBeta All this code is unnecessary. The styles it

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Load skins.minerva.icons.images.variants in stable

2016-10-12 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. https://gerrit.wikimedia.org/r/315541 Change subject: Load skins.minerva.icons.images.variants in stable .. Load skins.minerva.icons.images.variants in stable * Chevrons uses

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Always remember your wg prefix

2016-10-11 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. https://gerrit.wikimedia.org/r/315450 Change subject: Always remember your wg prefix .. Always remember your wg prefix If not things won't work how you want them to...

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: @phuedx: One possible fix

2016-10-11 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. https://gerrit.wikimedia.org/r/315437 Change subject: @phuedx: One possible fix .. @phuedx: One possible fix Change-Id: Ie7f20ea0a89d2ab8e1510a4662132fe244c9fd66 --- M

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: All View's can now call toHtmlString

2016-10-11 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. https://gerrit.wikimedia.org/r/315427 Change subject: All View's can now call toHtmlString .. All View's can now call toHtmlString Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Talk overlay's should not need so many partials

2016-10-11 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. https://gerrit.wikimedia.org/r/315428 Change subject: Talk overlay's should not need so many partials .. Talk overlay's should not need so many partials Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Hygiene: Allow a more generalised Overlay header

2016-10-11 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. https://gerrit.wikimedia.org/r/315426 Change subject: Hygiene: Allow a more generalised Overlay header .. Hygiene: Allow a more generalised Overlay header Overlays can opt into

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Fix logic of MinervaBottomLanguageButton

2016-10-11 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. https://gerrit.wikimedia.org/r/315414 Change subject: Fix logic of MinervaBottomLanguageButton .. Fix logic of MinervaBottomLanguageButton When MinervaBottomLanguageButton is

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Remove language overlay instrumentation

2016-10-11 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. https://gerrit.wikimedia.org/r/315325 Change subject: Remove language overlay instrumentation .. Remove language overlay instrumentation Interactions with the LanguageOverlay

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Update Grunt dependencies to allow us to use jscs autofixing

2016-10-11 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. https://gerrit.wikimedia.org/r/315322 Change subject: Update Grunt dependencies to allow us to use jscs autofixing .. Update Grunt dependencies to allow us to use jscs

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Remove MinervaBottomLanguageButton

2016-10-11 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. https://gerrit.wikimedia.org/r/315318 Change subject: Remove MinervaBottomLanguageButton .. Remove MinervaBottomLanguageButton The language button will show at the top of the

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Disable bottom language button in Minerva

2016-10-11 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. https://gerrit.wikimedia.org/r/315314 Change subject: Disable bottom language button in Minerva .. Disable bottom language button in Minerva We plan to remove this config

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Test case: Certain MediaWiki setups use locally served images

2016-10-11 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. https://gerrit.wikimedia.org/r/315310 Change subject: Test case: Certain MediaWiki setups use locally served images .. Test case: Certain MediaWiki setups use locally served

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Tests: Add test coverage for Page:getThumbnails

2016-10-11 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. https://gerrit.wikimedia.org/r/315309 Change subject: Tests: Add test coverage for Page:getThumbnails .. Tests: Add test coverage for Page:getThumbnails Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...mobileapps[master]: Do not relocate first paragraph in new endpoint

2016-10-10 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. https://gerrit.wikimedia.org/r/315126 Change subject: Do not relocate first paragraph in new endpoint .. Do not relocate first paragraph in new endpoint This moves the logic

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: QA: Re-enable VisualEditor integration test

2016-10-10 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. https://gerrit.wikimedia.org/r/315118 Change subject: QA: Re-enable VisualEditor integration test .. QA: Re-enable VisualEditor integration test Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Don't skip browser tests

2016-10-10 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. https://gerrit.wikimedia.org/r/315113 Change subject: Don't skip browser tests .. Don't skip browser tests If they are important fix them. If not remove them. Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: POC: Use jquery 3 in mobile target mode

2016-10-07 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. https://gerrit.wikimedia.org/r/314771 Change subject: POC: Use jquery 3 in mobile target mode .. POC: Use jquery 3 in mobile target mode The savings of 3kb are probably not

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Footer version 2 is now default

2016-10-07 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. https://gerrit.wikimedia.org/r/314736 Change subject: Footer version 2 is now default .. Footer version 2 is now default * Update the config value * Update the tests Bug:

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Merge config declarations

2016-10-06 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. https://gerrit.wikimedia.org/r/314627 Change subject: Merge config declarations .. Merge config declarations wmg will override wg Follow up to

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: QA: Don't reference status of beta in browser test names

2016-10-06 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. https://gerrit.wikimedia.org/r/314616 Change subject: QA: Don't reference status of beta in browser test names .. QA: Don't reference status of beta in browser test names This

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: QA: Remove indeterminism from test

2016-10-06 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. https://gerrit.wikimedia.org/r/314619 Change subject: QA: Remove indeterminism from test .. QA: Remove indeterminism from test Hitting random can have unexpected results on

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: QA: Mark browser tests which have login steps which @login

2016-10-06 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. https://gerrit.wikimedia.org/r/314615 Change subject: QA: Mark browser tests which have login steps which @login .. QA: Mark browser tests which have login steps which @login

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: QA: Make it clearer which tests require anonymous editing su...

2016-10-06 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. https://gerrit.wikimedia.org/r/314617 Change subject: QA: Make it clearer which tests require anonymous editing support .. QA: Make it clearer which tests require anonymous

[MediaWiki-commits] [Gerrit] mediawiki...mobileapps[master]: Fix documentation for existing experimental endpoints

2016-10-05 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. https://gerrit.wikimedia.org/r/314307 Change subject: Fix documentation for existing experimental endpoints .. Fix documentation for existing experimental endpoints This was a

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Collapse sections by default

2016-10-04 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. https://gerrit.wikimedia.org/r/314210 Change subject: Collapse sections by default .. Collapse sections by default A global function mfTempOpenSection is added to the top of

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: UC Mini should be blacklisted

2016-10-04 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. https://gerrit.wikimedia.org/r/314195 Change subject: UC Mini should be blacklisted .. UC Mini should be blacklisted The UC Mini browser should be blacklisted. The experience

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Move versioning to bottom of HTML

2016-10-04 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. https://gerrit.wikimedia.org/r/314051 Change subject: Move versioning to bottom of HTML .. Move versioning to bottom of HTML Given `headelement` contains the tag and doctype

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Enable RelatedArticles on Minerva skin for all but top 6 wikis

2016-10-03 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. https://gerrit.wikimedia.org/r/313906 Change subject: Enable RelatedArticles on Minerva skin for all but top 6 wikis .. Enable RelatedArticles on Minerva skin for all but top 6

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Push footer version 2 to stable

2016-10-03 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. https://gerrit.wikimedia.org/r/313898 Change subject: Push footer version 2 to stable .. Push footer version 2 to stable Bug: T145442 Change-Id:

<    5   6   7   8   9   10   11   12   13   14   >