BearND has uploaded a new change for review.
https://gerrit.wikimedia.org/r/196604
Change subject: Localisation updates from https://translatewiki.net.
..
Localisation updates from https://translatewiki.net.
Change-Id: Ie5d8c
BearND has uploaded a new change for review.
https://gerrit.wikimedia.org/r/196611
Change subject: Localisation updates from https://translatewiki.net.
..
Localisation updates from https://translatewiki.net.
Change-Id: Ib4ec1
BearND has uploaded a new change for review.
https://gerrit.wikimedia.org/r/196705
Change subject: Light theme chooser button was not labelled on 2.3
..
Light theme chooser button was not labelled on 2.3
Another regression si
BearND has uploaded a new change for review.
https://gerrit.wikimedia.org/r/197077
Change subject: Set text color in error popups for 2.3
..
Set text color in error popups for 2.3
In light mode on 2.3 the error popups were wh
BearND has uploaded a new change for review.
https://gerrit.wikimedia.org/r/197098
Change subject: Remove (R) from wordmark in ShareAFact image
..
Remove (R) from wordmark in ShareAFact image
Change-Id: I701e57bcffb67b8b3cc7f
BearND has uploaded a new change for review.
https://gerrit.wikimedia.org/r/197376
Change subject: Updated SquareUp libraries
..
Updated SquareUp libraries
- Added missing credit for Picasso
- client.setCache does not throw I
BearND has uploaded a new change for review.
https://gerrit.wikimedia.org/r/197377
Change subject: Roll appcompat-v7 back to 21.0.3
..
Roll appcompat-v7 back to 21.0.3
Too many issues on Gingerbread right now.
Want to see som
BearND has uploaded a new change for review.
https://gerrit.wikimedia.org/r/197851
Change subject: WIP: Add Talk link at bottom of page
..
WIP: Add Talk link at bottom of page
Currently hard-coded for enwiki.
Styles need to b
BearND has uploaded a new change for review.
https://gerrit.wikimedia.org/r/198754
Change subject: Localisation updates from https://translatewiki.net.
..
Localisation updates from https://translatewiki.net.
Change-Id: I4767a
BearND has uploaded a new change for review.
https://gerrit.wikimedia.org/r/198755
Change subject: Localisation updates from https://translatewiki.net.
..
Localisation updates from https://translatewiki.net.
Change-Id: Ia0f9f
BearND has uploaded a new change for review.
https://gerrit.wikimedia.org/r/199140
Change subject: Avoid cache fragmenting URLs for Share a Fact shares
..
Avoid cache fragmenting URLs for Share a Fact shares
Use wprov=sfia1 f
BearND has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/397928 )
Change subject: Fix onthisday with section tags
..
Fix onthisday with section tags
Onthisday was looking for direct children of body to look
BearND has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/397961 )
Change subject: Bump onthisday version.
..
Bump onthisday version.
Change-Id: I15a3dbb1337d56291a0e2bb85f2c043afe51
---
M lib/mobile-uti
BearND has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/398080 )
Change subject: Adjust end time for fundraising announcements
..
Adjust end time for fundraising announcements
New end date it is December 2
BearND has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/398085 )
Change subject: Skip some tests because of upstream issues
..
Skip some tests because of upstream issues
This is related to T182770.
Change
Hello jenkins-bot, Mholloway,
I'd like you to do a code review. Please visit
https://gerrit.wikimedia.org/r/398183
to review the following change.
Change subject: Revert "Revert "Update section validation logic""
..
Reve
BearND has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/398184 )
Change subject: Add unit test for logging the warning if section validation
fails
..
Add unit test for logging the warning if section valida
BearND has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/398254 )
Change subject: Automatically end announcements after configured endTime
..
Automatically end announcements after configured endTime
No need
BearND has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/398268 )
Change subject: Fix onthisday entries from day pages
..
Fix onthisday entries from day pages
Since HTML5 section ids were deployed,
onthisda
BearND has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/398300 )
Change subject: Bump onthisday version
..
Bump onthisday version
... since we fixed the section heading id selector strings,
see previous co
BearND has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/398304 )
Change subject: Update mobileapps to ff74bb1
..
Update mobileapps to ff74bb1
List of changes:
96eab05 Revert "Revert "Update section validat
BearND has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/382628 )
Change subject: Hygiene: update diff test results
..
Hygiene: update diff test results
The Frankenstein test page has been protected.
Chang
BearND has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/382877 )
Change subject: Fix Portuguese news selector
..
Fix Portuguese news selector
The old version of the CSS selector for ptwiki news stories res
BearND has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/382876 )
Change subject: Hygiene: simplify assertions in onthisday test
..
Hygiene: simplify assertions in onthisday test
This is to make failure out
BearND has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/382875 )
Change subject: Hygiene: simplify assert.closeTo and assert.contains
..
Hygiene: simplify assert.closeTo and assert.contains
This is to make
BearND has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/382878 )
Change subject: Hygiene: Update test fixtures
..
Hygiene: Update test fixtures
This is for news, onthisday, and a general test page.
This ia
BearND has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/383648 )
Change subject: Update mobileapps to c045afc
..
Update mobileapps to c045afc
List of changes:
6b7a264 Account for instead of for inline fi
BearND has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/386045 )
Change subject: Update mobileapps to 3628105
..
Update mobileapps to 3628105
List of changes:
c330b3f Summary 2.0: Introduce namespace white
BearND has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/386268 )
Change subject: Revert "Add fundraising test via announcement cards in France"
..
Revert "Add fundraising test via announcement cards in Fran
BearND has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/386336 )
Change subject: Next gen definitions parsing, using section tags
..
Next gen definitions parsing, using section tags
Prep definitions parsin
BearND has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/386334 )
Change subject: Hygiene: rename parseDefinitions to parseDefinitionsUsingDivs
..
Hygiene: rename parseDefinitions to parseDefinitionsUsingDiv
BearND has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/386335 )
Change subject: Hygiene: split up definitions parsing into two implementations
..
Hygiene: split up definitions parsing into two implementati
BearND has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/376138 )
Change subject: Change summary endpoint Content-Type to JSON
..
Change summary endpoint Content-Type to JSON
Also added a simple integration
BearND has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/376137 )
Change subject: Rename endpoint preview-html to summary
..
Rename endpoint preview-html to summary
The endpoint returns JSON not HTML anymor
BearND has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/376139 )
Change subject: Add swagger spec for summary endpoint
..
Add swagger spec for summary endpoint
Bug: T174808
Change-Id: I976a2997507240dd1621
BearND has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/376138 )
Change subject: Change summary endpoint Content-Type to JSON
..
Change summary endpoint Content-Type to JSON
Also added a simple int
BearND has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/376430 )
Change subject: Update mobileapps to 2cb6281
..
Update mobileapps to 2cb6281
List of changes:
b6396b8 Hygiene: POTD/set content-type header
BearND has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/402074 )
Change subject: random: fail early when MW API response has no query.pages
..
random: fail early when MW API response has no query.pages
Sta
BearND has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/402077 )
Change subject: Temporarily skip testing of French news.
..
Temporarily skip testing of French news.
Will add a separate patch to fix adding
BearND has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/402083 )
Change subject: News: don't include empty stories
..
News: don't include empty stories
Bug: T184198
Change-Id: Ia2e7c4cc61cbb99e2fa0f5af355b
BearND has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/402096 )
Change subject: Update mobileapps to a4ba9fd
..
Update mobileapps to a4ba9fd
List of changes:
29fd37f References: add specific version numbe
BearND has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/402129 )
Change subject: Show MW API requests when debug is true
..
Show MW API requests when debug is true
To make it easier to debug backend reques
BearND has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/402891 )
Change subject: Show MW API requests when env var DEBUG_MW_REQUESTS is set
..
Show MW API requests when env var DEBUG_MW_REQUESTS is set
Eve
BearND has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/402914 )
Change subject: Add revision and tid to references output
..
Add revision and tid to references output
Bug: T184328
Change-Id: I6b055ccc09f3
BearND has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/402913 )
Change subject: Hygiene: extract references endpoint into new module
..
Hygiene: extract references endpoint into new module
Also fixed/clar
BearND has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/402984 )
Change subject: Update mobileapps to d20915c
..
Update mobileapps to d20915c
List of changes:
94845db Show MW API requests when debug is tru
BearND has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/403568 )
Change subject: Remove unwanted nodes and attributes from summary
..
Remove unwanted nodes and attributes from summary
Bug: T184557
Change-I
BearND has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/403578 )
Change subject: Fix lint issues
..
Fix lint issues
Change-Id: I5dbf10b3479856a9e35d2fa32895373f63b577f4
---
M test/lib/mobile-util/mobile-ut
BearND has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/403725 )
Change subject: WIP: Remove parentheses using state machine instead of regex
..
WIP: Remove parentheses using state machine instead of regex
BearND has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/377347 )
Change subject: Hygiene: Refactor sectioning tests
..
Hygiene: Refactor sectioning tests
Change-Id: I2c818450432681318f546dc37cbc09db0c47817
BearND has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/377349 )
Change subject: Bring back old section handling code
..
Bring back old section handling code
The new section handling code via the tags fro
BearND has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/377348 )
Change subject: Hygiene: prefer equal to deepEqual in sectioning tests
..
Hygiene: prefer equal to deepEqual in sectioning tests
Change-Id:
BearND has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/377528 )
Change subject: Bump mobile-sections version
..
Bump mobile-sections version
Due to the sectioning change (see previous commit).
Change-Id:
BearND has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/377540 )
Change subject: Update mobileapps to 297b048
..
Update mobileapps to 297b048
List of changes:
69e296b Fix "On this day" for "selected" for f
BearND has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/377679 )
Change subject: TFA: add scowiki
..
TFA: add scowiki
Bug: T175759
Change-Id: I1114324a29b5443446b5dc2e8cf3a17ad4594b4b
---
M lib/feed/featur
BearND has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/378202 )
Change subject: Hygiene: move generate_wiktionary_languages.py to script folder
..
Hygiene: move generate_wiktionary_languages.py to script f
BearND has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/378368 )
Change subject: Add compare script for old and new extracts
..
Add compare script for old and new extracts
Compare the top 1000 pages viewed
BearND has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/378366 )
Change subject: Make script to compile top-pages more generic
..
Make script to compile top-pages more generic
Better error handling. Check
BearND has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/378364 )
Change subject: Remove spam entry from top pages
..
Remove spam entry from top pages
Change-Id: Iabffa6d7ec972c707a255789e68407683626765b
--
BearND has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/378371 )
Change subject: More top-pages script improvements
..
More top-pages script improvements
Get rid of curl call. Use preq instead.
Add redirec
BearND has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/378365 )
Change subject: Hygiene: move some files from static to private folder
..
Hygiene: move some files from static to private folder
The static
BearND has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/378370 )
Change subject: Make top-pages script take language commandline parameter
..
Make top-pages script take language commandline parameter
Delay
BearND has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/378369 )
Change subject: Add multi-lang.js script
..
Add multi-lang.js script
This script allows you to execute another given executable over a list
BearND has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/378367 )
Change subject: Split off script to compile top-pages
..
Split off script to compile top-pages
This script is used in several places and but
BearND has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/378372 )
Change subject: Add more top-pages lists
..
Add more top-pages lists
Chose the top WP projects based on number of users.
Change-Id: Ie60ece
BearND has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/391157 )
Change subject: featured-image: better diagnostics in error case
..
featured-image: better diagnostics in error case
We don't want to have t
BearND has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/385419 )
Change subject: Hygiene: add tmp folder to eslintignore
..
Hygiene: add tmp folder to eslintignore
Change-Id: I77f5fb80ffda11c1fcafe5113d6a8
BearND has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/385420 )
Change subject: Hygiene: create script to compare old and new sectioning code
..
Hygiene: create script to compare old and new sectioning cod
BearND has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/385423 )
Change subject: Hygiene: add tests for new Parsoid section elements
..
Hygiene: add tests for new Parsoid section elements
To prepare for T1
BearND has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/385422 )
Change subject: Get section number from Parsoid
..
Get section number from Parsoid
* Get section number from Parsoid's section element data-
BearND has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/385425 )
Change subject: Rewrite sectioning using section tags code
..
Rewrite sectioning using section tags code
For mobile-sections we only care ab
BearND has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/385424 )
Change subject: Fail incomplete sections early
..
Fail incomplete sections early
To avoid issues with incomplete sections, which let to T175
BearND has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/381507 )
Change subject: Add fundraising test via announcement cards in France
..
Add fundraising test via announcement cards in France
Changed wiki
BearND has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/382073 )
Change subject: Update mobileapps to 5dc0c02
..
Update mobileapps to 5dc0c02
List of changes:
7139e27 Add featured feed In the news entry fo
BearND has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/395849 )
Change subject: Version number for the media endpoint
..
Version number for the media endpoint
Bug: T177430
Change-Id: I426d97e2c36b0071bc3a
BearND has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/396297 )
Change subject: Bring back Sepia request caching
..
Bring back Sepia request caching
The key is to require sepia. This line got somehow dele
BearND has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/396428 )
Change subject: WIP: Dev: Replace Sepia with Replayer
..
WIP: Dev: Replace Sepia with Replayer
Unfortunately the Sepia project seems abandon
BearND has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/397633 )
Change subject: Bump mobile-sections and definitions version
..
Bump mobile-sections and definitions version
to hopefully follow shortly aft
BearND has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/397640 )
Change subject: References: add specific version number
..
References: add specific version number
This will be part of PCS.
Change-Id: I2f
BearND has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/397737 )
Change subject: References: back_link as object
..
References: back_link as object
Instead of a single string a backlink is now an object wi
BearND has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/397867 )
Change subject: References: citation type
..
References: citation type
Instead of an citations array we return a single value in the type
fi
BearND has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/403770 )
Change subject: Fix another lint issue
..
Fix another lint issue
I ran into these when trying to commit my patches. I run the pre-commit
hoo
BearND has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/403880 )
Change subject: Summary: update regex for non-ASCII parentheses
..
Summary: update regex for non-ASCII parentheses
The previous version crea
BearND has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/403881 )
Change subject: Summary: update regex for finding parentheticals
..
Summary: update regex for finding parentheticals
For the latin character
BearND has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/403882 )
Change subject: Summary: flattened anchors stay anchors
..
Summary: flattened anchors stay anchors
We can remove the flattenElements call fo
BearND has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/403977 )
Change subject: Flatten DOM anchors if no attributes kept
..
Flatten DOM anchors if no attributes kept
The flattenElements method previously
BearND has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/404244 )
Change subject: Hygiene: move summary route to own file
..
Hygiene: move summary route to own file
Change-Id: I3f1c11331d4b1ecbc19fa6d5b1a03
BearND has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/404243 )
Change subject: Hygiene: inline the summary call to _collectRawPageData
..
Hygiene: inline the summary call to _collectRawPageData
This make
BearND has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/404241 )
Change subject: Hygiene: add more summary tests
..
Hygiene: add more summary tests
Change-Id: I245cb3b3715cb67b7c589f42079f34203c25d32d
---
BearND has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/404242 )
Change subject: Hygiene: remove extraneous disambig code
..
Hygiene: remove extraneous disambig code
The disambig flag gets determined insid
BearND has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/404248 )
Change subject: summary: inline 204 checks
..
summary: inline 204 checks
The three checks for when to return 204 are simple enough that we c
BearND has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/404247 )
Change subject: summary: just parse the lead section
..
summary: just parse the lead section
No need to try to parse other sections for the
BearND has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/404246 )
Change subject: Initial streamlining getting the summary HTML
..
Initial streamlining getting the summary HTML
* Replace pageJsonPromise wit
BearND has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/404245 )
Change subject: Hygiene: move summary library functions to own lib file
..
Hygiene: move summary library functions to own lib file
There wer
BearND has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/404496 )
Change subject: Also keep style attributes when flattening elements
..
Also keep style attributes when flattening elements
See comment https
BearND has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/404509 )
Change subject: Hygiene: extract method for when to return 204
..
Hygiene: extract method for when to return 204
Change-Id: I97a3464f5f9f1ec
BearND has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/404510 )
Change subject: summary: fix mainpage handling
..
summary: fix mainpage handling
The issue was that several non-English main pages are not i
BearND has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/404515 )
Change subject: summary: skip removing data-mw attributes
..
summary: skip removing data-mw attributes
Skip removing data-mw attributes in t
BearND has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/404514 )
Change subject: summary: reorder summarizer transforms
..
summary: reorder summarizer transforms
Doing the regex manipulations first, then t
BearND has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/404622 )
Change subject: Skip beta cluster test
..
Skip beta cluster test
Beta cluster API is having some issues:
PHP fatal error: Stack overflow
Ch
901 - 1000 of 1043 matches
Mail list logo