Krinkle has submitted this change and it was merged.
Change subject: Revert Gitignore: Reset to upstream, and add
/etc/jenkins_jobs.ini
..
Revert Gitignore: Reset to upstream, and add /etc/jenkins_jobs.ini
This reverts commit
Krinkle has uploaded a new change for review.
Change subject: Gitignore: Reset to upstream, and add /etc/jenkins_jobs.ini
..
Gitignore: Reset to upstream, and add /etc/jenkins_jobs.ini
Also fix broken gitreview file.
Krinkle has uploaded a new change for review.
Change subject: Gitignore: Reset to upstream, and add /etc/jenkins_jobs.ini
..
Gitignore: Reset to upstream, and add /etc/jenkins_jobs.ini
Also fix broken gitreview file.
Krinkle has submitted this change and it was merged.
Change subject: Gitignore: Reset to upstream, and add /etc/jenkins_jobs.ini
..
Gitignore: Reset to upstream, and add /etc/jenkins_jobs.ini
Also fix broken gitreview file.
Krinkle has uploaded a new change for review.
Change subject: Gitignore: Add 'output' directory.
..
Gitignore: Add 'output' directory.
Change-Id: I922141803f304af95ebaede707f74ddcff3943ed
---
M .gitignore
1 file changed, 1
Krinkle has submitted this change and it was merged.
Change subject: Gitignore: Add 'output' directory.
..
Gitignore: Add 'output' directory.
Change-Id: I922141803f304af95ebaede707f74ddcff3943ed
---
M .gitignore
1 file
Krinkle has uploaded a new change for review.
Change subject: Jenkins test (DO NOT SUBMIT)
..
Jenkins test (DO NOT SUBMIT)
Change-Id: I906ea3ac4fe8ee642893bf13acd95cb697d26cd7
---
A example.js
1 file changed, 9 insertions(+), 0
Krinkle has submitted this change and it was merged.
Change subject: git macro to fetch mw ext at root of $WORKSPACE
..
git macro to fetch mw ext at root of $WORKSPACE
Sometime we do not want to fetch the extensions under a
Krinkle has uploaded a new change for review.
Change subject: mediawiki.jqueryMsg: Fix regression and add tests.
..
mediawiki.jqueryMsg: Fix regression and add tests.
From If060b75f.
Thanks to jshint and us using Checkstyle
Krinkle has uploaded a new change for review.
Change subject: (DRAFT) JSDuck stuff
..
(DRAFT) JSDuck stuff
Change-Id: Ieb8c5d2d2cb4672f1d6abc3f865c6fb1470d8feb
---
M .gitignore
M maintenance/Makefile
A
Krinkle has uploaded a new change for review.
Change subject: [Rewrite] Use ResourceLoader and remove hardcoded RTL rules.
..
[Rewrite] Use ResourceLoader and remove hardcoded RTL rules.
* Now handled automatically by RL with
Krinkle has uploaded a new change for review.
Change subject: [Rewrite] Clean up: PHP errors, CSS errors, storage, coding
style
..
[Rewrite] Clean up: PHP errors, CSS errors, storage, coding style
PHP errors:
* Notice:
Krinkle has uploaded a new change for review.
Change subject: Installer: Fix double escaping of config-download-localsettings.
..
Installer: Fix double escaping of config-download-localsettings.
The link was outputted as:
Krinkle has uploaded a new change for review.
Change subject: JSHint: Catch some big fish.
..
JSHint: Catch some big fish.
Warnings fixed:
* lqt.js: line 257: 'del' is not defined.
* lqt.js: line 1407: 'sel' is not defined.
*
Hello jenkins-bot,
I'd like you to do a code review. Please visit
https://gerrit.wikimedia.org/r/47321
to review the following change.
Change subject: sphinx is now stricter
..
sphinx is now stricter
The documentation
Hello jenkins-bot,
I'd like you to do a code review. Please visit
https://gerrit.wikimedia.org/r/47322
to review the following change.
Change subject: Add ability to specify mavenName for maven jobs.
..
Add ability to
Hello jenkins-bot,
I'd like you to do a code review. Please visit
https://gerrit.wikimedia.org/r/47323
to review the following change.
Change subject: Documentation fixes to make Sphinx happy
..
Documentation fixes to
Hello jenkins-bot,
I'd like you to do a code review. Please visit
https://gerrit.wikimedia.org/r/47324
to review the following change.
Change subject: Remove setuptools-git from setup.py.
..
Remove setuptools-git from
Hello jenkins-bot,
I'd like you to do a code review. Please visit
https://gerrit.wikimedia.org/r/47325
to review the following change.
Change subject: Raise exception for at least one type of syntax errors
..
Raise
Hello jenkins-bot,
I'd like you to do a code review. Please visit
https://gerrit.wikimedia.org/r/47326
to review the following change.
Change subject: Bugfix and tidy-up
..
Bugfix and tidy-up
Allow the configuration
Krinkle has uploaded a new change for review.
Change subject: mediawiki.action.view.dblClickEdit: Fix undefined $content.
..
mediawiki.action.view.dblClickEdit: Fix undefined $content.
Regression from Ie8a35700.
Bug: 44522
Krinkle has uploaded a new change for review.
Change subject: Fix sawikiquote wgLogo.
..
Fix sawikiquote wgLogo.
Change-Id: I9fd98309f3ccfd1b9cd799b1c5aebaddc75e5a63
Follows-up: I5683bc0397644
Bug: 43812
---
M
Krinkle has submitted this change and it was merged.
Change subject: Fix sawikiquote wgLogo.
..
Fix sawikiquote wgLogo.
Change-Id: I9fd98309f3ccfd1b9cd799b1c5aebaddc75e5a63
Follows-up: I5683bc0397644
Bug: 43812
---
M
Krinkle has uploaded a new change for review.
Change subject: Enable voting for mwext-Math-jslint.
..
Enable voting for mwext-Math-jslint.
Change-Id: Ibe43e16f118bdaefc2f4b2fba10cccad90719691
---
M layout.yaml
1 file changed, 2
Krinkle has submitted this change and it was merged.
Change subject: Enable voting for mwext-Math-jslint.
..
Enable voting for mwext-Math-jslint.
Change-Id: Ibe43e16f118bdaefc2f4b2fba10cccad90719691
---
M layout.yaml
1 file
Krinkle has uploaded a new change for review.
Change subject: mediawiki.action.view.dblClickEdit: Fix undefined $content.
..
mediawiki.action.view.dblClickEdit: Fix undefined $content.
Regression from Ie8a35700.
Bug: 44522
Krinkle has uploaded a new change for review.
Change subject: Sync: Commit live changes by hashar to
jobs/MediaWiki-GIT-Fetching/config.xml
..
Sync: Commit live changes by hashar to jobs/MediaWiki-GIT-Fetching/config.xml
Krinkle has submitted this change and it was merged.
Change subject: Sync: Commit live changes by hashar to
jobs/MediaWiki-GIT-Fetching/config.xml
..
Sync: Commit live changes by hashar to
Krinkle has uploaded a new change for review.
Change subject: Sync: Remove old files already removed by hashar on live
..
Sync: Remove old files already removed by hashar on live
Change-Id:
Krinkle has submitted this change and it was merged.
Change subject: Sync: Remove old files already removed by hashar on live
..
Sync: Remove old files already removed by hashar on live
Change-Id:
Krinkle has uploaded a new change for review.
Change subject: Sync: Commit submodule update tools/codesniffer to latest master
..
Sync: Commit submodule update tools/codesniffer to latest master
Change-Id:
Krinkle has uploaded a new change for review.
Change subject: Sync: Commit .gitignore changes for jenkins-job-builder
..
Sync: Commit .gitignore changes for jenkins-job-builder
Change-Id:
Krinkle has submitted this change and it was merged.
Change subject: Sync: Commit .gitignore changes for jenkins-job-builder
..
Sync: Commit .gitignore changes for jenkins-job-builder
Change-Id:
Krinkle has uploaded a new change for review.
Change subject: Sync: Commit move of tools/codesniffer submodule
..
Sync: Commit move of tools/codesniffer submodule
Change-Id: I94ec637570333b577508b333fa640c03dc760ea2
---
M
Krinkle has submitted this change and it was merged.
Change subject: Sync: Commit move of tools/codesniffer submodule
..
Sync: Commit move of tools/codesniffer submodule
Change-Id: I94ec637570333b577508b333fa640c03dc760ea2
---
Krinkle has uploaded a new change for review.
Change subject: phpcs: Pass DefaultSettings.php
..
phpcs: Pass DefaultSettings.php
See:
mediawiki/tools/codesniffer.git:/MediaWiki/rules.xml
Also fixed typo '=' in comment that
Krinkle has uploaded a new change for review.
https://gerrit.wikimedia.org/r/48766
Change subject: admins.pp: Add new key for 'krinkle'. Invalidate old key.
..
admins.pp: Add new key for 'krinkle'. Invalidate old key.
Krinkle has submitted this change and it was merged.
Change subject: Revert phpcs: Convert var to public in SpecialUserlogin.php
..
Revert phpcs: Convert var to public in SpecialUserlogin.php
This reverts commit
Hello jenkins-bot,
I'd like you to do a code review. Please visit
https://gerrit.wikimedia.org/r/48880
to review the following change.
Change subject: Fixing Inject to not create empty tags
..
Fixing Inject to not create
Hello jenkins-bot,
I'd like you to do a code review. Please visit
https://gerrit.wikimedia.org/r/48881
to review the following change.
Change subject: publishers: added option to define groovy postbuild script
..
Krinkle has submitted this change and it was merged.
Change subject: Implement publisher.checkstyle
..
Implement publisher.checkstyle
Add publisher for Checkstyle Plugin[1] (based on code for the
Violations Plugin publisher)
Krinkle has submitted this change and it was merged.
Change subject: publishers: added option to define groovy postbuild script
..
publishers: added option to define groovy postbuild script
Change-Id:
Krinkle has submitted this change and it was merged.
Change subject: Fixing Inject to not create empty tags
..
Fixing Inject to not create empty tags
Using the Inject functionality with the builders section caused
an error in
Krinkle has uploaded a new change for review.
https://gerrit.wikimedia.org/r/49016
Change subject: InfoAction: Heading ID should not include # character.
..
InfoAction: Heading ID should not include # character.
It was
Krinkle has uploaded a new change for review.
https://gerrit.wikimedia.org/r/49204
Change subject: docsgen: Fix error on Ubuntu
..
docsgen: Fix error on Ubuntu
When running this on Mac, it works fine.
But when running it on
Krinkle has uploaded a new change for review.
https://gerrit.wikimedia.org/r/49811
Change subject: Tests: Add missing expect numbers in QUnit tests.
..
Tests: Add missing expect numbers in QUnit tests.
Various tests were
Krinkle has uploaded a new change for review.
https://gerrit.wikimedia.org/r/49812
Change subject: Upstream: Update QUnit from v1.10.0 to v1.11.0
..
Upstream: Update QUnit from v1.10.0 to v1.11.0
* Code:
Krinkle has uploaded a new change for review.
https://gerrit.wikimedia.org/r/49840
Change subject: (DRAFT) initial commit
..
(DRAFT) initial commit
Change-Id: Icf305892a9512545a63f5a5280cc0d340c61585f
---
A EXAMPLE.js
A
Krinkle has uploaded a new change for review.
https://gerrit.wikimedia.org/r/49845
Change subject: Upstream: Update QUnit from v1.10.0 to v1.11.0
..
Upstream: Update QUnit from v1.10.0 to v1.11.0
* Code:
Krinkle has submitted this change and it was merged.
Change subject: WMF wrapper around grunt
..
WMF wrapper around grunt
This tiny shell script let us easily start grunt with the continuous
integration grunt file. Would save
Krinkle has uploaded a new change for review.
Change subject: Upstream: Sync with mediawiki/core (62db8b4).
..
Upstream: Sync with mediawiki/core (62db8b4).
Change-Id: Ieb96b4840577f73c671c6f39426dd7e568a9
---
M
Krinkle has submitted this change and it was merged.
Change subject: Skin: Make portlet rules backwards compatible with html cache.
..
Skin: Make portlet rules backwards compatible with html cache.
Follows-up I9a2ebd50.
Caused
Krinkle has uploaded a new change for review.
Change subject: Skin: Make portlet rules backwards compatible with html cache.
..
Skin: Make portlet rules backwards compatible with html cache.
Follows-up I9a2ebd50.
Caused
Krinkle has submitted this change and it was merged.
Change subject: Skin: Make portlet rules backwards compatible with html cache.
..
Skin: Make portlet rules backwards compatible with html cache.
Follows-up I9a2ebd50.
Caused
Krinkle has submitted this change and it was merged.
Change subject: wmfgrunt now support spaces in paths
..
wmfgrunt now support spaces in paths
Several shell variables were not properly expanded which would lead to
huge
Krinkle has uploaded a new change for review.
Change subject: (bug 33414) Fix SQL error on merge/delete with blocked user.
..
(bug 33414) Fix SQL error on merge/delete with blocked user.
Field ipb_id is the block id, ipb_user
Krinkle has submitted this change and it was merged.
Change subject: (bug 33414) Fix SQL error on merge/delete with blocked user.
..
(bug 33414) Fix SQL error on merge/delete with blocked user.
Field ipb_id is the block id,
Krinkle has uploaded a new change for review.
Change subject: (bug 42598) Database: fname was not logged for BEGIN/COMMIT.
..
(bug 42598) Database: fname was not logged for BEGIN/COMMIT.
Relied on presence of whitespace. From
Krinkle has uploaded a new change for review.
Change subject: (bug 41159) Position of VisualEditor's Create tab is wrong.
..
(bug 41159) Position of VisualEditor's Create tab is wrong.
Change-Id:
Krinkle has submitted this change and it was merged.
Change subject: Add some __METHOD__ to begin/commit/rollback calls
..
Add some __METHOD__ to begin/commit/rollback calls
Change-Id: I20dad8d6bb7a523e8a6f50bc0af5cdba57d7160f
Krinkle has submitted this change and it was merged.
Change subject: Renamed API from ve-parsoid to visual editor
..
Renamed API from ve-parsoid to visual editor
Change-Id: I3bfe2e813b31f9010010f63902b1e8e22f3bcd59
---
M
Krinkle has uploaded a new change for review.
Change subject: Init: Fix incorrect context for mw.msg.apply.
..
Init: Fix incorrect context for mw.msg.apply.
Context should be 'mw', not 'mw.msg'.
Also updated to using ve.bind
Krinkle has uploaded a new change for review.
Change subject: mw.Platform: Only show minor edit option if user has
minoredit right.
..
mw.Platform: Only show minor edit option if user has minoredit right.
Had to make the
Krinkle has uploaded a new change for review.
Change subject: mediawiki.Uri.test: Clean up
..
mediawiki.Uri.test: Clean up
* Grouped assertions together by logical test unit (method names).
* Re-ordered (constructor,
Krinkle has uploaded a new change for review.
Change subject: mediawiki.Uri: Don't raw encode the 'title' query parameter.
..
mediawiki.Uri: Don't raw encode the 'title' query parameter.
Previously:
Input:
Krinkle has uploaded a new change for review.
Change subject: (bug 42553) Only replace url on veaction=edit if there is no
other query
..
(bug 42553) Only replace url on veaction=edit if there is no other query
Change-Id:
Krinkle has uploaded a new change for review.
Change subject: Cleanup oldid: Use mw.config for page existence and revision id.
..
Cleanup oldid: Use mw.config for page existence and revision id.
Use mw.config wgCurRevisionId
Krinkle has uploaded a new change for review.
Change subject: (bug 42137) Sync availability of minor edit with MW backend.
..
(bug 42137) Sync availability of minor edit with MW backend.
Which for now is just not when creating
Krinkle has submitted this change and it was merged.
Change subject: (bug 42601) Make deleteOldRevisions.php no longer throw
database errors on empty sets.
..
(bug 42601) Make deleteOldRevisions.php no longer throw database
Krinkle has submitted this change and it was merged.
Change subject: (bug 42220) Added support for edit notices, which appear on the
toolbar
..
(bug 42220) Added support for edit notices, which appear on the toolbar
Krinkle has submitted this change and it was merged.
Change subject: Removed all browser-specific border-radius rules
..
Removed all browser-specific border-radius rules
These aren't needed for any of our target browsers
Krinkle has submitted this change and it was merged.
Change subject: Removed all browser-specific box-shadow rules
..
Removed all browser-specific box-shadow rules
These aren't needed for any of our target browsers anymore.
Krinkle has submitted this change and it was merged.
Change subject: Making previous fix compat with CSS style convention and adding
comment
..
Making previous fix compat with CSS style convention and adding comment
Krinkle has submitted this change and it was merged.
Change subject: (bug 40339) Out of bounds errors
..
(bug 40339) Out of bounds errors
Detecting contextChange events was making assumptions about the previous state,
and
Krinkle has submitted this change and it was merged.
Change subject: (bug 42638) Fix API action=optionsreset=1 unit tests
..
(bug 42638) Fix API action=optionsreset=1 unit tests
Change I98df55f2 broke action=optionsreset=1,
Krinkle has submitted this change and it was merged.
Change subject: (bug 42638) Fix API action=optionsreset=1 unit tests
..
(bug 42638) Fix API action=optionsreset=1 unit tests
Change I98df55f2 broke action=optionsreset=1,
Krinkle has submitted this change and it was merged.
Change subject: Release notes and version number
..
Release notes and version number
Updates for 1.20.2 release
Change-Id: Ib0eecc85bb84c06e0f9a9b2b53fba695073633bf
---
M
Krinkle has uploaded a new change for review.
Change subject: Clean up, fix errors on demos.
..
Clean up, fix errors on demos.
* Fix 404 error for ve.ui.Icons-{raster,vector}.css
Follows-up 9563f08 / I840f72426f9a.
Krinkle has uploaded a new change for review.
Change subject: init.Platform: Refactor parsed messages.
..
init.Platform: Refactor parsed messages.
Rewrite VisualEditorMessagesModule:
* Replace copy-paste dump of user-css module
Krinkle has submitted this change and it was merged.
Change subject: Revert UIDGenerator commits.
..
Revert UIDGenerator commits.
Changes seemed to be merged without anyone really looking at it
and the authorship in git is
Krinkle has uploaded a new change for review.
Change subject: (bug 42136) Use user prefs to set initial state of Watch this.
..
(bug 42136) Use user prefs to set initial state of Watch this.
* Don't show at all if user isn't
Krinkle has uploaded a new change for review.
Change subject: Fix CSS syntax errors from If1e08bbf.
..
Fix CSS syntax errors from If1e08bbf.
Change-Id: I38f33a065afbe37f931934017c11d5ceedb34176
---
M
Krinkle has uploaded a new change for review.
Change subject: (bug 42654) Implement Show changes in Save dialog.
..
(bug 42654) Implement Show changes in Save dialog.
Turned saveDialog-body into slide-based swapper.
Moved
Krinkle has submitted this change and it was merged.
Change subject: (bug 42491) Get rid of wikimedia-editpage-tos-summary
..
(bug 42491) Get rid of wikimedia-editpage-tos-summary
It is overly verbose and repeats contents of
Krinkle has uploaded a new change for review.
Change subject: Remove StartProfiler.php symlink.
..
Remove StartProfiler.php symlink.
* Previous wmf branches didn't have it.
* JSHint is throwing up on the unresolvable symlink.
*
Krinkle has uploaded a new change for review.
Change subject: mw.ViewPageTarget: Move diff button logic, min-height for
dialog.
..
mw.ViewPageTarget: Move diff button logic, min-height for dialog.
Follows-up Ic77c5ce4 and
Krinkle has uploaded a new change for review.
Change subject: Save dialog: Various clean up.
..
Save dialog: Various clean up.
Drop -down class in favour of :active CSS pseudo-class.
* http://kimblim.dk/css-tests/selectors/
*
Krinkle has uploaded a new change for review.
Change subject: (DRAFT) WIP - Save dialog: Implement new Review and Save
model.
..
(DRAFT) WIP - Save dialog: Implement new Review and Save model.
- basically in saveDialog-body
Krinkle has uploaded a new change for review.
Change subject: Save dialog: Fix too-wide diff box.
..
Save dialog: Fix too-wide diff box.
The rules have changed, these constraints are no longer needed
and actually causing the
Krinkle has uploaded a new change for review.
Change subject: Upstream: Upgrade jQuery JSON from 2.3 to 2.4.0.
..
Upstream: Upgrade jQuery JSON from 2.3 to 2.4.0.
* http://code.google.com/p/jquery-json/downloads/list
Krinkle has uploaded a new change for review.
Change subject: Upstream: Upgrade jQuery JSON from 2.3 to 2.4.0.
..
Upstream: Upgrade jQuery JSON from 2.3 to 2.4.0.
* http://code.google.com/p/jquery-json/downloads/list
Krinkle has uploaded a new change for review.
Change subject: (bug 43013) Exclude edit notices with no visible text.
..
(bug 43013) Exclude edit notices with no visible text.
en.wikipedia.org has a template gala for edit
Krinkle has uploaded a new change for review.
Change subject: Phase out $.toJSON, use JSON.stringify directly.
..
Phase out $.toJSON, use JSON.stringify directly.
Although $.toJSON optimises heavily for modern browsers (it
Krinkle has uploaded a new change for review.
Change subject: Typo from I65447da8.
..
Typo from I65447da8.
Change-Id: I27cce9784149cf1e98c4ed144ead4718978a74ae
---
M modules/ve/init/mw/ve.init.mw.Target.js
1 file changed, 1
Krinkle has uploaded a new change for review.
Change subject: (bug 43052) dblClickEdit/rightClickEdit: Trigger ca-edit click.
..
(bug 43052) dblClickEdit/rightClickEdit: Trigger ca-edit click.
To test, enable these preferences
Krinkle has uploaded a new change for review.
Change subject: Bin: Add symlink to node-jshint cli bin
..
Bin: Add symlink to node-jshint cli bin
Change-Id: Iac4341029f502fe94b7ea166a11b0b1903a282c8
---
A bin/jshint
1 file
Krinkle has submitted this change and it was merged.
Change subject: Bin: Add symlink to node-jshint cli bin
..
Bin: Add symlink to node-jshint cli bin
Change-Id: Iac4341029f502fe94b7ea166a11b0b1903a282c8
---
A bin/jshint
1
Krinkle has uploaded a new change for review.
Change subject: Grunt: Refactor and integrate jshint/phplint tasks.
..
Grunt: Refactor and integrate jshint/phplint tasks.
Tasks, package.json and node_modules imported from
Krinkle has submitted this change and it was merged.
Change subject: Revert Adding ability of jQuery badge to display the number
zero if requested.
..
Revert Adding ability of jQuery badge to display the number zero if
Krinkle has uploaded a new change for review.
Change subject: jquery.badge: Add ability to display the number zero.
..
jquery.badge: Add ability to display the number zero.
This is needed by Echo extension.
Follows-up
1001 - 1100 of 4725 matches
Mail list logo
