[Mesa-dev] [PATCH] nouveau: Fix bugs in nouveau_video_buffer

2011-12-19 Thread Maarten Lankhorst
Double free and array overflow, even if only 2 members are used the last one needs to be set to NULL explicitly. Signed-off-by: Maarten Lankhorst m.b.lankho...@gmail.com --- src/gallium/drivers/nouveau/nouveau_video.c |1 - src/gallium/drivers/nouveau/nouveau_video.h |6 +++--- 2 files

[Mesa-dev] [PATCH 1/3] vdpau: Add support for parameters

2011-12-19 Thread Maarten Lankhorst
Currently only validating, since nothing else can be done with it yet Signed-off-by: Maarten Lankhorst m.b.lankho...@gmail.com --- src/gallium/state_trackers/vdpau/mixer.c | 95 +- src/gallium/state_trackers/vdpau/query.c | 41 +-

[Mesa-dev] [PATCH 2/3] vdpau: Add support for mixer attributes

2011-12-19 Thread Maarten Lankhorst
It's harmless to add support for attributes we don't support, since they require a feature enabled for them to affect something. As long as they aren't enabled, nothing happens. This enables support for custom colorspaces and background colors. Signed-off-by: Maarten Lankhorst

[Mesa-dev] [PATCH 3/3] vdpau: Add background surface support

2011-12-19 Thread Maarten Lankhorst
Sets rgba layer as zeroth layer if a custom background_surface is specified. Signed-off-by: Maarten Lankhorst m.b.lankho...@gmail.com --- Can be applied without dependency on previous 2 patches in this series src/gallium/state_trackers/vdpau/mixer.c | 11 ++- 1 files changed, 10

Re: [Mesa-dev] [PATCH] glx: block attempt to swapbuffer on pixmap. (v2)

2011-12-19 Thread Dave Airlie
On Wed, Dec 7, 2011 at 6:32 PM, Eric Anholt e...@anholt.net wrote: On Wed,  7 Dec 2011 10:24:09 +, Dave Airlie airl...@gmail.com wrote: From: Dave Airlie airl...@redhat.com This keeps track of the creation process and stores a drawable type, it then blocks DRI2 from getting called if the

[Mesa-dev] [PATCH 1/2] softpipe: fix shadow 2d texture array sampling

2011-12-19 Thread Dave Airlie
From: Dave Airlie airl...@redhat.com The 4th texcoord is used in this case for the comparison. This fixes piglit glsl-fs-shadow2DArray* on softpipe. Signed-off-by: Dave Airlie airl...@redhat.com --- src/gallium/auxiliary/tgsi/tgsi_exec.c | 11 ++-

[Mesa-dev] [PATCH 2/2] softpipe: fix shadow1d tests.

2011-12-19 Thread Dave Airlie
From: Dave Airlie airl...@redhat.com This fixes the piglit glsl-1.10 shadow1D related tests. Signed-off-by: Dave Airlie airl...@redhat.com --- src/gallium/auxiliary/tgsi/tgsi_exec.c | 14 +- 1 files changed, 13 insertions(+), 1 deletions(-) diff --git

Re: [Mesa-dev] [PATCH 5/6] vl: Remove most members of pipe_video_decoder

2011-12-19 Thread Andy Furniss
Maarten Lankhorst wrote: Looks like I made the checking a bit too paranoid, causing it to not always decode last few macroblocks because of fear of reaching end of stream.. Does this work? I removed a few paranoid asserts, and if performance is still bad, I'll alter the patch to swap between

Re: [Mesa-dev] [PATCH 1/3] vdpau: Add support for parameters

2011-12-19 Thread Christian König
Committed all three with just a minor change: removed check_video_surface in favor of doing the checks directly in the render function. On 19.12.2011 10:10, Maarten Lankhorst wrote: Currently only validating, since nothing else can be done with it yet Signed-off-by: Maarten

[Mesa-dev] [Bug 43949] New: OSMesa does not work with 565 pixel format

2011-12-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=43949 Bug #: 43949 Summary: OSMesa does not work with 565 pixel format Classification: Unclassified Product: Mesa Version: 7.11 Platform: All OS/Version: All Status: NEW

Re: [Mesa-dev] [PATCH 1/2] linker: fix strdup memory leak

2011-12-19 Thread Pekka Paalanen
On Fri, 16 Dec 2011 10:46:11 -0800 Ian Romanick i...@freedesktop.org wrote: On 12/14/2011 11:26 PM, Pekka Paalanen wrote: string_to_uint_map::put() already does a strdup() for the key argument, so we leak the memory allocated by strdup() in link_uniforms.cpp. Remove the extra strdup(),

Re: [Mesa-dev] [PATCH 2/2] softpipe: fix shadow1d tests.

2011-12-19 Thread Brian Paul
On 12/19/2011 04:53 AM, Dave Airlie wrote: From: Dave Airlieairl...@redhat.com This fixes the piglit glsl-1.10 shadow1D related tests. Signed-off-by: Dave Airlieairl...@redhat.com --- src/gallium/auxiliary/tgsi/tgsi_exec.c | 14 +- 1 files changed, 13 insertions(+), 1

Re: [Mesa-dev] [PATCH 1/2] softpipe: fix shadow 2d texture array sampling

2011-12-19 Thread Brian Paul
On 12/19/2011 04:53 AM, Dave Airlie wrote: From: Dave Airlieairl...@redhat.com The 4th texcoord is used in this case for the comparison. This fixes piglit glsl-fs-shadow2DArray* on softpipe. Signed-off-by: Dave Airlieairl...@redhat.com --- src/gallium/auxiliary/tgsi/tgsi_exec.c | 11

[Mesa-dev] [Bug 43949] OSMesa does not work with 565 pixel format

2011-12-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=43949 Brian Paul bri...@vmware.com changed: What|Removed |Added Status|NEW |RESOLVED

[Mesa-dev] [Bug 43896] Mesa assembly breaks Super Meat Boy, Shank

2011-12-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=43896 Brian Paul bri...@vmware.com changed: What|Removed |Added Status|NEW |RESOLVED

Re: [Mesa-dev] [PATCH 2/2] st/mesa: add support for gl_ClipDistance

2011-12-19 Thread Brian Paul
On 12/17/2011 03:15 PM, Bryan Cain wrote: --- src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 49 +--- src/mesa/state_tracker/st_program.c| 18 ++ 2 files changed, 62 insertions(+), 5 deletions(-) diff --git

Re: [Mesa-dev] [PATCH 1/2] gallium: add support for clip distances

2011-12-19 Thread Brian Paul
On 12/17/2011 03:15 PM, Bryan Cain wrote: --- src/gallium/auxiliary/tgsi/tgsi_dump.c |3 +- src/gallium/auxiliary/tgsi/tgsi_text.c |3 +- src/gallium/auxiliary/tgsi/tgsi_ureg.c | 36 +--- src/gallium/auxiliary/tgsi/tgsi_ureg.h |6

Re: [Mesa-dev] [PATCH] gallium: remove PIPE_CAP_MAX_STREAM_OUTPUT_SEPARATE_ATTRIBS

2011-12-19 Thread Brian Paul
On 12/17/2011 01:09 PM, Marek Olšák wrote: It's the same as PIPE_CAP_MAX_STREAM_OUTPUT_BUFFERS. --- src/gallium/drivers/nvc0/nvc0_screen.c |2 -- src/gallium/drivers/r300/r300_screen.c |1 - src/gallium/drivers/r600/r600_pipe.c |1 - src/gallium/include/pipe/p_defines.h |

Re: [Mesa-dev] [PATCH] glx: block attempt to swapbuffer on pixmap. (v2)

2011-12-19 Thread Adam Jackson
On Mon, 2011-12-19 at 09:40 +, Dave Airlie wrote: On Wed, Dec 7, 2011 at 6:32 PM, Eric Anholt e...@anholt.net wrote: On Wed, 7 Dec 2011 10:24:09 +, Dave Airlie airl...@gmail.com wrote: From: Dave Airlie airl...@redhat.com This keeps track of the creation process and stores a

Re: [Mesa-dev] [PATCH] st/mesa: DrawTFB should use the vertex count from the last call of EndTFB

2011-12-19 Thread Brian Paul
On 12/17/2011 06:41 AM, Marek Olšák wrote: From ARB_transform_feedback2: ... the vertex count used for the rendering operation is set by the previous EndTransformFeedback command. --- src/mesa/state_tracker/st_cb_xformfb.c | 53 +-- 1 files changed, 42

Re: [Mesa-dev] [PATCH 2/2] i965 gen6: Implement rasterizer discard.

2011-12-19 Thread Paul Berry
On 16 December 2011 19:53, Kenneth Graunke kenn...@whitecape.org wrote: On 12/14/2011 11:59 AM, Paul Berry wrote: This patch enables rasterizer discard functionality (a part of transform feedback) in Gen6, by generating an alternate GS program when rasterizer discard is active. Instead of

[Mesa-dev] [PATCH] st/mesa: use SINT/UINT formats for VertexAttribIPointer

2011-12-19 Thread Christoph Bumiller
--- src/mesa/state_tracker/st_draw.c | 63 +++-- src/mesa/state_tracker/st_draw.h |2 +- src/mesa/state_tracker/st_draw_feedback.c |3 +- 3 files changed, 62 insertions(+), 6 deletions(-) diff --git a/src/mesa/state_tracker/st_draw.c

[Mesa-dev] [PATCH] vl: Use pipe clear_render_target instead of util_clear_render_target

2011-12-19 Thread Maarten Lankhorst
Mapping to software and uploading again clearing is killing performance. Signed-off-by: Maarten Lankhorst m.b.lankho...@gmail.com --- src/gallium/auxiliary/vl/vl_compositor.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/gallium/auxiliary/vl/vl_compositor.c

Re: [Mesa-dev] [PATCH] glx: block attempt to swapbuffer on pixmap. (v2)

2011-12-19 Thread Michel Dänzer
On Mon, 2011-12-19 at 10:14 -0500, Adam Jackson wrote: On Mon, 2011-12-19 at 09:40 +, Dave Airlie wrote: On Wed, Dec 7, 2011 at 6:32 PM, Eric Anholt e...@anholt.net wrote: On Wed, 7 Dec 2011 10:24:09 +, Dave Airlie airl...@gmail.com wrote: From: Dave Airlie airl...@redhat.com

Re: [Mesa-dev] vertex array regression

2011-12-19 Thread Brian Paul
On 12/16/2011 11:28 AM, Mathias Fröhlich wrote: Brian, On Thursday, December 15, 2011 22:36:24 you wrote: I found the problem. It's this chunk in vbo_context.c: [...] For fixed function, the point is to simply place the per-vertex material attributes in the generic attribute arrays. There

[Mesa-dev] [PATCH 2/2] gallium/draw: fix two side handling

2011-12-19 Thread Dave Airlie
From: Dave Airlie airl...@redhat.com The previous fix linked the vertex/fragment shader handling in softpipe for the unspecified front color output case, but specified back color case. However in that case we were doing a copy from back to non-existant front, this code checks we have existant

[Mesa-dev] softpipe two sided fixes

2011-12-19 Thread Dave Airlie
These two patches fix 13 piglit tests in softpipe, GL2 vertex-program-two-side and glsl-1.10 interpolation tests. I'm not 100% sure that my fixes are the correct way to fix the problem, but I'd probably need some direction if someone knows better, I'm not entirely happy that the fix is in two

[Mesa-dev] [PATCH 1/2] softpipe: try and use back color for a slot if color fails.

2011-12-19 Thread Dave Airlie
From: Dave Airlie airl...@redhat.com In the case where a front and back output are specified, the draw code will copy the back output into the front color slot and everything is happy. However if no front is specified then the draw code will do a bad copy (separate patch), but also the frag

[Mesa-dev] [PATCH] tgsi: update documents with some info on texture lookup

2011-12-19 Thread Dave Airlie
From: Dave Airlie airl...@redhat.com this mentions which channels are used for slice and depth comparison values. Signed-off-by: Dave Airlie airl...@redhat.com --- src/gallium/docs/source/tgsi.rst | 11 +++ 1 files changed, 11 insertions(+), 0 deletions(-) diff --git

Re: [Mesa-dev] [PATCH 2/2] softpipe: fix shadow1d tests.

2011-12-19 Thread Dave Airlie
That looks better.  Would you mind checking that the TGSI docs properly describe which coordinate components are used for array indexing, shadow distance, etc. I've sent a tgsi doc update, not really sure how we plan on handling, float texture (samplerCubeShadow sampler, vec4 P [, float

[Mesa-dev] softpipe color interpolation

2011-12-19 Thread Dave Airlie
Hi guys, So we have some piglit tests generated_tests/spec/glsl-1.10/execution/interpolation/interpolation-none-gl_FrontColor-smooth-none.shader_test that piglit fails This seems to be due to its linear interpolation not producing the correct answers compared to the hardware, on the rendered

Re: [Mesa-dev] [PATCH] glx: block attempt to swapbuffer on pixmap. (v2)

2011-12-19 Thread Adam Jackson
On Mon, 2011-12-19 at 16:45 +0100, Michel Dänzer wrote: On Mon, 2011-12-19 at 10:14 -0500, Adam Jackson wrote: The server is the only thing that knows how to handle this scenario, and it _can_ get this request, so you have to fix it there anyway. Actually no, the DRI2 code in the server

Re: [Mesa-dev] [PATCH] tgsi: update documents with some info on texture lookup

2011-12-19 Thread Brian Paul
On 12/19/2011 09:40 AM, Dave Airlie wrote: From: Dave Airlieairl...@redhat.com this mentions which channels are used for slice and depth comparison values. Signed-off-by: Dave Airlieairl...@redhat.com --- src/gallium/docs/source/tgsi.rst | 11 +++ 1 files changed, 11

Re: [Mesa-dev] softpipe color interpolation

2011-12-19 Thread Brian Paul
On 12/19/2011 10:10 AM, Dave Airlie wrote: Hi guys, So we have some piglit tests generated_tests/spec/glsl-1.10/execution/interpolation/interpolation-none-gl_FrontColor-smooth-none.shader_test that piglit fails This seems to be due to its linear interpolation not producing the correct answers

Re: [Mesa-dev] [PATCH 2/2] gallium/draw: fix two side handling

2011-12-19 Thread Brian Paul
On 12/19/2011 09:29 AM, Dave Airlie wrote: From: Dave Airlieairl...@redhat.com The previous fix linked the vertex/fragment shader handling in softpipe for the unspecified front color output case, but specified back color case. However in that case we were doing a copy from back to non-existant

Re: [Mesa-dev] [PATCH 1/2] softpipe: try and use back color for a slot if color fails.

2011-12-19 Thread Brian Paul
On 12/19/2011 09:29 AM, Dave Airlie wrote: From: Dave Airlieairl...@redhat.com In the case where a front and back output are specified, the draw code will copy the back output into the front color slot and everything is happy. However if no front is specified then the draw code will do a bad

[Mesa-dev] [PATCH] Fix compilation on cygwin after commit 762c9766c93697af8d7fbaa729aed118789dbe8e

2011-12-19 Thread Jon TURNEY
Fix compilation on cygwin after commit 762c9766c93697af8d7fbaa729aed118789dbe8e Use VERT_ATTRIB_* indexed array in gl_array_object added the first non-driver use of ffsll(), which exposes the fact that this isn't provided on cygwin. Found by tinderbox, see [1] [1]

Re: [Mesa-dev] [PATCH 1/2] softpipe: try and use back color for a slot if color fails.

2011-12-19 Thread Dave Airlie
On Mon, Dec 19, 2011 at 5:39 PM, Brian Paul bri...@vmware.com wrote: On 12/19/2011 09:29 AM, Dave Airlie wrote: From: Dave Airlieairl...@redhat.com In the case where a front and back output are specified, the draw code will copy the back output into the front color slot and everything is

Re: [Mesa-dev] softpipe color interpolation

2011-12-19 Thread Christoph Bumiller
On 19.12.2011 18:10, Dave Airlie wrote: Hi guys, So we have some piglit tests generated_tests/spec/glsl-1.10/execution/interpolation/interpolation-none-gl_FrontColor-smooth-none.shader_test that piglit fails This seems to be due to its linear interpolation not producing the correct answers

Re: [Mesa-dev] [PATCH] i965: Implement bounds checking for transform feedback output.

2011-12-19 Thread Paul Berry
On 15 December 2011 15:20, Kenneth Graunke kenn...@whitecape.org wrote: Signed-off-by: Kenneth Graunke kenn...@whitecape.org --- src/mesa/drivers/dri/i965/brw_context.c |1 + src/mesa/drivers/dri/i965/brw_context.h |3 ++ src/mesa/drivers/dri/i965/brw_gs_emit.c | 10

[Mesa-dev] Willing to take Haiku support Patches? (Was: DEATH to old drivers!)

2011-12-19 Thread Alexander von Gluck
Good afternoon! The Haiku OS project (not-for-profit organization, founded in 2001) has found ourselves in a weird spot, we have a working Mesa software render library based on a *heavily* modified Mesa 7.4.4. http://cgit.haiku-os.org/haiku/tree/src/libs/mesa However as you can imagine,

[Mesa-dev] [PATCH] i965: Don't minify depth when setting up cube map miptrees on Gen4.

2011-12-19 Thread Kenneth Graunke
Prior to Ironlake, cube maps were stored as 3D textures. In recent refactoring, we removed a separate layers parameter in favor of using depth. Unfortunately, depth was getting minified, which is only correct for actual 3D textures. Fixes piglit tests: - bugs/crash-cubemap-order -

Re: [Mesa-dev] Willing to take Haiku support Patches? (Was: DEATH to old drivers!)

2011-12-19 Thread Brian Paul
On Mon, Dec 19, 2011 at 11:18 AM, Alexander von Gluck kallis...@unixzen.com wrote: Good afternoon! The Haiku OS project (not-for-profit organization, founded in 2001) has found ourselves in a weird spot, we have a working Mesa software render library based on a *heavily* modified Mesa 7.4.4.

Re: [Mesa-dev] [PATCH] Fix compilation on cygwin after commit 762c9766c93697af8d7fbaa729aed118789dbe8e

2011-12-19 Thread Brian Paul
On 12/19/2011 10:45 AM, Jon TURNEY wrote: Fix compilation on cygwin after commit 762c9766c93697af8d7fbaa729aed118789dbe8e Use VERT_ATTRIB_* indexed array in gl_array_object added the first non-driver use of ffsll(), which exposes the fact that this isn't provided on cygwin. Found by tinderbox,

Re: [Mesa-dev] [PATCH 5/8] i965 gen6: Initial implementation of transform feedback.

2011-12-19 Thread Paul Berry
On 17 December 2011 11:50, Eric Anholt e...@anholt.net wrote: On Tue, 13 Dec 2011 15:35:18 -0800, Paul Berry stereotype...@gmail.com wrote: diff --git a/src/mesa/drivers/dri/i965/brw_gs.c b/src/mesa/drivers/dri/i965/brw_gs.c index f5d5898..c323a73 100644 ---

Re: [Mesa-dev] Willing to take Haiku support Patches? (Was: DEATH to old drivers!)

2011-12-19 Thread Alexander von Gluck
On Mon, 19 Dec 2011 11:44:51 -0700, Brian Paul wrote: On Mon, Dec 19, 2011 at 11:18 AM, Alexander von Gluck kallis...@unixzen.com wrote: Good afternoon! The Haiku OS project (not-for-profit organization, founded in 2001) has found ourselves in a weird spot, we have a working Mesa software

[Mesa-dev] [PATCH v2] i965 gen6: Initial implementation of transform feedback.

2011-12-19 Thread Paul Berry
This patch adds basic transform feedback capability for Gen6 hardware. This consists of several related pieces of functionality: (1) In gen6_sol.c, we set up binding table entries for use by transform feedback. We use one binding table entry per transform feedback varying (this allows us to

[Mesa-dev] [PATCH 01/10] i965: Add missing SIMD4x2 sample_l_c message #defines.

2011-12-19 Thread Kenneth Graunke
Signed-off-by: Kenneth Graunke kenn...@whitecape.org --- src/mesa/drivers/dri/i965/brw_defines.h |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_defines.h b/src/mesa/drivers/dri/i965/brw_defines.h index 0eb7512..1854602 100644 ---

[Mesa-dev] [PATCH 02/10] i965/vs: Implement vec4_visitor::generate_tex().

2011-12-19 Thread Kenneth Graunke
This is the part that takes the vec4_instruction IR and turns it into actual Gen ISA. v2: Add Gen4 messages, don't retype m0 to UW. Signed-off-by: Kenneth Graunke kenn...@whitecape.org --- src/mesa/drivers/dri/i965/brw_vec4.h|4 + src/mesa/drivers/dri/i965/brw_vec4_emit.cpp | 106

[Mesa-dev] [PATCH 03/10] i965/vs: Implement vec4_visitor::visit(ir_texture *).

2011-12-19 Thread Kenneth Graunke
This translates the GLSL compiler's IR into vec4_instruction IR, generating code to load coordinates, LOD info, shadow comparitors, and so on into the appropriate message registers. It turns out that the SIMD4x2 parameters are identical on Gen 5-7, and the Gen4 code is similar enough that, unlike

[Mesa-dev] [PATCH 04/10] i965/fs: Factor out texture offset bitfield computation.

2011-12-19 Thread Kenneth Graunke
We'll want to reuse this for the VS, and it's complex enough that I'd rather not cut and paste it. Signed-off-by: Kenneth Graunke kenn...@whitecape.org Reviewed-by: Eric Anholt e...@anholt.net --- src/mesa/drivers/dri/i965/brw_fs_visitor.cpp | 19 +--

[Mesa-dev] [PATCH 05/10] i965/vs: Add support for texel offsets.

2011-12-19 Thread Kenneth Graunke
The visit() half computes the values to put in the header based on the IR and simply stuffs that in the vec4_instruction; the emit() half uses this to set up the message header. This works out well since emit() can use brw_reg directly and access individual DWords without kludgery.

[Mesa-dev] [PATCH 06/10] i965/fs: Factor out texturing related data from brw_wm_prog_key.

2011-12-19 Thread Kenneth Graunke
The idea is to reuse this for the VS and (in the future) GS as well. v2: Include yuvtex data since we're not dropping GL_MESA_ycbycr. Signed-off-by: Kenneth Graunke kenn...@whitecape.org Reviewed-by: Eric Anholt e...@anholt.net [v1] --- src/mesa/drivers/dri/i965/brw_fs.cpp |4 +-

[Mesa-dev] [PATCH 08/10] i965/vs: Add texture related data to brw_vs_prog_key.

2011-12-19 Thread Kenneth Graunke
Now that this is all factored out, it's trivial to do. Signed-off-by: Kenneth Graunke kenn...@whitecape.org Reviewed-by: Eric Anholt e...@anholt.net --- src/mesa/drivers/dri/i965/brw_vs.c |8 src/mesa/drivers/dri/i965/brw_vs.h |3 +++ 2 files changed, 11 insertions(+), 0

[Mesa-dev] [PATCH 09/10] i965/vs: Implement EXT_texture_swizzle support for VS texturing.

2011-12-19 Thread Kenneth Graunke
Signed-off-by: Kenneth Graunke kenn...@whitecape.org --- src/mesa/drivers/dri/i965/brw_vec4.h |2 + src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp | 51 +++- 2 files changed, 52 insertions(+), 1 deletions(-) Unchanged from v1 (we decided it worked, but I never

[Mesa-dev] [PATCH 10/10] i965: Advertise our vertex shader texture units.

2011-12-19 Thread Kenneth Graunke
Previously, we advertised 0 VS texture units. Now that we have proper support for using the sampling engine in the VS, we can advertise 16, which is conveniently the number required for OpenGL 3.0. v2: Enable on Gen4. I hacked up my tests to not use flat ivec varyings and they pass.

Re: [Mesa-dev] [PATCH 1/2] egl: move unofficial extensions to eglmesaext.h

2011-12-19 Thread Kenneth Graunke
On 12/19/2011 02:05 AM, Chia-I Wu wrote: From: Chia-I Wu o...@lunarg.com As suggested by Ian in http://lists.freedesktop.org/archives/mesa-dev/2011-December/016035.html Note that eglext.h has to include eglmesaext.h at the end instead of the beginning because some extensions in

Re: [Mesa-dev] [PATCH 5/8] i965 gen6: Initial implementation of transform feedback.

2011-12-19 Thread Paul Berry
On 16 December 2011 19:50, Kenneth Graunke kenn...@whitecape.org wrote: On 12/13/2011 03:35 PM, Paul Berry wrote: [snip] +static void +brw_update_sol_surface(struct brw_context *brw, drm_intel_bo *bo, + uint32_t *out_offset, unsigned num_vector_components, +

Re: [Mesa-dev] vertex array regression

2011-12-19 Thread Mathias Fröhlich
Brian, On Monday, December 19, 2011 17:01:07 you wrote: I still don't get what the purpose of the special mapping of the last four/five elements is all about. Can you explain that? As far as I can see the last ones should not map to anything. The map is used only in fixed function mode. And

Re: [Mesa-dev] [PATCH 1/2] softpipe: try and use back color for a slot if color fails.

2011-12-19 Thread Dave Airlie
On Mon, Dec 19, 2011 at 5:49 PM, Dave Airlie airl...@gmail.com wrote: On Mon, Dec 19, 2011 at 5:39 PM, Brian Paul bri...@vmware.com wrote: On 12/19/2011 09:29 AM, Dave Airlie wrote: From: Dave Airlieairl...@redhat.com In the case where a front and back output are specified, the draw code

[Mesa-dev] [PATCH] mesa: remove stray GL_TEXTURE_1D_ARRAY code in _mesa_store_teximage3d()

2011-12-19 Thread Brian Paul
GL_TEXTURE_1D_ARRAY is never a legal target for glTexImage3D. This was probably copypaste code from the _mesa_store_teximage2d() function above. --- src/mesa/main/texstore.c |5 - 1 files changed, 0 insertions(+), 5 deletions(-) diff --git a/src/mesa/main/texstore.c

Re: [Mesa-dev] [PATCH 5/6] vl: Remove most members of pipe_video_decoder

2011-12-19 Thread Andy Furniss
Maarten Lankhorst wrote: Hey Andy, On 12/19/2011 01:50 PM, Andy Furniss wrote: Maarten Lankhorst wrote: Looks like I made the checking a bit too paranoid, causing it to not always decode last few macroblocks because of fear of reaching end of stream.. Does this work? I removed a few

Re: [Mesa-dev] [PATCH 5/6] vl: Remove most members of pipe_video_decoder

2011-12-19 Thread Andy Furniss
Andy Furniss wrote: I compiled with -O0 but the backtraces are different - maybe there is some randomness. Remembered to attach them this time :-) mplayer: vl/vl_vlc.h:172: vl_vlc_get_vlclbf: Assertion `tbl-length' failed. Program received signal SIGABRT, Aborted. [Switching to Thread

Re: [Mesa-dev] [PATCH 1/2] linker: fix strdup memory leak

2011-12-19 Thread Ian Romanick
On 12/19/2011 05:23 AM, Pekka Paalanen wrote: On Fri, 16 Dec 2011 10:46:11 -0800 Ian Romanicki...@freedesktop.org wrote: On 12/14/2011 11:26 PM, Pekka Paalanen wrote: string_to_uint_map::put() already does a strdup() for the key argument, so we leak the memory allocated by strdup() in

Re: [Mesa-dev] [PATCH 1/2] egl: move unofficial extensions to eglmesaext.h

2011-12-19 Thread Ian Romanick
On 12/19/2011 02:05 AM, Chia-I Wu wrote: From: Chia-I Wuo...@lunarg.com As suggested by Ian in http://lists.freedesktop.org/archives/mesa-dev/2011-December/016035.html Note that eglext.h has to include eglmesaext.h at the end instead of the beginning because some extensions in eglmesaext.h

Re: [Mesa-dev] [PATCH 2/2] egl: update headers

2011-12-19 Thread Ian Romanick
On 12/19/2011 02:05 AM, Chia-I Wu wrote: From: Chia-I Wuo...@lunarg.com Update to revision 15052. EGL_MESA_drm_image is now official. But apparently we have our own extension to it and we need this in eglmesaext.h: #ifdef EGL_MESA_drm_image /* Mesa's extension to EGL_MESA_drm_image...

Re: [Mesa-dev] [PATCH] i965: Don't minify depth when setting up cube map miptrees on Gen4.

2011-12-19 Thread Eric Anholt
On Mon, 19 Dec 2011 10:38:38 -0800, Kenneth Graunke kenn...@whitecape.org wrote: Prior to Ironlake, cube maps were stored as 3D textures. In recent refactoring, we removed a separate layers parameter in favor of using depth. Unfortunately, depth was getting minified, which is only correct

Re: [Mesa-dev] [PATCH 5/6] vl: Remove most members of pipe_video_decoder

2011-12-19 Thread Maarten Lankhorst
Hey Andy, On 12/19/2011 10:17 PM, Andy Furniss wrote: Andy Furniss wrote: I compiled with -O0 but the backtraces are different - maybe there is some randomness. Remembered to attach them this time :-) Thanks, but nothing seems to be obviously wrong there. I don't suppose you could find a

Re: [Mesa-dev] [PATCH] mesa: remove stray GL_TEXTURE_1D_ARRAY code in _mesa_store_teximage3d()

2011-12-19 Thread Eric Anholt
On Mon, 19 Dec 2011 13:47:42 -0700, Brian Paul bri...@vmware.com wrote: GL_TEXTURE_1D_ARRAY is never a legal target for glTexImage3D. This was probably copypaste code from the _mesa_store_teximage2d() function above. Radeon and intel use texstore3d for all our TexImage* storage. Though it

Re: [Mesa-dev] [PATCH] mesa: remove stray GL_TEXTURE_1D_ARRAY code in _mesa_store_teximage3d()

2011-12-19 Thread Brian Paul
On 12/19/2011 02:56 PM, Eric Anholt wrote: On Mon, 19 Dec 2011 13:47:42 -0700, Brian Paulbri...@vmware.com wrote: GL_TEXTURE_1D_ARRAY is never a legal target for glTexImage3D. This was probably copypaste code from the _mesa_store_teximage2d() function above. Radeon and intel use texstore3d

[Mesa-dev] [PATCH] Fix build with LLVM = r145623.

2011-12-19 Thread Johannes Obermayr
This is a workaround for https://bugs.freedesktop.org/show_bug.cgi?id=43861. Actually the issue which makes -pedantic failing should be solved. --- configure.ac |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/configure.ac b/configure.ac index a4943e1..8e809b9 100644 ---

Re: [Mesa-dev] [PATCH] Fix build with LLVM = r145623.

2011-12-19 Thread Vinson Lee
-Original Message- This is a workaround for https://bugs.freedesktop.org/show_bug.cgi?id=43861. Actually the issue which makes -pedantic failing should be solved. --- configure.ac |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/configure.ac

Re: [Mesa-dev] [PATCH 5/6] vl: Remove most members of pipe_video_decoder

2011-12-19 Thread Andy Furniss
Maarten Lankhorst wrote: Hey Andy, On 12/19/2011 10:17 PM, Andy Furniss wrote: Andy Furniss wrote: I compiled with -O0 but the backtraces are different - maybe there is some randomness. Remembered to attach them this time :-) Thanks, but nothing seems to be obviously wrong there. I don't

Re: [Mesa-dev] [PATCH 01/10] i965: Add missing SIMD4x2 sample_l_c message #defines.

2011-12-19 Thread Ian Romanick
On 12/19/2011 11:09 AM, Kenneth Graunke wrote: Signed-off-by: Kenneth Graunkekenn...@whitecape.org All but patch 03/10 are: Reviewed-by: Ian Romanick ian.d.roman...@intel.com I don't know the code well enough to give a credible R-b for 3. --- src/mesa/drivers/dri/i965/brw_defines.h |

[Mesa-dev] [PATCH 1/2] glx: Deliver an xlib style error to the application from an XCB error

2011-12-19 Thread Ian Romanick
From: Ian Romanick ian.d.roman...@intel.com Signed-off-by: Ian Romanick ian.d.roman...@intel.com --- src/glx/glx_error.c | 19 +++ src/glx/glx_error.h |4 2 files changed, 23 insertions(+), 0 deletions(-) diff --git a/src/glx/glx_error.c b/src/glx/glx_error.c index

[Mesa-dev] [PATCH 2/2] glx: Propagate the glXIsDirect protocol error back to the application

2011-12-19 Thread Ian Romanick
From: Ian Romanick ian.d.roman...@intel.com If the server returned BadContext, the error would just get droped on the floor. Fixes the piglit test glx-import-context-single-process NOTE: This is a candidate for the 7.11 branch, but it also requires the previous patch. Signed-off-by: Ian

[Mesa-dev] [PATCH 0/6] i965 gen6: Transform feedback queries

2011-12-19 Thread Paul Berry
This patch series adds support for the transform feedback queries (PRIMITIVES_GENERATED and TRANSFORM_FEEDBACK_PRIMITIVES_WRITTEN) for i965 Gen6. For now, the queries are implemented using software counters, since we don't yet have the necessary kernel support to use the hardware counters. (The

[Mesa-dev] [PATCH 1/6] mesa: Add count_tessellated_primitives() function.

2011-12-19 Thread Paul Berry
This function computes the number of primitives that will be generated when the given drawing operation is performed. It accounts for the tessellation that is performed on line strips, line loops, triangle strips, triangle fans, quads, quad strips, and polygons, so it is suitable for implementing

[Mesa-dev] [PATCH 2/6] mesa: Add a function to query whether a meta-op is in progress.

2011-12-19 Thread Paul Berry
This is needed by i965 to ensure that transform feedback counters are not incremented during meta-ops. --- src/mesa/drivers/common/meta.c | 10 ++ src/mesa/drivers/common/meta.h |3 +++ 2 files changed, 13 insertions(+), 0 deletions(-) diff --git a/src/mesa/drivers/common/meta.c

[Mesa-dev] [PATCH 3/6] i965 gen6: Ensure correct transform feedback indices on new batch.

2011-12-19 Thread Paul Berry
We don't currently have kernel support for saving GPU registers on a context switch, so if multiple processes are performing transform feedback at the same time, their SVBI registers will interfere with each other. To avoid this situation, we keep a software shadow of the state of the SVBI 0

[Mesa-dev] [PATCH 4/6] i965: Convert if/else to switch statements in brw_queryobj.c

2011-12-19 Thread Paul Berry
Previously, i965 only supported two query types: GL_TIME_ELAPSED_EXT and GL_SAMPLES_PASSED_ARB, and it distinguished between the two using if/else statements that compared query-Base.Target to GL_TIME_ELAPSED_EXT. This patch changes the if/else statements to switch statements so that we can add

[Mesa-dev] [PATCH 5/6] i965 gen6: Implement transform feedback queries.

2011-12-19 Thread Paul Berry
This patch adds software-based PRIMITIVES_GENERATED and TRANSFORM_FEEDBACK_PRIMITIVES_WRITTEN queries that work by keeping track of the number of primitives that are sent down the pipeline, and adjusting as necessary to account for the way each primitive type is tessellated. In the long run we'll

[Mesa-dev] [PATCH 6/6] i965 gen6: Turn on transform feedback extension unconditionally.

2011-12-19 Thread Paul Berry
Previously, we only enabled transform feedback when MESA_GL_VERSION_OVERRIDE was 3.0 or greater, since transform feedback support was not completely finished, so it didn't make sense to advertise support for it unless absolutely necessary. Now that transform feedback is fully implemented on gen6,

Re: [Mesa-dev] vertex array regression

2011-12-19 Thread Marek Olšák
2011/12/19 Mathias Fröhlich mathias.froehl...@gmx.net: Brian, On Monday, December 19, 2011 17:01:07 you wrote: I still don't get what the purpose of the special mapping of the last four/five elements is all about.  Can you explain that? As far as I can see the last ones should not map to

Re: [Mesa-dev] [PATCH 0/6] i965 gen6: Transform feedback queries

2011-12-19 Thread Kenneth Graunke
On 12/19/2011 04:18 PM, Paul Berry wrote: [snip] - [PATCH 0/8] i965 gen6: Initial implementation of transform feedback. - [PATCH] i965: Implement bounds checking for transform feedback output. - [PATCH 2/2] i965 gen6: Implement rasterizer discard. If you want to see this patch series in its

Re: [Mesa-dev] [PATCH 1/2] mesa: Set the correct ctx-NewState bitfield for rasterizer discard.

2011-12-19 Thread Marek Olšák
On Thu, Dec 15, 2011 at 7:21 PM, Paul Berry stereotype...@gmail.com wrote: On 15 December 2011 08:02, Eric Anholt e...@anholt.net wrote: On Thu, 15 Dec 2011 00:00:49 +0100, Marek Olšák mar...@gmail.com wrote: On Wed, Dec 14, 2011 at 11:25 PM, Paul Berry stereotype...@gmail.com wrote: (c)

[Mesa-dev] [PATCH] mesa: consolidate texstore functions

2011-12-19 Thread Brian Paul
From: Brian Paul bri...@vmware.com The code for storing 1D, 2D and 3D tex images (whole or sub-images) was all pretty similar. This consolidates those six paths. --- src/mesa/main/texstore.c | 475 ++ 1 files changed, 144 insertions(+), 331

Re: [Mesa-dev] vertex array regression

2011-12-19 Thread Mathias Fröhlich
Marek, On Tuesday, December 20, 2011 01:40:46 Marek Olšák wrote: The problem back in March and earlier was that the vertex array state was completely recomputed for each draw call even if the user did not change any state at all! There was the validation in the vbo module and then in

Re: [Mesa-dev] [PATCH 06/13] glx: Make __glXSendError available in non-Apple builds

2011-12-19 Thread Jeremy Huddleston
6, 7, and 13 look good to me, but I haven't tested them yet. Reviewed-by: Jeremy Huddleston jerem...@apple.com On Dec 16, 2011, at 11:55 AM, Ian Romanick wrote: From: Ian Romanick ian.d.roman...@intel.com Signed-off-by: Ian Romanick ian.d.roman...@intel.com Cc: Jeremy Huddleston

Re: [Mesa-dev] [PATCH 5/6] vl: Remove most members of pipe_video_decoder

2011-12-19 Thread Maarten Lankhorst
On 12/19/2011 11:46 PM, Andy Furniss wrote: Maarten Lankhorst wrote: Hey Andy, On 12/19/2011 10:17 PM, Andy Furniss wrote: Andy Furniss wrote: I compiled with -O0 but the backtraces are different - maybe there is some randomness. Remembered to attach them this time :-) Thanks, but

Re: [Mesa-dev] [PATCH 1/2] linker: fix strdup memory leak

2011-12-19 Thread Pekka Paalanen
On Mon, 19 Dec 2011 11:02:31 -0800 Kenneth Graunke kenn...@whitecape.org wrote: On 12/19/2011 05:23 AM, Pekka Paalanen wrote: On Fri, 16 Dec 2011 10:46:11 -0800 Ian Romanick i...@freedesktop.org wrote: On 12/14/2011 11:26 PM, Pekka Paalanen wrote: string_to_uint_map::put() already