Re: [Mesa-dev] [PATCH v2 5/6] i965/vec4: Adjust spilling cost for consecutive instructions

2015-07-30 Thread Iago Toral
On Thu, 2015-07-30 at 16:33 +0300, Francisco Jerez wrote: > Francisco Jerez writes: > > > Iago Toral Quiroga writes: > > > >> Previous patches made it so that we do not need to unspill the same vgrf > >> with every instruction as long as these instructions come right after > >> the register was

Re: [Mesa-dev] [PATCH v2 3/6] i965/vec4: Don't emit scratch reads for a spilled register we have just written

2015-07-30 Thread Iago Toral
On Thu, 2015-07-30 at 17:14 +0300, Francisco Jerez wrote: > Francisco Jerez writes: > > > Iago Toral Quiroga writes: > > > >> When we have code such as this: > >> > >> mov vgrf1.0.x:F, vgrf2.:F > >> mov vgrf3.0.x:F, vgrf1.:F > >> ... > >> mov vgrf3.0.x:F, vgrf1.:F > >> > >> And vgrf1

Re: [Mesa-dev] [PATCH v4 (part2) 52/56] mesa: Add getters for the GL_ARB_shader_storage_buffer_object max constants

2015-07-30 Thread Tapani Pälli
On 07/24/2015 08:30 AM, Samuel Iglesias Gonsálvez wrote: On 23/07/15 08:42, Samuel Iglesias Gonsalvez wrote: v2: - Add tessellation shader constants support Signed-off-by: Samuel Iglesias Gonsalvez --- src/mesa/main/get.c | 1 + src/mesa/main/get_hash_params.py | 14 +++

Re: [Mesa-dev] [PATCH v3 (part2) 27/56] nir: Implement __intrinsic_store_ssbo

2015-07-30 Thread Jordan Justen
On 2015-07-14 00:46:29, Iago Toral Quiroga wrote: > --- > diff --git a/src/glsl/nir/nir_intrinsics.h b/src/glsl/nir/nir_intrinsics.h > index f264f55..83eeecd 100644 > --- a/src/glsl/nir/nir_intrinsics.h > +++ b/src/glsl/nir/nir_intrinsics.h > @@ -176,12 +176,12 @@ LOAD(input, 0, NIR_INTRINSIC_CAN_E

Re: [Mesa-dev] [PATCH v3 (part2) 49/56] main: Add SHADER_STORAGE_BLOCK and BUFFER_VARIABLE support for ARB_program_interface_query

2015-07-30 Thread Tapani Pälli
On 07/14/2015 10:46 AM, Iago Toral Quiroga wrote: From: Samuel Iglesias Gonsalvez Including TOP_LEVEL_ARRAY_SIZE and TOP_LEVEL_ARRAY_STRIDE queries. Signed-off-by: Samuel Iglesias Gonsalvez --- src/glsl/ir_uniform.h| 5 + src/glsl/link_uniforms.cpp | 17 ++- src/glsl

Re: [Mesa-dev] [PATCH v2 2/6] i965/vec4: Remove checks for reladdr when checking for spillable registers

2015-07-30 Thread Iago Toral
On Thu, 2015-07-30 at 16:27 +0300, Francisco Jerez wrote: > Iago Toral Quiroga writes: > > > In theory, GRF array access should have been moved to scratch by the time > > we got here, so this should never happen. A full piglit run forcing > > spilling of all registers seems to confirm this. The F

Re: [Mesa-dev] [PATCH 1/3] [v2] i965/skl: Add production thread counts and URB size

2015-07-30 Thread Jordan Justen
Series Reviewed-by: Jordan Justen On 2015-07-30 20:16:20, Ben Widawsky wrote: > This patch adjusts the SKL values to the best known values we have. > > v2: Remove HS/DS/CS fields. Adding this makes most sense to add to the > GEN9_FEATURES macro, however, doing that would require updating BXT val

Re: [Mesa-dev] [PATCH] glsl: when generating out/inout parameter fixups, do indexing before the call

2015-07-30 Thread Ben Widawsky
On Fri, Jul 31, 2015 at 04:37:16PM +1200, Chris Forbes wrote: > If the indexing expression involves anything modified during the call, > the fixup code to copy back after the call would use the new values. > > This fixes the cases where the first expression node encountered is > ir_binop_vector_ex

[Mesa-dev] [PATCH] glsl: when generating out/inout parameter fixups, do indexing before the call

2015-07-30 Thread Chris Forbes
If the indexing expression involves anything modified during the call, the fixup code to copy back after the call would use the new values. This fixes the cases where the first expression node encountered is ir_binop_vector_extract, fixing the piglits: * shaders@out-parameter-indexing@vs-inout-in

Re: [Mesa-dev] [PATCH] radeonsi: copy *8_SNORM bits exactly in resource_copy_region

2015-07-30 Thread Michel Dänzer
On 31.07.2015 01:29, Marek Olšák wrote: > From: Marek Olšák > > Disabling the FP16 mode didn't help. > > If needed, we can use this trick for blits too, but not for scaled blits. > > + 4 piglits > --- > src/gallium/drivers/radeonsi/si_blit.c | 4 +++- > 1 file changed, 3 insertions(+), 1 delet

Re: [Mesa-dev] [PATCH] r600, compute: force tiling on 2D and 3D texture compute resources

2015-07-30 Thread Michel Dänzer
On 31.07.2015 07:06, Zoltan Gilian wrote: > To circumvent a problem occuring when LINEAR_ALIGNED array mode is > selected on a TEXTURE_2D RAT. > This configuration causes MEM_RAT STORE_TYPED to write to incorrect > locations. [...] > @@ -715,10 +716,15 @@ static unsigned r600_choose_tiling(struct

[Mesa-dev] [PATCH 2/3] i965/bxt: Use more conservative thread counts

2015-07-30 Thread Ben Widawsky
Since we really do not know what may occur in the future, pick a more conservative value for thread counts until we know better what values are correct. As far as I can tell, the old values will work fine, but some of the registers seem to indicate that going even lower is possible and the purpose

[Mesa-dev] [PATCH 1/3] [v2] i965/skl: Add production thread counts and URB size

2015-07-30 Thread Ben Widawsky
This patch adjusts the SKL values to the best known values we have. v2: Remove HS/DS/CS fields. Adding this makes most sense to add to the GEN9_FEATURES macro, however, doing that would require updating BXT values, and Jordan requested I not do that. Conveniently, this request makes a lot of sense

[Mesa-dev] [PATCH 3/3] i965/gen9: Add hs, ds, and cs thread + urb info

2015-07-30 Thread Ben Widawsky
For SKL: These are the production values. For BXT: These are low estimates to enable platforms. This patch was originally part of i965/skl: Add production thread counts and URB size but was split out at Jordan's request (which I found to be reasonable). Note on stable inclusion: 10.6 does not ca

Re: [Mesa-dev] [PATCH] r600: Remove assert that not general in some stream instr's

2015-07-30 Thread Dave Airlie
seems like one I wrote already.. http://lists.freedesktop.org/archives/mesa-dev/2015-July/088404.html Dave. On 31 July 2015 at 12:42, Edward O'Callaghan wrote: > Don't trigger assert on some stream emit instructions. > > Signed-off-by: Edward O'Callaghan > --- > src/gallium/drivers/r600/sb/sb_

[Mesa-dev] [PATCH] r600: Remove assert that not general in some stream instr's

2015-07-30 Thread Edward O'Callaghan
Don't trigger assert on some stream emit instructions. Signed-off-by: Edward O'Callaghan --- src/gallium/drivers/r600/sb/sb_bc_finalize.cpp | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/gallium/drivers/r600/sb/sb_bc_finalize.cpp b/src/gallium/drivers/r600/sb/sb_bc_finalize.cpp index

[Mesa-dev] [PATCH/RFC] Minor assert fix

2015-07-30 Thread Edward O'Callaghan
I believe this assert isn't vaild in generality of possible stream emit instructions out the sb backend finalizer. Edward O'Callaghan (1): r600: Remove assert that not general in some stream instr's src/gallium/drivers/r600/sb/sb_bc_finalize.cpp | 2 -- 1 file changed, 2 deletions(-) -- 2.4.

Re: [Mesa-dev] [PATCH] i965/skl: Add production thread counts and URB size

2015-07-30 Thread Jordan Justen
On 2015-07-29 12:35:24, Ben Widawsky wrote: > This patch adjusts the SKL values to the best known values we have. It also > adds > the missing HS/DS/CS fields. To support this patch I needed to add some > default > values to BXT. Those values are just minimal values which we can use for > enablin

Re: [Mesa-dev] [PATCH 10/20] i965/fs: Implement image load, store and atomic.

2015-07-30 Thread Jason Ekstrand
On Thu, Jul 23, 2015 at 4:38 AM, Francisco Jerez wrote: > Jason Ekstrand writes: > >> This all looks correct as far as I can tell. However, I'm very >> concerned about the number of checks such as >> has_matching_typed_format() that are built-in to the compiler (via >> surface_builder) where we

[Mesa-dev] XDC2015 - Travel sponsorship

2015-07-30 Thread Martin Peres
Hello everyone, We are 1.5 months away from XDC and 20 days away from the proposals deadline[1]! If you did not manage to secure funding from your company but still think you could benefit the community by giving a talk, we encourage you to send an email to the board of X.Org with your talk

Re: [Mesa-dev] i965 implementation of the ARB_shader_image_load_store built-ins. (v4)

2015-07-30 Thread Jason Ekstrand
Curro, What are we still wainting on for the image_load_store extension? I think I've given you R-B's on all but one or two of the compiler patches. Is the state setup stuff reviewed? Is there anything else that needs review? --Jason On Thu, Jul 23, 2015 at 6:58 AM, Francisco Jerez wrote: > Ja

Re: [Mesa-dev] [PATCHv2 18/20] i965/fs: Translate image load, store and atomic NIR intrinsics.

2015-07-30 Thread Jason Ekstrand
Reviewed-by: Jason Ekstrand On Thu, Jul 23, 2015 at 10:31 AM, Francisco Jerez wrote: > v2: Move array coordinate workaround into the surface builder. > --- > src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 106 > +++ > 1 file changed, 106 insertions(+) > > diff --git a/s

Re: [Mesa-dev] [PATCHv4 09/20] i965/fs: Import image format conversion primitives.

2015-07-30 Thread Jason Ekstrand
Reviewed-by: Jason Ekstrand On Thu, Jul 23, 2015 at 10:30 AM, Francisco Jerez wrote: > Define bitfield packing, unpacking and type conversion operations in > terms of which the image format conversion code will be implemented. > These don't directly know about image formats: The packing and > un

Re: [Mesa-dev] [PATCH] i965/fs: Add a very basic validation pass

2015-07-30 Thread Matt Turner
On Thu, Jul 30, 2015 at 3:42 PM, Jason Ekstrand wrote: > Currently the validation pass only validates that regs_read and > regs_written are consistent with the sizes of VGRF's. We can add more as > we find it to be useful. > --- > src/mesa/drivers/dri/i965/Makefile.sources| 1 + > src/mesa/

Re: [Mesa-dev] [PATCH 3/3] st/mesa: implement DrawTransformFeedbackStream

2015-07-30 Thread Samuel Pitoiset
On 07/30/2015 04:26 PM, Marek Olšák wrote: From: Marek Olšák --- src/mesa/state_tracker/st_cb_xformfb.c | 58 ++ src/mesa/state_tracker/st_cb_xformfb.h | 2 +- src/mesa/state_tracker/st_draw.c | 2 +- 3 files changed, 33 insertions(+), 29 deletions

[Mesa-dev] [PATCH] i965/fs: Add a very basic validation pass

2015-07-30 Thread Jason Ekstrand
Currently the validation pass only validates that regs_read and regs_written are consistent with the sizes of VGRF's. We can add more as we find it to be useful. --- src/mesa/drivers/dri/i965/Makefile.sources| 1 + src/mesa/drivers/dri/i965/brw_fs.cpp | 9 src/mesa/drivers/dri

Re: [Mesa-dev] [PATCH 3/3] st/mesa: implement DrawTransformFeedbackStream

2015-07-30 Thread Dave Airlie
On 31 July 2015 at 00:26, Marek Olšák wrote: > From: Marek Olšák once you rebase onto my last patch, these look fine. Reviewed-by: Dave Airlie > > --- > src/mesa/state_tracker/st_cb_xformfb.c | 58 > ++ > src/mesa/state_tracker/st_cb_xformfb.h | 2 +- > src/m

Re: [Mesa-dev] [PATCH 1/2] i965: Extract push constant state to a new file

2015-07-30 Thread Matt Turner
On Thu, Jul 30, 2015 at 2:31 PM, Ben Widawsky wrote: > Recommended-by: Kenneth Graunke > Signed-off-by: Ben Widawsky > --- > src/mesa/drivers/dri/i965/Makefile.sources | 1 + > src/mesa/drivers/dri/i965/gen6_constant_state.c | 189 > > src/mesa/drivers/dri/i965/

Re: [Mesa-dev] [PATCH 00/21] NIR control flow modification

2015-07-30 Thread Kenneth Graunke
On Tuesday, July 21, 2015 07:54:14 PM Connor Abbott wrote: > Back when I was getting NIR up and running, I created a bunch of > functions that dealt with modifying control flow; they allowed you to > remove control flow nodes (if's, loops, and basic blocks) as well as > insert newly-created control

[Mesa-dev] [PATCH] r600, compute: force tiling on 2D and 3D texture compute resources

2015-07-30 Thread Zoltan Gilian
To circumvent a problem occuring when LINEAR_ALIGNED array mode is selected on a TEXTURE_2D RAT. This configuration causes MEM_RAT STORE_TYPED to write to incorrect locations. --- src/gallium/drivers/radeon/r600_texture.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git

[Mesa-dev] [PATCH 2/2] clover: allow driver to override transfer pitch

2015-07-30 Thread Zoltan Gilian
The driver may set the pitch of a 2d or 3d mapping. --- src/gallium/state_trackers/clover/api/transfer.cpp | 13 - src/gallium/state_trackers/clover/core/resource.hpp | 8 2 files changed, 16 insertions(+), 5 deletions(-) diff --git a/src/gallium/state_trackers/clover/api/t

[Mesa-dev] [PATCH 1/2] clover: fix mapping of 2 and 3 dimenisional regions of images

2015-07-30 Thread Zoltan Gilian
Mapping tiled textures requires 2 or 3 dimensional region information. --- src/gallium/state_trackers/clover/api/transfer.cpp | 33 +++--- 1 file changed, 23 insertions(+), 10 deletions(-) diff --git a/src/gallium/state_trackers/clover/api/transfer.cpp b/src/gallium/state_tracker

[Mesa-dev] [PATCH] clover: handle setKernelArg errors

2015-07-30 Thread Zoltan Gilian
--- src/gallium/state_trackers/clover/core/kernel.cpp | 15 +++ 1 file changed, 15 insertions(+) diff --git a/src/gallium/state_trackers/clover/core/kernel.cpp b/src/gallium/state_trackers/clover/core/kernel.cpp index a23cd2b..820a80a 100644 --- a/src/gallium/state_trackers/clover/co

Re: [Mesa-dev] [PATCH] i965/skl: Emit new 3DSTATE_VF_COMPONENT_PACKING

2015-07-30 Thread Ben Widawsky
Update: I no longer thing we should merge this patch. A note in the programming has been introduced stating that we should not program this state packet without enabling at least one component. On Wed, Jul 01, 2015 at 04:06:54PM -0700, Ben Widawsky wrote: > We don't yet have a use for this state,

[Mesa-dev] [PATCH 1/2] i965: Extract push constant state to a new file

2015-07-30 Thread Ben Widawsky
Recommended-by: Kenneth Graunke Signed-off-by: Ben Widawsky --- src/mesa/drivers/dri/i965/Makefile.sources | 1 + src/mesa/drivers/dri/i965/gen6_constant_state.c | 189 src/mesa/drivers/dri/i965/gen6_vs_state.c | 88 --- src/mesa/drivers/dri/i965/ge

[Mesa-dev] [PATCH 2/2] i965: Consolidate push constant buffer setup

2015-07-30 Thread Ben Widawsky
This patch replaces the previous patch listed in references. References: http://patchwork.freedesktop.org/patch/54099/ Recommended-by: Kenneth Graunke Signed-off-by: Ben Widawsky --- src/mesa/drivers/dri/i965/gen6_constant_state.c | 104 ++-- 1 file changed, 62 insertions(+)

[Mesa-dev] Properly exposing limits with gallium

2015-07-30 Thread Ilia Mirkin
So I'm trying to get these things to line up, especially for nvc0. Here are the limits exposed by the blob drivers: http://people.freedesktop.org/~imirkin/glxinfo/glxinfo.html#v=Vendor and they reflect what the hardware is capable. More specifically, I need GL_MAX_VERTEX_OUTPUT_COMPONENTS = 128

Re: [Mesa-dev] [PATCH v2 00/78] i965: A new vec4 backend based on NIR

2015-07-30 Thread Jason Ekstrand
On Jul 27, 2015 3:39 PM, "Jason Ekstrand" wrote: > > On Mon, Jul 27, 2015 at 2:07 PM, Eduardo Lima Mitev wrote: > > On 07/25/2015 03:08 AM, Jason Ekstrand wrote: > >> Alright, I got through it again... > >> > >> I asked for a few trivial changes on a few of the patches. With those > >> fixed, ev

[Mesa-dev] [PATCH] docs: trivial cleanup of GL3.txt, remove redundant radeonsi entries.

2015-07-30 Thread Kai Wasserbäch
Follow-up to 1b2b0e42ce47bfd1fcb5513ed2c23b9bb7a5a5b8 Signed-off-by: Kai Wasserbäch --- Please commit this for me, if this is accepted. Thanks. docs/GL3.txt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/GL3.txt b/docs/GL3.txt index 0220f24..8124383 100644 --- a/d

Re: [Mesa-dev] [PATCH v3 (part2) 55/56] glsl: Consider active all elements of a shared/std140 block array

2015-07-30 Thread Antía Puentes
Please, ignore this patch, we have recently sent an updated version to the mailing list. The new version is available in: http://lists.freedesktop.org/archives/mesa-dev/2015-July/090108.html Regards. On mar, 2015-07-14 at 09:46 +0200, Iago Toral Quiroga wrote: > From: Antia Puentes > > Commmit

[Mesa-dev] [PATCH v2 2/2]] mesa/teximage: accept ASTC formats for 3D texture specification

2015-07-30 Thread Nanley Chery
From: Nanley Chery The ASTC spec was revised as follows: Revision 2, April 28, 2015 - added CompressedTex{Sub,}Image3D to commands accepting ASTC format tokens in the New Tokens section [...]. Support only exists in the HDR submode: Add a second new column "3D Tex." which is empty for

Re: [Mesa-dev] [PATCH 1/2] r600: Fix some printf format warns pretaining to PRIi64

2015-07-30 Thread Bruno Jimenez
Hi, I don't know if you will believe it or not, but I have just written a very similar patch to yours :) Anyway, yours have come first so have my Reviewed-by: Bruno Jiménez Note: I have no permissions in the git repo, you should ask someone to push this patch for you. - Bruno On Thu, 2015-07

Re: [Mesa-dev] [PATCH 1/2] mesa/formats: add some formats from GL3.3

2015-07-30 Thread Roland Scheidegger
Hmm I guess we can't convert it to something else when we don't have a matching MESA_FORMAT? Roland Am 30.07.2015 um 03:48 schrieb Dave Airlie: > From: Dave Airlie > > GL3.3 added GL_ARB_texture_rgb10_a2ui, which specifies > a lot more things than just rgb10/a2ui. > > While playing with ogl co

[Mesa-dev] [PATCH] radeonsi: copy *8_SNORM bits exactly in resource_copy_region

2015-07-30 Thread Marek Olšák
From: Marek Olšák Disabling the FP16 mode didn't help. If needed, we can use this trick for blits too, but not for scaled blits. + 4 piglits --- src/gallium/drivers/radeonsi/si_blit.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/radeonsi/si_blit.c

Re: [Mesa-dev] [PATCH 3/3] dri: set the __DRI_API_OPENGL bit based on max gl compat version

2015-07-30 Thread Emil Velikov
On 30 July 2015 at 10:27, Frank Binns wrote: > This matches similar behaviour for the __DRI_API_OPENGL_CORE bit. > > Signed-off-by: Frank Binns > --- > src/mesa/drivers/dri/common/dri_util.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/src/mesa/drivers/dri/common/d

Re: [Mesa-dev] [PATCH] includes/GL: remove duplicated extension declarations from glx.h

2015-07-30 Thread Ian Romanick
On 07/30/2015 07:50 AM, Emil Velikov wrote: > On 30 July 2015 at 15:22, Emil Velikov wrote: >> All three of GLX_NV_float_buffer, GLX_EXT_texture_from_pixmap and >> GLX_MESA_query_renderer have been in glxext.h for a while now. >> >> As such we can drop this workaround/hack from the header. >> >> S

[Mesa-dev] [Bug 91020] Mesa's demo / tools won't compile since EGL changes

2015-07-30 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=91020 --- Comment #5 from Emil Velikov --- (In reply to George Diamantopoulos from comment #4) > Created attachment 117106 [details] [review] > Fix build against EGL implementations that don't support the > EGL_MESA_screen_surface extension > > There

Re: [Mesa-dev] [PATCH] i915/aa: fixing anti-aliasing bug for thinnest width lines

2015-07-30 Thread Predut, Marius
Was sent 2 month ago, still not review/upstream -Original Message- From: Predut, Marius Sent: Thursday, July 30, 2015 7:04 PM To: mesa-dev@lists.freedesktop.org Cc: Predut, Marius Subject: [Mesa-dev][PATCH] i915/aa: fixing anti-aliasing bug for thinnest width lines On PNV platform, for

[Mesa-dev] [PATCH] i915/aa: fixing anti-aliasing bug for thinnest width lines

2015-07-30 Thread Marius Predut
On PNV platform, for 1 pixel line thickness or less, the general anti-aliasing algorithm gives up, and a garbage line is generated. Setting a Line Width of 0.0 specifies the rasterization of the "thinnest" (one-pixel-wide), non-antialiased lines. Lines rendered with zero Line Width are rasterized u

Re: [Mesa-dev] [PATCH] includes/GL: remove duplicated extension declarations from glx.h

2015-07-30 Thread Emil Velikov
On 30 July 2015 at 15:22, Emil Velikov wrote: > All three of GLX_NV_float_buffer, GLX_EXT_texture_from_pixmap and > GLX_MESA_query_renderer have been in glxext.h for a while now. > > As such we can drop this workaround/hack from the header. > > Signed-off-by: Emil Velikov > --- > > Not to mention

Re: [Mesa-dev] [PATCH 0/9] Mostly trivial clean ups

2015-07-30 Thread Jason Ekstrand
Patches 1-8 are Acked-by: Jason Ekstrand Thanks for cleaning that stuff up. On Thu, Jul 30, 2015 at 7:14 AM, Ian Romanick wrote: > All but the last of these patches have been sitting in one tree or > another for quite some time. All of these files were touched as part of > other work, but tha

Re: [Mesa-dev] [PATCH] includes/GL: remove duplicated extension declarations from glx.h

2015-07-30 Thread Brian Paul
On 07/30/2015 08:22 AM, Emil Velikov wrote: All three of GLX_NV_float_buffer, GLX_EXT_texture_from_pixmap and GLX_MESA_query_renderer have been in glxext.h for a while now. As such we can drop this workaround/hack from the header. Signed-off-by: Emil Velikov --- Not to mention that glxext.h h

Re: [Mesa-dev] [PATCH 9/9] glsl: Add constuctors for the common cases of glsl_struct_field

2015-07-30 Thread Francisco Jerez
Ian Romanick writes: > From: Ian Romanick > > Fixes a giant pile of GCC warnings: > > builtin_types.cpp:60:1: warning: missing initializer for member > 'glsl_struct_field::stream' [-Wmissing-field-initializers] > > I had to add a default constructor because a non-default constructor > was added

[Mesa-dev] [PATCH 0/3] Fix glDrawTransformFeedbackStream

2015-07-30 Thread Marek Olšák
This wasn't implemented. Piglit tests have yet to be written. Hopefully, they will just materialize themselves. Marek ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH 1/3] vbo: pass the stream from DrawTransformFeedbackStream to drivers

2015-07-30 Thread Marek Olšák
From: Marek Olšák --- src/mesa/drivers/dri/i965/brw_draw.c | 3 ++- src/mesa/drivers/dri/i965/brw_draw.h | 3 ++- src/mesa/drivers/dri/i965/brw_meta_fast_clear.c | 2 +- src/mesa/drivers/dri/i965/brw_primitive_restart.c | 3 ++- src/mesa/drivers/dri/nouveau/nouvea

[Mesa-dev] [PATCH 3/3] st/mesa: implement DrawTransformFeedbackStream

2015-07-30 Thread Marek Olšák
From: Marek Olšák --- src/mesa/state_tracker/st_cb_xformfb.c | 58 ++ src/mesa/state_tracker/st_cb_xformfb.h | 2 +- src/mesa/state_tracker/st_draw.c | 2 +- 3 files changed, 33 insertions(+), 29 deletions(-) diff --git a/src/mesa/state_tracker/st_cb_xfor

[Mesa-dev] [PATCH 2/3] mesa: save which transform feedback buffer is associated with which stream

2015-07-30 Thread Marek Olšák
From: Marek Olšák --- src/glsl/link_varyings.cpp | 1 + src/mesa/main/mtypes.h | 5 + 2 files changed, 6 insertions(+) diff --git a/src/glsl/link_varyings.cpp b/src/glsl/link_varyings.cpp index 1c52ff3..f7a7b8c 100644 --- a/src/glsl/link_varyings.cpp +++ b/src/glsl/link_varyings.cpp @@

[Mesa-dev] [PATCH 9/9] glsl: Add constuctors for the common cases of glsl_struct_field

2015-07-30 Thread Ian Romanick
From: Ian Romanick Fixes a giant pile of GCC warnings: builtin_types.cpp:60:1: warning: missing initializer for member 'glsl_struct_field::stream' [-Wmissing-field-initializers] I had to add a default constructor because a non-default constructor was added. Otherwise the only constructor woul

Re: [Mesa-dev] [PATCH v2 3/6] i965/vec4: Don't emit scratch reads for a spilled register we have just written

2015-07-30 Thread Francisco Jerez
Francisco Jerez writes: > Iago Toral Quiroga writes: > >> When we have code such as this: >> >> mov vgrf1.0.x:F, vgrf2.:F >> mov vgrf3.0.x:F, vgrf1.:F >> ... >> mov vgrf3.0.x:F, vgrf1.:F >> >> And vgrf1 is chosen for spilling, we can emit this: >> >> mov vgrf1.0.x:F, vgrf2.:F >>

[Mesa-dev] [PATCH 0/9] Mostly trivial clean ups

2015-07-30 Thread Ian Romanick
All but the last of these patches have been sitting in one tree or another for quite some time. All of these files were touched as part of other work, but that work is stalled a bit. At Ken's suggestion, I'm sending out the trivial bits just to prune my trees a bit. _

[Mesa-dev] [PATCH] includes/GL: remove duplicated extension declarations from glx.h

2015-07-30 Thread Emil Velikov
All three of GLX_NV_float_buffer, GLX_EXT_texture_from_pixmap and GLX_MESA_query_renderer have been in glxext.h for a while now. As such we can drop this workaround/hack from the header. Signed-off-by: Emil Velikov --- Not to mention that glxext.h honours GLX_GLXEXT_PROTOTYPES and provides the

[Mesa-dev] [PATCH 5/9] i965: Trivial formatting changes in gen6_multisample_state.c

2015-07-30 Thread Ian Romanick
From: Ian Romanick Signed-off-by: Ian Romanick --- src/mesa/drivers/dri/i965/gen6_multisample_state.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/src/mesa/drivers/dri/i965/gen6_multisample_state.c b/src/mesa/drivers/dri/i965/gen6_multisample_state.c index cf1421e

[Mesa-dev] [PATCH 8/9] i965: Make gen7_upload_ps_state static

2015-07-30 Thread Ian Romanick
From: Ian Romanick It is only ever called from within the same file. Signed-off-by: Ian Romanick --- src/mesa/drivers/dri/i965/brw_state.h | 9 - src/mesa/drivers/dri/i965/gen7_wm_state.c | 2 +- 2 files changed, 1 insertion(+), 10 deletions(-) diff --git a/src/mesa/drivers/dri/i9

[Mesa-dev] [PATCH 7/9] i965: Remove extern declaration for nonexistent state atom

2015-07-30 Thread Ian Romanick
From: Ian Romanick Signed-off-by: Ian Romanick --- src/mesa/drivers/dri/i965/brw_state.h | 1 - 1 file changed, 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/brw_state.h b/src/mesa/drivers/dri/i965/brw_state.h index 2eff1b5..a99bbbd 100644 --- a/src/mesa/drivers/dri/i965/brw_state.h ++

[Mesa-dev] [PATCH 2/9] i965: Trivial formatting changes in brw_draw.c

2015-07-30 Thread Ian Romanick
From: Ian Romanick Signed-off-by: Ian Romanick --- src/mesa/drivers/dri/i965/brw_draw.c | 102 +-- 1 file changed, 51 insertions(+), 51 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_draw.c b/src/mesa/drivers/dri/i965/brw_draw.c index b5ef276..9113d0f

[Mesa-dev] [PATCH 6/9] i965: Trivial formatting changes in gen7_vs_state.c

2015-07-30 Thread Ian Romanick
From: Ian Romanick Signed-off-by: Ian Romanick --- src/mesa/drivers/dri/i965/gen7_vs_state.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/mesa/drivers/dri/i965/gen7_vs_state.c b/src/mesa/drivers/dri/i965/gen7_vs_state.c index 4b17d06..00bc6f2 100644 --- a/

[Mesa-dev] [PATCH 1/9] i965: Trivial formatting changes in brw_wm.c

2015-07-30 Thread Ian Romanick
From: Ian Romanick Signed-off-by: Ian Romanick --- src/mesa/drivers/dri/i965/brw_wm.c | 84 +++--- 1 file changed, 41 insertions(+), 43 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_wm.c b/src/mesa/drivers/dri/i965/brw_wm.c index b590b17..9b90a7c 1006

[Mesa-dev] [PATCH 3/9] i965: Trivial formatting changes in brw_draw_upload.c

2015-07-30 Thread Ian Romanick
From: Ian Romanick Signed-off-by: Ian Romanick --- src/mesa/drivers/dri/i965/brw_draw_upload.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_draw_upload.c b/src/mesa/drivers/dri/i965/brw_draw_upload.c index c6dd69b..cbfd585 100644 --

[Mesa-dev] [PATCH 4/9] i965: Trivial formatting changes in brw_misc_state.c

2015-07-30 Thread Ian Romanick
From: Ian Romanick Signed-off-by: Ian Romanick --- src/mesa/drivers/dri/i965/brw_misc_state.c | 49 ++ 1 file changed, 23 insertions(+), 26 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_misc_state.c b/src/mesa/drivers/dri/i965/brw_misc_state.c index 16b0e

Re: [Mesa-dev] [PATCH v2 3/6] i965/vec4: Don't emit scratch reads for a spilled register we have just written

2015-07-30 Thread Francisco Jerez
Iago Toral Quiroga writes: > When we have code such as this: > > mov vgrf1.0.x:F, vgrf2.:F > mov vgrf3.0.x:F, vgrf1.:F > ... > mov vgrf3.0.x:F, vgrf1.:F > > And vgrf1 is chosen for spilling, we can emit this: > > mov vgrf1.0.x:F, vgrf2.:F > gen4_scratch_write hw_reg0:F, vgrf1.

[Mesa-dev] [PATCH] mesa: Remove GL_ARB_sampler_object depth compare error checking.

2015-07-30 Thread Stefan Dösinger
Version 3: Simplify the code comment, word wrap commit description. Version 2: Return GL_FALSE if ARB_shadow is unsupported instead of pretending to store the value as suggested by Brian Paul. This fixes a GL error warning on r200 in Wine. The GL_ARB_sampler_objects extension does not specify a

Re: [Mesa-dev] [PATCH] Allow setting GL_TEXTURE_COMPARE_MODE on a sampler object without ARB_shadow support (v2).

2015-07-30 Thread Stefan Dösinger
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi, Thanks for the quick feedback! I'll resend the patch with the requested fixes shortly. Stefan Am 2015-07-30 um 15:30 schrieb Brian Paul: > Can you try to shorten the subject line to 75 chars or less? It > should also start with "mesa:". Perhap

Re: [Mesa-dev] [PATCH v2 5/6] i965/vec4: Adjust spilling cost for consecutive instructions

2015-07-30 Thread Francisco Jerez
Francisco Jerez writes: > Iago Toral Quiroga writes: > >> Previous patches made it so that we do not need to unspill the same vgrf >> with every instruction as long as these instructions come right after >> the register was spilled or unspilled. This means that actually spilling >> the register

[Mesa-dev] [PATCH 13.5/17 v2] glsl: Add precision information to ir_variable

2015-07-30 Thread Iago Toral Quiroga
We will need this later on when we implement proper support for precision qualifiers in the drivers and also to do link time checks for uniforms as indicated by the spec. This patch also adds compile-time checks for variables without precision information (currently, Mesa only checks that a defaul

[Mesa-dev] [PATCH 13/17 v2] glsl: Move the definition of precision_qualifier_allowed

2015-07-30 Thread Iago Toral Quiroga
We will need this to build later patches --- src/glsl/ast_to_hir.cpp | 71 - 1 file changed, 35 insertions(+), 36 deletions(-) diff --git a/src/glsl/ast_to_hir.cpp b/src/glsl/ast_to_hir.cpp index 789b2bc..3ececb7 100644 --- a/src/glsl/ast_to_hir.cpp

Re: [Mesa-dev] [PATCH v2 5/6] i965/vec4: Adjust spilling cost for consecutive instructions

2015-07-30 Thread Francisco Jerez
Francisco Jerez writes: > Iago Toral Quiroga writes: > >> Previous patches made it so that we do not need to unspill the same vgrf >> with every instruction as long as these instructions come right after >> the register was spilled or unspilled. This means that actually spilling >> the register

Re: [Mesa-dev] [PATCH] gallivm: Fix GCC unused-variable warning.

2015-07-30 Thread Brian Paul
On 07/29/2015 09:19 PM, Vinson Lee wrote: lp_bld_tgsi_soa.c: In function 'lp_emit_immediate_soa': lp_bld_tgsi_soa.c:3065:18: warning: unused variable 'size' [-Wunused-variable] const uint size = imm->Immediate.NrTokens - 1; ^ Signed-off-by: Vinson Lee --- src/galliu

Re: [Mesa-dev] [PATCH] Allow setting GL_TEXTURE_COMPARE_MODE on a sampler object without ARB_shadow support (v2).

2015-07-30 Thread Brian Paul
Can you try to shorten the subject line to 75 chars or less? It should also start with "mesa:". Perhaps: "mesa: disable texture compare mode error checking for Wine" On 07/30/2015 07:04 AM, Stefan Dösinger wrote: Version 2: Return GL_FALSE if ARB_shadow is unsupported instead of pretending

Re: [Mesa-dev] [PATCH v2 2/6] i965/vec4: Remove checks for reladdr when checking for spillable registers

2015-07-30 Thread Francisco Jerez
Iago Toral Quiroga writes: > In theory, GRF array access should have been moved to scratch by the time > we got here, so this should never happen. A full piglit run forcing > spilling of all registers seems to confirm this. The FS backend > does not seem to check for this either. > --- > src/mes

Re: [Mesa-dev] [PATCH v2 5/6] i965/vec4: Adjust spilling cost for consecutive instructions

2015-07-30 Thread Francisco Jerez
Iago Toral Quiroga writes: > Previous patches made it so that we do not need to unspill the same vgrf > with every instruction as long as these instructions come right after > the register was spilled or unspilled. This means that actually spilling > the register is now cheaper in these scenarios

Re: [Mesa-dev] [PATCH v2 6/6] i965: Add a debug option for spilling everything in vec4 code

2015-07-30 Thread Francisco Jerez
Iago Toral writes: > On Thu, 2015-07-30 at 15:58 +0300, Francisco Jerez wrote: >> Iago Toral Quiroga writes: >> >> > --- >> > src/mesa/drivers/dri/i965/brw_fs_reg_allocate.cpp | 2 +- >> > src/mesa/drivers/dri/i965/brw_vec4.cpp| 2 +- >> > src/mesa/drivers/dri/i965/intel_debug.c

[Mesa-dev] [PATCH] Allow setting GL_TEXTURE_COMPARE_MODE on a sampler object without ARB_shadow support (v2).

2015-07-30 Thread Stefan Dösinger
Version 2: Return GL_FALSE if ARB_shadow is unsupported instead of pretending to store the value as suggested by Brian Paul. This fixes a GL error warning on r200 in Wine. The GL_ARB_sampler_objects extension does not specify a dependency on GL_ARB_shadow or GL_ARB_depth_texture for this value.

Re: [Mesa-dev] [PATCH v2 6/6] i965: Add a debug option for spilling everything in vec4 code

2015-07-30 Thread Iago Toral
On Thu, 2015-07-30 at 15:58 +0300, Francisco Jerez wrote: > Iago Toral Quiroga writes: > > > --- > > src/mesa/drivers/dri/i965/brw_fs_reg_allocate.cpp | 2 +- > > src/mesa/drivers/dri/i965/brw_vec4.cpp| 2 +- > > src/mesa/drivers/dri/i965/intel_debug.c | 3 ++- > > src/mesa

Re: [Mesa-dev] [PATCH v2 6/6] i965: Add a debug option for spilling everything in vec4 code

2015-07-30 Thread Francisco Jerez
Iago Toral Quiroga writes: > --- > src/mesa/drivers/dri/i965/brw_fs_reg_allocate.cpp | 2 +- > src/mesa/drivers/dri/i965/brw_vec4.cpp| 2 +- > src/mesa/drivers/dri/i965/intel_debug.c | 3 ++- > src/mesa/drivers/dri/i965/intel_debug.h | 5 +++-- > 4 files changed,

[Mesa-dev] [PATCH] i965/fs: Fix regression with SIMD8 VS since b5f1a48e234d47b24df38cb562cffb8941d43795.

2015-07-30 Thread Francisco Jerez
With num_direct_uniforms == 0 there's no space allocated in the param_size array for the one block of direct uniforms -- On the FS stage this would be a harmless no-op because it would simply re-set one of the param_size entries allocated for the sampler units to zero, but on the VS stage it has be

Re: [Mesa-dev] [PATCH 01/20] mesa: fix and simplify resource query for arrays

2015-07-30 Thread Timothy Arceri
On Thu, 2015-07-30 at 14:21 +0300, Tapani Pälli wrote: > On 07/30/2015 12:26 PM, Timothy Arceri wrote: > > On Thu, 2015-07-30 at 11:07 +0300, Tapani Pälli wrote: > > > On 07/30/2015 08:56 AM, Tapani Pälli wrote: > > > > On 07/30/2015 08:50 AM, Timothy Arceri wrote: > > > > > On 30 July 2015 3:27:41

Re: [Mesa-dev] V3 ARB_arrays_of_arrays GLSL ES

2015-07-30 Thread Timothy Arceri
On Thu, 2015-07-30 at 14:16 +0300, Tapani Pälli wrote: > patches 1,2,3 I'm going to push these so they get as much testing as possible. > > and patches for AoA size calculation 11,12,16 > > Reviewed-by: Tapani Pälli > > (will review some more later) That would be great thanks. > > On 07/29

Re: [Mesa-dev] [PATCH 01/20] mesa: fix and simplify resource query for arrays

2015-07-30 Thread Tapani Pälli
On 07/30/2015 12:26 PM, Timothy Arceri wrote: On Thu, 2015-07-30 at 11:07 +0300, Tapani Pälli wrote: On 07/30/2015 08:56 AM, Tapani Pälli wrote: On 07/30/2015 08:50 AM, Timothy Arceri wrote: On 30 July 2015 3:27:41 pm AEST, "Tapani Pälli" wrote: On 07/30/2015 08:25 AM, Tapani Pälli wrote: H

Re: [Mesa-dev] V3 ARB_arrays_of_arrays GLSL ES

2015-07-30 Thread Tapani Pälli
patches 1,2,3 and patches for AoA size calculation 11,12,16 Reviewed-by: Tapani Pälli (will review some more later) On 07/29/2015 04:56 PM, Timothy Arceri wrote: If useful the series is in the 'gles8' branch of the repo here: https://github.com/tarceri/Mesa_arrays_of_arrays.git Changes in v

Re: [Mesa-dev] [PATCH] mesa: support arrays of structures in GetProgramResourceIndex

2015-07-30 Thread Tapani Pälli
On 07/30/2015 12:48 PM, Timothy Arceri wrote: On Thu, 2015-07-30 at 19:40 +1000, Timothy Arceri wrote: On Thu, 2015-07-30 at 09:44 +0300, Tapani Pälli wrote: This fixes a lot of failing tests in: ES31-CTS.program_interface_query.uniform-types Signed-off-by: Tapani Pälli --- src/mesa/mai

Re: [Mesa-dev] [PATCH] st/mesa: fail to draw instead of asserting in transform feedback

2015-07-30 Thread Marek Olšák
It's not a failure, so it can't _fail_ to draw. It should be interpreted such that the drawing succeeds with the vertex count given by the transform feedback object, which is 0. Reviewed-by: Marek Olšák Marek On Thu, Jul 30, 2015 at 12:46 PM, Dave Airlie wrote: > if we get a request to take th

[Mesa-dev] [PATCH] st/mesa: fail to draw instead of asserting in transform feedback

2015-07-30 Thread Dave Airlie
if we get a request to take the count from feedback, but there is no buffer to take it from, just draw nothing instead of asserting. This fixes this assert killing the ogl conform, and a piglit test I've sent. Signed-off-by: Dave Airlie --- src/mesa/state_tracker/st_cb_xformfb.c | 6 -- src

Re: [Mesa-dev] [PATCH] glsl: Initialize parse-state in constructor of lower_subroutine.

2015-07-30 Thread Samuel Iglesias Gonsálvez
Reviewed-by: Samuel Iglesias Gonsálvez On Wed, 2015-07-29 at 10:53 -0700, Matt Turner wrote: > Static analysis tools don't like partial object initializations. > --- > src/glsl/lower_subroutine.cpp | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/src/glsl/lower_sub

Re: [Mesa-dev] [PATCH 16/17] glsl: Add link time checks for GLSL precision qualifiers

2015-07-30 Thread Iago Toral
On Wed, 2015-07-29 at 15:21 -0700, Ian Romanick wrote: > On 07/29/2015 07:01 AM, Samuel Iglesias Gonsalvez wrote: > > From: Iago Toral Quiroga > > > > Currently, we only consider precision qualifiers at compile-time. This patch > > adds precision information to ir_variable so we can also do link

Re: [Mesa-dev] [PATCH] mesa: support arrays of structures in GetProgramResourceIndex

2015-07-30 Thread Timothy Arceri
On Thu, 2015-07-30 at 19:40 +1000, Timothy Arceri wrote: > On Thu, 2015-07-30 at 09:44 +0300, Tapani Pälli wrote: > > This fixes a lot of failing tests in: > >ES31-CTS.program_interface_query.uniform-types > > > > Signed-off-by: Tapani Pälli > > --- > > src/mesa/main/program_resource.c | 7 +

[Mesa-dev] [PATCH 2/3] egl/dri: Add error info needed for EGL_EXT_image_dma_buf_import extension

2015-07-30 Thread Frank Binns
Update the DRI image interface error codes to reflect the needs of the EGL_EXT_image_dma_buf_import extension. This means updating the existing error code documentation and adding a new __DRI_IMAGE_ERROR_BAD_ACCESS error code so that drivers can correctly reject unsupported pitches and offsets. Hoo

[Mesa-dev] [PATCH 3/3] dri: set the __DRI_API_OPENGL bit based on max gl compat version

2015-07-30 Thread Frank Binns
This matches similar behaviour for the __DRI_API_OPENGL_CORE bit. Signed-off-by: Frank Binns --- src/mesa/drivers/dri/common/dri_util.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/common/dri_util.c b/src/mesa/drivers/dri/common/dri_util.c index 88

[Mesa-dev] [PATCH 1/3] egl: Add eglQuerySurface surface type check for EGL_LARGEST_PBUFFER attrib

2015-07-30 Thread Frank Binns
Calling eglQuerySurface on a window or pixmap with the EGL_LARGEST_PBUFFER attribute resulted in the contents of the 'value' parameter being modified. This is the wrong behaviour according to the EGL spec, which states: "Querying EGL_LARGEST_PBUFFER for a pbuffer surface returns the same

Re: [Mesa-dev] [PATCH] mesa: support arrays of structures in GetProgramResourceIndex

2015-07-30 Thread Timothy Arceri
On Thu, 2015-07-30 at 09:44 +0300, Tapani Pälli wrote: > This fixes a lot of failing tests in: >ES31-CTS.program_interface_query.uniform-types > > Signed-off-by: Tapani Pälli > --- > src/mesa/main/program_resource.c | 7 +-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --g

[Mesa-dev] [Bug 91474] egl initializes wrong card with hybrid graphics card

2015-07-30 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=91474 --- Comment #3 from Marek Chalupa --- (In reply to Axel Davy from comment #1) > Mesa egl does indeed support DRI_PRIME for the wayland backend, > > however unless DRI_PRIME is set, it uses the same card that the server. > I guess either the user

  1   2   >