Re: [Mesa-dev] [PATCH mesa 2/3] nv30: Fix color resolving for nv3x cards

Hi, On 07-09-15 21:55, Ilia Mirkin wrote: May I ask why you're doing 512x512 instead of 1024x1024? These are already scaled up coordinates, so 1024x1024 should work no? Or is it because of the seams on the edges? Do those not also appear with 512x512 or does it sample outside of the box? This

Re: [Mesa-dev] [PATCH 3/5] nir: Add new GS intrinsics that maintain a count of emitted vertices.

On Monday, September 07, 2015 10:51:37 AM Jason Ekstrand wrote: > On Sep 3, 2015 1:49 AM, "Kenneth Graunke" wrote: > > > > This patch also introduces a lowering pass to convert the simple GS > > intrinsics to the new ones. See the comments above that for the > > rationale

Re: [Mesa-dev] [PATCH 1/3] glsl: Use hash tables in opt_constant_variable().

On Tuesday, September 08, 2015 08:15:11 AM Tapani Pälli wrote: > I did not get as impressive results with these 3 patches (how did you > measure?) but on my machine (HSW GT2) complete shader_runner time goes > from ~83 secs to ~70secs so it is definitely improving. > > I simply do 'time

Re: [Mesa-dev] [PATCH mesa 3/3] nv30: Disable msaa for now because it causes lockups

Hi, On 07-09-15 22:00, Ilia Mirkin wrote: On Mon, Sep 7, 2015 at 3:50 PM, Hans de Goede wrote: msaa use on nv30 may trigger a (mesa?) bug where dmesg says: [ 1197.850642] nouveau E[soffice.bin[3785]] fail ttm_validate [ 1197.850648] nouveau E[soffice.bin[3785]]

Re: [Mesa-dev] [Nouveau] [PATCH mesa 3/3] nv30: Disable msaa for now because it causes lockups

On 8 September 2015 at 18:00, Hans de Goede wrote: > Hi, > > On 07-09-15 22:00, Ilia Mirkin wrote: >> >> On Mon, Sep 7, 2015 at 3:50 PM, Hans de Goede wrote: >>> >>> msaa use on nv30 may trigger a (mesa?) bug where dmesg says: >>> [ 1197.850642]

Re: [Mesa-dev] [PATCH 2/2] gallium/radeon: drop support for LLVM 3.4

On 07.09.2015 07:14, Marek Olšák wrote: > From: Marek Olšák > > This allows using the new tex instrinsics unconditionally. The series is Reviewed-by: Michel Dänzer -- Earthling Michel Dänzer | http://www.amd.com Libre

Re: [Mesa-dev] [PATCH] r600g: fix bug 91881

On 07.09.2015 09:15, Dave Airlie wrote: > On 7 September 2015 at 08:17, Marek Olšák wrote: >> From: Marek Olšák >> >> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=91881 > > Might be nice to say where the regression happened in the commit, and >

[Mesa-dev] [Bug 91888] EGL Wayland software rendering no longer work after regression

https://bugs.freedesktop.org/show_bug.cgi?id=91888 Daniel Stone changed: What|Removed |Added Status|NEW |RESOLVED

Re: [Mesa-dev] [PATCH 4/5] i965/gs: Use new NIR intrinsics.

On Monday, September 07, 2015 11:06:54 AM Jason Ekstrand wrote: > On Thu, Sep 3, 2015 at 1:48 AM, Kenneth Graunke wrote: > > By performing the vertex counting in NIR, we're able to elide a ton of > > useless safety checks around every EmitVertex() call: > > > > total

Re: [Mesa-dev] [PATCH 1/3] glsl: Use hash tables in opt_constant_variable().

On 09/08/2015 12:34 PM, Kenneth Graunke wrote: On Tuesday, September 08, 2015 08:15:11 AM Tapani Pälli wrote: I did not get as impressive results with these 3 patches (how did you measure?) but on my machine (HSW GT2) complete shader_runner time goes from ~83 secs to ~70secs so it is

[Mesa-dev] [PATCH 07/15] mesa: Resolve GCC sign-compare warning.

mesa/src/mesa/program/prog_to_nir.c: In function 'setup_registers_and_variables': /mesa/src/mesa/program/prog_to_nir.c:1059:22: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] for (int i = 0; i < c->prog->NumTemporaries; i++) { ^

[Mesa-dev] [PATCH 08/15] i965: Resolve GCC sign-compare warning.

mesa/src/mesa/drivers/dri/i965/brw_eu_compact.c: In function 'set_3src_control_index': mesa/src/mesa/drivers/dri/i965/brw_eu_compact.c:805:22: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] for (int i = 0; i < ARRAY_SIZE(gen8_3src_control_index_table);

[Mesa-dev] [PATCH 01/15] glsl: Resolve GCC sign-compare warning.

mesa/src/glsl/nir/nir_lower_tex_projector.c: In function 'nir_lower_tex_projector_block': mesa/src/glsl/nir/nir_lower_tex_projector.c:63:25: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] for (int i = 0; i < tex->num_srcs; i++) {

[Mesa-dev] [PATCH 14/15] i965: Resolve GCC sign-compare warning.

mesa/src/mesa/drivers/dri/i965/intel_mipmap_tree.c: In function 'intel_miptree_alloc_hiz': mesa/src/mesa/drivers/dri/i965/intel_mipmap_tree.c:1771:44: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] for (int level = mt->first_level; level <=

[Mesa-dev] [PATCH 10/15] i965: Resolve GCC sign-compare warning.

mesa/src/mesa/drivers/dri/i965/brw_state_dump.c: In function 'dump_sampler_state': mesa/src/mesa/drivers/dri/i965/brw_state_dump.c:382:18: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] for (i = 0; i < size / 16; i++) { ^

[Mesa-dev] [PATCH 12/15] i965/gen7: Resolve GCC sign-compare warning.

mesa/src/mesa/drivers/dri/i965/intel_mipmap_tree.c: In function 'intel_gen7_hiz_buf_create': mesa/src/mesa/drivers/dri/i965/intel_mipmap_tree.c:1544:47: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] for (int level = mt->first_level; level <=

[Mesa-dev] [PATCH 13/15] i965/gen8: Resolve GCC sign-compare warning.

mesa/src/mesa/drivers/dri/i965/intel_mipmap_tree.c: In function 'intel_gen8_hiz_buf_create': mesa/src/mesa/drivers/dri/i965/intel_mipmap_tree.c:1638:44: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] for (int level = mt->first_level; level <=

[Mesa-dev] [PATCH 15/15] glsl: Resolve GCC sign-compare warning.

mesa/src/glsl/nir/nir_opt_peephole_ffma.c: In function 'get_mul_for_src': mesa/src/glsl/nir/nir_opt_peephole_ffma.c:130:27: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] for (unsigned i = 0; i < num_components; i++) ^

[Mesa-dev] [PATCH 11/15] i965: Resolve GCC sign-compare warning.

mesa/src/mesa/drivers/dri/i965/brw_state_upload.c: In function 'brw_pipeline_state_finished': mesa/src/mesa/drivers/dri/i965/brw_state_upload.c:801:13: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] if (i != pipeline) { ^ Signed-off-by:

[Mesa-dev] [PATCH 09/15] i965: Resolve GCC sign-compare warning.

mesa/src/mesa/drivers/dri/i965/brw_eu_compact.c: In function 'set_3src_source_index': mesa/src/mesa/drivers/dri/i965/brw_eu_compact.c:839:22: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] for (int i = 0; i < ARRAY_SIZE(gen8_3src_source_index_table);

[Mesa-dev] [PATCH 1/4] mesa: Resolve GCC missing field initializer warning.

In file included from mesa/src/mesa/main/get.c:495:0: mesa/src/mesa/main/get_hash.h:180:5: warning: missing initializer for field 'extra' of 'const struct value_desc' [-Wmissing-field-initializers] { GL_POINT_SIZE_ARRAY_BUFFER_BINDING_OES, LOC_CUSTOM, TYPE_INT, 0 }, ^

[Mesa-dev] [PATCH 0/4] Resolve GCC missing field initializer warnings

Resolve a series of missing field initializer warnings within get_hash_params.py This changeset addresses some likely code rot around the *extra field, where the initialization is via C code generated indirectly from a Python script. As a new contributor, I am continuing to focus on manageable,

[Mesa-dev] [PATCH 3/4] mesa: Resolve GCC missing field initializer warning.

In file included from mesa/src/mesa/main/get.c:495:0: mesa/src/mesa/main/get.c:190:37: warning: missing initializer for field 'extra' of 'const struct value_desc' [-Wmissing-field-initializers] LOC_ARRAY, type, offsetof(struct gl_vertex_array_object, field)

[Mesa-dev] [PATCH 4/4] mesa: Resolve GCC missing field initializer warning.

In file included from mesa/src/mesa/main/get.c:495:0: mesa/src/mesa/main/get.c:190:37: warning: missing initializer for field 'extra' of 'const struct value_desc' [-Wmissing-field-initializers] LOC_ARRAY, type, offsetof(struct gl_vertex_array_object, field)

[Mesa-dev] [PATCH 2/4] mesa: Resolve GCC missing field initializer warning.

In file included from mesa/src/mesa/main/get.c:495:0: mesa/src/mesa/main/get.c:190:37: warning: missing initializer for field 'extra' of 'const struct value_desc' [-Wmissing-field-initializers] LOC_ARRAY, type, offsetof(struct gl_vertex_array_object, field)

Re: [Mesa-dev] [PATCH 0/4] Resolve GCC missing field initializer warnings

Thanks! I think I would have squashed these together in one patch, it is the same one-line fix in 4 consecutive lines after all. In any case, this series is: Reviewed-by: Iago Toral Quiroga On Tue, 2015-09-08 at 20:21 +1000, Rhys Kidd wrote: > Resolve a series of missing

[Mesa-dev] [PATCH 05/15] glsl: Resolve GCC sign-compare warning.

mesa/src/glsl/nir/nir_search.c: In function 'match_value': mesa/src/glsl/nir/nir_search.c:110:28: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] for (int i = 0; i < num_components; ++i) { ^ Signed-off-by: Rhys Kidd

[Mesa-dev] [PATCH 06/15] glsl: Resolve GCC sign-compare warning.

mesa/src/glsl/nir/nir_search.c: In function 'match_value': mesa/src/glsl/nir/nir_search.c:139:19: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] if (i < num_components) ^ Signed-off-by: Rhys Kidd ---

[Mesa-dev] [PATCH 02/15] glsl: Resolve GCC sign-compare warning.

mesa/src/glsl/nir/nir_lower_tex_projector.c: In function 'nir_lower_tex_projector_block': mesa/src/glsl/nir/nir_lower_tex_projector.c:114:38: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] for (int i = proj_index + 1; i < tex->num_srcs; i++) {

[Mesa-dev] [PATCH 04/15] glsl: Resolve GCC sign-compare warning.

mesa/src/glsl/nir/nir_search.c: In function 'match_value': mesa/src/glsl/nir/nir_search.c:84:22: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] for (int i = 0; i < num_components; ++i) ^ Signed-off-by: Rhys Kidd

[Mesa-dev] [PATCH 03/15] glsl: Resolve GCC sign-compare warning.

mesa/src/glsl/nir/nir_lower_tex_projector.c: In function 'nir_lower_tex_projector_block': mesa/src/glsl/nir/nir_lower_tex_projector.c:53:39: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] for (proj_index = 0; proj_index < tex->num_srcs; proj_index++)

[Mesa-dev] [PATCH 00/15] Resolve further GCC sign-compare warnings

Continued progress towards addressing all GCC sign-compare warnings across Mesa (at least as compiled for i965 hw). As a new contributor, I am continuing to focus on manageable, easily reviewed, discrete improvements. This patchset resolves a number of warnings reported by GCC when configured to

Re: [Mesa-dev] [PATCH 0/4] Resolve GCC missing field initializer warnings

On Tue, 2015-09-08 at 20:21 +1000, Rhys Kidd wrote: > Resolve a series of missing field initializer warnings within > get_hash_params.py > > This changeset addresses some likely code rot around the *extra > field, where the > initialization is via C code generated indirectly from a Python >

Re: [Mesa-dev] [PATCH] i965: Disallow fast blit paths for CopyTexImage with PixelTransfer ops

On 09/06/2015 09:37 AM, Chris Wilson wrote: > glCopyTexImage behaves similarly to glReadPixels with respect to the > pixel transfer operations. Therefore if any are set we cannot use the > simply blit fast paths. Do we have any test cases that hit these paths? If not, we should probably con

Re: [Mesa-dev] [PATCH] i965: Disallow fast blit paths for CopyTexImage with PixelTransfer ops

On Sun, Sep 6, 2015 at 9:37 AM, Chris Wilson wrote: > glCopyTexImage behaves similarly to glReadPixels with respect to the > pixel transfer operations. Therefore if any are set we cannot use the > simply blit fast paths. > > Signed-off-by: Chris Wilson

Re: [Mesa-dev] [PATCH] i965: Disallow fast blit paths for CopyTexImage with PixelTransfer ops

On Tue, Sep 08, 2015 at 12:33:05PM -0700, Anuj Phogat wrote: > On Sun, Sep 6, 2015 at 9:37 AM, Chris Wilson wrote: > > glCopyTexImage behaves similarly to glReadPixels with respect to the > > pixel transfer operations. Therefore if any are set we cannot use the > >

Re: [Mesa-dev] [PATCH 1/2] dri/common: embed drirc into driver binaries

On 09/06/2015 03:46 PM, Kenneth Graunke wrote: > On Sunday, September 06, 2015 10:06:38 PM Marek Olšák wrote: >> On Sun, Sep 6, 2015 at 8:38 PM, Emil Velikov >> wrote: >>> On 3 September 2015 at 20:33, Ilia Mirkin wrote: On Thu, Sep 3, 2015

Re: [Mesa-dev] [PATCH] i965: Disallow fast blit paths for CopyTexImage with PixelTransfer ops

On Tue, Sep 8, 2015 at 12:58 PM, Chris Wilson wrote: > On Tue, Sep 08, 2015 at 12:33:05PM -0700, Anuj Phogat wrote: >> On Sun, Sep 6, 2015 at 9:37 AM, Chris Wilson >> wrote: >> > glCopyTexImage behaves similarly to glReadPixels with respect to

Re: [Mesa-dev] Indirect fixes for Samplers v3

I tested this series, and found some issues: The following tests assert on g33: piglit.shaders.glsl-fwidth piglit.shaders.glsl-fs-sampler-numbering piglit.shaders.glsl-lod-bias piglit.shaders.glsl-kwin-blur-1 piglit.shaders.glsl-bug-22603 piglit.shaders.glsl-fs-texturecube

[Mesa-dev] [PATCH] st/mesa: increase viewport bounds limits for GL4 hw

According to the ARB_viewport_array spec, GL4 limit is higher than the GL3 limit. Also take this opportunity to fix the GL3 limit. Signed-off-by: Ilia Mirkin Cc: "11.0" --- src/mesa/state_tracker/st_extensions.c | 9 +++-- 1 file

Re: [Mesa-dev] [PATCH] st/mesa: increase viewport bounds limits for GL4 hw

Reviewed-by: Marek Olšák Marek On Tue, Sep 8, 2015 at 10:59 PM, Ilia Mirkin wrote: > According to the ARB_viewport_array spec, GL4 limit is higher than the > GL3 limit. Also take this opportunity to fix the GL3 limit. > > Signed-off-by: Ilia Mirkin

Re: [Mesa-dev] [PATCH v4 (part2) 25/59] glsl: number of active shader storage blocks must be within allowed limits

Reviewed-by: Jordan Justen On 2015-08-05 01:30:22, Iago Toral Quiroga wrote: > From: Samuel Iglesias Gonsalvez > > Notice that we should differentiate betweeb shader storage blocks and > uniform blocks, since they have different limits. > >

Re: [Mesa-dev] [PATCH V3 1/6] glsl: order indices for samplers inside a struct array

On Mon, Sep 7, 2015 at 3:09 PM, Timothy Arceri wrote: > On Mon, 2015-09-07 at 11:24 -0700, Jason Ekstrand wrote: >> On Tue, Sep 1, 2015 at 7:44 PM, Timothy Arceri >> wrote: >> > This allows the correct offset to be easily calculated for indirect >> >

Re: [Mesa-dev] [PATCH v4 (part2) 26/59] glsl: ignore buffer variables when counting uniform components

Reviewed-by: Jordan Justen On 2015-08-05 01:30:23, Iago Toral Quiroga wrote: > From: Samuel Iglesias Gonsalvez > > Signed-off-by: Samuel Iglesias Gonsalvez > --- > src/glsl/link_uniforms.cpp | 15 ++- > 1 file

Re: [Mesa-dev] [PATCH 00/15] Resolve further GCC sign-compare warnings

On Tue, 2015-09-08 at 20:12 +1000, Rhys Kidd wrote: > Continued progress towards addressing all GCC sign-compare warnings > across > Mesa (at least as compiled for i965 hw). > > As a new contributor, I am continuing to focus on manageable, easily > reviewed, > discrete improvements. This patchset

[Mesa-dev] [PATCH 2/3] nir: Add a pass to lower outputs to temporary variables

This pass can be used as a helper for NIR producers so they don't have to worry about creating the temporaries themselves. --- src/glsl/Makefile.sources | 1 + src/glsl/nir/nir.h | 2 + src/glsl/nir/nir_lower_outputs_to_temporaries.c | 131

[Mesa-dev] [PATCH 3/3] nir/glsl: Use lower_outputs_to_temporaries instead of relying on GLSL IR

--- src/glsl/nir/glsl_to_nir.cpp | 2 ++ src/mesa/drivers/dri/i965/brw_shader.cpp | 3 --- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/src/glsl/nir/glsl_to_nir.cpp b/src/glsl/nir/glsl_to_nir.cpp index 0712908..ad7d7dd 100644 --- a/src/glsl/nir/glsl_to_nir.cpp +++

[Mesa-dev] [PATCH 1/3] nir/cursor: Add a constructor for the end of a block but before the jump

--- src/glsl/nir/nir.h | 11 +++ src/glsl/nir/nir_from_ssa.c | 7 +-- 2 files changed, 12 insertions(+), 6 deletions(-) diff --git a/src/glsl/nir/nir.h b/src/glsl/nir/nir.h index e73b7fb..c4db005 100644 --- a/src/glsl/nir/nir.h +++ b/src/glsl/nir/nir.h @@ -1608,6 +1608,17

Re: [Mesa-dev] [PATCH] i965/fs: Fix hang on IVB and VLV with image format mismatch.

On 09/03/2015 06:03 AM, Francisco Jerez wrote: > IVB and VLV hang sporadically when an untyped surface read or write > message is used to access a surface of format other than RAW, as may > happen when there is a mismatch between the format qualifier of the > image uniform and the format of the

Re: [Mesa-dev] [PATCH] i965: Don't tell the hardware about our UAV access.

When I tested this, I saw an intermittent BSW gpu hang. I haven't been able to confirm that it is due to the host-mem-barrier test. -Mark Francisco Jerez writes: > The hardware documentation relating to the UAV HW-assisted coherency > mechanism and UAV access enable

Re: [Mesa-dev] [PATCH] i965/fs: Fix hang on IVB and VLV with image format mismatch.

This fixes a GPU hang on IVB, which is triggered with piglit.spec.arb_shader_image_load_store.invalid Tested-by: Mark Janes Francisco Jerez writes: > IVB and VLV hang sporadically when an untyped surface read or write > message is used to access

[Mesa-dev] [PATCH v2] mesa: Resolve GCC missing field initializer warning.

Resolve a series of missing field initializer warnings within get_hash_params.py Of the form: In file included from mesa/src/mesa/main/get.c:495:0: mesa/src/mesa/main/get_hash.h:180:5: warning: missing initializer for field 'extra' of 'const struct value_desc' [-Wmissing-field-initializers]

[Mesa-dev] [PATCH v2 2/3] mesa: Resolve GCC sign-compare warning.

mesa/src/mesa/program/prog_to_nir.c: In function 'setup_registers_and_variables': /mesa/src/mesa/program/prog_to_nir.c:1059:22: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] for (int i = 0; i < c->prog->NumTemporaries; i++) { ^

[Mesa-dev] [PATCH v2 0/3] Resolve further GCC sign-compare warnings

Continued progress towards addressing all GCC sign-compare warnings across Mesa (at least as compiled for i965 hw). As a new contributor, I am continuing to focus on manageable, easily reviewed, discrete improvements. This patchset resolves a number of warnings reported by GCC when configured to

[Mesa-dev] [PATCH v2 1/3] glsl: Resolve GCC sign-compare warning.

mesa/src/glsl/nir/nir_lower_tex_projector.c: In function 'nir_lower_tex_projector_block': mesa/src/glsl/nir/nir_lower_tex_projector.c:63:25: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] for (int i = 0; i < tex->num_srcs; i++) {

[Mesa-dev] [PATCH v2 3/3] i965: Resolve GCC sign-compare warning.

mesa/src/mesa/drivers/dri/i965/brw_eu_compact.c: In function 'set_3src_control_index': mesa/src/mesa/drivers/dri/i965/brw_eu_compact.c:805:22: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] for (int i = 0; i < ARRAY_SIZE(gen8_3src_control_index_table);

Re: [Mesa-dev] [PATCH 2/3] nir: Add a pass to lower outputs to temporary variables

On 09/08/2015 04:51 PM, Jason Ekstrand wrote: > This pass can be used as a helper for NIR producers so they don't have to > worry about creating the temporaries themselves. > --- > src/glsl/Makefile.sources | 1 + > src/glsl/nir/nir.h | 2 + >

Re: [Mesa-dev] [PATCH 2/3] nir: Add a pass to lower outputs to temporary variables

On Tue, Sep 8, 2015 at 5:30 PM, Ian Romanick wrote: > On 09/08/2015 04:51 PM, Jason Ekstrand wrote: >> This pass can be used as a helper for NIR producers so they don't have to >> worry about creating the temporaries themselves. >> --- >> src/glsl/Makefile.sources

[Mesa-dev] [RFC 2/3] nir: Add a pass to rewrite uses of vecN sources to the vecN destination

--- src/glsl/Makefile.sources| 1 + src/glsl/nir/nir.h | 1 + src/glsl/nir/nir_move_vec_src_uses_to_dest.c | 190 +++ 3 files changed, 192 insertions(+) create mode 100644 src/glsl/nir/nir_move_vec_src_uses_to_dest.c diff

[Mesa-dev] [RFC 3/3] i965/vec4: Use nir_move_vec_src_uses_to_dest

The idea here is not that it gives register coalescing a little bit of a helping hand. It doesn't actually fix the coalescing problems, but it seems to help a good bit. Shader-db results for vec4 programs on Haswell: total instructions in shared programs: 1801527 -> 1761720 (-2.21%)

[Mesa-dev] [RFC 1/3] nir: Add a generic instruction index

--- src/glsl/nir/nir.c | 18 ++ src/glsl/nir/nir.h | 4 2 files changed, 22 insertions(+) diff --git a/src/glsl/nir/nir.c b/src/glsl/nir/nir.c index 3f4bec4..156fe94 100644 --- a/src/glsl/nir/nir.c +++ b/src/glsl/nir/nir.c @@ -1404,3 +1404,21 @@

Re: [Mesa-dev] [PATCH] i965: Don't tell the hardware about our UAV access.

Mark Janes writes: > When I tested this, I saw an intermittent BSW gpu hang. I haven't been > able to confirm that it is due to the host-mem-barrier test. > It would probably be useful to know if the hang is due to any of the image load/store tests or if it's something

Re: [Mesa-dev] [PATCH v2 1/2] egl/dri2: Close file descriptor on error.

On 09/07/2015 01:58 AM, Emil Velikov wrote: > From: Matt Turner > > v2: [Emil Velikov] > Rework the error path to a common goto, close only if we own the fd. > > Signed-off-by: Emil Velikov > --- > src/egl/drivers/dri2/platform_drm.c | 27

[Mesa-dev] [PATCH] i965: Advertise 65536 for GL_MAX_UNIFORM_BLOCK_SIZE.

Our old value of 16384 is the minimum value. DirectX apparently requires 65536 at a minimum; that's also what nVidia and the Intel Windows driver advertise. AMD advertises MAX_INT. Ilia Mirkin noticed that "Shadow Warrior" uses UBOs larger than 16k on Nouveau, which advertises 65536 bytes for

[Mesa-dev] [PATCH v2] i965: add support for textureSamples function

Signed-off-by: Ilia Mirkin [v2: kayden-supplied code in fs_nir replacing need for logical opcode] --- v1 -> v2: - Fix sampleinfo comment in vec4 to reflect why it's necessary - Remove the LOGICAL opcode variant - Avoid calling emit_texture from fs_nir entirely, using

Re: [Mesa-dev] [PATCH 01/10] mesa: add infra for ARB_shader_texture_image_samples

On 08/27/2015 08:48 PM, Ilia Mirkin wrote: > Signed-off-by: Ilia Mirkin > --- > src/mesa/main/extensions.c | 1 + > src/mesa/main/mtypes.h | 1 + > 2 files changed, 2 insertions(+) > > diff --git a/src/mesa/main/extensions.c b/src/mesa/main/extensions.c > index

Re: [Mesa-dev] [PATCH 01/10] mesa: add infra for ARB_shader_texture_image_samples

On Tue, Sep 8, 2015 at 11:05 PM, Ian Romanick wrote: > On 08/27/2015 08:48 PM, Ilia Mirkin wrote: >> Signed-off-by: Ilia Mirkin >> --- >> src/mesa/main/extensions.c | 1 + >> src/mesa/main/mtypes.h | 1 + >> 2 files changed, 2 insertions(+) >> >>

Re: [Mesa-dev] [PATCH 01/10] mesa: add infra for ARB_shader_texture_image_samples

On 09/08/2015 08:17 PM, Ian Romanick wrote: > On 09/08/2015 08:10 PM, Ilia Mirkin wrote: >> I'll give it a shot on NVIDIA and see what happens... my tests might >> require GL 3.2 because I didn't want to deal with the various >> differences that happen otherwise. > > That should be good enough.

Re: [Mesa-dev] [PATCH 01/10] mesa: add infra for ARB_shader_texture_image_samples

On Tue, Sep 8, 2015 at 11:38 PM, Ian Romanick wrote: > On 09/08/2015 08:17 PM, Ian Romanick wrote: >> On 09/08/2015 08:10 PM, Ilia Mirkin wrote: >>> I'll give it a shot on NVIDIA and see what happens... my tests might >>> require GL 3.2 because I didn't want to deal with the

Re: [Mesa-dev] [PATCH 02/10] glsl: add ir_texture_samples texture opcode

On 08/27/2015 08:48 PM, Ilia Mirkin wrote: > Will be used for textureSamples() > > Signed-off-by: Ilia Mirkin > --- > src/glsl/ir.cpp| 5 +++-- > src/glsl/ir.h | 3 ++- > src/glsl/ir_clone.cpp |

Re: [Mesa-dev] [PATCH 01/10] mesa: add infra for ARB_shader_texture_image_samples

On 09/08/2015 08:10 PM, Ilia Mirkin wrote: > On Tue, Sep 8, 2015 at 11:05 PM, Ian Romanick wrote: >> On 08/27/2015 08:48 PM, Ilia Mirkin wrote: >>> Signed-off-by: Ilia Mirkin >>> --- >>> src/mesa/main/extensions.c | 1 + >>> src/mesa/main/mtypes.h

Re: [Mesa-dev] [PATCH 2/2] radeonsi: enable VGPR spilling on VI

On Sun, Sep 6, 2015 at 10:13 AM, Marek Olšák wrote: > From: Marek Olšák > > This fixes corruption in Unigine Heaven on VI > > Cc: 11.0 For the series: Reviewed-by: Alex Deucher > --- >

Re: [Mesa-dev] [PATCH 05/10] glsl: add support for the textureSamples function

This patch is Reviewed-by: Ian Romanick On 08/27/2015 08:48 PM, Ilia Mirkin wrote: > Signed-off-by: Ilia Mirkin > --- > src/glsl/builtin_functions.cpp | 31 +++ > 1 file changed, 31 insertions(+) > > diff --git

Re: [Mesa-dev] [PATCH] i965: Advertise 65536 for GL_MAX_UNIFORM_BLOCK_SIZE.

On 09/08/2015 06:04 PM, Kenneth Graunke wrote: > Our old value of 16384 is the minimum value. DirectX apparently > requires 65536 at a minimum; that's also what nVidia and the Intel > Windows driver advertise. AMD advertises MAX_INT. > > Ilia Mirkin noticed that "Shadow Warrior" uses UBOs

Re: [Mesa-dev] [PATCH] Use IMP_LIB_EXT when checking for LLVM shared libraries

On Mon, Sep 7, 2015 at 4:06 AM, Emil Velikov wrote: > Hi Jon, > > On 4 September 2015 at 14:00, Jon TURNEY > wrote: > > When checking for LLVM shared libraries, use IMP_LIB_EXT for the > extension for > > shared libraries appropriate to the

Re: [Mesa-dev] [PATCH] Use IMP_LIB_EXT when checking for LLVM shared libraries

On Fri, Sep 04, 2015 at 02:00:19PM +0100, Jon TURNEY wrote: > When checking for LLVM shared libraries, use IMP_LIB_EXT for the extension for > shared libraries appropriate to the target, rather than hardcoding '.so' > > Also add some comments to explain why we have this circus of pain. > >

Re: [Mesa-dev] [PATCH] Use IMP_LIB_EXT when checking for LLVM shared libraries

On Mon, Sep 07, 2015 at 10:06:49AM +0100, Emil Velikov wrote: > Hi Jon, > > On 4 September 2015 at 14:00, Jon TURNEY wrote: > > When checking for LLVM shared libraries, use IMP_LIB_EXT for the extension > > for > > shared libraries appropriate to the target, rather

Re: [Mesa-dev] [PATCH 00/15] Resolve further GCC sign-compare warnings

Hi, If you repost with the changes suggested by the others, and add the Reviewed-by tag when reposting, I'll pull these down (and the other series too), and get them merged along with one other patch I have sitting. You can add my reviewed-by to both series. Thanks for the effort =) 2015-09-08

Re: [Mesa-dev] [PATCH v4 (part2) 24/59] glsl: a shader storage buffer must be smaller than the maximum size allowed

On 2015-08-05 01:30:21, Iago Toral Quiroga wrote: > From: Samuel Iglesias Gonsalvez > > Otherwise, generate a link time error as per the > ARB_shader_storage_buffer_object spec. > > Signed-off-by: Samuel Iglesias Gonsalvez > --- >

Re: [Mesa-dev] [PATCH v4 (part2) 23/59] glsl: add std430 interface packing support to ssbo store and unsized array length

On 2015-08-05 01:30:20, Iago Toral Quiroga wrote: > From: Samuel Iglesias Gonsalvez > > Signed-off-by: Samuel Iglesias Gonsalvez > --- > src/glsl/lower_ubo_reference.cpp | 65 > ++-- > 1 file changed, 49

Re: [Mesa-dev] [PATCH 2/6] r600g: apply disable workaround on all scissors

On 2015.09.03 at 01:54 +0300, Grazvydas Ignotas wrote: > During review of the "r600g: make all scissor states use single atom" patch > Marek Olšák noticed that scissor disable workaround should be applied on > all scissor states and not just first one, so let's do so. This patch causes:

Re: [Mesa-dev] [PATCH] i965/gen8+: Skip depth stalls on state change

Ben Widawsky writes: > On Fri, Sep 04, 2015 at 02:58:30PM -0700, Ben Widawsky wrote: >> On Wed, Sep 02, 2015 at 01:03:43PM +0100, Chris Wilson wrote: >> > On Wed, Aug 26, 2015 at 10:52:58AM -0700, Ben Widawsky wrote: >> > > Docs suggest this is no longer required starting with

Re: [Mesa-dev] [PATCH 3/5] nir: Add new GS intrinsics that maintain a count of emitted vertices.

On Tue, Sep 8, 2015 at 2:24 AM, Kenneth Graunke wrote: > On Monday, September 07, 2015 10:51:37 AM Jason Ekstrand wrote: >> On Sep 3, 2015 1:49 AM, "Kenneth Graunke" wrote: >> > >> > This patch also introduces a lowering pass to convert the simple GS

Re: [Mesa-dev] [PATCH] i965: Advertise 65536 for GL_MAX_UNIFORM_BLOCK_SIZE.

On Tuesday, September 08, 2015 08:50:41 PM Ian Romanick wrote: > On 09/08/2015 06:04 PM, Kenneth Graunke wrote: > > Our old value of 16384 is the minimum value. DirectX apparently > > requires 65536 at a minimum; that's also what nVidia and the Intel > > Windows driver advertise. AMD advertises

Re: [Mesa-dev] Indirect fixes for Samplers v3

On Tue, 2015-09-08 at 15:25 -0700, Mark Janes wrote: > I tested this series, and found some issues: > > The following tests assert on g33: > piglit.shaders.glsl-fwidth > piglit.shaders.glsl-fs-sampler-numbering > piglit.shaders.glsl-lod-bias > piglit.shaders.glsl-kwin-blur-1 >

Re: [Mesa-dev] [PATCH 1/2] glsl/cs: Exclude gl_LocalInvocationIndex from builtin variable stripping

These 2 patches are Reviewed-by: Tapani Pälli On 08/23/2015 11:50 AM, Jordan Justen wrote: We lower gl_LocalInvocationIndex based on the extension spec formula: gl_LocalInvocationIndex = gl_LocalInvocationID.z * gl_WorkGroupSize.x * gl_WorkGroupSize.y +

Re: [Mesa-dev] [PATCH 01/10] mesa: add infra for ARB_shader_texture_image_samples

On Tue, Sep 8, 2015 at 11:46 PM, Ilia Mirkin wrote: > On Tue, Sep 8, 2015 at 11:38 PM, Ian Romanick wrote: >> On 09/08/2015 08:17 PM, Ian Romanick wrote: >>> On 09/08/2015 08:10 PM, Ilia Mirkin wrote: I'll give it a shot on NVIDIA and see what

Re: [Mesa-dev] [PATCH] i965: Don't tell the hardware about our UAV access.

Francisco Jerez writes: > Mark Janes writes: > >> When I tested this, I saw an intermittent BSW gpu hang. I haven't been >> able to confirm that it is due to the host-mem-barrier test. >> > It would probably be useful to know if the hang is due to

Re: [Mesa-dev] [PATCH 1/5] nir: Don't insert a fake link if unnecessary.

On Saturday, September 05, 2015 11:10:58 AM Connor Abbott wrote: > On Sat, Sep 5, 2015 at 2:31 AM, Kenneth Graunke wrote: > > On Friday, September 04, 2015 11:56:29 AM Connor Abbott wrote: > >> I'm confused as to how this can happen. The fake link is only for the > >>