Re: [Mesa-dev] [PATCH 1/2] mesa: don't use genned but unnammed xfb objects.

On Monday, May 9, 2016 4:22:21 PM PDT Dave Airlie wrote: > From: Dave Airlie > > If we try to draw or query an XFB object that hasn't been bound, > we shouldn't return any information. > > This fixes a couple if cases in: > GL33-CTS.transform_feedback.api_errors_test > > The ObjectLabel test is

Re: [Mesa-dev] [PATCH] r300g: fix big endian support

On 01.05.2016 23:11, Marek Olšák wrote: > From: Marek Olšák > > The problem was that A8R8G8B8 was not supported, which is required > for DRI2 window framebuffers on BE. > > This patch: > - adds support for ARGB 32bpp array formats for LE & BE using byteswapping > - sets endian swap for packed fo

Re: [Mesa-dev] [PATCH] Revert "i965: Always use Y-tiled buffers on SKL+"

Hi, On 08-05-16 13:15, Daniel Stone wrote: Hi, I'd already suggested the same, but it never got pushed: https://lists.freedesktop.org/archives/mesa-dev/2016-May/115501.html So I guess we can add the Tested-by from the other, for whichever gets pushed. Your commit message seems better as it ac

Re: [Mesa-dev] [PATCH 4/4] gallium/radeon: align alignments for better buffer reuse

On Mon, May 9, 2016 at 5:59 AM, Michel Dänzer wrote: > On 08.05.2016 21:21, Marek Olšák wrote: >> From: Marek Olšák >> >> --- >> src/gallium/winsys/amdgpu/drm/amdgpu_bo.c | 1 + >> src/gallium/winsys/radeon/drm/radeon_drm_bo.c | 1 + >> 2 files changed, 2 insertions(+) >> >> diff --git a/src

Re: [Mesa-dev] [PATCH 4/4] gallium/radeon: align alignments for better buffer reuse

On 09.05.2016 17:02, Bas Nieuwenhuizen wrote: > On Mon, May 9, 2016 at 5:59 AM, Michel Dänzer wrote: >> On 08.05.2016 21:21, Marek Olšák wrote: >>> From: Marek Olšák >>> >>> --- >>> src/gallium/winsys/amdgpu/drm/amdgpu_bo.c | 1 + >>> src/gallium/winsys/radeon/drm/radeon_drm_bo.c | 1 + >>>

Re: [Mesa-dev] [PATCH] Revert "i965: Always use Y-tiled buffers on SKL+"

Hi, On 8 May 2016 at 20:05, Ben Widawsky wrote: > On Sun, May 08, 2016 at 12:15:00PM +0100, Daniel Stone wrote: >> I'd already suggested the same, but it never got pushed: >> https://lists.freedesktop.org/archives/mesa-dev/2016-May/115501.html >> >> So I guess we can add the Tested-by from the ot

Re: [Mesa-dev] [PATCH v2] glsl: Copy propagate in array index function parameters

On Fri, 2016-05-06 at 12:23 -0400, Ilia Mirkin wrote: > Could you add something to piglit which tries this with AoA to make > sure that your logic is right? Sure. I've submitted a couple of tests that use another array for array indexing. https://lists.freedesktop.org/archives/piglit/2016-May/

Re: [Mesa-dev] [PATCH 03/14] gallium/radeon: use a common function for DMA blit preparation

On Sun, May 8, 2016 at 6:11 PM, Nicolai Hähnle wrote: > On 04.05.2016 18:43, Marek Olšák wrote: >> >> From: Marek Olšák >> >> this is more robust and probably fixes some bugs already >> --- >> src/gallium/drivers/r600/evergreen_state.c| 10 ++--- >> src/gallium/drivers/r600/r600_state.c

[Mesa-dev] [PATCH] gallium/radeon: fix partial layered transfers of cube (array) textures

From: Marek Olšák a staging cube texture with array_size % 6 != 0 doesn't work very well just use 2D_ARRAY or 2D for all staging textures Cc: 11.1 11.2 --- src/gallium/drivers/radeon/r600_texture.c | 21 ++--- 1 file changed, 6 insertions(+), 15 deletions(-) diff --git a/src/

[Mesa-dev] [PATCH] st/mesa: use transfer_inline_write for memcpy TexSubImage path

From: Marek Olšák This allows drivers to use their own fast path for texture uploads. --- src/mesa/state_tracker/st_cb_texture.c | 43 ++ 1 file changed, 39 insertions(+), 4 deletions(-) diff --git a/src/mesa/state_tracker/st_cb_texture.c b/src/mesa/state_tracke

[Mesa-dev] [Bug 93551] Divinity: Original Sin Enhanced Edition(Native) crash on start

https://bugs.freedesktop.org/show_bug.cgi?id=93551 --- Comment #26 from Karol Herbst --- (In reply to kilobug from comment #25) > Perhaps it's due to LLVM version, for the Intel vs radeonsi ? I tried with > llvm 3.8, and some of OpenGL 4.2 extensions require llvm 3.9... but I've to > admit it sca

Re: [Mesa-dev] [PATCH] gallivm: disable avx512 features

08.05.2016, 17:02, srol...@vmware.com kirjoitti: > From: Roland Scheidegger > > We don't target this yet, and some llvm versions incorrectly enable it based > on cpu string, causing crashes. > (Albeit this is a losing battle, it is pretty much guaranteed when the next > new feature comes along ll

Re: [Mesa-dev] [PATCH v2] glsl: Copy propagate in array index function parameters

Reviewed-by: Lars Hamre On Fri, May 6, 2016 at 11:54 AM, Juan A. Suarez Romero wrote: > Copy propagate is not applied in function parameters when they are out > or inout. > > But if the parameter is an array, we can copy propagate the index array. > > This also fixes shaders@out-parameter-indexi

Re: [Mesa-dev] [PATCH] gallivm: disable avx512 features

On 08/05/16 07:02, srol...@vmware.com wrote: From: Roland Scheidegger We don't target this yet, and some llvm versions incorrectly enable it based on cpu string, causing crashes. (Albeit this is a losing battle, it is pretty much guaranteed when the next new feature comes along llvm will mistak

Re: [Mesa-dev] [PATCH] gallivm: use InternalLinkage instead of PrivateLinkage for texture functions

On 07/05/16 17:29, srol...@vmware.com wrote: From: Roland Scheidegger At least with MCJIT the disassembler will crash otherwise when trying to disassemble such functions. --- src/gallium/auxiliary/gallivm/lp_bld_sample_soa.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a

Re: [Mesa-dev] About tolerance calculation on specific (builtin) functions

On Wed, 2016-05-04 at 13:48 -0400, Ilia Mirkin wrote: > On Wed, May 4, 2016 at 1:41 PM, Connor Abbott > wrote: > > > > On Wed, May 4, 2016 at 1:05 PM, Andres Gomez > > wrote: > > > > > > Hi, > > > > > > as part of the work done to "Add FP64 support to the i965 shader > > > backends" at: > > >

[Mesa-dev] [PATCH v2] glsl: enforce invariant conditions for built-in variables

v2: - ES version check (Tapani Pälli) The conditions for which certain built-in special variables can be declared invariant were not being checked. GLSL ES 1.00 specification, Section "Invariance and linkage" says: For the built-in special variables, gl_FragCoord can only be declared invariant

Re: [Mesa-dev] [PATCH v2] glsl: enforce invariant conditions for built-in variables

You should be able to check for the slot, which is faster than a strcmp. Also in the second if, you can hoist the invariant check up to the second containing if to avoid a bit of unnecessary work. On May 9, 2016 9:46 AM, "Lars Hamre" wrote: > v2: > - ES version check (Tapani Pälli) > > The condi

[Mesa-dev] [PATCH] swr: Add missing break in query switch statement.

Missed a switch break in query stat collection when refactoring queries. --- src/gallium/drivers/swr/swr_query.cpp |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/src/gallium/drivers/swr/swr_query.cpp b/src/gallium/drivers/swr/swr_query.cpp index 5c59965..7867db3 100644 -

[Mesa-dev] Mesa 11.2.2

Hi all, Mesa 11.2.2 is now available. With this release we have dri2/dri3 fixes for libGL, libEGL now works for OpenBSD platforms, big endian support for radeons has improved, and the i965, nouveau and vc4 drivers have gained misc fixes. MangledGL GetProcAddress works correctly and the dri module

[Mesa-dev] Mesa 11.1.4

Hi all, Mesa 11.1.4 is now available. NOTE: It is anticipated that 11.1.4 will be the final release in the 11.1.4 series. Users of 11.1 are encouraged to migrate to the 11.2 series in order to obtain future fixes. With this release we have dri2/dri3 fixes for libGL, libEGL now works for OpenBSD

Re: [Mesa-dev] [PATCH 1/5] glsl: Make opt_constant_variable() bail in useless cases.

Hey Kenneth, while hunting the cause of fdo#95285 down, I tested these patches from your tombraider-2 branch. But when applied the game started crashing, see . Now, it might be that the omitted "glsl: Make lower_const_arrays_to_uniforms work di

Re: [Mesa-dev] [PATCH] Added pbuffer hooks for surfaceless platform

Gurchetan Singh writes: > This change enables the creation of pbuffer > surfaces on the surfaceless platform. > > V2: Use double-buffered pbuffer configuration > --- > src/egl/drivers/dri2/egl_dri2.h | 8 +- > src/egl/drivers/dri2/platform_surfaceless.c | 219 > +++

Re: [Mesa-dev] [PATCH v2 mesa] vk/intel: use negative VK_NO_PROTOTYPES scheme

On Sun, May 01, 2016 at 09:39:58PM -0700, Jason Ekstrand wrote: > On May 1, 2016 6:04 PM, "Kenneth Graunke" wrote: > > On Sunday, May 1, 2016 9:51:00 AM PDT Emil Velikov wrote: > > > Adding the anv authors. > > > > > > Jason, Chad, is there a canonical place where changes to > > > vulkan_intel.h s

Re: [Mesa-dev] [PATCH] mesa: Deal with size differences between GLuint and GLhandleARB in GetAttachedObjectsARB

On 05/08/2016 02:38 AM, Jeremy Huddleston Sequoia wrote:> Signed-off-by: Jeremy Huddleston Sequoia CC: Nicolai Hähnle CC: Matt Turner CC: Ian Romanick --- src/mesa/main/shaderapi.c | 26 +- 1 file changed, 25 insertions(+), 1 deletion(-) diff --git a/src/mesa/main/

Re: [Mesa-dev] [PATCH] swr: Add missing break in query switch statement.

Reviewed-by: George Kyriazis > -Original Message- > From: mesa-dev [mailto:mesa-dev-boun...@lists.freedesktop.org] On > Behalf Of BruceCherniak > Sent: Monday, May 9, 2016 9:00 AM > To: mesa-dev@lists.freedesktop.org > Subject: [Mesa-dev] [PATCH] swr: Add missing break in query switch > s

[Mesa-dev] [PATCH 8/8] radeonsi/sid_tables: rename reg_table to sid_reg_table

From: Nicolai Hähnle This is purely cosmetic, making it easier to assign blame for space used in the binary in case somebody else makes a similar cleanup effort in the future. --- src/gallium/drivers/radeonsi/si_debug.c| 4 ++-- src/gallium/drivers/radeonsi/sid_tables.py | 2 +- 2 files chan

[Mesa-dev] [PATCH 6/8] radeonsi/sid_tables: store strings by offset instead of by pointer

From: Nicolai Hähnle This saves some space and avoids the need for relocations. --- src/gallium/drivers/radeonsi/si_debug.c| 22 +++-- src/gallium/drivers/radeonsi/sid_tables.py | 147 + 2 files changed, 141 insertions(+), 28 deletions(-) diff --git a/src/galliu

[Mesa-dev] [PATCH 3/8] r600: move cf_op_table to .c file

From: Nicolai Hähnle So that it gets compiled and emitted only once, saving space is the final binary. --- src/gallium/drivers/r600/r600_isa.c | 109 +++ src/gallium/drivers/r600/r600_isa.h | 110 +--- 2 files changed, 111 insertion

[Mesa-dev] [PATCH 0/8] gallium/radeon: reduce read-only data with relocations

Hi, two sets of changes to reduce the size of the .data.rel.ro segment in the driver binary. This segment contains data that is supposedly read-only, but contains relocations and must therefore be modified by the dynamic linker. This means the segment cannot be shared between processes, and it inc

[Mesa-dev] [PATCH 2/8] r600: move fetch_op_table to .c file

From: Nicolai Hähnle So that it gets compiled and emitted only once, saving space is the final binary. --- src/gallium/drivers/r600/r600_isa.c | 119 +++ src/gallium/drivers/r600/r600_isa.h | 120 +--- 2 files changed, 121 insertion

[Mesa-dev] [PATCH 7/8] radeonsi/sid_tables: store offset into global fields table instead of pointer

From: Nicolai Hähnle This avoids relocations in the final binary. --- src/gallium/drivers/radeonsi/si_debug.c| 2 +- src/gallium/drivers/radeonsi/sid_tables.py | 23 +++ 2 files changed, 16 insertions(+), 9 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_debug

[Mesa-dev] [PATCH 5/8] r600: remove TABLE_SIZE macro

From: Nicolai Hähnle Use ARRAY_SIZE instead. --- src/gallium/drivers/r600/r600_isa.c | 4 ++-- src/gallium/drivers/r600/r600_isa.h | 2 -- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/src/gallium/drivers/r600/r600_isa.c b/src/gallium/drivers/r600/r600_isa.c index 044f45c..2633

[Mesa-dev] [PATCH 4/8] r600: move alu_op_table to .c file

From: Nicolai Hähnle So that it gets compiled and emitted only once, saving space is the final binary. --- src/gallium/drivers/r600/r600_isa.c | 283 +- src/gallium/drivers/r600/r600_isa.h | 279 + src/gallium/drivers/r600/sb/sb

[Mesa-dev] [PATCH 1/8] r600: protect r600_isa.h with extern "C"

From: Nicolai Hähnle --- src/gallium/drivers/r600/r600_isa.h | 8 1 file changed, 8 insertions(+) diff --git a/src/gallium/drivers/r600/r600_isa.h b/src/gallium/drivers/r600/r600_isa.h index b3f49bd..005b580 100644 --- a/src/gallium/drivers/r600/r600_isa.h +++ b/src/gallium/drivers/r6

Re: [Mesa-dev] [PATCH 03/14] gallium/radeon: use a common function for DMA blit preparation

On 09.05.2016 06:29, Marek Olšák wrote: On Sun, May 8, 2016 at 6:11 PM, Nicolai Hähnle wrote: On 04.05.2016 18:43, Marek Olšák wrote: From: Marek Olšák this is more robust and probably fixes some bugs already --- src/gallium/drivers/r600/evergreen_state.c| 10 ++--- src/gallium/dri

Re: [Mesa-dev] [PATCH 1/4] winsys/amdgpu: move gart_page_size to struct radeon_winsys

For the series: Reviewed-by: Nicolai Hähnle On 08.05.2016 07:21, Marek Olšák wrote: From: Marek Olšák --- src/gallium/drivers/radeon/radeon_winsys.h| 1 + src/gallium/winsys/amdgpu/drm/amdgpu_bo.c | 16 src/gallium/winsys/amdgpu/drm/amdgpu_winsys.c | 2 +- src

Re: [Mesa-dev] [PATCH] gallium/radeon: fix partial layered transfers of cube (array) textures

Reviewed-by: Nicolai Hähnle On 09.05.2016 06:37, Marek Olšák wrote: From: Marek Olšák a staging cube texture with array_size % 6 != 0 doesn't work very well just use 2D_ARRAY or 2D for all staging textures Cc: 11.1 11.2 --- src/gallium/drivers/radeon/r600_texture.c | 21 ++---

Re: [Mesa-dev] [PATCH] st/mesa: use transfer_inline_write for memcpy TexSubImage path

Looks good to me, though perhaps somebody wants to chime in about how it affects other drivers. Reviewed-by: Nicolai Hähnle On 09.05.2016 06:38, Marek Olšák wrote: From: Marek Olšák This allows drivers to use their own fast path for texture uploads. --- src/mesa/state_tracker/st_cb_textur

Re: [Mesa-dev] [PATCH] st/mesa: use transfer_inline_write for memcpy TexSubImage path

FWIW nouveau (nv30,nv50,nvc0) all use u_default_transfer_inline_write. If that's not what radeon uses, I'd appreciate it if you could test it out with that in the vtable. I may not be able to test myself for at least a day. On Mon, May 9, 2016 at 12:42 PM, Nicolai Hähnle wrote: > Looks good to me

[Mesa-dev] Fwd: Your message to mesa-dev awaits moderator approval

hmm, maybe the get_reviewer.pl script needs to be a bit less ambitious, or possibly mesa-dev needs to allow more CC's.. although I don't think 10 CC's is *that* excessive.. BR, -R -- Forwarded message -- From: Date: Mon, May 9, 2016 at 12:52 PM Subject: Your message to mesa-dev

Re: [Mesa-dev] [PATCH] st/mesa: use transfer_inline_write for memcpy TexSubImage path

On Mon, May 9, 2016 at 6:47 PM, Ilia Mirkin wrote: > FWIW nouveau (nv30,nv50,nvc0) all use u_default_transfer_inline_write. > If that's not what radeon uses, I'd appreciate it if you could test it > out with that in the vtable. I may not be able to test myself for at > least a day. Radeon does us

[Mesa-dev] [PATCH 1/3] nir: return progress from lower_idiv

From: Rob Clark With algebraic-opt support for lowering div to shift, the driver would like to be able to run this pass *after* the main opt-loop, and then conditionally re-run the opt-loop if this pass actually lowered some- thing. Signed-off-by: Rob Clark --- src/compiler/nir/nir.h

[Mesa-dev] [PATCH 3/3] freedreno/ir3: do idiv lowering after main opt loop

From: Rob Clark Give algebraic-opt pass a chance to catch udiv by const power-of-two, before running lower-idiv pass. Signed-off-by: Rob Clark --- src/gallium/drivers/freedreno/ir3/ir3_nir.c | 43 ++--- 1 file changed, 27 insertions(+), 16 deletions(-) diff --git a/src

Re: [Mesa-dev] [PATCH v2 56/59] i965/fs: push first double-based uniforms in push constant buffer

Kenneth Graunke writes: > On Monday, May 9, 2016 7:33:02 AM PDT Samuel Iglesias Gonsálvez wrote: >> >> On 09/05/16 07:21, Pohjolainen, Topi wrote: >> > On Fri, May 06, 2016 at 08:56:08AM +0200, Samuel Iglesias Gons?lvez wrote: >> >> When there is a mix of definitions of uniforms with 32-bit or 6

Re: [Mesa-dev] [04.5/11] i965: Add flag telling if miptree is for client consumption

On Fri, May 06, 2016 at 09:08:41PM +0300, Pohjolainen, Topi wrote: > On Thu, May 05, 2016 at 07:08:15PM -0700, Ben Widawsky wrote: > > On Mon, Apr 25, 2016 at 08:10:01PM +0300, Topi Pohjolainen wrote: > > > Signed-off-by: Topi Pohjolainen > > > --- > > > src/mesa/drivers/dri/i965/intel_mipmap_tre

Re: [Mesa-dev] [v6 05/11] i965: Deferred allocation of mcs for lossless compressed

On Fri, May 06, 2016 at 11:38:25AM +0300, Topi Pohjolainen wrote: > Until now mcs was associated to single sampled buffers only for > fast clear purposes and it was therefore the responsibility of the > clear logic to allocate the aux buffer when needed. Now that normal > 3D render or blorp blit ma

[Mesa-dev] [PATCH 2/3] nir/algebraic: support for power-of-two optimizations

From: Rob Clark It was kinda sad that we couldn't optimize imul/idiv by power-of-two. So I bashed my head against python for a while and this is what I came up with. In the search expression, you can use "#a^2" to only match constants which are a power of two. The rest is taken care of w/ norma

Re: [Mesa-dev] [v6 05/11] i965: Deferred allocation of mcs for lossless compressed

On Mon, May 09, 2016 at 10:29:28AM -0700, Ben Widawsky wrote: > On Fri, May 06, 2016 at 11:38:25AM +0300, Topi Pohjolainen wrote: > > Until now mcs was associated to single sampled buffers only for > > fast clear purposes and it was therefore the responsibility of the > > clear logic to allocate th

Re: [Mesa-dev] [PATCH 2/3] nir/algebraic: support for power-of-two optimizations

On Mon, May 9, 2016 at 12:52 PM, Rob Clark wrote: > From: Rob Clark > > It was kinda sad that we couldn't optimize imul/idiv by power-of-two. > So I bashed my head against python for a while and this is what I came > up with. In the search expression, you can use "#a^2" to only match > constants

Re: [Mesa-dev] [PATCH 1/2] mesa: don't use genned but unnammed xfb objects.

On 05/09/2016 08:22 AM, Dave Airlie wrote: > From: Dave Airlie > > If we try to draw or query an XFB object that hasn't been bound, > we shouldn't return any information. > > This fixes a couple if cases in: > GL33-CTS.transform_feedback.api_errors_test > > The ObjectLabel test is inspired by a

Re: [Mesa-dev] [PATCH 2/2] mesa/objectlabel: don't return info on genned but never bound textures.

On 05/09/2016 08:22 AM, Dave Airlie wrote: > From: Dave Airlie > > This fixes some cases in the CTS KHR debug tests where it uses > glIsTexture to find an invalid ID and then call GetObjectLabel. > > Signed-off-by: Dave Airlie > --- > src/mesa/main/objectlabel.c | 3 ++- > 1 file changed, 2 in

Re: [Mesa-dev] [v4 07/11] i965/blorp: Do not resolve lossless compressed blit sources

On Thu, Apr 21, 2016 at 02:59:02PM +0300, Topi Pohjolainen wrote: > Blorp blits use sampling engine which is capable of resolving > on the fly. We determined blitter does need the resolve? With that info added to the commit message: Reviewed-by: Ben Widawsky > > Signed-off-by: Topi Pohjolainen

Re: [Mesa-dev] [PATCH 2/5] glsl: Remove bonus tree walking in opt_constant_folding().

This patch is Reviewed-by: Ian Romanick On 05/09/2016 08:50 AM, Kenneth Graunke wrote: > It looks like this was missed when converting opt_constant_folding() > from a hierarchical visitor to an rvalue visitor in 6606fde3. > > ir_rvalue_visitor already processes values on the way back up the tre

Re: [Mesa-dev] [PATCH 1/5] glsl: Make opt_constant_variable() bail in useless cases.

On 05/09/2016 08:50 AM, Kenneth Graunke wrote: > The pass ultimately skips over any entries with assignment_count != 1, > so there's no need to do further work once we've determined that there > are multiple assignments. > > The constant value could be a large array (i.e. uvec4[327]), at which > p

Re: [Mesa-dev] [v4 08/11] i965/gen9: Setup MCS for compressed texture surfaces

On Thu, Apr 21, 2016 at 02:59:03PM +0300, Topi Pohjolainen wrote: > Signed-off-by: Topi Pohjolainen Reviewed-by: Ben Widawsky > --- > src/mesa/drivers/dri/i965/gen8_surface_state.c | 9 + > 1 file changed, 5 insertions(+), 4 deletions(-) > > diff --git a/src/mesa/drivers/dri/i965/gen8_

Re: [Mesa-dev] [PATCH 1/3] glsl: Apply memory qualifiers to vars inside named block interfaces

This is a heads-up that the piglit tests related to this bug have been merged in trunk (thanks Ilia for the review), so expect the 4 tests to fail until this patch is merged. Eduardo On 05/05/2016 01:52 PM, Eduardo Lima Mitev wrote: > This is missing and memory qualifiers are currently being igno

Re: [Mesa-dev] [PATCH 3/5] glsl: Consolidate duplicate copies of constant folding.

This patch is Reviewed-by: Ian Romanick On 05/09/2016 08:50 AM, Kenneth Graunke wrote: > We could probably clean this up more (maybe make it a method), but at > least there's only one copy of this code now, and that's a start. > > No change in shader-db. > > Signed-off-by: Kenneth Graunke > -

Re: [Mesa-dev] [PATCH 1/3] glsl: Apply memory qualifiers to vars inside named block interfaces

On 05/09/2016 07:47 PM, Eduardo Lima Mitev wrote: > This is a heads-up that the piglit tests related to this bug have been > merged in trunk (thanks Ilia for the review), so expect the 4 tests to > fail until this patch is merged. > For reference, the patch adding the tests: https://cgit.freedes

Re: [Mesa-dev] [PATCH 4/5] glsl: Avoid excess tree walking when folding ir_dereference_arrays.

This patch is Reviewed-by: Ian Romanick On 05/09/2016 08:50 AM, Kenneth Graunke wrote: > If an ir_dereference_array has non-constant components, there's no > point in trying to evaluate its value (which involves walking down > the tree and possibly allocating memory for portions of the subtree >

Re: [Mesa-dev] [PATCH 5/5] glsl: Don't do constant propagation in opt_constant_folding.

This patch is Reviewed-by: Ian Romanick On 05/09/2016 08:50 AM, Kenneth Graunke wrote: > opt_constant_folding is supposed to fold trees of constants into a > single constant. Surprisingly, it was also propagating constant values > from variables into expression trees - even when the result coul

Re: [Mesa-dev] [v4 07/11] i965/blorp: Do not resolve lossless compressed blit sources

On Mon, May 09, 2016 at 10:39:44AM -0700, Ben Widawsky wrote: > On Thu, Apr 21, 2016 at 02:59:02PM +0300, Topi Pohjolainen wrote: > > Blorp blits use sampling engine which is capable of resolving > > on the fly. > > We determined blitter does need the resolve? With that info added to the > commit

Re: [Mesa-dev] [PATCH] glsl: remove trailing comma in enum lists to silence warning

On 05/03/2016 10:17 PM, Eric Anholt wrote: > Brian Paul writes: > >> On 05/02/2016 06:15 PM, Ilia Mirkin wrote: >>> I know I've been sticking commas at the end of enums left and right >>> for the past several years, and haven't heard any complaints. The nice >>> thing about the trailing comma is

Re: [Mesa-dev] [PATCH v3 02/11] mesa/main: Add support for GL_ARB_cull_distance (v2)

On 05/08/2016 10:44 PM, Tobias Klausmann wrote: > airlied: > v2: rename LowerClipDistance to LowerCombinedClipCullDistnace. > I don't think we want any other behaviour with any current hw. > > Signed-off-by: Tobias Klausmann > Reviewed-by: Edward O'Callaghan > --- > src/compiler/glsl/link_varyi

Re: [Mesa-dev] [PATCH v3 05/11] glsl: Extend lowering pass for gl_ClipDistance to support other arrays (v2)

I have a few comments below, but this patch was pretty hard to review because it combines a global rename with functional changes. Please split this into two patches. On 05/08/2016 10:44 PM, Tobias Klausmann wrote: > This will come in handy when we want to lower gl_CullDistance into > gl_CullDist

Re: [Mesa-dev] [PATCH] Revert "i965: Always use Y-tiled buffers on SKL+"

On Mon, May 9, 2016 at 2:40 AM, Daniel Stone wrote: > Hi, > > On 8 May 2016 at 20:05, Ben Widawsky wrote: >> On Sun, May 08, 2016 at 12:15:00PM +0100, Daniel Stone wrote: >>> I'd already suggested the same, but it never got pushed: >>> https://lists.freedesktop.org/archives/mesa-dev/2016-May/1155

Re: [Mesa-dev] [PATCH] i965: Clamp "Maximum VP Index" to 1 when gl_ViewportIndex isn't written.

Reviewed-by: Matt Turner ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH v3 06/11] glsl: Add arb_cull_distance support

On 05/08/2016 10:44 PM, Tobias Klausmann wrote: > Signed-off-by: Tobias Klausmann > --- > src/compiler/glsl/ast_to_hir.cpp | 14 > src/compiler/glsl/builtin_variables.cpp | 11 ++- > src/compiler/glsl/glcpp/glcpp-parse.y| 3 + > src/compiler/glsl/glsl_parser_extr

Re: [Mesa-dev] [PATCH 1/3] glsl: Apply memory qualifiers to vars inside named block interfaces

Patches 1 and 2 are Reviewed-by: Ian Romanick I don't have a strong opinion about patch 3, so I'll call that Acked-by: Ian Romanick On 05/05/2016 01:52 PM, Eduardo Lima Mitev wrote: > This is missing and memory qualifiers are currently being ignored for SSBOs. > --- > src/compiler/glsl/ast_t

Re: [Mesa-dev] [PATCH 0/4] Delete some useless Mesa IR bits

ping On 04/19/2016 08:22 PM, Ian Romanick wrote: > While doing some other work, I noticed that prog_to_nir supported SLE, > SGT, SNE, and SEQ. It's impossible for those opcodes to occur in the > prog_to_nir path because that could only have come from the > NV_vertex_program2 (or other NV assembly

Re: [Mesa-dev] [PATCH 1/5] compiler: guard list iteration macros against undefined behavior

On Sat, May 7, 2016 at 3:05 PM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > The old iteration casts sentinel nodes (which are mere exec_nodes) into > whatever type we're looping over, which leads to badness (in fact, gcc's > undefined behaviour sanitizer crashes while trying to verify that w

[Mesa-dev] [Bug 95215] ARB_shading_language_include is not implemented

https://bugs.freedesktop.org/show_bug.cgi?id=95215 Ian Romanick changed: What|Removed |Added CC||i...@freedesktop.org --- Comment #12 from

Re: [Mesa-dev] [PATCH 0/4] Delete some useless Mesa IR bits

The series is Reviewed-by: Matt Turner ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [04.5/11] i965: Add flag telling if miptree is for client consumption

On Mon, May 09, 2016 at 10:26:59AM -0700, Ben Widawsky wrote: > On Fri, May 06, 2016 at 09:08:41PM +0300, Pohjolainen, Topi wrote: > > On Thu, May 05, 2016 at 07:08:15PM -0700, Ben Widawsky wrote: > > > On Mon, Apr 25, 2016 at 08:10:01PM +0300, Topi Pohjolainen wrote: > > > > Signed-off-by: Topi Po

Re: [Mesa-dev] [PATCH 3/7] i965: Create multiple miptrees planar YUV images

"Pohjolainen, Topi" writes: > On Thu, May 05, 2016 at 05:04:02PM -0700, Kristian H?gsberg wrote: >> From: Kristian Høgsberg Kristensen >> >> --- >> src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 3 ++ >> src/mesa/drivers/dri/i965/intel_mipmap_tree.h | 5 ++ >> src/mesa/drivers/dri/i965/inte

Re: [Mesa-dev] [PATCH v3 06/11] glsl: Add arb_cull_distance support

On 09.05.2016 20:41, Ian Romanick wrote: snip + /* From the ARB_cull_distance spec: + * + * It is a compile-time or link-time error for the set of shaders forming + * a program to have the sum of the sizes of the gl_ClipDistance and + * gl_CullDistance arrays to be

[Mesa-dev] [PATCH] anv/copy: Fix Copying between Buffers and Images of different dimensions

From: Nanley Chery This function previously assumed that the Buffer and Image had matching dimensions. However, it is possible to copy from a buffer with larger dimensions than the image. Modify the copy function to enable this. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=95292 Signed

Re: [Mesa-dev] [PATCH] glsl: remove trailing comma in enum lists to silence warning

Ian Romanick writes: > On 05/03/2016 10:17 PM, Eric Anholt wrote: >> Brian Paul writes: >> >>> On 05/02/2016 06:15 PM, Ilia Mirkin wrote: I know I've been sticking commas at the end of enums left and right for the past several years, and haven't heard any complaints. The nice thi

[Mesa-dev] [PATCH 01/17] scons: Build NIR.

From: Jose Fonseca Signed-off-by: Rob Clark --- src/compiler/SConscript | 57 +++-- 1 file changed, 55 insertions(+), 2 deletions(-) diff --git a/src/compiler/SConscript b/src/compiler/SConscript index 10c79c4..dde4dfd 100644 --- a/src/compiler/SCons

[Mesa-dev] [PATCH 00/17] gallium: add support for NIR as alternate IR

From: Rob Clark Not much changed from last time, other than rebasing or nir iterator macro changes, and pulling in Jose's patch to add scons support to build NIR. Hopefully we can get some r-b's for the few remaining patches, so I can do something else other than rebasing on NIR churn forever ;-

[Mesa-dev] [PATCH 05/17] nir: add lowering pass for glDrawPixels

From: Rob Clark Signed-off-by: Rob Clark Reviewed-by: Connor Abbott --- src/compiler/Makefile.sources | 1 + src/compiler/nir/nir.h | 13 ++ src/compiler/nir/nir_lower_drawpixels.c | 254 3 files changed, 268 insertions(+) create

[Mesa-dev] [PATCH 07/17] nir: passthrough-edgeflags support

From: Rob Clark Handled by tgsi_emulate for glsl->tgsi case. Signed-off-by: Rob Clark Reviewed-by: Connor Abbott Reviewed-by: Eric Anholt --- src/compiler/Makefile.sources | 1 + src/compiler/nir/nir.h | 2 + src/compiler/nir/nir_lower_passt

[Mesa-dev] [PATCH 06/17] nir: add lowering pass for glBitmap

From: Rob Clark Signed-off-by: Rob Clark Reviewed-by: Connor Abbott Reviewed-by: Eric Anholt --- src/compiler/Makefile.sources | 1 + src/compiler/nir/nir.h | 7 ++ src/compiler/nir/nir_lower_bitmap.c | 139 3 files changed, 147 inse

[Mesa-dev] [PATCH 04/17] nir: add lowering pass for y-transform

From: Rob Clark Signed-off-by: Rob Clark Reviewed-by: Connor Abbott --- src/compiler/Makefile.sources| 1 + src/compiler/nir/nir.h | 11 + src/compiler/nir/nir_lower_wpos_ytransform.c | 310 +++ 3 files changed, 322 insertions(+)

[Mesa-dev] [PATCH 03/17] gallium: add NIR as a possible IR

From: Rob Clark Signed-off-by: Rob Clark Reviewed-by: Roland Scheidegger Reviewed-by: Marek Olšák --- src/gallium/include/pipe/p_defines.h | 1 + src/gallium/include/pipe/p_screen.h | 9 + src/gallium/include/pipe/p_state.h | 6 ++ 3 files changed, 16 insertions(+) diff --git

[Mesa-dev] [PATCH 11/17] nir/lower-io: split out some helper fxns

From: Rob Clark Prep work to reduce the noise in the next patch. Signed-off-by: Rob Clark --- src/compiler/nir/nir_lower_io_to_temporaries.c | 124 ++--- 1 file changed, 72 insertions(+), 52 deletions(-) diff --git a/src/compiler/nir/nir_lower_io_to_temporaries.c b/src/co

[Mesa-dev] [PATCH 12/17] nir/lower-io: add support for lowering inputs

From: Rob Clark Signed-off-by: Rob Clark --- src/compiler/nir/nir.h | 3 +- src/compiler/nir/nir_lower_io_to_temporaries.c | 56 +- src/mesa/drivers/dri/i965/brw_nir.c| 4 +- 3 files changed, 52 insertions(+), 11 deletions(-) diff -

[Mesa-dev] [PATCH 09/17] nir: move callsite of lower_outputs_to_temporaries

From: Rob Clark Going to convert this pass to parameterized lower_io_to_temporaries, and we want the user to be able to specify whether to lower outputs or inputs or both. The restriction of running this pass before validate to avoid output reads no longer applies. Signed-off-by: Rob Clark Rev

[Mesa-dev] [PATCH 10/17] nir: rename lower_outputs_to_temporaries -> lower_io_to_temporaries

From: Rob Clark Since it will gain support to lower inputs, give it a more generic name. Signed-off-by: Rob Clark --- src/compiler/Makefile.sources | 2 +- src/compiler/nir/nir.h | 4 +- src/compiler/nir/nir_lower_io_to_temporaries.c | 1

[Mesa-dev] [PATCH 08/17] nir: lower-io-types pass

From: Rob Clark A pass to lower complex (struct/array/mat) inputs/outputs to primitive types. This allows, for example, linking that removes unused components of a larger type which is not indirectly accessed. In the near term, it is needed for gallium (mesa/st) support for NIR, since only used

[Mesa-dev] [PATCH 15/17] mesa/st: add nir pass for lowering builtin uniforms

From: Rob Clark Signed-off-by: Rob Clark --- src/mesa/Makefile.sources | 2 + src/mesa/state_tracker/st_nir.h | 31 src/mesa/state_tracker/st_nir_lower_builtin.c | 245 ++ 3 files changed, 278 insertions(+) create mode 100644 sr

[Mesa-dev] [PATCH 16/17] mesa/st: move things around a bit in st_create_fp_variant()

From: Rob Clark Prep work for next patch. Signed-off-by: Rob Clark Reviewed-by: Marek Olšák --- src/mesa/state_tracker/st_program.c | 20 1 file changed, 8 insertions(+), 12 deletions(-) diff --git a/src/mesa/state_tracker/st_program.c b/src/mesa/state_tracker/st_progra

Re: [Mesa-dev] [PATCH] radeonsi: Set declared tessellation LDS size to hardware size.

On Sun, May 8, 2016 at 1:00 PM, Bas Nieuwenhuizen wrote: > The calculated limit gave problems on SI as it was > 32 KiB > and the hardware LDS size on SI is only 32 KiB. It isn't > correct anyway when processing multiple patches in a threadgroup. > > As we potentially have any number of patches suc

[Mesa-dev] [PATCH 13/17] glsl: export accessor for builtin-uniform descriptors

From: Rob Clark We'll need this for a nir pass to lower builtin-uniform access. Signed-off-by: Rob Clark Reviewed-by: Jason Ekstrand --- src/compiler/glsl/builtin_variables.cpp | 23 ++- src/compiler/glsl/ir.h | 3 +++ 2 files changed, 17 insertions(+), 9

[Mesa-dev] [PATCH 17/17] mesa/st: add support for NIR as possible driver IR

From: Rob Clark Signed-off-by: Rob Clark --- src/mesa/Makefile.sources | 1 + src/mesa/SConscript| 1 + src/mesa/state_tracker/st_glsl_to_nir.cpp | 423 + src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 40 ++- src/mesa/sta

[Mesa-dev] [PATCH 14/17] mesa/st: split the type_size calculation into it's own file

From: Rob Clark We'll want to re-use this for NIR. Signed-off-by: Rob Clark Reviewed-by: Marek Olšák --- src/mesa/Makefile.sources | 2 + src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 64 +- src/mesa/state_tracker/st_glsl_types.cpp | 101 ++

Re: [Mesa-dev] [PATCH 1/5] compiler: guard list iteration macros against undefined behavior

On 09.05.2016 14:03, Matt Turner wrote: On Sat, May 7, 2016 at 3:05 PM, Nicolai Hähnle wrote: From: Nicolai Hähnle The old iteration casts sentinel nodes (which are mere exec_nodes) into whatever type we're looping over, which leads to badness (in fact, gcc's undefined behaviour sanitizer cra

Re: [Mesa-dev] [PATCH] radeonsi: Set declared tessellation LDS size to hardware size.

On Mon, May 9, 2016 at 9:55 PM, Marek Olšák wrote: > On Sun, May 8, 2016 at 1:00 PM, Bas Nieuwenhuizen > wrote: >> The calculated limit gave problems on SI as it was > 32 KiB >> and the hardware LDS size on SI is only 32 KiB. It isn't >> correct anyway when processing multiple patches in a thread

[Mesa-dev] [PATCH 02/17] gallium: refactor pipe_shader_state to support multiple IR's

The goal is to allow the pipe driver to request something other than TGSI, but detect whether what is getting is TGSI vs what it requested. The pipe drivers will always have to support TGSI (and convert that into whatever it is that they prefer), but in some cases we should be able to skip the TGSI

Re: [Mesa-dev] [PATCH 13/17] glsl: export accessor for builtin-uniform descriptors

On Mon, May 9, 2016 at 12:34 PM, Rob Clark wrote: > From: Rob Clark > > We'll need this for a nir pass to lower builtin-uniform access. > > Signed-off-by: Rob Clark > Reviewed-by: Jason Ekstrand > --- > src/compiler/glsl/builtin_variables.cpp | 23 ++- > src/compiler/glsl/i

  1   2   >