Re: [Mesa-dev] [PATCH] ac: image size builtin for GLSL_SAMPLER_DIM_3D

2018-01-18 Thread Dieter Nützel
Tested-by: Dieter Nützel on RX580 with UH, UV, glmark2 and Blender 2.79 UH and UV crash for 'wireframe' (as expected - not implemented, yet) ;-) BTW Find an interesting hang with Unigine_Superposition-1.0 with and _without_ NIR in very high mode. NIR is _much_ better.

Re: [Mesa-dev] [PATCH] i965: Rename 'aux' to 'prog_data' in program cache.

2018-01-18 Thread Iago Toral
Reviewed-by: Iago Toral Quiroga On Thu, 2018-01-18 at 14:03 -0800, Kenneth Graunke wrote: > 'aux' is a very generic name, suggesting it can be a bunch of things. > However, it's always the brw_*_prog_data structure. So, call it > that. > --- >

Re: [Mesa-dev] [PATCH] i965: Drop render_target_start from binding table struct.

2018-01-18 Thread Iago Toral
On Thu, 2018-01-18 at 15:49 -0800, Kenneth Graunke wrote: > We have to start render targets at binding table index 0 in order to > use > headerless FB write messages, and in fact already assume this in a > bunch > of places in the code. Let's finish that off, and not bother storing > 0 > in a

Re: [Mesa-dev] [PATCH 8/8] st/glsl_to_nir: disable io lowering and forced indirect array splitting in fs

2018-01-18 Thread Dieter Nützel
For the series: Tested-by: Dieter Nützel on RX580 with UH, UV, glmark2 and Blender 2.79 UH and UV crash for 'wireframe' (as expected - not implemented, yet) ;-) Dieter Am 15.01.2018 04:46, schrieb Timothy Arceri: We need this to be able to support the interpolateAt

Re: [Mesa-dev] [PATCH] intel: Add Geminilake brand strings

2018-01-18 Thread Kenneth Graunke
On Wednesday, January 17, 2018 1:31:53 PM PST Anuj Phogat wrote: > Signed-off-by: Anuj Phogat > --- > include/pci_ids/i965_pci_ids.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/include/pci_ids/i965_pci_ids.h

Re: [Mesa-dev] [PATCH] egl: do not expose EGL_EXT_pixel_format_float yet

2018-01-18 Thread Tapani Pälli
On 01/18/2018 03:31 PM, Emil Velikov wrote: On 18 January 2018 at 06:05, Tapani Pälli wrote: On 01/17/2018 11:59 PM, Rob Herring wrote: On Wed, Jan 17, 2018 at 12:27 PM, Tapani Pälli wrote: Let's expose this only when we have formats.

[Mesa-dev] [PATCH v2] egl: add support for EGL_ANDROID_blob_cache

2018-01-18 Thread Tapani Pälli
v2: cleanup, move callbacks to _egl_display struct (Emil Velikov) Signed-off-by: Tapani Pälli --- src/egl/drivers/dri2/egl_dri2.c | 39 +++ src/egl/drivers/dri2/egl_dri2.h | 1 + src/egl/main/eglapi.c | 30

Re: [Mesa-dev] [PATCH 2/7] egl: add support for EGL_ANDROID_blob_cache

2018-01-18 Thread Tapani Pälli
On 01/18/2018 04:55 PM, Emil Velikov wrote: On 17 January 2018 at 16:11, Tapani Pälli wrote: On 17.01.2018 13:28, Nicolai Hähnle wrote: On 16.01.2018 18:45, Emil Velikov wrote: Hi Tapani, On 15 January 2018 at 12:31, Tapani Pälli wrote:

Re: [Mesa-dev] [PATCH 6/7] android: ignore MESA_GLSL_CACHE_DISABLE setting

2018-01-18 Thread Tapani Pälli
On 01/18/2018 04:59 PM, Emil Velikov wrote: On 17 January 2018 at 08:12, Tapani Pälli wrote: On 16.01.2018 11:02, Jordan Justen wrote: On 2018-01-15 04:31:42, Tapani Pälli wrote: Signed-off-by: Tapani Pälli ---

[Mesa-dev] [PATCH] mesa: Only require independent blending for GLES 3.2.

2018-01-18 Thread Eric Anholt
We've been requiring this since GLES 3.0 was introduced, but the GLES 3.2 spec is the one that has "Supporting blending on a per-draw-buffer basis" in the new features. V3D 3.3 would require lowering blending to shader code to implement independent blending. --- src/mesa/main/version.c | 2 +- 1

Re: [Mesa-dev] Logging infrastructure?

2018-01-18 Thread Tapani Pälli
Hi; On 01/18/2018 11:44 PM, Chuck Atkins wrote: Is there a logging infrastructure currently available to drivers in Mesa?  I was looking to clean up some of swr's debug / info output and have it conditional on the MESA_DEBUG and LIBGL_DEBUG variables but then I realized that it's really

[Mesa-dev] [PATCH v2] ac: remove arrays when when querying sampler info

2018-01-18 Thread Timothy Arceri
Fixes the following ARB_arrays_of_arrays piglit tests: basic-imagestore-const-uniform-index basic-imagestore-mixed-const-non-const-uniform-index basic-imagestore-mixed-const-non-const-uniform-index2 basic-imagestore-non-const-uniform-index --- src/amd/common/ac_nir_to_llvm.c | 4 +--- 1 file

Re: [Mesa-dev] [PATCH 7/7] android: set '/sdcard/' as MESA_GLSL_CACHE_DIR by default

2018-01-18 Thread Tapani Pälli
On 01/18/2018 08:18 PM, Jordan Justen wrote: On 2018-01-15 04:31:43, Tapani Pälli wrote: This can/should be modified depending on needs. AFAIK by default, this is the only path that can be read/written to by anyone. Signed-off-by: Tapani Pälli --- Android.common.mk

Re: [Mesa-dev] [PATCH 3/4] i965/bufmgr: Add a set_tiling helper

2018-01-18 Thread Kenneth Graunke
On Thursday, January 18, 2018 7:05:46 PM PST Jason Ekstrand wrote: > On Thu, Jan 18, 2018 at 4:30 PM, Kenneth Graunke > wrote: > > > On Friday, January 12, 2018 1:28:00 AM PST Chris Wilson wrote: > > > Quoting Jason Ekstrand (2018-01-12 01:40:52) > > > > This helper should

Re: [Mesa-dev] [PATCH 0/7] EGL_ANDROID_blob_cache

2018-01-18 Thread Tapani Pälli
On 01/18/2018 05:49 PM, Nicolai Hähnle wrote: On 17.01.2018 17:10, Tapani Pälli wrote: On 17.01.2018 13:34, Nicolai Hähnle wrote: On 15.01.2018 13:31, Tapani Pälli wrote: Hello; Here's a refactored series of EGL_ANDROID_blob_cache. Now cache functions are stored in disk_cache struct and

[Mesa-dev] [PATCH 2/2] glsl: add image and sampler (un)packing support to glsl to nir

2018-01-18 Thread Timothy Arceri
This is needed for ARB_bindless_texture support. --- src/compiler/glsl/glsl_to_nir.cpp | 4 1 file changed, 4 insertions(+) diff --git a/src/compiler/glsl/glsl_to_nir.cpp b/src/compiler/glsl/glsl_to_nir.cpp index 4e3e9c4610..1a579f41cd 100644 --- a/src/compiler/glsl/glsl_to_nir.cpp +++

Re: [Mesa-dev] [PATCH] radv/winsys: replace bo list searchs with a hash table.

2018-01-18 Thread Dieter Nützel
Ping! Any progress? Am 11.01.2018 04:53, schrieb Dave Airlie: From: Dave Airlie This should make the merging of cmd buffers less CPU intensive, note I said *should* :) --- src/amd/vulkan/winsys/amdgpu/radv_amdgpu_cs.c | 47 --- 1 file changed, 20

[Mesa-dev] [PATCH 1/2] nir: add image and smapler type to glsl_get_bit_size()

2018-01-18 Thread Timothy Arceri
These are needed for ARB_bindless_texture support. --- src/compiler/nir_types.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/compiler/nir_types.h b/src/compiler/nir_types.h index 4397c2406f..e2dfd1ef5b 100644 --- a/src/compiler/nir_types.h +++ b/src/compiler/nir_types.h @@ -102,6

Re: [Mesa-dev] [PATCH 3/4] i965/bufmgr: Add a set_tiling helper

2018-01-18 Thread Jason Ekstrand
On Thu, Jan 18, 2018 at 4:30 PM, Kenneth Graunke wrote: > On Friday, January 12, 2018 1:28:00 AM PST Chris Wilson wrote: > > Quoting Jason Ekstrand (2018-01-12 01:40:52) > > > This helper should be used carefully as setting tiling is a racy > > > operation since it

[Mesa-dev] [PATCH] ac: fix ac_build_varying_gather_values() for packed layouts

2018-01-18 Thread Timothy Arceri
This fixes a segfault for varyings not starting at component 0. --- src/amd/common/ac_llvm_build.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/amd/common/ac_llvm_build.c b/src/amd/common/ac_llvm_build.c index 3467bba693..6615a269f8 100644 ---

Re: [Mesa-dev] radeonsi nir arb_vertex_attrib_64bit fixes

2018-01-18 Thread Dieter Nützel
Ping! 2 & 3 are missing r-b. Welcome home, Nicolai -- Did you had nice vacation? ;-) Am 08.01.2018 01:35, schrieb Timothy Arceri: This series fixes all of the failing arb_vertex_attrib_64bit piglit tests ~1000. ___ mesa-dev mailing list

Re: [Mesa-dev] [PATCH] radeonsi: don't ignore pitch for imported textures

2018-01-18 Thread Dieter Nützel
Ping! Am 11.01.2018 04:45, schrieb Dieter Nützel: Tested-by: Dieter Nützel on RX580 with UH, UV, glmark2 and Blender 2.79 with and without nir. Dieter Am 10.01.2018 20:49, schrieb Marek Olšák: From: Marek Olšák Cc: 17.2 17.3

Re: [Mesa-dev] [PATCH 4/5] docs: move untar line in basic testing instructions for coherence

2018-01-18 Thread Eric Engestrom
On Thursday, 2018-01-18 23:06:40 +, Andres Gomez wrote: > For scons, windows/mingw dealing with LLVM_CONFIG is done before > untarring. Isn't this a no-op change? > This is also more convenient for copy and paste. No objection though, this and the rest of the series is Reviewed-by: Eric

[Mesa-dev] [PATCH] ac/nir: fix user sgpr allocations on gfx9

2018-01-18 Thread Dave Airlie
From: Dave Airlie The code to decide how to allocate sgprs didn't take into account the merged shaders on gfx9. This updates the code to count the correct number of requires sgprs, which means we should be able to enable push const inlining easier. Signed-off-by: Dave

Re: [Mesa-dev] [PATCH] radeonsi: don't ignore pitch for imported textures

2018-01-18 Thread Marek Olšák
I know. It's not been formally reviewed yet though. marek On Fri, Jan 19, 2018 at 4:34 AM, Dieter Nützel wrote: > Ping! > > > Am 11.01.2018 04:45, schrieb Dieter Nützel: >> >> Tested-by: Dieter Nützel >> >> on RX580 with UH, UV, glmark2 and Blender

[Mesa-dev] [PATCH] i965: Drop render_target_start from binding table struct.

2018-01-18 Thread Kenneth Graunke
We have to start render targets at binding table index 0 in order to use headerless FB write messages, and in fact already assume this in a bunch of places in the code. Let's finish that off, and not bother storing 0 in a struct to pretend to add it in a few places. --- src/intel/blorp/blorp.c

Re: [Mesa-dev] [PATCH 3/4] i965/bufmgr: Add a set_tiling helper

2018-01-18 Thread Kenneth Graunke
On Friday, January 12, 2018 1:28:00 AM PST Chris Wilson wrote: > Quoting Jason Ekstrand (2018-01-12 01:40:52) > > This helper should be used carefully as setting tiling is a racy > > operation since it potentially interacts with other processes. Still, > > it is a useful thing to be able to do. >

[Mesa-dev] [Bug 104677] radv_generate_graphics_pipeline_key reads input rate from incorrect binding

2018-01-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=104677 Bas Nieuwenhuizen changed: What|Removed |Added Resolution|--- |FIXED

[Mesa-dev] mesa-dev mailing list is not listing the archived mails properly since January 2018 (?)

2018-01-18 Thread Andres Gomez
Hi, maybe it has been mentioned and I have overlooked it. In that case, sorry for the redundant mail. I'm checking: https://lists.freedesktop.org/archives/mesa-dev/2018-January/ And it seems very few messages are listed. Notice that you can access directly to them, though. I don't know if

[Mesa-dev] [PATCH 4/5] docs: move untar line in basic testing instructions for coherence

2018-01-18 Thread Andres Gomez
For scons, windows/mingw dealing with LLVM_CONFIG is done before untarring. This is also more convenient for copy and paste. Cc: Emil Velikov Cc: Juan A. Suarez Romero Signed-off-by: Andres Gomez --- docs/releasing.html | 2

Re: [Mesa-dev] [PATCH] gallivm: avx-512 changes for texel fetcher

2018-01-18 Thread Roland Scheidegger
Am 18.01.2018 um 20:26 schrieb Kyriazis, George: >> On Jan 18, 2018, at 1:10 PM, Roland Scheidegger > > wrote: >> >> Am 17.01.2018 um 23:33 schrieb George Kyriazis: >>> The texture swizzle was not doing the right thing for avx512-style >>> 16-wide

[Mesa-dev] [PATCH] ac: add support for gl_HelperInvocation

2018-01-18 Thread Timothy Arceri
--- src/amd/common/ac_nir_to_llvm.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c index cf0b3d998c..4f240db4ac 100644 --- a/src/amd/common/ac_nir_to_llvm.c +++ b/src/amd/common/ac_nir_to_llvm.c @@ -3914,6

Re: [Mesa-dev] [PATCH 5/7] report.py: Add option to only display measurements that have changes

2018-01-18 Thread Kenneth Graunke
On Friday, January 12, 2018 12:06:59 PM PST Ian Romanick wrote: > From: Ian Romanick > > This is useful for preparing data to go in a Mesa commit message. > > Signed-off-by: Ian Romanick > --- > report.py | 53

[Mesa-dev] [PATCH 3.5/7] report.py: Don't use 'len(x) > 0' to check list emptiness

2018-01-18 Thread Ian Romanick
From: Ian Romanick Signed-off-by: Ian Romanick Suggested-by: Dylan Baker --- report.py | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/report.py b/report.py index 003a1ee..185b585 100755

[Mesa-dev] [PATCH 3/3] ac/radeonsi: add emit primitive to the abi

2018-01-18 Thread Timothy Arceri
--- src/amd/common/ac_nir_to_llvm.c | 6 -- src/amd/common/ac_shader_abi.h | 3 +++ src/gallium/drivers/radeonsi/si_shader.c | 1 + 3 files changed, 8 insertions(+), 2 deletions(-) diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c index

[Mesa-dev] [PATCH] ac: fix emit vertex stream parameter

2018-01-18 Thread Timothy Arceri
Fixes the following piglit test on radeonsi: ./bin/arb_enhanced_layouts-gs-stream-location-aliasing --- src/amd/common/ac_nir_to_llvm.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c index

[Mesa-dev] [PATCH] ac: remove arrays when when querying sampler info

2018-01-18 Thread Timothy Arceri
Fixes the following ARB_arrays_of_arrays piglit tests: basic-imagestore-const-uniform-index basic-imagestore-mixed-const-non-const-uniform-index basic-imagestore-mixed-const-non-const-uniform-index2 basic-imagestore-non-const-uniform-index --- src/amd/common/ac_nir_to_llvm.c | 4 ++-- 1 file

[Mesa-dev] [PATCH 3/5] docs: add a notice whenever a release is the final in a series

2018-01-18 Thread Andres Gomez
Cc: Emil Velikov Cc: Juan A. Suarez Romero Signed-off-by: Andres Gomez --- docs/releasing.html | 17 - 1 file changed, 16 insertions(+), 1 deletion(-) diff --git a/docs/releasing.html b/docs/releasing.html

[Mesa-dev] [PATCH 2/5] docs: add final release note for 17.2.8

2018-01-18 Thread Andres Gomez
Cc: Emil Velikov Cc: Juan A. Suarez Romero Signed-off-by: Andres Gomez --- docs/index.html | 4 1 file changed, 4 insertions(+) diff --git a/docs/index.html b/docs/index.html index 95a07150644..075956499d4 100644 ---

Re: [Mesa-dev] [PATCH 4/4] vbo: fix VBO optimization regression

2018-01-18 Thread Brian Paul
I just pushed it and updated https://bugs.freedesktop.org/show_bug.cgi?id=104690 -Brian On 01/18/2018 03:10 PM, Ian Romanick wrote: Mark: Can you check that this fixes the G33 regression that you mentioned to me this morning? On 01/17/2018 02:57 PM, Brian Paul wrote: The optimization in

Re: [Mesa-dev] [PATCH v2] meson: Don't confuse the install and search paths for dri drivers

2018-01-18 Thread Eric Engestrom
On Thursday, 2018-01-18 17:09:33 +, Dylan Baker wrote: > Currently there is not a separate option for setting the search path of > DRI drivers in meson, like there is in scons and autotools. This is an > oversight and needs to be fixed. This adds an extra option > `dri-search-path`, which will

Re: [Mesa-dev] [PATCH 4/4] vbo: fix VBO optimization regression

2018-01-18 Thread Ian Romanick
Mark: Can you check that this fixes the G33 regression that you mentioned to me this morning? On 01/17/2018 02:57 PM, Brian Paul wrote: > The optimization in change 8e4efdc895ea ("vbo: optimize some display > list drawing") missed the loopback case. This is used when the > glBegin/End primitive

[Mesa-dev] [PATCH 5/5] docs: correct a typo in releasing instructions

2018-01-18 Thread Andres Gomez
Cc: Emil Velikov Cc: Juan A. Suarez Romero Signed-off-by: Andres Gomez --- docs/releasing.html | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/releasing.html b/docs/releasing.html index

[Mesa-dev] [PATCH 2/3] radeonsi: add generic emit primitive helper

2018-01-18 Thread Timothy Arceri
This will be shared by the tgsi and nir backends. --- src/gallium/drivers/radeonsi/si_shader.c | 21 ++--- 1 file changed, 14 insertions(+), 7 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_shader.c b/src/gallium/drivers/radeonsi/si_shader.c index

[Mesa-dev] [PATCH 1/3] ac: add stream handling to visit_end_primitive()

2018-01-18 Thread Timothy Arceri
--- src/amd/common/ac_nir_to_llvm.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c index 12353943a5..9709514532 100644 --- a/src/amd/common/ac_nir_to_llvm.c +++ b/src/amd/common/ac_nir_to_llvm.c @@

[Mesa-dev] [ANNOUNCE] mesa 17.3.3

2018-01-18 Thread Juan A. Suarez Romero
Mesa 17.3.3 is now available. In this release we have: The RADV driver gets several fixes around the resolve pass. It also gets fixes to solve a mpv hang, pipeline statistics, and other few issues. Worth to note that several of these the fixes improves the RADV VEGA support. Intel's ANV driver

[Mesa-dev] Logging infrastructure?

2018-01-18 Thread Chuck Atkins
Is there a logging infrastructure currently available to drivers in Mesa? I was looking to clean up some of swr's debug / info output and have it conditional on the MESA_DEBUG and LIBGL_DEBUG variables but then I realized that it's really something useful all across mesa so there may already be

[Mesa-dev] [PATCH] i965: Rename 'aux' to 'prog_data' in program cache.

2018-01-18 Thread Kenneth Graunke
'aux' is a very generic name, suggesting it can be a bunch of things. However, it's always the brw_*_prog_data structure. So, call it that. --- src/mesa/drivers/dri/i965/brw_program_cache.c | 31 ++- 1 file changed, 16 insertions(+), 15 deletions(-) diff --git

[Mesa-dev] [PATCH v2] autotools: include meson build files in tarball

2018-01-18 Thread Dylan Baker
This adds the meson.build, meson_options.txt, and a few scripts that are used exclusively by the meson build. v2: - Remove accidentally included changes needed to test make dist with LLVM > 3.9 Signed-off-by: Dylan Baker Acked-by: Eric Engestrom

Re: [Mesa-dev] [PATCH 1/4] i965/miptree: Add an explicit tiling parameter to create_for_bo

2018-01-18 Thread Kenneth Graunke
On Thursday, January 11, 2018 5:40:50 PM PST Jason Ekstrand wrote: > From: Jason Ekstrand > > Otherwise, create_for_bo will just grab the tiling from the BO which is > not what we want when using modifiers. > > Cc: mesa-sta...@lists.freedesktop.org Patches 1-2 are:

Re: [Mesa-dev] [PATCH] autotools: include meson build files in tarball

2018-01-18 Thread Dylan Baker
Quoting Eric Engestrom (2018-01-18 13:04:00) > On Thursday, 2018-01-18 17:09:04 +, Dylan Baker wrote: > > This adds the meson.build, meson_options.txt, and a few scripts that are > > used exclusively by the meson build. > > > > Signed-off-by: Dylan Baker > > I

[Mesa-dev] [PATCH] ac/nir: Fix TCS output LDS offsets.

2018-01-18 Thread Bas Nieuwenhuizen
When a channel was not set we also did not increase the LDS address, while that obviously should happen. The output loading code was inadvertently fixed which resulted in a mismatch causing the SaschaWillems tessellation demo to result in corrupt rendering. Fixes: 7898eb9a60 "ac: rework

Re: [Mesa-dev] [PATCH] autotools: include meson build files in tarball

2018-01-18 Thread Eric Engestrom
On Thursday, 2018-01-18 17:09:04 +, Dylan Baker wrote: > This adds the meson.build, meson_options.txt, and a few scripts that are > used exclusively by the meson build. > > Signed-off-by: Dylan Baker I could've sworn we already some $(shell find -name meson.build)

[Mesa-dev] [PATCH 0/5] docs: add missing final release of series notes

2018-01-18 Thread Andres Gomez
Just a series to add the missing "final release" note for 17.1.10 and 17.2.8, as commented at: https://lists.freedesktop.org/archives/mesa-dev/2018-January/182322.html Additionally, update the releasing documentation to make explicit mention of the need to mention the final release of a series.

[Mesa-dev] [PATCH 1/5] docs: add final release note for 17.1.10

2018-01-18 Thread Andres Gomez
Cc: Emil Velikov Cc: Juan A. Suarez Romero Signed-off-by: Andres Gomez --- docs/index.html | 4 1 file changed, 4 insertions(+) diff --git a/docs/index.html b/docs/index.html index 75a39d797d4..95a07150644 100644 ---

Re: [Mesa-dev] [PATCH 00/14] BSD portability (Meson, ANV, RADV, VC4/5, SWR)

2018-01-18 Thread Dylan Baker
Quoting Emil Velikov (2018-01-18 10:57:02) > On 18 January 2018 at 18:29, Greg V wrote: > > > > On 01/18/2018 21:18, Emil Velikov wrote: > >> > >> Hi Greg, > >> > >> On 31 December 2017 at 16:55, Greg V wrote: > >>> > >>> Hello everyone

Re: [Mesa-dev] [PATCH 2/2] st/vdpau: release held lock in error path

2018-01-18 Thread Grazvydas Ignotas
Anyone cares about vdpau? Gražvydas On Tue, Jan 16, 2018 at 12:03 AM, Grazvydas Ignotas wrote: > Signed-off-by: Grazvydas Ignotas > --- > src/gallium/state_trackers/vdpau/surface.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git

Re: [Mesa-dev] [PATCH 10/10] nouveau: Remove no-op nvgl_logicop_func function

2018-01-18 Thread Francisco Jerez
Ian Romanick writes: > From: Ian Romanick > > The values that this function returned were always the values passed > in. The only thing that happened was either an assertion or undefined > results when an unknown value was passed in. This

Re: [Mesa-dev] [PATCH] ac/nir: account for view index in the user sgpr allocation.

2018-01-18 Thread Samuel Pitoiset
Reviewed-by: Samuel Pitoiset On 01/18/2018 03:37 AM, Dave Airlie wrote: From: Dave Airlie The view index user sgpr wasn't being accounted for properly, this refactors out the code to decide if it's required and then uses that info to account for

Re: [Mesa-dev] [PATCH v2 0/4] Fix unm_sampes and some warnings

2018-01-18 Thread Ian Romanick
Patches 2, 3, and 4 are Reviewed-by: Ian Romanick I send out a lot of patches that fix warnings. I like to copy-and-paste the warnings that are eliminated into the commit message. It's not required, but I feel like it helps. The only trick is to make sure the

Re: [Mesa-dev] [PATCH] meson: ensure that xmlpool_options.h is generated for targets that need it

2018-01-18 Thread Eric Anholt
Dylan Baker writes: > Currently a couple of gallium targets race with xmlpool_options.h being > generated, don't do that. Reviewed-by: Eric Anholt signature.asc Description: PGP signature ___ mesa-dev mailing

Re: [Mesa-dev] [PATCH] radv: Use correct bindings for inputRate in key generation.

2018-01-18 Thread Samuel Pitoiset
Reviewed-by: Samuel Pitoiset On 01/18/2018 03:55 PM, Bas Nieuwenhuizen wrote: The bindings also have an index field. Fixes: 49d035122e "radv: Add single pipeline cache key." Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=104677 ---

Re: [Mesa-dev] [PATCH 12/14] swr: build on FreeBSD/DragonFlyBSD

2018-01-18 Thread Chuck Atkins
Hi Emil, Greg, > > (Needs CPU topology detection to actually work) > Does it? Or does it just need the topology detection for the current "default" behavior for thread placement? The default behavior for swr is to use the cpu topology info to place one thread per core and pin it to that

Re: [Mesa-dev] [PATCH 2/2] radv: Replace an assert with unreachable.

2018-01-18 Thread Samuel Pitoiset
Series is: Reviewed-by: Samuel Pitoiset On 01/17/2018 11:25 PM, Bas Nieuwenhuizen wrote: Otherwise we get uninitialized variable warnings for es_vgpr_comp_cnt. --- src/amd/vulkan/radv_shader.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [Mesa-dev] [PATCH] r600: enable ARB_enhanced_layouts

2018-01-18 Thread Dave Airlie
On 19 January 2018 at 06:09, Roland Scheidegger wrote: > Am 18.01.2018 um 20:35 schrieb Dave Airlie: >> On 19 January 2018 at 04:30, Roland Scheidegger wrote: >>> Looks good to me, seems like you're nearly done with gl 4.5 ;-) >> >> Thanks, >> >> I've

Re: [Mesa-dev] [PATCH 1/2] swr: (autoconf) allow a single swr architecture to be builtin

2018-01-18 Thread Cherniak, Bruce
Thanks Chuck! Reviewed-by: Bruce Cherniak > On Jan 18, 2018, at 1:57 PM, Chuck Atkins wrote: > > Part 1 of 2 (part 1 is autoconf changes, part 2 is C++ changes) > > When only a single SWR architecture is being used, this allows that >

Re: [Mesa-dev] [PATCH 2/2] swr: allow a single swr architecture to be builtin

2018-01-18 Thread Cherniak, Bruce
Thanks Chuck! Reviewed-by: Bruce Cherniak > On Jan 18, 2018, at 1:57 PM, Chuck Atkins wrote: > > Part 2 of 2 (part 1 is autoconf changes, part 2 is C++ changes) > > When only a single SWR architecture is being used, this allows that >

Re: [Mesa-dev] [PATCH] r600: enable ARB_enhanced_layouts

2018-01-18 Thread Roland Scheidegger
Am 18.01.2018 um 20:35 schrieb Dave Airlie: > On 19 January 2018 at 04:30, Roland Scheidegger wrote: >> Looks good to me, seems like you're nearly done with gl 4.5 ;-) > > Thanks, > > I've mostly written qbo support I think (the 64-bit int divide is the > biggest thing

Re: [Mesa-dev] [PATCH 12/14] swr: build on FreeBSD/DragonFlyBSD

2018-01-18 Thread Dylan Baker
Quoting Emil Velikov (2018-01-18 10:50:05) > On 18 January 2018 at 18:09, Greg V wrote: > > On 01/18/2018 21:01, Emil Velikov wrote: > >> > >> On 31 December 2017 at 16:55, Greg V wrote: > >>> > >>> (Needs CPU topology detection to

[Mesa-dev] [Bug 104214] Dota crashes when switching from game to desktop

2018-01-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=104214 --- Comment #55 from Juan A. Suarez --- Is this bug already fixed? With commit: commit 897c54d522ab960a879b763a15e489f630c491ee Author: Thomas Hellstrom Date: Thu Jan 11 10:19:23 2018 +0100

[Mesa-dev] [PATCH 1/2] swr: (autoconf) allow a single swr architecture to be builtin

2018-01-18 Thread Chuck Atkins
Part 1 of 2 (part 1 is autoconf changes, part 2 is C++ changes) When only a single SWR architecture is being used, this allows that architecture to be builtin rather than as a separate libswrARCH.so that gets loaded via dlopen. Since there are now several different code paths for each detected

[Mesa-dev] [PATCH 2/2] swr: allow a single swr architecture to be builtin

2018-01-18 Thread Chuck Atkins
Part 2 of 2 (part 1 is autoconf changes, part 2 is C++ changes) When only a single SWR architecture is being used, this allows that architecture to be builtin rather than as a separate libswrARCH.so that gets loaded via dlopen. Since there are now several different code paths for each detected

Re: [Mesa-dev] [PATCH] gallivm: avx-512 changes for texel fetcher

2018-01-18 Thread Kyriazis, George
On Jan 18, 2018, at 1:10 PM, Roland Scheidegger > wrote: Am 17.01.2018 um 23:33 schrieb George Kyriazis: The texture swizzle was not doing the right thing for avx512-style 16-wide loads. Special-case the post-load swizzle operations for avx512 so

Re: [Mesa-dev] [PATCH 02/14] vc4, vc5: add ETIME fallback define

2018-01-18 Thread Dylan Baker
Quoting Emil Velikov (2018-01-18 10:40:40) > On 18 January 2018 at 17:13, Dylan Baker wrote: > > I'm not sure how Emil feels about this (and the related patches) but I > > think it > > might be better to handle this at the build system level, for meson it would > > look

Re: [Mesa-dev] [PATCH] radv: Use correct bindings for inputRate in key generation.

2018-01-18 Thread Dave Airlie
On 19 January 2018 at 00:55, Bas Nieuwenhuizen wrote: > The bindings also have an index field. Make sense, Reviewed-by: Dave Airlie > > Fixes: 49d035122e "radv: Add single pipeline cache key." > Bugzilla:

Re: [Mesa-dev] [PATCH v2] egl/android: Implement the eglSwapinterval for Android.

2018-01-18 Thread Eric Engestrom
On Thursday, 2018-01-18 19:07:06 +, Emil Velikov wrote: > On 18 January 2018 at 17:43, Eric Engestrom wrote: > > On Thursday, 2018-01-18 07:52:42 +, Zhongmin Wu wrote: > >> Implement the eglSwapinterval for Android platform to > >> enable the async mode for some GFX

Re: [Mesa-dev] [PATCH v2 3/4] meson: fix getting cflags from pkg-config

2018-01-18 Thread Dylan Baker
Quoting Emil Velikov (2018-01-18 10:26:20) > On 17 January 2018 at 20:54, Greg V wrote: > > get_pkgconfig_variable('cflags') always returns an empty list, it's a > > function for getting *custom* variables. > > > > Meson does not yet support asking for cflags, so

Re: [Mesa-dev] [PATCH v2] meson: Don't confuse the install and search paths for dri drivers

2018-01-18 Thread Eric Anholt
Dylan Baker writes: > Currently there is not a separate option for setting the search path of > DRI drivers in meson, like there is in scons and autotools. This is an > oversight and needs to be fixed. This adds an extra option > `dri-search-path`, which will default to the

Re: [Mesa-dev] [PATCH 0/6] meson: fix gallium media target linkage

2018-01-18 Thread Dylan Baker
Quoting Emil Velikov (2018-01-18 11:12:30) > On 17 January 2018 at 18:34, Dylan Baker wrote: > > The linkage of all of the gallium media targets is broken in various > > ways in the meson build. This series should correct that by doing more > > what the autotools build does.

Re: [Mesa-dev] [PATCH] r600: enable ARB_enhanced_layouts

2018-01-18 Thread Dave Airlie
On 19 January 2018 at 04:30, Roland Scheidegger wrote: > Looks good to me, seems like you're nearly done with gl 4.5 ;-) Thanks, I've mostly written qbo support I think (the 64-bit int divide is the biggest thing left), However we'll have to keep restricted to GL4.3 until

Re: [Mesa-dev] [PATCH] gallivm: avx-512 changes for texel fetcher

2018-01-18 Thread Kyriazis, George
On Jan 18, 2018, at 1:10 PM, Roland Scheidegger > wrote: Am 17.01.2018 um 23:33 schrieb George Kyriazis: The texture swizzle was not doing the right thing for avx512-style 16-wide loads. Special-case the post-load swizzle operations for avx512 so

Re: [Mesa-dev] [PATCH v2 2/4] meson: handle LLVM 'x.x.xgit-revision' versions

2018-01-18 Thread Dylan Baker
Quoting Emil Velikov (2018-01-18 10:22:50) > On 17 January 2018 at 20:54, Greg V wrote: > > When LLVM is built inside of a git repo (even way below, e.g. > > /usr/ports/.git > > exists, and LLVM is built in /usr/ports/devel/llvm50/work), its version > > becomes

Re: [Mesa-dev] [PATCH 02/14] vc4, vc5: add ETIME fallback define

2018-01-18 Thread Eric Anholt
Dylan Baker writes: > [ Unknown signature status ] > I'm not sure how Emil feels about this (and the related patches) but I think > it > might be better to handle this at the build system level, for meson it would > look something like (in the top level meson.build): > > if

Re: [Mesa-dev] [PATCH 0/6] meson: fix gallium media target linkage

2018-01-18 Thread Emil Velikov
On 17 January 2018 at 18:34, Dylan Baker wrote: > The linkage of all of the gallium media targets is broken in various > ways in the meson build. This series should correct that by doing more > what the autotools build does. > Above all and slightly unrelated, can I ask you

Re: [Mesa-dev] [PATCH] gallivm: avx-512 changes for texel fetcher

2018-01-18 Thread Roland Scheidegger
Am 17.01.2018 um 23:33 schrieb George Kyriazis: > The texture swizzle was not doing the right thing for avx512-style > 16-wide loads. > > Special-case the post-load swizzle operations for avx512 so that we move > the xyzw components correctly to the outputs. > > cc: Jose Fonseca

Re: [Mesa-dev] [PATCH v2] egl/android: Implement the eglSwapinterval for Android.

2018-01-18 Thread Emil Velikov
On 18 January 2018 at 17:43, Eric Engestrom wrote: > On Thursday, 2018-01-18 07:52:42 +, Zhongmin Wu wrote: >> Implement the eglSwapinterval for Android platform to >> enable the async mode for some GFX benchmarks such as >> Daimler C217, CityBench. >> >> Signed-off-by:

Re: [Mesa-dev] [PATCH 13/14] swr: fix clang 5 null cast warning

2018-01-18 Thread Cherniak, Bruce
Apologies for not seeing this over the holidays. Reviewed-by: Bruce Cherniak > On Jan 18, 2018, at 12:03 PM, Emil Velikov > wrote: On 31 December 2017 at 16:55, Greg V

Re: [Mesa-dev] [PATCH 00/14] BSD portability (Meson, ANV, RADV, VC4/5, SWR)

2018-01-18 Thread Emil Velikov
On 18 January 2018 at 18:29, Greg V wrote: > > On 01/18/2018 21:18, Emil Velikov wrote: >> >> Hi Greg, >> >> On 31 December 2017 at 16:55, Greg V wrote: >>> >>> Hello everyone and happy new year! :) >>> >>> This set of patches makes the

Re: [Mesa-dev] [PATCH 2/2] swr: suppress debug output from loader unless LIBGL_DEBUG is set.

2018-01-18 Thread Eric Engestrom
On Tuesday, 2018-01-16 19:38:25 +, Chuck Atkins wrote: > > > +#define debug_printf(...) if(mesa_debug) { fprintf(stderr, > > __VA_ARGS__); } > > > > `do {} while(0)` > > > > Forgive me but I don't understand, what you're saying here. Sorry, I guess I could've used a few more characters to

Re: [Mesa-dev] [PATCH 12/14] swr: build on FreeBSD/DragonFlyBSD

2018-01-18 Thread Emil Velikov
On 18 January 2018 at 18:09, Greg V wrote: > On 01/18/2018 21:01, Emil Velikov wrote: >> >> On 31 December 2017 at 16:55, Greg V wrote: >>> >>> (Needs CPU topology detection to actually work) >> >> IMHO it might be better to drop the

Re: [Mesa-dev] [PATCH 02/14] vc4, vc5: add ETIME fallback define

2018-01-18 Thread Emil Velikov
On 18 January 2018 at 17:13, Dylan Baker wrote: > I'm not sure how Emil feels about this (and the related patches) but I think > it > might be better to handle this at the build system level, for meson it would > look something like (in the top level meson.build): > > if

Re: [Mesa-dev] [PATCH 00/14] BSD portability (Meson, ANV, RADV, VC4/5, SWR)

2018-01-18 Thread Greg V
On 01/18/2018 21:18, Emil Velikov wrote: Hi Greg, On 31 December 2017 at 16:55, Greg V wrote: Hello everyone and happy new year! :) This set of patches makes the Meson build work on FreeBSD, including RADV, ANV, wayland-egl, VAAPI, VDPAU. Huge thanks for

Re: [Mesa-dev] [PATCH 01/14] util: fix ElfW macro

2018-01-18 Thread Greg V
On 01/18/2018 19:57, Emil Velikov wrote: On 31 December 2017 at 16:55, Greg V wrote: Elf64_Nhdr exists, Elf_Nhdr does not. Can you please add a typedef in FreeBSD sources, pretty please? I'm not a committer :) raised an issue in bugzilla:

Re: [Mesa-dev] [PATCH 12/14] swr: build on FreeBSD/DragonFlyBSD

2018-01-18 Thread Greg V
On 01/18/2018 21:01, Emil Velikov wrote: On 31 December 2017 at 16:55, Greg V wrote: (Needs CPU topology detection to actually work) IMHO it might be better to drop the patch, until its actually working. There's little point in building it if one cannot use it.

Re: [Mesa-dev] [PATCH 01/14] util: fix ElfW macro

2018-01-18 Thread Emil Velikov
On 18 January 2018 at 17:59, Greg V wrote: > On 01/18/2018 19:57, Emil Velikov wrote: >> >> On 31 December 2017 at 16:55, Greg V wrote: >>> >>> Elf64_Nhdr exists, Elf_Nhdr does not. >> >> Can you please add a typedef in FreeBSD sources,

Re: [Mesa-dev] [PATCH] r600: enable ARB_enhanced_layouts

2018-01-18 Thread Roland Scheidegger
Looks good to me, seems like you're nearly done with gl 4.5 ;-) Reviewed-by: Roland Scheidegger Am 18.01.2018 um 05:11 schrieb Dave Airlie: > From: Dave Airlie > > Only one piglit test fails, > sso-vs-gs-fs-array-interleave > > There are 3 tests using

Re: [Mesa-dev] [PATCH v2 3/4] meson: fix getting cflags from pkg-config

2018-01-18 Thread Emil Velikov
On 17 January 2018 at 20:54, Greg V wrote: > get_pkgconfig_variable('cflags') always returns an empty list, it's a > function for getting *custom* variables. > > Meson does not yet support asking for cflags, so explicitly invoke > pkg-config for now. That sounds

Re: [Mesa-dev] [PATCH v2 2/4] meson: handle LLVM 'x.x.xgit-revision' versions

2018-01-18 Thread Emil Velikov
On 17 January 2018 at 20:54, Greg V wrote: > When LLVM is built inside of a git repo (even way below, e.g. /usr/ports/.git > exists, and LLVM is built in /usr/ports/devel/llvm50/work), its version > becomes something like 5.0.0git-f8ab206b2176. > > New meson versions

Re: [Mesa-dev] [PATCH] anv_icd.py: improve reproducible builds

2018-01-18 Thread Dylan Baker
Reviewed-by: Dylan Baker Quoting maxin.j...@gmail.com (2018-01-18 03:33:37) > From: "Maxin B. John" > > Sort the output to ensure build reproducibility > > Signed-off-by: Maxin B. John > --- > src/intel/vulkan/anv_icd.py | 2

Re: [Mesa-dev] [PATCH 7/7] android: set '/sdcard/' as MESA_GLSL_CACHE_DIR by default

2018-01-18 Thread Jordan Justen
On 2018-01-15 04:31:43, Tapani Pälli wrote: > This can/should be modified depending on needs. AFAIK by default, > this is the only path that can be read/written to by anyone. > > Signed-off-by: Tapani Pälli > --- > Android.common.mk | 1 + > 1 file changed, 1

  1   2   3   >